wgrantBugSubscription.date_created has tzinfo=UTC03:02
wgrantI thought we mostly used naive UTC datetimes?03:02
wgrantHm, it seems to vary.03:02
StevenKO hai03:52
StevenKwgrant: What do you think of https://code.launchpad.net/~stevenk/launchpad/db-add-audit-spph and https://code.launchpad.net/~stevenk/launchpad/spph-approved_by-model as two thirds of bug 885739?03:58
_mup_Bug #885739: queue and override manipulations should have an audit trail <lp-soyuz> <soyuz-publish> <Launchpad itself:Triaged> < https://launchpad.net/bugs/885739 >03:58
wgrantStevenK: Ah, I was going to talk to you about those.04:01
wgrantStevenK: I think this is another patchwork thing.04:01
StevenKwgrant: Oh?04:02
wgrantStevenK: This is the sort of thing that should probably be on PU04:02
StevenKRight. But it's a bit nasty to get at PU from SPPH, isn't it?04:03
wgrantBut it's difficult because none of this has been designed since 2005, and there's now 5x more of it.04:03
StevenKI agree PU is probably the better place for approved_by04:04
StevenKoverrride_changed_by belongs on SPPH, and I figured out that the date was utterly pointless since a new SPPH is created.04:04
wgrantWe probably want something like ArchiveAudit which BPPH and SPPH reference.04:05
wgrantIt records all the sponsorship etc. crap, along with the PU if present.04:06
wgrantIt also records the details of the operation, for example the fact that the overrides were changed.04:06
StevenKHeh, you mean like SPPH.spondor ? :-)04:06
wgrantRather than making SPPH even more obese for no good reason.04:06
wgrantThat totally doesn't belong on SPPH.04:06
StevenKwgrant: So, can has mumble about ^ ?04:08
wgrantI thought Launchpad had a policy against doing Soyuz correctly.04:08
wgrantThe idea is that $randomperson just adds more columns to random places in the schema until things sort of work.04:09
wgrantStevenK: Anyway, can mumble in a few.04:10
wgrantJust finalising some triggers now.04:10
wgrantDelicious, delicious PL/pgSQL04:10
nigelbSo, that's what wgrant eats for breakfast. Code.04:11
wgrantMy secret is revealed.04:11
StevenKwgrant: A few what?04:21
wgrantHmm, my window decorations have gone missing.04:24
huwshimiwgrant: I'm starting to feel like I'm going to need a hardware "unity --replace" button04:30
StevenKlifeless: O hai04:38
wgranthuwshimi: About half the time my kernel hangs, but the other half I just Ctrl+Alt+F1 and do it there.04:39
huwshimiwgrant: Yeah, that seems about the same as me04:45
StevenKwallyworld_: Would you mind +1ing https://code.launchpad.net/~stevenk/launchpad/kill-spph-ancestor/+merge/94716 ?05:04
wallyworld_StevenK: np, looking now05:04
wallyworld_StevenK: so ancestor is never used anywhere? tests or anything?05:06
StevenKHmmm, it is referenced in the factory05:07
StevenKStill digging05:07
wallyworld_ok, i assume you'll update the branch and then i can +105:09
StevenKwallyworld_: Hah, turns out both wgrant and I were wrong.05:12
* StevenK deletes the MP, since it's dangerous to land and would cause us to lose data05:13
wallyworld_first time for everything05:13
wallyworld_wgrant: how close is your multipolicy-3 branch to being merged?05:21
wgrantwallyworld_: -50 minutes05:22
wallyworld_wgrant: cool. i have a branch that i  need to merge in your changes before i finish05:23
wgrantwallyworld_: That is, it landed 50 minutes ago.05:23
wallyworld_ah, i read '-' as '~'05:24
wgrantSo did StevenK.05:24
wgrantSilly northerners.05:24
wallyworld_we old farts have poor eyesight05:24
wgrantDeclarative factory next week, I think.05:41
StevenKwgrant: Indicies on ArchiveAudit are going to be ... fun05:45
wgrantEasy enough.05:45
wgrantThere's only a single date, and everything else is easy.05:45
StevenKI want an index for every column?05:46
StevenKAside from date, that is05:46
wgrantSo, individual indices aren't immensely useful.05:46
wgrantIndices for individual columns, that is.05:46
wgrantPostgres can sometimes do a reasonable job by ANDing them together. But generally you'd create indices that satisfy the queries that you want.05:47
wgrantWhich is, in this case, none.05:47
StevenKI was attempting to think ahead05:47
wgrantUntil we want to run queries over that table, single-column indices on id and the person FKs are what you want.05:47
wgrant(just enough to satisfy the foreign key constraints in sensible time, since we don't know what sort of queries we want otherwise)05:48
lifelessStevenK: hi, I'm on leave today; if its urgent please give me a ring, otherwise ping tomorrow06:09
StevenKlifeless: Tomorrow is fine06:09
=== almaisan-away is now known as al-maisan
=== al-maisan is now known as almaisan-away
StevenKwgrant: Can I not create a table and add comments to comment.sql in the same patch?07:18
wgrantStevenK: You can.07:20
StevenKpsycopg2.ProgrammingError: schema "archiveaudit" does not exist07:20
wgrantYou're doing it wrong.07:20
wgrantDid you forget to s/TABLE/COLUMN/?07:21
StevenKPerhaps :-)07:21
StevenKwgrant: And I suspect we can ignore adding perms onto archiveaudit until we start to use it07:22
wgrantThe person foreign keys mean that there has to be SELECT and UPDATE on archiveaudit to the person merger.07:22
StevenKWhich runs as launchpad_main?07:23
wgrantHell no.07:23
StevenKI see it07:23
StevenKlifeless: Go away, you're on leave.07:24
stubReviewing PL/SQL code doesn't look any more fun after second coffee.07:26
stubStevenK, wgrant: For person merge, the tests unfortunately still run as launchpad_main I think, and there is a 'person-merge-job' user or similar that is actually used on prod.07:27
StevenKThat is disappointing.07:31
StevenKA quick bzr grep agrees, though.07:32
StevenKHmmm, is bug searching horrible again?07:38
wgrantStevenK: No, should be better than usual, for a couple of reasons.07:41
StevenKwgrant: Keeps timing out for me07:43
wgrantOOPS ID?07:43
wgrantLarge listings are certainly not snappy, but then the dynamic stuff never has been.07:43
StevenKwgrant: https://lp-oops.canonical.com/oops.py/?oopsid=OOPS-732cfe7bfe2e69be0875af0907fee4e107:44
wgrant2.6s here07:45
wgrantStevenK: Still happening?07:47
wgrantI've been idle long enough that I'm on a slave.07:47
wgrantYou're still on the master.07:48
wgrantWhich may be relevant.07:48
StevenKIt just worked.07:48
wgrantThe karma DoS is in progress.07:49
wgrantMay be relevant.07:49
wgrant(it's something like 2000 writes per second at times)07:50
wgrantStevenK: Shouldn't archive, distroseries, pocket be NOT NULL?07:52
wgrantAlso date.07:52
StevenKGood point.07:53
wgrantAnd this shouldn't land until we've got code for everything to populate it.07:53
wgrantSo we can actually be sure it fits.07:54
adeuringgood morning08:53
=== almaisan-away is now known as al-maisan
wgrantstub: Thanks.09:20
wgrantThe DISTINCT ON shouldn't be necessary at all IIRC, except that there's no UNIQUE bugsubscription(bug, person) :/09:21
stubIf there are multiple people with multiple results in there, you might get multiple (bug,person) rows intermixed I think.09:23
wgrantThe join should be unique already, except that the origin table is invalid because of the lack of unique constraint.09:24
wgrant(and there are violations)09:24
stubThere might have been a time we did allow multiple subscriptions from a person. I wonder if person merge can still create them?09:24
wgrantI believe that's how they all came about.09:25
wgrantI suspect it's an oversight rather than a feature.09:25
stubI'd go with the ORDER BY just in case as this is a temporary trigger09:25
wgrantstub: Indeed, wasn't suggesting otherwise :)09:30
wgrantI just added that as a quick hack to workaround the bad data and forgot to make it deterministic.09:31
jelmer'morning launchpadders09:38
danhgMorning jelmer :)09:40
nigelbHI jelmer!10:52
wgrantczajkowski: Those bugs are on some project that someone randomly added to launchpad-project.12:11
wgrantczajkowski: We should get a webops to remove it from the group.12:11
czajkowskiwgrant: context ,ooking at a lotta bugs this morning and trying to work them out12:12
wgrantAh, it was nearly two hours ago now.12:13
wgrantYou triaged three bugs on gazungaos12:13
czajkowskiwgrant: nods the kubuntu folks12:17
czajkowskiwgrant: but yes removing it from the group would be good also12:18
czajkowskithanks sorry being thick, lotta traiging and back and forthh going on this mornign12:18
wgrantHm? Not Kubuntu.12:19
wgrantIt's some random project unrelated to Ubuntu.12:19
=== benji changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: benji | Firefighting: - | Critical bugtasks: 4*10
czajkowskiwhere does the ubuntu bug pull information from for the twitter feed?14:25
deryckadeuring, https://plus.google.com/hangouts/extras/talk.google.com/orange-standup14:34
danilosflacoste, lifeless: hi, I wonder if it would be possible to export a Sprint API function that allows registering people by email address and calls ensurePerson() on that email? we'd want this to integrate better with our summit registration form which already collects a bunch of data about people14:35
abentleyadeuring: lp:~abentley/launchpad/lazr.jobrunner14:46
flacostedanilos: well, we don't want to add the ability to register people in Launchpad without their confirmation15:02
flacostedanilos: so that would either need to be limited to a very specific user15:02
flacostedanilos: or that API should email the user to ask for confirmation15:02
danilosflacoste, right, understood, thanks (that'd be a a simple solution for our integration of registration form/launchpad/summit), but I guess we'll have to fix summit as well :)15:04
danilosflacoste, basically, we have a requirement that whoever registers for our conference has a Launchpad account, but we could only get to the point of them having SSO account15:05
danilosflacoste, we'll have to point them to log into Launchpad before we allow them to register15:05
flacostedanilos: that's interesting15:12
jmlI'm waiting on Launchpad to acknowledge my recent 'push'15:13
flacostedanilos: maybe you could add a ensurePersonFromSSO that would create a LP profile for someone with a SSO account15:13
jmlI've been waiting for some time now15:13
flacostejml: interesting, i think abentley landed some change to the branch scanner15:13
flacostemight be related, although i'm not sure if they were deployed15:13
* flacoste checks15:13
flacosteyep, was rolled out15:14
abentleyjml: what branch?15:16
jmlabentley: lp:~jml/pkgme-service/directory-already-exists15:16
abentleyjml: So I see pushes from 30 minutes ago, but still "Updating branch".15:17
jmlabentley: yeah, I'm waiting for r7315:18
abentleyjml: looking...15:22
abentleyjml: It appears we were just slow.15:28
jmlabentley: thanks.15:28
abentleyjml: There's been pretty heavy traffic on the branch scanner today.  There was a block of 8 jobs that started at 15:05:10 and finished at 15:10:25.  I'm guessing you pushed in that timeframe.15:48
abentleyjml: The next block was a block of 30 jobs that ran from 15:11:09-15:13:43.15:49
abentleyjml: then a futher block of 13 from 15:14:09-15:17:54.15:50
jmlabentley: ah, ok.15:54
danilosflacoste, that'd work for us, should we go that route perhaps?15:55
=== matsubara is now known as matsubara-lunch
flacostedanilos: yes, i think so, the complex bit is in finding out if the email address has a SSO account15:56
danilosflacoste, right, we can't rely on account table anymore15:56
danilosflacoste, do you have any idea on how we could do that? would we need something on the SSO side as well?15:57
flacostedanilos: yes, there might be an existing api for this on canonical-identiy-provider15:58
danilosflacoste, ok, I'll check if there's something along the lines16:05
=== al-maisan is now known as almaisan-away
* czajkowski glares at launchpad and wonders why it has to misbehave! 16:42
=== matsubara-lunch is now known as matsubara
=== deryck is now known as deryck[lunch]
nigelbczajkowski: Remember to ask StevenK about how launchpad is made. he has that long line about everything being held together by strings and jaffa tape.17:18
=== deryck[lunch] is now known as deryck
=== almaisan-away is now known as al-maisan
=== matsubara is now known as matsubara-afk
=== al-maisan is now known as almaisan-away
=== Ursinha_ is now known as Guest34384
flacostegary_poster: any reason why buildout doesn't use the versions specified in setup.py (vs the one in versions.cfg)?20:41
czajkowskiflacoste: evening, good weekend?20:43
flacostehi czajkowski, yes, it was great, went to party at a friend's new appartment on Saturday, how about you?20:44
czajkowskigood thanks, nice weekend went to see a rubgy game, and now working on community council work after dinner20:47
czajkowskiyup the weather is actually improving :D20:51
gary_posterflacoste, not sure, but I think versions.cfg is applied afterwards, so it wins.21:04
flacostegary_poster: ah, right, and you usually don't want to pin in setup.py, so that makes sense21:05
=== almaisan-away is now known as al-maisan
wallyworld_StevenK: wgrant: jcsackett: the trains are not running today and i have to help out my neighbour by driving her kids to school so i'll miss the standup21:32
cr3hi folks, how do you assign the on call reviewer?21:49
lifelessflacoste: hi21:56
flacostelifeless: hang out?21:56
lifelesssending you an invite21:56
lifelessflacoste: it should be in your stream21:57
flacostelifeless: you invited my canonical.com account?21:58
lifelesspossibly not :)21:58
flacostelifeless: got it21:58
cr3benji: ^^^ since you're the on call reviewer, ping :)22:03
benjicr3: we have a schedule, hold on a sec and I'll find it22:04
cr3benji: thanks, I'd like to adopt the same process in our team instead of inventing our own :)22:04
benjicr3: the schedule is at https://dev.launchpad.net/ReviewerSchedule; you may also be interested in http://bradcrittenden.net/post/358363191/getting-your-code-into-launchpad22:08
benjicr3: and this too https://help.launchpad.net/Code/Review22:09
=== benji changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: - | Firefighting: - | Critical bugtasks: 4*10
cr3benji: thanks for all the info, much appreciated!22:11
benjicr3: my pleasure22:11
wgrantlifeless: Why do bugtask inserts take 290ms on prod?22:26
wgrantIs bugsummaryjournal very slow?22:26
flacostelifeless: i think your ISP crashed22:28
lifelessflacoste: bah my adsl22:31
flacostelifeless: yep, i need to go, i suggest we resume that conversation tomorrow?22:31
lifelesswgrant: shouldn't be, is it ?22:32
=== al-maisan is now known as almaisan-away
wgrantlifeless: https://lp-oops.canonical.com/oops.py/?oopsid=OOPS-6e6b4b29ef635939095468528e92c7ec22:35
lifelesswonder if the rollup is honkeydory22:40
lifelessnup 022:40
wgrantlifeless: Huh22:40
wgrantCan you try an EXPLAIN ANALYZE in a txn?22:40
wgrantSee which trigger takes the time.22:41
wgrantI was worried about my trigger adding 0.4ms sometimes22:41
wgrantI see that won't be a problem :)22:41
lifelessif you prep a test I will run it for you22:42
lifelesstoday is not a good day22:42
lifelesswgrant: is our heat logic uncontended yet ?22:42
wgrantlifeless: maxheat is no longer updated or even calculated, and garbo-hourly is doing nothing.22:43
wgrantSo indeed it should be uncontentious.22:43
wgrantbugtask only has three triggers, and bugsummary is the only one that seems like it could really do much.22:44
lifelessis the bug private with a lot of subscribers22:44
wgrantIt's public security.22:45
wgrant11 subscribers22:45
wgrant9 trillion contexts22:45
_mup_Bug #732628: TOCTOU in mount.ecryptfs_private <kernel-cve-tracking-bug> <patch> <eCryptfs:Fix Released by kirkland> <ecryptfs-utils (Ubuntu):Fix Released by kirkland> <linux (Ubuntu):Fix Released> <linux-ec2 (Ubuntu):Invalid> <linux-fsl-imx51 (Ubuntu):Invalid> <linux-linaro (Ubuntu):New> <linux-lts-backport-maverick (Ubuntu):Invalid> <linux-lts-backport-natty (Ubuntu):Invalid> <linux-lts-backport-oneiric (Ubuntu):Invalid> <linux-mvl-dove (Ubun22:45
wgrantLike 14 source packages22:46
wgrantEach with 5 series22:46
wgrantsigh, kernel team abusing packages22:46
kirklandholy smokes22:46
lifelesswgrant: possibly inefficient distro rollup check with each row being in the same distro or something22:48
lifelesswgrant: should be able to reproduce locally. I suspect a bugsummary query inefficiency22:48
wgrantlifeless: Also the kernel team abusing Launchpad22:50
wgrantThat bug has 73 tasks :/22:51
wgrantMaybe I should introduce a limit of 3 package tasks per distro.22:51
wgrantWould only break the kernel team.22:52
wgrantBut would also fix Launchpad.22:52
elmowgrant: how is that "abuse"?22:53
wgrantelmo: It's an order of magnitude more tasks than Launchpad is designed for, because the kernel is duplicated in 13 source packages.22:54
wgrant14, sorry22:55
micahgwgrant: would break transition bugs as well22:55
StevenKpoolie: O hai. A user reported yesterday that http://pad.lv/nnnnn => works fine; https://pad.lv/nnnnn => 404 , is that known?22:56
pooliei guess making it work but with an invalid cert would be a start23:02
wgrantpoolie: Or just get a free StartSSL cert?23:04
wgrantNot sure if IE likes them, but all non-Windows browsers I've run into too.23:04
poolieoh, can you?23:04
pooliei guessed that :)23:04
wgrantTheir web UI sucks, but it works.23:04
poolieis it worth anything?23:05
pooliei guess the browser vendors have decided there is a modicum of security23:05
wgrantIt's probably more secure than most other CAs...23:05
wgrantgiven they all just do hopeless email validation anyway.23:05
wgrantWith the added bonus of being corrupt.23:05
wgrantAh, they have an IE logo, so looks like even IE likes them now.23:06
poolieok i'll see what i can do23:47
pooliefeel free to file a bug against pad.lv if you wish23:47
timrcare people able to create distributed distributions? I'd like to create a full mirror of beta1 our developers can use to bootstrap their live-build images23:49

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!