| wallyworld | sinzui: you available to answer a question? | 01:10 |
|---|---|---|
| * wallyworld goes to have lunch with bigjools | 02:25 | |
| * StevenK stabs mail handling | 03:21 | |
| wgrant | StevenK: Oh? | 03:28 |
| StevenK | Two reasons. 1. Why does LP insist on sending me 5 mails about an MP that I just created and approved, and 2. I can't find what sends mail when a bug you created is marked as a dupe | 03:30 |
| wgrant | StevenK: See BugDuplicateChange in bugchange.py | 03:31 |
| StevenK | Oh fuck me, it's an *adapter* | 03:32 |
| StevenK | I've been looking in model code | 03:32 |
| StevenK | Right, this code is utterly disgusting. | 03:34 |
| lifeless | StevenK: 'notification service' | 03:35 |
| StevenK | lifeless: This is the same argument about bug changes. You don't get mailed about changes *you yourself* performed | 03:36 |
| lifeless | StevenK: actually you do | 03:36 |
| wgrant | Unless you are crazy and ask for them to not be sent. | 03:36 |
| lifeless | StevenK: unless you have a) a new account or b) have turned the option off | 03:36 |
| StevenK | Perhaps we want to drop the number from this notification. | 03:37 |
| wgrant | It's difficult. | 03:38 |
| StevenK | "** This bug has been marked a duplicate of private bug %d" | 03:38 |
| lifeless | StevenK: the bug number they cannot see ? | 03:38 |
| wgrant | Because the notifications are global. | 03:38 |
| wgrant | For branch links it was solved by not notifying about private linkages. | 03:38 |
| wgrant | But that can't be done hter.e | 03:38 |
| lifeless | StevenK: so basically, a) apport is broken, and b) until its fixed we're committed to supporting something insane. | 03:38 |
| lifeless | StevenK: there is an agreed upon fix for apport that pitti will, sometime, get to. | 03:38 |
| wgrant | That's what I said on the call this morning :) | 03:38 |
| wgrant | Anda few months ago] | 03:38 |
| lifeless | StevenK: I think tackling this before that fix is just churn, and hard. But we could do the fix ourselves, its retracer side not on-cd-side | 03:39 |
| StevenK | I'd like to fix this "properly" and not give people links in mail that they can't actually follow. | 03:39 |
| wgrant | Impossible. | 03:41 |
| wgrant | Without rewriting the bug notification system. | 03:41 |
| StevenK | wgrant: Then why didn't you say so on the call this morning? :-) | 03:42 |
| wgrant | Huh? | 03:42 |
| wgrant | I said to kick apport. | 03:42 |
| wgrant | Maybe you discussed this during my fglrx crashes. | 03:42 |
| wgrant | I never heard discussion about changing notifications. | 03:43 |
| StevenK | Possibly | 03:44 |
| StevenK | I said that I'd like to do that on the call and Curtis said it sounded great to him. | 03:44 |
| StevenK | But that may have been the cold and flu meds talking. :-) | 03:45 |
| * StevenK ponders calling this new service 'audit system service' ... changing that into an acroymn as an exercise for the reader | 03:55 | |
| timrc | sinzui, Can I be allowed here? https://launchpad.net/launchpad/+sharing :) pleease | 04:01 |
| StevenK | No, you can't be. | 04:02 |
| StevenK | Not yet. | 04:02 |
| StevenK | lifeless: O hai. Any thoughts on a witty name for this audit service? :-) | 04:03 |
| wgrant | StevenK: Any progress on the AP garbo job tests? | 04:04 |
| StevenK | wgrant: I'd like some help. You mentioned yesterday it might be transaction boundaries | 04:04 |
| wgrant | Break into it after garbo runs with pdb and see what's in the DB. | 04:05 |
| StevenK | I've done printf debugging pulling things from the store | 04:06 |
| lifeless | StevenK: http://pypi.python.org/pypi/auditor | 04:08 |
| StevenK | Not found | 04:09 |
| StevenK | :-P | 04:09 |
| wgrant | We do like stomping on the global namespace, don't we. | 04:09 |
| StevenK | Haha | 04:09 |
| StevenK | Well, like lifeless said, we would like others to use it | 04:09 |
| wgrant | Sure, but we're not the One True Auditor. | 04:10 |
| StevenK | my-first-auditor | 04:10 |
| StevenK | lp-audit-service? | 04:12 |
| wgrant | It's not LP | 04:12 |
| StevenK | I don't want to proclaim canonical- either | 04:13 |
| lifeless | auditord | 04:13 |
| lifeless | auditd | 04:13 |
| lifeless | also unused there | 04:13 |
| wgrant | First fix Python namespacing, then call it lazr.auditd | 04:13 |
| lifeless | there is an auditd in ubuntu | 04:13 |
| lifeless | wgrant: deprecated | 04:13 |
| wgrant | lifeless: Only because Python namespacing is the most awful thing in the world. | 04:14 |
| StevenK | And it doesn't touch zope | 04:14 |
| lifeless | wgrant: it is, and also it is awful | 04:14 |
| lifeless | mcollective-plugins-centralrpclog might be interesting to look at | 04:14 |
| wgrant | It's the most awful thing in the world, and it's also awful? | 04:14 |
| lifeless | yes | 04:14 |
| wgrant | Good good | 04:15 |
| lifeless | excatly | 04:15 |
| lifeless | you could call it scientologyd | 04:15 |
| StevenK | Right. Flights to Christchurch booked. | 04:15 |
| StevenK | Now lifeless will pay. | 04:15 |
| lifeless | when do you want the spare bed put up ? | 04:16 |
| StevenK | Plan is to kick you in the face for that last comment and then fly home. :-P | 04:17 |
| lifeless | well, it audits | 04:17 |
| lifeless | seriously, auditord IMNSHO is fine | 04:17 |
| StevenK | You said auditor first | 04:17 |
| lifeless | I did | 04:17 |
| lifeless | thats fine too | 04:17 |
| lifeless | but the namespace thing is true | 04:18 |
| lifeless | so auditord for the server, probably auditor-client for the client if you decide it needs one | 04:18 |
| lifeless | (I don't think it does) | 04:18 |
| StevenK | I was going to write a module under lp.services that translates a given object into a string represantation of its EID, but I don't think it needs a client, given we can just scream HTTP at it | 04:19 |
| lifeless | yup yup | 04:19 |
| mwhudson | <wgrant> lifeless: Only because Python namespacing is the most awful thing in the world. | 04:24 |
| mwhudson | wgrant: have you written anything in common lisp? | 04:24 |
| lifeless | mwhudson: nothing common about it | 04:24 |
| StevenK | Perl namespacing is pretty good | 04:25 |
| wgrant | Python namespacing is fine, but packaging of it is a nightmare. | 04:25 |
| mwhudson | ah yes, no arguments there | 04:33 |
| StevenK | To be fair, it also omits one of SystemD's greatest strengths: Roman numeral-compliant project naming. System D is obviously way better than System V. | 04:45 |
| StevenK | -- Steve Langasek | 04:45 |
| * StevenK cackles | 04:45 | |
| wgrant | StevenK: Distro quotes section of LWN? | 04:52 |
| StevenK | Yup | 04:52 |
| StevenK | wgrant: http://pastebin.ubuntu.com/864582/ | 04:55 |
| wgrant | StevenK: Diff? | 04:58 |
| StevenK | wgrant: http://pastebin.ubuntu.com/864586/ | 04:58 |
| StevenK | wgrant: Confused yet? | 05:09 |
| * wgrant tries. | 05:10 | |
| StevenK | wgrant: I can push a branch if you wish | 05:11 |
| wgrant | StevenK: Sorry, actally looking now. | 05:22 |
| wgrant | Let's see. | 05:22 |
| StevenK | Hah | 05:24 |
| StevenK | wgrant: Did you get distracted again? | 05:39 |
| wgrant | The tests take about 10 years to run, so yeah. | 05:44 |
| wgrant | Easy to get distracted | 05:44 |
| StevenK | Haha | 05:44 |
| nigelb | Heh | 05:56 |
| === almaisan-away is now known as al-maisan | ||
| wgrant | StevenK: http://pastebin.ubuntu.com/864662/ | 06:28 |
| StevenK | wgrant: It's just the where clause? | 06:32 |
| StevenK | Hm, it's a different query entirely | 06:33 |
| wgrant | StevenK: And I used itertools.product instead of the nested list comprehension. | 06:37 |
| wgrant | I'm not quite sure why the old one wasn't working, and the debug cycle is too slow, so I just rewrote it from scratch instead. | 06:38 |
| StevenK | Hmm, now I get SilentLaunchpadScriptFailure instead | 06:42 |
| StevenK | I HATE debugging garbo failures | 06:42 |
| wgrant | StevenK: make schema to check the security is right? | 06:47 |
| mabac | huwshimi, thanks for reviewing the workitems-widget branch! I'll switch so we have whiteboard first and then the work items text area. and I'll have a go at adding a edit mode message to the whiteboard | 06:56 |
| huwshimi | mabac: OK great! | 06:56 |
| mabac | huwshimi, do you (or anyone else :) have an example of something similar in lp? that is a message that looks or behaves like what you're after? | 06:59 |
| mabac | rats | 06:59 |
| StevenK | wgrant: Interdiff between yours and mine: http://pastebin.ubuntu.com/864684/ | 07:13 |
| StevenK | wgrant: But DistributionAddition gives SilentLaunchpadScriptFailure :-( | 07:13 |
| === wallyworld changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: - | Firefighting: - | Critical bugtasks: 4*10 | ||
| === al-maisan is now known as almaisan-away | ||
| adeuring | good morning | 08:56 |
| mabac | I'm trying to find a way to show a message on blueprints when the whiteboard is being edited. I think I'm on to something using tal:condition in specification-index.pt. Does anyone know how I can detect the state of a TextAreaWidget? | 09:00 |
| mabac | If there's a standard way to do something like this, I'd be happy to learn about that instead. :) | 09:03 |
| === almaisan-away is now known as al-maisan | ||
| === al-maisan is now known as almaisan-away | ||
| === stub1 is now known as stub | ||
| czajkowski | salgado: ping | 10:59 |
| salgado | hi czajkowski | 10:59 |
| czajkowski | salgado: ready for G+ | 11:00 |
| salgado | czajkowski, yep, will be there in a sec. do you have a URL for the hangout? | 11:00 |
| czajkowski | salgado: setting up now | 11:01 |
| mabac | salgado, quick question for you. :) how would you go about displaying a message when the whiteboard is being edited? it's for alerting the user to not put work items in it. | 11:02 |
| mabac | salgado, I've run into a dead end with tal conditionals in the template. | 11:03 |
| salgado | mabac, maybe that text widget thing has a way to specify some help text to be shown below it? | 11:10 |
| czajkowski | salgado: nice to meet you | 11:10 |
| salgado | czajkowski, nice to meet you too, and thanks for the help! :) | 11:10 |
| czajkowski | np | 11:10 |
| czajkowski | once mrevell has the post done I';ll post it to the loco contacts list, add it to my blog so it ends up on the loco radar and then onto jono | 11:11 |
| rick_h_ | morning | 11:11 |
| mabac | salgado, didn't find anything like that. so I'm going for something simple and dynamic. I got a pointer to the js from danilos so I'll try that | 11:13 |
| czajkowski | rick_h_: g'day | 11:15 |
| danilos | mabac, btw, if the JS widget is capable of supporting something, do not hesitate to expose it in the lazrjs.py TextAreaEditorWidget either :) | 11:16 |
| mabac | danilos, ok let's see what I can find :) | 11:17 |
| salgado | mabac, ok, good look with that; notice that after you change anything in a .js file you'll need to run 'make jsbuild' to see them on the browser | 11:28 |
| mabac | salgado, ok thanks. I would have missed that | 11:29 |
| salgado | that's about everything I know about javascript in LP: cover your eyes, make changes, run 'make jsbuild' and hope it will work | 11:29 |
| rick_h_ | :) that'll be easier soon | 11:30 |
| mabac | :) | 11:31 |
| rick_h_ | I've been hacking on tools for that, but a bit complicated to setup atm | 11:32 |
| mabac | salgado, I did this but hiding it when the whiteboard is not being edited got tricky: http://dl.dropbox.com/u/400334/whiteboardnotice.png | 11:37 |
| salgado | mabac, yeah, we'd need to have hooks with the widget to do that, I think. I'm checking the docs of YUI's widget class to see if there's anything there that could be useful | 11:44 |
| rick_h_ | what widget salgado ? | 11:48 |
| salgado | rick_h_, the base for InlineEdit: http://yuilibrary.com/yui/docs/widget/ | 11:49 |
| rick_h_ | ok, so widgets have a ton of events to watch for | 11:49 |
| rick_h_ | looking you *might* be able to watch for the visibleChange attribute? | 11:51 |
| rick_h_ | you're looking to fire something when you click edit right? | 11:51 |
| mabac | rick_h_, yup that'd be good enough | 11:52 |
| rick_h_ | mabac: I'm just not 100% sure that the visible is following the editor part of the widget or not | 11:53 |
| mrevell | salgado, Is launchpad.dev the only place I can play with the work items box? | 11:53 |
| rick_h_ | mrevell: yea, it's through testing/pqm, but don't think it's on qastaging yet | 11:55 |
| rick_h_ | so salgado tests passed and such this morning it looks like | 11:55 |
| mrevell | cheers | 11:55 |
| salgado | mrevell, rick_h_, yes, only launchpad.dev for now. mabac is trying to add a warning to let people know they should not enter work items on the whiteboard | 12:05 |
| === danilo_ is now known as danilos | ||
| mrevell | salgado, Is it not behind a feature flag? | 12:05 |
| salgado | mrevell, nope. do you think it's worth doing that? | 12:06 |
| mrevell | salgado, If it's going to end up on production before it's ready for use, then yes. | 12:07 |
| rick_h_ | mrevell: sorry, that's my confusion | 12:08 |
| rick_h_ | I landed a different branch for salgado yesterday | 12:08 |
| rick_h_ | the work items is still in reivew/changes | 12:08 |
| mrevell | Sorry, I'm confused. So what's landing now? | 12:09 |
| salgado | mrevell, it will not land before it's ready | 12:12 |
| salgado | mrevell, the new UI is still under review | 12:13 |
| mrevell | Gret :) | 12:13 |
| StevenK | Can someone who isn't me log into carob and look at the pqm logs to see what the heck the buildbot-poller is doing? | 12:13 |
| mrevell | Or rather, great | 12:13 |
| === almaisan-away is now known as al-maisan | ||
| rick_h_ | StevenK: where do I look to see "what the heck the buildbot-poller is doing? | 12:16 |
| StevenK | rick_h_: /srv/pqm-logs or some such, there's a log for it | 12:16 |
| StevenK | You may need to sync logs | 12:16 |
| rick_h_ | StevenK: how often does it poll? | 12:18 |
| rick_h_ | StevenK: https://pastebin.canonical.com/61452/ is last bit from the buildbot log | 12:19 |
| StevenK | I was trying to *not* think about how crap buildbot and its poller is at 2320 on a Friday night. :-( | 12:20 |
| StevenK | rick_h_: Sync pqm logs | 12:21 |
| rick_h_ | sorry, someone an expert on buildbot? /me's never used it before until LP so don't know what I'm looking for | 12:21 |
| StevenK | rick_h_: buildbot and buildbot-poller are distinct systems. | 12:21 |
| StevenK | And buildbot-poller was written by us. | 12:21 |
| === matsubara-afk is now known as matsubara | ||
| rick_h_ | so am I looking to sync the buildbot system or a different one? | 12:22 |
| rick_h_ | StevenK: and am I supposed to be looking at something other than /srv/lp-pqm-logs/pqm_logs/buildout.log then for the poller logs? | 12:23 |
| StevenK | rick_h_: That log you pasted is the right one. | 12:24 |
| rick_h_ | ok, requested buildbot sync, not seeing anything new yet | 12:24 |
| StevenK | It will use 'write' to tell you when the sync is completed | 12:24 |
| StevenK | IE, you'll notice. | 12:24 |
| rick_h_ | ah ok | 12:24 |
| salgado | StevenK, does this have anything to do with the fact that devel has not been merged into stable yet? | 12:29 |
| StevenK | That's one of things the poller does, yes. | 12:30 |
| rick_h_ | StevenK: so sync completed, nothing new in the log | 12:37 |
| salgado | StevenK, hmm, my changes were actually committed to ~launchpad-pqm/launchpad/stable before they were blessed by buildbot, it seems. I see them committed ~8h ago | 12:37 |
| StevenK | No, that's because it merged your revision | 12:37 |
| salgado | oh, that's because we pull? | 12:37 |
| StevenK | I'm not sure what the poller does, but it's magical. | 12:37 |
| salgado | heh, ok | 12:37 |
| StevenK | It sends a message to PQM, and it does it. | 12:38 |
| salgado | what's the difference between staging and qastaging? | 12:39 |
| StevenK | staging runs off db-stable, and qastaging runs off stable | 12:40 |
| StevenK | Typical staging is used to test DB changes nowdays | 12:40 |
| StevenK | salgado: production-{devel,stable} from your time are long dead, we deploy to production from stable | 12:40 |
| rick_h_ | Something seems to have kicked, qa bot updated tag/status for my change now | 12:41 |
| rick_h_ | but log still seems same | 12:41 |
| StevenK | rick_h_: Can you kick that manager of yours to do his two items of QA? | 12:41 |
| rick_h_ | StevenK: will do | 12:42 |
| salgado | StevenK, right, makes sense :) | 12:42 |
| === danhg_ is now known as danhg | ||
| deryck | adeuring, abentley, rick_h_ -- hey. firing up hangout. | 14:35 |
| adeuring | ok | 14:35 |
| abentley | deryck: I don't see you. | 14:39 |
| deryck | abentley, hey, are you trying? https://plus.google.com/hangouts/extras/talk.google.com/orange-standup | 14:39 |
| czajkowski | sinzui: have you been spring cleaning the licience reviews? | 14:44 |
| sinzui | I review the all other/* licenses every Friday. I close projects, give canonical project licenses, send out license renewals | 14:47 |
| czajkowski | sinzui: ah ok, as I was waiting on one to change its status and wondered where it had gotten to . | 14:48 |
| sinzui | Today I gave out a license and mark a project approved since it changed their license to gpg affero | 14:48 |
| sinzui | oops | 14:48 |
| sinzui | sorry | 14:48 |
| czajkowski | nods that was the one I was wondering about | 14:48 |
| czajkowski | as you had a note on the whiteboard | 14:48 |
| sinzui | That note was from 2009 I think | 14:49 |
| sinzui | czajkowski, You reported a bug about the batching for all /projects... | 14:49 |
| czajkowski | sinzui: aye as it came via a RT and it does seem rather strange we'd display a negative figure tbh. | 14:49 |
| sinzui | ...only the pathological user with a historical interest will ever use it... | 14:50 |
| czajkowski | ok | 14:50 |
| sinzui | eg me because I read the license info of 5,000 projects when we decided all projects had to have a license | 14:50 |
| czajkowski | heh ok | 14:51 |
| abentley | adeuring: chat? | 15:16 |
| adeuring | abentley: sure. mumble? | 15:24 |
| abentley | adeuring: sure. | 15:24 |
| adeuring | abentley: still there? | 15:31 |
| mabac | rick_h_, salgado I changed the workitems-widget branch a little so it displays a message when editing the whiteboard. I suspect it might be considered somewhat hackish so if you guys would like to have another look, it'd be great. :) https://code.launchpad.net/~linaro-infrastructure/launchpad/workitems-widget/+merge/94790 | 15:33 |
| === al-maisan is now known as almaisan-away | ||
| salgado | mabac, on a call now, will check in a minute | 15:36 |
| mabac | salgado, thanks. going afk now. might be able to check in again later. maybe ping huw if he comes online to have a look too? | 15:37 |
| rick_h_ | mabac: peeking | 15:37 |
| mabac | rick_h_, thanks. if it's to hideous, comment on the mp and I'll deal with it as soon as I can. | 15:38 |
| sinzui | amI online? | 15:41 |
| rick_h_ | yes | 15:42 |
| sinzui | thanks | 15:42 |
| nigelb | sinzui: No :D | 15:44 |
| abentley | adeuring: Internet is back. Shall we try again? | 15:46 |
| adeuring | abentley: sure | 15:46 |
| sinzui | nigelb, :) | 15:50 |
| nigelb | :D | 15:51 |
| === matsubara is now known as matsubara-lunch | ||
| mabac | rick_h_, salgado just wanted to check back in. is there a verdict? :) | 16:17 |
| rick_h_ | mabac: not a huge fan of the hook at the moment. I'm going to propose an alternative. I need to get a checkout and play with it a little bit. | 16:18 |
| jelmer | abentley: btw, nice to see ec2 moved | 16:18 |
| jelmer | I was wondering if we should put lp-dev-utils in the launchpad PPA | 16:18 |
| salgado | mabac, I'll defer to rick_h_ on this one as I know close to nothing about YUI and LP's widgets | 16:19 |
| rick_h_ | mabac: personally the editor needs to provide an event you can just listen for. It seems it doesn't right now, so I want to add it | 16:19 |
| mabac | rick_h_, thanks, that'd be great. any help is very welcome on this. | 16:19 |
| rick_h_ | mabac: thanks for your patience | 16:20 |
| mabac | salgado, it's obvious from my patch that I have no clue. :) | 16:20 |
| mabac | rick_h_, no problem. I spent too much time to get that hack working so I'm happy you want to assist me. I'll pop out for the weekend then. | 16:21 |
| abentley | jelmer: I guess that gives it a better install story, but I think there's a bunch of packaging needed. | 16:21 |
| salgado | mrevell, you didn't forget that text for the help popup, did you? ;) | 16:44 |
| mrevell | I did not salgado :) | 16:44 |
| salgado | mrevell, if we could get it by Monday it'd be great; no need to hurry too much | 16:44 |
| mrevell | I started later on it that I'd have liked but it's under way. | 16:44 |
| mrevell | No prob | 16:44 |
| salgado | mrevell, great, thanks! | 16:45 |
| salgado | hmm. I've got a job on the garbo hourly script and it doesn't seem to be running enough iterations of it for the whole work to be done | 17:13 |
| salgado | my job runs for only a couple minutes | 17:13 |
| salgado | is there a limit on the time or number of iterations that I'm not seeing? | 17:14 |
| salgado | lifeless, around? | 17:18 |
| salgado | anybody up for a quick review? https://code.launchpad.net/~salgado/launchpad/workitem-migration-allow-inactive-milestones/+merge/95624 | 17:32 |
| === matsubara-lunch is now known as matsubara | ||
| sinzui | salgado, what happens the work items when I make their active milestone deactivated (untargetable) | 17:56 |
| salgado | sinzui, there should be no milestones to which a WI cannot be targeted | 17:57 |
| salgado | that's what I'm changing, so that they can be targeted to inactive milestones | 17:58 |
| === deryck is now known as deryck[lunch] | ||
| * sinzui looks again | 17:58 | |
| sinzui | ah | 17:58 |
| salgado | sinzui, the UI/DB allows that (I confirmed a few minutes ago); it's just the migrator script that was broken | 17:58 |
| sinzui | Right. Lp UI often does not permit it, but the API will let you do it | 17:59 |
| sinzui | salgado, r=me | 18:00 |
| salgado | sinzui, also, I'm thinking of moving the migrator script from garbo-hourly to garbo-frequent as it takes a couple minutes on the first 2 or 3 runs and then will run much faster than that. does that sound ok to you? | 18:00 |
| sinzui | yes | 18:01 |
| salgado | sinzui, do you mind if I sneak that change in this same branch? | 18:01 |
| sinzui | no | 18:01 |
| salgado | sinzui, great, if you could have another look there ;) | 18:02 |
| salgado | come on, LP, update my diff | 18:03 |
| sinzui | still looks okay | 18:04 |
| sinzui | I'll just add a comment to the review | 18:04 |
| salgado | sinzui, great! can you land it for me as well? | 18:05 |
| sinzui | yes | 18:05 |
| salgado | sinzui, superb, thanks a bunch! | 18:05 |
| === salgado is now known as salgado-lunch | ||
| rick_h_ | salgado-lunch: ping when you get back | 18:17 |
| lifeless | salgado-lunch: hi | 18:59 |
| === deryck[lunch] is now known as deryck | ||
| === salgado-lunch is now known as salgado | ||
| salgado | rick_h_, hi | 19:22 |
| rick_h_ | salgado: howdy, so I replied to mabac's MP | 19:22 |
| rick_h_ | salgado: I just wanted ot make sure it made sense, and since it seems we're off on TZ, wasn't sure if I should ping/update you on it to help with him | 19:22 |
| salgado | rick_h_, I agree with you that it's probably better to do it in specification-index.pt instead of trying to generalize it at this point | 19:26 |
| rick_h_ | salgado: ok cool. Sorry to make trouble/more work | 19:27 |
| rick_h_ | salgado: totally not against adding a generate notification to the editor, but want ot be more thorough on it as a longer term thing | 19:27 |
| salgado | rick_h_, I completely understand that :) | 19:28 |
| rick_h_ | cool, so hopefully that diff helps makes the fix simple, that's working and tested from his branch | 19:29 |
| rick_h_ | just have to undo the other stuff | 19:29 |
| salgado | rick_h_, you're giving us code that's simple and documented; it's a huge help! | 19:31 |
| salgado | I'm sure mabac will be thankful, and so am I :) | 19:31 |
| jcsackett | abentley (or anyone): you know that thing where lp-propose stops using the template from lpreview body? how does one go about fixing that? :-P | 19:59 |
| abentley | jcsackett: first, run "bzr plugins -v" to ensure lpreview body is installed, and running from where you expect. | 20:00 |
| jcsackett | abentley: confirmed; it's installed and running from my .bazaar/plugins | 20:02 |
| abentley | jcsackett: now try running lp-propose and see if the target branch matches "lp:(~launchpad-pqm/)?launchpad(/(db-)?devel)?" | 20:03 |
| jcsackett | target is lp:launchpad | 20:04 |
| jcsackett | hrm. that's the same branch, but not a mach for that format. | 20:04 |
| jcsackett | oh, wait, i may have misread that regex. i think that is a match. | 20:05 |
| abentley | jcsackett: Hrm. I think the displayed target branch is not what it checks against. | 20:06 |
| jcsackett | abentley: ah. | 20:08 |
| abentley | jcsackett: So the submit branch's public URL should match 'bzr\+ssh://bazaar.launchpad.net/~launchpad-pqm/launchpad/(db-)?devel' | 20:10 |
| jcsackett | abentley: ok. | 20:10 |
| jcsackett | abentley: as in the setting in locations.conf? | 20:10 |
| abentley | jcsackett: Yes, though bzr info will tell you what bzr thinks the setting is. | 20:11 |
| jcsackett | abentley: ok, the submit branch had gotten borked when i mucked with my locations the other day. stuff works now. | 20:14 |
| jcsackett | thanks! | 20:14 |
| abentley | jcsackett: np | 20:14 |
| sinzui | jcsackett, r=me | 21:18 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
