[00:19] StevenK: I -really- prefer stub to get a lookin with the narrow exception of him being away for an extended period; he is back today. [00:21] lifeless: I would have really prefered to already have it landed, but you disappeared yesterday afternoon. Fine, I will wait for stub. [00:22] StevenK: I EOD'd at 1700 here :) [00:22] StevenK: and cynthia has a cold, so it really was EOD [00:22] StevenK: in any event, I would have said the same thing yesterday [00:27] so bigjools, tell me about messaging servers [00:32] Do we have some report that reports if any patch in db-stable/devel isn't applied to prod? [00:49] no, but we have a bug asking for one [00:52] wgrant: Product done. Would about Distribution? [00:53] StevenK: Yes [00:53] Bah, okay. [00:54] You expected otherwise? [00:54] I didn't, actually. [01:23] wgrant, wallyworld__: https://code.launchpad.net/~stevenk/launchpad/product-distribution-accesspolicy/+merge/96499 [01:25] * wallyworld__ has a look [01:27] StevenK: you probably also need to create a proprietary policy when a product has a commercial subscription created for it [01:30] Hmmm [01:31] wallyworld__: So I'm not sure if products go from non-commercial to commercial, or if they are created as commercial [01:32] StevenK: i *think* they are created as non commercial and then the subscription is added by an admin [01:32] ? [01:33] * StevenK can't see what method on IProduct is called for that. [01:34] i don't think it's on IProduct [01:35] StevenK: didn't you add a factory method to create a subscription? [01:35] That just creates a CommercialSubscription [01:36] We don't have CommercialSubscriptionS{et,ource}, just it. [01:37] i think redeemSubscriptionVoucher does it perhaps? [01:37] which is on IProductPublic [01:37] Have you managed to read that function without your eyes bleeding? [01:37] not yet [01:38] yes, it looks like that is the one [01:39] Right [01:39] The garbo job doesn't handle that process either [01:40] not sure what to do when the subscription expires though. do we remove the policy? [01:40] Right, that's the tricky question. [01:40] wgrant: ? ^^^^ [01:42] wallyworld__: We don't know how that will work yet. [01:42] wallyworld__: This is just for the initial migration. [01:42] ok, just checking :-) [01:42] At what stage we create the policies once the New World is complete, we don't know. [01:43] lifeless: helleau [01:43] bigjools: hellauo [01:44] like the accent [01:44] what do you want to know then? [01:45] were they useful, what interface did they have, would you use one again, and whatever you think I should know about them [01:46] wgrant: so, for StevenK's branch, do we want to add a proprietary policy when a voucher is redeemed? [01:46] wallyworld__: No, proprietary doesn't exist yet. [01:46] wallyworld__: We'll redefine at what point any policies are created at all later on. [01:47] The first step is to get bugs onto the new model, which just needs these two created at all times. [01:47] ok. the current work i've done in the ui shows proprietary as an option in the disclosure picker for commercial projects [01:47] This is just a dirt cheap way to achieve that. [01:47] bigjools: can go voice if that would be easier ;) [01:47] lifeless: can do [01:47] lifeless: I'll make it quick - I am starving :) [01:48] skype/hangout? [01:48] StevenK: r=me [01:49] lifeless: I'll skype you [01:50] lifeless: well I would do if you were on [01:50] ah skype is being crap [01:52] I despair about my ADSL [01:53] I despair about random desktop lockups [01:54] lifeless: In your case, the A is not Asynchronous, but Abominable. [01:56] lifeless: frozen [02:00] lifeless: for f.... [02:03] lifeless: reliable internets in NZ then? [02:03] will be if you answer, switching to tablet's skype rather than faildsl [02:04] lifeless: not geting your call [02:04] tried to call you and you didn't answer either :) [02:44] StevenK: Any test failures from that branch yet? [02:44] StevenK: I'd expect some in test_bug_mirror_legacy_access_triggers [02:48] wallyworld__: are you at home? [02:48] yeeees? [02:49] * wallyworld__ is nervous now [02:49] wallyworld__: eeeexcellent, can I pop round in a bit and print and scan sumting pleez :) [02:49] it will cost you [02:49] wine? [02:49] I can pay in wine [02:49] we'll discuss it [02:51] ooerr missus [02:51] * bigjools out [03:19] could someone check out my headers and see if im missing anything when doing an authenticated call to me?ws.op=searchTasks? http://pastebin.ubuntu.com/873995/ [03:20] it times out, but doing an anonymous call works [03:25] i dont have OAuth realm="https://api.launchpad.net/" but that is optional according to the oauth specs [03:26] wgrant: StevenK: what would i need to do to get a review of a branch which merely renames stuff, but the line count is high [03:26] timeout -> do you get an OOPS in the response headers ? [03:26] wallyworld__: Beg. [03:26] lifeless: yea [03:26] ... which is ? [03:26] * wallyworld__ is on his knees [03:27] https://code.launchpad.net/~wallyworld/launchpad/fix-sharing-terminology-948083/+merge/96506 [03:27] lifeless: one sec :) [03:27] lifeless: apparently a code update is in progress at this very moment [03:28] im not sure how long those take [03:30] stokachu: you're testing on staging ? [03:30] lifeless: yea [03:30] try qastaging [03:30] ok [03:30] it should be up [03:31] lifeless: OOPS-7f4c62461a1ee30fcb05df7f03a8a3ef [03:31] lifeless: fwiw i just tried on production and it worked [03:33] Heh, GitHub seems to have lost all their CSS [03:33] they had ssh problems earlier [03:33] stokachu: Bug searches except in small projects will tend to time out on staging. [03:33] wgrant: So I have an attribute that requires view to see and edit to change. Do I need a decorator for that? [03:33] And qastaging. [03:33] StevenK: That applies to most attributes in Launchpad. [03:33] StevenK: It goes on IBugView [03:34] We don't usually use interfaces to specify edit permissions. [03:34] wgrant: ok, is this not the correct approach i should take then? [03:34] wgrant: Okay, so the IBugEdit I'm making is pointless? [03:34] StevenK: Although in some simple cases (eg. if launchpad.Edit grants edit privileges on everything that launchpad.View can see) you can use interfaces. [03:34] StevenK: IBugEdit would conventionally be things that you require launchpad.Edit to see. [03:34] stokachu: I don't know... what are you trying to do? :) [03:35] wgrant: There's a bunch of methods you need .Edit to call [03:35] wgrant: im just trying to get my profile and see bugs (public/private) im assigned to [03:35] StevenK: Then they belong on IBugEdit [03:35] so far ive just been investigating searchTasks [03:35] Also, it should be illegal to have two people talking with the same first two letters. [03:35] then ill append like &assignee='adam-stokes' ? [03:35] One of you needs to go awawy :) [03:35] LOL [03:36] it is getting late i could go play some dawn of war [03:36] stokachu: So, if you just want assigned bugs, specify assignee=, yeah [03:36] Let's get stub in here too! [03:36] Then we can have three! [03:36] stokachu: By default it will do things like search by bugs you've commented on. [03:36] stokachu: Which can be very very slow. [03:36] wgrant: ah ok [03:37] stokachu: so yeah, thats a simple code/performance issue for us [03:37] so with assignee can it be just my name? like searchTasks&assignee=adam-stokes [03:37] stokachu: however [03:37] User: Anonymous User [03:37] DB id: Anonymous [03:37] stokachu: Probably needs to be assignee=/~admin-stokes [03:37] -> it hasn't logged you in [03:37] Er [03:37] s/admin/adam/ [03:37] wgrant: ok :) [03:38] lifeless: ah i didn't get new credentials on qastaging [03:38] can never have to many staging servers i guess :) [03:38] stokachu: so you probably should if you want confirmation that the auth works ;) [03:38] lifeless: haha ok ill re-auth, in your opinion is it better to test against qastaging or staging? [03:39] i dont want to anger the gods by messing with production [03:40] you can use either [03:40] ok cool.. thanks for everyones help :D [03:41] wallyworld__: I think this branch I'm in the middle of will turn out bigger. [03:43] wallyworld__: addPillarSharee -> sharePillarInformation? [03:43] I've already tried to make nouns out of these; it doesn't work well :) [03:43] wgrant: that sounds reasonable [03:43] i have bigjools here at the moment [03:43] wallyworld__: Why did you remove 2011 from the copyright in sharingservice? [03:43] because i only started that file in 2012 [03:43] But it's a renamed file :-) [03:44] the original file was started in 2012 also [03:44] Not according to the copyright :-) [03:44] it was just a drive-by [03:44] the copyright was originally wrong [03:44] cut and paste [03:44] from elsewhere [03:44] Fine [03:44] I was mostly trolling [03:45] :-) [04:06] Hmmmm. [04:07] A bunch of methods that are in IBugEdit are mutators for properties in IBugView. [04:07] I might split them all out into IBugPrivacy [04:14] confused [04:14] StevenK: What? [04:17] wgrant: So private and security_related are defined in IBugView, but there are few methods in IBugEdit that opperate on them [04:18] Same for duplicateof, which is in IBugView, but markAsDuplicate is in IBugEdit and marked as a mutator of it. [04:20] StevenK: Right, that's normal. [04:21] Or does lazr.restful really not like cross-interface mutator_fors? [04:21] It should work... [04:21] As long as you define them in the right order/ [04:22] wgrant: pyflakes is complaining [04:22] Oh? [04:22] lib/lp/bugs/interfaces/bug.py:840: undefined name 'private' [04:22] lib/lp/bugs/interfaces/bug.py:841: undefined name 'private' [04:22] And so on [04:23] Well, yes, that's not going to work. [04:23] IBugView['private'] [04:23] This is Python, not magic :) [04:23] haha [04:23] But, it should be! [04:24] bigjools has left the building [04:26] Right, fixed.\ [04:26] So now pyflakes is happy. [04:26] * StevenK tries 'make' [04:28] @mutator_for(IBugView['private']) [04:28] File "/home/steven/launchpad/lp-sourcedeps/eggs/zope.interface-3.5.2-py2.6-linux-x86_64.egg/zope/interface/interface.py", line 552, in getDescriptionFor [04:28] raise KeyError(name) [04:28] KeyError: 'private' [04:28] IBugPublic['private'] [04:29] Oh damn it, I should have realised that myself. [04:32] wallyworld__: back now and I can't stop thinking about your special offer === jtv1 is now known as jtv [04:33] Oh, bwahaha [04:34] * StevenK tries VERY hard to not quotefile that comment [04:34] wgrant: http://pastebin.ubuntu.com/874044/ Zope hates me [04:34] bigjools: i've been thinking about you too [04:34] and other things beginning with w [04:35] watermelon! [04:35] StevenK: One of your interfaces probably inherits another one. [04:35] StevenK: That is wrong. [04:35] And bad and evil. [04:35] And won't even work. [04:35] I don't think [04:35] so [04:36] wgrant: http://pastebin.ubuntu.com/874045/ [04:36] Perhaps the wrong interface is inherited IPrivacy? [04:36] StevenK: Recall that one of those interfaces redefines bits of IPrivacy [04:37] So declaring access on both won't work. [04:37] Right, and linked_branches is probably in the exactly same boat [04:37] I would assume so. [04:44] wgrant: Working, but I'm not sure about IBugPublic inheriting from IPrivacy. [04:45] It's fine if it's OK. [04:45] wgrant: are you or anyone else able to see private bugs assigned to me specifically? [04:45] i keep pulling up 0 bugs [04:46] stokachu: How are you filtering to private bugs? [04:47] 'request' => 'GET /1.0/~adam-stokes?ws.op=searchTasks&assignee=https%3A%2F%2Fapi.launchpad.net%2F1.0%2F%7Eadam-stokes [04:47] thats my urlencoded request being made, after ive retrieved my oauth token [04:50] http://pastebin.ubuntu.com/874054/ heres my full response request [04:50] stokachu: https://launchpad.net/api/1.0/~adam-stokes?ws.op=searchTasks&assignee=https%3A%2F%2Flaunchpad.net%2Fapi%2F1.0%2F~adam-stokes shows a private bug for me (it uses normal webapp cookies, so you can use your browser rather than an OAuth client) [04:50] So I suspect you're not authing properly. [04:52] stokachu: Alternatively, are you sure you authorized your token for private data? [04:52] hmm I have a header defined with my Authorization credentials [04:52] i used the change anything button [04:52] That should be fine. [04:52] What happens if you just "GET /1.0/~" with appropriate auth headers? [04:53] Hm [04:53] I'd expect the Authorization header to start with 'OAuth ', I think. [04:54] so OAuth realm is not optional? [04:54] wgrant: I'm getting a bunch of ForbiddenAttribute failures, including one that is in the ZCML, but not the interface. [04:54] http://pastebin.ubuntu.com/874061/ here is the response to a /~ [04:56] stokachu: That's a response to /~adam-stokes [04:56] stokachu: Which? [04:56] Bah [04:56] StevenK: Which? [04:57] Oh, hahaha. maybeConfirmBugtasks is listed in the ZCML, not in the interface, but is defined in the model. [04:57] stokachu: 'OAuth realm' isn't an atom. 'OAuth' is the authorization scheme, realm is a field like oauth_nonce [04:57] wgrant: ForbiddenAttribute for things like name, tags, date_last_updated [04:57] You may be able to omit the realm field [04:57] StevenK: On what operation? [04:58] current_bug.date_last_updated = now [04:58] ForbiddenAttribute: ('date_last_updated', ) [04:58] StevenK: Right, you need to define set_schema or set_attributes [04:58] wgrant: http://pastebin.ubuntu.com/874063/ :( [04:58] stokachu: That's more like it [04:58] wgrant: I should keep the enormous list of set_attributes for lp.Edit? [04:58] stokachu: Prepend 'OAuth ' to your Authorization value [04:59] StevenK: Probably, yes. [04:59] StevenK: Note that some of them are obsolete. [04:59] Particularly on BugTask [04:59] Attributes that don't exist any more. [04:59] I'll try setSchema IBugView [05:00] No. [05:00] Unless all those attributes were formerly settable. [05:00] But I suspect they were not. [05:00] You spoil all of my fun [05:00] See Branch for a reasonable example of how to do things. [05:00] But okay, grabbing the list [05:02] I think it's only hits{,timestamp} [05:02] Oh, community{score,timestamp} [05:03] See what I mean? [05:03] And a few others [05:03] Right, so there's 9 left [05:03] I think that's a reasonable list [05:03] Most should have setters. [05:03] So not too many should need naming explicitly. [05:05] SUCCESS! [05:05] Hm, this branch isn't too bad. It's just going to be hell to get reviewed. [05:05] stokachu: It works better when you specify an auth scheme? :) [05:06] wgrant: lol sooo much better [05:06] wgrant: My branch that makes ProductSet add AccessPolicy fails with missing db perms. :-( [05:06] StevenK: I am unsurprised. [05:06] StevenK: Grant INSERT on AP to anything with INSERT on Distribution or Product [05:06] Problem solved. [05:07] That's disgusting. [05:07] But yeah. [05:09] Looks like just write and updateremoteproduct [05:09] Oh, bah [05:10] Forgot to add maybeConfirmBugtasks to IBugSomething [05:33] wgrant: I think I've got it working. [05:33] Which is kind of awesome, considering what I did to IBug. [05:35] :) [05:36] Sadly, the branch is 1215 lines, but I don't think that can really be helped given just how big IBug is. [05:38] Indeed. [05:38] I won't kill you. [05:38] Oh, are you offering to review it, then? :-) [05:38] Depends on when it's proposed :) [05:38] I'll be reading the diff anyway... [05:39] Passed tests: 1159 [05:39] Failed tests: 2 [05:39] 1 failed test due to the fact that the stream is still being written to, and another which I've fixed. [05:40] I think that's enough to prove the changes are okay enough to toss at ec2. [05:42] Sounds reasonable. [05:43] I'm not in danger of the instance terminating after 20 minutes because make failed, or getting the dreaded message that it tried to send a mail and failed because the message was so damn large. [05:48] wgrant: https://code.launchpad.net/~stevenk/launchpad/force-ibug-into-line/+merge/96513 [06:02] linux_source_bug_dupe.syncUpdate() [06:02] ForbiddenAttribute: ('syncUpdate', ) [06:02] I can't see syncUpdate() in either the model or interface, but the ZCML allows it. [06:03] StevenK: Done [06:03] syncUpdate is probably an SQLObject method [06:03] Anything using it is probably wrong [06:03] Delete the call and see if the test still works. [06:04] There's a bunch of them [06:04] Does the test explain why they're there? [06:05] I've not checked, just noticed they were failing [06:05] No [06:05] So, delete them. [06:05] Flushes are largely implicit now. [06:05] wgrant: maybeConfirmBugtasks is in the model, and was in the ZCML, so by rights it should be on the interface? [06:07] StevenK: You're probably not going to be confirming tasks due to an edit if you can't edit the bug. [06:08] Hmmm, it's only called by the bug model itself [06:08] Not by BugTask? [06:09] No [06:09] So kill it from the interface. [06:09] Are there any plans to rename the arm restricted arch family to armel? [06:10] It's unprecedented manual SQL with minimal benefit. [06:10] Doable, but there are no plans. [06:11] How much trouble would it be to do? With it being 'arm' currently, I have to special case the arch in our automated project setup code. [06:11] wgrant: personIs{DirectSubscriber,AlsoNotifiedSubscriber,SubscribedToDuplicate} were also declared under IBugSet, their docstrings meantioned IBug and they were in IBug's ZCML. [06:12] bigjools: Around? [06:12] yes [06:12] wgrant, or alternatively, would it be possible to introduce armel and just leave arm there as legacy? [06:12] cody-somerville: No [06:13] bigjools: UPDATE processorfamily SET name='armel' WHERE name='arm'? [06:13] (see above) [06:13] * bigjools tries to think what that will break [06:13] The DAS archtags are already all armel. [06:14] yeah [06:14] The only people it can break are commercial admins. [06:14] And I don't care about them :) [06:14] pfff [06:14] wth can see proc family? [06:14] But PFs should not change. :-( [06:15] y'know [06:15] this should not change, as StevenK says [06:15] Why not? [06:16] It's wrong, and nothing except the UI and API use the anem. [06:16] name [06:16] why is there not an armhf? [06:16] There is an armhf. [06:16] arm is armel [06:16] armhf is armhf [06:16] oh ok - feh I was looking at dev data not prod [06:17] 6 | arm | ARM Processors | The ARM family of processors, primarily used in embedded applications. | t [06:17] 9 | armhf | ARM hard float processors | ARM processors with an FPU | t [06:17] File "/home/steven/launchpad/lp-branches/force-ibug-into-line/lib/lp/bugs/model/bug.py", line 2071, in _markAsDuplicate [06:17] duplicate_of.maybeConfirmBugtasks() [06:17] ForbiddenAttribute: ('maybeConfirmBugtasks', ) [06:17] wgrant: ^ [06:18] That is what prompted me to add it to the interface. [06:18] StevenK: Ah, of course. It's called from the other bug. [06:18] Also, does anyone know why https://api.launchpad.net/1.0/unr/+milestone/unr-9.10 is returning a HasBug object instead of Milestone object? [06:18] wgrant: ok do it [06:18] cody-somerville: launchpadlib is thpecial [06:19] wgrant: Okay, I'll re-add it to the interface. [06:19] wgrant, lol. say again? [06:19] cody-somerville: unr is a project group [06:19] Project groups are evil. [06:19] Don't do it :) [06:22] wgrant: So I drop IBugAdmin, where should heat_last_updated and setHeat() go? [06:23] StevenK: Well, I was going to say to just drop them from the interface. But setHeat seems to be entirely unused. [06:23] Except by tests. [06:23] And heat_last_updated is used by garbo [06:23] Yes. [06:23] what download limits does internode have? [06:23] But not through the interface. [06:23] bigjools: About 10 different ones. [06:24] wgrant: Right, so I should remove the setHeat tests and then IBugAdmin can just die? [06:24] Ranging from probably 10GB to a terabyte. [06:24] oh well, hope I don't blow this place's limit [06:24] You can probably ring up and ask [06:24] StevenK: Assuming the tests aren't doing anything interesting, yep. [06:25] wgrant: It seems to just be doc/bug-heat.txt [06:27] wgrant: So I can drop those sections of the doctest [06:27] StevenK: Sounds reasonable. [06:29] cody-somerville: Should be renamed. [06:29] wgrant, Okay, thanks. [06:30] wgrant: is there a broadband comparison/guide site that lists all providers instead of just the crappy ones? [06:31] Haha [06:31] bc.whirlpool.net.au [06:31] Although I can't talk to it... [06:32] Whirlpool down. That's amusing. [06:32] broadbandguide is a joke [06:33] Looks like it's been down for about 15 minutes. [06:33] bigjools: I heard broadband down there is a joke anyway ;) [06:33] How odd. [06:34] nigelb: an ISP walked into a bar ... [06:34] hehe [06:35] wgrant: Now where people complain about NBN? [06:35] Coalition headquarters? [06:35] Haha [06:36] Which is even more pointless than complaining about it on Whirlpool. [06:39] odev setup, why u wear out my ssd [06:51] wgrant: I've had to remove a bunch of bug-heat.txt [06:57] Ah crap. I need IHasLinkedBranches on IBugView due to linked_branches, but that causes a test failure because linkBranch and unlinkBranch require Edit [06:59] StevenK: Probably best to have IHasLinkedBranches inherited by IBug directly, and name the attributes in configure.zcml [07:01] bigjools: Whirlpool is back, btw [07:01] wgrant: yeah looking at it [07:02] wgrant: it's a bit confusing for a newb [07:02] I dunno what half the terms are [07:04] bigjools: Did you search? [07:05] StevenK: for what? [07:05] bigjools: From bc.whirlpool.net.au there's a "or your can search for ..." which is a link [07:05] wgrant: http://pastebin.ubuntu.com/874142/ [07:06] wgrant: Oh, this is not helped that IBugView has its own definition of linked_branches [07:06]