| karni | nhaines: Where you expecting those mp3's some time ago? | 01:45 |
|---|---|---|
| karni | :) | 01:45 |
| karni | nhaines: How are things? :) | 01:45 |
| nhaines | Hey! :) Well, U1 is always slow but it was cool because the 199 files counter decremented.... but in the next update it was back to 199! | 01:48 |
| nhaines | Everything's great, how're you? :) | 01:48 |
| karni | nhaines: huh, I guess that's not cool | 01:57 |
| karni | nhaines: About to end my day and starting holiday tomorrow (at least theoretically). Practically (no turning back!) on Friday, when I'm leavning snowboarding in south of France. | 01:58 |
| karni | nhaines: My eyes hurt a little, I'll be leaving soon. I'm happy all's good on your side :) | 01:59 |
| snickers_ | Hello, Is anyone over here that can help me | 08:12 |
| === zyga-xchat is now known as zyga | ||
| JamesTait | Morning all! :D | 09:33 |
| mandel | morning all! | 09:36 |
| === pedronis_ is now known as pedronis | ||
| === zyga-xchat is now known as zyga | ||
| === zyga-xchat is now known as zyga-afk | ||
| gatox | morning | 11:14 |
| mandel | gatox, morning! | 11:22 |
| gatox | mandel, how are you? | 11:23 |
| mandel | gatox, fine, getting the proxy stuff together at a good speed :) | 11:23 |
| gatox | mandel, great! | 11:23 |
| mandel | gatox, is certainly an interesting job,and you? | 11:25 |
| mandel | gatox, how is the qt work treating you? | 11:26 |
| gatox | mandel, i've to do some interesting qt tunning now...... and about health: about to die jeejej | 11:26 |
| mandel | gatox, really? what have you done? | 11:29 |
| gatox | mandel, i bought some medicine for the fever....... i almost couldn't sleep last night :S | 11:29 |
| mandel | gatox, wtf are you doing here then!!! | 11:32 |
| mandel | gatox, take sick days! | 11:32 |
| gatox | mandel, yes.... i'm going to wait for roberto and ask him | 11:32 |
| mandel | gatox, well if you are sick, don't ask, you will need some doctors thing and that's about it | 11:33 |
| gatox | mandel, yes, i understand.... but i don't want just to leave :P jeje he will be around soon | 11:35 |
| gatox | ralsina, ping.... just in case :P | 11:35 |
| === zyga-afk is now known as zyga | ||
| nessita | buenos días! | 12:20 |
| gatox | nessita, hi | 12:22 |
| nessita | hola gatox | 12:22 |
| nessita | gatox: yesterday I forgot to mention that the button specialization you do has to be in ussoc | 12:22 |
| nessita | gatox: since we'll need it for both | 12:23 |
| gatox | nessita, yes... i'm working in a generic button in this moment..... not in any of the projects..... and it has its problems..... i'm looking how to fix this things | 12:23 |
| nessita | gatox: oh | 12:23 |
| gatox | i found out where is the problem really | 12:23 |
| gatox | for any button | 12:24 |
| nessita | gatox: what kind of problemas? | 12:24 |
| gatox | nessita, basically..... with a custom button..... we are having the same result.... because we are adding a padding to the button in order to see it big and with rounded corners, etc..... and THAT padding is the one that is compressing the selection area | 12:25 |
| gatox | and if you add a qlabel.... the problem is the same.... and if you try to add padding to the qlabel inside the qpushbutton (for the custom button)..... the text looks compressed because the button don't realize of the change | 12:25 |
| nessita | gatox: what if you add padding to both? | 12:26 |
| gatox | nessita, nessita, the same problem..... if we want to highlight all the widget, the button shouldn't have padding | 12:26 |
| gatox | you can see how all the button is highlighted if you remove the padding properties in the qpushbutton qss | 12:26 |
| gatox | nessita, also.... i don't know if you read lisetttte email.... but there she propose another kind of highlighting | 12:27 |
| nessita | gatox: let's go by parts: I wonder, you said that "if you try to add padding to the qlabel inside the qpushbutton (for the custom button)..... the text looks compressed because the button don't realize of the change", | 12:27 |
| gatox | nessita, yes.......... the button doesn't expand based on the label property | 12:28 |
| nessita | gatox: so what if besides adding padding to the label, you also add the same padding to the button, so it expands accordingly | 12:28 |
| nessita | gatox: did you try that? | 12:28 |
| gatox | nessita, yes.... that is what i answer before.... you are going to have the same situation | 12:29 |
| nessita | gatox: but I don't understand why | 12:29 |
| nessita | gatox: I understand if we only have padding in the button | 12:29 |
| gatox | nessita, do you want to highlight all the widget? | 12:29 |
| nessita | yes | 12:29 |
| gatox | nessita, ok..... the padding area of the button is not highlighted | 12:30 |
| gatox | that's the problem | 12:30 |
| ralsina | good morning! | 12:30 |
| gatox | ralsina, hi | 12:30 |
| === zyga-xchat is now known as zyga | ||
| nessita | gatox: I'm not sure we're understanding each other :-) | 12:31 |
| nessita | gatox: so, I understand that the padding are of the button is not highligthed. But, what if the label inside the button has enough padding to reach the borders of the button? | 12:32 |
| gatox | nessita, it's easy....... if you add 6px padding to the button..... you are going to have a separation of 6px between the border of the button and its content....... that area of separation..... is not highlighted | 12:32 |
| nessita | gatox: waht if you add 6px padding to the label? then the separation between the border of the button and the content is 0 | 12:32 |
| gatox | nessita, if you add padding to the label.... and add padding to the button..... you are going to still have a padding on the button | 12:32 |
| gatox | you have 2 different paddings..... no 2 overlaps paddings | 12:33 |
| ralsina | gatox: go away! | 12:33 |
| nessita | gatox: but... you said that if you add padding just to the label, the text compresses because the button does not expand | 12:33 |
| ralsina | gatox: I just read the backlog. You have a fever, go to a doctor instead of working. | 12:33 |
| nessita | gatox: how can we make the button grow so the label fits properly then? | 12:34 |
| gatox | ralsina, that is what i'm going to ask you..... i'm with fever and feeling really bad.... i'm going to go to the doctor now....... | 12:34 |
| nessita | gatox: you with fever? :-/ | 12:34 |
| gatox | nessita, since yesterday | 12:34 |
| nessita | gatox: you know you can send an email saying "i will not work today, I have fever" | 12:34 |
| gatox | nessita, but, let's finish with this first | 12:34 |
| nessita | gatox: NO | 12:34 |
| ralsina | gatox: let me fiddle with the button, go away, come back healthy | 12:34 |
| nessita | gatox: really, go to the doctor, this issue is not worth it | 12:35 |
| gatox | nessita, yes yes... i'm going to the doctor.... | 12:35 |
| ralsina | gatox: it's the kind of thing we can even fix after beta2, doesn't even need UIFe, since it's not visibleon screenshots | 12:35 |
| gatox | ralsina, ok... | 12:36 |
| gatox | nessita, if you have anything else to do, please wait for me tomorrow.... so we can keep talking about this.... i already saw a lot of tihngs about this..... so you don't waste your time trying the same things | 12:36 |
| mandel | nessita, I've push a new revision to lp:~mandel/ubuntu-sso-client/webclient-use-dialog I have fixed most of the issues you pointed out except 3 to which I added explanations | 12:36 |
| mandel | gatox, pesado! vete al medico de una vez! | 12:37 |
| nessita | gatox: sure, I will not do anything about this | 12:37 |
| mandel | gatox, done make me go to cordoba.. | 12:37 |
| mandel | s/done/don't | 12:37 |
| nessita | gatox: byeeeeee | 12:37 |
| gatox | mandel, nessita ralsina ok, bye!! i'm off | 12:37 |
| ralsina | hahaha | 12:38 |
| ralsina | ok, had more success seding him to the doctor than with my wife (same symptoms) | 12:38 |
| ralsina | So, morning reviews, who wants some? | 12:39 |
| mandel | ralsina, no here :) | 12:42 |
| alecu | hello! | 13:01 |
| ralsina | nessita: just sent you an email with a little sanity check on the button styling: it's not us it's them | 13:13 |
| nessita | hola alecu | 13:15 |
| nessita | ralsina: ack | 13:15 |
| mandel | ok, lunch time for me :D | 13:26 |
| * mandel lunch | 13:26 | |
| === yofel is now known as yofel_ | ||
| === yofel_ is now known as yofel | ||
| ralsina | nessita: I think I have a fix for the "ugly orange focus square" problem in QPushButtons: http://www.flickr.com/photos/ralsina/6964221547/in/photostream | 13:46 |
| ralsina | nessita: of course, it won't be that ugly gray roundy-square when it's finished ;-) | 13:46 |
| nessita | ralsina: I'm also working on this... what do you have so far? | 13:47 |
| ralsina | nessita: the trick is setting padding of the :focus style to something ridiculously large so the square disappears | 13:47 |
| nessita | so we stop duplicating work :-P | 13:47 |
| ralsina | nessita: hahaha | 13:47 |
| ralsina | nessita: yes, let's stop freelancing ;-) Let me paste you my stylesheet change: https://pastebin.canonical.com/61923/ | 13:48 |
| nessita | ralsina: can you paste the diff instead, please? | 13:48 |
| ralsina | nessita: I think this, with a nice gradiant for the border, is a fix | 13:48 |
| ralsina | nessita: sure | 13:49 |
| ralsina | nessita: https://pastebin.canonical.com/61924/ | 13:49 |
| nessita | great | 13:49 |
| nessita | ralsina: let me apply that to my branch and will push | 13:49 |
| ralsina | and maybe we should stop using setDefault() and just set focus where we want it | 13:49 |
| nessita | ralsina: those are different things, no? | 13:51 |
| ralsina | nessita: yes | 13:51 |
| nessita | default and focus, are different things | 13:51 |
| ralsina | nessita: but default seems to be causing the gtk theme to do weird thigns withthe focus indicator | 13:52 |
| ralsina | nessita: without a setDefault() there is no orange halo on focused buttons | 13:52 |
| nessita | I'm -1 to stop using setDefault, I think every app should have default buttons, they guide the user what to click. Let's top using the gtk theme :-P | 13:52 |
| nessita | ralsina: the button in the file sync does not have the setDefault and has the halo | 13:53 |
| ralsina | nessita: I was tempted to switch the buttons to windows style but it's not doable on PyQt | 13:53 |
| ralsina | nessita: because once you have a default button, the focused button gets a halo | 13:53 |
| ralsina | nessita: it's a freaky bug, try the program I mailed you :-( | 13:53 |
| nessita | ralsina: I don't think the halo is related to default. I think is directly related to focus, see for example the "share publish button", has the halo, is never default in his lifetime | 13:53 |
| nessita | running your program now | 13:54 |
| nessita | ralsina: is there any chance you're confusing the halo with the orange default? | 13:55 |
| ralsina | nessita: with the setDefault, the focused button is orange. Without setDefaultit isn't | 13:55 |
| nessita | yes, but that's not the mild orange I refer to... the mild orange is the little box, for example, on top of the folder names | 13:56 |
| ralsina | nessita: it's the same thing. Try my program, with setDefault and -stylesheet ubuntuone.qss | 13:56 |
| ralsina | nessita: you will get the small "pinkish" square | 13:57 |
| ralsina | nessita: without setDefault, you won't | 13:57 |
| nessita | ralsina: so how do you explain the mild orange box in the tabs regarding your theory for default buttons? :-) | 13:57 |
| * nessita is confused | 13:57 | |
| ralsina | nessita: similar unrelated bugs? ;-) | 13:57 |
| nessita | .... | 13:57 |
| ralsina | nessita: ayway, the padding fixes it for the buttons. I can try to fix the tabs later ;-) | 13:58 |
| nessita | ralsina: heh | 13:58 |
| nessita | let me show you what I have so far | 13:58 |
| * ralsina feels like House MD | 13:58 | |
| nessita | (give me a few minutes to polish) | 13:58 |
| ralsina | nessita: sure, I will go put my mate in process | 13:58 |
| nessita | ralsina: ah, but I wanted to ask you about the qss | 13:58 |
| dobey | holas | 13:59 |
| nessita | ralsina: how's the precedence of style definition? the higher in the file the less precendence? | 13:59 |
| nessita | hola dobey | 13:59 |
| dobey | good news! | 13:59 |
| nessita | dobey: yes to the bug commnet, will reply soon | 13:59 |
| nessita | dobey: yes? | 13:59 |
| dobey | i fixed the sdtool hang | 13:59 |
| nessita | dobey: is that you? are you happy? what did you do with our regulardobey?!?!?! | 13:59 |
| nessita | :-P | 14:00 |
| nessita | dobey: yey! what was it? | 14:00 |
| dobey | or well. *i* didn't fix it. but i see what's wrong | 14:00 |
| dobey | so i will upload a package with the fix, today | 14:00 |
| nessita | shot | 14:00 |
| dobey | it seems there was another change in twisted, separate from the addition of gireactor/gtk3reactor, which is needed. and i wasn't aware of it | 14:01 |
| dobey | so doing "PYTHONPATH=. u1sdtool -s" with twisted trunk was working fine. but with the backported patch, it wasn't | 14:01 |
| dobey | so have to backport another change as well :) | 14:01 |
| nessita | aahhh | 14:02 |
| * alecu has just touched the power cable while unplugging the laptop. | 14:02 | |
| alecu | not fun. | 14:02 |
| alecu | somehow I feel things... differently now. | 14:02 |
| ralsina | nessita: yes, later = stroger | 14:02 |
| alecu | in an "electrical blue" shade. | 14:02 |
| ralsina | alecu: see dead people yet? | 14:03 |
| nessita | alecu: what cable you touched? | 14:03 |
| ralsina | alecu: 1-1? | 14:03 |
| ralsina | alecu: mumblish? | 14:03 |
| alecu | nessita, the 220v one | 14:03 |
| nessita | alecu: ouch | 14:03 |
| ralsina | alecu: seeing blue is a side effect of viagra. Good to knw you take care of yourself ;-) | 14:03 |
| alecu | lol | 14:04 |
| nessita | ralsina: how do *you* know? | 14:04 |
| nessita | :-P | 14:04 |
| ralsina | nessita: I know lots of useless stuff | 14:04 |
| ralsina | nessita: plus, House MD, of course | 14:04 |
| alecu | nessita, he already takes heart pills, so it would be very risky to add viagra to the mix. | 14:04 |
| * ralsina knows the density of Saturn, yet has never been there (around 0.59 IIRC) | 14:04 | |
| ralsina | alecu: not heart pills, just BP pills. No heart problems yet, luckily. I started on hyperinsulinemia pills yesterday though. | 14:05 |
| dobey | ralsina: you mean gravity relative to earth, not density, right? | 14:06 |
| ralsina | dobey: nope. Density. | 14:06 |
| ralsina | dobey: as in mass per volume | 14:07 |
| alecu | lol | 14:07 |
| ralsina | dobey: turs out i english that's called specific gravity and it's 0.7. Oh well. | 14:08 |
| alecu | nessita, I've added some comments and fixes after your review of branch: https://code.launchpad.net/~alecu/ubuntuone-client/proxy-tunnel-server/+merge/95075 | 14:29 |
| nessita | ack! | 14:30 |
| urbanape | good morning, friends | 14:33 |
| * mandel back | 14:37 | |
| === m_conley_away is now known as m_conley | ||
| ralsina | dobey: quick 1-1 on IRC? | 14:43 |
| dobey | sure | 14:46 |
| ralsina | dobey, alecu, nessita, thisfred, joshuahoover, mandel (not gatox, sick, not briancurtin, pycon): team call! | 14:59 |
| nessita | uh right | 14:59 |
| alecu | ralsina, and urbanape too! | 15:00 |
| urbanape | ah, omw | 15:00 |
| ralsina | sorry urbanape! | 15:00 |
| mandel | ralsina, ack | 15:00 |
| joshuahoover | nessita: bug #945065 | 15:37 |
| ubot5` | Launchpad bug 945065 in Ubuntu Single Sign On Client trunk "[UIFe] ResetPassword page has some widgets really close to the right margin" [Medium,In progress] https://launchpad.net/bugs/945065 | 15:37 |
| * jalcine wonder if this'll promote a better Qt app integration with GNOME. o.o | 15:39 | |
| ralsina | grmbl,ksnapshot really needs a ubuntu one kipi plugin | 15:46 |
| dobey | lawl | 15:46 |
| nessita | ralsina: I'm looking at your alerted branch | 15:46 |
| ralsina | nessita: oooook. My branch is slightly scared ;-) | 15:47 |
| nessita | ralsina: running --alert will not change anything in the desktop... is that ok? | 15:47 |
| ralsina | nessita: it does set the urgent bit but I see nothing when that's done | 15:47 |
| nessita | ie it will not make the U1 icon dance and all in the launcher | 15:47 |
| nessita | dobey: any idea about that? ^ | 15:47 |
| ralsina | nessita: but the bit is set. I really don't know | 15:47 |
| nessita | ralsina: yes, I also printer the bit value and is indeed set | 15:47 |
| nessita | printed* | 15:48 |
| dobey | eh? | 15:48 |
| dobey | url? | 15:48 |
| nessita | dobey: https://code.launchpad.net/~ralsina/ubuntuone-control-panel/alerted/+merge/96253 | 15:50 |
| nessita | running nessita@dali:~/canonical/controlpanel/review_alerted$ ./setup.py clean build; U1_DEBUG=True PYTHONPATH=. bin/ubuntuone-control-panel-qt --alert will not change anything at all in the desktop | 15:50 |
| dobey | +U1_DOTDESKTOP = "ubuntuone-installer.desktop" | 15:51 |
| ralsina | nessita: I amnot even sure what "urgent" looks like. Dancing? extra arrow? | 15:51 |
| dobey | i think that needs to be the full path perhaps | 15:51 |
| ralsina | dobey: that's copied from syncdaemon | 15:51 |
| dobey | oh | 15:51 |
| ralsina | so if it's broken, it's broken on syncdaemon as well | 15:51 |
| nessita | ralsina: the icon in the launcher bounces and is shown | 15:51 |
| nessita | ralsina: just like when you open a link with the browser minimized | 15:52 |
| dobey | depends on your config | 15:52 |
| dobey | but the arrow for it also turns blue | 15:52 |
| ralsina | ok, somebody say my name in 5 seconds | 15:52 |
| dobey | ralsina | 15:52 |
| nessita | ralsina: my name | 15:52 |
| ralsina | ok, quassel makes the icon dance, but the arrow is not blue | 15:53 |
| ralsina | nessita: when you start the app, the icon dances anyway | 15:53 |
| nessita | ralsina: what app? | 15:53 |
| dobey | nessita: any app | 15:53 |
| nessita | dobey: it does not for me... | 15:53 |
| ralsina | ok,gotta cook && eat, wil be back in a bit | 15:53 |
| dobey | or at least, setting urgency on startup is probably entirely useless | 15:54 |
| ralsina | --alert would make sense if it made an already running u1cp icon dance but that's not terribly useful either since u1cp is likely not running | 15:55 |
| dobey | ralsina: and if something actually called it with arguments, which installer does not | 15:55 |
| ralsina | I wonder if something ever used --alert in the past and/or what it did exactly | 15:56 |
| dobey | and running it manually with --alert is basically never going to happen outside of someone testing that --alert does something | 15:56 |
| dobey | ralsina: i don't think anything did use it, but the plan was to use it | 15:56 |
| ralsina | right | 15:56 |
| dobey | for the quota notification | 15:57 |
| dobey | for --alert to be useful, you'd also have to avoid showing the window when --alert was passed | 15:57 |
| dobey | because you're probably actually setting urgency, and then unsetting it, as it is now, before the message even gets sent over dbus | 15:58 |
| dobey | or both messages get sent fast enough that you can't see it | 15:58 |
| ralsina | right, since focus is removing the flag | 15:59 |
| dobey | and the first thing the new app does when the window is shown, is get focus :) | 15:59 |
| ralsina | dobey: I actually tried starting it in a way that gets no focus and it keeps dancing so maybe it even works, but it's very hard to tell ;-) | 16:03 |
| nessita | dobey, ralsina: alert was being used, afaik, when you perform an action that should open the controlpanel but was already opened | 16:03 |
| nessita | dobey, ralsina: just like when you click on a link and your browser is minimized | 16:04 |
| nessita | ralsina: comment added back to https://code.launchpad.net/~ralsina/ubuntuone-control-panel/go-native/+merge/96123 | 16:04 |
| ralsina | nessita: but syncdaemon can set urgent by itself. | 16:05 |
| dobey | nessita: --alert was never used | 16:11 |
| dobey | nessita: sd was setting it directly with the Unity api | 16:12 |
| nessita | it was? oh | 16:12 |
| nessita | let's nuke it then | 16:12 |
| nessita | ralsina: ^ | 16:12 |
| dobey | yeah. i'd get rid of --alert, but keep the unsetting of urgency on focusIn | 16:12 |
| nessita | dobey: ah, right | 16:16 |
| nessita | dobey: would you please comment that on the MP? | 16:16 |
| nessita | alecu: can you please review this https://code.launchpad.net/~mandel/ubuntu-sso-client/webclient-use-dialog/+merge/94416 before I give another pass to it? I have some doubts about the logic added in ubuntu_sso/utils/webclient/common.py, and would like your review in there before my second pass | 16:17 |
| nessita | alecu: also, your first tunnel branch is approved | 16:17 |
| alecu | nessita, looking | 16:17 |
| alecu | nessita, thanks! | 16:17 |
| ralsina | nessita: ack, will kill! | 16:18 |
| nessita | ralsina: see last dobey's comment as well | 16:18 |
| dobey | nessita: commented on merge also | 16:20 |
| nessita | thanks | 16:20 |
| dobey | ralsina: oh i forgot; there's also a bug about track duplication in rb for u1ms purchased tracks. should be an easy fix, but not in the upload i'm doing today. | 16:22 |
| dobey | hrmm. where the heck is that u1sdtool ^C bug | 16:22 |
| dobey | ah, there it is | 16:23 |
| mandel | nessita, is there a question about why there is a proxy_username and a username? | 16:30 |
| nessita | mandel: no, I'm not completely happy with the logic in webclient/common, the retry param is very confusing from my POV, specially since I'm not fully aware of the use of it. SO I prefer that alecu do one pass over that, and then I will re-review | 16:31 |
| mandel | nessita, ok, is indeed a little confusing, the retry param is for that case in which the proxy credentials were indeed asked to the user but he provided the wrong ones, in that case, the dialog shows that the creds were wrong the last time, is similar to the use of retrying in http://developer.gnome.org/libsoup/stable/SoupSession.html#SoupSession-authenticate | 16:33 |
| mandel | alecu ^ | 16:33 |
| mandel | nessita, it took me some time to get my head around that | 16:34 |
| ralsina | nessita: I will keep the set_urgent() method on the main window just because it may come handy later in life | 16:35 |
| nessita | ack | 16:36 |
| ralsina | nessita: pushed alerted without --alert because life is a cruel joke | 16:41 |
| ralsina | dobey: ack on the rhythmbox bug | 16:42 |
| ralsina | nessita: there is no bug for the tab-ordering, right? I will file one if that's the case | 16:49 |
| nessita | ralsina: ack | 16:49 |
| ralsina | nessita: on the focus branch, the get more storage button is taller than the disconnect button now, and "go to web for public blah" link is not underlined anymore. Sorry if you already knew! | 16:54 |
| nessita | ralsina: the "link" buttons, as per the "new" spec, should not be underlined, only when focused | 16:55 |
| ralsina | nessita: ack | 16:55 |
| nessita | ralsina: did not know about the taller button... have a screenshot? | 16:55 |
| nessita | you sure is not happening the same on trunk? | 16:55 |
| ralsina | nessita: in a minute, sure | 16:55 |
| ralsina | and yes, same thing happens in trunk! | 16:55 |
| ralsina | so not a bug in the branch | 16:56 |
| nessita | fiuuu | 16:56 |
| nessita | can try to fix though | 16:56 |
| nessita | but will have lunch before | 16:56 |
| nessita | LUNCH! | 16:56 |
| dobey | lunch, bbiab | 17:07 |
| mandel | alecu, nessita, ralsina mp for the qt webclient refactor that ensures that the correct proxy is used when doing a http or https request via a proxy factory: https://code.launchpad.net/~mandel/ubuntu-sso-client/qt-ssl-dialog/+merge/96624 | 17:26 |
| ralsina | mandel: ack, will review before you come back tomorrow | 17:26 |
| mandel | ralsina, the mp comment explains how the http/https proxy usages is tested, we use http + squid auth and https + squid nonauth that way we know that is correctly done, writing the tests for libsoup implies fully mocking the gsettings which we don't have time for atm | 17:28 |
| mandel | will move to the ssl dialog for libsoup tom and will do an IRL of the entire thing | 17:28 |
| alecu | mandel, lovely! | 17:28 |
| mandel | joshuahoover, FYI branch for UIFe bug 948119 proposed | 17:30 |
| ubot5` | Launchpad bug 948119 in Ubuntu Single Sign On Client "[UIFE] Add a translatable string for the ssl certificate details" [Medium,In progress] https://launchpad.net/bugs/948119 | 17:30 |
| joshuahoover | mandel: cool | 17:30 |
| mandel | ok, EOD for me.. brother is still at the hospital.. :( | 17:30 |
| mandel | laters! | 17:30 |
| * mandel EOD | 17:30 | |
| ralsina | bye mandel! | 17:30 |
| alecu | bye mandel! | 17:31 |
| alecu | mandel, please remember to review my other branches!!!! | 17:31 |
| mandel | alecu, will do before you are up tom :) | 17:31 |
| alecu | mandel, thanks | 17:31 |
| * mandel is lucky that alecu likes to sleep | 17:31 | |
| ralsina | nessita: I am thinking, it makes no sense for the explore buttons to have tab-focus. You activate them by focusing on the folder list, scrolling to the item and clicking enter | 17:43 |
| ralsina | nessita: it's either that or have them scroll into view when they get focus (I have the code for that done), but I like it better with no focus. | 17:44 |
| nessita | ralsina: well, we could implement something else as itemActivated in the row, no? I think is nice to show the focus in those buttons, since user may expect to be able to focus them and activate. A user may not guess that activating the row means activatins the explore button. I agree to scroll the list to show the focused button, that also has to be done for the focused checkbox, no? | 17:45 |
| ralsina | nessita: I have not found how to make the checkbox tab-focusable yet | 17:46 |
| ralsina | nessita: but yes, if it's doable, it should too | 17:46 |
| nessita | right | 17:46 |
| ralsina | ok, I'll go with scroll-on-focus now, it's easy to change if needed | 17:47 |
| nessita | ralsina: also, any idea why the tabbing does not reach the twitter and facebook buttons? | 17:49 |
| ralsina | nessita: let me check | 17:49 |
| nessita | if they do, I can not make any visual detection of that | 17:50 |
| ralsina | nessita: it does | 17:50 |
| ralsina | nessita: after help | 17:50 |
| ralsina | nessita: it's just invisible | 17:50 |
| nessita | ralsina: ok, will debug further, thanks | 17:50 |
| nessita | lovely! | 17:50 |
| ralsina | nessita: those buttons have border: none | 17:52 |
| ralsina | nessita: so, well, that :-) | 17:52 |
| nessita | yeap, but I added: | 17:52 |
| nessita | 146 QPushButton#twitter_button:focus, | 17:52 |
| nessita | 147 QPushButton#facebook_button:focus { | 17:52 |
| nessita | 148 background: green; | 17:52 |
| nessita | 149 border-width: 2px; | 17:52 |
| nessita | 150 border-color: #dd4814; | 17:52 |
| nessita | 151 } | 17:52 |
| ralsina | nessita: add solid | 17:52 |
| nessita | and nothing happens either | 17:52 |
| ralsina | brder; 2px solid #dd4814; | 17:52 |
| nessita | *really*? | 17:52 |
| ralsina | nessita: yes, it's set to 2px of none :-) | 17:52 |
| nessita | I HATE THIS | 17:53 |
| nessita | ralsina: it does not change anything :-/ | 17:53 |
| ralsina | nessita: good thing you are not a web dev anymore, because CSS does exactly the same thing ;-) | 17:53 |
| ralsina | nessita: can you push? | 17:53 |
| nessita | ralsina: I'm not pregnant, so not sure | 17:53 |
| ralsina | nessita: haha | 17:53 |
| ralsina | nessita: don't want you to have an accident, so just bzr push ;-) | 17:54 |
| nessita | ralsina: also, I commented out the border:none as well, so will push and you can play | 17:54 |
| ralsina | nessita: ok, cool | 17:54 |
| nessita | ralsina: pushed | 17:55 |
| ralsina | nessita: those buttons have a fixed size of 16x16 and a 16x16 image in them, there is no room for a visible border | 18:00 |
| nessita | ralsina: ah... so the fix is... | 18:00 |
| ralsina | nessita: I will play a bit to see if I can find a way to make that visible without breaking stuff | 18:02 |
| nessita | ralsina: ok, I have a second challenge for you, let me know when you\ re ready | 18:02 |
| nessita | ralsina: what if we fixed the size to be 18x18 | 18:03 |
| nessita | ralsina: and when !focus, we set a border of 2px with the same color as the background :-D | 18:03 |
| nessita | yes, that's cheating | 18:04 |
| nessita | but it works! | 18:04 |
| ralsina | nessita: fix for twitter buttons https://pastebin.canonical.com/61967/ | 18:05 |
| ralsina | nessita: and it's a bit like that, yes ;-) | 18:05 |
| ralsina | so, second challenge accepted! ;-) | 18:05 |
| nessita | ralsina: will push so you debug | 18:05 |
| nessita | ralsina: Pushed up to revision 281. So, second challengue is the "Help button" along with the "share_publish_button" | 18:06 |
| nessita | ralsina: using my latest branch, you will notice that if you focus in those, they turn blue | 18:06 |
| nessita | ralsina: the goal is those to be underline, but in the same qss section where I'm turning them blue, text-decoration: underline; does nothing | 18:07 |
| ralsina | nessita: ok, will look | 18:07 |
| nessita | ralsina: as you can see the text-decoration: underline; is there | 18:07 |
| dobey | 18x18? | 18:07 |
| ralsina | dobey: no, they are 16x16 with an invisible 2px frame, ignore the 18 behind the curtain | 18:08 |
| dobey | wtf | 18:08 |
| nessita | ralsina: but, if you move the text-decoration: underline; to the qss section where the same buttons are styled for non-focus state, that will draw the underline | 18:08 |
| nessita | WTF? :-) | 18:08 |
| ralsina | nessita: ok, will research what F it is then :-) | 18:08 |
| ralsina | nessita: for 2px border you will need 20px on the buttons, really, not 18 | 18:09 |
| ralsina | nessita: border is inside widget boundaries | 18:09 |
| nessita | yeah true | 18:09 |
| ralsina | nessita: also, I see the tabs are no longer pink-on-focus, nice! | 18:10 |
| nessita | ralsina: they are underlined like the docs requests ;-) | 18:10 |
| ralsina | nessita: a real fix for that may involve adding a QLabel inside the button | 18:23 |
| nessita | ralsina: hum... then why the underline works when non focused? | 18:23 |
| ralsina | nessita: oh,no idea | 18:24 |
| ralsina | nessita: I just think that using a QLabel may work. According to the docs this should work too | 18:24 |
| nessita | and it does | 18:25 |
| nessita | but not for :focus :-/ | 18:25 |
| ralsina | nessita: right | 18:25 |
| dobey | ok, time to get this rhythmbox fixup done | 18:28 |
| nessita | ralsina: any hack you can advice? | 18:30 |
| ralsina | nessita: not yet | 18:30 |
| ralsina | nessita: I can make it work by rsetting the property on focusInEvent but it breaks lts of stuff | 18:30 |
| nessita | right | 18:31 |
| nessita | ralsina: well, we can always as another styling for those in particular | 18:31 |
| ralsina | nessita: well, the 1000px padding when you reset the stylesheet becomes effectively 1000px :-) | 18:31 |
| nessita | like, instead of being underlined, to be changed the fg color (not to blue, but to something else). For example, the white link can change to orange, and the orange change to... grey | 18:31 |
| ralsina | nessita: which kinda breaks the layout a wee bit | 18:32 |
| nessita | ralsina: what does that mean: "reset the stylesheet"? | 18:32 |
| ralsina | nessita: calling setStyleSheet on the button | 18:32 |
| nessita | ah, oh | 18:32 |
| nessita | don\ t do that :-P | 18:32 |
| nessita | ralsina: I will propose to design to have the help_button turn orange when focused | 18:33 |
| nessita | and the share_publish_button to turn grey | 18:33 |
| ralsina | nessita: fine by me | 18:34 |
| nessita | ralsina: I found the problem, and is *odd* | 18:36 |
| nessita | ralsina: when in :focus, with background: transparent, underline does not work | 18:36 |
| ralsina | interesting | 18:36 |
| nessita | remove the background setting and it works :-/ | 18:36 |
| ralsina | bizarre | 18:36 |
| nessita | can certainly set the background by hand... but that's dirty | 18:37 |
| ralsina | so, let's set it to background instead of transparent I guess | 18:37 |
| ralsina | nessita: well, let's get design input. It's just another constant (and we have 50 already anyway) | 18:37 |
| nessita | right | 18:37 |
| nessita | ralsina: sorry, I lied | 18:39 |
| nessita | no, it does not work changing the background | 18:39 |
| nessita | I confused myself, had a leaking underline from other state | 18:39 |
| ralsina | nessita: then forget it, don't block on it | 18:40 |
| ralsina | nessita: we can just change the icon or something, too | 18:40 |
| nessita | yeah | 18:40 |
| nessita | ralsina: ok, I think I'm happy with what I have so far. I will propose for merging, the thing that is pending is making the freaking checkboxes in the folders list to be focused, but I guess you're working on that? | 19:02 |
| ralsina | nessita: yes | 19:04 |
| ralsina | nessita: I am not sure it is possible, but I will try | 19:04 |
| nessita | ralsina: ok, I'm also fixing an ugly thing I found with devices, which may fix the tabbing there. HAve you done enything in the devices tab? | 19:04 |
| ralsina | nessita: not yet | 19:05 |
| ralsina | nessita: trying to do a test for the "scroll-on-focus" that doesn't segfault | 19:05 |
| nessita | ralsina: ok, will advice not to do anything in there until I push this | 19:06 |
| ralsina | nessita: sure, I expect I will only do folders today | 19:06 |
| alecu | nessita, I've reviewed mandel's branch. The logic in common.py looks ok, so I've approved it. | 19:10 |
| nessita | alecu: ack! | 19:11 |
| alecu | ok, guys, gals: I'll be out for a few hours, running some errands and going to kinder. | 19:14 |
| alecu | see you laters! | 19:14 |
| === alecu is now known as alecu-away | ||
| dobey | alecu-away: play nice with the other kids while you're there. | 19:39 |
| ralsina | nessita: to keep branches short and clean, I think I will propose one that fixes only folders | 20:05 |
| nessita | ralsina: makes perfect sense | 20:05 |
| ralsina | nessita: specially since it will all be much prettier and easier to see with your branch | 20:05 |
| nessita | yes | 20:06 |
| ralsina | nessita: there is no way I can find to get the checkbox in an item. I can make it a real widget (like the button) and then it's easy | 20:25 |
| nessita | ralsina: what does it involve "make it a real widget"? | 20:26 |
| ralsina | nessita: doing like we do for the explore buttons, and move some code from the slot connected to ui.folders to some other place connected to the checkbox we are adding. Nothing major. | 20:27 |
| nessita | ralsina: when you say slot, you mean callback? | 20:27 |
| ralsina | nessita: no, I mean the on_folders_item_Activated slot | 20:28 |
| ralsina | or maybe itemChanged I would have to look | 20:29 |
| nessita | ralsina: <pausing a bit the original conversation> | 20:29 |
| nessita | ralsina: for me, those 2 are callbacks connected to signals | 20:29 |
| nessita | why you call them slots? | 20:29 |
| ralsina | nessita: Qt slang | 20:29 |
| nessita | ralsina: I know that in Qt there some things called slot, that's why I ask, the thing is that I always thought that a slot != callback | 20:30 |
| nessita | ergo would like to understand the difference :-) | 20:30 |
| ralsina | nessita: you connect signals to slots or to other signals. On Python, any callable works so talking about slots makes a little less sense | 20:30 |
| ralsina | on C++ you have to declare that a method is a slot so you are able to connect signals to it | 20:30 |
| nessita | ahhhhhh | 20:31 |
| nessita | ok, got it | 20:31 |
| ralsina | and you can't connect signals to standalone functions | 20:31 |
| nessita | in C++, right? | 20:31 |
| ralsina | right | 20:31 |
| nessita | ack | 20:31 |
| nessita | <unpause> | 20:31 |
| ralsina | on PyQt people maintained the slang because we use the C++ docs all the time | 20:31 |
| nessita | ok, let me re-read with this new knowledge | 20:31 |
| nessita | ralsina: do you consider the solution you're proposing to be cleaner? | 20:32 |
| ralsina | nessita: not cleaner, but it will make it less confusing | 20:32 |
| ralsina | nessita: currently, since you can tab to the buttons, not being able to tab to the checkboxes is weird | 20:32 |
| nessita | yes | 20:32 |
| nessita | ok, I'd say go ahead | 20:32 |
| nessita | I'm running tests to propose my branch | 20:33 |
| ralsina | nessita: also, that means that you can explore by tabbing to the button or to the list + arrows and then space, but for checkboxes you can only do the second | 20:33 |
| nessita | ralsina: didn't you forgot your kid? | 20:33 |
| ralsina | nessita: ok then | 20:33 |
| ralsina | nessita: his mother picked him today :-) | 20:33 |
| nessita | ah, ok :-) | 20:33 |
| ralsina | nessita: I only forget him once or twice a year tops | 20:33 |
| nessita | you're a great dad | 20:33 |
| nessita | (?) | 20:33 |
| ralsina | *almost*! | 20:34 |
| ralsina | the problem was this week he exits at noon, so it's right in standup / mgmt call/ team call/whatever | 20:34 |
| nessita | ralsina: ah, I thought you had to pick him up at 5pm | 20:41 |
| ralsina | nessita: not yet, in a couple of weeks | 20:42 |
| ralsina | nessita: still in adaptation | 20:42 |
| ralsina | crap, spent 45 minutes befre noticing that self.ui.folders.setItemWidget only works AFTER the item is added to the tree. Sigh. | 20:53 |
| nessita | ralsina: when you can, https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/focus/+merge/96654, will attach screenshot soon | 20:56 |
| ralsina | nessita: got it | 20:56 |
| nessita | ralsina: oops wait let me revert something a broek | 20:58 |
| nessita | broke | 20:58 |
| nessita | ralsina: pushed | 20:59 |
| ralsina | nessita: ack | 21:00 |
| * dobey finally builds updated rhythmbox for ubuntu in pbuilder | 21:08 | |
| nessita | ralsina: any idea about this? https://bugs.launchpad.net/ubuntu/+source/ubuntu-sso-client/+bug/950126 | 21:16 |
| ubot5` | Ubuntu bug 950126 in ubuntu-sso-client (Ubuntu) "ubuntu-sso-login crashed with SIGSEGV in setEnabled()" [Undecided,New] | 21:16 |
| ralsina | nessita: not really | 21:16 |
| ralsina | nessita: python question, how can I not duplicate code here: https://pastebin.canonical.com/61985/ | 21:17 |
| nessita | looking | 21:17 |
| nessita | ralsina: uh oh gah, you saw that in my branch there is already a ExploreFolderButton? | 21:17 |
| ralsina | nessita: no, I did not :-) | 21:17 |
| ralsina | nessita: have not started reviewing it yet | 21:18 |
| nessita | ralsina: anyways, from my point of view, that code should not be in SubscriptionCheckBox nor in ExploreButton. I think the proper fix is: | 21:18 |
| ralsina | but hey, I can merge changes later. In which case, no worries about duplication ;-) | 21:18 |
| nessita | ralsina: let me finish my proposal! | 21:18 |
| nessita | :-) | 21:18 |
| ralsina | sure, go ahead | 21:18 |
| nessita | * in the tree widget, connect to each button.checkbox to the focusIn signal (map that to whatever the signal name is) and have a single callback that does what you want | 21:19 |
| ralsina | nessita: focusin is not a signal :-( | 21:19 |
| ralsina | nessita: it's an event, so the only way to act on it is to inherit and overload | 21:19 |
| nessita | but that code (self.item.treeWidget().scrollToItem(self.item)...) does not belong to the button nor to the checkbox | 21:19 |
| nessita | it really really does not belong there | 21:20 |
| ralsina | nessita: the button is the only one that knows it got focus | 21:20 |
| nessita | ralsina: what about emitting a custom signal in each widget on focusInEvent? | 21:20 |
| nessita | so, the implementation of focusInEvent would be self.focused.emit() | 21:20 |
| ralsina | nessita: sure, but we are adding a signal and an extra method just to move that one line of code | 21:20 |
| nessita | 1- is not one line of code :-) | 21:21 |
| ralsina | ok 2 lines of code ;-) | 21:21 |
| nessita | 2- the code does not belong there, when speaking about concerns of classes and ADTs | 21:21 |
| ralsina | the only purpose of this class is scrolling its parent when it gets focus ;-) | 21:22 |
| nessita | the problem, from my POV, is qt not providing a signal for focusin!!! | 21:22 |
| nessita | ralsina: a widget can not rely on who's its parent | 21:22 |
| ralsina | nessita: yes, but that is a problem that we cannot fix | 21:22 |
| nessita | ralsina: we can if we provide the signal ourselves :-P | 21:22 |
| ralsina | nessita: ok, I will do it, but it looks like a really nasty "solution" to me, moving back and forth between classes, adding a "scroll self.ui.folders to this item" function, plus the button will still need a reference to the item anyway | 21:23 |
| nessita | ralsina: why "the button will still need a reference to the item anyway"? | 21:24 |
| ralsina | nessita: the button gets the focus event. How will it tell ui.folders to what item to scroll? | 21:24 |
| ralsina | nessita: and don't say "search the items until we find the button" please ;-) | 21:25 |
| nessita | ralsina: the self.ui.folders has the item already, no? | 21:25 |
| nessita | no searching all the items | 21:25 |
| ralsina | nessita: it has all the items. Doesn't know which one has a button that has focus. | 21:25 |
| nessita | ralsina: one sec | 21:26 |
| ralsina | so, I could traverse the items using a QTreeWidgetIterator and check all ItemWidgets until I find the focused one, but tikes | 21:26 |
| ralsina | nessita: ok | 21:26 |
| nessita | ralsina: what about using the focuschanged signal? does that make any sense? | 21:31 |
| ralsina | nessita: same problem, focuschanged gives you the button, if it doesn't hold a reference to the item where it is placed, you have to search for it | 21:32 |
| nessita | ralsina: right, but we solve the need of hving a custom signal, no? | 21:32 |
| ralsina | nessita: I *could* keep a {widget: item} in the main UI class, and avoid the lookup | 21:33 |
| ralsina | nessita: yes, but we still need the custom class | 21:33 |
| nessita | ralsina: for styling? | 21:33 |
| ralsina | nessita: no, so it keeps the reference to the item so we can scroll | 21:35 |
| ralsina | nessita: of course I could just do butto.item = child | 21:35 |
| ralsina | but that's a bit chanchito ;-) | 21:35 |
| nessita | ralsina: ah, I thought your {widget: item} mapping would live in the self.ui.folders | 21:35 |
| nessita | and then you could do {widget: item}[the_focused_button] | 21:36 |
| ralsina | nessita: no, because self.ui.folders is a standard class, so it would have to be in FoldersPanel | 21:36 |
| ralsina | so, we get focuschanged, and that gives us a widget, we look for it in the dictionary, and scroll to the item. That needs no class no nothing | 21:36 |
| nessita | ralsina: yes, I meant the FoldersPanel instance | 21:36 |
| ralsina | plus, that gets triggered for *every* focuschange in the app, but that's not as horrible as it sounds | 21:37 |
| nessita | ralsina: right. Well, from all the possibilities, I find the one of having the tree-widget related code in the inner widget the less acceptable... the rest I can live with | 21:38 |
| nessita | ralsina: would you think is better to hace custom signals in each "inner" widget and pass the item around? | 21:38 |
| ralsina | nessita: just as a last defense for my current solution: it doesn't rely on parent(), it relies on item which is a mandatory argumet on creation | 21:39 |
| nessita | ralsina: right... but it relays that the item has a treeWidget in it :-/ | 21:40 |
| nessita | which is the part I find that crosses too many class boundaries and couples the classes a lot | 21:40 |
| ralsina | nessita: item is a QTreeWidgetItem. It checks if it's added to a treeWidget, and if it is, it scrolls it | 21:40 |
| nessita | ralsina: from my POV, is very very dirty, I think it violates class abstraction | 21:41 |
| ralsina | nessita: ok, "te doy la derecha". I will do the focuschanged one, the other is a lot of do-nothing code | 21:42 |
| dobey | la la la, build build build | 21:47 |
| nessita | ralsina: ok, I'm calling it a day... will email design with the screenshots and diego, so if he works tomorrow, he knows where we stand | 21:51 |
| ralsina | nessita: cool | 21:52 |
| ralsina | nessita: he sent me email: has gastroenteritis and maybe a sore throat | 21:52 |
| ralsina | nessita: so I wouldn't expect him tomorrow, but you know how he is | 21:52 |
| nessita | ralsina: did you mention that he should rest tomorrow as well? | 21:53 |
| ralsina | nessita: I told him "don't come back until you are well" | 21:53 |
| nessita | hum | 21:53 |
| nessita | too vague for diego :-P | 21:53 |
| nessita | what's "well"? :-D | 21:53 |
| nessita | be able to breathe? | 21:53 |
| dobey | i think it means "the computer boots" | 21:55 |
| dobey | ok. proposed new rhythmbox | 22:15 |
| dobey | and rhythmbox-ubuntuone uploaded; though it won't be installable until new rhythmbox is accpted/published as well | 22:16 |
| jalcine | so it's a tease? lol | 22:17 |
| dobey | well, can't have people reporting crashes that are already fixed. | 22:18 |
| jalcine | true, true. | 22:27 |
| dobey | alright. later all | 22:33 |
| JanC | is there any chance to get U1MS decoupled from a particular media player...? ;) | 22:35 |
| dobey | JanC: the core of it is. | 22:42 |
| dobey | JanC: it's just a widget we embed inside rhythmbox. and we hook up various signals and things to rhythmbox, so previews work, and songs end up in the user's music library, and stuff like that | 22:43 |
| JanC | hm | 22:43 |
| dobey | the plug-in is just a thin veneer :) | 22:43 |
| dobey | anyway, i am really gone now | 22:44 |
| JanC | wouldn't it make more sense to have a separate application that can update $FAVOURITE_PLAYER using a simple plugin? | 22:48 |
| nhaines | It would make sense to support both Rhythmbox and Banshee instead of oscillating quickly between the two. | 22:54 |
| JanC | nhaines: I use neither | 23:11 |
| JanC | they are both similar, and for some reason C++ & C# are slower than Python... ;) | 23:12 |
| JanC | s/and/as/ | 23:12 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!