[13:13] hey cjohnston [13:15] hey daker_ [13:16] got some time? [13:17] daker_: Amoz did alot of the work, Just need help cleaning up a few things [13:23] ok [13:24] https://code.launchpad.net/~chrisjohnston/ubuntu-community-webthemes/ubuntu-updated-design-guidelines [13:24] https://code.launchpad.net/~chrisjohnston/summit/ubuntu-updated-design-guidelines [13:26] I'm uploading a new DB so you don't get errors [13:30] daker_: http://ubuntuone.com/3R0N0lnoQu5XdFzOA7m065 [13:34] daker_: so far the issues I have found is the main-nav li ends too far to the right and the sub-nav (ive only worked on summit.html for the sub-nav) is too low and behind the main-content [13:36] ok thanks [13:49] cjohnston: should i work on this https://code.launchpad.net/~chrisjohnston/summit/ubuntu-updated-design-guidelines ? [13:58] daker_: both, yes.. the theme stuff is going into the ubuntu-community-webthemes but there are some changes needed in summit [13:58] gonna forward an email.. give me a sec [14:01] daker_: mail [14:03] ok [14:12] daker_: I'd like to remove out of our old CSS everything that's no longer needed too.. to clean stuff up [14:14] sure [14:15] cjohnston: is summit using Django-1.3.1 ? [14:15] yes [14:15] because its on its own server [14:16] they wont let us put LTP there [14:16] ive tried [14:16] daker_: I'll try this week to get a time line for an upgrade for LTP.. last I heard they were waiting on hardware.. [14:16] but thats been months [14:25] ok [14:26] cjohnston: http://pastebin.com/NFdZwqZM [14:28] daker_: hrm [14:28] are you doing make or setup your own virtualenv [14:29] hey guys [14:30] cjohnston: yep make init [14:31] hey Amoz [14:31] isn't make spawning a new process for every line in the makefile? [14:31] daker_: try make clean then try it again [14:31] i dont like make.. i like making your own virtual env [15:15] mhall119: cjohnston i am out of idea make init doesn't want to work :/ [15:16] daker_: try summit.readthedocs.org [15:28] nigelb: ^^ [15:28] er, what? [15:38] nigelb: daker is having issues getting make to work.. [15:38] thoughts? [15:38] don't use make. [15:39] lol [15:39] thats my opinion [16:05] cjohnston: [16:05] AttributeError at / [16:05] 'Settings' object has no attribute 'THEME_MEDIA' [16:06] daker_: python manage.py runserver --setings ubuntu_settings [16:09] cjohnston, so what do you want to do with the 960 bug? [16:10] Amoz: i dont see any issues with the 960 [16:10] as you see by my screenshot yesterday, its the proper width [16:11] link it again please [16:11] the 960.css overrides the core.css header#page-header padding [16:12] from 0px 20px from core.css, to 0px 10px in 960.css [16:12] that's the issue [16:12] right.. but only on a couple of pages [16:13] http://ubuntuone.com/3J7pjP8d94o7z1h9noMJD3 [16:16] cjohnston, so how do you want to fix that bug then? [16:16] Amoz: what bug? [16:16] in the screenshot? [16:16] that's one of the things daker_ is going to hopefully look at [16:21] one can set the #main-nav width to 960px; that will fix the glitch [16:21] however, the padding will be only 10px [16:21] because of the 960.css [16:22] cjohnston, I can push if you want to see it [16:22] please [16:23] 960 is only called on a couple of pages [16:23] so it shouldnt be effecting the main pae [16:23] page [16:23] what do you mean "called" ? [16:23] included in the template? [16:24] on my main page it's included anyhow [16:24] Amoz: http://summit.ubuntu.com/ vs http://summit.ubuntu.com/uds-p/2011-10-31/display [16:25] you can branch from my lp:~fougner/+junk/light-django-theme-new-design [16:25] wait.. i may be backwards [16:25] yeah [16:25] the 960 is included in main [16:25] Amoz: lets just remove the 960 reference for now [16:26] and then fix everything else to work as it should [16:26] please [16:26] okay, check out my branch first [16:27] I fixed the boxshadow as well [16:27] i dont care to have the wide nav bar on the grid view since its no longer the main view [16:27] the last revision i see is 22 hours old [16:28] Amoz: I have to take off for a bit.. [16:29] oh, sorry [16:29] I pasted my two branches above where you can see the sub-nav not working.. maybe you and daker can collaborate [16:29] cjohnston, okay [16:29] daker_: Amoz, Amoz daker_ [16:29] I should be back in 1.5 hours [16:29] :-) [16:29] o/ [16:30] bye ^^ [16:30] hello daker_ [17:53] Amoz: im back [18:07] cjohnston, cool [18:08] Amoz: did you get a chance to remove the 960 stuff? [18:09] cjohnston, yeah, kinda [18:09] but the 960 styles were holding some divs in place [18:09] footer, etc. [18:10] so now they're spanning the whole site and need to be set in the default.css or core.css [18:10] I believe its already set in core, just needs to be changed what its called [18:13] cjohnston, nope, the layouts are defined in core-grid [18:13] and that's just general classes [18:14] and the original design is using a wrapper IIRC [18:14] our original design or the one by canonical [18:15] canonical [18:15] what happens if you wrap the whole thing in wrapper and inner wrapper [18:15] like in their design [18:18] it will be easier to implement their stylesheets, if the html templates are more similar to theirs [18:18] work on what we would need to make it work best and we will see how much work will be required [18:18] but then we break the html templating, as you said we shouldn't [18:18] if you dont mind [18:19] I'd like to know and see the rest or the sites using the same template/themes etc. [18:19] that way I can make a more informed decision [18:19] technically the other sites use ubuntu_website_base.html.. summit is the only one that uses website_base.html so if we only modify website_base.html, then their sites wouldnt be effected as long as we leave all the old stuff [18:19] loco.ubuntu.com lp:loco-team-portal [18:19] i dont know anything about jonos site [18:21] I'll check it out, need to eat and stuff first tho [18:21] k [18:52] Amoz: i removed the 960 and added the wrapper and inner-wrapper [18:52] still having issues on my end tho [18:57] Amoz: looks like leaving the old css is whats screwing things up [18:57] i commented that stuff out and some issues were fixed [18:57] the header one is fixed [19:21] cjohnston: i am lost :/ [19:21] cjohnston, maybe a few quirks would be fixed if you remove the old css [19:21] cjohnston, but I'm checking everything in chrome developer tools to see applied styles [19:21] Amoz: a few quirks were fixed by removing it [19:21] and I'm quite sure the old css isn't messing with the header [19:22] those two branches above are now updated [19:22] could you list the branches pls ? [19:22] https://code.launchpad.net/~chrisjohnston/ubuntu-community-webthemes/ubuntu-updated-design-guidelines [19:22] https://code.launchpad.net/~chrisjohnston/summit/ubuntu-updated-design-guidelines [19:23] if you just merge them you will get your stuff from yesterday, plus my changes [19:23] whats wrong daker_ [19:25] Amoz: I just pushed revno 39 to the theme branch [19:26] i don't know form where i should start [19:26] got simmit working [19:26] summit* [19:26] daker_: now, merge in my two branches that I posted a couple minutes ago... the first one goes into the ubuntu_website directory, the second into the summit directory [19:30] cjohnston: ok done, i see the new theme, now how do you make changes ? [19:30] edit the css-files in the ubuntu_website dir [19:31] ok [19:31] daker_: ubuntu_website/media/css/core* is the css.. the templates are just like LTP... we use ubuntu_website/templates/website_base.html and common/templates/base.html [19:32] i just pushed revno 40.. which makes changes to the subnav.. but they are in the wrong place on the page [19:32] http://127.0.0.1:8000/uds-p/ [19:32] is the page im talking about [19:46] cjohnston, I'm porting the html theme now [19:46] trying that way instead [19:46] k [19:49] * Amoz YTs rebecca black - friday and goes into haxor mode [19:50] lol [19:52] dude [19:52] cjohnston, someone's removing the li tags in the subnav [19:52] ? [19:52] I'm editing the sub_nav_links block in website_base.html [19:52] but on the site the li tags are nowhere to be seen [19:53] somewhere... they get overriden and removed [19:53] Amoz: correct [19:53] if you look on http://127.0.0.1:8000/uds-p/ they are there [19:53] nope [19:53] if you merged in both of my branches they are [19:53] I didn't merge anything [19:53]
  • Tracks
  • [19:53]
  • All Sessions (iCal)
  • [19:53] [19:53] I'm starting over from scratch [19:53]
  • Past Summits
  • [19:53] :O [19:53] right.. [19:54] thats django templates [19:54] block sub-nav-links in website_base gets replaced [19:54] by what? [19:54] in that case we have to change it as well [19:54] in the case of /uds-p/ its schedule/templates/schedule/summit.html [19:55] Amoz: http://bazaar.launchpad.net/~chrisjohnston/summit/ubuntu-updated-design-guidelines/revision/310 look under that same file name in that MP... [19:56] I see your point in not editing the html, but you'll have a hard time getting the design right if tags are removed [19:56] such as li [19:56] you have to add them on the pages that use it [19:56] that means the original design using both anchors and li tags, needs to be styled into ONE element [19:56] I'm fine with adding
  • around the main-nav and sub-nav links [19:57] just as I did in my branch [19:57] yeah but when I first told you I wanted to port the html and not the css, you told me not to do the html [19:58] some things in the html have to be done.. I was saying not to redo all of it [19:58] okay [20:01] there isn't a quick way to move the working dir to another computer I suppose.. [20:06] rsync or push a branch and pull it again [20:08] cjohnston, I was referring to the whole environment [20:08] not really [20:09] okay :( [20:09] gotta set it up again then [20:09] shouldnt be too bad since you have done it befor [20:09] e [20:11] :P [20:32] cjohnston, how's the weather in FL today? [20:32] :) [20:36] takes forever to setup the prerequsities [20:40] raining.. [20:41] which is messing up my smoking process for dinner [20:41] smoking process? [20:41] smoking pork [20:41] o.O [20:42] now [20:42] ready [20:42] chek dis out [20:42] PM [20:43] deveoper summit in the header is too far to the right [20:43] tell me what you think [20:43] I know [20:43] remove the
    s from the website_base [20:43] small quirks like that is expected [20:43] this is the big structure/layout [20:43] also the footer isnt ported yet [20:44] but the header and menu looks good [20:44] and the main content [20:44] rite? [20:44] ya.. [20:44] i think so [20:44] good [20:44] for some reason the right side code on uds-p is being all screwy [20:45] mind pushing the branches and let me see? [20:45] NO! [20:45] iz mine [20:45] lol [20:45] ^^ [20:45] ofc u can [20:45] w8 plz [20:48] there [20:48] cjohnston, [20:50] Amoz, [20:50] cjohnston, [20:52] ya [20:52] you highlit me [20:54] link please? [20:55] lazy man huh? ;) [20:55] http://bazaar.launchpad.net/~fougner/+junk/light-django-theme-new-design [20:55] there [20:56] I thought you already had it [20:58] Developer Summit shouldn't be in website_base.html [20:59] change the to h2... the block will do the rest [21:04] just h2? [21:04] not #loco [21:11] i thought you were porting the html [21:12] if your porting the html that span can go away to match their hrml [21:12] html [21:14] Amoz: any reference in the old css to top-nav needs to be brought to core [21:14] you took the site down :-( [21:14] haha [21:14] yeah [21:15] I was doing changes [21:15] I need to learn more bzr ... [21:15] bzr is cool [21:16] yeah it is [21:16] really awesome [21:16] like git but easier imo [21:16] hehe [21:16] at least for simple stuff [21:16] i have some friends trying to convince me that git is the best thing in the world [21:17] Amoz: if you run byobu you can leave the server running while working in another terminal [21:17] well git is really awesome as well [21:17] but for ubuntu dev, bzr is sooo integrated [21:17] cjohnston, I know that :P [21:22] cjohnston, if I have a normal conflict in a branch and I want to just pull in from another branch and use the file from there [21:22] how can I do that? [21:23] i dont understand [21:23] if you just want one file, go download it from LP [21:23] im not sure what a normal conflict is [21:24] text conflict [21:24] I just want the pulled file to overwrite the local conflicting one [21:25] just download the file from launchpad [21:34] cjohnston, there, watch it now [21:34] the branch should be pushed as well [21:34] gotta go for tonite [21:34] gf's whining [21:35] :-/ [21:35] lol [21:35] thanks for your help [21:35] ill prolly merge it after dinner and do some work [21:36] cool [21:36] fix top-nav etc. [21:36] yup [21:36] but you know what [21:36] please put it in a separate stylesheet [21:37] it's so much easier to keep track of upstream (canonical) design if our own extras are in a separate file [21:37] ok [21:37] cya! [21:37] later [23:19] cjohnston: i fixed the the subnav, where i should push ? [23:25] daker_: I think he got it fixed as well.. daker_ whats your though.. redoing the CSS or redoing the HTML? if we redo the html we have to redo the html on all the sites, but if they release another theme upadte and they use the same names of things we just have to ap;ly the updated css [23:26] redoing the css only is very hard [23:26] daker_: in that case: http://bazaar.launchpad.net/~fougner/+junk/light-django-theme-new-design [23:27] I don't think Amoz pushed his changes to the summit branch, but i dont think much needs to change in the summit branch, just li's that I've seen so far.. everything else is in website_base.html [23:28] i have a solution [23:28] whats that [23:28] why not to fork light-django-theme ? [23:29] I think updating light-django-theme would be better than forking it.. [23:29] ok :) [23:29] i think that would make it harder to update sites [23:30] how many site use it ? [23:30] i know of three [23:30] sites* [23:30] but i dont know [23:32] awe [23:33] ? [23:33] this need a lot work [23:33] of* [23:34] his branch or something else [23:36] changing the html will affect the tree other sites [23:36] cright [23:36] right [23:38] daker_: if we update the new website_base.html file and leave ubuntu_base.html then sites can update if they want [23:39] also we should leave the old css [23:39] yes [23:39] we may need to rename a couple files [23:44] it would be nice if we could all work on one team branch, but with him not being a team member, he has to ask for merges [23:45] we can do it [23:48] daker_: do you have time to go from his new branch and work on it in the next couple hours? [23:49] sure [23:49] awesome [23:49] let me know what help you need [23:49] im trying to work on something for the wife, but if you need any assistance I'll be happy to help [23:49] but i need to go to sleep [23:49] I'd love to get this released for Summit in the next couple days and then LTP in the few days after that [23:50] ok.. [23:50] do me a favor, commit whatever you have done before you go to bed and give me and Amoz a link to the branch so we can pick up from where you left off