=== jalcine is now known as webjadmin_
* mandel restarting due to updates10:18
* mandel back from update10:51
JamesTaitappport-bug compiz10:58
JamesTaitDammit. :(10:58
gatoxgood morning!11:01
JamesTaitAnd https://bugs.launchpad.net/ubuntu/+source/compiz/+bug/952887 is the bug I was filing.11:10
ubot5`Ubuntu bug 952887 in compiz (Ubuntu) "Transparent terminal windows and black backgrounds in other windows after kernel update" [Undecided,New]11:10
alecuhello all!12:00
gatoxalecu, hi!12:03
mandelwow... moving a folder in evolution has managed to screw up my system.. wtf!12:16
mandelalecu, gatox morning! :)12:17
gatoxmandel, hi12:17
urbanaperalsina, mandel, et al: Gotta run to a follow-up eye exam after dropping Lex off at school, so I might miss our standup. Here's my update:12:17
urbanapeDONE: Not much, I'm afraid. Floundered a bit, so started spelling out an actual ubuntuone-darwin-installer project to make some forward progress.12:17
urbanapeTODO: Dunno if briancurtin is back from PyCon this week or if he's participating in sprints, but maybe pair with him, otherwise keep going.12:17
urbanapeBLOCK: In the process of upgrading my machine to Lion, I seem unable to get the tests that we had running going again, so I'm a bit blocked on getting new tests for the darwin-specific code written.12:17
mandelurbanape, ok, good luck with the eyes tests, I hope your sight is as bad as it was :)12:18
mandelI need to go to the back to solve some little problem, Ill be back in a few mins12:41
nessitahello everyone!12:49
gatoxnessita, hi!12:52
ralsinagood morning!12:55
gatoxralsina, hi o/12:55
ralsinaurbanape: if you are still around, because of flight combinations, brian will only be back tomorrow12:56
ralsinaurbanape: and good luck with the eye-doctor!12:56
ralsinahello gatox!12:56
ralsinaNoone has commented on my app indicator. I am so sad I am going to start doing schedules and phonecalls like a manager should instead of coding.13:04
dobeyralsina: do i really need to comment?13:05
ralsinadobey: haha13:05
ralsinadobey: what would you say if I told you it has no twisted? That's a +1 from yu, right? ;-)13:05
dobeybut it's qt13:05
ralsinadobey: yes, that it is13:06
ralsinadobey: it's what I know. I am not doing vala on sundays.13:06
dobeydoesn't need to be vala. if we're going to provide an app indicator, it should be in syncdaemon, as the current messaging indicator integration is, i think13:06
dobeybut meh13:07
ralsinadobey: but the indicator should work even if syncdaemon is stopped13:08
ralsinadobey: IMVHO13:08
dobeyNew -> Opinion13:08
ralsinadobey: haha13:08
dobeyit's time to change our name to "GNU/Linux One"13:08
ralsinadobey: well, we are packaged for Fedora now!13:09
dobeynot exactly13:09
dobeyi wouldn't call running alien a .deb and turning it into an rpm "packaged"13:09
ralsinaif you squint and make loud noises, it feels like we are ;-)13:10
* mandel back13:10
mandelralsina, dobey wow... people have very interesting opinions. Also, I wonder if they know how many of us are in the desktop+ team, is not that we have the time to package this for everything13:18
rye_ralsina: i'd definitely rewrite my indicator in vala, having 50Mb of python process just showing a cloud is an overkill13:18
ralsinarye_: the indicator I did is totally redoablein C++13:19
rye_ralsina: but, I guess you need to write it in Qt13:19
ralsinarye_: except for the OAuth signing, which I have no idea how to do outside python13:19
rye_ralsina: ubuntuone-indicator is also totally redoable in anything that has DBus and HTTP library and sha1 somethings13:19
dobeyralsina: we should never write C++.13:19
dobeyralsina: unless it's to patch Qt or something upstream.13:19
ralsinadobey: ok, C# ;-)13:19
ralsinadobey: it's my own toy, don't be a killjoy ;-)13:20
rye_36 Mb now, in IDLE13:20
dobeyralsina: write it in go!13:20
rye_dobey: which brings us to the question - "HOW?" :)13:20
ralsinadobey: I was thinking cobra13:20
mandeldobey, go + dbus.. is not ready yet, right?13:20
ralsinago + libindicator?13:20
dobeyrye_: it has dbus client bindings13:20
ralsinago + oauth?13:20
rye_ralsina: oauth is kind of simple13:21
rye_once you have the tokens13:21
dobeymandel: you can't use it as a server, but you can as a client, at least13:21
ralsinarye_: I need signed URLs, how's that done?13:21
mandeldobey, oh, I did not know that13:21
dobeyralsina: exec oauth-sign which signs a url and prints the results on stdout. it's the unix way.13:22
ralsinadobey: the unix way is bumpy?13:22
rye_ralsina: sign them? http://oauth.net/core/1.0/13:23
rye_but still it is kind of weird that we are using qt binding for python to tak to indicator libarary which uses gtk13:24
ralsinarye_: and implementing oauth is exactly the kind of things that is not fun to do and for which a library written by security-aware people should already exist ;-)13:24
ralsinarye_: it was easy.13:24
ralsinarye_: and I am on uity-2d so qt all the way ;-)13:25
dobeyralsina: if only oauth was written by security-aware people… ;)13:25
ralsinadobey: well, I at least want I library full of /* <eye roll> */ and /* WTF!? */13:26
rye_ralsina: unity-2d is not using qt for the panel as far as I remember13:27
rye_dobey: ^ ?13:27
ralsinarye_:  no idea, really13:27
rye_ralsina: only launcher and dash13:28
dobeyhold on. disk i/o13:28
ralsinaNow onto real work and my freaky sunday project sleeps until sunday. Any pending reviews?13:28
ralsinarye_: ok, so Qt is on memory anyway13:28
dobeyrye_: uh. well, it links to both13:29
dobeyrye_: but i think it's rendering with qt. not sure where the gtk link comes from13:29
dobeyralsina: btw, were you checking bug #946626 with trunk, or plain ubuntu 12.04? :)13:31
ubot5`Launchpad bug 946626 in ubuntuone-control-panel (Ubuntu) "ubuntuone-control-panel does not adapt to length of translated messages" [Undecided,New] https://launchpad.net/bugs/94662613:31
ralsinadobey: trunk13:31
dobeyralsina: maybe it's fixed in trunk already, but not in the release?13:32
ralsinadobey: you tried it on last release and it fails?13:32
ralsinadobey: I can't go back to release because I am on nightlies13:32
ralsinadobey: and have no other P-box13:32
dobeyralsina: no, i'm just saying because i think the guy isn't running nightlies13:32
dobeyralsina: bzr branch lp:ubuntuone-control-panel -r release-2_99_90 ?13:33
ralsinadobey: booooooring13:33
ralsinadobey: testing it in 1'13:33
* dobey shsould change the system language on his computers13:34
ralsinadobey: bzr branch lp:ubuntuone-control-panel -r release-2_99_90 do you remember the revision name?13:34
ralsinaoops, I cut it off, it says that revision doesn't exist?13:35
dobeyralsina: oh. right. lp:ubuntuone-control-panel/stable-3-0 :)13:36
dobeyso you can just grab tip because i'm sure we haven't merged anythng else13:37
ralsinadobey: hehe, stable branches dude! ;-)13:37
dobeyit's early, dude13:37
ralsinadobey: yeah. Sorry, I am a little manic until I find the right sugar level13:37
* dobey puts on that bit of hendrix13:38
nessitagatox: this branch https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/ugly-reset/+merge/96130 looks great, but any chance you can apply this diff to the .ui file? I was curious why the width was getting increased, and why you were adding right margin to the page, so I played a little and found that that the fixed size for the ballong was too wide13:39
nessitagatox: the diff is http://pastebin.ubuntu.com/880337/13:39
* gatox looking13:40
ralsinadobey: looks good on 3-013:40
gatoxnessita, just asking: did you try that IRL and the widgets don't move when things appear?13:42
nessitagatox: yes13:42
gatoxnessita, ok then13:43
dobeyralsina: weird13:43
ralsinadobey: may be related to having a really really long name, though. Can I change mine somewhere?13:43
dobeyralsina: looks like he filed it against 2.99.513:43
dobeyralsina: and he doesn't have a long name, though it looks like in his screenshot, the window is maximized13:44
ralsinaso, I suppose we fixed it13:44
ralsinau1cp looks surprisingly nice maximized13:45
nessitagatox: hum, wait, I think I tested a not compiled version, let me re try13:45
gatoxnessita, ok ok13:45
dobeyralsina: you can't see the rest of the world to compare it to? :)13:46
ralsinadobey: haha the problem is yours is too tiny13:46
ralsinaanyway, gatox can I get a review for https://code.launchpad.net/~ralsina/ubuntuone-control-panel/translate-all-the-dialogs/+merge/96889 please?13:47
dobeyralsina: the fonts in qt control panel are hard coded :(13:47
gatoxralsina, yep, on it!13:47
ralsinadobey: really? file a bug please13:48
dobeywell they're all bold, and gigantic13:48
dobeyso i presume they are13:48
ralsinadobey: the "bold" thing is a known bug (and not ours, really)13:48
ralsinadobey: the size looks good here, but I have everything set as default, so I suppose I wouldn't notice13:49
gatoxralsina, +113:53
ralsinagatox: thanks!13:53
nessitagatox: confirmed this is the diff http://pastebin.ubuntu.com/880367/ (no need to change the ubuntu_sso/qt/reset_password_page.py file)13:54
gatoxnessita, ok13:54
* Chipaca returns from lunch13:54
Chipacagatox: hola! what did the machinalis guys do that was so awesome?13:54
* Chipaca curious :)13:54
nessitagatox: I noticed the label for the password assistance was bigger than the image, which is 198x9813:55
gatoxChipaca, about what? when? :P13:55
nessitagatox: so if we want the text to fit the ballon image, we need the label to be smaller than that, and to wrap13:55
Chipacagatox: oh, wait, old news13:55
Chipacagatox: machinalis responding to a tweet of you from ... february?13:55
gatoxChipaca, ahhhh they assign some hours from their developers to code ninja-ide13:56
gatoxChipaca, it was really helpful :D13:56
ChipacaI can imagine :)13:57
Chipacaglad they were carrying that spirit forwards13:57
gatoxChipaca, yes, it's really nice13:58
nessitagatox: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/forgotten-link/+merge/96814 globally approved13:59
gatoxnessita, great, thanks14:00
mandelok, lunch time for manuel14:04
* mandel lunch14:04
nessitaralsina: regarding the translate-all-the-dialogs, isn't there a more "generic" call that can be made? the code you added looks like it requires a lot of "manual" work, speacially the building of the translator.load("qt_" + locale, ...)14:06
ralsinanessita: nope,that's straight from the Qt docs14:06
nessitaralsina: bummer :-/14:06
ralsinanessita: yeah, not the prettiest possible code. I tried to test it as well as I could.14:07
nessitaralsina: looks good, approving14:07
ralsinanessita: thanks!14:07
gatoxnessita, the ugly-reset has been updated14:12
nessitagatox: awesome, will look after too-verbose14:12
gatoxnessita, ok14:12
urbanapehey, all.14:13
urbanapeLooks like I'm still good to go for LASIK on Thursday.14:13
urbanapeShould be back and fully functional after the post-op follow-up on Friday morning.14:13
nessitaralsina: in tab-tab-tab you have some leftovers (#self.is_processing = True). Also, question, is it really needed to move this code:14:13
nessita                child.icon_obj = icon  # hack!14:13
nessita                child.setIcon(FOLDER_NAME_COL, icon)14:13
nessita                item.addChild(child)14:13
nessitabefore the if like the branch is doing?14:13
ralsinanessita: looking14:17
ralsinanessita: yes, you can't add widgets to a QTreeWidgetItem that is not added to a QTreeWidget14:18
nessitaralsina: ah, ack14:18
ralsinanessita: if you do, they all end invisible stacked in the top-left corner of the QTreeWidget14:18
ralsinanessita: that took me 2 hours to figure out, BTW ;-14:19
nessitaralsina: would have taken more to me ;-)14:19
nessitagatox: too-verbose approved14:20
gatoxnessita, cool14:20
ralsinanessita: removed the comment, will check the diff in a bit to find other randomness14:20
nessitaralsina: ack14:20
nessitagatox: not sure if you got it from before, but with the new changes to the ui file there is no need to add changes to ubuntu_sso/qt/reset_password_page.py14:22
gatoxnessita, i'll check that right now14:22
nessitagatox: thanks!14:23
=== JanC_ is now known as JanC
gatoxralsina, can you review this: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/too-verbose/+merge/96364 when you have a moment?14:24
ralsinagatox: of course!14:24
gatoxralsina, thanks14:24
dobeyi won't say anything :)14:28
ralsinadobey: failed at that! ;-)14:28
gatoxnessita, :S did you really test it IRL? ugly-reset?14:32
nessitagatox: yes, I did, but le me try again?14:32
nessitagatox: wanna push the latest you have?14:32
gatoxnessita, the balloon is not aligned with the password..... a spacer was removed14:32
gatoxin your diff14:32
nessitagatox: how are youy running this?14:32
nessitaI removed a spacer that was doing nothing (I think :-))14:33
gatoxnessita, jejee was aligning the balloon with the line edits :P14:33
dobeyralsina: https://bugs.launchpad.net/ubuntuone-control-panel/+bug/95306214:34
nessitagatox: ASCO TOTAL :-D14:34
ubot5`Ubuntu bug 953062 in Ubuntu One Control Panel "Font and sizes are hard-coded" [Undecided,New]14:34
nessitadobey: yes! that's true :-)14:34
gatoxnessita, what??14:34
nessitagatox: using spacers to align stuff that may changed  because line wraps or font changes is ulgy, IMHO14:35
ralsinanessita: I know we hardcoded them for windows, but on Ubuntu we should follow the desktop. The default is ubuntu font anyway.14:35
dobeyralsina: the .qss is compiled into the control panel regardless of what platform we're on14:35
nessitaralsina: we need to have the same looks in every OS... I understand that that means do not change the looks if the theme changes, no?14:35
ralsinadobey: I know14:35
gatoxnessita, but it looks  uglier now14:35
nessitadobey: yes, because of that ^14:35
dobeyralsina: and it is where the fonts are defined14:36
ralsinanessita: but suppose for example, a locale where ubuntu font doesn't have the glyphs...14:36
dobeynessita: i don't think it means "don't follow the theme"14:36
nessitagatox: then we need a grid there instead of what we have, and have the ballon in the "second" row instead of using a spacer to align it14:36
ralsinanessita: since the default is ubuntu, I think we can be a bit lax in Ubuntu14:36
dobeynessita: to me, it means "follow the same general layout and workflow"14:36
nessitadobey: well, we can ask, but I understood is "also follow the same colours, fonts, sizes, and shapes"14:37
ralsinadobey: we may add "keep branding color scheme" but I am with you on the fonts. Let me ping upstairs.14:37
dobeytheme != branding14:37
dobeyi understand how marketroid types can get that confused, though14:37
gatoxnessita, ok..... i'll change the layout of that page then14:38
nessitagatox: ack, try to keep it as simple as possible14:39
ralsinadobey: let's not have that argument now, when I am on your side on the fonts issue mmmmkay? ;-)14:39
ralsinagatox: +1 on verbose14:40
gatoxralsina, thanks14:40
dobeyit's not an argument. it's a fact. simply because i'm not on the design team, doesn't make me not a designer :)14:40
* ralsina goes back to coding mumbling grmblcocacolaredwhiteyaddambrgl14:41
dobeywe can just bring back the old applet and preferences :P14:42
ralsinadobey: wanna rotate to design in the R cycle?14:43
ralsinadobey: you'd have to move to london and work in an office though. With people.14:43
ralsinadobey: cool, we need you (group hug!)14:48
ralsinanessita: tab-tab-tab looks clean to me now (revno 291) but maybe I am just tired of looking at it14:52
nessitaralsina: will look after a couple of on going reviews14:52
ralsinanessita: thanks14:52
* nessita will review all morning and will hack undergrounf after lunch14:52
dobeyhttps://code.launchpad.net/~dobey/ubuntuone-client/transient-notify/+merge/96815 can has reviews?14:53
ralsinadobey: on it!14:53
ralsinanessita: remember tech leads, but if you want to skip it, do me a briefing14:53
nessitaralsina: may attend and do noth, lowering attention to teach leads14:54
nessitawill not type correctly today, though14:54
ralsinanessita: cool, will ping you on IRC if I need you14:54
* mandel back14:55
dobeydamned dst.15:01
ralsinanessita: standup!15:03
gatoxalecu, nessita?15:03
ralsinaurbanape is at the doctor's15:03
ralsinaso gatox go!15:03
gatoxPropose some branches to improve the logging operations in u1-sso (landed), propose a branch that fixes a unicode bug in current user sign in page in u1-sso (landed).15:03
gatoxRefactoring the ui layout for Reset Password page, started working on Bug #940392.15:03
nessita(alecu and I are debugging a weird issue, sorry)15:03
ubot5`Launchpad bug 940392 in Ubuntu Single Sign On Client "Qt UI: policy_link gets cut off at the end" [High,In progress] https://launchpad.net/bugs/94039215:03
gatoxmandel, go15:03
ralsinaalecu is last15:03
mandelDONE: Implemented ssl error handeling in webclient libsoup. Got to deal with errors correctly I need to find out how to load the cert details from the pem file (probably I just need to look at openssl)15:03
mandelTODO: Read cert details from pem. Propose branch move to pinned certs.15:03
mandelBLOCKED: no15:03
mandelCOMMENTS: nessita I added bug 952880 at the moment appname is a kwarg so that we do not brake control panel but we should make it an arg.15:03
ubot5`Launchpad bug 952880 in Ubuntu One Control Panel "The app name is not passed to the webclient" [Medium,Triaged] https://launchpad.net/bugs/95288015:03
mandelralsina, please!15:03
ralsinaDONE: a few branches, wrote a prototype indicator, reviews TODO: finish pushing tab-tab-tab tech leads call, pick a fewmore bugs, more reviews, administrivia,  BLOCKED: no NEXT:  dobey15:03
dobeyλ DONE: initial installer changes, bug #88736915:04
dobeyλ TODO: finish installer, bug #951425, bug #93420615:04
dobeyλ BLCK: none.15:04
ubot5`Launchpad bug 887369 in Ubuntu One Client trunk "Please use transient hint so notifications in Gnome Shell stay out of the way" [Low,In progress] https://launchpad.net/bugs/88736915:04
ubot5`Launchpad bug 951425 in Ubuntu One for Rhythmbox "Ubuntu One plugin has problems when being enable/disabled" [Undecided,Confirmed] https://launchpad.net/bugs/95142515:04
ubot5`Launchpad bug 934206 in rhythmbox-ubuntuone (Ubuntu Precise) "track duplication from RB-U1" [High,Confirmed] https://launchpad.net/bugs/93420615:04
nessitano notes, writting15:04
ralsinanessita: DONE: got bitten by mistery animal15:04
nessitaor more than one, perhaps15:04
nessitaDONE: started adding wizard pages to controlpanel, tons of reviews15:04
ralsinaalecu: you are after nessita15:05
alecuDONE: fixes for reviews: refactored tunnel_runner so tunnel_client can be in a different package15:05
alecuTODO: finish bug #92921215:05
alecuBLOCKED: no15:05
ubot5`Launchpad bug 929212 in Ubuntu One Client "[FFE] Tunnel webservice calls if proxy is enabled" [High,Confirmed] https://launchpad.net/bugs/92921215:05
nessitaTODO: finish all the things I started in the DONE :-)15:05
nessitaBLOCKED: no15:05
nessitaNEXT: alecu but he already went :-D15:05
ralsinaalecu: precoz!15:05
nessitasorry for being distracted, but we have a weird issue with the new tunneling process in syncdaemon15:05
nessitaok, eom?15:05
ralsinanessita: it's ok15:05
nessitaNOTE: tomorrow I'm not coming to work!15:06
ralsinanessita: before you hibernate if you want to throw a few bugs my way, I will appreciate it!15:10
nessitaralsina: wanna fix the tests using the es lang? :-)15:10
ralsinanessita: happy to15:11
nessitaralsina: most of those need to use unicode :-)15:11
ralsinanessita: it's just adding unicode() around things15:11
nessitaralsina: hem... not sure if is that...15:11
ralsinanessita: at least the ones I looked are comparing unicode objects and QStrings15:11
nessitaralsina: ok, I'll leave it to you15:12
ralsinanessita: cool, thanks15:12
dobeyalright, need to get lunch, bbiab15:19
* gatox lunch!15:28
ralsinanessita, gatox, alecu,mandel: whenever you use strings you get from the UI on tests, convert to unicode first: https://bugs.launchpad.net/ubuntuone-control-panel/+bug/951716/comments/115:50
ubot5`Ubuntu bug 951716 in Ubuntu One Control Panel "Runing tests with LANG set makes some tests fail" [Low,In progress]15:50
ralsinaI will do a check and fix all the ones I find, but from now on, keep it in mind.15:50
gatoxralsina, yes15:51
alecuralsina, perhaps we can remind about that on the team meeting.15:51
mandelralsina, because writing a method in the test case in ubuntu one devtools for that is not an option?15:51
mandelralsina, I mean, we can ensure that the self.assertEquals does the right thing15:51
ralsinamandel: what would the right thing be?15:51
ralsinamandel: not typecheck and convert all QStrings beforehand, right?15:52
mandelralsina, I don't know what the right thing is, but certainly do not go hunting after string everywhere when you can do it in a single place, right?15:52
mandelralsina, and looking at that message = we need to manually convert the QString to unicode prior to comparison.15:53
mandelralsina, type checking in an assert is not THAT ugly15:53
ralsinamandel: but to typecheck that, we need to import QtCore in devtools15:53
ralsinaand dobey will have a stroke ;-)15:53
mandelralsina, make a QtTestCase and just import it when you need it, like the qtreactor thing15:54
nessitamandel: naaaaaaah15:54
nessitawe already have so many base test cases :-)15:54
ralsinamandel: and then I have to see all the things that use this and change their ancestors? That's even trickier :-)15:55
mandelralsina, nessita ok, as you please, I just don't like to type, the more I type the more typos!15:55
ralsinait's not even that important since tests always succeed in english ;-)15:55
ralsinaI assume setting the locale to chinese will trigger all possible failures, too15:56
mandelalecu, I'm getting a dirty reactor: <TLSMemoryBIOProtocol #0 on 42424> with libsoup but not with qtnetwork.. have you seen that already?16:00
ralsinanessita: tech leads!16:02
alecumandel, have you made sure that libsoup has disconnected?16:25
alecumandel, usually it's the library (qt or libsoup) still connected for the next request (http/1.1)16:25
mandelalecu, I found the issue, we are just storing a single protocol instance, by appending them and then closing the connection from there is sorted out16:26
dobeymandel, ralsina: why would we need to add a utility function to devtools?16:26
mandelalecu, I'm done with the libsoup + ssl branch, will propose in a few mins16:26
ralsinadobey: worry not, we will not16:27
mandeldobey, I was proposing to add an assert that will deal with the issue that ralsina pointed out about unicode and QStrings in ui tests..16:27
mandeldobey, so, ignore it :)16:27
dobeywe could add an assertUnicodeEqual() without the need for adding a QtCore import16:29
lamalexhi, i published  a file but when i go to th elink i just get could not locate16:31
dobeylamalex: it opens it here. shinke.zip16:31
lamalexguess ijust didnt wait long enough16:32
lamalexcould use a better error message16:32
dobeylamalex: is it just a plain text error, or stylized page?16:34
lamalexplain text16:34
lamalexits not happenign now, now i get the zip16:34
dobeylamalex: file a bug that the error message could be better. we should probably have the stylized error page pop up, and say "Please try again in a few minutes." or something16:35
mandelnessita, alecu proposed the ssl for libsoup implementation here: https://code.launchpad.net/~mandel/ubuntu-sso-client/libsoup-ssl-dialog/+merge/97057 I added both of you for the reviews, I'm moving to the pinned certs (I don't know if there is a bug for that)16:42
nessitamandel: ack16:42
nessitamandel: perhaps you wanna takcle the passing the app+name to the webclient?16:42
mandelnessita, sure is a very easy one, is there a constant for the control panel app name?16:42
mandelgatox, do you know if there is an appname var in control panel?16:48
gatoxmandel, nop, i don't know that about control panel16:48
gatoxmandel,  but, i don't think so....16:48
gatoxat least for me, it doesn't have much sense, because it's only an app....16:48
gatoxunless you want to reuse "Ubuntu One" string in several places maybe16:49
gatoxmandel, in that case..... check at the __init__ with the translations16:49
dobeygatox: why would there be?16:49
mandelgatox, is just to show the Ubuntu One thing on the ssl errors.. I'll use the ubuntu one string16:49
dobeymandel: why would there be? cp doesn't work for other services :)16:49
gatoxdobey, that's what i said16:50
mandeldobey, I'm asking just in case16:50
dobeymandel: the app name string that gets passed to SSO is in ubuntuone.credentials which is currently in ubuntuone-client16:50
mandeldobey, ok, thx!16:50
gatoxmandel, look hoow the cp call the login from sso16:50
gatoxmandel, that's the place where you will see if there is any, or how is being done right now16:50
nessitaalecu: ping16:53
nessitabah, perhaps mandel?16:53
nessitasso dailies are failing with:16:53
nessita  File "/build/buildd/ubuntu-sso-client-3.1+r907/ubuntu_sso/utils/webclient/tests/__init__.py", line 20, in <module>     from twisted.internet import ssl   File "/usr/lib/python2.7/dist-packages/twisted/internet/ssl.py", line 23, in <module>     from OpenSSL import SSL ImportError: No module named OpenSSL16:53
nessitaoops, that does not look good16:53
nessitamandel, alecu: did we add a new dep on ussoc? http://pastebin.ubuntu.com/880624/16:54
mandelnessita, AFAIK no because openssl is already a dependency of twisted16:54
nessitamandel: perhaps is a specific twisted package we're not depending on?16:55
mandelnessita, yes, I'm checking right now16:55
nessitahum, no :-/16:55
nessitanessita@dali:~$ dpkg -S /usr/lib/python2.7/dist-packages/twisted/internet/ssl.py16:55
nessitapython-twisted-core: /usr/lib/python2.7/dist-packages/twisted/internet/ssl.py16:55
mandelnessita, the ssl namespace of twisted needs to have pyopenssl installed16:57
mandelnessita, I'm surprise that the twisted package does not get that as a dependency16:57
nessitaseems like python-openssl is needed, looking at the packaging branch16:57
dobeymandel: same reason squid doesn't ship ssl support in ubuntu16:57
nessitaralsina: tab tab tab approved16:58
dobeyi think16:58
ralsinanessita: cool, thanks!16:58
* nessita fixes16:58
mandeldobey, but.. I mean, it should be marked as a dependency in the .deb, right?16:58
dobeymandel: not necessarily16:58
ralsinawe could act gracefully if that is not available?16:59
dobeymandel: twisted doesn't Depends: on gtk3 gtk2 gtk1 and glib2 and glib1 and all the various python bindings, for example16:59
ralsinagatox: could I get a second review for https://code.launchpad.net/~ralsina/ubuntuone-control-panel/tab-tab-tab/+merge/96687 ?16:59
nessitamandel: sometimes it makes, if there is an issue with dependencies16:59
gatoxralsina, of course.....17:00
mandeldobey, AFAIK twisted.internet.ssl is in python-twisted17:00
dobeyas is gtk2reactor.py17:00
mandeldobey, yes, in python-twisted-core we have /usr/lib/python2.7/dist-packages/twisted/internet/ssl.py witch uses pyopenssl..17:01
dobeymandel: yes. and many other things, which use many other things, though the twisted package itself doesn't depends on them17:01
mandelbut I have no idea on packaging.. maybe there is an issue with that, but I find it odd that we let people install that without the required openssl lib17:01
dobeymandel: because ssl isn't a requirement for the twisted library itself to work17:01
dobeymandel: if you want to use gireactor in your app, you need to depends on python-gi in your app package. and if you want to use ssl, you'd need to depend on what the twisted ssl module depends on, to work17:02
mandeldobey, as I said, I have no idea, but if it is like that I would have imaging there was a python-twisted-ssl package with that dependency17:02
nessitadobey: so, there is not licensing issue with python-openssl? can I add it to the depends, right?17:02
dobeynessita: add it to the depends of what?17:03
nessitadobey: python-ubuntu-sso-client17:03
dobeynessita: ubuntu-sso-client is GPL right?17:04
nessitalet me confirm17:04
nessitadobey: yeah gpl v317:04
dobeynessita: i think that's a problem then17:04
nessitadobey: so the window release we're making also have this issue?17:05
dobeyif it's using openssl, yes17:05
dobeyis today Licensing Problems Monday or something?17:06
nessitadobey: maybe, why? :-)17:06
mandeldobey, nessita yes, the windows release is also using openssl because it was stated as a dependency of twisted on windows17:06
dobeyralsina: ^^ we have another problem :(17:06
nessitadobey: add to that u1client, which also uses17:07
mandeldobey, so having an apache license library is a problem?17:07
nessitafrom twisted.internet import ssl17:07
gatoxralsina, +117:07
mandelnessita, where is that in control panel?17:07
nessitamandel: where did you read coontrol panel? :-)17:07
nessitaI said "u1client" :-)17:07
dobeynessita: *sigh* :(17:07
mandelnessita, oh, miss read!17:08
nessitaralsina, alecu, dobey, mandel (if you can, I know may be late for you): let's have a talk in 1 hours, please, regarding this licensing issue? I need to have lunch17:08
=== JanC_ is now known as JanC
ralsinanessita: ack17:08
mandelnessita, I can make in an hour, if is not terribly long :)17:08
nessitamandel: in the mean time, can you analyze if we can make the ssl dependency optional, both in sso and in u1client?17:09
mandelnessita, certainly17:09
dobeywell actually17:09
dobeyit's an easy problem to solve for us17:09
dobeysince we own all the copyright17:10
dobeyso not a *huge* problem17:10
ralsinayes, we may have to add an exception17:17
dobeybut since all the base are belong to us, it's easy17:18
ralsinadobey: he17:18
ralsinadobey: indeed. There is even a standard "gpl but let me use openssl" license somewhere17:18
ralsinanessita: I can't make it at 3PM ART I have to pick up the kid17:26
ralsinanessita: what's the meeting about? Getting an exception for it, or something technical? If it's just the exception I cna just contact the lawyers to get approval.17:27
ralsinadobey: got the ok about soft-coding the font family && size17:32
ralsinadobey: should not need a UIFe since the default is what we have now, IIUC17:32
dobeyralsina: i don't think the font sizes are all the same as default. the font face is, but sizes not so much17:33
ralsinadobey: ok, so at least we can unhardcode that17:34
dobeyhrmm, i wonder if some of the font sizes are set outside of the qss17:34
ralsinadobey: wouldn't surprise me17:35
ralsinadobey: I will do some experimenting. If I can get a screenshot without visible changes, I'll just do it. Then I need to think how to re-enable it for windows only.17:35
dobey'<br><span style=" font-size:16pt;">%s!</span>'17:35
ralsinadobey: grr indeed17:36
ralsinadobey: but hey, if everything was perfect, we would be on foodstamps.17:36
ralsinaand there are no fodstamps here!17:36
dobeyi have a branch that removes the font-face and sizes from the qss, already17:37
ralsinadobey: care todo a before/after shot?17:37
dobeyuploading now17:43
dobeybut i am not using the default fonts17:43
dobeylp:~dobey/ubuntuone-control-panel/system-font is the branch17:46
alecuralsina, dobey: aren't we using openssl+twisted in u1-client since forever?17:46
dobeyalecu: shhhhhh17:46
ralsinadobey: ok, so two hardcoded fontsizes at least17:47
ralsinadobey: care to try switching them to something like 200% instead of 16pt? (or whatever)17:47
dobeyralsina: i left the PERCENT and NAME bits alone17:47
dobeysure i'll try17:47
dobeyralsina: it doesn't like %17:49
ralsinadobey: frak17:49
ralsinadobey: right, only pt and px17:50
ralsinadobey: which is a pain in the ass of apocalyptic proportions17:50
ralsinawe could precalculate them but then it will react badly on theme changes17:51
dobeyralsina: doesn't seem to like em either :(17:51
ralsinadobey: can you push thatbranch somewhere so I ca play with it?17:51
dobey13:46 < dobey> lp:~dobey/ubuntuone-control-panel/system-font is the branch17:51
ralsinadobey: thanks17:52
dobeybonus is this makes the "giant translations" bug eaiser to deal with, too :)17:52
ralsinaWHOA school run now!17:52
alecunessita, when you return, I've added a small fix for the "second connection attempt" issue that you've found.17:53
alecunessita, so, please re-review when you can.17:53
=== beuno is now known as beuno-lunch
=== beuno-lunch is now known as beuno
nessitaalecu: ack17:57
* nessita is back from lunch17:57
nessitadobey: so, how can we workaround/fix the ssl licensing issue?17:57
nessitadobey: I read backlog and you perhaps mentioned there is a chance/way?17:58
mandelnessita, gatox can I have a very easy review: https://code.launchpad.net/~mandel/ubuntuone-control-panel/add-app-name/+merge/9707117:59
nessitamandel: sure18:00
gatoxmandel, yes sir18:00
mandelnessita, can we have the quick mumble now?18:01
mandelnessita, the one regarding openssl18:01
nessitamandel: ralsina is gone in school run, so I was waiting for him. Feel free to eod if you have to, really :-)18:01
nessitamandel: besides I m waiting on what dobey can say about a possible workaround?18:02
mandelnessita, I can wait a little, I'll give him 10 min, then I'll have to go18:02
dobeynessita: there isn't much to say. we have to add the exception to our license18:03
nessitadobey: is that doable? can you please teach me so I update nightlies and then the ubuntu packaging?18:04
gatoxmandel, HEY!! WHERE IS THE TEST?! jeje18:04
mandelgatox, kahdlashd18:05
dobeynessita: i think ralsina is wanting to mail legal18:05
gatoxmandel, jejeje just kiding....... or  not ¬¬ jeje18:05
nessitagatox: NF!!!18:05
nessitathat definitely needs tests18:05
gatoxmandel, what happens if i call that without the appname?18:06
gatoxok..... nf18:06
mandelnessita, gatox atm it will work, in my next sso push it will brake and all tests will brake too!18:06
dobeynessita: oh, i guess alecu's branch landing also broke the client builds18:07
gatoxmandel, i think you can test what is being done with that argument that the class is receiving or something..... maybe i'm wrong.... but that's my idea18:08
dobeynessita: are you also fixing that, or should i?18:08
mandelgatox, yeah, I can assert that the factory does indeed get the parameter, but it the webclient brake form the sso side it does not make sense..18:09
nessitadobey: I can fix both, if you teach me about me the "exception" we need to add in our end18:09
mandelgatox, maybe asserting that the correct app_name is passed is a better test..18:09
nessitamandel: what thing will break? (sorry, not following)18:10
mandelnessita, atm the app_name in the webclient is a kwarg so that I did not brake the work done already in control panel when it landed, now once the control panel passes it appname will be an arg18:11
mandelnessita, so, if you don't pass it you won't get a webclient18:11
dobeygah, i think my current usb keyboard is usb 1.018:11
mandelnessita, is to ensure that the correct appname is in the sso dialogs18:11
nessitamandel: ok, but why the fact that the app_name is not mandatory does not allow you to add tests for the controlpanel? (or at least that's what I understood)18:12
dobeyindeed it is18:13
mandelnessita, no, what I meant to say is that I did not add them because if you do not pass the app_name in the next version of sso everything will brake and I did not considered the tests to be needed18:13
mandeldobey, you type so fast you need it to be 3.0?18:13
nessitamandel: any change must have it's test/s :-)18:14
dobeymandel: it has a built-in usb hub, so the 2 GB of data transferring of this usb stick was going extremely slow18:14
mandelnessita, ok, I'll add tests then..18:14
mandeldobey, oh, makes sense18:14
dobeymandel: ~16M/s is much faster than ~1M/s :)18:14
mandelnessita, ok EOD for me, I'll add the tests tom18:14
dobeyit's a usb 2.0 device though, so a usb 3.0 port probably wouldn't help :P18:14
nessitadobey: so, any advices/links on what should I add besides the new dep on python-openssl?18:15
dobeynessita: wait for ralsina18:15
dobeynessita: he said he was going to mail legal18:15
dobeynessita: so we should wait for that. but should go ahead and make nightlies build i think18:15
mandeldobey, he, you know things are going to go fast when you mail legal ;)18:16
mandelok, time to go and do all the errands I call life, see you tom!18:16
dobeymandel: it only took ~4 years to get Novell legal to approve relicising tango-icon-theme :P18:16
mandeldobey, lol18:16
nessitadobey: ack then, will push to both nightlies18:17
ralsinadobey, nessita I am back18:21
ralsinadobey, this is a slightly less controversial legal matter. Not to mention that we *do* want to ship it ;-)18:21
dobeywell yes, we basically have no choice in the matter18:22
ralsinadobey: what do you think, needs a UIFe? http://ubuntuone.com/0dHmwZ1BiRlM909ZVtBnSM18:37
dobeyralsina: heh, the fonts we hard-coded it to are smaller than the defaults in ubuntu? nice.18:38
ralsinadobey: but *bolder* ;-)18:39
nessitaralsina: the screenshot in the back does not have ubuntu font, no?18:39
ralsinanessita: I am doubting ow if I tweaked fonts here18:40
ralsinaI will try in a clean account18:40
dobeyso, given that cp-qt isn't in the default install, and i don't think there are any screenshots of it in the docs, i'd say it doesn't need one18:40
ralsinaRight, I have andale mono 11 as font for some reason!18:41
ralsinabut that's not a mono font.Weirder and weirder.18:41
dobeyandale mono?18:42
dobeyi don't think so18:42
ralsinaclean account time, I suppose18:43
dobeyi don't think the default font is ubuntu, on ubuntu.18:43
dobeyalso, the bold text everywhere in the control panel is an issue with the ubuntu font, it seems18:44
ralsinayes, and mostly with only the ubuntu font18:44
nessitadobey, ralsina: so, I think that we need to ensure that the u1cp gets the ubuntu font... from my POV is part of the branding18:44
dobeynessita: on windows, yes.18:45
nessitadobey, ralsina: regarding the bold, I think is an issue with the qt theme and gtk18:45
nessitadobey: from my POV, not only on windows. On every OS.18:45
nessitadobey: but we can ask design to confirm that18:45
ralsinanessita: yes, but it only happens for the ubuntu font because it uses a "advanced" way to specify the weight of the font variants18:45
dobey13:32 < ralsina> dobey: got the ok about soft-coding the font family && size18:46
nessitadobey: I'm pretty sure the approved was on the base that ubuntu is the edfault font on ubuntu :-)18:46
nessitaralsina: o no? ^18:46
dobeynessita: there's a big difference between "default font" and "forcing the font family"18:47
nessitadobey: maybe, will not argue about that. My point is that I think design expects the font in the u1cp to be UBuntu font, on every OS (no matter if it's hardcoded, default, or foo). But again, I haven't ask so explicitly and perhaps we shou;d18:48
ralsinanessita: I have asked cristian18:48
ralsinanessita: "<cparrino> ralsina - was under the assumption that we were already picking up the theme, so I'm ok with your suggestion"18:49
nessitaralsina: may I see the question as well? :-)18:49
ralsinanessita: where my suggestion was ": branding question! Can we make the font on the control panel follow the theme on Ubuntu? Currently it's hardcoded to ubuntu font, which makes sense on windows."18:49
dobeyralsina: of course, i think my branch also breaks that on windows?18:50
ralsinadobey: yes, so we need to tweak that18:50
ralsinadobey: I am happy to be the tweaker if you have other stuff to do18:50
nessitaralsina: ok then18:50
ralsinaI am happy to report that we look much nicer with the default font in a fresh account.18:51
ralsinaHowever, u1cp is slightly taller18:51
dobeyralsina: my cup overfloweth. but would be nice if i knew *how* the tweaking is supposed to work18:51
dobeyralsina: how did you make the big fonts work?18:51
ralsinadobey: basically, we need to have a separate windows.qss that only loads on windows (before or after ubuntuone.qss)18:51
ralsinadobey: have not fixed that yet18:52
ralsinadobey: it just happens to look decent at default font size :-)18:52
dobeydoes qt not have a <really-big> tag or whatever for the text?18:53
dobeyinstead of 16pt can we not just say xx-large?18:53
ralsinadobey: in the html? maybe18:53
dobeywe can18:53
* ralsina goes read the "this is the weird html+css2 subset we support in labels" doc again18:54
dobeyalthough i am seeing a weird issue now18:54
dobeythe top of the "1% used" bit is getting covered up18:54
ralsinadobey: push?18:55
dobeyralsina: done18:56
ralsinadobey, care for a very simple branch review? https://code.launchpad.net/~ralsina/ubuntuone-control-panel/lang-tested18:57
ralsinadobey: not seing the % being cutoff18:58
ralsinadobey: may be because you are in gnome3 and all that which caused different visuals on friday18:58
dobeyralsina: eh? that shouldn't matter. unity is mostly a special case of gnome18:59
ralsinadobey: yes, but the qt theme is picking style hits from gtk18:59
ralsinadobey: so, different styles in gtk can cause visual differences18:59
dobeywell it could be a weird bug in qt19:01
dobeyor a result of my font selection19:01
ralsinadobey: can you merge trunk so I get a smaller diff in the qss?19:01
ralsinadobey: yes, you are sort of a corner case on fonts19:01
dobeyeh? did you change something in trunk recently?19:01
ralsinadobey: define recently :-)19:01
dobeyin the last few hours19:01
ralsinadobey: well, a branch or two merged19:02
ralsinadobey: not sure they touched the qss19:02
ralsinaoh, my truk was out of date. nevermind19:02
dobeyyeah nothing changed in trunk qss :)19:02
ralsinadobey: but I have a large diff on the qss of your branch not just fonts!19:03
ralsinaoh... lots of context19:03
* ralsina hates diff now19:03
nessitaralsina: can you please propose the same lang-tested branch for ussoc? :-)19:05
nessita(when you have some slot)19:05
ralsinanessita: happy to!19:05
ralsinanessita: can you file the bug? I am kinda juggling things right now :-)19:05
nessitaralsina: should be the same bug also affecting ussoc19:06
nessitaI can do the also affects bits19:06
ralsinanessita: then it's ok, I'll do it19:07
nessitaralsina: already done!19:07
ralsinanessita: cool, thanks!19:07
dobeynow i just wish synergyc would stop crashing19:08
ralsinadobey: synergic used to be real stable, I had to disable it because it's become crap the last 6 months :-(19:09
ralsinaNow I can't fix my wife's computer without standing up19:09
dobey#0  0xb757abf2 in std::_Rb_tree_increment (__x=0x8b0a75c0) at ../../../../src/libstdc++-v3/src/tree.cc:6519:10
dobeylovely :-/19:11
dobey"let's include our own copy of the c++ stdlib"19:11
dobeyi wonder if i can just install an old version and have it work19:13
ubot5`Error: ubuntu bug 926198 not found19:13
dobeyle evil19:13
dobeyoh right19:13
ralsinadobey: is the openssl linking a new thing? We have been using https and stuff since ever19:13
dobeyralsina: it's new in ubuntu-sso-client. we've been ignorant with ubuntuone-client forever19:15
ralsinaok, so it's mostly old news but we just figured it out19:15
ralsinadobey: it's just u1-client and ussoc? No u1cp?19:16
dobeyralsina: i'd say we should just add the exception to anything we make that is GPL, to be safe.19:17
dobeyralsina: cp will need it for proxy stuff i'm sure, anyway19:17
ralsinadobey: right19:18
ralsinadobey: I am happy to approve system-fonts as it is now if you file a bug about forcing the ubuntu font on windows for me to tackle later19:24
nessitadobey: so, for client packaging dailies I need to edit the control.in, right?19:27
dobeyralsina: https://bugs.launchpad.net/ubuntuone-control-panel/+bug/95331819:28
ubot5`Ubuntu bug 953318 in Ubuntu One Control Panel "Windows styling affects Ubuntu themes as well" [Undecided,Triaged]19:28
dobeynessita: yes19:28
nessitadobey: acxk19:28
nessitafirst missing build dep is python-qt4reactor, so will add that as a first step19:29
dobeynessita: it's the only thing that needs added afaik19:30
dobeynessita: we also need to add the new binary package for the proxy tunnel stuff, though19:30
nessitadobey: yes, but the tests will be run for the proxy module, no?19:30
nessita(if the proper deps are there, squid y apache2-utils)19:31
dobeyso adding the build-dep should fix that19:31
nessitaso I guess the proxy tests will fail as well19:31
nessitaI didn't add the python-openssl yet, I'm waiting to see the actual error19:31
nessita(sanity check)19:31
dobeyor just get skipped19:31
nessitalet's see19:31
dobeypython-openssl is probably arleady in there19:31
nessitadobey: in u1client/packaging-dailies? naha19:32
nessitanessita@dali:~/canonical/client/packaging-dailies$ grep openssl *19:32
dobeyrly? that's odd19:32
nessitadobey: why would it be there already?19:32
dobeynessita: well it's been using it for years19:32
dobeyand the tests haven't been failing19:32
nessitadobey: perhaps you're confused?19:32
dobeywhy would i be confused?19:33
nessitadobey: u1client was not using ssl directly so far, was just telling the reactor to connectSSL (but was never importing twisted.foo.ssl)19:33
nessitadobey: what triggers the IMportError on openssl is importing twisted.foo.ssl19:34
nessitadobey: OTOH, protocol does list python-openssl as dep :-)19:34
dobeyprotocol imports it19:34
dobeynessita: but it's been importing that module from protocol, which imports ssl19:36
dobeynessita: but i think protocol already depends: python-openssl, which is why it worked19:36
nessitadobey: that's what I said :-)19:36
nessitadobey: OTOH, protocol does list python-openssl as dep :-)19:36
nessita(at (04:34:39 PM) )19:37
dobeyi didn't see that19:37
dobeyas i was on another workspace, looking at the source :)19:37
dobeyralsina: so i should propose my system-font branch as-is?19:38
ralsinadobey: hmmm maybe leave the ubuntu font family in19:39
dobeynessita: btw, can you upload patches to ubuntu for the broken 'link' things in sso and control-panel?19:39
ralsinadobey: then I will remove it forUbuntu on the fix for the other bug19:39
ralsinaand we go flexible size on both platforms19:39
nessitadobey: yes, sure. But, what link is broken on controlpanel?19:39
dobeyralsina: hrmm, ok19:39
dobeynessita: 'sign in' ?19:39
nessitaI know about the broken link for "password forgotten" only19:39
nessitadobey: where?19:40
dobeyan no19:40
dobeyit's in sso also19:40
dobeybug #95158419:40
ubot5`Launchpad bug 951584 in ubuntuone-control-panel (Ubuntu) "Cannot sign in to Ubuntu One - "Sign in" button disabled" [Undecided,Confirmed] https://launchpad.net/bugs/95158419:40
nessitadobey: that's another bug, more complex and un-debugged so far :-/19:40
dobeynessita: are we setting the button insensitive until the form is filled?19:41
nessitadobey: yes, design spec19:41
dobeynessita: simple solution then: "don't do that" :)19:41
nessitadobey: guess my answer :-)19:41
dobeynessita: i'd rather have people using our software, than trying to be perfect with design doc19:41
dobeydesign is useless if people can't use it19:42
dobeywe can fix it to be right later19:42
dobeyfor now, please make it work :)19:42
nessitadobey: that would just make having reports "clicking on sign in makes the app crash". Apparently there is a race condition when the backend is not ready in time19:42
nessitadobey: is not that simple, if you please read me, you may help come up with a solution that actually works (and not just moves the error somewhere else)19:43
dobeywell i didn't know the code was broken in that way19:43
nessitadobey: the button is not enabled because something gets stucked in the backend19:43
dobeyall i see is "some people can't log in, let's let them log in"19:43
nessitaa friend of mine have the issue, but we have not debugged it yet19:43
nessitadobey: but, the button is working for a lot of people, so is not that simple as "is inactive" :-)19:44
dobeywell, we could just use the gtk panel instead :)19:44
nessitadobey: those comments stopped being funny long time ago ;-)19:44
dobeynessita: could you at laest comment on the bug then, and provide some reassurance or something?19:45
nessitadobey: is on my queue19:45
dobeyit's not supposed to be funny19:45
nessitadobey: then if you're serious... I would have to kindly ask you to please align to the team/code direction we're going, which is not GTK+ (despite our personal preferences)19:46
nessitaso no, going back to GTK+ is not an option19:46
ralsinanessita: I have a branch for the test fails in ussoc when LANG is set, but there seems to be a "real" bug in the spawner when LANG is set. Not really sure though.19:50
nessitaralsina: very likely... any chance you debug further?19:50
nessita(today or tomorrow)19:50
ralsinanessita: sure. Here is the trace if it reminds you of something https://pastebin.canonical.com/62164/19:50
nessitaralsina: aaaahhhh maybe the thing we\ re using to detect failed to start is also lang'd19:51
ralsinanessita: could be19:51
nessitaralsina: can you debug on runner/tx.py where the error is handled?19:51
ralsinaOh, tx.py I was looking at qt.py!19:52
nessitayou will see  that 'No such file or directory" is  used19:52
ralsinaLet's remove the localised part19:52
dobeycomparing results with string literals in tests, is always frightening :(19:55
dobeyralsina: https://code.launchpad.net/~dobey/ubuntuone-control-panel/system-font/+merge/9709419:57
ralsinadobey: yep19:57
nessitadobey: is not test, is live code! :-D20:00
nessitadobey: live code not used in production, though20:00
dobeyeven worse20:00
dobeyand you wrote it!? bad teacher!20:00
nessitadobey, ralsina: the time I checked, twisted didn't let me much choice.20:00
nessitadobey: :-D20:00
nessitayou should see how beautiful it is a piece of C code I wrote this weekend20:01
ralsinanessita: there is a similar bug in the glib launcher, checking...20:01
nessitawith asserts everywhere, ensuring prea dn post20:01
dobeynessita: want to fix memory errors in ubuntu? :)20:01
ralsinanessita: check my last C code ;-) http://code.google.com/p/raspf/source/browse/trunk/raspf.c20:02
dobeyralsina: didn't you say you were reviewing https://code.launchpad.net/~dobey/ubuntuone-client/transient-notify/+merge/96815 this morning?20:02
nessitaralsina: I would very much appreciate the debugging of that. The main problem, when I tried to solve that, is that the errors comes directly from the "child" stdout/stderr, son string parsing is needed (as far as I recall)20:02
ralsinadobey: I think I did!20:02
dobeyralsina: there are no votes still :)20:02
nessitadobey: no thanks, that's why I code python in my mainly job20:02
ralsinadobey: slipped right by me! ;-)20:02
ralsinanessita: but tell me that's not the most pythonic C *ever* ;-)20:03
nessita+1 to use bstring20:03
ralsinathe first thing every new C programmer  should learn is "never ever ever use null-terminated strings if you canpossibly avoid it"20:04
ralsinanessita: there are even tests! http://code.google.com/p/raspf/source/browse/trunk/testspf3.c20:05
ralsinanessita: that library is a literal port of a python one of course :-)20:05
dobeynever ever use strings which are not null terminated20:07
ralsinadobey:  +1 I found the terminal with the tests running in it ;-)20:07
ralsinadobey: yes, use strings that know their own length ;-)20:08
ralsinadobey: you my C guy! Is errno 2 guaranteed to be ENOTFOUND and viceversa?20:09
dobeyralsina: 'man errno' doesn't even list ENOTFOUND20:12
nessitau1client dailies are building! https://code.launchpad.net/~ubuntuone-hackers/+recipe/client-dailies20:13
ralsinadobey: interesting...20:14
ralsinadobey: I meant ENOENT20:14
nessitadobey: can you please also affect ussoc in https://bugs.launchpad.net/ubuntuone-control-panel/+bug/953062? and also propose a branch if you have the tim20:15
ubot5`Ubuntu bug 953062 in ubuntuone-control-panel (Ubuntu) "Font and sizes are hard-coded" [Undecided,New]20:15
nessitadobey: so we keep cnsistency between bopth20:15
dobeyralsina: ah right. i don't think it's guaranteed to be 2, but it is guaranteed to be ENOENT :)20:16
ralsinadobey: grmbl20:16
dobeyralsina: particularly, i don't know what windows does for it20:16
nessitadobey: you also may wanna merge trunk in20:16
dobeynessita: did you change the qss?20:16
ralsinawell, what we have now really doesn't work in other languages anyway.20:17
nessitadobey: nopes, but in the LP diff there are some diffs against the tab tab tab branch20:17
dobeybad launchpad20:17
gatoxeod for me!20:18
gatoxsee you tomorrow people20:18
nessitabye gatox20:19
nessitadobey: oh tabtabtab did not have a commit message20:20
nessitaset one now20:20
ralsinanessita: sorry!20:21
nessitaralsina: but then why LP was showing that in the diff for dobey?20:21
ralsinanessita: no idea, I had that too20:21
dobeywhat the hell20:21
ralsinadid I break tarmac?20:22
nessitaralsina: did the test-lang-fixed have the tabtabtab merged in?20:22
dobeylp is weird20:22
ralsinanessita: ohhhhh hope not!20:23
ralsinaif it did, that was by mistake :-/20:23
dobeyit doesn't matter if it's in trunk or not20:23
alecukindertime for me20:23
alecusee you laters, all.20:23
ralsinabye alecu!20:23
dobeynessita: let me try something else20:24
nessitadobey: where? when? who?20:24
dobeynessita: regardless of what landed in trunk, lp shouldn't be showing that stuff in my branch20:24
dobeynessita, ralsina: ah, it seems like i messed up when i made the branch20:32
nessitadobey: ok20:32
ralsinaIT WAS NOT MY FAULT??? AMAZING! ;-)20:33
dobeyfixing it20:33
ralsinathis week just keeps getting better!20:33
dobeyi'm sure i could find some huge problem for you to have to deal with :)20:34
ralsinadobey: killjoy!20:34
dobeynessita, ralsina: there i fixed it20:44
nessitadobey: ack! same MP?20:45
dobeynessita: yep20:46
ralsinanessita, dobey: another fix-tests-with-lang-set branch, now for ussoc https://code.launchpad.net/~ralsina/ubuntu-sso-client/lang-tested/+merge/97097 includes fixes for internationalized spawners20:53
nessitaralsina: nice!20:57
ralsinanessita: I am not terribly happy about the spawner fixes but they are what we can do, I think20:58
dobeywe can probably do better21:02
dobeybut i'm not fussed about it at the moment21:02
ralsinadobey: if you suggest fixes on MP I can do them late tonight maybe21:11
dobeyralsina: i already gave it +121:12
ralsinadobey: ack21:13
dobeyi think we might have a problem with the proxy tunnel vs. web client in sso thing21:14
dobeybecause, circular deps are bad, mmkay21:16
dobeywell, is past time for me to get off here21:21
dobeylater all21:21
nessitabye dobey21:21
ralsinaEOD for me as well21:22
* alecu is back21:29
alecuwe will not have circular dependency problems with the webclient and the tunnel, because the webclient will be in sso, but will not use the tunnel_client.21:30
alecutxweb.Webclient instances will take a "reactor" optional parameter that will be set to "tunnel_client" only when being used by SD.21:31
alecuso, dobey: don't worry about that :-)21:32
nessitaalecu: anda!21:51
alecunessita, what anda?21:51
nessitaalecu: your branch21:52
nessitaalecu: have you tried testing it without having squid installed?>21:52
nessita(I do have squid)21:52
alecunessita, it does not matter if squid is installed, right? it only matters if gsettings point to it.21:52
alecunessita, I've tested with gsettings pointing at the squid, and with gsettings set to "none"21:53
nessitaalecu: ok, approving21:55
nessitagood work!21:55
nessitaand I need to run vbery fast to pilates now21:55
=== yofel_ is now known as yofel

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!