StevenK | wallyworld: Mind reviewing a mostly-mechnical MP? https://code.launchpad.net/~stevenk/launchpad/force-bug-enums-into-line/+merge/97123 | 00:51 |
---|---|---|
wallyworld | StevenK: sure | 00:51 |
wallyworld | StevenK: have you pushed a subsequent change, mp says diff still updating | 00:53 |
StevenK | I have not, that's it | 00:54 |
wallyworld | and it just disappeared | 00:54 |
wallyworld | so it seems to hang around for a bit | 00:54 |
StevenK | Reload the page, longpoll is dumb | 00:54 |
wallyworld | i have been | 00:54 |
wallyworld | and yet it stilled stayed on the page | 00:54 |
StevenK | Sigh. This is why we can't have nice things. | 00:55 |
wallyworld | no, IE is why we can't have nice things | 00:55 |
wallyworld | StevenK: r=me | 00:56 |
* StevenK lp-lands it, it's very benign | 00:59 | |
wallyworld | WCPGW | 00:59 |
StevenK | Haha | 00:59 |
wallyworld | :-) | 00:59 |
StevenK | lifeless: Are you still AFK? | 03:19 |
wgrant | StevenK: He's sick AFAIK. | 03:33 |
StevenK | Well, we both knew that already. | 03:34 |
StevenK | :-P | 03:34 |
wgrant | Hah | 03:34 |
StevenK | But okay, noted. | 03:34 |
lifeless | StevenK: future ref - staff calendar will show you | 03:57 |
lifeless | StevenK: and yes, throat full of razor blades, cold sweats, muscle pain, sinus. ye whole works. | 03:57 |
lifeless | that said, | 03:58 |
lifeless | !ask | StevenK | 03:58 |
wgrant | Also, backscroll. | 03:58 |
StevenK | lifeless: It is not urgent, and for further win, is not work-related. | 03:59 |
StevenK | lifeless: So don't worry about it. | 03:59 |
lifeless | StevenK: well, I'm here for a few minutes, so please do ask | 04:00 |
StevenK | lifeless: You need to be lucid enough to remember your GPG passphrase. :-) | 04:03 |
lifeless | go one | 04:03 |
StevenK | lifeless: http://keyring.debian.org/replacing_keys.html | 04:03 |
StevenK | I'd like to get my 1024D key out, and my 4096R key in. | 04:04 |
lifeless | heh | 04:04 |
lifeless | I should too | 04:04 |
StevenK | lifeless: I can toss you the full fingerprints in privmsg | 04:05 |
lifeless | mail, signed by your old key; isn't that part of the protocol ? | 04:06 |
StevenK | Doesn't have to be | 04:06 |
StevenK | If it still valid, I can choose to sign it with the old key | 04:06 |
lifeless | is your new key in the keyservers? | 04:07 |
StevenK | Yeah | 04:07 |
lifeless | 588A553F, ? | 04:07 |
StevenK | That's it | 04:07 |
lifeless | hmm, I don't have a trust path to it | 04:11 |
lifeless | skype ? | 04:12 |
lifeless | StevenK: ^ | 04:12 |
StevenK | Let me get that out | 04:13 |
StevenK | You don't have a trust path to C87FFC2F either? | 04:14 |
lifeless | don't seem to | 04:14 |
lifeless | of course, gpg may have lost local trust settings or whatever | 04:14 |
lifeless | whatever; will take 30 seconds to directly verify | 04:14 |
StevenK | lifeless: I'm Skype-enabled if you're ready. | 04:16 |
* StevenK prods Skype | 04:21 | |
* StevenK waits for lifeless to ping timeout from IRC ... | 04:22 | |
wallyworld | huwshimi: hello, do you have any exisiting/preferred code to use for a tri-state checkbox? or a preferred implementation technique? eg css or? | 05:16 |
bigjools | tri-state checkbox? | 05:16 |
wallyworld | one which can show three states | 05:16 |
wallyworld | yes, no, maybe | 05:17 |
wallyworld | or similar | 05:17 |
wallyworld | all, nothing, some | 05:17 |
StevenK | Unchecked, checked, or greyed out check. If it is played with, it collapses to checked or unchecked only. | 05:17 |
bigjools | a checkbox with three states... is that one where you need to visit the parallel universe to see the third state? | 05:17 |
wallyworld | no, it's represented typically as a grey tick | 05:18 |
huwshimi | wallyworld: What's the situation? | 05:18 |
bigjools | sorry, juju has made me flippant this afternoon | 05:18 |
wallyworld | huwshimi: for the sharing ui. the user needs to select to share "all", 'Some' or 'Nothing' | 05:18 |
wallyworld | bigjools: fuck off | 05:18 |
wallyworld | huwshimi: 'some' would be grey | 05:18 |
wallyworld | 'all' would be ticked | 05:19 |
huwshimi | wallyworld: Would checkboxes with those labels work? | 05:19 |
wallyworld | huwshimi: tri-state is more compact. the other solution is radio buttons, but yuk | 05:19 |
bigjools | wallyworld: sorry I can't hear you over the sound of my own awesomeness | 05:19 |
wallyworld | huwshimi: radio buttons would take up a bit of space | 05:20 |
wallyworld | and not scale that well | 05:20 |
StevenK | bigjools: Must be pretty quiet, then. | 05:20 |
huwshimi | wallyworld: The standard toolkits don't even SUPPORT tri-state checkboxes | 05:20 |
wallyworld | StevenK: speak up, i can't hear you over the whinging pom | 05:20 |
bigjools | StevenK: good comeback, I must remember that one | 05:20 |
StevenK | wallyworld: :-D | 05:20 |
wallyworld | huwshimi: yeah, there's several css/js based solutions people have used | 05:21 |
huwshimi | wallyworld: I'd really prefer we not use a tri-state | 05:21 |
wallyworld | :-( | 05:21 |
wallyworld | it's a very common paradigm | 05:21 |
StevenK | bigjools: Can't tell if trolling, or ... | 05:21 |
wallyworld | huwshimi: what don't you like? | 05:21 |
wallyworld | huwshimi: if i resort to radio buttons, the sharing picker is sure going to look fugly | 05:23 |
huwshimi | wallyworld: I'd prefer us to be much more explicit, especially as sharing the wrong thing has high ramifications. A tri-state will make the user have to think/guess about what each state might be. | 05:23 |
huwshimi | wallyworld: I'm not convinced it will be ugly. If it is, we may be doing something else worng | 05:24 |
huwshimi | wallyworld: And no, it's not a common paradigm in web applications (it's not even common elsewhere). | 05:24 |
wallyworld | huwshimi: hmmm. ok. i'll rework the ui and see how it looks | 05:24 |
StevenK | The states are ALL, NONE and SOME. If the user changes it, it collapses to ALL or NONE. Sounds pretty clear to me. | 05:24 |
wallyworld | huwshimi: we must look at different apps then | 05:24 |
wallyworld | it's not that common on the web | 05:25 |
StevenK | I remember tri-state from *shudder* my time doing Visual Basic. | 05:25 |
wallyworld | but what about installers as one example | 05:25 |
wallyworld | where you get to choose all packages, non, or some | 05:25 |
wgrant | I don't recall seeing many tristate checkboxes outside horrifyingly awful Microsoft Office options dialogs. | 05:27 |
wallyworld | wgrant: i'm sure i've used a linux installer at some point with them | 05:27 |
wallyworld | maybe suse | 05:27 |
wgrant | Red Hat doesn't exist | 05:27 |
StevenK | If only | 05:28 |
wallyworld | it's a very compact and convenient way to represent all/some/none | 05:28 |
wgrant | And it makes it rather challenging to recover. | 05:28 |
StevenK | Indeed. You can't go back to Some if you click the wrong checkbox | 05:28 |
StevenK | I hate the idea of comboboxes for each too, since that's just disgusting | 05:29 |
wallyworld | no, it's tri-state | 05:29 |
huwshimi | wallyworld: The most common use for a tri-state is to represent the state of other checkboxes on the page. | 05:29 |
wallyworld | as you click, it cycles through the states | 05:29 |
wgrant | wallyworld: I don't think I've ever seen one of those before. | 05:29 |
wgrant | AFAICR they just collapse into one of the two extremes. | 05:30 |
wallyworld | huwshimi: yes, that's true | 05:30 |
wgrant | You can never return to some. | 05:30 |
StevenK | That's what I recall. | 05:30 |
wallyworld | i'm clearly outvoted :-) | 05:30 |
wallyworld | i'll do it as radio buttons | 05:30 |
wgrant | Ewww | 05:30 |
wallyworld | what alternatives do i have? drop down combo? | 05:31 |
wallyworld | i guess i could do that | 05:31 |
StevenK | New widget, but ... | 05:31 |
wgrant | That would be even worse, I think. | 05:31 |
wallyworld | sooo, we don't like tri-state checkeboxes, nor radio buttons, nor drop down combo; there ain't much kleft | 05:31 |
StevenK | |-- ALL / -|- SOME / --| NONE | 05:32 |
StevenK | If you excuse my horrid ASCII-art, that's my idea, but I don't like it either. | 05:32 |
wgrant | I was thinking maybe a lozenge radio button. | 05:32 |
wgrant | Which is slightly less obese than full radio buttons. | 05:32 |
huwshimi | wallyworld: Can you show me the situation somehow? | 05:32 |
wallyworld | maybe | 05:32 |
wallyworld | huwshimi: https://qastaging.launchpad.net/launchpad/+sharing | 05:33 |
StevenK | wgrant: Can haz example? I've never heard of those | 05:33 |
wallyworld | huwshimi: click on the +Share with someone link | 05:33 |
wallyworld | huwshimi: choose a person and then see the 2nd step where you get to chosse the sharing permissions | 05:34 |
wallyworld | huwshimi: there are currently checkboxes but they need to be tri-state | 05:34 |
wgrant | StevenK: The [ Test | One | Two ] on http://arstechnica.com/apple/reviews/2011/07/mac-os-x-10-7.ars/3 | 05:34 |
wallyworld | huwshimi: lozenge buttons seem the best suggestion so far i think | 05:35 |
StevenK | wgrant, wallyworld: That was what I meant with my ASCII-art | 05:35 |
wgrant | sinzui will cry, as they have bad history in Launchpad. | 05:35 |
wgrant | But for unrelated uses. | 05:35 |
wgrant | StevenK: Oh, I assumed your thing was more like the horrible GTK3 toggle things. | 05:35 |
wallyworld | StevenK: ah of course. you also printed out naked women on dot matrix tractor printers and stood 100 feet away too didn't you? | 05:36 |
wgrant | With the line that's either on the left or right. | 05:36 |
StevenK | wallyworld: No ... it was the fastest way to get my point across. | 05:37 |
StevenK | Sadly, wgrant did it better, like usual. | 05:37 |
wallyworld | StevenK: just giving you shit | 05:37 |
StevenK | I know. ;-) | 05:37 |
StevenK | wallyworld: Since you're full of it, it has to go somewhere ... | 05:37 |
wallyworld | lol | 05:37 |
wallyworld | huwshimi: you find what i mean ok? | 05:38 |
huwshimi | wallyworld: I did | 05:38 |
wallyworld | huwshimi: i await your verdict :-) | 05:38 |
* StevenK votes for lozenge radio buttons. | 05:38 | |
* wallyworld so does wallyworld | 05:40 | |
wallyworld | do we have any code in lp for those? | 05:41 |
StevenK | Curious how to do them in YUI | 05:41 |
wallyworld | surely there's a widget someone has donr | 05:41 |
huwshimi | Do we use the lozenge anywhere else in Launchpad? | 05:42 |
wgrant | We used to have lozenge menus, but they were abolished in 3.0. | 05:42 |
StevenK | And sinzui probably danced on their grave. | 05:43 |
wgrant | We all did. | 05:43 |
wgrant | It was a glorious day. | 05:43 |
huwshimi | If we don't use the elsewhere then I don't think now is the right time to be introducing new UI concepts | 05:44 |
huwshimi | wallyworld: What you might have to do is produce a few really quick mockups so we can see the options | 05:44 |
wgrant | Sure, but what else can we use that doesn't look horrible? | 05:44 |
StevenK | But the concept is the correct way to show a tri-state ... | 05:44 |
huwshimi | I'm sure we can do it with any of the options and not make it horrible | 05:45 |
huwshimi | but introducing unusual UI concepts probably isn't the smartest idea right now | 05:45 |
wallyworld | huwshimi: lozenge maybe new for lp but not outside of lp. and lp is very primative so i wouldn't use it's current widget set as a guide to the current best practice | 05:46 |
huwshimi | wallyworld: Right, but no-one has enough time to work on a new UI concept to the point where we get it right | 05:46 |
wallyworld | if not lozenge, then the only choices are radio button and drop down. i can see what they both look like | 05:47 |
StevenK | And they'll both be terrible, I fear | 05:47 |
wallyworld | me too :-( | 05:47 |
huwshimi | wallyworld, wgrant, StevenK: Tell me why all the rest of the options are terrible. | 05:52 |
huwshimi | I want to be convinced | 05:52 |
wallyworld | huwshimi: radio buttons are too verbose and not that well suited to being displayed for each item in a list | 05:53 |
wallyworld | huwshimi: drop downs don't allow the user to easily see all of the choices available without clocking | 05:53 |
StevenK | Yes, does a grid of 21 radio buttons make for good UI? | 05:54 |
huwshimi | wallyworld: How are radio buttons more verbose than the lozenge | 05:54 |
huwshimi | ? | 05:54 |
huwshimi | StevenK: There will be a maximum of nine | 05:54 |
huwshimi | StevenK: Usually six | 05:54 |
StevenK | I doubt it, for large projects. | 05:55 |
wallyworld | huwshimi: they are more compact, radio buttons have the clickable widget and text separate | 05:55 |
huwshimi | wallyworld: We have plenty of space | 05:55 |
StevenK | There are *better* ways to display tri-stated information than an arry of radio buttons. | 05:56 |
StevenK | Just thinking about it makes me want to stab my eyes. | 05:56 |
wallyworld | huwshimi: i think guis are better when they don't misuse space | 05:56 |
huwshimi | StevenK: I'm not convinced that we can do a better job of building them though | 05:57 |
huwshimi | I think I'd rather us do something that we can't go wrong with than introduce a new UI concept that will most likely introduce a support and maintenance cost | 05:58 |
StevenK | I think we have to mock up the three choices | 05:59 |
wgrant | I'm not sure a dropdown is a choice. | 05:59 |
StevenK | Neither. | 05:59 |
wallyworld | i guess it's hard sometimes for people who understand these ui concepts to see how it would introduce a support cost | 05:59 |
wallyworld | it's not like lp is aimed at people who don't know computers | 06:00 |
wallyworld | and if you are using the sharing ui and you can't use a lozenge or whatever then you have no business in the ui | 06:00 |
huwshimi | wallyworld: Sure, but given our track record of UI design, creating a lozenge widget for example has a high risk of failure. It's not just that the user won't be able to figure it out, it's that we won't do a good enough job at creating something that works perfectly. | 06:01 |
wallyworld | oh, the pain, stabbed in the heart | 06:02 |
nigelb | drama queen. | 06:05 |
* nigelb ducks and runs | 06:05 | |
huwshimi | wallyworld: We have to consider these things when making decisions. Especially as I'm not sure we'd gain enough to warrant the extra development time (forgetting adding another inconsistent UI concept etc.) | 06:06 |
wallyworld | huwshimi: np. there's a line between "adding inconsistent ui" and "using the right tool for the job" and i guess that's what needs to be looked at | 06:08 |
huwshimi | wallyworld: I think if we do some mockups we can make a decision pretty quickly | 06:09 |
wallyworld | huwshimi: ok. thanks for the input, appreciated | 06:10 |
wallyworld | nigelb: i wouldn't stick my head up after what happened in the cricket :-P | 06:10 |
nigelb | dammit | 06:11 |
nigelb | :P | 06:11 |
wgrant | wallyworld: Oh, nice, a dict marshaller for lazr.restful. How does that affect the WADL? | 06:40 |
wallyworld | wgrant: not sure about what you mean by the effect on the wadl. it generates fine and looks ok but i'm no expert. all the web services tests that invoke that method pass | 07:37 |
wgrant | wallyworld: Right, just wondering how easily we can convince launchpadlib to interpret it well. | 07:41 |
wallyworld | service.sharePillarInformation(pillar=ws_pillar, sharee=ws_grantee, | 07:43 |
wallyworld | permissions={InformationType.USERDATA.title: SharingPermission.ALL.title}) | 07:43 |
wallyworld | wgrant: you just pass in a dict as expected | 07:43 |
wallyworld | wgrant: the keys are values are marshalled | 07:43 |
wgrant | wallyworld: Ah, right, it's only going the other way that it'll need special code. | 07:44 |
wgrant | Methods that *return* dicts | 07:44 |
=== almaisan-away is now known as al-maisan | ||
wallyworld | wgrant: there's an unmarshall method which is properly implemented (generates json data). will that be used for return types? | 07:45 |
wgrant | wallyworld: The server side has always worked, AFAIK | 07:45 |
wgrant | I wrote a couple of methods which returned dicts | 07:45 |
wallyworld | someone filed a bug related to returning dicts from memory | 07:46 |
wgrant | lazr.restfulclient doesn't know what to do with them, so it just returns them as dicts of strs. | 07:46 |
wallyworld | bug 481090 | 07:46 |
_mup_ | Bug #481090: Cannot define a method that returns a dict <lazr.restful:Triaged> < https://launchpad.net/bugs/481090 > | 07:46 |
wallyworld | ah, ok, lazr.restfulclient | 07:47 |
lifeless | StevenK: signed and pushed | 08:14 |
StevenK | lifeless: Thanks. I've submitted an RT (two in fact, because I'm a complete blockhead); we shall see what keyring-maint says. | 08:14 |
czajkowski | goood morning | 08:26 |
StevenK | czajkowski: Proof required. :-P | 08:43 |
czajkowski | I have tea and oddles of toast with peanut butter nothign going to upset me :) | 08:46 |
jelmer | g'morning launchpadders | 09:05 |
=== gmb changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: gmb | Firefighting: - | Critical bugtasks: 4*10 | ||
gmb | Does anyone else see this whilst trying to use the bzr beta PPA?: http://pastebin.ubuntu.com/881655/ | 10:33 |
bigjools | gmb: they are not publishing precise packages yet | 10:34 |
gmb | Ah. | 10:34 |
gmb | Bottom. | 10:34 |
=== al-maisan is now known as almaisan-away | ||
bigjools | is precise not beta enough for you? :) | 10:35 |
=== almaisan-away is now known as al-maisan | ||
gmb | I want my bleeding edge to look like it came out of an accident with a bandsaw. | 10:35 |
wgrant | You want ppa:bzr/daily :) | 10:36 |
gmb | :). | 10:36 |
bigjools | christ, my desktop PC has gone 3 weeks with no net connection and now dist-upgrade has taken an hour so far (50 mins of that actually installing) | 10:37 |
gmb | wgrant, You may know the answer to this: Is it wise or unwise to use setup.py from within the Makefile of a debian package? | 10:37 |
czajkowski | joys of precise :) | 10:38 |
StevenK | gmb: If Makefile == debian/rules, then how else are you going to do it? | 10:42 |
maxb | gmb: debian package ... Makefile? you mean debian/rules? | 10:43 |
maxb | also re bzr ppa, at the moment bzr/beta == bzr/proposed | 10:45 |
maxb | er | 10:45 |
maxb | also re bzr ppa, at the moment bzr/beta == bzr/ppa | 10:46 |
gmb | maxb, StevenK: Well, yes (AFAICT that's calling the Makefile in the top level of the source, which is that I'm referring to). | 10:46 |
StevenK | gmb: Oh, right, your build step calls $(MAKE) | 10:46 |
maxb | urgh, you have a horrid package with both a setup.py and a Makefile | 10:46 |
gmb | maxb, It mixes python and shell stuff. | 10:47 |
gmb | I'm considering doing the python bit manually though | 10:47 |
gmb | Because setup.py just vomits. | 10:47 |
gmb | ... when the package is being built, anyway. | 10:47 |
gmb | Actually, maybe it would be simpler to have a separate package for the python stuff. | 10:47 |
StevenK | Doing the python bit in Make will cause you to put your keyboard cord around your neck and yank hard. | 10:47 |
gmb | StevenK, Ah, I see. Separate package is looking very tempting, then. | 10:49 |
gmb | Screw it, the original package can depend on the new one. | 10:49 |
StevenK | WCPGW | 10:49 |
gmb | Hah. | 10:49 |
gmb | StevenK, maxb: Thanks chaps. | 10:50 |
gmb | At least I know i'm not entirely mad. | 10:50 |
StevenK | But you don't have that far to travel. | 10:51 |
gmb | StevenK, Well, no, I still work on Launchpad. "Madness" is within spitting distance. | 10:52 |
wgrant | gmb: What's the package? | 10:57 |
gmb | wgrant, charm-tools. | 10:58 |
* StevenK reads a conversation on another channel, and reaches for his keyboard so he can wrap the cord around his neck, and then realises it's a wireless keyboard ... | 10:58 | |
wgrant | Hm, so -server wrote it? | 10:58 |
gmb | wgrant, Yes, I think so. | 10:58 |
wgrant | Odd that it is so awkward, then. | 10:59 |
gmb | wgrant, Well, what's awkward is that I'm adding Python stuff to it. It worked perfectly until I started pratting about. | 10:59 |
wgrant | Oh | 10:59 |
gmb | Anyway, I'm going to bug clint about it this afternoon :) | 10:59 |
wgrant | That would do it. | 10:59 |
wgrant | Separate package :) | 10:59 |
gmb | Yeah :) | 10:59 |
wgrant | Ooh. | 11:00 |
wgrant | Parallel test suite bugs. | 11:00 |
wgrant | You have something working, then? :) | 11:00 |
gmb | wgrant, "Working" is relative. But yes, we do, now that we've solved a lot of the weirdnesses with lxc and -start-ephemeral. | 11:02 |
wgrant | Heh. | 11:04 |
wgrant | Good good. | 11:04 |
nigelb | StevenK: #firstworldproblems | 11:17 |
gmb | Holy mother of dog and all her wacky nephews. Why are my comments on merge proposals posted with all the spaces stripped out? What's this nonsense? | 11:20 |
=== al-maisan is now known as almaisan-away | ||
=== matsubara-afk is now known as matsubara | ||
=== danhg_ is now known as danhg | ||
=== almaisan-away is now known as al-maisan | ||
=== Ursinha` is now known as Ursinha | ||
fjlacoste | benji: have you looked at wallyworld's lsazr.restful branch yet? | 14:48 |
fjlacoste | i was about to write a review for it | 14:48 |
fjlacoste | but you are a pending reviewers | 14:48 |
benji | fjlacoste: I wasn't aware of it. I would be happy to look and equally happy for you to do so. | 14:48 |
fjlacoste | benji: i'll take care of it | 14:49 |
benji | I wonder why I wasn't aware of it. I'll try to figure that out. | 14:49 |
jcsackett | benji: i ifnd when i'm working off the web UI i sometimes miss things b/c i was looking at /launchpad/+activereviews instead of /launchpad-project/+activereviews? | 14:54 |
jcsackett | ... that shouldn't have ended in a question mark. | 14:54 |
benji | jcsackett: ooh, that may be it; I hope firefox auto-complete learns the better one quickly ;) | 14:55 |
jcsackett | benji: i hope it learns it faster than chromium's did for me. :-) | 14:56 |
benji | heh | 14:56 |
fjlacoste | benji: well, i agree that it's weird unless he explicitely asked a review from you | 14:58 |
fjlacoste | because i would have expected that to be assigned to the team | 14:58 |
benji | fjlacoste: he did ask for a review from me (at least that's what it says now), and since the email looks so much like all the non-personal review requests I see I passed over it. I'm in the process of making messages like that highlighted so they won't slip through again. | 15:00 |
benji | gary_poster: I bet you're already doing this, but it dawned on me that using -vvvvvv with the test runner would show me the actual order in which the tests were run | 15:21 |
benji | gary_poster: you also know that I'm in the wrong channel | 15:21 |
gary_poster | benji yes :-) | 15:22 |
gary_poster | I'm using -vv, which is giving me the order | 15:22 |
gary_poster | I'm switching channels! | 15:22 |
benji | yeah, never remember how many Vs do what, so I just hold down V until I get tired | 15:23 |
=== al-maisan is now known as almaisan-away | ||
=== beuno is now known as beuno-lunch | ||
=== beuno-lunch is now known as beuno | ||
=== salgado is now known as salgado-lunch | ||
sinzui | jcsackett, I reopened bug 933794 and updated it. +audit-sharing still needs a summary of users, policies and level of sharing | 16:12 |
_mup_ | Bug #933794: +audit-sharing does not show a block summarising who is shared with <disclosure> <qa-ok> <ui> <Launchpad itself:Triaged> < https://launchpad.net/bugs/933794 > | 16:12 |
=== salgado-lunch is now known as salgado | ||
jcsackett | sinzui: dig. | 17:00 |
jcsackett | sinzui: thought that might be a new bug; i'm good with just changing the existing one though. | 17:01 |
czajkowski | fjlacoste: any idea why on lp all the footers with Contact Launchpad Support end up https://answers.launchpad.net/launchpad | 17:15 |
sinzui | czajkowski, I know | 17:25 |
czajkowski | sinzui: oh do tell :) | 17:26 |
czajkowski | dont leave me hanging :) | 17:26 |
sinzui | czajkowski, We want users to ask question in a place we support rather then sending email to a place to be ignored | 17:27 |
czajkowski | sinzui: so where are people finding the feedback mail address | 17:27 |
czajkowski | and how am I getting questions via RT then | 17:27 |
sinzui | czajkowski, The link is not static. anonymous users see a different link because only logged in users can ask a question..and anonymous users are probably trying to login which is not something we at Lp can help with | 17:28 |
sinzui | czajkowski, anonymous users send those | 17:28 |
czajkowski | hmm ok | 17:28 |
czajkowski | thanks sinzui | 17:28 |
sinzui | czajkowski, many rt emails are in reply to emails generated from Lp, such as commercial inquiries and translation issues | 17:29 |
czajkowski | the commercial folks are using feedback as well | 17:30 |
sinzui | czajkowski, anonymous users see a link to https://help.launchpad.net/Feedback | 17:30 |
czajkowski | just curious as spring cleaning rt | 17:30 |
czajkowski | sinzui: cheers for the ifo | 17:30 |
sinzui | czajkowski, I hope that changes I making these week will reduce the emails. I am replacing the generic license issues message with ones specific to the case. This will land in a few days | 17:31 |
sinzui | The generic email is confusing | 17:31 |
czajkowski | excellent | 17:31 |
=== fjlacoste is now known as flacoste | ||
salgado | I see we have some BugTasks which have a productseries bug no product, and I also see IBugTask.target can be an IProductSeries. however, I cannot seem to figure out how to create (in a test) a bugtask with a productseries but no product... the factory method won't do that and if I try to transitionToTarget(series) I get an error: | 18:49 |
salgado | IllegalTarget('Series tasks may only be created by approving nominations.',) | 18:49 |
salgado | heh, now I think I understand... maybe I need to create *and* approve a nomination? | 18:49 |
lifeless | conjoined masters | 18:50 |
salgado | lifeless, you mean this is a conjoined master or I need to figure out what conjoined masters are and create one? | 18:53 |
lifeless | conjoined masters - any series only task gets a context task added if none exists | 19:07 |
lifeless | there should be no series only task bugs around | 19:08 |
lifeless | search for conjoined should give you some context | 19:08 |
salgado | lifeless, oh, ok, that makes sense. but I don't actually want a bug with series-only tasks... all I want is a series-only task which AFAICT is created via nominations? | 19:12 |
lifeless | salgado: thats my point, there isn't such a thing atm | 19:30 |
lifeless | salgado: can you point to a bug that demonstrates what you want in prod / qas / s ? | 19:30 |
lifeless | bah | 19:30 |
lifeless | iwlwifi has a lot to answer for | 19:30 |
salgado | lifeless, a series-only task? there seems to be 14177 of them on staging | 19:31 |
lifeless | salgado: how are you determining that ? | 19:31 |
salgado | select count(*) from bugtask where product is null and productseries is not null; | 19:31 |
lifeless | ah terminology | 19:32 |
lifeless | thats a series task, not series only | 19:32 |
lifeless | tasks are always one-of product|productseries|distro|distroseries|distropackage|distroseriespackage | 19:32 |
lifeless | the conjoined master means there is always a matching product task whenever there is a product series task, and likewise for the distro+distroseries and distropackage+distroseriespackage | 19:33 |
lifeless | salgado: you can make a series task by nomination or targeting; if this is for the test suite, makeBugTask(target=someseries) should do it | 19:33 |
salgado | lifeless, right, I understood those tasks with series but no product will have a matching task for the product. but what I wanted was just to know how to create such a task with a productseries but no product | 19:34 |
lifeless | salgado: via the UI, API or python ? | 19:34 |
salgado | lifeless, I couldn't get makeBug() to do that. it seems to always set the product on the task as well. I've now managed to do it via makeBugNomination(), though | 19:36 |
salgado | I think I was expecing makeBug() to create a single task bug it actually creates two in that case | 19:37 |
salgado | for product and productseries | 19:38 |
lifeless | salgado: uhm, the db won't let that happen | 19:38 |
lifeless | Check constraints: | 19:38 |
lifeless | "bugtask_assignment_checks" CHECK ( | 19:38 |
lifeless | CASE | 19:38 |
lifeless | WHEN product IS NOT NULL THEN productseries IS NULL AND distribution IS NULL AND distroseries IS NULL AND sourcepackagename IS NULL | 19:38 |
lifeless | salgado: so yes, it was making two tasks | 19:38 |
lifeless | and you then need to grab the task you want | 19:38 |
salgado | right, yeah, thanks for the help, lifeless | 19:40 |
lifeless | no worries | 19:40 |
lifeless | this is fugly | 19:40 |
lifeless | I want to fix, but one thing at a time | 19:40 |
lifeless | sinzui: did the recent 404 changes drop showing the oopsid ? | 20:08 |
lifeless | sinzui: (It is fine if they did, just seeking confirmation it was deliberate, or whether I need to investigate something being bokred) | 20:09 |
lifeless | sinzui: the breadcrumbs on https://launchpad.net/~ubuntu-security/+archive/ppa/+build/3244524 include links that will 404/403 | 20:10 |
sinzui | lifeless, oops rules should not change | 20:10 |
lifeless | ah indeed | 20:11 |
lifeless | it is a 403 which does not oops | 20:11 |
lifeless | even though it matches the same bad-internal-link rule when I think about it as a human | 20:11 |
lifeless | sinzui: (the ppa is private, the build is unembargoed, but the breadcrumbs still link to the ppa) | 20:12 |
sinzui | lifeless, I had not consider that case. I think the user who can see that page gets Lp.LimitedView thus 200 | 20:12 |
sinzui | A 404/403 page does not include breadcrumbs | 20:12 |
lifeless | sinzui: the build page is 200 | 20:12 |
sinzui | well my test show that error pages do not have breadcrumbs | 20:12 |
lifeless | sinzui: the build page includes a link to the ppa page | 20:12 |
lifeless | sinzui: the ppa page is 403 | 20:12 |
lifeless | sinzui: the link to the ppa page is in the breadcrumbs of the build page | 20:13 |
sinzui | ah. I see. | 20:13 |
sinzui | That is a whole new case. Someone should have written a custom breadcrumb adapter for build that exclude 404/403 situations | 20:14 |
sinzui | lifeless, maybe that build page should not be public since Lp think the parent object is private... | 20:15 |
* sinzui looks for bug | 20:15 | |
lifeless | sinzui: the build is public because it is a binary-copied security update | 20:17 |
lifeless | sinzui: https://launchpad.net/ubuntu/+source/postgresql-8.4 | 20:18 |
lifeless | This is another example of custom visibility rules deviating from the pattern and making other assumptions unsafe | 20:18 |
lifeless | one way to address it would be to expose the same raw data under each archive its been copied too, or something | 20:18 |
lifeless | I'd need to check code to be totally sure what its doing | 20:19 |
lifeless | I will file a bug about the symptoms | 20:19 |
sinzui | okay | 20:19 |
lifeless | bug 954411 | 20:21 |
_mup_ | Bug #954411: build breadcrumbs of unembargoed builds in private ppa link to the ppa which is inaccessible <403> <confusing-ui> <Launchpad itself:Triaged> < https://launchpad.net/bugs/954411 > | 20:21 |
wallyworld | sinzui: i have to drop my son to school a bit later today since he is going to camp so will miss the standup | 20:24 |
sinzui | wallyworld, thank you | 20:25 |
wallyworld | sinzui: i'll be packing the lazr.restful change, landing the other branches which depend on it, and prtotyping a tri-state ui for the sharing picker | 20:26 |
wallyworld | sinzui: we need a tri-state widget for All/Some/Nothing. tri-state checkbox was rejected on irc. so it's down to radio buttons or a lozenge | 20:27 |
sinzui | Yuck | 20:27 |
wallyworld | sinzui: discuss with the guys and i'll ctach up with them when i get back | 20:28 |
lifeless | if some means 'do not change', tri-state could work, but if some means some, surely they should be shown? | 20:28 |
wallyworld | lifeless: some does mean some | 20:29 |
wallyworld | so we need something that looks good and is compact when rendered as part of a <li> | 20:29 |
sinzui | wallyworld, I read the scrollback this morning. wgrant is correct hat I do not like the lozenge because Lp users cannot see them. Lp 2.0 required extra support to explain to user the link is already on the page..just click the think that does not look like anything you have see on your operating system before | 20:33 |
wallyworld | sinzui: interesting. i like lozenge widgets do i guess it does come down to personal preference. i guess radio buttons or drop down is what we have to choose from then | 20:34 |
wallyworld | and drop downs were not preferred | 20:35 |
wallyworld | so i'll see what can be done with radio buttons | 20:35 |
sinzui | wallyworld, I agree with compact is more most important and the user must see the options | 20:35 |
sinzui | so I will accept lozenges after a ui test | 20:35 |
wallyworld | sinzui: cool :- ) do we have any existing code for them? | 20:36 |
abentley | wallyworld: We have the order-by losenges in the bug listings. | 20:42 |
wallyworld | abentley: thanks! will look at those | 20:51 |
salgado | gmb, since you're the on-call reviewer today, I thought I'd ask you to ec2-land one branch that was blocked on a bug that was just fixed (bug 953316). would you mind? (https://code.launchpad.net/~linaro-infrastructure/launchpad/workitems-widget/+merge/94790) | 20:55 |
_mup_ | Bug #953316: Change the workitem-migrator job to do so only for Linaro-related blueprints <qa-ok> <Launchpad itself:Fix Committed by salgado> < https://launchpad.net/bugs/953316 > | 20:55 |
salgado | isn't it too late for gmb, though? | 20:55 |
gmb | salgado: Yes, it is :) I'd forgotten to take myself out of the /topic though. | 20:55 |
gmb | Sorry. | 20:55 |
=== gmb changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: - | Firefighting: - | Critical bugtasks: 4*10 | ||
salgado | it only occurred to me after I wrote that | 20:55 |
gmb | next question is: Why do I have an IRC client open at 9pm? | 20:56 |
* gmb -> exeunt | 20:56 | |
salgado | heh | 20:56 |
salgado | abentley, can you ec2-land that for me? | 20:56 |
abentley | salgado: okay. | 20:57 |
salgado | thanks abentley! | 20:58 |
abentley | salgado: I just bugfixed ec2 land, so this will be a good test. | 20:58 |
salgado | oh, I love being a guinea pig ;) | 20:59 |
=== salgado is now known as salgado-afk | ||
wgrant | sinzui, lifeless: It is not possible to hide the origin of a build. | 22:01 |
wgrant | Copying a private build to elsewhere discloses the existence of its source archive. | 22:01 |
lifeless | wgrant: thats my understanding, yes | 22:02 |
sinzui | wgrant, StevenK, sorry I am delayed | 22:12 |
wgrant | We forgive you :) | 22:15 |
sinzui | wgrant, maybe half of this bug is fixed: Bug #181401 | 22:50 |
_mup_ | Bug #181401: push to lp:project or lp:project/series should to set the development focus and/or create the series <lp-code> <ui> <Launchpad itself:Triaged> < https://launchpad.net/bugs/181401 > | 22:50 |
StevenK | wgrant: https://code.launchpad.net/~stevenk/launchpad/information_type-model/+merge/97319 | 23:00 |
wallyworld | StevenK: wgrant: did you discuss the sharing picker tri-state ui at the stand up? | 23:18 |
StevenK | At length | 23:20 |
wallyworld | verdict? just to prototype something? | 23:20 |
StevenK | Dan likes the idea of the lozonge, Huw does not, the UI design that previous used lozenges was an utter failure. But yes, prototype it up. | 23:22 |
wallyworld | that's the trouble with ui work - everyone seems to have very different opinions | 23:23 |
wgrant | wallyworld: The issue of team members was also raised | 23:26 |
wallyworld | in what respect? | 23:27 |
wgrant | wallyworld: In that there might want to be an option for "None, and none for any of the team members either" | 23:27 |
wallyworld | wgrant: for sure, that was in the prototypes | 23:27 |
wallyworld | but we haven't got to that in the implementation yet | 23:28 |
wgrant | lifeless: Can I set the bugs-fixed-elsewhere hiding flag on prod? | 23:36 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!