[03:35] wallyworld: Want to review https://code.launchpad.net/~stevenk/launchpad/information_type-bugs-garbo/+merge/97335 ? [03:35] StevenK: give me a few minutes [03:43] And hopefully wgrant and wallyworld don't hate me, but: https://code.launchpad.net/~stevenk/launchpad/destroy-ie-regression/+merge/97337 [03:43] StevenK: bug._setInformationType is already committed? [03:44] wallyworld: It's in the pre-req branch. As is the comment in test_bug, but I hadn't pushed so it polluted the diff [03:46] StevenK: r=me [03:47] feels very silent today. [03:48] StevenK: with the other one, i think we need to commit to testing any affected pages on qas in IE before qa-ok. or even test before landing [03:49] wallyworld: I think I'll just reply to the thread with the MP and see what happens. [03:49] ok :-) [03:50] wallyworld: Main reason I linked it to you was not for review, but to hope I wasn't treading on toes. [03:51] StevenK: oh not at all. any of that stuff that I may have checked in would have been due to copy and paste from elsewhere, not deliberately doing it [03:53] Needs to be tested before landing. [03:55] Oh, WCPGW [03:56] :-P [03:57] Bah [03:57] IE8 doesn't support last-child [03:57] IE9 does, though. [04:03] Windows XP font rendering is the worst thing in the world, apart from IE6. [04:03] wgrant: brainfuk [04:03] Haha [04:04] wgrant: intercal [04:06] Bah [04:06] Ruby [04:07] * StevenK ducks [04:07] ruby is old. node.js is the new hawtness [04:12] "Unknown runtime error" [04:12] Thanks, IE8, that's really helpful. [04:12] Hahaha [04:12] IE8 against what? [04:12] Trying to run Launchpad's JS. [04:13] Using my branch, or LP in general? [04:13] devel + a few unrelated changes [04:14] StevenK: How do I use the comboloader these days? [04:14] hopefully it will make the JS file small enough that IE's debugger can render it. [04:16] wgrant: You need to make sure your Apache is set up -- does 'combo' appear twice in your local-apache-launchpad config? [04:19] StevenK: I have the WSGIScriptAlias [04:19] And yes. [04:19] Does /srv/launchpad.net exist? [04:20] s/net/dev/, sorry [04:20] Ewwwwww [04:21] But yes [04:21] * wgrant must take an axe to this later. [04:21] Is /srv/launchpad.dev/convoy a symlink into the correct tree + build/js? [04:22] If so, enable the feature flag js.combo_loader.enabled [04:22] wgrant: I can't use /var/tmp [04:23] You can't follow symlinks you don't own, and if $USER creates the symlink then www-data can not follow it. [04:23] We had this argument already. [04:23] And I refuse to edit the Apache config on every build [04:23] That doesn't make it valid for rocketfuel-setup to shit all over /srv [04:23] :) [04:24] rf-setup does far worse already [04:24] And the evil is in our Makefile, not rf-setup [04:24] Hm [04:24] Can I disable minimisation in combobuild? [04:25] Hmmm [04:25] I thought I had [04:25] Oh [04:25] Someone is trying to set innerHTML of a table. [04:25] Bad $someone. [04:33] lifeless: You should watch Damien Conway's talk "Temporally Quaquaversal Virtual Nanomachine Programming in Multiple Topologically Connected Quantum-Relativistic Parallel Timespaces... Made Easy" [04:34] wgrant: Is http://www.globalnerdy.com/2012/02/16/how-to-tell-html-from-html5-or-microsofts-image-problem/ still true? [04:35] wtf [04:35] some of our JS is awful [04:35] Some? [04:36] Well, for example, the "oh, this JS needs to know a URL. let's stick a contentless in the page somewhere and hope nobody notices it's there" [04:36] Bwahjaha [04:43] StevenK: what did keyring-maint say? [04:44] lifeless: So it seems keyring-maint is as much a blockhead as me. [04:44] The first RT was signed with the new key, and the second RT was signed with the current key. [04:44] Gunnar approved the first RT and said it's been done. [04:45] He then comment on the second RT with effectively, "DOH! Did I just ... yes, I did." [04:52] StevenK: rotfl [04:56] * StevenK stabs ec2. [04:56] It failed, and didn't send me a mail [05:19] * StevenK stabs ec2, and then twists the knife. [05:21] wut [05:22] why on earth are all collapsibles done with a not necessarily inside a
? [05:22] When a can only exist in a
.. [05:22] Also it makes no sense. [05:22] wgrant: Did you get the combo-loader working, or you gave up? [05:23] Got it working. [05:23] Had to hack base-layout.pt to remove minimisation [05:23] But it works. [05:23] Ah yes, I was going to look at that [05:24] It's pretty simple, really. [05:24] http://pastebin.ubuntu.com/882822/ [05:24] "If your membership does expire, we'll send you one more message to let [05:24] you know it's happened. [05:24] RAHHH [05:24] SMASH [05:25] wgrant: Ah, but only want raw there if devmode [05:26] Sure [05:26] Has anyone here worked with publishing custom events with YUI? [05:27] huwshimi: what do you need? [05:28] rick_h_: I have a widget that I want to publish events from. I have things set up the way I think they should work, but I can't seem to see the events... [05:28] rick_h_: WTF, isn't it like 6am? [05:28] StevenK: in CA for pycon sprints [05:28] StevenK: Pycon [05:29] So it's 10:30pm and I'm sprinting [05:29] Ah [05:29] rick_h_: Want to see some code? [05:29] huwshimi: sure [05:29] rick_h_: Can I borrow you for a sec? [05:29] StevenK: maybe, beware, I'm 3/4 a bottle of wine in :) [05:29] rick_h_: wgrant had to add filter: 'raw' for no minified JS from the combo-loader in the pastebin he linked [05:29] right [05:29] I'm just wondering what it should be for qas/prod [05:30] I thought we picked that up in our dev settings [05:30] I think qas and prod should both be min [05:30] chrome dev tools can un-minify it if required [05:30] Which is filter 'min' ? [05:30] but they should both be running without hte raw [05:30] it defaults to min, just remove the raw setting [05:30] bah, see...qas and prod should both be min, which is the default [05:31] Right [05:31] so just leave off the filter all together and it should default sanely [05:31] Yeah, I'm trying to figure out how to codify that given our TAL. [05:31] StevenK: remember, you can edit the config after it's setup [05:32] so YUI_Config... all that [05:32] and then "if dev mode, YUI_Config.groups.... tweak the value after the fact [05:32] I guess I should pull up the file [05:33] base-layout-macros.py [05:33] pt [05:33] Intriguing [05:33] Damn muscle memory [05:33] wgrant: ? [05:33] StevenK: ah right, the whole script block is one script tag, well just add another I guess [05:33] IE8 doesn't complain about broken JS on https://launchpad.net/launchpad [05:34] But it also doesn't execute much or any of it. [05:34] rick_h_: I'm not sure how useful this mess is to you: http://paste.ubuntu.com/882825/ [05:34] And it's not disabled, because when I run it locally without removing any anti-IE guards it breaks. [05:34] rick_h_: If you search for xxx on that page it'll show you where the event stuff is [05:34] StevenK: https://pastebin.canonical.com/62277/ [05:38] huwshimi: your JS scope on your hover (non custom) event is wrong [05:38] this in there is the ev [05:38] either add the this as the third argument or run a that=this in there [05:40] rick_h_: Oh, perfect! [05:40] wgrant: Will with some vertical whitespace sprinkled in would be fine? [05:44] StevenK: Probably. [05:49] ok, I'm out, have fun all [05:50] Night rick_h_. [06:19] lifeless: bugs.statistics_portlet.hide_fixed_elsewhere_count default 0 true? === almaisan-away is now known as al-maisan === al-maisan is now known as almaisan-away [06:25] wgrant: StevenK: has ec2 land failed for you today or recently with a bzrlib error? [06:26] Not for me, but apparently everyone else [06:26] :-( [06:26] workaround? [06:36] pqm-submit? :) [06:40] bigjools: i want it to run tests first though [06:41] who needs those [06:41] me [06:51] wallyworld: I had it fail, you need to update lp-dev-utils [06:51] ah thanks [06:52] And my garbo job branch has checkwatches.txt fail? Le sigh [07:02] wgrant: yes, but also put it on the blog / lp-users or something ? [07:05] lifeless: The premise of the change is that nobody will notice if it disappears. [07:07] indeed [07:07] so there is a balance to strike :) [07:08] That balance is to hide it and watch nobody complain. [07:16] * StevenK is tempted to make a twitter joke [07:20] * StevenK has fun breaking wallyworld's mockup [07:20] StevenK: it's only POC :-) [07:20] what broke? [07:20] wallyworld: Click logout, it's funny [07:20] StevenK: ah, that was never meant to work [07:21] That much is obvious. :-) [07:21] the point of the mockup for this iteration is the disclosure picker chamges [07:21] anything else that works is not guaranteed [07:21] wallyworld: However, hitting the expander for large commercial doesn't show anything and the button that displays isn't wired up [07:21] Er [07:21] *everything, not anything [07:22] which expander? [07:23] The filter one [07:23] StevenK: the filter is not implemented [07:23] it was last revised weeks/months ago [07:24] the thing to focus on for this iteration is the picker :-) [07:25] * wallyworld has to reboot his router. stupid voip port locked up :-( [07:25] wallyworld: You know, flat mockups for the radio buttons, lozenge etc. will do just fine for deciding which direction to go in. [07:27] huwshimi: yeah. but i when we do decide, all the plumbing has to change anyway so i can just reuse what i did there. not much will be wasted [07:28] wallyworld: So you're going to be creating the lozenge etc in javascript as well then? [07:28] huwshimi: not sure. i might hust do a static mockup. but i do think people will want to click and see how they like it etc [07:29] huwshimi: and i thought i'd see the reaction to the radio buttons first [07:30] wallyworld: We need to do flat mockups first. If we need to see interactive ones to be able to decide then we can do those once we've narrowed down the options. [07:30] wallyworld: Doing them at this stage is wasted effort [07:30] i didn't waste much. 80% of the work was in the plumbing which can be resued regardless of what choice we make [07:31] Mmmmmm, delicious delicious tag soup. [07:33] * wallyworld is off to soccer [07:38] wow === almaisan-away is now known as al-maisan === al-maisan is now known as almaisan-away === almaisan-away is now known as al-maisan [08:46] good morning [09:08] aloha [09:09] morning all === danhg_ is now known as danhg === al-maisan is now known as almaisan-away === almaisan-away is now known as al-maisan [12:33] mabac: Hai, your revision of r14942 is up on qastaging and ready for QA, if you can do it soon. [12:34] StevenK, we're doing it now [12:34] salgado: Excellent, thank you. [12:35] StevenK, yup, shouldn't take much longer [12:35] I wasn't going to care about deploying until tomorrow morning my time, so you have about ten hours. :-) [12:35] StevenK, thank you :) [12:54] mrevell: salgado with bugs that are coming into lp for triaging that are blueprint issues what way do you want me to handle them ? [12:56] czajkowski, don't know, tbh. what are the options? [12:59] well two are yours and others are linaro issues. so just wondering will they be considered for development [13:00] or do i traige the all low and add you as the assingee or critical :) [13:00] or opinion :) [13:11] czajkowski, we just filed 3 or 4 that would be very nice to have fixed, so we'll definitely take care of those. there are at least another 2 which are wishlists I'd say. I'll collect them all in an email and state our plans [13:15] and the day begins with a development machine that won't boot from disk errors... [13:16] morning, all. :-) [13:45] * mpt wonders why sinzui changed "private" to "proprietary" in bug 136937 [13:45] <_mup_> Bug #136937: Cannot file a non-security proprietary bug in Launchpad < https://launchpad.net/bugs/136937 > [13:50] mpt, private could mean embargoed security information, Personal user data information, or proprietary information [13:50] mpt proprietary means the information belongs to an organisation any probably will not ever become public [13:52] sinzui, sometimes. A big counterexample was Launchpad itself when it was proprietary. :-) Then our bug reports were private only when they referred to detailed architecture or source code. [13:52] but I understand what you mean now, proprietary is the main use case for non-security privacy [13:52] mpt yes, and we decided to make them all public when the code became public [13:53] There are still proprietary bugs though...we wanted to make all public, but company information is in some comments [13:54] mpt, right. Most private bugs in Lp are user-data because apport includes personal user information that requires cleaning before the bug is made visible to Ubuntu's bug squad === abentley changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: abentley | Firefighting: - | Critical bugtasks: 4*10 [14:32] abentley, I am pondering job system for projects that send emails or maintainers and possibly updates the project. I need a daily script that create job if one has not already been created within a time frame (week or months). Project reviewers could also use the UI to create jobs (send an email about licensing problems). Does this sound doable? [14:32] s/emails or maintainers/emails to maintainers/ [14:33] sinzui: Yes, it sounds very doable. It's a little like how we create recipe builds. [14:33] oh, I will look at that. [14:34] abentley, we only autobuild once per day right? [14:35] sinzui: We used to only autobuild once per day, I'm not sure if that was changed. [14:35] My plans might require that jobs in the jobs table not be deleted or actually remain in the job table for up to 6 months. I do not think we delete job. [14:36] * sinzui has to find more plurals and tenses === al-maisan is now known as almaisan-away [14:37] sinzui: That's correct. [14:37] fab [14:38] sinzui: I and adeuring are currently working on https://dev.launchpad.net/CeleryJobRunner so if you need to change code in lp.services.job, please let me/adeuring know. [14:40] okay. I doubt I will. I was thinking of a new table+model for project jobs that references the exising job object. (dates and statues) [14:41] sinzui: Right. I didn't think so either. [14:41] still one s short [14:41] thanks abentley. I will start sketching this in code [14:42] sinzui: Once we've migrated to celery, we'll have the option of using celerybeat, rather than cron, for scheduling periodic tasks. [14:44] abentley, Oh. I do want that [14:45] sinzui: The way we do recipe builds is we periodically look for recipes to build, and then schedule those recipes to be built. [14:45] Looks like my session is knackered by an update. I am restarting. [14:45] sinzui: ACK. [14:55] oh dear, Starting a window kill the indicators/menus in Unity. starting a terminal is insane as the UI refreshes and the window shrinks by one line each loop until the terminal is just a window frame [14:57] Hmm [14:57] I've seen a similar sort of thing with qemu for a few weeks. [14:57] When run under precise's compiz it has seizures [14:57] resizing up and down for 20s or so [14:57] Until it contracts to ~1x20px [15:00] I think I will not use the indicators for the next day. [15:00] sinzui: Anyhow, pre-celery, you'd have a cron script that looks at projects and creates jobs, and another that actually runs the jobs. [15:01] abentley, indeed that is what I was thinking [15:02] abentley, hey, sorry running a tad late. give me 5 minutes to grab a coffee and we can chat. [15:02] sinzui: post-celery, celerybeat could run a Task that creates Jobs, which would then run in celeryd. [15:02] deryck: sure. [15:02] abentley, how many weeks are we from celerybeat? [15:03] sinzui: I think at least two. [15:04] sinzui: This almost sounds like a straight cron script would do the trick, though. If you had a field on the project to track the last execution. [15:06] abentley, I do not want to change project because there can be many reasons a job is in the queue, and there could be several, but I want to avoid duplicate jobs (a job type that I need to create) or jobs that spam users too frequently [15:07] I want my process to look at the most recent jobs for a time frame and if the type is not present, create one [15:07] sinzui: I guess you could have one script that created the jobs and then ran them immediately. [15:08] That might be th effective out come. since the task is short [15:09] I am separating how the job is created from the job since I already know of two very different ways that the job would need to be created [15:09] abentley, https://plus.google.com/hangouts/extras/talk.google.com/orange-catchup (when you're ready) [15:39] what's the difference between login.launchpad.net/$id/+decide and /two_factor_auth? [15:45] cr3: Dunno - login.launchpad.net is the SSO server ISD runs, despite it being on our domain. [15:56] adeuring, hey, just finished my chat with abentley and we updated the board to better reflect the multiple branches you have going. [15:56] deryck: ok, thanks [15:58] adeuring, also, were you getting something up for review today or tomorrow? Or you're not sure yet? [15:58] deryck: things are nearly ready [15:59] adeuring, awesome! [15:59] thanks! === salgado is now known as salgado-lunch [16:58] abentley: https://code.launchpad.net/~adeuring/launchpad/lp-lazr.jobrunner/+merge/97458 (plus lp:~adeuring/launchpad/lazr.jobrunner-more-tests -- no MP for that branch) [16:58] adeuring: Cool. Looking. [17:05] adeuring: I don't think we can land this with "develop =../lazr.jobrunner". We need lazr.jobrunner to be an egg in download-cache. [17:10] adeuring: It looks like lp.services.job.model.job.Job is not derived from lazr.jobrunner.jobrunner.BaseJob. Should it be? [17:11] abentley: It can't hurt, I think, but it's not strictly necessary either. IOW: I don't have any opinion on it ;) [17:12] adeuring: I think it will be clearer if we do it, so we should, but we can do it in a follow-up. [17:13] abentley: right; there are anyway a few things to clean up, like the change to buildout.cfg === matsubara is now known as matsubara-lunch [17:14] (together iwh bureaucracy, like adding lazr.jobrunner to the download cache) [17:15] adeuring: The purpose of lp.services.job.jobrunner.BaseJobRunner.runJob is to adapt the input to IJob? [17:16] abentley: I think so. That was your change, IIRC ;) [17:16] adeuring: Yes, I believe so. It almost looked redundant. [17:18] abentley: Well, it is a way to "mix" any run() method (i.e., the core of a job) with the "Bureaucratic" stuff, like start(), fail() etc [17:19] adeuring: It looked redundant with lazr.jobrunner.jobrunner.BaseJobRunner.runJob [17:21] adeuring: Do you know whether the removeSecurityProxy in job_str is still necessary? [17:21] abentley: I did not check... [17:22] adeuring: I think I did that before I made job_id a part of IJob. [17:22] abentley: ok, let's try it. Also, you are right: we can drop BaseJobRunner.runJob(); at least, the tests pass [17:27] adeuring: How does makeOopsReport access the oops messages? [17:28] abentley: makeOopsReport() does net "see" these messages. Adding them is done via a callback in oops_config. [17:29] abentley: but makeOopsReport could be used instead of the context manager to add this extra data. (with a small drawbacks.) [17:30] adeuring: Okay, I see where that's done now. That's fine. === salgado-lunch is now known as salgado [17:43] adeuring: By deriving BaseRunnableJob from BaseJob, you'll eliminate a little redundancy: user_error_types, retry_error_types [17:43] abentley: right [17:47] adeuring: You should also specify a version of lazr.jobrunner in versions.cfg [17:47] abentley: yes [17:47] abentley, hey they. I have one for review when you're available. [17:48] deryck: ACK. With you in a few minutes. [17:49] abentley, no problem. Thanks [17:52] abentley: if we derive BaseRunnableJob from BaseJob, the delegaton mechanism to lp.services.job.model.job.Job.start() etc fails; instead, the "dumb" methods from BaseJob are used. And these are not aware of the DBEnum values of the status property. [17:53] adeuring: Okay, let's leave it alone for now. [17:55] adeuring: Okay, so that's everything I see there. I'm going to mark it "needs fixing" because it needs to specify a proper egg for lazr.jobrunner. [17:55] abentley: right [17:55] adeuring: But don't get me wrong, this is great progress. [17:56] thanks [17:56] deryck: I can look at your review now. [17:57] abentley, thanks! https://code.launchpad.net/~deryck/launchpad/buglistings-preload-people-901122/+merge/97041 === matsubara-lunch is now known as matsubara [18:05] deryck: In getBugTaskPeople, can you just use Bug.owner directly, instead of getting Person.id? It should be the same value, and it reduces the number of tables involved. [18:06] abentley, but I need to return the people themselves. [18:07] deryck: right. I mean use bug.owner and bug.assignee to generate your person_ids. [18:08] abentley, ah, right. Well I could use bugtask.assignee, but I can't use bug.owner without issuing another query to get Bugs. That's why I did the big join. [18:08] deryck: e.g. http://pastebin.ubuntu.com/883667/ [18:09] * deryck looks closely [18:10] abentley, ah right! I see what you mean now. yes, I can do that. thanks [18:10] deryck: np [18:11] deryck: bug.ownerID ? [18:11] abentley, it's a hold over from the first iteration of this, where I just had a union and selected people, not subselects to get ids. [18:11] lifeless, that's what I thought abentley was suggesting. he's talking about simplifying the way I wrote a subselect. [18:13] deryck: I guess the advantage of your version is that it handles NULL assignee/owner automatically. [18:13] deryck: I think you will get much better results using the Person eager load helper. [18:13] abentley, yeah [18:13] deryck: which knows how to get related assets; you know that bugtask is loaded, and bugtask.bug is already loaded. [18:13] lifeless, where is the person helper? [18:13] deryck: so you have no need to do any DB work in this helper at all: just assemble the ids you need and hand off to the person helper. [18:14] lifeless, I thought doing this would issue more queries: [task.bug.ownerID for task in bugtasks] ? Local testing seemed to say so. [18:14] deryck: getPrecachedPersonsFromIDs [18:14] deryck: if bugtasks is a storm collection, yes it will [18:15] lifeless, right. so that's why I made my own query. [18:15] thats why you need to listify anything you get from storm before you start wrking with it [18:15] slice it first, then materialise and cache [18:15] ah [18:16] so I could listify the batch, get the owner ids and hand off to the person helper? [18:16] deryck: right, though if it is a batch, not storm, it has a caching layer in it already [18:17] deryck: I suggest, grab the ids, hand off, and if you get extra queries, show me the backtrace leading up to the first one and I will help you sort it out [18:17] lifeless, ok, that's fair. thanks [18:17] abentley, so never mind then. :) see ^^. I'll rework it. [18:18] deryck: Okay. Happy hacking! [18:18] abentley, thanks :) [18:18] shouldn't be too big a change really. [18:18] * deryck steps away briefly to get food [19:14] abentley: hi, I have a very small MP that I'd like to get on your review docket: https://code.launchpad.net/~benji/launchpad/bug-954319/+merge/97491 [19:16] benji: sure thing. [19:16] cool [19:17] benji: r=me. [19:17] abentley: thanks [19:18] I am in a state of kanban conflict: the board is now not over the limit (with me moving my branch into landing) but we can't add anything else without going back over [19:19] oops, wrong chan [20:18] deryck: were you ever able to get LP running on a new precise box? I'm trying to set one up and am apparently having the same problems you wrote to the list about. [20:19] benji, I did. I had to install postgresql from oneiric packages. I downloaded them from launchpad individually by hand.... [20:19] benji, and then I'd run make run and install packages individually via apt-get install until it quit erroring. [20:20] wgrant: btw, there is demand for a public API for openid->teamsetc [20:20] benji, I think I've got everything installed now except launchpad-messageque-dependencies. [20:20] wgrant: wondering if you want to make it a full fledged thing at the same time [20:21] deryck: I'm glad you got it working. I guess I'll go the same route. [20:21] benji, yeah, it was a slow and steady pain, but fixable given time and will power. [20:22] This seems like it should be a priority for us to fix. I would attempt to do so, but given my knowlege of packaging, it would be a bigger waste of time than I'm already facing. [21:52] lifeless: Need to try to push XMLRPC duration variance down a bit first [21:52] It's possibly not possible with the current setup, though. [21:53] Since we're going to be GILled sometimes no matter what I do. [21:53] And really these should complete in tens of milliseconds. [21:53] wgrant: I was thinking xmlrpc for sso, API for u1 etc [21:58] only sso with its special casing needs to bypass visibility rules [21:58] lifeless: Well [21:58] lifeless: The others would need to run under service accounts. [21:58] Which we don't really do. [21:59] And we would need to have extended private team visibility rules. [21:59] Or have the service accounts as members of the teams... [21:59] ew [22:00] the latter is pragmatic === rick_h_ is now known as rick_h [23:27] wgrant, I see I misunderstood Y.Array(my_array). I though it returned a YUI Array, not a native array. I do not see anything I have written in your diff, but I think code I have written for disclosure and teams must be wrong [23:27] Test results: bugfilters-ie8 => devel: SUCCESS [23:27] Success [23:27] sinzui: Oh yes, I initially tried to use it as a constructor too [23:27] sinzui: One of the more braindead YUI decisions I've seen... [23:28] I think I fixed everything except for some of the derived distros widgets. [23:28] I'll recheck. [23:32] sinzui: Thanks [23:48] wallyworld, sinzui, StevenK, jcsackett: ec2 is fixed if you want to pull lp:lp-dev-utils [23:48] cool thanks :-) [23:58] Mornin [23:58] Hi nigelb