=== webjadmin_ is now known as JackyAlcine === m_conley is now known as m_conley_away === josh_wines is now known as joshwines [09:21] morning all! [09:35] Morning all! :D [11:04] good morning! [11:33] reboot [11:49] tomboy notes are not synchronising from one of my machines - "failed to synchronise notes. check the details below and try again" . expanding details says "updated" for various notes (same ones each time), but new notes are not being uploaded. any suggestions? [11:51] oimon, try asking rye about that :) [11:54] good morning everyone! [11:54] gatox: will start with your reviews now [11:54] nessita, hi! ack [11:56] oimon: i have a script that fixes that [11:58] oimon: http://people.canonical.com/~roman.yepishev/us/tomboy-sync-validator.py - please run it in the terminal and see whether it reports any errors [12:01] nessita, there is any bug in particular you want me to review?? i was updating my installer-migration branch [12:01] gatox: no need to update that branch... we will not use the installer [12:01] nessita, i remove the issue then? [12:02] as invalid? [12:02] gatox: let me check your bug queue [12:02] nessita, ok [12:03] rye, thanks, no errors, but running tomboy --debug and trying to sync gives http://paste.ubuntu.com/884680/ [12:04] gatox: I will update that bug since it needs to also affect ussoc [12:04] oimon: argh, that's tomboy bug, let me look it up [12:04] nessita, there was a different one for sso..... which is already closed [12:04] gatox: ah... why 2 bugs? [12:04] rye, i'm on 11.10 [12:05] nessita, i think there was one for sso..... and one for the installer [12:05] gatox: ok, in those cases we should use a single bug affecting the 2 projects (for future reference) [12:05] might be bug 848250 [12:05] Launchpad bug 848250 in tomboy "Tomboy sync fails on Oneiric, New Note Template already exists" [Medium,In progress] https://launchpad.net/bugs/848250 [12:05] nessita, ok [12:06] gatox: can you please update the status of all your in progress bug? [12:06] there are some I guess you're not working on (https://bugs.launchpad.net/ubuntuone-client/+bug/889785 for example) [12:06] Ubuntu bug 889785 in Ubuntu One Client "Can not add folders in WinXP" [High,In progress] [12:07] nessita, done [12:07] gatox: you updated all your in progress bug? :-) [12:08] nessita, i had a couple of in progress..... that i change them back to triaged... because i started with them, but then i needed to move to another issue..... and my current issues were already "in progress" [12:08] gatox: perfect [12:13] gatox: bug list updated, you can choose between any medium it tempts you [12:13] nessita, great, thanks! [12:14] rye, it doesn't seem solvable due to u1 notes being unavailable now [12:14] oimon: bug 848250 [12:14] Launchpad bug 848250 in tomboy "Tomboy sync fails on Oneiric, New Note Template already exists" [Medium,In progress] https://launchpad.net/bugs/848250 [12:14] oh, you already found it :) [12:14] duanedesign, yep, the workaround cannot be performed due to server side notes being removed [12:14] duanedesign: i was not able to find it :-/ [12:15] comment 10 seems to work sans webui [12:15] gatox, nessita morning to you too! [12:15] hola mandel [12:15] how is it going? [12:16] nessita, fine, got a number of proxy bugs fixed and moving on to the next :) [12:16] nessita, If you have time you can give me a couple of reviews ;-) [12:17] duanedesign, doesn't work for me :( [12:20] nessita, any one looking at bug 884978 else I'll tackle it since is a high priority one [12:20] Launchpad bug 884978 in Ubuntu Single Sign On Client "pass proxy config to T&C webkit" [High,Triaged] https://launchpad.net/bugs/884978 [12:20] mandel: I will try, but already have 7 reviews to do [12:20] oimon: you probably caught this but the name of the note is capitalized 'New Note Template'. I noticed in the comment the user refers to it in lower case. [12:20] nessita, any from alecu, I can do those [12:21] mandel: nopes, all from diego, roberto and rodney [12:21] nessita, ok, then I'll move to 884978, is that ok? [12:21] mandel: regarding that bug, there is another about the t&C not loading... so that may complicate your work a bit :-( [12:21] let me find the other bug [12:22] nessita, please do, I might as well look at loading the t&c and then into the proxy [12:22] mandel: bug #933081 [12:22] Launchpad bug 933081 in Ubuntu Single Sign On Client "GTK UI: URL for terms and conditions never finishes loading" [Medium,Triaged] https://launchpad.net/bugs/933081 [12:22] mandel: we may be missing a webkit signal or something... [12:23] nessita, ok, tackling that one first then, thx for the bug number! [12:23] mandel: so perhaps we need to solve that without proxy, and then add the proxy bits. Or if it's short, you can do both in a single branch? [12:23] nessita, is this in the gtk implementation or the qt? [12:23] mandel: feel free to assign yourself there [12:23] mandel: gtk [12:23] nessita, if they are small I'll try to fix both at the same time :) [12:23] mandel: ah, you were talking about qt? [12:24] mandel: in qt we do not show the T&C in a webkit... [12:24] nessita, then is gtk :) [12:24] heh [12:24] nessita, no worries, I'll deal with this guy now [12:24] mandel: let me know how that does [12:24] goes* [12:24] ok [12:32] nessita, I've seen someone complaining about something with pygobject and connect_signals before in stackoverflow.. let me find it, we might have the same issue [12:34] good morning! [12:36] ralsina, hi! [12:39] gatox, nessita, mandel: if anyone needs reviews now is a good time because I am switching to windows today [12:39] not permanently [12:40] ralsina, I do, I do! [12:40] ralsina, ah! don't scare us like that! jejeje [12:40] mandel: hit me! [12:40] ralsina, let me get the easy ones that are very short, one min [12:40] gatox: you are a mac user :-) [12:40] ralsina, not yet jeje [12:40] ralsina: I think you also have pending https://code.launchpad.net/~brian.curtin/ubuntuone-client/930398-windows-is_root/+merge/96224 [12:40] ralsina, i bought the mac..... and i didn't turn it on yet since that day [12:41] ralsina, https://code.launchpad.net/~mandel/ubuntu-sso-client/ssl-checkbox/+merge/97619 and https://code.launchpad.net/~mandel/ubuntu-sso-client/merge-code/+merge/97627 [12:41] nessita: I want to test that one IRL so I am leaving for when windows works :-/ [12:41] ralsina, really really easy ones [12:41] ralsina: ah ok :-) [12:41] ralsina, i've added the pretty pictures here: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/ugly-reset/+merge/96130 [12:41] gatox: worse then you are a fake mac user! ;-) [12:41] gatox: cool! [12:43] gatox: why is the left padding (to the titles/lineedits) much smaller than the right padding (to the button)? [12:43] ralsina, because we are adding a left-padding in the stylesheet for all the pages [12:44] gatox: but why is the right-padding *larger*? [12:45] ralsina, ahhhh you mean that the right-padding should be of the same size as the left one?.... ok, fixing that [12:45] nessita: if I swear that I'll have a fix for those two things you mentioned in dobey's system-font branch 15 minutes after it lands, would you approve it? I want to take it off dobey's plate [12:45] gatox: I am just asking. If you have a good reason,I may not care :-) [12:45] ralsina: then why those stuff ended in dobey's plate in the first place? :-/ [12:46] nessita: because he wanted to do it [12:46] nessita: and then it kinda grew :-) [12:46] ralsina, nop good reason.... just was according to my taste.... it wasn't any specific guideline..... so i pick :P [12:46] ralsina: I'm still worried that the default font looks too big... can we do something about that? [12:46] nessita: they are the size of the default ubuntu font. That's a desktop-wide setting [12:47] ralsina: where can I check what font I have setup? because I'm pretty sure I have a small font... [12:48] gatox: any reason to set 30px right margin for the reste page? [12:48] reset* [12:48] nessita: just open a normal app, like settings,thunderbird or whatever, should be the same size. They are here. [12:48] gatox: given that the parent already have it set [12:48] nessita, the parent already have a right margin? [12:49] gatox: yes, of 30px, so all the pages show the same indent [12:49] nessita, the font used to be in Appearance.... but it doesn't seems to be there anymore [12:49] nessita, ok, i'll remove that and check [12:49] ralsina: I can approve once the welcome label is fixed, the side widget I can fix in my controlpanel branches [12:49] nessita: cool then [12:49] gatox: thanks [12:50] gatox: the branch looks good, will approve, but please remove that 30px margin :-) [12:50] nessita, yes.. on it [12:52] nessita: just in case, here is how thunderbird and u1cp look in that branch. u1cp is bolder because it's the ubuntu font, but size is ok: http://ubuntuone.com/6sa3Q8lCADIpEXnTYqwmCJ [12:55] nessita: gsettings get org.gnome.desktop.interface font-name [12:55] nessita, ralsina padding fixed [12:56] good morning dobey! [12:56] hi [12:57] nessita: I see you changed my commit message on ubuntu-font-in-windows, I have been trying to follow the style you mentioned, did I do it wrong? [12:57] ralsina: the work "Fixed" in (Fixed LP: #1234567) should not be there :-) (thanks for asking!) [12:57] word* [12:58] oops, I remembered it wrong then. Let me tattoo it in theback of my left hand ;-) [12:58] juaz [12:58] ralsina: I read that fast and wonder "what does your son has to do with this?" [12:59] hahaha [12:59] he didn't remind me1 [13:00] gatox: this is approved https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/captcha-problem/+merge/97505 but requested a test improvement [13:00] (please) [13:00] nessita, ok [13:02] gatox: +1 on ugly-reset [13:02] ralsina, thx! [13:09] ralsina: should i pick up where i left off with the windows installer work, or did you add anything? [13:09] briancurtin: done nothing there yet [13:09] ok, i'll push forward with what i have [13:09] briancurtin: are tests running? Anything we can parallelize? [13:10] nessita, http://code.google.com/p/pywebkitgtk/issues/detail?id=44 is fixed an we can use the enums from pygobject, shall I change the code for that? that means importing webkit which we probably not want since you added a comment about delaying the use of webkit to be able to build [13:11] ralsina: tests are to the point that they're running. i see a few API differences that need to be accounted for first (e.g, different num of args to some funcs). all imports are changed [13:12] briancurtin: running and failing? ;-) [13:12] ralsina: there's one particular issue that could be parallelized, in figuring out what to do with this change: http://bazaar.launchpad.net/~brian.curtin/ubuntuone-windows-installer/release-updates/revision/111 [13:12] ralsina: yeah, running and failing. it doesnt look too far away from having them passing, though [13:13] briancurtin: we are not using the windows-installer binary anymore [13:13] briancurtin: so, don't worry about it. We will just start control panel from the bitrock installer [13:14] mandel: sure! [13:15] briancurtin: hola! would you please fix the comments from https://code.launchpad.net/~brian.curtin/ubuntuone-client/851810-notify-on-volumes/+merge/94280 when you have a moment (no rush)? [13:15] ralsina: so i can ignore issues in the ubuntuone_installer package? ok, that pushes me back towards a twisted thing i was running into yesterday that i'll work on [13:15] nessita, and the import, what do you want me to do with that? not importing from the top but just when webkit is used? [13:15] briancurtin: cool [13:15] nessita: yep, i saw the review - thanks. i'll take a look when i'm done with this [13:16] mandel: yes [13:16] nessita, ack [13:16] briancurtin: ack, thanks [13:20] mandel: +1 on both branches, congrats on the spelling (trick: branches with no words in them) [13:21] ralsina, lol [13:23] gatox: simple needs fixing in https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/qt-login-backend/+merge/97425, but wanted to be sure you knew about logger.exception [13:23] ralsina: you too ^ (perhaps) :-) [13:23] nessita: thanks, I did not know that! [13:23] nessita, me neither [13:24] :-) [13:24] now I need to find roomfor another tatoo... [13:24] another child?!?!?! [13:24] ralsina, jejje [13:24] nessita: another dead braincell because of old age and my brain is full! [13:25] ralsina, you can made a t-shirt with all the new things and work in front of a mirror :P [13:25] nessita: no thanks, one is enough :-) [13:26] ralsina, gatox: http://pastebin.ubuntu.com/884765/ [13:31] nessita, ok, lp:~diegosarmentero/ubuntu-sso-client/qt-login-backend updated [13:38] holas! [13:38] * alecu is back. [13:39] gatox: thanks! [13:39] hola alecu [13:40] mandel, ping [13:40] alecu, pong! [13:40] mandel, what did you end up doing re: pinned certs storage? [13:40] alecu, ralsina solution [13:40] ralsina: would you have at hand a screenshot of the license page? my external drive with my VM is not mounting [13:41] mandel, great. [13:41] nessita: some context? ;-) [13:41] ralsina: how many license pages do we have? :-P [13:41] nessita: 2, AFAIK [13:41] ralsina: the former installer license page, would you have a screenshot handy? [13:41] ralsina: 2? really? [13:41] nessita: on windows? [13:41] on... U1 [13:41] :-D [13:42] nessita: sorry, you lost me [13:42] nessita: let's try again, want a screenshot of the old license page in what? The old gtk sso? The windows installer? [13:42] ralsina: heh. WOuld you have a screenshot of the license page from the installer, the one that shows the gpl fragment license? [13:42] ralsina: gtk sso never showed license, but T&C [13:42] nessita: let me look for it [13:43] right [13:43] nessita: in 2' [13:43] no rush [13:44] I'm of to buy some peppers and have lunch, catch you i a little! [13:44] * mandel lunch [13:50] if anyone has 2 seconds for a spelling error i came across in a keyword argument: https://code.launchpad.net/~brian.curtin/ubuntuone-client/upoad-spellcheck/+merge/97656 [13:53] So virtualbox completely crashed my ubuntu, and am now on windows 7 [13:57] nessita: http://screencast.com/t/wq2JlJvu [13:57] ralsina: thanks!!! [13:59] briancurtin: nice catch [14:01] dobey: you approved without a test :-/ [14:01] briancurtin: we should add a test that failes with that typo [14:02] and then propose the fic [14:02] is a bug if we did not have a failing test for that typo [14:02] nessita: i thought so as well. i'll see if i can fit it in, need to focus on installer updates for now [14:03] briancurtin: thanks [14:20] briancurtin, alecu, gatox, nessita, dobey, thisfred, mandel: looks like the DST change has moved our team meeting to 20 minutes ago and oone noticed it [14:20] ralsina: we could stick with the art time, no? :-P [14:21] ralsina: we need to check with mandel, since he has lunch now [14:21] ralsina, our meeting is on UTC time! [14:21] i thought it was in 40 [14:21] ralsina, so, it's 40 minutes from now :-) [14:21] alecu: google calendar disagrees :-) [14:21] either way works for me [14:21] ralsina, yep..... i saw the email.... but it wasn't 12pm :P [14:21] so, we'll have it in 40. Just a heads up :-) [14:22] 20 minutes ago is better for me [14:22] heh [14:22] the meeting is at 3pm utc [14:22] dobey: because you already are on DST :-) [14:23] google says is 2:22pm UTC now [14:23] ralsina: you don't have a DST though [14:23] dobey: we do sometimes [14:24] google also says the meeting started 20 mins ago. So whoever created the calendar item didn't do it in UTC [14:24] mandel, nessita: u1cp-qt fails while trying to go thru an authenticated proxy, like this: http://pastebin.ubuntu.com/884837/ [14:24] mandel, nessita: the very very weird thing? it's trying to use libsoup. [14:24] brb reboot [14:24] alecu: what system? [14:24] nessita, P [14:25] alecu: the choosing in on the webclient side... [14:25] ralsina: but only on leap years during a famine when a new ruler comes to power [14:28] dobey: exactly. Since we are on repeated ruler, no DST [14:29] nessita, mandel: and ussoc is failing in a similar way, also using libsoup: http://pastebin.ubuntu.com/884852/ [14:29] alecu: do you have python-qt4 installed? [14:29] nessita, probably. I wouldn't see any UI otherwise, right? [14:30] "already the newest version" says apt-get [14:30] alecu: so, the mainloop detection is being made in ussoc, ubuntu_sso/main/linux [14:30] alecu: would you put some prints there and see what's going on/ [14:30] ? [14:31] nessita, the mainloop used according to the logs is qt [14:31] nessita, File "/media/sf_canonical/ubuntu-sso-client/trunk/ubuntu_sso/main/qt.py", line 71, in run_func [14:31] loop.exec_() [14:31] alecu: then perhaps the webclient chooser needs some checking? [14:31] I'll take a look at that. [14:38] nessita, lol. The webclient chooses to use the qnetwork backend only if the qt4reactor is installed. But no reactor is installed in fact! [14:39] alecu: bug! :-P [14:39] alecu: also, great news that we're not using the qt4reactor ;-) [14:39] nessita, we are not using it on linux, right. [14:40] if it were choosing it, then it would be another bug. Lose lose situation there. [14:44] I had forgotten what a pain it was to do stuff on windows. Selective memory FTW [14:49] "getting information, please wait..." forever. ralsina - does that ring a bell for anything i'm forgetting to include? [14:50] (also the windows/root branch i proposed does work on XP, since i got this far) [14:50] briancurtin: hmmm [14:50] briancurtin: probably not finding something [14:50] briancurtin: is that running exes or .py ? [14:50] ohhh, i know. forgot to update everything in the bitrock xml file [14:51] hehe [14:51] briancurtin: off you go ;-) [14:51] its all in the dist/ but that's all [14:51] briancurtin: yu should be able to run everythig from dist [14:52] oh they are there. (thought for a second that while i added new bins to the setup, bitrock didn't know about them, but it picks up the whole dist folder anyway) [14:52] alecu, looking [14:52] alecu, what is happening there is that the prox-uri property is not set in the async session.. [14:53] alecu, which is something we have never tested because we always use force_use_proxy, would be interesting to see what the gnome proxy feature is doing.. [14:53] mandel, that's one thing. But the funnier one is that for the qt control panel and the qt sso the libsoup backend is being used. [14:54] mandel, that's more worrying to me. [14:54] alecu, wait, is not using them from the qt processes since it it was you would get a segfault qt and gi don't like each other at all [14:55] mandel, the qt processes are *using* libsoup. [14:55] alecu, what might happen is that the sso dbus process is suing the gi reactor, therefore is calling libsoupd, the qt panel is called with spawn process and there the qt version is used [14:55] mandel: gi shouldn't have a problem under qt [14:55] dobey, yes, because qt uses gtk2 :) [14:56] mandel: qt itself doesn't. i guess maybe the theme thing does? [14:56] alecu, ^ [14:56] dobey, yes, I should have specified, the theming does use gtk2 [14:56] mandel, well, at the point that the webclient is started, no reactor has been imported. [14:56] mandel: but still, that should be fine, because libsoup doesn't use gtk [14:57] so the symbols conflicting problem shouldn't happen there [14:57] dobey, hm.. the easies things is to test it in a little script rather than speculate :) [14:57] mandel, anyway: we do not want to use libsoup here. We want to use qtnetwork. [14:57] dobey, you argument is mutt and I'm going to remove gwibber hehehe [14:57] mandel, the sso backend should be using qtnetwork. [14:58] alecu, certainly, so there are two bugs, one, what happens with the proxy-uri, second why are we using the wrong lib [14:58] mandel: i'm not speculating :) [14:58] dobey, lol [14:58] and i don't care if you don't use gwibber [14:58] dobey, I am :) [14:58] troll [14:58] mandel, the proxy-uri problem might go away if we use qtnetwork. [14:59] dobey, I most say, well handled ;-) [14:59] alecu, certainly, but it should not happen, I need to investigate how can that be dealt with [14:59] mandel, do you have time to look at the qtnetwork on the backend process issue? [15:00] alecu, I have time for both issues, I'm at the moment fixing the t&c from ubuntuone-control-panel-gtk [15:00] alecu, and I believe I'm done (need to write some small tests) [15:00] mandel, I've tried doing some IRL of ussoc in trunk going thru an authenticated proxy, and it fails like I pasted above. [15:01] everyone, mumble? [15:01] alecu, you mean this: http://pastebin.ubuntu.com/884837/ [15:01] ralsina, dobey, alecu, mandel, gatox? [15:01] nessita, ups!!! going! [15:01] mandel, ubuntuone-control-panel-gtk???? GTK? [15:01] urbanape: ? [15:01] me [15:01] gatox: eh? [15:01] :-) [15:01] mandel, I thought the gtk one was gone [15:01] gatox: mumble! is jueves :-P [15:01] ahhhhhhh [15:01] :P [15:01] gatox: you have to say "me" into the headset [15:01] alecu: is gone, has been nuke [15:02] alecu, sorry I mean the gtk of sso [15:02] alecu, I confused the project [15:02] mandel, ok. [15:02] nessita: going [15:02] nessita, saw it nuked on my tree... congrats? [15:02] alecu: ponele :-) [15:03] it lasted for... two releases? [15:03] alecu: natty, and oneiric [15:03] so, yes [15:03] thisfred: mumble [15:03] dobey: right, thanks [15:03] alecu: [15:04] alecu: mumble [15:04] and thisfred: you too! [15:04] thedac: I would never forget to ask you to come! :-) [15:04] oops, that was for thisfred [15:04] I hate the drivers for my laptop [15:05] * alecu is rebooting the laptop where mumble resides. [15:44] dobey: gatox: links to merge props you need review on plz [15:45] https://code.launchpad.net/~dobey/ubuntu-sso-client/system-font/+merge/97264 [15:45] thisfred, thanks, but i only need a re-review from nessita [15:46] kk [15:46] dobey: I'm on it [15:47] +1 [15:48] thisfred, wow! that was fast! [15:48] jejeje...... i think i'm going to give you my future branches [15:49] the branch was close to trivial ;) [15:49] jeje [15:49] fark me, argument parsing on windows sucks when you are not an exe [15:50] its especially horrible if you're in a batch file [15:51] briancurtin: it's impossible right now to run control panel like python bin\ubuntuone-control-panel-qt because we are getting "bin\ubuntuone-control-panel-qt" as argv[1] :-( [15:54] i would think that'd be your argv[0] [15:55] briancurtin: but it's not [15:55] python is my argv[0] [15:55] oh, wait [15:55] it's Qt [15:56] application.arguments() has the *real* argv [15:57] ok, that's fixable [15:58] deltree /Y C:\ [15:58] there, I fixed it [16:00] ooh [16:00] native work items in lp [16:01] ralsina: so what did you want me to manually test now? [16:02] thisfred: proxy, talk to alecu about what to test, talk to gatox about using my proxy [16:02] kk [16:02] alecu: what to test? ;) [16:03] thisfred, we need to test trunk sso and trunk control panel, going thru an authenticated proxy. [16:03] thisfred, but first we need to force the qt webclient backend. [16:03] ok let me grab and build those [16:03] force? [16:03] thisfred, we are testing this on P. [16:03] I am on P [16:04] thisfred, yes: this morning we found out that the libsoup webclient backend was being used by mistake. [16:04] alecu: ah ok, so I need to wait for your ping when that's fixed? [16:05] thisfred, you can go ahead branching and building all that, and merge my branch with the fix, that should be ready in 10min [16:07] kk [16:08] * gatox lunch! [16:09] thisfred, lp:~alecu/ubuntu-sso-client/use-qt4-webclient-backend [16:09] mandel, ^ [16:09] alecu, on it! [16:10] * thisfred too === gatox is now known as gatox_lunch [16:15] * briancurtin lunch [16:17] mandel, I've managed to reproduce the segfault: [16:17] http://pastebin.ubuntu.com/884995/ [16:17] mandel, it happens *only* when using an authenticated proxy. [16:17] mandel, and it happens after accepting the dialog with the proxy passwords. [16:18] alecu, looking [16:18] mandel, I've only tested sso; I've not tested u1cp yet. [16:18] lunch. bbiab [16:18] nessita, ^^^^ [16:18] nessita, (good news so far) [16:18] alecu, I'm palying with control panel [16:18] alecu: nice! (reading backlog) [16:20] alecu, hm.. I'm getting that the ssl cert in *ubuntu.com is not valid.. wtf? [16:21] alecu, nessita control panel seems ok with nonauth proxies [16:25] mandel, nessita: control panel segfaults with authenticated proxies when forcing the qt4 webclient backend. [16:25] alecu, got the same here.. [16:26] mandel, but it seems to work fine for non-authenticated and for no proxy. [16:26] mandel, did you get the segfault too? [16:26] mandel, also, both sso and u1cp pop up the proxy credentials dialog *twice* (each one) [16:26] alecu, yep, and I also got the following: http://pastebin.ubuntu.com/885010/ [16:27] alecu, indeed, I have seen that too, when it should not since the info after the first attempt should be in the keyring [16:27] mandel, I got that same message (proxy server not found) [16:28] mandel, the thing is that the credentials dialog is popped up twice, one on top of the other. It's not waiting to retry. [16:29] alecu, hm.. interesting.. so in summary, nonauth does not segfault, right. while with auth does, where we have keyring and spawn process.. [16:29] mandel, this seems related to the issue with QAuthorizers I reported by mail last night. [16:29] mandel, keyring and spawn too [16:29] alecu, could be, but we also need to check who is spawning the dialog, could it be one from sso and other from control panel? [16:30] nessita, does the control panel request anything from sso via dbus? [16:30] mandel, no: this happens when I do it from sso only. [16:30] mandel: yes, credentials [16:31] alecu, hm.. but in my last irl everything worked fine.. yet, it was using libsoup and not qt! [16:31] mandel, anyway: we have two issues: first, we need to use the qt4 backend, and we need a proper branch for this, not my quick hack. [16:31] second: we need to fix the segfault. [16:31] alecu, so, yield in the signal, show dialog, qt main loop recovers the control, error, then the errback spawns the dialog [16:32] mandel, right [16:32] mandel, that's exactly what I suspect is causing the double dialog. [16:32] alecu, so, why horrible horrible way to fix this is not to listen to the signal.. [16:32] alecu, go straight to the errback to deal proxy auth issues [16:33] alecu, which my incur in performance.. [16:33] mandel, I hope "performance" there is just a joke. [16:34] alecu, it should not be an issue, no [16:34] alecu, and is a simple fix.. [16:35] alecu, let me make that change in your branch and see what happens [16:41] mandel, are you able to work on a proper branch to select the qt backend? [16:42] alecu, yes, I'm done with what I was working with [16:42] alecu, so does it make sense for me to manually test now, or should I await further fixes? (waiting on gatox_lunch for the proxy instructions) [16:42] alecu, I can also remove the double dialog poping up [16:44] thisfred, yup, I think we are done till we have more fixes. sorry to trouble you. === gatox_lunch is now known as gatox [16:45] alecu: no trouble at all, please ping me when/if I can be of assistance [16:46] thisfred, thanks! [16:46] thisfred, here am i [16:46] nessita, ping [16:47] gatox hi, if you can explain to me (best in private msg I guess) how to use roberto's proxy, that would be awesome, then I'll know the next time I need to test [16:47] mandel: pong [16:48] nessita, t&c page loading fixed, I also noticed that going to the t&c page, going back and going again will result in a crash and fixed it in that branch, is there a bug for that? [16:48] nessita, the reason is that you cannot add twice a widget to a scroll area, easy fix :) [16:49] thisfred, yes, i'm trying to find the ip from roberto's machine.... [16:49] mandel: no bug, wanna file it? :-) [16:49] nessita, sure! [16:49] mandel: and awesome you worked on this! :-D [16:50] nessita, thx :) [16:51] ralsina, can you repeat your ip please, i don't have it.... the port was 8888 i think [16:52] gatox: 184.82.108.14 [16:52] thisfred, there.... that ip, with the user and pass i gave you should work === lifeless_ is now known as lifeless [16:54] gatox: thx [16:56] thisfred, if you fancy doing a review I will appreciate it :) => https://code.launchpad.net/~mandel/ubuntu-sso-client/tc-not-loading/+merge/97698 [16:56] nessita, FYI: https://code.launchpad.net/~mandel/ubuntu-sso-client/tc-not-loading/+merge/97698 [16:57] mandel: on it [16:58] thisfred, thx! [16:58] hey, all: can I get another review here? https://code.launchpad.net/~alecu/ubuntuone-client/proxy-tunnel-fix/+merge/97475 [16:58] alecu, I found the reason why we are not finding the host :) [16:59] mandel, awesome! [16:59] alecu, very simple, so I can push a branch will all the changes and not be a gazillion lines :) [16:59] gotta love simple fixes to complex problems. [17:02] gatox, briancurtin: review please? https://code.launchpad.net/~ralsina/ubuntuone-control-panel/truncate-argv/+merge/97700 [17:02] ralsina, on it [17:03] gatox: oops, that branch is missing half a test [17:04] ralsina, ok, let me know when its ready [17:06] gatox: there, revno 286 [17:06] ralsina, ok [17:07] alecu, thisfred can you please test IRL lp:~mandel/ubuntu-sso-client/use-qt4-webclient-backend in my system I get auth proxies working with a single creds dialog and not errors (in ubuntuone-control-panel-qt) [17:08] alecu, is based on your branch so is still using the hack to select qt [17:08] lunchtime!!! [17:09] mandel, sure! I'm pulling it now. [17:11] alecu, let me know, if it works, well we are nearly there and I can go and get some stress out with rugby :) [17:12] nessita, joshuahoover this bug aint a bug, WebKit does pick the system settings correctly, but it does always pop for the creds in auth proxies (it stores them nowhere) shall we leave that bug like that and change the description? I see it has a FFe but is really no needed [17:13] nessita, joshuahoover would be more of a bug fix because the proxy is read is just annoying to have to pass the creds all the time.. [17:14] mandel, http://pastebin.ubuntu.com/885088/ [17:14] ralsina, +1 [17:14] "CredentialsError: 1" [17:16] gatox: thanks! [17:16] alecu, that is coming from sso, it has no meaning to me.. what did you do, I'll try to reproduce it. I removed my creds from seahorse and launched ubuntuone-control-panel [17:16] mandel, I removed my creds from seahorse, launched ubuntu-sso-client, launched syncdaemon, and with u1sdtool I told sd to connect. [17:17] mandel, sd asked to get the credentials from sso... boom. [17:17] mandel, I removed *every* credential, including the proxy ones. [17:18] alecu, what could be happening there.. 'cause there should be nearly no diff between you test and mine in regards of the creds [17:20] mandel,alecu: a bunch of proxy tests on sso fail on windows [17:20] mandel, if I try to run control panel, it's the same. [17:20] but it's just a dirty reactor thing, probably nothing serious, can either one take a look at it, say, tomorrow? [17:20] ralsina, let's talk about those on monday. You can skip them now. [17:20] ralsina, I'm not surprise by them failing, I'm surprise they are not skipped [17:20] I can make them skip [17:20] alecu, ^ it whould not be finding squit, right? [17:21] right, there is no squid here [17:21] alecu, I have no idea what CredentialsError: 1 means.. ralsina any idea? [17:21] mandel, control panel runs, but when it wants to get the credentials sso dies and leaves a "grayed out" control panel. [17:21] mandel: means "look at the sunset" by my book [17:21] mandel, alecu: here are the errors https://pastebin.canonical.com/62414/ [17:22] alecu, mandel: where is that error coming from? [17:23] ralsina, alecu and I are not to blame for those failures, those are the IPC tests not cleaning the reactor.. [17:23] ralsina, "CredentialsManagementProxyTestCase" and "SSOLoginProxyTestCase" is IPC, not proxy proper. [17:23] mandel: happy to clean your name and reputation [17:23] alecu, ralsina blame en el buen sentido de la palabra :) [17:24] oi [17:26] * mandel read dobeys oi with a British northern accent. [17:26] mandel: hmm, it won't load the captcha for me, when I enable the proxy [17:27] thisfred, we do have a bug for that I think.. [17:27] thisfred, can you try with your account and file a bug for that.. [17:27] ok, so that's not what I'm testing [17:28] mandel, if I use sso trunk I don't get the CredentialsError: 1 [17:28] mandel, this seems to be happening only on your new branch. [17:28] alecu, ok.. I wonder why it works in my machine.. la puta de oros.. [17:28] mandel: sorry, which bug were you saying wasn't an ffe? [17:29] joshuahoover, bug 884978 is a lie [17:29] Launchpad bug 884978 in Ubuntu Single Sign On Client "pass proxy config to T&C webkit" [High,Triaged] https://launchpad.net/bugs/884978 [17:29] mandel: logging in does also not work. I see a [17:29] mandel: ah, ok [17:29] joshuahoover, webkit does get the proxy settings, it just asks for the creds all the time.. [17:29] brief flash of red, something about Nonetype [17:30] thisfred, Nonetype?!?! which branch are you using? [17:30] thisfred, that sounds like libsoup and not qtnetwork [17:30] mandel: yours. Is this the correct way to run? PYTHONPATH=. ./bin/ubuntu-sso-login-gtk --app_name test --tc_url https://one.ubuntu.com/terms/ [17:31] or do I need the login-qt for this? [17:31] thisfred, oh, a diff branch, sorry I though you were talking about proxy :) [17:31] mandel: huh? [17:32] thisfred, nothing, my context switch was tooooo slow :P [17:32] this is your proxy branch [17:32] alecu, I think this is the right way to do the qt selection: http://pastebin.ubuntu.com/885115/ [17:32] use-qt4-webclient-backend [17:33] mandel, at the point that function is ran the app.instance might not have been created yet. [17:33] mandel, we better make double sure. [17:34] mandel: so I'm lost as to what I'm supposed to do. I have ralsina's proxy configured system wide, what do I do next? [17:34] mandel, "if not 'PyQt4' in sys.modules" means that Qt was already imported, right? [17:34] alecu, means that if PyQt4 in sys.modules it was indeed imported [17:35] alecu: you should also check that the thing in sys.modules is not None, btw [17:35] err [17:35] mandel: you too [17:36] thisfred, ok, then you have to remove your u1 creds and using that branch lauch control panel [17:36] dobey, as in sys.models not None? [17:37] alecu, the thing is, if the developer does import ubuntu_sso.utils.webclient before import PyQt4 we have an issue.. [17:37] alecu, and if we check the other way around we have the same problem.. [17:37] mandel: can't remove credentials in panel: I get AttributeError [17:37] "'NoneType' object has no attribute 'host'" [17:37] so from the we [17:37] b then [17:37] thisfred, remove them from seahorse :) [17:38] ah i [17:38] thisfred, and I've got a feeling that the code you are running is not the one in my branch :) [17:38] thought remove the device [17:38] thisfred, does the same thing AFAIK.. [17:40] mandel: removed. Then what do I invoke to run cp & sso from branches? [17:42] alecu, can you give thisfred the steps you followed to see if he can reproduce the error? [17:42] I have mandel's branch and sso trunk built [17:42] thisfred, what I do is to go to trunk of control panel, set the python path to include the sso branch and the current dir and launch control panel [17:42] kk [17:43] will try [17:43] * briancurtin back [17:43] thisfred, mandel, that's what I do too. [17:43] thisfred, I first start sso, with: U1_DEBUG=True PYTHONPATH=. ./bin/ubuntu-sso-login [17:44] then ucp with: U1_DEBUG=True PYTHONPATH=~/canonical/ubuntu-sso-client/use-qt4-webclient-backend/:~/canonical/ubuntuone-client/pipeline2/:. ./bin/ubuntuone-control-panel-qt [17:46] briancurtin: welcome back! can I get a review? It should be on your backlog [17:47] ralsina: yep, looking now [17:47] ralsina: you'll fix the padding for the weird vertical separator in control-panel in another branch? [17:47] briancurtin: thanks! [17:47] dobey: nessita said she'd do it in one of her branches [17:47] ah ok [17:48] ralsina: what thing exactly? (happy tp do it, but wanted to confirm what :-)) [17:48] nessita: could we get my branch landed then please? [17:48] nessita: padding in the sidewidget's right side [17:48] dobey: reviews are queued up for review time, soon to come :-) [17:48] ralsina: yes, perfect [17:48] dobey: your review is queued up [17:48] ok [17:50] alecu, I get the following: http://pastebin.ubuntu.com/885143/ [17:50] alecu, assumes that the proxy is nonauth until it needs the creds from the keyring and works ok [17:51] mandel, have you tried erasing *every cred* from the keyring? [17:51] ralsina: have some minutes to help me? [17:51] mandel, even the proxy ones. [17:51] nessita: of course [17:51] alecu, doing it right now [17:51] ralsina: I'm getting tons of RuntimeError: underlying C/C++ object has been deleted for objects that I have stored in a dict [17:52] ralsina: so, I have a self.items dict, where I stored paths and treewidgetitems [17:52] ralsina: the treewidgetitems get garbabe collected, and is driving me crazy [17:52] alecu: Oh I need a special version of u1client as well? [17:52] nessita: can I see it? [17:52] ralsina: yes, let me push [17:52] thisfred, probably not... I was just testing that other branch. [17:53] ralsina: lp:~nataliabidart/ubuntuone-control-panel/more-pages, branch, and run: ./setup.py clean build; U1_DEBUG=True PYTHONPATH=. bin/ubuntuone-control-panel-qt [17:53] you will get the overview screen no matter what, just click on the login button [17:54] ralsina: so, clicking sequence should be: open controlpanel, click on any button except close, click on Next (That sometimes segfaults), if no segfault, wait a little bit and boom [17:54] nessita: I am on windows and have no creds right now because sso-client doesn't work. It's going to take me a bit to try it [17:55] nessita: 'cause I will have to install the old release to get logged in. But just a minute [17:55] ralsina: approving the branch. since i'm the last approver, am i the person who sets it from "needs review" to "approved", or is that you? [17:55] briancurtin: please set it [17:56] briancurtin: it's one or the other, depends on mood :-) [17:56] done, approved [17:56] alecu, in the debug from control panel you do not see when it gets them from the user because that is a diff process, the sso one.. [17:57] alecu, I get with no creds anywhere: http://pastebin.ubuntu.com/885153/ [17:57] mandel, right. The one that's dying is sso [17:57] alecu, exactly, let me get you a video :) [17:57] mandel, is that with 64 bits P, all updates? [17:58] mandel, no need for the video. I trust you on that :-) [17:58] alecu, x64 I need to reboot for the updates to complete :P [17:58] blah, i am going to have to refactor the rbox plug-in [17:58] mandel, me too... I'll reboot the P vm where I'm doing these tests. [17:59] alecu, thisfred I'm on my EOD, I'd love to stay, but I have to walk the dog.. [17:59] mandel, no prob. Can you work on the branch to use qt4 first thing tomorrow? [18:00] alecu, of course! [18:00] greatg [18:00] alecu, is the only thing I have in my plate atm [18:00] nessita: can't run it on windows, get other unrelated problem [18:01] nessita: let me check code instead. Any specific places to look? [18:01] alecu, thisfred in any case I have pushed the latests changes to lp.. [18:01] mandel, aaaaaah [18:01] ralsina: yes, ubuntuone/controlpanel/gui/qt/folders.py:464 [18:02] ralsina: in that method, self.items is populated by calling add_folder (the code may look familiar ;-)) [18:02] alecu, tell thisfred he was using and old one and try again.. [18:02] nessita: oh yes [18:03] alecu, the latests code that I had working is 915 of lp:~mandel/ubuntu-sso-client/use-qt4-webclient-backend [18:03] ralsina: but in update_sizes, I'm getting tons of underlying object deleted for: [18:03] File "/home/nessita/canonical/controlpanel/more-pages/ubuntuone/controlpanel/gui/qt/folders.py", line 560, in update_sizes [18:03] state = item.checkState(LOCAL_FOLDER_SUBSCRIPTION_COL) [18:03] RuntimeError: underlying C/C++ object has been deleted [18:03] alecu, which for me works.. [18:03] nessita: ack, let me think a bit [18:04] mandel, with that branch I get a None [18:04] mandel, let me paste it [18:04] alecu, please [18:04] http://pastebin.ubuntu.com/885166/ [18:04] mandel, ^ [18:04] damn, it's using libsoup again. [18:05] nessita: could you comment the folders.clear() calls? I know that will cause duplicates [18:05] doh, I was running trunk this time. [18:05] ralsina: sure, let's try [18:05] alecu, yes, cause I was trying the solution I gave you, can you add a return True [18:05] alecu, which ui are you trying? [18:05] mandel, U1_DEBUG=True PYTHONPATH=. ./bin/ubuntu-sso-login [18:06] ralsina: no changes [18:06] nessita: ok, I will boot into linux to help with this [18:06] ralsina: I'm really worried since process_info is being called twice... [18:06] nessita: should be back in 15 minutes after the mandatory fsck [18:06] ralsina: ack [18:06] nessita: ok, this is usually simple to fix once you find the right place :-) [18:07] ralsina: wait [18:07] ralsina: no ext4? [18:07] thisfred: btrfs [18:07] ralsina: I realized one thing... [18:07] thisfred: not really btr so far [18:07] ralsina: can the wizard call .show on a page more than o=nce? [18:07] at least it's not reiser ;) [18:07] alecu, I just pushed it returning true all the time, can you try [18:07] thisfred: not falling there twice. Reiser's fsck is a killer pummmm tsh! [18:08] nessita: could happen [18:08] ralsina: in which scenarios? [18:08] ralsina: 'cuz load() is called on showEvent, and that's triggering multiple calls to process_info [18:08] which is a pain in the ass [18:09] hmmm [18:09] dunno [18:09] ralsina: ok, let me try a couple of new things with this info [18:09] should not happen, but that's just a theory [18:09] mandel, I've pulled the branch, but still get a CredentialsError: 1 [18:09] ralsina: if needed, I will ask you to restart [18:09] nessita: cool [18:09] mandel, the "1" is the error code returned by the ui [18:09] alecu, I'll take a look tom, chaging the code like crazy is not worth it.. [18:10] alecu, maybe the ui is doing something crazy.. [18:10] ok, EOD, alecu first thing tom I'm with this.. [18:12] ok I'll be there to help test then [18:12] mandel, one last thing... [18:12] mandel, what do you put in your gnome proxy settings? [18:12] mandel, "hostname" or "user:pass@hostname? [18:13] mandel, I've been trying "hostname", but it seems that with the later it gives a different error. [18:13] * thisfred did just hostname [18:14] nessita: quick question, in ubuntu_sso\utils\tests\test_common.py the GetBinDirTestCase doesn't do anything, does it? [18:14] ralsina: it should do a lot (see the inheritance), but let me check that there is no bug [18:14] nessita: it's inheriting the wrong class [18:14] ralsina: indeed [18:15] there is bug [18:15] nessita: ack, will do a branch sinceI have to fix that in windows anyway [18:15] ralsina: should inherit from GetProjectDirTestCase [18:19] yay. So after disabling the proxy, I still had to log out and in again, because SSL connections didn't work [18:24] thisfred, I managed to make mandel's branch run. [18:24] I started on one term this: U1_DEBUG=True PYTHONPATH=. ./bin/ubuntu-sso-login [18:24] nessita: have 2' to help me out? [18:24] and on another: U1_DEBUG=True PYTHONPATH=. python /media/sf_canonical/ubuntu-sso-client/use-qt4-webclient-backend/bin/ubuntu-sso-login-qt --app_name "Ubuntu One" --help_text "Ubuntu One requires an Ubuntu Single Sign On (SSO) account. This process will allow you to create a new account, if you do not yet have one." --ping_url 'https://one.ubuntu.com/oauth/sso-finished-so-get-tokens/{email}?platform_version=3.2.0-17-generic&platform=Linux&client_version=3. [18:24] ralsina: yes [18:24] 1&platform_arch=x86_64' --policy_url 'https://one.ubuntu.com/privacy/' --tc_url 'https://one.ubuntu.com/terms/' --login_only [18:25] nessita: cool [18:25] So, I am trying to make get_bin_dir work on windows [18:25] thisfred, before running both branches I had to delete all proxy credentials from seahorse. [18:25] nessita: and basically, what it has to return is "the same folder where this binary is" [18:25] thisfred, and if I enter every password ok, it works. [18:26] thisfred, if I enter no password, it crashes. [18:26] nessita: but the current implementation is a python module generated by autotools. Which I don't have on windows. [18:26] thisfred, if I enter a wrong password it falls into a loop. [18:26] ralsina: don't lie! :-D [18:26] alecu, ok, but what if people have their proxies already configured? [18:26] ralsina: the current impl is generated by distutils ;-) [18:26] nessita: so, could I add a small widows-specific bit to constants.py.in that does the right thing on windows? [18:26] nessita: sorry, got confused by the syntax ;-) [18:26] or is that a todo issue already? [18:27] ralsina: I would love if we can have the constant.py "generated" properly at installation time [18:27] thisfred, oh, and I was using username@host. Probably other ways can screw this up. [18:27] thisfred, "configured" how? [18:27] thisfred, "user:pass@host"? [18:27] nessita: when setup.py runs on windows, we don't know yet where the binaries will live [18:27] ralsina: any chance we do that? ie, can we have the @prefix@ replaced properly on windows? [18:27] alecu: you say you had to remove the proxy creds from seahorse? [18:27] nessita: the prefix on windows is windows-version specific [18:27] ralsina: right, you mentioned that. but perhaps we can overwrite that when the installer do know [18:28] alecu: we're not gonna ask people to do that ri [18:28] ralsina: in which stage we know the installation path? [18:28] ht? [18:28] nessita: constants.py is not even there when we install [18:28] nessita: we have a constants.pyc inside a zip [18:28] thisfred, right. But only *we* are storing proxy credentials in the keyring, yet. [18:28] ralsina: then what tweak were you planning on adding? [18:28] nessita: if it were a config file, I could generate it though [18:28] ralsina: wanna give me details on that? [18:29] alecu: oh ok. Then where does the network config tool store them? [18:29] nessita: a if sys.platform=("win32") => calculate BIN_DIR and set it when the module is imported [18:29] thisfred, the network config tool has no place to store the creds. [18:29] nessita: wanna mumble? [18:29] ok [18:29] it remembers the password thou [18:29] ralsina: let's mumble, I would try very hard not to leak that in that file [18:29] gh [18:29] thisfred, the solution of using "user:pass@host" is a workaround that we found on some libsoup forums [18:30] right [18:30] thisfred, and we are respecting that for folks that have that already configured. [18:30] sure, we should [18:30] thisfred, but if those creds are wrong, our code *should* ask for the user to enter them again. [18:30] thisfred, (think proxy creds expired) [18:31] thisfred, and when the user enters the new creds we store them in the keyring. [18:31] ok I'm not gonna log out and in ten more times today, I'll test tomorrow when manuel is back [18:31] right [18:34] ralsina, I'm not having too much luck getting another review here: https://code.launchpad.net/~alecu/ubuntuone-client/proxy-tunnel-fix/+merge/97475 [18:35] alecu: I am on windows [18:35] alecu: want me to tell someone to do it? ;-) [18:35] ralsina, yup, I'm deferring to your dictator powers. [18:35] alecu: best case I can do a code review and that's not going to be enough [18:35] gatox: review alecu's branch,please [18:35] alecu: there [18:36] * ralsina puts the remote control back on the desk [18:36] ralsina, ack.... [18:36] gatox: if you can, if you can't no ;-) [18:36] * alecu loves seeing a mind control show in action. [18:36] ralsina, yes.... i'll run the test now.... and review the code in a couple of minutes when i finish with this branch [18:39] gatox: thanks so much [18:39] ralsina, no problem [18:40] alecu: my mom always told me, if you say please and thank you, people do what you say [18:40] that's why I never trust the polite people [18:41] alecu, jeje === yofel_ is now known as yofel [18:54] ralsina: thank you [18:54] dobey: you are welcome [18:54] * ralsina squints at dobey [18:55] heh [19:03] man i really don't want to do this refactoring [19:05] heh [19:05] If only it was fully automatic. [19:05] alecu, +1 [19:08] nessita, ralsina when you can please: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/handle-errors/+merge/97725 [19:09] gatox: adding a new strng requires a freeze exception :-/ [19:09] gatox: can t we reuse an existing string? [19:09] nessita, oops..... [19:09] nessita, let me check [19:09] gatox: can you re use instead GENERIC_BACKEND_ERROR, putting something like: [19:10] GENERIC_BACKEND_ERROR + '({app_name})' [19:10] gatox: or no app_name at all [19:10] nessita, in that case i prefer no app_name [19:10] nessita, ok, i'll change it to use that [19:10] I guess me too [19:10] gatox: thanks [19:14] mannnnn, i got this windows install to work once and now i cant get it back :/ [19:14] briancurtin, been there :P === JackyAlcine_ is now known as jalcine [19:16] nessita, branch updated.... [19:17] ralsina: question... if I set the wizard to have this button layout: [self.Stretch,self.CancelButton, self.NextButton], why it shows the "next" to the left to the 'cancel'? [19:18] nessita: no idea. Shouldn't [19:18] ralsina: ok, will retry [19:18] thanks [19:20] gatox, thanks for the review! [19:21] aale:D [19:21] omg... again with the tab-completion [19:21] alecu, :D [19:24] ralsina: is this correct for setting the focus oin a wizard button? self.button(self.NextButton).setFocus(QtCore.Qt.TabFocusReason) [19:24] is f***ing ignoring me [19:27] nessita: in order to set the ocus that way, the focus have to be in the widget's top-level parent alreadt [19:27] nessita: IIRC [19:27] ralsina: ah, right [19:27] thanks [19:27] nessita: doesn't work from another app [19:28] nessita: "Gives the keyboard input focus to this widget (or its focus proxy) if this widget or one of its parents is the active window." [19:28] gaaaah [19:32] nessita: are you ok? need some mate? medialunas? huevos? [19:32] dobey: mate may help, thanks. But I'm filled with anger towards Qt right now :-) [19:33] will start reviews after making me a tea [19:33] * nessita brbs [19:33] hehe [19:35] interesting diff if you propose a sso branch agains u1cp [19:37] So, urbanape had a good reason to skip team call: https://twitter.com/#!/urbanape/status/180375476651556864/photo/1 [19:38] ralsina, wow...... :S [19:38] gatox, briancurtin: care for a little review? https://code.launchpad.net/~ralsina/ubuntu-sso-client/spawn-evil/+merge/97732 [19:39] ralsina, of course [19:39] ralsina: will look in a min [19:39] briancurtin, gatox: thanks [19:39] nessita: I am very slightly miffed by bug #956304 [19:39] Launchpad bug 956304 in Ubuntu Single Sign On Client "The bin/ubuntu-sso-login-qt is not cross-platform" [High,In progress] https://launchpad.net/bugs/956304 [19:40] (just noticed that myself) [19:40] briancurtin: I'm working on it in a bit myself [19:40] i just started it instead of ubuntu-sso-login.exe on accident and noticed the dbus problem [19:41] briancurtin: and since sso-login needs this to show UI, we are stuck for a bit :-) [19:41] briancurtin: in any case without spawn-evil it would not have found the binaries anyway [19:42] i figured there was something like that. i just added dist/ to the Path to see if that'd change. somehow it worked one time but not after that [19:43] briancurtin: so far no huge bugs, though [19:43] ralsina, i have a couple of test failures..... i'm pasting them in the branch [19:44] gatox: ack [19:44] i still can't get anything to show up other than "getting information, please wait" except for that one time, even if i add dist/ to the path, and even if i manually startup ubuntu-sso-login and syncdaemon [19:44] briancurtin: you still don't have credentials, right? [19:44] nah, i havent been able to enter any. im not able to get anything to load which would allow me to enter any [19:45] is that what this -qt one will allow? [19:45] briancurtin: you can try getting credentials with the old binaries, then you will see u1cp (if you are careful to kill all the old binaries and then start sso-login manually) [19:45] briancurtin: exactly [19:45] ralsina: what does miff mean? [19:46] nessita: annoyed, but just a little bit [19:46] ralsina: you 100% sure? [19:47] nessita: http://dictionary.reference.com/browse/miffed [19:47] ralsina: about the bug report, I mean :-P [19:47] nessita: oh, yes :-) [19:47] ralsina: what part uses dbus? [19:47] nessita: the script in bin/ [19:47] a verrr [19:48] dobey: got this on your ussoc system-font: Text conflict in data/qt/stylesheet.qss [19:48] Text conflict in ubuntu_sso/qt/__init__.py [19:48] 2 conflicts encountered. [19:48] ** Done! [19:49] stop breaking my branches! :) [19:49] ralsina: oh, right, sorry. Good news is easy to fix, move that to qt/main.py and make sure that code is not called from any test [19:49] nessita: yeah, was doing that :-) [19:49] ralsina: sorry :-( [19:49] nessita: thus why I was only a little miffed :-) [19:50] ralsina: I guess I did that with the idea "just for this test" and bu [19:50] nessita: I can instead do a if sys.platorm in the bin/ which is less invasive [19:50] nessita: happens to us all. I probably approved it ;-) [19:51] ralsina: +1 to modify the bin/ [19:51] nessita: ack, so it's a 1-liner [19:51] (though is not the cleaner solution, but let's choose our battles) [19:51] nessita: right [19:51] nessita: the mac guys can clean it later [19:51] :) [19:52] ralsina: can they? :-D [19:52] windows + mac = the janitors around here [19:52] lol [19:52] nessita: if I make that "if sys.platform == win32: skip that" yeah ;-) [19:53] dobey: c'mon!!! FAILED (skips=2, failures=1, successes=856) [19:53] stop wasting my review-cpu-cycles! [19:53] :-P [19:54] dobey: will re-review tomorrow morning [19:58] gatox: can you do a linux test run of lp:~ralsina/ubuntu-sso-client/cross-platform please? just tests and lint to see if it works [19:58] ralsina, yep [19:59] gatox: thanks. Sorry I am throwing so much stuf at you, but ... windows [19:59] ralsina, jeje i understand, and it's not a problem! [20:01] ralsina, just this: [20:01] bin/ubuntu-sso-login-qt: [20:01] 1: [C0103] Invalid name "ubuntu-sso-login-qt" (should match (([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$) [20:01] gatox: fuuuuu ok! [20:02] gatox: I just removed the global approved on ugly-reset, I just noticed is adding a string [20:02] gatox: + WizardPage [20:02] nessita, eh?? [20:03] * gatox looking... [20:03] gatox: spawn-evil fixed [20:03] gatox: you should check that in the generated ui files there is nothing like this: [20:03] def retranslateUi(self, ResetPasswordPage): [20:03] ResetPasswordPage.setWindowTitle(QtGui.QApplication.translate("ResetPasswordPage", "WizardPage", None, QtGui.QApplication.UnicodeUTF8)) [20:04] gatox: in every generated ui file, we should have: [20:04] def retranslateUi(self, ForgottenPasswordPage): [20:04] pass [20:04] nessita, ok..... i'll remove that [20:05] gatox: since you're modifying the file, please run on the ResetPasswordPage Layout -> Adjust size [20:06] so size decreases to [20:06] 505 [20:06] 260 [20:06] nessita, ok [20:06] done [20:06] i'll update the branch now [20:06] gatox: no rush, will re-review tomorrow [20:06] nessita, ack [20:08] nessita, just to let you know.... the branch is updated and the _ui.py has def retranslateUi(self, ResetPasswordPage): pass [20:08] gatox: thanks! [20:10] nessita, gatox: trivial branch that is blocking briancurtin and I - https://code.launchpad.net/~ralsina/ubuntu-sso-client/cross-platform/+merge/97746 [20:10] ralsina, on it [20:10] nessita, gatox tells me there is lint there but I can't see how to fix it :-/ [20:11] ralsina: can you make it to be if sys.platform == 'win32': ? [20:11] I understand mac will use dbus [20:11] nessita: no it won't [20:11] and if it does, they ca fix it ;-) [20:11] last I heard mac IPC was going to be PBover tcp (briancurtin?) [20:11] ralsina: the lint is fixeable just like the -gtk is fixed [20:12] as of now that's correct [20:12] uh wait [20:12] ralsina: the fix is import sys after the lint disable [20:12] briancurtin, ralsina: ack [20:12] ralsina: can you fix the lint first then? (just move the import below the disable) [20:13] gatox: lint issue at https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/qt-login-backend/+merge/97425 [20:13] nessita, ahhhh........of course [20:14] :-) [20:15] sure [20:17] ralsina, +1 [20:17] just the lint thing [20:18] ralsina: question, on "tweaks" in controlpanel, you modified the data/external_icon_orange.png and data/external_icon_white.png, may I ask what changed? [20:19] ralsina: also, test failure there, will add to the MP [20:20] ralsina: but loved the branch though :-) [20:22] nessita: since those are now background images, I had to add the padding inside the image [20:22] nessita: cool that you liked it :-) [20:22] nessita: and de-linted cross-platform [20:22] ralsina: ack [20:26] https://code.launchpad.net/~dobey/rhythmbox-ubuntuone/fix-disable/+merge/97747 if anyone could please [20:27] thisfred: ^^ if you want [20:27] since i know rhythmbox is your favorite player and all [20:27] dobey: can do a code review if it's good enough for you [20:27] sure, waiting on bzr bisect [20:27] thisfred: can you bisect a diverging branch? :-) [20:28] ok, I finished giving a pass to every branch I had queued up for review, will give another one tomorrow morning [20:28] I have to leave for a while, will be back online from another location in 30 minutes or so [20:28] ralsina, only if no one is around to hear you do it? [20:28] brb! [20:28] nessita: if I can ask for an exception for cross-platform, it's blocking windows :-) [20:29] ralsina: is approved, like I mentioned ;-) [20:29] also globally approved already [20:29] ralsina: it's fine by me. i tested the code IRL before committing it anyway :) [20:29] oh, it's approved, cool [20:29] nessita: sorry, missed it! [20:29] :-) [20:29] brb! [20:30] ralsina: not sure what you mean. First time using bisect, but it seemed an easy way to see where a somewhat predictable segfault got introduced [20:30] thisfred: yes, it was just a geometric joke [20:30] dobey: no tests? :P [20:31] aha [20:31] thisfred: yes, but you have to run them inside rhythmbox :) [20:31] things that diverge describe an angle, which can then be bisected. Yet diverging branches on bzr cannot be merged, so you can't bisect from one to the other [20:31] * ralsina is so subtle [20:31] dobey: not worth it [20:31] * thisfred ru [20:31] bberstamps [20:32] dobey: +1 [20:32] dobey: also you get a gold star for no misspellings [20:32] yay, i'm not mandel! [20:32] and a bonnet for the oldfashioned use of thy [20:32] people EOD for me! see you tomorrow [20:33] ralsina: keep it. i didn't write the API [20:33] bye gatox! [20:33] thou are not deserving then [20:33] ralsina, i'll have a indicator-surprise for you on sunday-monday :P [20:33] art [20:33] gatox: cool [20:33] thisfred: indeed god sir [20:33] good [20:33] heh [20:34] ralsina: no, "god sir" was correct there :) [20:34] dobey: 'proval [20:35] dobey: ha [20:35] in Icelandic maybe [20:35] windows, I hate thee [20:36] because ctrl+r (rename terminal tab) requires confirmation but ctrl+w (close tab) doesn't [20:36] bisect run is counterintuitive [20:36] bisect is kickass and awesome. Used it a lot on svn, even when I had to do it manually [20:36] but it's going in the right direction ow [20:36] now [20:37] test_activate ... "sni-qt/17309" WARN 16:36:55.972 void StatusNotifierItemFactory::connectToSnw() Invalid interface to SNW_SERVICE [20:37] No systemtrayicon available [20:37] nice [20:37] ah? sni-qt? [20:37] dobey: what on the name of shiva are you trying to do? [20:37] that got printed while running the cp qt tests [20:38] dobey: whoa [20:38] i think the qt tests are loading the windows tray icon code perhaps? [20:38] dobey: that code is cross platform [20:38] dobey: is that in tarmac? [20:38] i don't think sni-qt is installed in tarmac [20:39] that was on my machine [20:39] dobey: which is what surprised me ;-) [20:39] dobey: you could just unistall sni-qt [20:39] right [20:39] dobey: or maybe skip some tests when onn linux [20:39] might as well uninstall mumble too :) [20:39] dobey: hehe [20:40] not that i use the mumble tray icon [20:40] though i would prefer to not use mumble. it's a pretty broken interface [20:41] yes mumble's ui is nuts [20:41] "I know, let's not offer a way to find a person OR channel" [20:42] also, i just fixed one of the most useless tests ever [20:42] thisfred, dobey: care to do a review of https://code.launchpad.net/~ralsina/ubuntuone-control-panel/tweaks/+merge/97244 [20:42] and then I can sleep in peace today? [20:42] maybe [20:42] sure [20:43] has lots of "pretty" pictures [20:43] though it has to wait for nessita to re-review it [20:44] dobey: yeah, but I rather have one +1 in [20:44] i'll give you one for moral support ;) [20:45] ralsina: so ubuntu-sso-login-qt.exe now operates if i start it. didn't affect anything in terms of the whole system actually functioning when is start control panel, though [20:45] briancurtin: ok, let's try this [20:45] briancurtin: first, make sure you have no creds [20:45] ralsina: +1, made me miss reviewing C code [20:45] briancurtin: then start ubuntu-sso-login [20:46] briancurtin: then, start control panel [20:46] briancurtin: you should get a lgin screen [20:46] briancurtin: if you don't we still have a bug somewhere [20:46] thisfred: hahaha [20:46] ralsina: ok, and where can i be sure to remove any possibly pre-existing creds? i havent had to deal with cred stuff yet, not sure where it is [20:47] * ralsina loans thisfred to mobile saying "loves reviweig CSS changes" [20:47] briancurtin: windows 7 or XP? [20:47] XP [20:47] briancurtin: it's in the registry somewhere [20:47] i'll search around [20:47] briancurtin: but if you never logged in, you don't have any [20:47] i logged in before with the previous installer so it's probably in there [20:48] ralsina: I'll put that in my objectives for next cycle, to make sure it doesn't actually happen ;) [20:48] briancurtin: you could logout using the old control panel too [20:49] ah, found it. stored in a "Software\Ubuntu One\Keyring" key [20:50] briancurtin: almost makes sense too :-) [20:51] still just sitting at "getting information, please wait..." [20:51] no information in logs [20:51] briancurtin: hmmmm [20:51] briancurtin: can you put your binaries somewhere? [20:52] you want just the dist/ folder or the whole installer? [20:52] briancurtin: make sure you don't have the old ubuntu-sso-login running, it causes weird problems [20:52] just dist [20:52] briancurtin: also, are they console apps? [20:54] ralsina: they're listed under windows part of setup.py but i have this installer built with the conf.py setting SHOW_CMD == True in order to make them console apps for the time being [20:54] briancurtin: cool [20:55] i'll put the dist/ up somewhere, 1 min [20:57] ralsina: briancurtin.com/dist.zip [20:57] briancurtin: thanks! [20:58] that includes sources being pulled just a few minutes ago [21:00] thisfred, ralsina: https://code.launchpad.net/~dobey/ubuntuone-client/apport-newonly/+merge/97750 [21:01] briancurtin: I am getting an exception on SSO when I start u1cp [21:01] briancurtin: and also, an exception when I try to start syncdaemon [21:01] where are these showing up? [21:01] i have nothing, everything just sits there and no log files tell me anything [21:01] briancurtin: I started ubuntu-sso-login in one terminal [21:02] briancurtin: and there I have this [21:02] briancurtin: https://pastebin.canonical.com/62426/ [21:02] briancurtin: on another, trying to start syncdaemon I get this: https://pastebin.canonical.com/62427/ [21:03] dobey: +1 [21:03] ive never seen either of those [21:03] briancurtin: and apparently my evil-spawn branch was not good enough 2012-03-15 18:02:53,279:279.000043869 - ubuntu_sso.utils - DEBUG - _get_dir: trying use dir at 'C:\\Users\\ROBERTO\\canonical\\t\\dist\\dist\\library.zip\\bin' (exists? False) [21:03] which is like, a totally stupid result [21:04] briancurtin: dunno what to say [21:04] briancurtin: they are *your* binaries :-) [21:04] for me, sso-login just starts up and sits there. then i open up control panel and the GUI comes up and does the waiting thing for a very long time, then eventually times out [21:04] briancurtin: set U1_DEBUG=True first [21:07] ralsina: here's what i see in both terminals while the GUI does the waiting thing: https://pastebin.canonical.com/62428/ [21:07] briancurtin: are you sure you don't have any leftover processes? u1cp specifically? [21:09] i've been uninstalling + deleting the entire C:\Program Files\ubuntuone folder each time i try new stuff. also killing app ubuntu* processes before starting anything out [21:09] also just restarted the VM much of the time between trying things [21:09] briancurtin: I don't know then [21:09] briancurtin: let's try something simpler [21:09] briancurtin: start ubuntu-sso-client [21:10] briancurtin: then in another terminal try u1sdtool -s [21:10] briancurtin: I get exceptions.TypeError: remote_register_to_signals() takes exactly 3 arguments (2 given) on sso [21:10] shoot, bisect's not gonna be easy: we have revisions of trunk with failing tests. Now I have to distinguish between those and segfaults. [21:10] briancurtin: remember to set U1_DEBUG=True before starting sso, please [21:11] just to be sure, you mean ubuntu-sso-login.exe (said ubuntu-sso-client, wanted to be sure im not missing something) [21:11] briancurtin: yes, sorry [21:12] thisfred: instead of a bisect do a test run for all revisions (your history is not too big) then grep the logs? [21:14] ralsina: that's time consuming though: a single test run is between 15 and 50 seconds, and I have to do at least 20 or so per revision because the segfault is not 100% reliable [21:14] thisfred: yikes [21:14] thisfred: do it at night? ;-) [21:14] ralsina: u1sdtool -s doesn't output anything (U1_DEBUG=True) [21:14] briancurtin: ugh [21:14] briancurtin: I really have to EOD :-( [21:15] so it's worth changing the script so it can distinguish test failures from segfaults I think [21:15] if that's possi [21:15] ralsina: i'll keep poking around on it and try to get up earlier tomorrow to put more time in [21:15] ble [21:15] briancurtin: how about ubuntuone-syncdaemon --debug? [21:15] they both exit with 1 [21:15] I think [21:17] ralsina: starting up syncdaemon works fine, outputs a bunch of stuff, adds a watch for brian\Ubuntu One [21:18] briancurtin: weirder and weirder [21:18] briancurtin: you don't have any ubuntu one installed, right? === JackyAlcine is now known as jalcine [21:19] dobey: it will be for IS managed bots only; you mentioned tarmac - if that isn't IS managed, you will need it to be so [21:19] ralsina: right now i'm running off an installer that i built which was from the dist/ that i sent you [21:19] so we should be running the same things, just that you got it from my zip and i got it from an executable installer [21:19] briancurtin: mmmmkey, so maybe you have some stuff I don't, like syncdaemon config files [21:19] briancurtin: what time is it over there? [21:19] 16:20 [21:20] ok, here is 18:20, so if you start 1 hur early and I one hur late we can pair all day [21:20] that ok with you? [21:20] hmm, bzr switch results in max recursion depth exceeded [21:20] briancurtin: this all must be some very minor stuff [21:20] ralsina: yeah that's fine. i usually get started at 08:00, so start at 07? [21:20] No, 8 is ok [21:21] i'm open to whatever time, though [21:21] so I will just start 1 hour later :-) [21:21] ok, 08 it is [21:21] yay! ;-) [21:21] put your installer somewhere so we start from the same things [21:21] and with that I EOD [21:21] sounds good, i'll upload it now [21:23] alecu: ping [21:24] alecu: I'm seeing more and more reports for "ubuntu-sso-login crashed with SIGSEGV in QSocketNotifier::setEnabled()"... would you know what can be remotly causing this? [21:24] bah; i am used to non-DST now, so having it still be bright outside right now is confusing [21:25] nessita, remotely causing a segfault? a bug in qt for sure. [21:25] ralsina: http://briancurtin.com/work/ubuntuone-2.0.3-windows-installer.exe [21:26] ralsina: so the rb-scope branch needs some stuff to be finished up, and david is working on it; so the plan is for it to be in precise, it seems [21:26] ralsina: not sure if i should do anything else with that [21:26] dobey: I will talk to david and offer help [21:27] ok [21:27] alecu: "remotly" in the sense of "se te ocurre qué corcho", not as in "remote" :-D [21:27] davidcalle: if you need a hand with the rhythmbox scope, please ping me! [21:27] dobey: there ;-) [21:27] nessita, oh, ah. [21:27] heh [21:28] nessita: no useful trace? [21:28] nessita, and... we are not using QSocketNotifier directly [21:28] nessita, probably the QNetworkAccessManager is using inside qt. [21:29] alecu: yes, that's not a "public" class [21:29] ok gotta go walk the dog. later all! [21:29] ralsina, alecu: bug #940669 and bug #943046 [21:29] Launchpad bug 940669 in ubuntu-sso-client (Ubuntu) "ubuntu-sso-login crashed with SIGSEGV in QSocketNotifier::setEnabled()" [High,Confirmed] https://launchpad.net/bugs/940669 [21:29] Launchpad bug 943046 in ubuntu-sso-client (Ubuntu) "ubuntu-sso-login crashed with SIGSEGV in QSocketNotifier::setEnabled()" [High,Confirmed] https://launchpad.net/bugs/943046 [21:30] nessita: looking [21:31] dobey: did you resolve conflicts in lp:~dobey/ubuntu-sso-client/system-font? [21:31] nessita: not yet [21:31] ralsina, I'm looking at it with mhr3. The branch we are working on is https://code.launchpad.net/~scopes-hackers/unity-lens-music/rb-scope [21:31] ack [21:31] davidcalle: cool [21:31] davidcalle: just volunteering if you can use some help [21:32] ralsina, but thanks, I will ping you if mhr3 gives me a task that would take me much more time than needed for an experimented Vala dev. [21:32] davidcalle: ok! [21:32] nessita: ok, no freaking idea [21:33] ralsina, nessita: both qt and glib show up on one of the stacktraces of that bug: https://launchpadlibrarian.net/94184698/Stacktrace.txt [21:33] and on the other as well. [21:33] alecu: that segfault means that a reference to that QSockeNotifier was lost [21:34] because it's dereferencing a null [21:34] alecu: it's normal to have glib in qt apps using the gtk theme (really, see QEventDispatcherGlib::processEvents(QFlags)) [21:35] ok. [21:35] alecu, nessita: if we had the sso / syncdaemon/ whatever logs, maybe we could see where i the python code it's crashing [21:35] right [21:38] briancurtin: good news, when I do the same things you do, I get the same results ;-) [21:39] at least we're on the same page! [21:40] briancurtin: yeah [21:41] I love Ubuntu One, but at work I use RHEL5 most of the time. Is there any reasonable way to access my Ubuntu One account from RHEL5 except for the web interface? [21:43] ralsina: fwiw, i pushed the changes to the bitrock config if you need to replicate the same build from the start: https://code.launchpad.net/~brian.curtin/ubuntuone-windows-installer/release-updates [21:43] briancurtin: awesome [21:43] briancurtin: I will try to put a couple of hours late tonight see if something pops up [21:44] So EOD for realz [21:44] briancurtin: we will kick its ass in the morning, don't worry [21:44] ralsina: i have a few plans this evening so i can't stick around in the evening, but i'll try to get up early tomorrow to get a jump on it before we start [21:45] briancurtin: I will mail you if I see something [21:45] ok cool, have a good evening [21:45] bye people! [21:45] osse: someone was working on converting our .deb packages to .rpms to install on fedora, but i don't know if they'll work on rhel5; that's a fairly old version [21:46] osse: if you have the necessary dependencies installed though, you should be able to install enough bits to use file sync at least [21:47] dobey, don't I know it; it's really old. Gnome 2.16 I believe. Python 2.4 provided, but I've installed 2.7.2 by hand. [21:48] osse: you can't upgrade the OS? [21:48] dobey, I'm not afraid to get dirty. I'm satisfied if I can get to the point where I can mv/cp files to and from some local directory, perhaps invoking the actual syncing by hand. [21:50] dobey, no I can't. I'm an embedded software developer. We use that system for a reason (though I can't figure out why really. the embedded system itself runs something else when you get down to it). [21:50] I just realized Ubuntu One has a Windows client. I have Windows easily accessible at work, so I can probably use that. [21:51] probably better than trying to get it running on rhel 5 anyway :) [21:52] would probably be doable, but you will have to install a *LOT* of dependencies to get there [21:54] well i gotta go do non-work stuff now. later all :) [21:55] dobey, have a good one [23:27] ralsina, what was your proxy's ip, again?