[09:15] morning all!" [09:15] hi everybody, how do i install an "ubuntu one" client? [09:15] in debian [09:29] Happy Monday, all! [09:34] paranoidphreak, on debian.. well there are lots of dependencies that you have to double check that we have not added patches etc.. [09:34] paranoidphreak, I have never tried to run it on debian to be honest.. it is going to be a 'little' adventure [09:38] mandel: ok...........so, the short answer is it needs alot of experimenting? [09:38] paranoidphreak, yes, and I know that rye (who is not here know) is the kind of guy that likes to do that [09:39] paranoidphreak, it should be possible since I know we have people using it on Fedora :) [09:39] mandel: thanks......... [09:39] paranoidphreak, sorry I cannot be more helpful, but got be coding at full speed to get to the bext ubuntu beta 2 with proxy support, sorry [09:40] mandel: i'll probably do some googling [09:41] mandel: goodluck on your coding [09:42] paranoidphreak, thx! [09:52] good morning! [09:53] mandel, morning! [09:53] ralsina_, morning to you too, sir! [09:53] alecu, ralsina_ estais los dos locos! [09:53] good morning alecu, mandel [09:54] mandel, it's only 7 am here ;-) [09:54] ralsina_, you've got mail with the answers that you needed about windows + a review request for a simple branch [09:54] mandel, and we only got 8 more hours to land stuff today [09:54] mandel: yes, trying it now [09:55] alecu, I'm trying to get the update of the proxy of network access manager working unless you have something else for me [09:55] alecu, I'm reading the c++ implementation to see if we can do something.. [09:56] mandel, I've got one big thing we should do today: disabling ssl [09:56] mandel, and a few more smaller ones. [09:57] alecu, that one is very easy.. specially since the support for libsoupd was not landed, shall I disable it, remove it or add a param to the webclient to state that you will no allow ssl errors? [09:58] mandel, "disable it" sounds right. We might need to use that support much later. [09:58] alecu, ok, simple work, but then.. what do we do with the ssl support branches that have not landed? there are a few [09:59] mandel: QCoreApplication.instance() is not None if you have a QApplication, so no need to test both (line 21 of your branch's diff) [09:59] ralsina_, cool, I did not know that, will fix a in a min [10:00] mandel: also, typo in line 38 "cres"=> "creds" [10:00] ralsina_, can you put both in a comment? [10:00] mandel: sure! [10:00] Oh, great, launchpad is down [10:02] and bzr server is down. Come on! [10:04] mandel, "not yet landed": we don't worry about landing them today, we land them during the week, or next week even. [10:04] alecu, ok [10:05] mandel, I'm talking about ssl support branches, right? :-) [10:05] alecu, yes :) [10:06] ralsina_, is it april 1st already? [10:06] alecu: not yet! [10:06] ralsina_, I mean, because of LP being down... it sounded like a really annoying joke [10:07] alecu: it's back up, so it was probably an update [10:08] great [10:09] Good morning #ubuntuone! [10:09] ralsina_, it seems more than a few things are broken: "apt-get update" is unable to reach http://archive.ubuntu.com/ [10:10] hey there, karni! [10:10] alecu: fun! [10:10] hola alecu ! [10:10] mandel: when IRLing your brach https://pastebin.canonical.com/62534/ [10:11] mandel: but then again, that build has sommay things layered it is a club sandwich [10:11] ralsina_, hm.. let me do IRL on windows, one sec I'm trying to get my head around the proxy cache.. [10:11] mandel: ok, thanks, but check my email, doing a IRL on windows means merging like 6 branches [10:18] Ok, I am off to dress kid, send him to be educated, and have breakfast. Should be back in ... 72 minutes, give or take [10:21] crap! archive.ubuntu.com works fine. It's my P vm that's working awfully. [10:23] mandel, because of what ralsina_ says (merging 6 branches to do IRL), I would say that we should not worry about windows today, and instead focus on fixing the issue on linux. [10:24] alecu, that is what I'm doing atm [10:25] mandel, do you want me to take a look at that too? sounds like a big issue [10:25] alecu, let me try on more hack and I will, I want to try a number of different ideas I have been gathering over the weekend [10:26] mandel, do you have a .txt list of those? or let's mumble after your hack. [10:26] alecu, mumble after the hack if you don't mind [10:31] alecu, mumble? [10:33] mandel, coming [10:39] alecu, you sound like a rapper.. [10:39] alecu, a bad one, muy entrecortador [10:51] mandel, https://code.launchpad.net/~alecu/ubuntuone-client/proxy-tunnel-auth/+merge/97763 [11:12] good morning! [11:13] alecu, PYTHONPATH=. ./bin/ubuntu-sso-login-gtk --tc_url http://www.google.com --app_name test [11:13] gatox, morning! [11:14] mandel, hi! o/ [11:14] alecu, use a real tc_url if you want :) [11:23] * mandel coffee [11:38] * mandel back [12:04] * mandel rebooting due to updates [12:06] alecu, did they t&c test work? [12:25] good morning gatox! [12:25] ralsina_, hi! [12:25] ralsina_, how are you? [12:25] gatox: full of energy and high spirits [12:25] gatox: it feels like speed + vodka [12:25] ralsina_, jeje nice way to start the week! [12:26] gatox: did you see my first message about windows? It seems I get disabled login buttons on windows [12:26] ralsina_, yes..... i read it..... do you want me to take a look at that?? i'm kind of block with a tests right now anyway [12:27] gatox: if you are blocked, yes please [12:27] ralsina_, yap!.... on it then! [12:27] gatox: remember that right now the only way to get that far is to usemy doing-windows branch and build exes [12:27] ralsina_, woww....... no way to test it from sourceS? [12:27] gatox: or maybe you can just run the scripts for the sso ui and the same thing happens, I have not tested that [12:28] * ralsina_ checks [12:29] gatox: yes, same thing happens from source [12:29] ralsina_, ok great..... i'll test it from sources [12:40] hello everyone! [12:40] nessita, hi [12:40] I'm sorry I'm late, I set the alarm clock to the wrong time :-/ [12:44] hello nessita! [12:44] hola ralsina_! === ralsina_ is now known as ralsina [12:47] lunch time for me [12:49] alecu, nessita, gatox who needs reviews? [12:49] ralsina, not me [12:49] ralsina: me not yet... I guess we need to define what to do with cloud-to-computer [12:49] nessita: I think just use the real Folders panel [12:49] ralsina: your last comment is confusing me a bit, perhaps you meant "if the user has 'non subcribed' folders? [12:49] nessita: not the remote-only version [12:49] nessita: no, "no suscribed folders" [12:50] nessita: the idea is, this only needs to happen for new users [12:50] nessita: so, a user that already suscribed a UDF is not new [12:50] nessita: but leaving that aside, just switching to the full folders list is enough for this release, I think [12:50] ralsina: well, my understanding is that we need to show the wizard every time the user adds the device [12:51] nessita: ok, then we switch to the full folders list, and ask for UX input on that. Sounds good? [12:51] nessita: it's just that having the folder you just clicked on "disappear" is scary [12:52] ralsina: I'm still not sure we're talking about the same... I would like first to understand what you meant and then go to design with something unified :-) [12:52] nessita: sure, quick mumble? [12:53] ralsina: oh, I'm too sleepy, I just jumped from the bed (PICNIC while setting the alarm clok - the "pm" is too small :-/) [12:53] nessita: ok, when you had a few mates :-) [12:53] ralsina: so, may I ask you a few questions about what confuses me? [12:53] nessita: sure [12:54] ralsina: so, why do youy say the wizard is supposed to be shown only for "new" users? on windows is shown every time there is no credentials (which can be after an existing user removed his device). I matched that behavior in linux [12:55] nessita: agreed. Actually, it was supposed to check for things like whether you had a ~/Ubuntu One but we never got around to that [12:55] nessita: so, you are right, there [12:56] ralsina: ok, no thaqt sleepy then :-P. So, given that, I'm +1 to show the current folders list (*without* the explore button) [12:56] nessita: right [12:56] great, thanks [12:56] cool then, with that, you have a +1 fromme [12:56] will make that chnage asap so while that lands, I review for you [12:56] that also makes a bug from thisfred on friday invalid [12:57] tss [12:57] the one about having "header" items with nothing under them [12:57] gatox: holas! question, are you working on the translations for u1cp? [12:58] ralsina: so we will always show all the folders? I think that's much [12:58] better [12:58] thisfred: yep [12:58] cool [12:58] my bug's still valid, this will just fix it :P [12:59] nessita, no, that issue was actually the same as sso.... the first screen is just sso stuff.... i'm working in the windows problem that ralsina mention in his branch [12:59] thisfred: although it will still "flicker" a bit when you check/uncheck one, which I need to fix someday [12:59] yeah, but that's minor [12:59] thisfred: yeah [12:59] ralsina: what I know is missing but will do in another branch for the release after this, as bug fix, is to skip the page if there are no volumes to show, since actually I want to use this to wait for syncdaemon's volumes list: https://code.launchpad.net/~brian.curtin/ubuntuone-client/851810-notify-on-volumes [12:59] thisfred: we have much bigger fish to fry :-) [12:59] gatox: so you 100% sure there are no missing translations on controlpanel? :-) [12:59] nessita: +1 on that, that will help the UX a lot [13:00] Whale fry! [13:00] ralsina: yes, but need brian to actually fix the things I asked there ;-) [13:00] thisfred: with veggies (I am on a diet :-) [13:00] nessita: after this release ;-) [13:00] nessita: I need brian al for me today ;-) [13:00] ack [13:01] ralsina: steamed whale for you then [13:01] thisfred: you know, whale is technically a fish for lent-related purposes [13:01] nessita, well.... if you put it like this.... i think that is a trap jeeje..... but at least for this screenshot: https://launchpadlibrarian.net/96191627/ubuntuone-controlpanel-qt.png you can see that all the non-translated things are from sso.... i didn't check the other files.... i could do that if you want [13:01] ralsina: clever catholics [13:02] thisfred: panda, the other vegetable [13:02] ha! [13:02] nessita, also..... i'm really stuck with the tests for main for the unicode branch..... it keeps giving me a seg fault (the asserts are ok.... but it through a seg fault) [13:03] gatox: what branch? I can give you a hand there [13:03] let's all try to help each other instead of tupac-amaru-izing nessita today :-) [13:03] ralsina, let me push the changes [13:05] gatox: pinging ralsina for that specific thing is the best decision ever :-D [13:05] gatox: and yes please to check the other files [13:06] nessita, ok..... as soon as i finish with the windows thing, i'll check those files [13:06] unicode is my brêäd and bùttër [13:06] gatox: ack [13:07] ralsina, this branch..... after the reviews, i talk to nessita and we agree to decode all the args: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/unicode-args/+merge/97936 [13:07] gatox: ack [13:07] ralsina, so i decode everything in the main before sending that data to the ui.... but i having problems to test that [13:08] gatox: so you have a segfaulting test? [13:08] yep [13:08] test_main [13:08] gatox: ack, will get back to you as soon as I figure something out [13:08] ralsina, PYTHONPATH=. u1trial --gui --reactor=qt4 ubuntu_sso/qt/tests/test_main.py [13:09] gatox: I am again roberto, the one that has windows abierto. But I will try it! :-) [13:09] ralsina, ahhhhhhhh jeje [13:10] ralsina, if you want, paste the changes and i can try it here [13:10] gatox: ack [13:10] gatox: no segfault here! [13:10] gatox: so, YOU FIXED IT! ;-) [13:10] ralsina, cuack..... the test execute and say pass? [13:10] gatox: yep [13:11] then u1trial gets stuck [13:11] gatox: https://pastebin.canonical.com/62540/ [13:12] ralsina, i see this: http://paste.ubuntu.com/890580/ [13:12] gatox: one f my branches fixes this test! [13:12] gatox: let me find it [13:13] gatox: https://code.launchpad.net/~ralsina/ubuntu-sso-client/ubuntu-font-in-windows/+merge/98010 [13:14] gatox: merge manually the test fixes [13:14] ralsina, are you going to add more stuff to that branch..... because i could review it so it can be merged in trunk..... [13:15] already has 1 approval [13:15] gatox: no, that branch is good to go [13:15] ralsina, ok..... reviewing... [13:21] ralsina, nessita: any of you knows when are nightlies rebuilt? [13:21] alecu: after each tarmac build [13:21] alecu: not me [13:21] alecu: after each tarmac land I meant :-) [13:21] alecu: so, checking https://code.launchpad.net/~ubuntuone-hackers/+recipe/client-dailies I can tell builds are failing for client [13:22] alecu: click on any of the build failed and check the error [13:22] nessita, what does it means "Successful build" but stop signs? [13:22] alecu: error on tests.proxy.test_tunnel_server.MainFunctionTestCase.test_on_proxies_enabled_prints_port_and_cookie [13:23] alecu: where do you see that? [13:23] alecu: ah, I understand your question [13:23] nessita, in the page you just pasted... [13:23] let me explain [13:23] ok [13:24] alecu: we have a single "source" package, and from that we built several binary packages. The outer success means the *source* apckage built ok, but the "stop sign" means that both binary packages failed [13:24] ok, great. [13:24] nessita, so: from dbus.mainloop.qt import DBusQtMainLoop [13:24] exceptions.ImportError: No module named qt [13:25] alecu: seems like python-qt4-dbus is a missing dep? [13:25] nessita, right [13:25] alecu: is that code not in the default install of SD (need to check that) [13:25] nessita, I added that to use the keyring from the tunnel [13:25] ralsina, +1 to this one: https://code.launchpad.net/~ralsina/ubuntu-sso-client/ubuntu-font-in-windows/+merge/98010 [13:25] alecu: where was that code added? [13:25] gatox: awesome! [13:26] nessita, rev 1211 [13:26] alecu: which file, I mean :-) [13:26] nessita, and that's why 1210 is the last package available on nightlies! [13:26] nessita, ubuntuone/proxy/tunnel_server.py [13:27] nessita, so, it would be a dependency for the proxy tunnel binary [13:27] alecu: did someone already built the separated binary proxy package? [13:28] nessita, very good question. [13:28] nessita, I can't answer it! [13:28] nessita, let's ask ralsina. [13:29] alecu: if you give me the complete list of dependencies for that python package, I can make the binary package build [13:29] ? [13:30] * ralsina has clue -4 about packaging [13:30] ralsina, that's +1 than what I have. [13:31] alecu: having played munchkin with you, you have a "takes all packages from the enemy" card. [13:31] alecu: just check on the nightlies packaging branch and there is no binary for proxy [13:31] alecu: so, I can add it but need the full dependency list... could you give me that? (alphabetically ordered please) [13:32] nessita: should that be something other than "ubuntuone-client" and "python-dbus-qt4" ? [13:33] ralsina: yes, every module that the python package depend on. From the top of my head, python-twisted-core is needed [13:33] nessita, I think the dependencies would be: python-qt4, python-qt4-dbus, ubuntuone-client [13:33] alecu: what about all the twisted deps? [13:33] do not assume you get twisted from u1client [13:33] nessita: we don't need to support installing it withut u1-client [13:33] nessita, they would be pulled by ubuntuone-client [13:34] nessita, why not twisted from u1client? [13:34] ralsina: u1-client definitely will be a dep [13:34] alecu: because that's how packages deps are listed [13:34] nessita, how do I find the list of packages that u1client depends on? [13:34] alecu: preferred and recommended and appreciated way is not to assume deps from another package you depend on [13:35] makes sense [13:35] alecu: I would prefer that you grep over imports in proxy package and build the list from there, since u1client list may be incomplete [13:35] packaging is not easy :-) [13:35] huh [13:36] hola dobey [13:36] hi [13:36] morning, folks [13:46] morning urbanape! [13:46] heya [13:46] nessita, http://pastebin.ubuntu.com/890617/ [13:47] alecu: thanks! no python-twisted-web? (did not check the code) [13:47] nessita, only to run the tests [13:47] alecu: perfect, thanks, will let you know [13:47] nessita, but not in the modules that should go in the package. [13:47] ack [13:47] nessita, great. Let me know if I can help with any other thing. [13:47] alecu: sure [13:48] nessita, one thing: we are importing some modules that may have some other dependency. [13:48] alecu: such as? [13:48] nessita, say: from ubuntu_sso.keyring import Keyring [13:48] nessita, and that module in turn *may* use python-dbus. [13:49] alecu: ah, that's ok: the dep in *our* proxy code is python-ubuntu-sso-client [13:49] perfect. [13:49] is "hidden" for us the deps that python-ubuntu-sso-client requires [13:49] I guessed so, but wanted to check anyway :-) [13:49] thanks :-) [13:49] gatox: my sso branch is now merged, so your segfault should have gone away (please check!) [13:50] ralsina, ok, thanks..... i'm looking at the problem that you have in windows.... is the same that was happening in some linux... and this is really weird... the good part...... we can now reproduce the bug [13:50] so i'm looking at that [13:51] dobey: any reason not to have python-twisted-core as a u1client build-depends? [13:51] (is not listed ATM) [13:53] nessita: i guess it's not there because we're pulling it in via ubuntuone-dev-tools [13:53] dobey: ok, adding it then to be explicit [13:53] briancurtin: ping [13:53] urbanape: what's up [13:54] hey a, can I steal some of your time this afternoon? [13:54] hi briancurtin! [13:54] urbanape: depends on how far i get with this windows release. currently working through some of ralsina's weekened branches [13:54] kk [13:54] hey ralsina [13:55] briancurtin: please check them out, they are full of sunday goodness [13:55] as in, I did two while eating a diet sundae and everything [13:55] haha [13:56] dobey: so, once we have the python-ubuntuone-client-proxy bin package, shall python-ubuntuone-client suggests it? [13:57] why is it python-ubuntuone-client-proxy? [13:57] dobey: how would you like to name it? [13:57] it should be ubuntuone-client-proxy i think [13:57] as it includes the tunnel script [13:57] dobey: why? (interested in the convention and rationale) [13:58] and it's not a "python library" really [13:58] ok, makes sense, changing [13:58] dobey: so, ubuntuone-client should suggests it then? [13:59] yes, only Suggests: at most. it can't Recommends or Depends it [13:59] right [14:01] nessita and everyone else: sorry abut pep and lint issues in my branches, but it's hard to get that done right on windows :-( [14:01] ralsina: yes, I know, is ok [14:02] alecu: so, what should the -proxy package ship? the binary ubuntuone-proxy-tunnel, and the python package under ubuntuone/proxy/... anything else? [14:03] alecu: is there any other needed file, man page, dbus service file, icon, desktop file, etc? (just doing a checklist) [14:03] nessita, I think we don't need any other file. [14:03] alecu: great, thanks [14:04] nessita, we don't have a manpage, and anyway it's an internal binary, not supposed to be called by users. [14:04] yes [14:04] nessita, and no dbus service file, icon nor desktop file. [14:04] perfect [14:10] launchpad's working nicely today. only on my 7th try to "setup.py fetch" and get sources [14:10] briancurtin: ugh [14:11] briancurtin: I had a bit more luck earlier. But it's mostly bzr for windows that sucks :-/ [14:11] briancurtin: you getting permission denied errors? [14:12] ralsina: bzr error 3, whatever that means [14:12] even opening branches to view in the browser is hit-or-miss this morning [14:12] briancurtin: ok, never saw that one. It was actually down this morning, too [14:12] ah [14:13] ralsina: https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/cloud-to-computer-page/+merge/97990 updated and irl tested [14:14] nessita: yuju! Will review right away! [14:15] dobey: can you please review this diff? http://pastebin.ubuntu.com/890669/ [14:15] (for u1client packaging branch) [14:15] nessita: just noticed there is no way to test that on windows, though, so just code review from me [14:15] ralsina: you could run it IRL, I think... [14:16] nessita: no, because on windows you can't login right now [14:16] dobey: still pending to write the changelog though :-) [14:16] ralsina: is that on every windows or just yours? (curious) [14:16] mandel, ping [14:17] nessita: all windows, reported it on sunday, diego is working on it [14:17] ralsina: interesting :-/. [14:17] nessita: the sso ui ever enables the login button [14:17] s/ever/never/ [14:17] ralsina: yeah, read the email... and also saw some reports on linux as well [14:17] nessita: so, if the issue is the same, hey, windows helps us fix it :-) [14:18] yes [14:18] nessita: gatox has reproduced it on windows [14:18] nice [14:18] will make some mate to see if I can finish waking me up :-d [14:18] ugh [14:18] * nessita slaps herself [14:18] ralsina, nessita yes.... there is a problem with the credentials and the backend is returning none.... i'm looking at the logs right now [14:18] cd .. [14:18] oops [14:18] i really don't like having to list each python package individually [14:19] nessita, ralsina i'll let you know as soon as i have something [14:19] nessita: also, the paths are wrong [14:19] dobey: any suggestion how to list everything but "proxy"? [14:19] nessita: it would be ubuntuone-client/ubuntuone/foo [14:19] nessita: no. i don't think dpkg has an "everything but the things that are in other binary packages" thing [14:19] dobey: you're right, will change. Any solution to not to list everything? [14:19] ok [14:20] dobey: the breaks-replaces is fine, no? [14:22] nessita: should be. i'd probably do it as << ${binary:Version} or source:Version (whichever one works there) [14:23] dobey: any reason for that? last time we fixed something like this you suggested using the exact version, to avoid breaking/replacing in "the future" [14:24] alecu, pong [14:24] alecu, sorry took me longer to have lunch, had to deal with the family, is father day here.. [14:24] * mandel hates family things.. [14:25] nessita: because it's nightlies and sticking the +r43432 in there feels weird [14:25] mandel, roberto reported two small issues in this branch: https://code.launchpad.net/~mandel/ubuntu-sso-client/use-qt4-webclient-backend/+merge/97934 [14:25] dobey: ok then, as you wish. Will change [14:25] alecu, yes, I know fixing in a few minx [14:25] alecu, mins* [14:25] ok [14:25] nessita: for proper stable packages, i'd use specific versions, but for nightlies, i'd generally prefer a minimum of that, in favor of automation [14:26] dobey: duly noted [14:26] changed to (<< ${binary:Version}) [14:26] cool [14:27] nessita: we use zope.interface in u1client? [14:27] dobey: yes, on trunk/ubuntuone/syncdaemon/interfaces.py [14:28] dobey: and in the tests now [14:33] alecu: I answered your needsinfo in https://code.launchpad.net/~ralsina/ubuntuone-client/find_exes/+merge/98107 as "you are right" ;-) [14:34] ralsina, ok, I'll re-review. [14:34] alecu, I think that setting QNetworkRequest::AuthenticationReuseAttribute to QNetworkRequest::Manual might do the trick [14:35] mandel, awesome [14:36] nessita: ay reason to create are_you_sure.ui instead of using QMessageBox.question()? [14:38] mandel, that means that each webcall would be done once, the proxy will return a 407, and then it will be retried with the credentials. [14:38] alecu, in theory.. I'm writing some tests to make sure it does what the can says.. [14:39] mandel, but it sounds like a reasonable compromise until the credentials cached by NAM are truly erased on failure. [14:39] ralsina: you tell me, you added that in the installer :-) (just copied it) [14:39] nessita: really? Whoa, was I in a dumb day! :-) [14:39] nessita: ok, I'll file a bug for it and give this one a +1 [14:39] ralsina: I think you needed to customize the button texts... [14:39] alecu, it is just good enough, specially when we can catch them and then tell the requests after the first successful one to use it in automatic mode [14:40] ralsina: and I m not sure you can do that with a yes no dialog? [14:40] nessita: could be. Whatever, it works ;-) [14:40] alecu, since this in an attribute at the request level and not the network access manager [14:40] mandel, I think we should not care about re-setting it to automatic. [14:42] nessita, ralsina yes.... it was because of the buttons-text [14:43] gatox: thanks! [14:43] alecu, that could in an optimzation done later for sure [14:45] briancurtin: fllowed your suggestion on find-exes, please rereview [14:46] ralsina: if you're looking for them, I believe they all live in Texas. [14:46] At least, that's how the song goes. [14:46] urbanape: ? [14:46] “All my exes live in Texas” [14:47] urbanape: groovesharking it :-) [14:48] urbanape: omfg is that a crappy song (sorry country fans :-) [14:48] hahah [14:48] I wonder how his san antonio ex is called. Antonio? [14:48] that's why I lay may hat in Tennessee [14:49] * alecu heard that song a lot while playing San Andreas. [14:51] mandel, I'm not finding an easy way to enable socks [14:51] alecu, in webclient? [14:51] mandel, I'll start with the SSL-disable branch if you think it's fine. [14:51] mandel, in webclient, yes. [14:51] alecu, if you have nothing on your plate, sure [14:52] mandel, also, it seems that this test in webclient would not work right: test_https_request [14:52] mandel, since self.assertFailure needs to be yielded [14:53] or failUnlessFailre, as it's called in the test. [14:54] mandel, also, the indenting of that method suggests that a yield was there at some point [14:54] alecu, really.. I cannot recall, but I'm sure it was not [14:54]