StevenK$ grep BugsInformationTypeMigrator garbo-hourly.log-20120320 | grep -c Blocked00:04
StevenKwgrant: ^00:04
wgrantStevenK: Well, the problem here is clear.00:16
wgrantThe PRF has gone insane. Get it killed.00:17
=== cjwatson_ is now known as cjwatson
wgrantwallyworld: So, using StormRangeFactory will generate a query something like https://pastebin.canonical.com/62588/01:23
wgrantwallyworld: Note the slight oddness in that you have to include the sort key in the SELECT list, due to the DISTINCT.01:24
wallyworldwgrant: ok, seems simple enough. how do i tell the batching infrastructure to use it?01:25
wgrantwallyworld: There's only a couple of places that use it so far, but see eg. ArchiveSubscribersView01:26
wgrant        self.batchnav = BatchNavigator(01:26
wgrant            self.subscriptions, self.request,01:26
wgrant            range_factory=StormRangeFactory(self.subscriptions))01:26
wallyworldok, thanks01:26
wgrantThat is up to 30% faster than the original query.01:29
wgrantThen you just need https://pastebin.canonical.com/62590/, which takes <1ms for 100 people.01:30
wgrantChromium is of the opinion that my launchpad.dev wildcard cert has been revoked.02:15
wgrantDespite it not having a CRL or OCSP endpoint specified.02:15
wgrantAnyone feel like reviewing https://code.launchpad.net/~wgrant/launchpad/involvement-config-validity/+merge/98328?03:44
StevenKwgrant: r=me03:47
StevenKwgrant: In my branch to change IBug.{private,security_related} to make use of information_type most of the TestBugMirrorAccessTriggers fail with AttributeError: 'NoneType' object has no attribute 'concrete_artifact'03:48
wgrantStevenK: You'll need to change the triggers to use information_type instead of private and security_related03:49
wgrantStevenK: There's a card in Next for that.03:49
wgrantI was going to do it once production's column was populated.03:49
StevenKBut is sort of seperate to this work to move IBug definition03:50
wgrantIt means that setting .private and .security_related still has to set the DB flags.03:51
StevenKwgrant: I'm tempted to re-write the garbo jobs __call__ to be faster and not call bug._setInformationType() in a loop03:51
wgrantSee how it goes overnight.03:52
wgrantKilling PRF before you sleep if necessary.03:52
StevenKwgrant: What about the VACUUMs that keep turning up?03:53
wgrantThey shouldn't be too terrible most of the time.03:54
lifelessStevenK: what about it ?03:58
StevenKlifeless: They seem to keep blocking garbo jobs04:01
StevenKJust look at the trail of fail in garbo-hourly.log04:01
lifelessautovacuum is more a symptom not a cause04:02
lifelessit canm be blocked by other writes04:02
lifelesseven if it shows up, its almost certainly not the reason for lag04:02
wgrantLag is not relevant here.04:03
wgrantLong transactions.04:04
lifelessvacuum is only long when its blocked on another xaction04:04
wgrantStevenK: /win 604:54
wgrantStevenK: How are you structuring your branches?04:55
StevenKwgrant: I'm only working on one at the moment, and it's only 200 lines.04:56
wgrantStevenK: Hm04:56
StevenKwgrant: What are you thinking?04:56
wgrantStevenK: But you appear to have a branch which stops writing to Bug.private and Bug.security_related04:56
wgrantWhich can't be in the same branch.04:56
StevenKNot any more.04:56
wgrantGood good.04:57
StevenKIBug.private is now IBug._private and stuff is looking good.04:57
StevenKJust running test -vvm bugs to see if there is anything heinous before I put up an MP.04:59
wgrantThis branch still keeps the flags and information_type in sync, just from the opposite direction?04:59
StevenKsetPrivacyAndSecurityRelated is utterly horrid05:00
StevenKSo the less I touch it, the better.05:00
StevenKI'm thinking we want to replace it with IBug.transitionInformationType() like the methods on IBugTask.05:01
wgrant1) Get things keeping information_type in sync with private and security_related (done)05:03
wgrant2) Populate information_type (nearly done)05:03
wgrant3) Treat information_type as canonical, mirroring to private and security_related05:03
wgrant4) Get that deployed everywhere (including ftpmaster)05:03
wgrant5) Replace the triggers (I'm just testing that now)05:03
wgrant6) Stop touching private and security_related in any way05:04
wgrant7) Drop private and security_related05:04
StevenK8) Kill IBug.set{Private,SecurityRelated,PrivacyAndSecurityRelated}, replacing it with IBug.transistionToInformationType()05:05
wgrantThat's part of 605:05
StevenKI did wonder05:05
StevenKRight, I do like that plan.05:05
StevenKWe have cards for part 6 and 7?05:06
wgrantNot yet.05:07
StevenKShall I create two in Backlog, sans bugs for now?05:07
wgrantAlso, I missed a step05:08
wgrant2.5) ALTER TABLE Bug ALTER COLUMN information_type SET NOT NULL;05:08
* StevenK stabs Kanban05:08
StevenKAh yes05:08
StevenKLet me create a card for that and stuff into next05:08
StevenKWe'll need to fix the model/interface code seperately, but that's a trivial patch.05:09
wgrantAre you fixing test_bug_mirror_access_triggers to not set private/security_related directly?05:09
StevenKAlready done05:09
wgrants/need/potentially and non-critically want/05:09
wgrantStevenK: Can you push? My trigger branch needs that.05:09
StevenKwgrant: What I mean is sprinkle things like notNull=True to information_type in the model05:09
wgrantStevenK: I'm aware. We probably want to do that at some point, but it's not in the critical path.05:10
wgrantNor important at all.05:10
StevenKI'd prefer to do it just after the DB patch is deployed, but meh05:10
StevenKThe following 1 account(s) were found. Select the account you wish to access.05:11
StevenK<list of two things>05:11
* StevenK stabs Kanban harder05:11
wgrantI only had one.05:11
StevenKwgrant: Sorry, got distracted by Kanban. lp:~stevenk/launchpad/bugs-use-information_type05:16
wgrantThankyou sir.05:18
wgrantStevenK: We should complete (and test as a whole) parts 3-7 before we land any of them.05:25
wgrantIn case we've missed something05:25
wgrant5 is done, asounds like you're close to 3 and 6, and 7 is pretty trivial :)05:25
StevenK3 yes, 6 no.05:26
wgrantStevenK: Isn't 6 mostly a matter of deleting code?05:32
wgrantOr does 3 not change the queries that use it?05:32
StevenK3 does not. I'm trying to keep it simple.05:33
wgrantAh, sure.05:33
StevenK3 falls back to _private and _security_related if information_type is not set, so it's not dependant on the garbo job being complete.05:33
StevenKHmmmm. That could not be helping.05:35
StevenKwgrant: What should I set information_type to if IProduct.private_bugs -- I want to say PROPRIETARY.06:02
wgrantStevenK: USERDATA06:03
wgrantPROPRIETARY doesn't exist yet.06:03
wgrantIt's defined, but it doesn't exist.06:03
StevenKwgrant: Are you still reviewing since you're OCR and everything.06:56
=== almaisan-away is now known as al-maisan
=== al-maisan is now known as almaisan-away
stub LINE 3: ...                     WHERE bt.bug=bug.id ORDER BY bt.name LI...07:51
stubCould have sworn we fixed that one already (BugTask.name does not exist...)07:51
stubScoping rules seem subtly different in 9.1 if you use the same tag to alias more than one table in a nested query07:56
adeuringgood morning08:54
jelmer_moin adeuring, czajkowski09:09
=== jelmer_ is now known as jelmer
=== almaisan-away is now known as al-maisan
dpmhi jtv, are you around?09:44
jtvHi dpm!  Trying to have a conference call atm, but can get back to you in half an hour or so if that's okay.09:45
dpmjtv, sure! if you've got 5 minutes for me later on, that'd be perfect09:46
=== gmb changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: gmb | Firefighting: - | Critical bugtasks: 4*10
=== jml` is now known as jml
=== mpt_ is now known as mpt
deryckMorning, everyone.11:44
=== al-maisan is now known as almaisan-away
deryckabentley, adeuring, rick_h -- I'm coming.  joining hangouts is slooooowww here for some reason.13:32
rick_hderyck: all the beach air interfering with your bandwidth :P13:33
adeuringabentley: can't hear you13:51
abentleyadeuring: My mic shows levels.  Let's both rejoin.13:51
adeuringabentley: let's use muble. Google claims that have to install an new plugin...13:53
=== almaisan-away is now known as al-maisan
abentleyadeuring: I think job.fail needs transaction.abort before it.  Here's how it fails without it: http://pastebin.ubuntu.com/892304/15:16
adeuringabentley: ouc, of course, yes15:16
abentleyadeuring: Maybe we should go back to having commit/abort methods on the runner?  I know it's not pretty.15:17
adeuringabentley: I think we should first try to fix the bugs we have currnently. I really don't like to have DB commit into lazr.jobrunner...15:19
abentleyadeuring: Or maybe the runner could accept a transaction manager.15:19
abentleyas a parameter.15:19
adeuringabentley: well, that's bascially teh same ;)15:19
abentleyadeuring: This is a bug that we have currently.15:20
abentleyadeuring: I was getting this, so I had to disable oops handling to get the real error.15:20
adeuringabentley: does this mean that the OOPS handling is also broken?15:21
abentleyadeuring: The oops handling was broken because job.fail was not aborting the transaction, so when it tried to invoke methods on job, it got InternalError: current transaction is aborted, commands ignored until end of transaction block15:22
adeuringabentley: ah, ok.15:23
abentleyadeuring: I've worked around all of this by doing "import transaction; transaction.abort()" immediately before job.fail, but this is not a long-term solution.15:24
adeuringabentley: the branch I'm working on should fix the problem: it changes the methods fail(), queue(), suspend() etc15:25
abentleyadeuring: Great.15:26
=== al-maisan is now known as almaisan-away
=== matsubara is now known as matsubara-lunch
deryckabentley, rick_h -- Just FYI for the YUI history curious, our phantom history events is a bug fixed in YUI
rick_hderyck: awesome15:59
abentleyderyck: Ah, great.15:59
deryckabentley, rick_h -- http://pastebin.ubuntu.com/892344/ shows the issue.  simple initialState bug.15:59
deryckabentley, rick_h -- I vote for waiting on upgrade to fix it. :)15:59
rick_hderyck: yea, guess so16:00
deryckonly other option is to fork our 3.3.0 and patch the history module.16:01
rick_hright, messy16:01
deryckthen we have a diff against 3.3.0, have to maintain our own build, etc. when the issue is annoying but relatively minor.16:01
=== salgado is now known as salgado-lunch
=== matsubara-lunch is now known as matsubara
sinzuideryck, rick_h what is stopping us from using 3.4.1?16:57
derycksinzui, upgrade time && too many js irons in the fire.16:57
rick_hsinzui: hopefully the combo loader will make it much easier to swap out versions, run all our tests, and find out what issues pop up16:58
sinzui:( this is why we stopped updating zope for 3 years16:58
sinzuirick_h, well if the calendar dies, we have incentive to use 3.4.1 with a hack to make the popup work in firefox16:59
rick_hsinzui: that and 3.5 is due next month so the hope is more to jump to 3.516:59
sinzuiThat would make me happy16:59
deryckI don't think it's far off actually.  Just not NOW()! :)16:59
rick_hsinzui: yea, so the plan isn't to not upgrade, but try tomake one big jump with combo loader + 3.5 in sucession17:00
deryckthat's the chief driver of the combo loader, to make upgrades much easier.17:00
rick_hyea, it's all kind of tied together with combo loader, 3.5, handlbars/pybars. Lots of parts moving that hopefully we can snap together17:01
deryckand that's also what gives me hope that an upgrade is not just vapor, but something that will happen.17:02
=== salgado-lunch is now known as salgado
rick_htumbleweed: ping17:34
sinzuijcsackett, do you have a few minutes to talk about the auditor editing case in the the mockups18:42
jcsackettsinzui: sure.18:59
jcsackettsinzui: can you start the hangout? i do not have a functioning webcam, so will have to use my phone.18:59
sinzuijcsackett, starting now19:01
sinzuijcsackett, does you phone see a hangout with me in the messenger?19:03
tumbleweedrick_h: pong19:13
rick_htumbleweed: wanted to see if you could help me out with the test data so I can get the test working for that MP19:14
rick_hI posted back on the MP what I got going, and need to see if the test data in wadllib is out of date19:14
tumbleweedrick_h: I can't see pastebin.canonical.com19:16
rick_htumbleweed: k, sec19:16
rick_hbasically checking the date formats given the test json data in wadllib works out, so curious if the json out of that bug is different and needs updating19:17
tumbleweedthanks for actually doing a test. I was just testing it from launchpadlib, against lp19:19
lifelessflacoste: hey19:20
rick_htumbleweed: ok, I wasn't sure what the test is hitting and wondered if you could shoot me a json file to check against19:20
flacostehi lifeless!19:20
flacosteyes, it would be a good time to talk!19:20
rick_htumbleweed: end of the day, the change seems good, but I'd like to get a good test to make sure we don't break things again19:20
tumbleweedrick_h: IIRC the problem was that namespace_url (line 483 of application.py) was None19:20
lifelesscool, @ 30 past? Would like to nab a snack first19:21
* lifeless is astonished that pg 8.4 handles bugtag.name without blowing up19:22
rick_htumbleweed: ugh, ok, so deeper issue than it seemed19:22
rick_htumbleweed: ok, the source for that test stuff is open right? if so I guess I'll just pull that down and trace through to be able to duplicate something19:23
tumbleweedrick_h: you should be able to test it by checking isinstance(lp.distributions['ubuntu'].date_created, datetime.datetime)19:24
rick_htumbleweed: right, but I need to get that into a unit tests with a json api response and an existing known wadl file. but yea, I'll pull that down and try to get it going19:26
rick_htumbleweed: thank19:26
tumbleweedof course :)19:26
rick_hit helps to know that's what the bug was hiting, couldn't tell that input the test file in the pastebin from the bug was using as input19:26
lifelessflacoste: okies19:32
* flacoste starts hang out19:33
lifelessgary_poster: do you have a little time today, once I'm finished with flacoste, to talk paralleltest ?19:35
gary_posterlifeless, I have my call with Francis in 24 min, and am trying to get a machine ready for analysis right now.  I know it would be good to talk.  We also have our scheduled call tomorrow though19:36
gary_posterIOW, not easily, now19:42
lifelessgary_poster: no worries; perhaps we can talk a little tomorrow 1:120:06
gary_posterok cool20:06
gary_posterlifeless I'll ping if I have time before EoD today in case you are around/available20:06
lifelesscool, thanks20:10
gary_posterlifeless, if we can make it fast we could talk now20:55
gary_posterlifeless, https://talkgadget.google.com/hangouts/extras/canonical.com/goldenhordeoneonone ?20:55
kirklandgetting some weird LP oopses ... anyone around to take a look?20:57
lifelesskirkland: gotta link the OOPS man :P20:58
lifelessgary_poster: sure, trying to get in20:58
lifelessthis multi account stuff really is a nuisannce20:58
kirklandlifeless: copying over from #launchpad (where I did) ...20:58
kirklandSorry, something went wrong with your search. (Error ID: OOPS-3611440967e645c2a3d8c68345be9b24)20:58
gary_posterlifeless, I tried inviting your @gmail.com20:59
kirklandI'm also getting a "not found" on a bug that I've been looking at/working on all day20:59
lifelessthat used to work20:59
lifelessseems to not now20:59
lifelessgary_poster: sending you an invite instead20:59
gary_poster:-) cool21:00
lifelesskirkland: thats a 404; it is oopsing because you have a local referrer21:00
kirklandlifeless: what does that mean, sorry for being dense?21:14
kirklandlifeless: I've been working on this private bug all day long https://bugs.launchpad.net/ztrustee/+bug/95965021:14
kirklandlifeless: and it's now disappeared for all I can tell21:14
mwhudsoni guess you no longer have permission to see it21:18
mwhudsonfor whatever reason21:18
lifelesskirkland: you may have been unsubscribed from it21:28
lifelesskirkland: hmm21:29
lifelessztrustee may have been renamed :)21:29
kirklandlifeless: interesting;  I'm on the team that owns the project21:30
lifelesskirkland: can you see the project?21:30
kirklandlifeless: I can see ztrustee (which is right);  ztrustree is 40421:30
lifelesshah, yes ok21:31
lifelessso there are two possibilities21:31
kirklandInclude the error ID OOPS-e72a16ca0af50bf4338dddc14d2ba243 in your message.21:31
lifelesswe've nerfed something in private projects21:31
kirklandlifeless: any info there?21:31
lifelessor you / your team have been unsubscribed from that bug, leading to no access21:31
kirklandlifeless: how odd, okay, thanks21:32
kirklandlifeless: we can recreate the bug, that's no problem21:32
lifelessits failing in   File "/srv/launchpad.net/production/launchpad-rev-14969/lib/lp/bugs/security.py", line 127, in checkAuthenticated21:32
lifeless    return self.obj.userCanView(user.person)21:32
lifelesswhich is a cannot-access situation21:32
kirklandlifeless: this is the first time something like this has happened, though, so I thought I'd mention it in case it's systemic21:33
lifelesskirkland: I'm 99% certain someone in your team unsubscribed the team from the bug21:33
kirklandlifeless: okay, we'll go with that21:33
kirklandlifeless: I'll re-raise if it happens unexpectedly again21:33
lifelesswhat they need to do if they don't want notifications is to use the *mute* feature21:33
lifelessuntil the disclosure project is rolled out21:33
lifelessthe disclosure project is decoupling access controll and notification21:33
kirklandlifeless: k21:33
lifelesswhich will avoid this rather spectacular foot gun21:33
kirklandlifeless: btw, can you tell me who to thank for the recent "Affiliations" feature, when searching for a person or team?21:34
kirklandlifeless: cool21:34
lifelesspurple panthers21:34
lifelessthe same folk working on disclosure21:34
lifelesse.g. sinzui & co21:34
kirklandlifeless: lovely21:37
kirklandsinzui: thanks!!!21:38
sinzuikirkland, I will pass that on to the squad. they did the testing and work to make it appear in real time21:42
kirklandsinzui: it's *awesome*21:42
kirklandsinzui: and exactly what I was looking for in Bug #930364, which was marked wont-fix21:43
_mup_Bug #930364: show badges when searching/selecting a launchpad user <disclosure> <person-picker> <Launchpad itself:Won't Fix> < https://launchpad.net/bugs/930364 >21:43
kirklandsinzui: I think you noted that in Comment 7, which is good enough for me!21:44
sinzuikirkland, we have started the UI for showing who has access to private data: https://qastaging.launchpad.net/ecryptfs/+sharing is a draft of a what we will announce in a few weeks21:47
* sinzui cannot see that page so cannot answer question about who has access and how, but the views to do that will be in place next week21:47
sinzuiStevenK, http://blog.launchpad.net/general/reimagining-the-nature-of-privacy-in-launchpad-part-122:30

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!