alecumandel, I think that with your fix we could remove the references to WebClient.proxy_instance00:01
mandelalecu, I honestly do not have the balls to make that change at 1 am when it works :P00:02
mandelalecu, sounds like an improvement we can do later hehe00:02
alecuI thought you were much braver :-)00:02
mandelalecu, you mean a lot more stupid, which I am, but I fail under peer pressure :P00:03
alecugood point :-)00:03
mandelalecu, if we get this on beta 2 we will have enough user to be sure it works, later we need to remove that instance thing and test it on windows etc..00:04
alecumandel, approved!00:06
mandelalecu, toma!00:06
alecuralsina, ping!00:06
mandelalecu, lol: 'and code looks as good as if I had written half of it.'00:10
mandelalecu, there are a number of files around in the project that can match that, like windows file events00:10
ralsinaalecu: pong00:11
mandelralsina, review review review: https://code.launchpad.net/~mandel/ubuntu-sso-client/fix-alecus-mess/+merge/9830800:12
ralsinamandel: hehe, ok, on it00:12
ralsinaBTW: sorry I disappeared, but had 2 doctor's appointments and could not get wifi in between00:13
mandelralsina, I added the QApplication 'cause I saw it using libsoup.. just in case :)00:13
ralsinamandel: haha00:13
ralsinamandel: NEEDSFIXING!00:13
ralsinamandel: nah00:13
mandelralsina, no me undas!!!00:13
ralsinamandel: line 27, str(domain)?00:14
ralsinaif domain comes from the cli, it could be unicode (but then the user is evil)00:14
ralsinaSo, alecu, mandel, what did I miss?00:15
mandelralsina, hm.. good point, but yes, he is evil setting a proxy with unicode00:16
ralsinamandel: and it's going to be *really* obvious in the logs00:17
mandelralsina, I was not paying much attention to irc to be hones, I was a little blocked trying to get that working with a factory.. this area of qt is buggy, and the bug is 3 years old O_o00:17
ralsinamandel: ok, things happen00:18
mandelralsina, I'm off to bed, catch you tom :)00:18
ralsinamandel, alecu: did you guys find any clues about creds-qt on windows?00:18
mandelralsina, will this land in the beta 2?00:19
mandelralsina, I can take a look at that early in the morning tom :)00:19
alecubye mandel00:19
alecuralsina, no: no clues00:19
ralsinaalecu: ok00:20
ralsinahahaha must be annoying to google a problem and get a page in your manager's blog, and he's not even around00:20
ralsinamandel: we are probably going to do a release on windows that doesn't match exactly with ubuntu's00:21
ralsinabecause we don't have time to merge the windows fixes before the ubuntu release00:21
ralsinamandel: if you can take a look, and have nothing else, I would really really appreciate it00:22
mandelralsina, ok, I'll take a look to see what is going on, can you send me an email with how I have to merge the branches for windows?00:22
ralsinamandel: already did it yesterday ;-)00:25
ralsinamandel: will resent just for you00:25
mandelralsina, hmm if you sent it I have it.. I was updating my email client and there are some filter rules missing..00:26
ralsinamandel: I will resend just in case00:26
mandelralsina, we get a ridicoulus about of mail per day..00:26
ralsinamandel: yes we do, I get 3 times what you get, too ;-)00:27
ralsinamandel: resent00:27
mandelralsina, which is stupid.. important ones get lost in the noise..00:27
mandelralsina, I'll take a look at that bug tom morning as well as getting jenkins set up to scream at us when we brake windows00:28
mandelralsina, but with no emails, irc or twitter or something funny :P00:28
ralsinamandel: cool, thanks00:28
mandelralsina, like a chuck norris fact when you brake one of the platforms hehe00:28
alecumandel, that already exists!00:29
ralsinaI think I am going to be sane and just do one more review then rest00:29
ralsinainstead of the original plan of banging my head against windows for 3-4 hours00:30
mandelralsina, lol00:30
ralsinamandel, alecu: if this means proxy is done, great job, guys00:33
* ralsina sees he wrote "done" and laughs histerically00:33
ralsinalet's say "shipped" ;-)00:33
mandelralsina, there are some corners to make smoother, and the credits goes to alecu00:33
mandelralsina, while I'll take the money :P00:34
ralsinamandel: go to sleep!00:34
* alecu should stop reading this article and get some food and sleep too.00:34
mandelralsina, alecu I think I lost it: http://www.youtube.com/watch?v=bLr4pCg4PNk00:39
mandellol, I'm going to bed :P00:39
ralsinamandel: yes please ;-)00:40
mandelalecu, we should get a tecno viking plug in, is scarier that chuck :P00:48
mandelok, of to bed :)00:48
mandelsee you all tom!00:48
ralsinabye mandel!00:49
ralsinaannnnnnnd I am gone too, will be working early tomorrow.00:57
alecubye too!01:03
=== JanC_ is now known as JanC
mandelmorning all!09:21
JamesTaitGood morning all! :D09:32
karniGood morning! :)09:47
=== jml` is now known as jml
=== mpt_ is now known as mpt
gatoxgood morning!11:14
mandelgatox, morning!11:16
gatoxmandel, hi! how are you?11:17
mandelgatox, did you watch the season finale then? (Walking dead)11:17
gatoxmandel, yes... i said EOD and run to watch the episode! :P11:17
mandelgatox, tired.. ended up working 'til late yesterday and now sorting out the windows code to make sure proxy works there :)11:17
mandelgatox, it is no an ending.. I cannot wait for season 3!11:18
gatoxmandel, me too........11:18
gatoxmandel, yes, i saw your twit about the review last night11:18
mandelgatox, hehe11:19
mandelgatox, have you watch the show in english?11:20
gatoxmandel, yes, of course, i download it in english and 720 :D11:20
mandelgatox, then be ready for the wtf: https://www.youtube.com/watch?v=ZblD1BNudAk11:21
mandelgatox, I cannot believe his is from... I'll let you watch it :P11:21
gatoxmandel, let me see11:22
nessitabuenos días!11:36
gatoxnessita, buenas11:37
nessitahola gatox11:37
mandelnessita, buenos dias!11:37
nessitahola mandel!11:37
nessitaralsina: when you can, could you please fix the conflict in https://code.launchpad.net/~ralsina/ubuntuone-control-panel/tweaks/+merge/97244 ?11:56
thisfrednessita: did you see my comment re: string formattun12:41
thisfredformatting, even12:41
nessitathisfred: I did, I was not aware that .format is much slower12:41
nessitathisfred: have a link I can read? :-)12:41
ralsinagood morning!12:42
thisfrednessita: it was a thread recently on python-dev, let me look12:42
ralsinanessita: of course!12:42
nessitaralsina: thanks12:42
ralsinathisfred: *how* slow are we talking here? ;-)12:42
thisfrednessita: the more imortant point was it ties us to a recent python, thou12:43
thisfredralsina: in practice I'm sure it won't matter12:43
ralsinathisfred: and how "recent" is that?12:43
ralsinathisfred: I guessed so12:43
thisfredralsina: 2 weeks or so?12:43
ralsinathisfred: no, I meant how recent a python :-)12:43
thisfredah, I think it may be 2.712:44
ralsinamandel, urbanape: how nice would it be to have this? http://blog.rburchell.com/2012/03/qt-51-aka-when-qfilesystemwatcher-might.html12:44
nessitathisfred: yes, I also read that, but I'm not concerned about that... it ties us to 2.6, right?12:44
thisfredralsina: also since the old formatting is never going away, and already used everywhere12:44
ralsinathisfred: yeah. But the new formatting is much less error prone12:45
gatoxralsina, really nice! the actual qfilesystemwatcher of qt sucks right now12:45
ralsinathisfred: although since we d have the plan to go back in time up t maverick (hopefully) we should not do stuff that's not available in maverick's python12:45
ralsinagatox: yes it does12:45
thisfredralsina: also we make it harder than necessary to port to legacy distros ;12:46
nessitaralsina, thisfred .format is available since 2.6 ;-)12:47
nessitaand lucid has 2.6, so no worries on that front12:47
nessitaralsina, thisfred: http://docs.python.org/library/stdtypes.html#str.format12:47
ralsinayes 2.6 is good enough12:47
thisfrednessita: yep 2.6, so not so big a pro12:47
mandelralsina, looking12:48
thisfredwith legacy distros I was referring to red hat which I think is still stuck on 2.512:48
thisfrednot enough of an incentive maybe12:48
ralsinathisfred: let me dig deep in my sould to see how much I care...12:48
thisfredI'm sure we already require 2.6 for other stuff12:48
ralsinathisfred: I know it's there somewhere12:49
thisfredalso, we'll probably be going to 3 soon12:49
mandelralsina, it states the problem we already have with move on linux.. is a delete created if you are looking at the creating dir..12:49
ralsinathisfred: fedora is 2.7, RHEL is so not our target12:49
* mandel hates file systems..12:49
thisfrednessita: ok, so critique retracted ;) but then I approved anyway12:50
nessitathisfred: thanks :-)12:50
urbanaperalsina, mandel: I still think Apple made the right choice with iCloud. But it's orthogonal to a model like Dropbox.12:51
urbanapeSimpler, but less room for fuckupery on the part of the filesystem12:52
ralsinaurbanape: since they own the freaking FS they have little excuse12:52
ralsinaurbanape: but yes, there is a diminishing returns thing on how much effort you can put there12:52
urbanapeThere's also the belief that hierarchical approach is outdated/doesn't fit the users' minds so much.12:53
urbanapeIt would be hard to get Ubuntu apps to play along without a (more?) common underlying framework behind the apps, too.12:53
ralsinaurbanape: yep12:54
mandelralsina, urbanape I wonder what I they using instead of ReadDirectoryChangesW in qt12:55
urbanapeand it uses kqueue for the time being12:56
ralsinamandel: why not ask the guy?12:56
thisfrednessita, for completeness' sake: http://python.6.n6.nabble.com/Status-regarding-Old-vs-Advanced-String-Formating-td4503327.html12:58
mandelralsina, so, I fixed the issue with the dialog not working on windows and... then  I hit this bug: http://twistedmatrix.com/trac/ticket/222612:59
mandelnessita, how much control do we have over patched to the qt reactor?12:59
ralsinamandel: looking...12:59
thisfredalso: http://pyvideo.org/video/948/pragmatic-unicode-or-how-do-i-stop-the-pain12:59
mandelralsina, python keeps running so do int a sys.exit(return_code) does not return the correct code.. bummer12:59
nessitathisfred: thanks!12:59
nessitamandel: not sure what you mean... we can propose patches to upstream thru github13:00
mandelnessita, ok..13:00
ralsinamandel: ugh13:00
* mandel goes to github13:00
nessitamandel: why?13:00
ralsinamandel:  on windows we can build qtreactor from whatever we want13:00
ralsinamandel: and we don't use it on linux13:01
nessitaralsina: we use it to run tests13:01
ralsinamandel: we are literally building it out of a branch tarball on github13:01
nessita(on both)13:01
ralsinanessita: ok, but that won't be affected by this, because it's a bug on exiting the process13:01
mandelralsina, nessita the issue i the following, all the thread that are used by deferToThread with qt reactor get glocked if you use exec_ for a QDialog (one bug in the reactor)13:03
ralsinanessita: while fixing the conflict in tweaks, I think the gotowebbutton __init__ is kinda broken. Specifically, self.legend is never going to be not None13:03
nessitaralsina: why not?13:03
mandelralsina, nessita my work around was to use show and connect to finish which will get the return code, then do a sys.exit(return_code) and reactor.stop() but that does not work (an other reactor bug)13:03
ralsinanessita: oh, right, subclasses, nevermind13:03
nessitamandel: I would seriously consider bringing those to upstream...13:04
mandelralsina, nessita a third way to fix this is do a callFromThread in the windows keyring so that we do not use a thread but execute the call in the main loop of Qt, then return a deferred that gets fired when done, which does work and does not require to fix the reactor13:04
mandelnessita, sure, I can loop at what is being done in the reactor..13:05
nessitamandel: did you talk with alece about this? he is our master when it comes to reactor stuff13:06
mandelnessita, will do when he wakes up.. we work 'til late yesterday13:06
mandelnessita, is this upstream => https://github.com/ghtdak/qtreactor13:07
nessitamandel: yes13:08
mandelnessita, thx13:08
ralsinaand alecu is in uruguay13:09
nessitaralsina: I got a little lost regarding your tweaks branch... is it ready?13:13
ralsinanessita: yes, pushed the conflicts fix13:14
* gatox brb..... goes to buy fruit salad to try to unblock the brain with the backend issue :S13:16
gatoxif fruit salad doesn't work.... i'm going to buy a gun13:16
ralsinagatox: you may also try getting help. You know. Professional help ;-)13:18
mandelralsina, how well does the python threading and the pyqt interact? I'm looking at http://twistedmatrix.com/trac/browser/tags/releases/twisted-8.1.0/twisted/python/threadpool.py#L27 which is what is used as a threadpool in twisted and I wonder how well does that work13:21
ralsinamandel: not very well AFAIK13:21
mandelralsina, he, then I guess there is some way to easy improve this :)13:22
ralsinamandel: or rather, python threads and pyqt work, as long as you don t do anything pyqt-ish in the non-main threads13:22
alecuhello #ubuntuone!13:27
ralsinahello alecu!13:27
nessitahola alecu13:27
gatoxalecu, buenas13:28
nessitaralsina, mandel, alecu, gatox: isn't the issue in windows, related to the keyring using deferToThread and not working, the thing that is making the 'Sign In' button not being enabled? it makes sense13:28
nessitasince that would mean that ussoc can not progress and can't tell if there is no credentials in the system13:29
gatoxis there any branch about that, that i could test?13:30
mandelnessita, yes, that looks similar to the problem I see in the proxy creds dialog (which is a smaller simpler app)13:30
mandelnessita, deferToThread on the qt reactor is not work at the moment, nor is callInThread13:30
nessitagatox: apparently there is no fix yet, AFAIK13:30
ralsinanessita: may be!13:30
mandelnessita, yest callFromThread does (which means, q in the main loop)13:30
nessitamandel: how come this worked before?13:30
gatoxright now i'm seeing like the app get stuck when trying to do: reactor.connectTCP and ask if it's listening13:30
ralsinamandel: it may be the exact same thing i the -ui-qt script!13:31
ralsinanessita: this never worked on windows with that on a separate process13:31
nessitaralsina: aaaaahhhhhhh  uuuuhhhhhhh craaaaaaaap13:31
mandelnessita, I'd need to look at all the changes, I've noticed that when a dialog uses exec_ it does not work, but if you use show it does13:31
ralsinanessita: before it was either in u1cp r in -installer, so it worked13:32
ralsinamandel: exec_ starts a secondary event loop, that may break reactor13:32
nessitamandel: we're displaying the "main" sso UI with show....13:32
nessitamandel: no, I lie, it uses exec_13:32
nessitamandel, ralsina: but is a separated process... why would that interfere with the "first" mainloop?13:32
ralsinanessita: lost me there. May not be the same thing then.13:33
nessitain any case, I'm incline to think that the "backend" not ready bug is related to this13:33
gatoxnessita, who is working on this?13:34
nessitagatox: a couple of tests you could do on Linux, is to lock your keyring, and then try to sign in13:34
mandelnessita, in a diff process it should not be an issue.. I now exec_ brakes things I have not looked any deeper atm13:34
nessitagatox: mandel I guess, but not sure. Ideally we'd need advice from alecu_, being him our reactor master13:34
alecu_nessita, sorry: the reactor master you are looking for is dobey :-)13:35
nessitaalecu_: can you mumble?13:35
alecu_nessita, I know how to *use* reactors, not how they work internally.13:35
dobeyque pasa?13:35
ralsinacould we get rid of deferToThread and just block on those calls? The windows keyring should be quick anyway13:35
nessitaalecu_: I have some ideas I would like to run by you13:35
alecu_nessita, I can try mumbling, but not sure if mumble will work for me today, since I'm not working from home.13:35
nessitaralsina: what if it's locked, like the linux keyring can be?13:35
ralsinanessita: you can't lock the windows keyring13:35
ralsinanessita: AFAIK at least13:36
nessitaalecu_: let's try... mandel, gatox, can you do a quick mumble?13:36
gatoxnessita, yes!13:36
nessitaralsina: will research. I know you're in a meeting, but if you want/can, mumble?13:36
mandelnessita, sure13:36
gatoxon mumble13:36
ralsinaI am at the design call, in mumble so no13:36
nessitagatox: would you drag me to the channel you're in? I can't13:37
nessitaalecu_: we're in mumble if you can13:38
alecu_nessita, this connection is very flaky, so no mumble today.13:44
nessitaalecu_: :-/13:45
alecu_nessita, so, how can I help?13:45
mandelnessita, lp:~mandel/ubuntu-sso-client/proxy-creds-windows13:46
nessitaalecu_: we're mumbling, will get back to you with concrete questions13:46
mandelnessita, here is the 'interesting' changes: http://bazaar.launchpad.net/~mandel/ubuntu-sso-client/proxy-creds-windows/view/head:/ubuntu_sso/qt/proxy_dialog.py#L15813:48
briancurtinralsina: i don't think you saw it yesterday, but syncing with a proxy works fine. still trying to figure out what the on_upload_finished issue is with getting the wrong number of arguments13:50
ralsinabriancurtin: awesome!13:50
ralsinabriancurtin: if you can pop into mumble, they are covering some windows-related bugs now13:50
briancurtinralsina: logging in now13:50
alecu_briancurtin, did anybody else got that error on XP?13:51
briancurtinalecu_ it turns out that same thing happens on Win7, just way way faster (i noticed it on XP since its a really slow VM)13:52
briancurtinso its all windows, apparently13:52
alecu_briancurtin, so, it's a relief knowing it's not a platform dependent bug.13:53
alecu_makes it sound a lot less scary :-)13:53
ralsinayeah, if that was XP only, it was caused by martians13:53
alecu_ralsina, martians that should be extinct long ago!13:54
ralsinaEOLife'd martians, yes13:54
alecu_"Your race is doomed!!!". 'No, we *will* prevail' it said while climbing back in the saucer.13:55
mandelbriancurtin, nessita, gatox very important regarding spawing a ui that uses the qt4 reactor and expecting the return code: http://twistedmatrix.com/trac/ticket/222614:01
mandelsys.exit(3) reactor.stop() with the qtreactor does not work.. :(14:02
nessitamandel: so, let me know when you come back from lunch and when the branch is ready for inspection :)14:16
ralsinaso, good news?14:19
nessitaralsina: kinda... I'm very confident gatox's backend issue is caused by the Qt SSO UI not running the qt4reactor in windows14:29
nessitaralsina: regarding mandel's issue, need to see his branch14:29
ralsinanessita: that is good news14:29
ralsinathe stuff about "the app doesn't end', we have seen before14:30
ralsinaor at least very similar things14:30
gatoxnessita, yes, it was reproducible from sources also..... i'm adding the qtreactor now14:32
nessitagatox: yey!14:32
nessitaalecu_, ralsina, mandel: there are like 4 branches from mandel that will not make it for this release.... were you aware of that?14:36
gatoxnessita, can you please point me in the direction of the qtreactor on u1-cp?14:37
nessitagatox: yes, first look at the bin/ubuntuone-control-panel-qt14:37
gatoxahhhh ok14:37
nessita     25 if sys.platform == 'win32':14:37
nessita     26     import qt4reactor14:37
nessita     27     qt4reactor.install()14:37
nessita     2814:37
nessita     29 from ubuntuone.controlpanel.gui.qt import main14:37
nessitagatox: then, go to ubuntuone.controlpanel.gui.qt.main14:38
ralsinanessita: I piged him about one yesterday but it has a broken prerequisite14:38
nessitagatox: in there, see the windows.py file :-)14:38
nessitagatox: I advice doing something similar to the qt sso ui14:38
gatoxnessita, will do14:38
* mandel back14:54
mandelnessita, yes, we know is not a problem, is a feature that we did that won't be used in our case14:54
mandelnessita, I'm making the changes to the branch to see the different issues14:55
nessitamandel: got lost, what thing is not a problem?14:56
mandelnessita, branches not landing, we know they wont and we are not in a hurry for those14:56
mandelnessita, and they should have merge issues..14:57
nessitamandel: ack then14:57
nessitaralsina, alecu, dobey, thisfred?15:01
ralsiname(no notes yet)15:01
nessitabriancurtin: go!15:01
briancurtinDONE: debugging, proxy IRL testing15:01
briancurtinTODO: hooking up VS to debug on_download_finished TypeError now that i know it's not XP specific, get any other windows stuff out of the way to get back with urbanape for a bit15:01
briancurtinBLOCKED: XP kinda sucks15:01
briancurtinNEXT: urbanape15:01
urbanapeDONE: looked into /dev/fsevents reading for file-level event granularity15:01
urbanapeTODO: Tests, land branch, for god's sake!15:01
urbanapeBLOCK: my brain.15:01
urbanapegatox, go.15:01
gatoxPropose the unicode fixes branch for sso and fixed the test_main suit. Investigate the backend issue.15:01
gatoxFinish with the backend problem.15:01
gatoxnessita, go15:02
nessitaDONE: proposed computer-to-cloud-page u1cp branch, reviews15:02
nessitaTODO: land branches for release, help with stucked apps to mandel and gatox, leave early due to teaching duties15:02
nessitaBLOCKED: nopes15:02
nessitaNEXT: mandel15:02
* mandel finishing notes15:02
mandelDONE: We got the webclient working correctly by fixing bug (late night work). Looked at issues with prxoy creds dialog on windows.15:03
mandelTODO: more creds dialog debugging. Look at jenkins. Write sso script example for aquarius.15:03
mandelBLOCKED: no15:03
mandeldobey, please15:03
dobeyλ DONE: askubuntu, bug #932103 (pinging right people, and testing)15:03
dobeyλ TODO: bug #953119, releases, uploads15:03
dobeyλ BLCK: none.15:03
ubot5Launchpad bug 932103 in gstreamer0.10-fluendo-plugins-partner (Ubuntu Precise) "Cannot install MP3 playback support; silently fails" [High,Fix released] https://launchpad.net/bugs/93210315:03
ubot5Launchpad bug 953119 in ubuntuone-client-gnome (Ubuntu) "valgrind invalid read error" [Undecided,Triaged] https://launchpad.net/bugs/95311915:03
nessitaalecu_: go!15:03
nessitaALL: is there any branch that *needs* to be in tomorrow's release that hasn't landed yet?15:03
ralsinanessita: I don't think so, if we don't mind the windows release being done from another tarball15:04
ralsinaDONE: got a few windows-specific branches merged and the focus tweaks branch, reviews, tech leads call, mgmt call (in progress), design call, missed part of the day because of doctor TODO: help with windws fixes, start windows release process BLOCKED: not really15:04
nessitagatox, briancurtin, alecu_, mandel, dobey, thisfred, urbanape: is there any branch that *needs* to be in tomorrow's release that hasn't landed yet?15:05
thisfredDONE: reviews | gave up on segfault for now TODO: u1db filter functions in C | u1db and other reviews | turn 40 | go to Savannah BLOCKED: no NEXT: ralsina!15:05
urbanapenessita: not from me15:05
mandelnessita, not from me AFAIK15:05
dobeynessita: is there a branch that fixes everything to be how i wante it to be? :)15:05
briancurtinnessita: windows specific, but we need this one in whenever the windows release happens (1 approval already): https://code.launchpad.net/~brian.curtin/ubuntuone-client/930398-windows-is_root/+merge/9622415:05
gatoxnessita, i don't have branches for review.... working in the qtreactor thing right now15:05
nessitathisfred: happy birthday! (you turn 40 today? :-))15:05
thisfrednessita: tomorrow :)15:05
nessitaack to all the branch info, thanks15:06
nessitathisfred: will try remember saying happy bday tomorrow then :-)15:06
thisfredALL: so I won't be here the rest of the week15:06
nessitadobey: no :-)15:06
thisfrednessita: I'll be in Georgia :)15:06
ralsinathisfred: sorry, I shot first. Like Han Solo15:06
dobeythe state, or the country?15:07
mandelthisfred, 40!?! If you where a british northern girl you could be my mother!15:07
thisfredI'd have given you up for adoption for sure15:07
dobeymandel: your mother gave birth to you at the age of 13?15:08
dobeyexplains a lot15:08
mandeldobey, that is why I said 'british northern girl' my mother is spanish :P15:08
thisfredthat and the heavy drinking she did during the pregnancy15:08
=== alecu_ is now known as alecu
* gatox lunch!15:10
ralsinanessita: we have a new comment in the color chage bug from robert, is that good enough to move forward/15:14
nessitaralsina: looooooking15:14
=== gatox is now known as gatox_lunch
nessitaralsina: may be enough.... I guess we can start the process. Asking joshuahoover for confirmation is the best thing to do right now15:16
ralsinanessita: ack15:16
nessitaralsina: also, I proposed https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/license-page/+merge/98432 so we can add the strings before releasing (though the license page is never shown, for now)15:16
ralsinanessita: looking15:17
joshuahoovernessita: yeah, that should be good...i'll move it forward as soon as i get off this current call i'm on15:17
nessitajoshuahoover: thanks!!!15:17
ralsinanessita: I can do the --installer branch later myself if you want15:17
ralsinanessita: since I have been hacking on command lines lately15:17
nessitaralsina: you can try, but it will not be trivial15:17
ralsinanessita: sure, I can try, if I fail I'll cry and let you know ;-)15:18
nessitaralsina: since the wizard is created 'automatically' from the setupUi, and thus I don't know how to pass custom arguments to custom widgets15:18
ralsinanessita: I'm siure there is a way ;-)15:18
urbanapebriancurtin: your last note in the standup reminded me: Should I get W7 for my VMware?15:19
urbanapeI'm currently running XP15:19
nessitaralsina: nice15:19
alecunessita, btw: was it useful, the info on the package dependencies I provided yesterday ?15:22
ralsinanessita: +1 on that15:22
nessitaalecu: yes, the -proxy package is already available (I mentioned this at noon yesteday). Have you try it? :-)15:22
dobeynessita: do you want to do the release of ubuntuone-client as well?15:23
nessitadobey: I can if you teach me :-)15:24
nessitadobey: make dist I guess and then upload that tarball?15:24
mandelnessita, I updated lp:~mandel/ubuntu-sso-client/proxy-creds-windows I have added a new arg for testing, if you use --use-exec the diaog will be launched using exec_ otherwise a show + finish signal solution is used (which 'works')15:24
mandelralsina, ^15:24
dobeyoh, right. it's a bit more complicated than that, because of gtk-doc15:24
mandelralsina, and if you have time we can take a look to see if I did something stupid15:24
ralsinamandel: I will be available in about 15 minutes15:25
nessitamandel: so, I just confirmed that the reactor has to be installed *before* the qapp is created15:25
dobeynessita: i'll do the tarball release, and you can do the upload15:25
nessitadobey: sounds great15:25
mandelnessita, before? then the doc is a lie: https://github.com/ghtdak/qtreactor15:26
briancurtinurbanape: yeah i think you might as well have it15:26
ralsinamandel: that stinks of "QDialog.exec_()" breaks the qtreactor to me15:26
ralsinamandel: so I am ok with using show()15:26
mandelnessita, from the docs in github: '= Using the Qt4Reactor =15:26
mandelIn your own code, BEFORE you import the reactor...15:26
mandelapp = QApplication(sys.argv)15:26
mandelimport qt4reactor15:26
ralsinanessita: if you install the reactor first, it will create a QCoreApplication, IIRC15:26
mandelralsina, does the trick, except for the fact that I cannot return the code via sys.exit :(15:26
urbanapebriancurtin: do we have an MSDN account or do I just grab a copy somewhere?15:27
urbanape(legit, natch)15:27
ralsinamandel: we had that problem before, didn't we?15:27
mandelralsina, I have not seen that..15:27
briancurtinurbanape: that's a question for ralsina (i'd like the answer as well, since my XP VM was created with an MSDN i got elsewhere)15:27
nessitaralsina, mandel: then we have it wrong in the controlpanel... the reactor is installed *before* the qapp15:27
nessitaralsina: is u1cp working on windows?15:27
ralsinanessita: yes15:28
ralsinanessita: which is why I am pretty confused right now15:28
mandelurbanape, I do :)15:28
nessitaralsina: well, we're going it the other way around there (first installing the reactor, then creating a qapp)15:28
nessitamandel: wanna test having the other way around? (first installing the reactor, then creating a qapp)15:28
ralsinanessita: so, let's do it like you say and let's see :-)15:28
mandelurbanape, and is legit, gatox alecu nessita and I have msn accounts :)15:28
mandelnessita, sure!15:28
ralsinaif that wouldn't work, QApp will complain15:29
mandelralsina, nessita updated chaging the order, that is, first import & install then create instance, it works, wtf? also, look at the logs, the qt reactor.qApp is a QCoreApplication and not a QApplication..15:37
mandelbranch is the same15:37
ralsinamandel: awesome and weird15:37
nessitaralsina: perhaps a Qapp can be created after a qcoreapp and the latter gets "upgraded"???15:38
ralsinanessita: never heard of such a thing15:38
ralsinanessita: but let's pick our battles ;-)15:38
nessitagatox_lunch: may I have a review for https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/license-page/+merge/98432 ?15:38
mandelralsina, nessita , I think that is a QCoreApplication because the reactor is calling QCoreApplication.instance() which return the QApplication instance casted as a Core app15:40
nessitamandel: you lost me15:40
mandelnessita, nothing I was guessing.. and is wrong.. if you do QApplication(sys.argv) and then QCoreApplication.instance() you get the QApplication15:42
nessitadobey: do you know if u1client is ready to be updated from trunk?15:43
dobeynessita: i don't know of any pending branches we need to land for today15:44
nessitadobey: besides the tarball, are you doing the update branch as well, or shall I?15:44
dobeyyou can do that15:44
nessitadobey: ack15:44
mandelralsina, from here: http://cep.xor.aps.anl.gov/software/qt4-x11-4.2.2-browser/dd/d94/qdialog_8cpp-source.html I see that exec uses a QEventLoop which might be the culprit, can you have a QEventLoop without a QApp?15:45
ralsinamandel: probably not15:45
ralsinamandel: you can have one with a QCoreApp though15:46
mandelralsina, and it can deal with UI, right?15:46
ralsinamandel: no15:46
ralsinamandel: you need a real qapp before you can create a qpainter15:47
ralsinamandel: what's your branch again/15:49
mandelralsina, branch: lp:~mandel/ubuntu-sso-client/proxy-creds-windows15:49
ralsinamandel: ok, looking now15:50
mandelralsina, fancy a major wtf? I have one for you :)15:53
mandelralsina, execute this on linux and windows http://paste.ubuntu.com/892348/15:53
ralsinamandel: why not15:53
mandelralsina, if I did not screw it up you are going to me like me15:54
* mandel FUUUUUUUUUUUU15:54
urbanapeApple Store Genius Bar appt, part deux!15:54
ralsinamandel: ok, so you can exec_ a dialog without exec_ ing the app. That's a bit surprising15:54
mandelralsina, you did it on windows only?15:55
ralsinamandel: yes15:55
mandelralsina, try linux now15:55
ralsinamandel: can't do it on linux now15:55
ralsinamandel: so explain :-)15:55
mandelralsina, well, I can tell you => segfault15:55
ralsinamandel: ha!15:55
mandelralsina, I don't think our problem is related to that, but is a serious what the holy frack windows?15:56
dobeyok, i really need to get lunch. bbiab kids15:56
mandelralsina, and exec_ is probably executing the QEventLoop correctly as long as there is a QApplication, that means that the reactor does not run the dialog ergo no deferToThread15:57
ralsinamandel: well, you prefer the segfault?15:57
ralsinamandel: right, the reactor is only moved by the main event loop15:57
ralsinamandel: so, we use show(modal=True) and that's it15:57
mandelralsina, yes, and also + finish.connect, right?15:58
ralsinamandel: I am looking now at your exit_code function15:58
mandelralsina, a diff story is returning via sys.exit, which does not work15:58
ralsinamandel: you can't do stuff after sys.exit!15:58
nessitaguys, I gotta run to the university15:58
ralsinamandel: let me take a whack at it :-)15:58
nessitaralsina, gatox_lunch: call me to my cell if anything comes up15:58
ralsinanessita: sure!15:59
nessitaralsina: I will propose the stable-3-0 updates branches during the afternoon15:59
nessitaralsina: actually, I have one update ready now: https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/stable-3-0-update-2.99.91/+merge/9844016:00
nessitathe rest will come during the day, will email those16:00
ralsinamandel: it works perfectly if you exit with QtCore.QCoreApplication.instance().exit(code)16:00
mandelralsina, sweet!16:01
ralsinanessita: will review them after I boot to linux.16:01
mandelralsina, so we have a dirty fix :)16:01
ralsinamandel: what's dirty? ;-)16:01
ralsinamandel: have not tried exiting with QApplication.instance() but should be the same thing16:01
ralsinamandel: it's even crossplatform! ;-)16:01
nessitaok, I'm soon to be off16:04
nessitabye all!16:04
ralsinamandel: so, go ahead, ping me when you have a branch to review :-)16:04
mandelralsina, hm.. have you done an IRL16:04
ralsinamandel: yes16:04
mandelralsina, when you store the creds it does not exit.. at least in my system16:04
ralsinamandel: running the script, not the whole thing16:04
ralsinamandel: works perfectly, even stores the credentials16:05
ralsinamandel: let me give you a diff16:05
mandelralsina, or push to a branch and I merge (me lazy! )16:05
ralsinamandel: ok, let me try a slightly cleaner fix16:06
mandelralsina, must say, it is a cute bug :)16:06
ralsinamandel: fix at lp:~ralsina/+junk/mandel16:08
ralsinamandel: ok, rather, it's being pushed there16:08
ralsinamandel: ok, let me push it to a ot-junk place because that takes forever16:09
=== gatox_lunch is now known as gatox
ralsinamandel: here it is: lp:~ralsina/ubuntu-sso-client/mandel notice that we *still* have to stop the reactor16:09
mandelralsina, ah.. I was missing that detail16:10
ralsinamandel: why we have to do that after we stop the event loop, I have no idea, but as long as we have a recipe, I am happy16:11
mandelralsina, it is a very weird thing.. that qt reactor scares me..16:13
ralsinamandel: just walk carefully and try to look bigger than you are16:13
ralsinamandel: we only need it because of IPC and this defertothread right?16:14
mandelralsina, in most of the stuff ipc, in this case, defertothread16:15
mandelralsina, I know that the qt login ui implementation if it has IPC is going to have this problem16:15
mandelgatox, ^16:15
mandelunless exec_ is not used16:15
ralsinamandel: ok, let's think about how to get rid of it for next year16:15
ralsinamandel, gatox: talk with each other ;-)16:16
mandelralsina, so many things we need to fix for next year!16:16
mandelgatox, are u single?16:16
gatoxmandel, ok...... you are scaring me now16:16
mandelralsina, that ^ kind of chat? :P16:16
ralsinamandel, gatox: because this fix needs to be done in the UI too16:16
gatoxmandel, ralsina i'm trying to add the call to the qtreactor in the ui of sso right now16:16
mandelralsina, yes, it does, so we should make him do one of the reviews to say wtf and learn about it :)16:17
ralsinagatox: you will also be hit by the exit code bug we just fixed16:17
gatoxralsina, eh? what was the problem about that?16:17
mandelgatox, there are several things, first doing this: http://paste.ubuntu.com/892348/16:18
mandelgatox, well esecute the dialog and not run the twisted reactor O_o16:19
mandelgatox, second, you will need to use QApplication.exit() to set the return code and after reactor.stop16:19
gatoxi didn't use QApplication.exit() before because it wasn't working..... you have it working with that now?16:20
mandelgatox, yest, let me clean up a little the branch and will ask for a review16:21
gatoxmandel, so.... let me understand..... this thing that you are doing with the qapplication, qcoreapplication.... is related in anyway with the problem i'm having with the sso ui?16:21
gatoxmandel, do i need to do the same? or the qtreactor approach is the correct one'16:21
mandelgatox, you have to use the qtreactor which brings a long some bugs that we have found how to work around16:22
briancurtinralsina: i'm spending too much time right now to even get debugging setup for this on_download_finished problem. since this isn't a showstopper, are there other things i should work in order to push forward the release?16:26
ralsinabriancurtin: we are waiting for two branches (mandel & gatox) and we may have something that works16:29
ralsinabriancurtin: so, maybe lunch? ;-)16:29
briancurtincool, well i'll keep going on this for now and await their branches16:29
briancurtinyeah i should do that soon16:30
ralsinabriancurtin: if you are around, 1:1?16:55
briancurtinralsina: logging in now17:03
ralsinabriancurtin: cool17:03
briancurtinif mumble will ever start running...17:04
mandelralsina, gatox FYI fixing tests.. is not that easy to ensure the changes we made are tested17:12
gatoxmandel, i'm having some troubles with the reactor already installed.... i'm looking at that now....17:12
dobeyugh the pollen17:12
mandelgatox, let me know if you need a hand :)17:16
gatoxmandel, yes, thanks.... i already fix that.... but now there is another problem (as always jeje)17:17
mandelgatox, unicode?17:18
gatoxmandel, jeje not this time17:18
ralsinapolen, unicode, you guys are complainers17:26
* ralsina goes do something manager-like17:26
alecu_ralsina, my bottom itches!17:26
ralsinaalecu_: it's all the hat sitting17:26
mandelralsina, no tall the tests pass won windows, right?17:26
ralsinamandel: on sso?17:27
mandelralsina, yes, I'm getting a dirty reactor..17:27
dobeyralsina: well, snot and keyboards don't mix17:27
ralsinamandel: on u1cp things get stuck, and yes we have dirty reactors like chernobyl17:27
alecu_mandel, I'm replying to rm-cbride mail on proxies.17:27
ralsinadobey: but do they BLEND?17:27
ralsinamandel: one of these days we need to debug that17:27
briancurtinmandel: the reactors are very dirty17:28
dobeyralsina: almost certainly17:28
mandelalecu_, which mail?17:29
mandelalecu_, oh, ubuntunet-discuss, got it17:29
dobeyalso, the new theme changes are weird17:30
dobeyto light-themes17:30
mandelralsina, briancurtin can you add a bug report regarding the reactors, I'll try to clean them asap17:31
ralsinamandel: sure17:31
ralsinadobey: you mean our theme changes, or the light-theme changes?17:31
dobeyralsina: light-themes; some fonts look fuzzier now, and the desaturation when not focused is a bit odd17:32
ralsinadobey: ack17:32
dobeyand doesn't seem to work for all widgets17:32
dobeyman. some apps really do not like multiple screen setups17:38
ralsinamandel: how's that branch coming?17:45
mandelralsina, getting test running on both platforms, maybe 10 mins more and I'm done17:46
ralsinamandel: cool!17:46
* dobey discovers a unicode bug in apport17:47
ralsinadobey: assign to gatox!17:51
ralsinamandel: bug #96043617:52
ubot5Launchpad bug 960436 in Ubuntu One Control Panel "tests from trunk fail on windows" [Undecided,New] https://launchpad.net/bugs/96043617:52
dobeymy tear ducts are itchy :(17:52
briancurtindobey: too much unicode?17:55
dobeytoo much plant reproductive code17:56
=== gatox is now known as gatox_brb
* mandel forgot how slow is too work on a windows vm..18:04
dobeyi should port my theme to gtk318:14
dobeyhi davidcalle18:17
davidcallehi dobey!18:18
dobeyhow are you?18:18
davidcalledobey, fine and you?18:18
dobeydavidcalle: good. have you got any further with finishing the rb scope?18:19
davidcalledobey, it's waiting to be merged.18:20
davidcalledobey, https://plus.google.com/u/0/117867558830601601230/posts/j6ikKygHS4818:20
davidcalleto be merged ... in the music lens*18:20
=== gatox_brb is now known as gatox
mandelralsina, do you have a bug for the proxy issue?18:27
gatoxmandel, are you eod already?18:27
ralsinamandel: no18:27
mandelralsina, I'll create one then18:27
mandelgatox, nearly, do you need help?18:27
ralsinamandel: you can use the one about the script not being crossplatform18:27
gatoxmandel, if you have a minute.... i'm really stuck with this...... i've installed the qtreactor, but the problem persist18:28
mandelgatox, which is the problem?18:28
dobeydavidcalle: ah, is there a different branch now? the rb-scope one says "work in progress" for its status, and hasn't had any changes since Mar 13 :)18:28
mandelralsina, created a quick one, I can also add it to that one so that you just close it when all scripts are done18:29
mandelralsina, do you have the bug number?18:29
davidcalledobey, indeed, it's https://code.launchpad.net/~scopes-hackers/unity-lens-music/rb-scope/18:29
ralsinamandel: nah, the quick one is enough18:29
gatoxmandel, the reactor seems not to be working or something.... twisted get stuck on connectTCP18:29
gatoxmandel, the same problem we discuss early today.... that it was going to be fix probably with the qtreactor..... can i show you a branch on how i use the qtreactor and you can tell me if that is ok?18:30
mandelgatox, of course you can, shoot!18:31
gatoxmandel, uploading the branch18:31
briancurtinralsina: for the autostart piece moving into CP, is there any preferred location it should go? i'm guessing just somewhere in main so it gets added on startup?18:33
briancurtinit used to be at the end of the wizard in u1-win-installer18:34
mandelgatox, ralsina please: https://code.launchpad.net/~mandel/ubuntu-sso-client/proxy-creds-windows/+merge/9848118:34
ralsinabriancurtin: somewhere after the user has logged in, I suppose.18:34
gatoxmandel, on it18:34
gatoxmandel, this is the branch: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/backend-problem18:34
briancurtinralsina: ah, better idea :)18:34
ralsinabriancurtin: maybe at the end of the wizard in ubuntuone/controlpanel/gui/qt/wizard.py18:34
briancurtinoh :)18:34
ralsinabriancurtin: in the done() method18:35
gatoxmandel, the bug can only be reproduce on windows..... if you start the ubuntu-sso-login-qt ui..... with --login_only..... and complete the form, the login button never became enabled18:35
ralsinamandel: on it!18:35
mandelgatox, the issue is on windows not getting signals etc, right?18:35
briancurtinmandel: also looking18:35
mandelgatox, ack18:36
mandelbriancurtin, thx! is a little hacky, or hackier than i like. The branch is related to the fact that using exec_ in qt uses a QEventLoop, that starts a new event loop and blocks the reactor go not allowing the deferreds to be fired18:36
gatoxmandel, the issue is that the backend get stuck so when the setup of the pages try to use it fails, and the ui is not configured.... but the problem is not the ui, but the backend being stuck on connectTCP18:37
mandelbriancurtin, the work around is to use show on windows and connect to the finished signals so that only event loop present is the one from the reactor18:37
mandelgatox, a priori thins look good18:40
mandelgatox, how are you testing it?18:40
briancurtinmandel: and since i'm not sure of what didn't work before this branch, what should i notice in an IRL test of it?18:40
briancurtin(still waiting for the diff to show up, so i don't know *anything* yet :)18:40
gatoxmandel, trying to execute the ui..... you can execute python bin/ubuntu-sso-login-qt --app_name="u2" --login_only18:41
mandelbriancurtin, you can go either to the keyring on linux of the credential manager on windows and see a test_domian entry with the username and password :)18:41
gatoxmandel, or also, run first, bin/ubuntu-sso-login.... and then the ui in another process18:41
gatoxboth things gave the same result18:41
mandelbriancurtin, do you know how to use meld with bzr? you can branch and then do 'bzr diff --old lp:ubuntu-sso-client --using meld'18:42
mandelbriancurtin, a lot nicer than lp diff :)18:42
mandelgatox, do you mind if I walk the dog and give you a hand after?18:44
briancurtinmandel: ah, didn't know about that18:44
briancurtinhave the dog do a review18:44
gatoxmandel, yes! no problem....18:44
gatoxmandel, also if it's your eod go and enjoy the world! :P18:44
mandelbriancurtin, he is not that smart hehe18:44
gatoxno worries!18:44
mandelgatox, sure? I'd like to take a rest to be honest, but you can send me an email and I'll take a look while watching bad tv :)18:45
gatoxmandel, yes!! no problem!! don't worry, really18:45
mandelgatox, ok, then do send me the email!18:46
mandelall, EOD here18:46
gatoxmandel, ok! see you18:46
gatoxmandel, bye!18:46
mandelralsina, briancurtin let me know about the review in the comments, I get the lp email on my phone18:46
briancurtinwill do18:46
* mandel walks dog and freezes ass18:46
mandelbriancurtin, and be harsh :)18:47
ralsinamandel: ack18:47
ralsinagatox: can you do a test/lint run of  lp:~ralsina/ubuntuone-control-panel/installer-option on linux?19:05
gatoxralsina, yep....19:05
ralsinagatox: thanks!19:05
gatoxralsina, i'm getting this: http://paste.ubuntu.com/892625/19:09
ralsinagatox: thanks!19:10
=== yofel_ is now known as yofel
dobeymandel needs to actually read the review comments though :P19:10
ralsinagatox: another one please?19:13
ralsinadobey: which specific one?19:14
dobeyralsina: https://code.launchpad.net/~mandel/ubuntu-sso-client/ssl-checkbox/+merge/9761919:14
dobeyi reviewed it on friday even :P19:14
dobeyand it's the branch that's blocking his other one from landing19:15
ralsinadobey: that branch is not going into release19:15
ralsinadobey: it's a nixed feature (or at least a delayed one)19:15
ralsinadobey: turns out noone uses ssl-to-proxy connections19:15
dobeywell, few people do i guess19:16
gatoxralsina, yes shoot19:16
gatoxralsina, the same one updated?19:16
dobeyupdate the related proposals to reflect that then? :)19:16
ralsinagatox: yes19:17
ralsinadobey: talk to the mandel :-)19:17
* ralsina is jut the manager19:17
* dobey delegates management to his manager19:18
gatoxralsina, http://paste.ubuntu.com/892645/19:18
ralsinagatox: thaks, and sorry I use you as a buildbot ;-)19:19
ralsinagatox: but the tests are broken here19:19
gatoxralsina, jejej no problem..... is just 2 commands19:19
ralsinagatox: I can't believe I have not added a bit of lint yet :-)19:20
ralsinaoh, fun,tests are full of magic numbers19:22
ralsinaAnd I don't mean the band "The Magic Numbers"19:23
ralsinagatox: uno mas y no jodemos mas! (a menos que fallen los tests)19:26
gatoxralsina, jejeje ok19:26
gatoxralsina, bad news: http://paste.ubuntu.com/892669/ (and it seems you left a print somewhere in the code)19:28
ralsinagatox: it's moving in the right direction! ;-)19:28
gatoxjeje yes19:29
ralsinagatox: again!19:34
gatoxon it19:35
gatoxralsina, tihs was kind of aggresive. http://paste.ubuntu.com/892692/ :P19:39
gatoxit's working! it's working.....19:41
ralsinagatox: oops19:41
ralsinagatox: forgot the self. :-/19:41
gatoxralsina, happens :P..... it seems that the qtreactor thing blocking the backend is working.... i should test it now with py2exe19:42
ralsinagatox: wooohoo!19:42
ralsinabriancurtin: we may build a release today yet :-)19:42
ralsinabriancurtin: for QA purposes only ;-)19:42
gatoxralsina, at least from sources...... that was failing before, it's working now19:42
briancurtini'm putting together the autostart thing right now, adding in the tests19:43
ralsinabriancurtin: awesome, I have almost finished adding the --installer page19:43
ralsinagatox: one more!19:43
gatoxralsina, running19:44
ralsinabriancurtin: another missing bit to migrate to u1cp is "uninstall when the user clicks on cancel on the license" but that one can wait until tomorrow I think19:44
briancurtinralsina: ok19:45
dobeycancel on what license?19:45
gatoxralsina, http://paste.ubuntu.com/892709/19:46
ralsinadobey: on windows, we show the gpl on installation19:46
ralsinagatox: argh19:46
dobeyonly the gpl?19:46
ralsinadobey: yes19:46
dobeyalso, the gpl doesn't really say anything about use. it's all about distribution19:47
dobeyso uninstall is probably the "wrong" action at that point19:47
dobeyas is requiring a user to click "accept" to the gpl19:47
ralsinadobey: yes, it's about accepting it before you copy the software into your system. If you don't accept it, it doesn't install19:47
ralsinadobey: platform expectations, also known as "all my friends liked jumping off bridges"19:47
dobeybut all of our code isn't GPL :)19:48
ralsinadobey: please don't make my life harder today. We can do this tomorrow after I have a nice rest ;-)19:48
dobeyspeaking of making life harder. legal agreed we should add the exception for openssl right/19:49
ralsinadobey: awesome19:49
ralsinaso, for next release19:49
ralsinagatox: one moreplese19:53
ralsinadobey: got it!19:53
dobey^^ can i get some reviews on those two?19:53
ralsinadobey: yep19:53
dobeynessita donde es?19:53
briancurtinuh, python crashes on "test_animation_is_active" in u1cp :/19:54
ralsinadobey: teaching19:54
ralsinabriancurtin: on windows?19:54
briancurtinralsina: yeah19:54
ralsinabriancurtin: tests on windows seem to have devolved lately19:54
ralsinadobey: trunk is open already, right?19:54
gatoxralsina, congrats! \o/ just a minor lint issue:19:54
gatox    332:  [W0201, UbuntuOneWizard.check_settings] Attribute '_next_id' defined outside __init__19:54
ralsinagatox: hey, close :-)19:54
dobeyralsina: trunk of what?19:55
ralsinadobey: sso19:55
dobeyralsina: well, my opinion is that trunk is always open; and we can cherry pick :)19:55
dobeyralsina: i don't know if nessita did an sso release or not19:55
ralsinadobey: cool, just wanted not to bother19:55
ralsinadobey: +1 on -installer since it's exactly like trunk19:56
dobeyBugs targeted: 30 New, 2 Triaged19:56
dobeyon sso-client19:56
* dobey wonders why that says 10 new, 2 triaged19:57
ralsinagatox: hopefully last one?20:02
gatoxrunning tests20:03
ralsinadobey: +1 on rb20:03
dobeyralsina: gracias20:03
gatoxralsina, everything perfect20:03
ralsinagatox: awesome, proposing20:04
gatoxralsina, yes! it's working20:08
gatoxralsina, the reactor thing20:08
ralsinagatox: awesome!20:09
gatoxralsina, let me check if this requires test..... and i'll propose20:09
ralsinaSo, the delta between linux and windows seems to have been about 1.5 developer-week. That's not so much.20:10
ralsinaas in, it took 10 developer-days to get windows working again20:10
ralsinawe just have to spread that across the cycle20:10
ralsinagatox: if, after you propose, you could review https://code.launchpad.net/~ralsina/ubuntuone-control-panel/installer-option/+merge/98503 and its prerequisite branch, it would be great20:11
gatoxralsina, yes! no problem20:11
ralsinadobey: your -installer branch is bouncing horribly20:14
dobeyyeah i know why20:15
ralsinadobey: ack20:15
dobeywtf tarmac20:22
dobeyhow did this branch land20:23
dobeyalso, how did i not get these lint errors yesterday20:24
ralsinadobey: good questions20:25
dobeyguess i have to do another branch to get in the release20:25
ralsinaI am going to take a break20:25
ralsinabriancurtin: before you leave, if you have that branch ready, please give me a report20:26
ralsinaI will do (very late tonight) a patchwork binary with all the branches we fixed today20:26
ralsinaso QA has something to start testing tomorrow20:26
briancurtinralsina: i will. i'm currently fudging OpenKey in the tests so it will work20:26
ralsinabriancurtin: awesome20:26
ralsinagatox, dobey, briancurtin: And I am gone. Review requests, on the mail please, I will do some tonight.20:29
briancurtinralsina: have a good evening20:29
gatoxralsina, ok.... i'll send you mine in a while.... and review yours20:30
dobeybriancurtin, thisfred: one of you care to do a quick/trivial review on https://code.launchpad.net/~dobey/rhythmbox-ubuntuone/fix-lint/+merge/98511 ?20:32
briancurtindobey: +120:34
gatoxralsina, here is the branch: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/backend-problem/+merge/98513 (i'm sending you an email with this too)20:39
ralsinathanks gatox!20:40
gatoxralsina, reviewing yours and nessita's now20:40
ralsinagatox: looks like you introduced some controlpanel module there!20:46
gatoxralsina, really?!..... removing that20:46
ralsinagatox: line 122 o the diff20:46
gatoxralsina, i've approved your branch and nessita's..... not globally approved20:48
ralsinagatox: golbally apprve nessita's20:48
ralsinaargh, can't type anymore :-)20:48
ralsinamine can wait for another review20:48
gatoxralsina, ohh.. i confuse the modules..... fixing that20:49
ralsinagatox: something tells me you did not IRL this ;-)20:49
gatoxralsina, yes..... and it works!20:49
gatoxbut if the controlpanel is in the pythonpath is going to work20:50
ralsinagatox: right, fails for me on windows because I have no controlpanel on PYTHONPATH20:50
gatoxbecause those modules are the same20:50
ralsinagatox: docstring on qt/main/__init__ says "gtk"20:52
ralsinagatox: and why remove all of tests_main ?20:53
gatoxralsina, fixed..... and added the missing tests to the new folder20:54
ralsinagatox: ack, will rereview20:54
gatoxralsina, i moved the test_main inside main folder20:54
gatoxand added some more20:54
gatoxralsina, eod for me..... but let me know if there is something that i need to fix in the branch i'll do it20:56
ralsinagatox: cool, good work, BTW20:56
gatoxralsina, thanks :D20:56
dobeybriancurtin, thisfred: same changes again, but for stable-3-0, if you can do a quick review please https://code.launchpad.net/~dobey/rhythmbox-ubuntuone/fix-lint-stable-3-0/+merge/98517 ?21:02
thisfredon it21:02
briancurtindobey: looking21:02
ralsinagatox: congrats21:03
gatoxralsina, :D21:03
ralsinagatox: it works and everything21:03
briancurtindobey: +121:03
ralsinaand bye all!21:04
gatoxralsina, awesome.... the working-thing part was important! :P21:04
gatoxralsina, bye!21:04
nessitabriancurtin: hola!22:07
nessitaralsina: were you able to do my review?22:07
gatoxnessita, i think ralsina is not here22:10
nessitagatox: holas! bu, I asked him to do a review for me22:10
nessitagatox: were you able to review the one I asked before leaving?22:10
gatoxnessita, i review a branch of yours.... i don't know if that is what you mean22:11
gatoxthat one22:11
gatoxnessita,  i propose the branch that fix the reactor thing also22:11
nessitagatox: yes, thank you for the review. I will review and land the reactor one tomorrow, so it does enters this (ubuntu) release22:11
gatoxnessita, ok, great22:12
dobeyalright, i am off. got installer and rb-u1 uploaded to ubuntu at least. and so much for doing any yard work tonight it seems. :-/22:15
dobeylater all22:15
gatoxdobey, bye22:15
nessitagatox: you still working?22:17
nessitabriancurtin: you up for a very trivial review? https://code.launchpad.net/~nataliabidart/ubuntuone-windows-installer/stable-3-0-update-2.99.91/+merge/9844522:17
briancurtinnessita: looking now22:18
gatoxnessita, npo.... just hanging around :P22:18
nessitagatox: ja22:18
briancurtinnessita: oh that was easy :)22:18
nessitabriancurtin: ;-)22:18
briancurtini'm out of here, see everyone tomorrow22:38
=== gatox is now known as gatox_tv_brb40
* nessita needs reviews23:18
nessitaralsina: hey!!!23:21
nessitaralsina: you around?23:21
=== gatox_tv_brb40 is now known as gatox
nessitaralsina: ok, sent you email with review request, as soon as those are done, will move forward creating the tarballs23:39
nessitanow, to have dinner23:39
nessitabye all!23:39

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!