[00:29] desrt: the gmenus in Unity are very nice \o/ [00:47] jbicha: What apps currently use it? I'd like to try for myself for a11y reasons. [00:50] TheMuso: epiphany-browser gnomine gnotravex iagno mahjongg quadrapassel [00:50] Ok epiphany it is then. :) [00:51] Hrm epiphany uses clutter? For what? [00:53] TheMuso: I don't think it needs clutter, but I heard that epiphany < 3.92 might have been broken with the latest webkit [00:53] Ah haven't got a new enough indicator-appmenu yet. [00:53] * TheMuso updates. === Ursinha is now known as Ursinha-away === jalcine is now known as jalcine_ === jalcine_ is now known as jalcine === jalcine is now known as jalcine_ === jalcine_ is now known as jalcine === jalcine is now known as jalcine_ === jalcine_ is now known as jalcine [05:28] jasoncwarner_: Where can I file a bug against the piece of code responsible for generating that bug webpage? [05:28] ha! [05:28] directly with kate, I think [05:28] Good Morning. [05:28] I talked to her this morning b/c there were some without tags showing up in that list [05:29] jasoncwarner_: Ok thanks, nothing quite so serious for me, just something to help me navigate that page a little better with Orca. [05:29] oh, fair enough! [05:29] are you having trouble with it? [05:30] No problems at all, but if the sections like desktop et al were marked with header tags, I could use Orca's next heading/previous heading navigation commands to move between the different bug groups. [05:30] Without having to go through an entire list of bugs for a particular team before getting to the next one. [05:52] Good morning [06:18] good morning [06:30] bonjour didrocks [06:30] hey pitti, how are you? [06:31] quite fine, thank you! [06:32] fever and tired definitively behind you? [06:32] absolutely, yesterday was quite fine already [06:33] Hey didrocks, pitti! [06:33] Good moring! [06:34] good evening RAOF ;) [06:34] pitti: good :) [06:34] Gnome3 seems a bit broken today :( [06:36] Waarschuwing van vensterbeheer:Log level 8: gtk_style_context_save: assertion `GTK_IS_STYLE_CONTEXT (context)' failed [06:36] Waarschuwing van vensterbeheer:Log level 8: meta_color_spec_render: assertion `GTK_IS_STYLE_CONTEXT (context)' failed [06:36] it gets flooded :) [06:48] pitti, didrocks, RAOF good morning guys [06:49] beta2! beta2! [06:49] (freeze ;)) [06:50] hey rickspencer3 [06:50] oh, right! [06:50] bonjour rickspencer3! [06:51] hey didrocks [06:51] French Mafia testing going ok? [06:51] rickspencer3: it's under way. We already spotted some annoying more issues [06:51] didrocks, :( [06:51] well ... [06:51] :) [06:51] with the compiz ABI break, we need a window of at least 5 hours of build [06:51] so will be short! [06:51] it's good that the testing works [06:52] right, it's testing the testing :) [07:02] hey rickspencer3 didrocks and pitti...morning, Europeans. [07:02] hey jasoncwarner_ [07:02] hey jasoncwarner_ [07:03] hey jasoncwarner_ [07:03] hey didrocks :) going to be a good day, right? right? :) [07:04] * didrocks crosses fingers :) [07:04] jasoncwarner_: we already spotted regressions [07:04] I'm using the time tested and very scientific method called "THE SECRET" to will the universe to do what I want [07:04] so trying to keep people busy ;) [07:04] heh :-) [07:04] let's see if it works :p [07:04] didrocks: did all the branches land that you wanted to land? I saw the recap email and it looked like only some landed [07:05] didrocks: in the regressions, anything major? [07:06] jasoncwarner_: hum, some still worrying and which deserve a fix before pushing [07:06] didrocks: k...(pinging thumper) [07:07] jasoncwarner_: I bother it before you! :p [07:07] but I guess he's not around yet [07:07] him* [07:07] :) [07:08] yeah, I figure thumper tends to have like 10 pings right around this time.... [07:08] and first thing in my morning ;) [07:08] I'm sure he hates having me in this TZ ;) [07:08] hey didrocks how is compiz looking? we good to go on that? [07:08] I know you need a new build, but are you waiting on anything there? [07:09] jasoncwarner_: very good, I cherry-picked some other fixes from trunk yesterday [07:09] jasoncwarner_: and it's a wonderful life on that side :) [07:09] jasoncwarner_: it's still on the staging ppa for now [07:09] but there is an ABI break [07:10] that's why we need a solid window of 5 hours of upload/build [07:10] times for dependencies to build [07:10] then publish [07:10] then depends build… [07:10] publish… [07:10] and so on ;) [07:10] to not having a "zomg you broke the CD" [07:11] didrocks: You can't stage that in a PPA? [07:11] That worked pretty well for the X transition. [07:11] RAOF: we have that in a ppa, but there is no dbgsym package built, pkgbinarymangler isn't as well, right? [07:12] I'm not sure, actually. [07:12] RAOF: will be nice next cycle with -proposed opened [07:12] Not building the dbgsym packages would be annoying, and you'd obviously need a non-virtualised PPA. [07:13] hyperair: hey, btw, UNE doesn't exists anymore, no more need to move banshee .desktop file to /usr/share/une/applications [07:13] RAOF: yeah, kind of late for this cycle to change the process I would say [07:13] didrocks: oh okay, thanks for the notice. [07:13] didrocks: Yeah, perhaps. [07:13] hyperair: no worry ;) [07:13] RAOF: but definitively something on my list for next cycle (/me looks at -proposed) [07:14] Yeah, if -proposed is open then that's even better. [07:29] didrocks: BTW, as we'll be frozen tomorrow, I'd appreciate if you could upload the new compiz galore to precise-proposed [07:29] didrocks: we can accept it there, let evrything build, and move it to precise in one step, to avoid archive inconsistency for half a day again [07:29] pitti: to -proposed? [07:29] didrocks: does that sound ok? [07:29] it's opened? [07:29] didrocks: well, technically it's open all the time [07:29] didrocks: but you can't accept pacakges while precise is not frozen [07:29] ah ok ;) [07:30] but for beta-2 it will be, so bug 930217 doesn't hit [07:30] Launchpad bug 930217 in launchpad "Make proposed pocket useful for staging uploads" [Low,Triaged] https://launchpad.net/bugs/930217 [07:30] rickspencer3: ^ FYI [07:30] but that would mean that they will be accepted tonight? [07:30] that'll also be a real-world test drive for that approach [07:30] cjwatson: ^ FYI as well [07:30] at first (just after we are frozen) [07:30] didrocks: ah, I thought you were planning an upload tomorrow [07:30] didrocks: if you want to upload today, please go ahead [07:30] earlier >> test-driving [07:30] pitti: well, we don't know yet :) [07:31] and I don't want to break if the release team isn't happy with a safer upload tomorrow [07:31] ok [07:31] right now, we have regressions I would prefer we won't let them enters [07:31] what I mean is: correct >> earlier >> test driving :) [07:31] we'll know more in a couple of hours [07:32] will keep you in touch [07:32] cheers [07:49] thanks for the fyi pitti [07:49] also, can I say, "pretty cool" [07:50] that's a meaningful advance in our release process [07:51] * rickspencer3 steps away [07:56] pitti, can you upload CUPS to Debian and Ubuntu? Thanks. [07:57] pitti, Sweetshark good morning. [07:57] pitti, Sweetshark I added a testcase to bug 916291 . I think we can find a smaller set of packages to reproduce the problem [07:58] Launchpad bug 916291 in libreoffice "failed to upgrade from Oneiric to Precise: ERROR: Cannot determine language! - exit status 134" [Critical,Triaged] https://launchpad.net/bugs/916291 [07:58] but at least with this packages, the upgrade crashes systematically [07:58] *these === tkamppeter_ is now known as tkamppeter [08:01] jibel: bonjour! thanks for this [08:02] RAOF: there has been no recent change in mesa/intel driver? [08:09] didrocks, last change to mesa was the 17th, which was just a dependency tweak. -intel hasn't received a change since the 15th of Feb. [08:10] ok, thanks ;) [08:10] didrocks, mesa 8.0.2 was released yesterday and is on the docket but hasn't landed yet [08:10] bryceh: we are seeing a crash in the driver right now [08:10] which driver? [08:10] getting the dbgsym stacktrace [08:10] ah the mesa/intel driver [08:11] right [08:11] https://pastebin.canonical.com/62804/ [08:11] didrocks, the main crash we've been seeing there is the intel_miptree_release() bug (#926379) [08:11] ok, it's the same :) [08:12] pretty much all the other mesa bugs we're tracking are random (non-crash) gunk - https://bugs.launchpad.net/ubuntu/+source/mesa?field.tag=precise&field.tags_combinator=ALL [08:12] bryceh: thanks for the link :) [08:13] didrocks, I repro'd the bug on my own hardware using an instrumented mesa, and collected debug data. Waiting for advice from upstream, but might dig in further if I have time. [08:14] anyway, nite. [08:14] bryceh: have a good night! and thanks again ;) [08:21] pitti, hi [08:21] hello tkamppeter [08:22] pitti, can you upload cups-filters and cups to Debian and Ubuntu? Thanks. [08:22] yes, at it; I'm currently updating my chroots [08:44] didrocks: I feel really bad at pinging you, but I have to: does the new unity fix the resizing area again, or is that a gtk bug? [08:44] (bug 160311) [08:44] Launchpad bug 160311 in metacity "Resizing windows by grabbing window borders is difficult" [Low,In progress] https://launchpad.net/bugs/160311 [08:44] pitti: it fixes it [08:44] for 3D I mean (I know it has always been broken in 2d) [08:44] didrocks: \o/ [08:44] pitti: you had this only if you didn't install mutter [08:44] which is the case rarely isn't it? :p like just in the default install ;) [08:45] yeah, will still be broken in 2d though [08:45] didrocks: cheers! [08:45] ;) [08:45] * didrocks goes back to this crash on startup… [08:45] * pitti hugs didrocks, merci [08:46] * didrocks hugs pitti back [08:46] bryceh: hi! can bug 926379 be related to those invalid writes (valgrinding compiz): http://paste.ubuntu.com/886919/ ? [08:46] Launchpad bug 926379 in xserver-xorg-video-intel "compiz crashed with SIGSEGV in intel_miptree_release()" [Critical,Confirmed] https://launchpad.net/bugs/926379 [08:47] before opening a wishlist bug report: is the new GTK color picker just a stop gap? → http://img.xrmb2.net/images/709325.png [08:47] (the old one looked like this: http://img.xrmb2.net/images/620480.png) [08:47] ricotz, FYI the g-k update in gnome3 ppa did not fix my problem, still asking for the ssh password when I do "git pull" [08:48] oh and since last update, now in gnome-shell, windows decoration is just black bar [08:51] hey [08:51] xclaesse, have you tried to confirm your g-k problem with the ubuntu packages? (make sure to revert all g-k related packages) [08:51] * pitti hugs seb128 [08:52] * seb128 hugs pitti [08:52] salut seb128 [08:52] hello everyone [08:52] pitti, happy beta2 freeze day? ;-) [08:52] hey didrocks, ricotz [08:52] hey ricotz, guten Morgen [08:52] seb128: and to you! [08:52] pitti, how are you today? [08:53] seb128: splendid, thanks! just a bit scared about how much stuff there is still to do.. [08:53] xclaesse, could to toggle the window-manager theme? when you are not using adwaita -- might be a graphics card driver problem if you are using a propritary one? [08:53] pitti, don't tell me! [08:54] pitti, libreoffice natty amd64 build turned out well, /me added another builder to the "good" list ;) [08:54] ricotz: yay! king it is [08:54] ricotz, it's intel chipset here [08:54] ricotz, changing theme does nothing [08:55] xclaesse, hmm, any other x related ppas active? [08:55] ricotz, but I see there is a mutter update now, but that would remove gnome-shell... I guess I should wait for the update batch to be done [08:55] xclaesse, ah, you are still on .90? [08:55] better wait for .92 then [08:55] gnome-shell is .90 yes [08:57] ricotz, oh, I see vuntz has that same problem actually [08:57] so that would be upstream [08:57] xclaesse: look at your ~/.xsession-errors :-) [08:57] on intel too? [08:58] vuntz, ah, right, lots of warnings [08:58] ricotz: yes [08:59] switching windows/workspace is also not smooth anymore [08:59] maybe related [08:59] vuntz, didnt see it here [08:59] but i am on a newer mesa, i guess [08:59] ricotz, gnome-shell .92 is already uploaded? [08:59] xclaesse, yes [08:59] good [09:00] hi, could someone take a look at bug #943279? We have a brand new default VNC client without any translation templates, and that's rather ugly. [09:01] Launchpad bug 943279 in remmina "Remmina i18n support problems" [Undecided,New] https://launchpad.net/bugs/943279 [09:01] good morning everyone [09:01] hey chrisccoulson [09:01] how are you? [09:01] hey chrisccoulson [09:01] kelemengabor, looking [09:02] thanks! [09:02] hi seb128, pitti, how are you? [09:02] chrisccoulson: I'm great, thanks [09:04] pff, ppa-purge to remove gnome3 ppa wants to remove all gnome packages... :( [09:05] chrisccoulson, I'm good thanks [09:08] chrisccoulson, btw did you plan to look at totem for the bug you pointed the other day? if not I will put on my list for today [09:08] seb128, i might not be able to look at it today, as i've got a new firefox release to deal with [09:08] kelemengabor, btw thanks for all the work you put into those translation bugs [09:09] chrisccoulson, ok, I'm taking it, beta2 freeze is in 12 hours or so [09:09] thanks [09:09] seb128: you are welcome :) [09:25] hmmm, is porter-armel down? [09:26] * Sweetshark wonders if he killed the littlun with a libreoffice build. [09:28] .oO(thanks aptitude for removing bzr, who needs that anyway in ubuntu development) [09:42] ricotz, FYI, I reverted all packages from gnome3 ppa to the version from precise, so I have g-k 3.2.2, and git pull still asking for the password [09:42] even after restarting the session [09:44] xclaesse, so something might be wrong with you setup [09:45] xclaesse, could be useful to create a separate clean user profile to test/confirm with [09:48] xclaesse, for me it is working fine here with ssh and gpg keys [10:05] ricotz, checking gnome-session-properties, and I don't see ssh agent started there [10:05] ricotz, shouldn't it include gnome-keyring something? === fenris is now known as Guest95871 [10:09] xclaesse, we hide system services from the session properties dialog [10:15] pitti: can we get 3.5.1-1ubuntu1 into the distro now? all but armel succeeded building. [10:15] I am trying to look into the armel thing, but the porter box seems to be down now. [10:15] Sweetshark: what do you mean? it is already in precise [10:16] pitti: duh [10:16] * Sweetshark takes his meds. [10:16] ;) [10:17] seb128, ah ok [10:17] ricotz, ah, mutter/gnome-shell updated now, and black bar is fixed :) [10:17] vuntz, ^ [10:17] tkamppeter: FTR, sid is currently broken, need to wait a bit (pcre3) [10:19] xclaesse: weird, I'm up-to-date and I see this; I might need to log out and log in again [10:37] pitti, what does "pcre3" mean? [10:37] pitti, should the packages be uploaded Ubuntu-only then? [10:37] tkamppeter: Debian uploaded a bad pcre3 library yesterday, which pretty much breaks everything [10:38] tkamppeter: a fix is already in place, but it still needs a couple of hours to land [10:38] tkamppeter: if it's urgent, then you can do that [10:38] pitti, it simply should go before beta2 freeze. [10:53] tkamppeter: so better upload it now [10:58] can anyone give me a hand with lighdm, I'm not able log in with my account (mandel) and I had to install gdm to be able to use my machine, my lightdm logs are the following: http://paste.ubuntu.com/894951/ [10:58] you will see that I can log as a guest which I used to su to my account which has sudo right and install gdm [11:05] pitti, are you using a German or an English UI? [11:05] tkamppeter: German [11:05] pitti, can you enter the command "lpstat -r" and tell me the output? [11:06] $ lpstat -r [11:06] scheduler is running [11:07] pitti, do you have any German translated output from CUPS command line tools? [11:07] seb128, hi [11:07] tkamppeter, hey [11:07] tkamppeter: I don't; ./locale/cups_de.po does not actually have any translations [11:08] tkamppeter: well, some, but only very few [11:08] seb128, I assume that you have a French user interface. Can you run "lpstat -r" and post the output here? [11:08] tkamppeter, "scheduler is running" [11:09] seb128, thanks. [11:09] yw [11:09] tkamppeter: see /usr/share/cups/locale/fr/cups_fr.po [11:10] it seems nobody really bothered to actually translate those [11:10] pitti, seb128, it is because of bug 960496, for me (using English UI) updating of the PPDs of existing print queues works, for some other users not. [11:10] Launchpad bug 960496 in gutenprint "[Precise] [Regression] Cannot print on Epson CX3650" [Undecided,New] https://launchpad.net/bugs/960496 [11:11] tkamppeter: if I add a tranlation to /usr/share/cups/locale/de/cups_de.po, I get [11:11] $ lpstat -r [11:11] Steuerprogramm läuft [11:11] tkamppeter: i. e. the machinery is working, just all the translations are missing upstream [11:12] tkamppeter: eek, how do PPDs depend on translated client messages? that sounds wrong [11:13] pitti: bug #916892, seems it can be the cause that unity doesn't show up usb keys on the launcher anymore? [11:13] Launchpad bug 916892 in unity-distro-priority "gnome-disk-utility crashed with SIGSEGV in gdu_device_get_object_path()" [Undecided,Fix committed] https://launchpad.net/bugs/916892 [11:14] pitti, if you look into the postinst script of cups, /var/lib/dpkg/info/cups.postinst, you see that before the PPD update is started, at first it is checked whether the scheduler is running, analysing output of "lpstat -r", during the update routine there is heavy use of CUPS command line toools. [11:14] tkamppeter: it's running under LC_ALL=C, so that should work [11:15] if only programs would have something like an exit code, so that callers woudln't need to grep i18n'ed output [11:15] pitti, I see now. [11:18] pitti, the PPD updating part of the cups.postinst also checks with "ehich lpstat", "which llpinfo", and "which lpadmin" whether the command line tools are present. Can it happen that they are not present when cups gets configured? [11:19] tkamppeter: no, as cups depends on cups-client [11:23] dpm: hey David, how are you? [11:24] heya pitti, very well, thanks, yourself? [11:24] dpm: quite fine, thanks! [11:24] :) [11:24] dpm: do you have an opinion about bug 961065 ? [11:24] Launchpad bug 961065 in apport "[UIFE] Alert inappropriately refers to "program version" for internal errors" [Undecided,Fix committed] https://launchpad.net/bugs/961065 [11:24] looking... [11:24] dpm: I want to do an apport upload today before the freeze, either with or without that change [11:29] pitti, ok, it might be a bit of a pain to retranslate it, but I think it makes sense to do the change if it is to comply with the spec. I've commented on the bug. [11:29] dpm: thanks [11:30] pitti, will you send a heads up to the translators list, or do you want me to send it? [11:30] well, if you ask me like this... :) [11:30] but I guess I ought to do it as the uploader [11:30] ha, wrong way of asking :) [11:31] pitti: bug #916892, seems it can be the cause that unity doesn't show up usb keys on the launcher anymore? [11:31] Launchpad bug 916892 in unity-distro-priority "gnome-disk-utility crashed with SIGSEGV in gdu_device_get_object_path()" [Undecided,Fix committed] https://launchpad.net/bugs/916892 [11:32] hm, there is no such program like "gnome-disk-utility" [11:32] I suppose someone tampered with the bug title [11:32] didrocks: but yes, could be [11:32] Title: compiz crashed with SIGSEGV in gdu_device_get_object_path() [11:32] ah yes, that's more like it [11:33] it's on my radar, if I ever manage to get out of the mail/backlog/archive/bug swamp of this morning [11:33] pitti: [11:33] dpm: translators list is which exactly? [11:33] pitti: thanks :) [11:34] pitti, ubuntu-translators at lists dot u dot c [11:37] dpm: sent, thanks [11:38] cool, thanks pitti [11:38] does anyone here know the remmina upstream developer? He/she's set the translations to open in Launchpad, which is not a very good idea wrt quality [11:46] pitti, while reading the e-mail on the translators list, I've noticed that on https://translations.launchpad.net/apport/trunk/+translations-settings you can set the import settings to "Import template files" instead of "Import template files and translations" - the latter setting is generally for new projects that need a one-off import of PO files, or for vcs imports [11:47] dpm: sometimes I update po/de.po in the branch [11:47] and sometimes merges change them [11:47] so why wouldn't I let them auto-import back to LP? [11:51] pitti, in that case, then it's fine, I was just mentioning it in case, as many projects do not make use of it and maintainers just set it thinking it's the right setting. But as you say, you do make use of it. The only thing to bear in mind is that imports take precedence over translations done in the LP web UI [11:58] dpm: ok, thanks for having a look [12:00] that sucks. the UDS registration form doesn't work in nightly builds of Firefox === MacSlow is now known as MacSlow|lunch === Ursinha-away is now known as Ursinha [12:26] chrisccoulson, iz firefox bog! [12:26] firefox doesn't have any bugs! :-P [12:30] * mpt just encountered a very odd Firefox bug [12:31] (bug 799400) [12:31] Launchpad bug 799400 in firefox "message missing when trying to upload ureadable file" [Undecided,Confirmed] https://launchpad.net/bugs/799400 [12:39] seb128: hi. assuming gst 1.0 get released soon, i was wondering if moving to gst 1.0 in 12.10 is something doable, or not even an option... did you think about that already? [12:39] ndec_, hey, "lol" ;-) [12:40] lol ? [12:40] i didn't realize it was a joke! [12:40] ndec_, we are focussed on 12.04 [12:40] i know ... [12:40] so am i [12:40] for the OMAP part of it! [12:40] so "if", "assuming", "maybe", "could" [12:40] said differently no clue, it's too early to say [12:40] gst 1.0 is not out [12:40] UDS is not there yet [12:41] we are focussed on 12.04 I didn't give any thinking to 12.10 [12:41] it mostly depends what upstream people do, i.e totem, rhythmbox, banshee, pitivi, etc [12:41] it's the sort of "let's wait for gst1.0 to be out, let's wait to see how much work is porting an app, and let's see what happen" [12:42] thx [12:42] yw [12:42] ndec_, sorry but there is just too much "unknown" is that equation to have a reply and it's not the right timing in any case, we will probably discuss it at UDS [12:43] ndec_, do you need 1.0 for anything? I guess we will have it in the archive for sure for 12.10, I can't see how much we will port though... [12:43] seb128: no worry. i wasn't expecting a commitment, just a thought about feasibility! [12:43] basically i just wanted to hear that you were not strongly opposed to the idea [12:43] ndec_, I'm waiting for gst1.0 to be out first and to see how goes the first app porting [12:43] ndec_, ideally I would like to move to it if it's feasable [12:44] yeah, we kind of need gst1.0 for ARM SoC (at least the one i care about: OMAP) [12:44] ok, that's a good reason to push for it [12:44] we can get around with gst0.10.. but with 1.0 we can use upstream, and get rid of the pile of patches we have on 0.10 [12:44] ndec_, do you know what's the roadmap from the gst guys to have the stable out? [12:44] soon [12:44] ok [12:45] so yeah, starting to use it next cycle makes sense [12:45] I'm not sure how much we can "port" in one cycle though [12:45] if gst1.0 becomes stable and performance is better and xvimagesrc is ported to 1.0 then I'll switch too... [12:45] with Kazam. [12:46] so I'd be happy to see it in 12.10 too :) [12:53] seb128: sorry, I had to reopen bug #943279 - it's not perfect yet :( [12:53] Launchpad bug 943279 in remmina "Remmina i18n support problems" [High,Triaged] https://launchpad.net/bugs/943279 [12:54] kelemengabor, are you sure? [12:55] kelemengabor, I looked at the code, the plugins code use the "remmina" domain [12:55] kelemengabor, there is only one GETTEXT_PACKAGE defined in the soruce [12:55] http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/precise/remmina/precise/view/head:/remmina-plugins/po/CMakeLists.txt [12:55] kelemengabor, I think upstream is buggy [12:55] is this not redefining it? [12:56] I don't speak CMakeLists though, just assuming this based on the upstream... [12:56] kelemengabor, I don't speak CMakeLists either [12:57] let me check [12:57] seb128: nor should you learn :) [12:57] hey desrt, how are you ? [12:57] although.... i have to say... CMakeLists have a lot in common with french [12:57] good :) [12:58] desrt, looking to make friends today? ;-) [12:58] seb128: by your estimation, which group should be more insulted by that statement? :) [12:59] desrt, I think it's insulting the french! [12:59] ;-) [13:03] seb128, thx for the review! [13:03] seb128, please don't forget the other one though :) [13:03] kenvandine, hey, yw! [13:04] kenvandine, doh, thanks for pointing it, I didn't notice there were 2 of them, I went through by email a bit quickly [13:04] :) [13:04] you did the second one :) [13:04] https://code.launchpad.net/~ken-vandine/telepathy-indicator/lp_926072/+merge/98719 [13:04] after submitting that, i found that it also fixes 2 other fixes too :) [13:05] kenvandine, I'm reading it, do you care about old C compliance or are you C99? [13:05] i don't really care :) [13:06] kenvandine, i.e you did a variable declaration after the g_return_val_if_fail() [13:06] but don't mind cleaning it up [13:06] ah [13:06] I know some GNOME guys used to report bugs about those [13:06] saying it's a c99ish [13:06] ism [13:06] yeah, i did that on purpose... i like doing that before doing anything else [13:06] but i know not everyone agrees with that :) [13:07] kenvandine, ok, approved [13:07] thx! [13:07] yw ;-) [13:07] i think that makes all open bugs for tp-indicator fixed [13:07] :) [13:07] woot [13:07] hey kenvandine [13:07] \o/ [13:07]