[11:57] hey frankban. I just approved your holiday before Easter plus Easter Monday. Small request: when you put in a national holiday, please include the name of the holiday (Easter Monday for this one, for instance). [11:57] thank you gary_poster, I will do that [11:57] cool thanks [12:09] bac benji frankban gmb call in 2, or when I finish rebooting [12:14] bac ping [12:28] * benji installs 430 updates and hopes for the best. [13:02] frankban, I moved 609986 to "review". When you make the LP branch that upgrades the zope.testing version, you can self review if you want, or ask me for a quick review [13:03] gary_poster: ok [13:32] * benji performs the ancient and unpredictable ritual of rebootus-post-upgradus. [13:42] gary_poster: oh, a small note from yesterday: bin/test --shuffle does indeed report the seed it uses, so adding that to setuplxc was straight-forward [13:46] benji, great. Sorry for not noting that card on the board review. I saw lifeless' comments and I thought they were reasonable. Did you verify that his two concerns were addressed? [13:46] gary_poster: ooh, I didn't see his comments, let me go look [14:32] gary_poster: new diff with explosives: http://pastebin.ubuntu.com/902215/ [14:51] gary_poster: https://code.launchpad.net/~frankban/launchpad/bug-609986-add-zope.testing-3.9.4-p5/+merge/99536 [14:51] frankban, boom! :-) looking [14:51] thanks [14:53] frankban, approved, and diff looks good. [14:53] (explosive I mean) [14:53] thanks gary_poster, I am running tests now [14:53] great [14:56] wow, I am testing the tester fixed for parallel testing, that's a new meaning of the word "meta" [15:03] lol [15:05] yay! unity crash (and subsequent forgetting of my keybindings) [15:05] :-/ [15:19] gary_poster: oh, the answer to Robert's shuffle questions are that it works correctly (shuffling happens and is done inside layers, not across them). I'll reply to that effect. [15:41] awesome benji, yay [16:10] gary_poster: errors during the test run [17:03] frankban, :-/ easy resolution? [17:07] gary_poster: one problem is s/addSkip/addError in tear_down_not_supported: can you remember me why that's needed? Another one is a BAseLayer teardown error: http://pastebin.ubuntu.com/902490/ [17:10] I will start investigating tomorrow morning, I assume it's not possible that lp.testing.layers.BaseLayer is broken [17:28] frankban, it is definitely possible that BaseLayer is broken. s/addSkip/addError/ : that was one of those "we don't understand so let's hope gmb was right" things. I dunno. :-/ [17:29] frankban, but I wouldn't count out "if cls.fixture is not None: cls.fixture.cleanUp()" yet [18:13] Why has Firefox suddenly decided that I use Brittish spelling?