| jimbaker | hazmat, because the reverse diff i did against trunk to recover from lbox submit destroyed history, i'm going to propose branches again as new branches | 00:10 |
|---|---|---|
| jimbaker | unfortunately recovering from destroyed history is unfortunate | 00:22 |
| hazmat | jimbaker, huh? | 00:36 |
| hazmat | destroyed history? | 00:36 |
| hazmat | where? | 00:36 |
| hazmat | when you merged trunk back to your local branch | 00:36 |
| hazmat | you just reapply a reverse to your local branch | 00:36 |
| jimbaker | hazmat, please take a look at trunk r501 then 502 | 00:36 |
| hazmat | jimbaker, you merged and then reverted | 00:37 |
| jimbaker | hazmat, i have not yet merged trunk to the local branch | 00:37 |
| jimbaker | that is, my relation-id branch | 00:37 |
| jimbaker | but i'm not getting proper ancestor diffs against it | 00:38 |
| jimbaker | hazmat, so "destroyed" may be the wrong term, but it's certainly not readily usable | 00:38 |
| hazmat | jimbaker, generate a diff of your branch to the previous version of trunk 500 | 00:39 |
| hazmat | merge trunk | 00:39 |
| hazmat | reapply diff | 00:39 |
| hazmat | to your branch | 00:39 |
| hazmat | you will lose some of the history on your branch | 00:39 |
| hazmat | well as you say not lose, but garble | 00:39 |
| hazmat | but you'll have proper diffs | 00:40 |
| hazmat | and won't lose any work | 00:40 |
| hazmat | jimbaker, how's the rel-id work coming outside of that? | 00:41 |
| jimbaker | hazmat, is it reasonable that bzr diff -r ancestor:../../trunk produces an empty result? | 00:41 |
| jimbaker | hazmat, it is done | 00:41 |
| hazmat | jimbaker, can you push your latest.. i'll play around with it | 00:42 |
| jimbaker | hazmat, thanks | 00:42 |
| jimbaker | hazmat, it is pushed | 00:42 |
| jimbaker | i will push the other 3 branches too. they are also complete | 00:42 |
| jimbaker | in terms of responding to all reviews | 00:43 |
| hazmat | jimbaker, have you lbox propose -cr them? | 00:44 |
| jimbaker | hazmat, previously | 00:44 |
| jimbaker | hazmat, all branches have been pushed | 00:44 |
| hazmat | jimbaker, they should get reproposed if their not approved | 00:45 |
| * hazmat looks at rel-id | 00:45 | |
| jimbaker | hazmat, should i use lbox propose -cr? previously we discussed using lbox submit | 00:45 |
| jimbaker | for this purpose | 00:45 |
| jimbaker | hazmat, i will be back in about 1 hour, kids need to eat dinner | 00:49 |
| hazmat | jimbaker, lbox submit merges | 00:49 |
| hazmat | jimbaker, when was that? | 00:51 |
| hazmat | jimbaker, here's a diff of your branch against r500 http://paste.ubuntu.com/906490/ | 00:51 |
| hazmat | you can merge trunk and reapply the diff, there's 4 conflicted files | 00:52 |
| hazmat | that need manual attention | 00:52 |
| hazmat | jimbaker, please submit rel-id for review again after you've merged trunk and reapplied the diff, i'd like to double check the merge | 00:53 |
| TheMue | rogpeppe: morning | 09:23 |
| rogpeppe | TheMue: hiya | 09:24 |
| TheMue | rogpeppe: just proposed the new config watch, looks nice | 09:24 |
| TheMue | rogpeppe: now i'm off for some hours, family needs me | 09:24 |
| rogpeppe | TheMue: i don't see any email | 09:24 |
| rogpeppe | TheMue: have you got a codereview link? | 09:25 |
| TheMue | rogpeppe: strange, google lags ;) | 09:25 |
| rogpeppe | TheMue: ok, see you later | 09:25 |
| rogpeppe | TheMue: i refreshed too | 09:25 |
| TheMue | rogpeppe: https://codereview.appspot.com/5885059/ | 09:26 |
| rogpeppe | TheMue: thanks | 09:26 |
| fwereade_ | hazmat, btw, did you ever resolve the can't-actually-bootstrap-with-constraints problem you saw yesterday? | 13:28 |
| rogpeppe | lunch | 13:28 |
| hazmat | fwereade_, no.. i'm not able to bootstrap on ec2 with warned-ignore-constraint branch | 13:45 |
| hazmat | fwereade_, it looks like some app failures | 13:46 |
| fwereade_ | hazmat, bah... and it's definitely neither a juju-origin nor a PYTHONPATH problem? | 13:46 |
| fwereade_ | hazmat, sorry, "app failures"? | 13:46 |
| hazmat | fwereade_, er.. apt | 13:46 |
| fwereade_ | hazmat, huh, weird... I don't think I changed anything related to that | 13:47 |
| fwereade_ | hazmat, wasn't niemeyer talking to you about having some problem like that himself the other day? | 13:48 |
| hazmat | fwereade_, i'm able to deploy envs with trunk without issue | 13:48 |
| fwereade_ | hazmat, ++weird | 13:49 |
| hazmat | hmm.. pythonpath.. | 13:49 |
| hazmat | that was in a virtualenv.. indeed | 13:49 |
| * hazmat tries again | 13:50 | |
| hazmat | fwereade_, yeah.. looking over the cloud-init on the instance i don't see the constraints so that is likely the issue.. user error ;-) | 13:50 |
| * fwereade_ looks relieved | 13:51 | |
| hazmat | bbiam | 13:51 |
| hazmat | fwereade_, hm.. even with the correct branch its hanging | 14:16 |
| hazmat | although its not clear that this problem has anything to do with the branch | 14:16 |
| fwereade_ | hazmat, do you know what's hanging? could it just be a grumpy EC2? | 14:16 |
| hazmat | vs. an apt or repo issue | 14:16 |
| hazmat | fwereade_, its failing doing a package install | 14:17 |
| fwereade_ | hazmat, ah ok | 14:17 |
| fwereade_ | hazmat, do you know what package? | 14:17 |
| fwereade_ | hazmat, (not that that's actually going to tell me anything useful I can think of...) | 14:17 |
| hazmat | fwereade_, hm. there are two.. | 14:20 |
| hazmat | CalledProcessError: Command '['apt-get', '--option', 'Dpkg::Options::=--force-confold', '--assume-yes', 'update']' returned non-zero exit status 100 | 14:20 |
| hazmat | bzr: ERROR: Invalid url supplied to transport: "bzr+ssh://bazaar.launchpad.net/~fwereade/juju/warn-ignored-constraint": no supported schemes | 14:21 |
| fwereade_ | hazmat, huh, never seen anything like those before :( | 14:21 |
| hazmat | fwereade_, also happens on trunk :-( | 14:27 |
| fwereade_ | hazmat, ha, that's one of those things that would be a relief if it weren't an "OH CRAP" | 14:27 |
| hazmat | fwereade_, indeed :-) | 14:27 |
| hazmat | fwereade_, the repo issue is being looked into by ben and scott, its something their aware of | 14:49 |
| hazmat | the bzr issue is odd as well | 14:49 |
| fwereade_ | hazmat, http://search.dilbert.com/comic/Actively%20Waiting | 14:50 |
| fwereade_ | ;) | 14:50 |
| fwereade_ | hazmat, bzr is very weird | 14:51 |
| hazmat | it feels like a regression of some sort | 14:51 |
| hazmat | fwereade_, oh.. | 14:51 |
| hazmat | your branch might be private | 14:51 |
| hazmat | that would explain it | 14:51 |
| hazmat | fwereade_, yeah.. i can bzr branch lp:juju but not your branch.. | 14:52 |
| fwereade_ | hazmat, gaaah, sorry | 14:52 |
| hazmat | that's just from the anon perspective.. that's odd though | 14:53 |
| TheMue | rogpeppe: next watcher version is in the box | 14:53 |
| fwereade_ | hazmat, I've merged everything except the doc changes into shadow-trunk-1204; I'll go and peer at that on launchpad and see if I can figure out what to do | 14:53 |
| rogpeppe | TheMue: cool | 14:53 |
| fwereade_ | hazmat, ...and hey, how did it ever work for me if that's the problem? | 14:53 |
| hazmat | fwereade_, good question | 14:54 |
| rogpeppe | TheMue: i've got the email this time. previous one must have been lost in transit sometime | 14:54 |
| fwereade_ | hazmat, hey, it's "warn-ignored-constraints" | 14:54 |
| fwereade_ | hazmat, your error message was missing the terminal s | 14:54 |
| hazmat | fwereade_, yeah.. i was just reading about the relevant bug | 14:54 |
| hazmat | bug 854713 | 14:54 |
| hazmat | oh.. no mup here | 14:55 |
| hazmat | https://bugs.launchpad.net/bzr/+bug/854713 | 14:55 |
| SpamapS | hazmat: am I reading the tea leaves correct that this is the final bit for subordinates: https://code.launchpad.net/~bcsaller/juju/subordinate-control-status/+merge/98088 ? | 14:55 |
| fwereade_ | hazmat, icky :) | 14:55 |
| hazmat | SpamapS, there's one more branch out for subordinates in addition to that one | 14:56 |
| hazmat | that branches pre-requisites have been merged though | 14:56 |
| hazmat | so just sub-status and sub-agent branches | 14:56 |
| TheMue | rogpeppe: at least the link worked and i got your helpful comments | 15:02 |
| rogpeppe | TheMue: LGTM (with a couple of minor comment issues) | 15:04 |
| TheMue | rogpeppe: thx | 15:05 |
| rogpeppe | TheMue: i'm very happy how this is starting to look | 15:06 |
| TheMue | rogpeppe: "observices"? oh no! seems like a bad mixture of observes and service. | 15:06 |
| TheMue | rogpeppe: *lol* | 15:06 |
| TheMue | rogpeppe: having a native speaker as lector is really helpful. | 15:10 |
| TheMue | rogpeppe: thx | 15:10 |
| rogpeppe | TheMue: np | 15:10 |
| jimbaker | hazmat, did you have a chance to look at the most recent relation id branches in rietveld (there are 4)? also thanks for helping me recover relation-id with respect to trunk! | 15:38 |
| hazmat | jimbaker, not yet, i haven't seen updated reitveld reviews for them outside of id | 15:39 |
| hazmat | jimbaker, http://codereview.appspot.com/user/jimbaker ic them here though. its helpful to actually use a description on these. | 15:40 |
| jimbaker | hazmat, np, i don't know why we have Issue 5900068: <please have a summary here> | 15:41 |
| jimbaker | it has a description, not just a summary - and i'm quite certain it had one in the editor. i'll see if i can change that | 15:42 |
| jimbaker | need to work on lbox fu i suppose | 15:42 |
| hazmat | jimbaker, don't worry about it, i think your not supposed to edit it | 15:53 |
| hazmat | lbox may use it for sync with the mp | 15:53 |
| hazmat | at least the mp always says don't edit it | 15:53 |
| jimbaker | hazmat, ok... we will see how it works out. i hope it uses something besides text to link (since i did edit it!) | 15:54 |
| hazmat | no idea | 15:54 |
| hazmat | jimbaker, the src is only a lp:lbox away | 15:54 |
| jimbaker | hazmat, yeah, i will think about that ;) | 15:55 |
| hazmat | fwereade_, i think its probably good to merge the shadow branch and deal with the docs merge later | 16:08 |
| hazmat | fwereade_, docs reviewed | 16:30 |
| hazmat | hmm.. looks like the sub-status/sub-agent are updated in reitveld yet | 16:32 |
| * hazmat moves on to rel-id | 16:32 | |
| jimbaker | hazmat, thanks | 16:32 |
| fwereade_ | hazmat, sweet | 16:35 |
| fwereade_ | hazmat, I'll make sure it's up to date, retest, and do a propose for form's sake | 16:36 |
| hazmat | fwereade_, sounds good, but are you sure your not just going for the biggest merge medal :-) | 16:47 |
| fwereade_ | hazmat, heh, now I know there is one that's totally what I'm doing :p | 16:48 |
| fwereade_ | hazmat, https://code.launchpad.net/~fwereade/juju/shadow-trunk-1204/+merge/100195 | 16:56 |
| fwereade_ | hazmat, it's only also on rietveld because I wanted to see what it looked like :p | 16:57 |
| hazmat | jimbaker, i'm seeing alot of errors running tests against the rel-id branch | 17:00 |
| jimbaker | hazmat, let me check that | 17:01 |
| jimbaker | (i ran test multiple times... but... let's see it run once more) | 17:01 |
| hazmat | jimbaker, i did a pull.. but it seems to be in the scheduler code.. | 17:04 |
| hazmat | File "/home/kapil/canonical/ensemble/jimbaker/relation-id/juju/hooks/scheduler.py", line 185, in __init__ | 17:04 |
| hazmat | self._relation_ident = relation_ident | 17:04 |
| hazmat | exceptions.NameError: global name 'relation_ident' is not defined | 17:04 |
| * hazmat checks his branch for previous gymnastics causing foobar | 17:05 | |
| fwereade__ | eyup, he's got an off-brand file path there | 17:05 |
| hazmat | jimbaker, yeah.. sorry it was my gymnastics to get a good diff earlier that seem to have cause the issue | 17:05 |
| hazmat | fwereade__, sadly not they weren't cleanly relocatable | 17:06 |
| hazmat | pipelines end up recording fullpaths | 17:06 |
| hazmat | i saved the juju one for golang ;-) | 17:06 |
| fwereade__ | hazmat, haha, nice | 17:06 |
| fwereade__ | hazmat, if you'd give me an ultra-quick form approval on that branch I'll submit before I go out | 17:06 |
| jimbaker | hazmat, it's running cleanly for me. quick check, on your diffstat are you getting 10 files changed, 201 insertions(+), 99 deletions(-) ? | 17:08 |
| fwereade__ | hazmat, (not sure why, it feels wrong for me to do it myself) | 17:08 |
| hazmat | fwereade__, fair enough | 17:08 |
| hazmat | jimbaker, see above comments, it was caused from me generating the diff | 17:09 |
| hazmat | tests are running fine now | 17:09 |
| jimbaker | hazmat, that's a relief | 17:09 |
| * hazmat wonders if we can hit 2k tests b4 the release | 17:10 | |
| jimbaker | hazmat, certainly getting close | 17:11 |
| hazmat | fwereade__, that's hillarious re actively waiting comic | 17:13 |
| hazmat | fwereade__, approved | 17:16 |
| fwereade__ | hazmat, many thanks, submitting now | 17:17 |
| hazmat | jimbaker, rel-id looks good | 17:23 |
| hazmat | bcsaller, the sub-status and sub-agent need to be lbox proposed again if their ready for review | 17:23 |
| * hazmat looks for some food, bbiab | 17:23 | |
| bcsaller | hazmat: not quite ready | 17:24 |
| jimbaker | hazmat, thanks | 17:24 |
| jimbaker | hazmat, any more feedback on the other relation id branches? | 20:17 |
| hazmat | jimbaker, not yet | 20:28 |
| jimbaker | hazmat, ok | 20:28 |
| wrtp | niemeyer: how ok is gocheck with concurrency? | 21:33 |
| niemeyer | wrtp: In which regard? | 21:34 |
| wrtp | niemeyer: if a test runs a new goroutine that then does an Assert, what happens? | 21:34 |
| wrtp | (when the assert fails, that is) | 21:34 |
| niemeyer | wrtp: The same thing that with testing | 21:35 |
| niemeyer | wrtp: It'd attempt to panic such a goroutine, which would cause bad things to happen | 21:35 |
| wrtp | niemeyer: i don't know the situation with testing actually. | 21:35 |
| niemeyer | wrtp: It's ok with concurrency, but the panic-on-unknown-goroutine is a hard one to handle | 21:35 |
| wrtp | niemeyer: ah, it throws a panic rather than using runtime.Goexit() ? | 21:35 |
| niemeyer | wrtp: It uses Goexit actually, for now, but still it's not g | 21:36 |
| niemeyer | reat | 21:36 |
| wrtp | niemeyer: i think that would probably work ok | 21:36 |
| wrtp | niemeyer: for me anyway | 21:36 |
| niemeyer | wrtp: It continues running, and which invalidates the point of using assert | 21:36 |
| wrtp | niemeyer: i can have a chan in the goroutine that gets closed when the goroutine goexits | 21:37 |
| wrtp | niemeyer: hmm, what happens if you get two asserts that fail? does it mind? | 21:37 |
| niemeyer | wrtp: it doesn't mind, but I'll probably mind having to maintain that logic :) | 21:38 |
| niemeyer | wrtp: Just do something usual | 21:38 |
| wrtp | niemeyer: the alternative is to pass errors back down a channel | 21:38 |
| niemeyer | wrtp: Sounds fine | 21:38 |
| wrtp | niemeyer: which might be the best course. i just wondered if it might be reasonable to use assert. | 21:38 |
| wrtp | niemeyer: it would read well, i think. | 21:39 |
| wrtp | niemeyer: by not using Assert, i lose the context for the error, which is a pity. | 21:40 |
| niemeyer | wrtp: You can error there | 21:41 |
| niemeyer | wrtp: Error, I mean | 21:41 |
| niemeyer | wrtp: or Check, in that case | 21:41 |
| wrtp | niemeyer: yeah, Check would make things more obvious, i guess | 21:41 |
| wrtp | although: c.Assert(err, IsNil) isn't quite as nice as if !c.Check(err, IsNil) { return } | 21:43 |
| wrtp | niemeyer: if you think of each new goroutine as a new test, the TestFoo function as a kind of "main", and the result being the boolean OR of all the test results before TestFoo returns, it makes quite a bit of sense actually. | 21:51 |
| wrtp | niemeyer: it scales to goroutines quite nicely. | 21:51 |
| niemeyer | wrtp: I don't think of each goroutine as a new test | 21:51 |
| wrtp | niemeyer: i'm thinking of them a sub-tests | 21:52 |
| wrtp | s/ a / as / | 21:52 |
| niemeyer | wrtp: c.Assert == t.Fatal if it fails.. a fatal that isn't fatal is bogus | 21:53 |
| wrtp | niemeyer: fatal to what? | 21:53 |
| niemeyer | wrtp: t.Fatal | 21:53 |
| wrtp | what's t.Fatal? | 21:53 |
| niemeyer | wrtp: Please check out the testing package | 21:54 |
| wrtp | i know that Fatal, ok | 21:54 |
| wrtp | but again, fatal to what? what's dying? the test has multiple pieces that can die individually | 21:55 |
| wrtp | niemeyer: i think it works quite well to think of it that way. it means that tests can scale up to concurrency well. | 21:56 |
| niemeyer | wrtp: Please actually do read the docs | 21:56 |
| niemeyer | wrtp: That's not what Fatal or Assert means, and I'm not keen on changing their meaning | 21:57 |
| wrtp | niemeyer: yeah, FailNow could do with an updated doc. "FailNow marks the function as having failed and stops its execution. Execution will continue at the next test or benchmark when the original Test function finishes" | 21:58 |
| wrtp | niemeyer: it would be nice if Fatal/FailNow/Assert could have a useful meaning in a concurrent test | 21:58 |
| wrtp | niemeyer: here's a flavour of how the two approaches look side by side: http://paste.ubuntu.com/907926/ | 22:07 |
| wrtp | niemeyer: ah! i can define my own assert that calls Check and Goexits if it fails. | 22:18 |
| niemeyer | wrtp: I'd rather have it inlined in the test, and simple | 22:57 |
| wrtp | niemeyer: it is simpler as an assert - not as much control structure to get right. | 22:58 |
| niemeyer | I'm heading off for dinner.. laters all, or see you all on Monday | 22:58 |
| wrtp | niemeyer: see you in 10 days! | 23:01 |
| wrtp | niemeyer: have a good week. | 23:01 |
| wrtp | have a great Easter, everyone | 23:04 |
| wrtp | see you in a bit | 23:04 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!