| salgado | wgrant, how http://paste.ubuntu.com/915336/ looks as a fix for that? | 00:02 |
|---|---|---|
| StevenK | rick_h: 10UTC is 8pm. | 00:03 |
| StevenK | rick_h: I'll ping you at about 8pm, and if it's just us we'll skip it. | 00:03 |
| rick_h | StevenK: sorry, went off of this http://everytimezone.com/#2012-4-4,-120,6be and you're in Sydney right? according to the directory | 00:04 |
| StevenK | rick_h: Yup, I am. | 00:05 |
| wgrant | salgado: Looks reasonable. | 00:06 |
| wgrant | salgado: I didn't look further once I found that one, so there may be more holes. | 00:06 |
| salgado | wgrant, the other possible uses of 'structure' in that template will render either a format_link(obj) or a string that's hard-coded in the template (e.g. Nobody, N/A) | 00:08 |
| wgrant | salgado: That's what I thought, great. | 00:11 |
| wgrant | That sort of thing is strongly discouraged nowadays, but this particular case seems fairly safe. | 00:11 |
| salgado | yeah, I should've remembered that | 00:16 |
| wgrant | lifeless: Since you're probably the only Stormy person around, https://code.launchpad.net/~wgrant/storm/psycopg2-2.4-pgbouncer/+merge/100896 would enjoy your review. | 00:18 |
| salgado | wgrant, so, would you like to review that whole branch or should I just pester StevenK to review the incremental changes? | 00:28 |
| wgrant | salgado: I'll glance over it but don't really have time to review the whole thing properly immediately. | 00:30 |
| * wallyworld_ goes to get more coffee so there is not a shortage over the extended Easter break | 00:57 | |
| nigelb | ws 10 | 01:00 |
| nigelb | urgh | 01:00 |
| salgado | wgrant, ok, that's fine | 01:05 |
| StevenK | salgado: While I remember, you guys do need to fill out [r=santa] or [bug=1], our tools will do it for you when we go to land it. | 01:05 |
| StevenK | Sigh. Do *not* need to fill out | 01:05 |
| salgado | oh, cool | 01:05 |
| salgado | wgrant, StevenK, so, if you guys are happy with https://code.launchpad.net/~linaro-infrastructure/launchpad/team-engineering-view-ui/+merge/100707 would you mind ec2-landing it for me? | 01:07 |
| salgado | if not just tell me why and I'll fix it :) | 01:09 |
| salgado | late dinner now | 01:09 |
| === salgado is now known as salgado-afk | ||
| lifeless | wgrant: sorry, I won't get to that today | 03:23 |
| lifeless | wgrant: stub will be around noos | 03:23 |
| * wgrant out for a while. | 03:40 | |
| * StevenK tries take two at finding a vocab that backs onto an enum | 04:11 | |
| StevenK | stub: Hai. wgrant is out for a while, can you glance at https://code.launchpad.net/~wgrant/storm/psycopg2-2.4-pgbouncer/+merge/100896 ? | 04:38 |
| wgrant | stub: Could you glance over https://code.launchpad.net/~wgrant/storm/psycopg2-2.4-pgbouncer/+merge/100896? | 05:53 |
| wgrant | Storm reviewers are a little hard to come by in this TZ | 05:53 |
| stub | wgrant: already done | 06:07 |
| wgrant | stub: Oh, indeed. Thanks. | 06:10 |
| wgrant | The default isolation change seems happy with that fix. | 06:10 |
| * wgrant ec2s | 06:10 | |
| stub | Cool. We still have a forked Storm I think, so we don't need to delay on a release. | 06:12 |
| wgrant | Yeah, already merged that up and built a new egg. | 06:13 |
| lifeless | have a good weekend y'all | 06:21 |
| lifeless | stub: you get a pass on catchup today, I can't be arsed ;) [unless you have something specific to cover] | 06:22 |
| bigjools | have a nice easter lifeless | 06:22 |
| stub | wgrant: Staging seems happy enough after I bumped that lock count up to 1024 (default is 64). The isolation level change is still my preferred solution though. | 06:23 |
| wgrant | Night lifeless. | 06:25 |
| wgrant | stub: Yeah | 06:25 |
| wgrant | stub: We'll see how much of a difference it makes | 06:25 |
| wgrant | stub: Do we graph pg_locks size? | 06:25 |
| stub | lifeless: If interest, we seem to have run out of disk space on staging. We no longer quite have enough space for 5 full copies of the production database. Freshly build, they clock in at 320GB. I don't know if it is database size growth over the last 3 weeks putting us over the edge, or if 9.1 is a little bigger. But that doesn't really matter. | 06:26 |
| stub | wgrant: No | 06:26 |
| wgrant | stub: https://code.launchpad.net/~wgrant/launchpad/psycopg2-2.4.4/+merge/100912 and https://code.launchpad.net/~wgrant/launchpad/9.1-serializable-is-special/+merge/100913 | 06:31 |
| lifeless | stub: theories? different fill rate? | 06:36 |
| lifeless | /dev/cciss/c1d0p1 808G 381G 419G 48% /srv | 06:37 |
| lifeless | so we have enoughspace to migrate on widcherry | 06:37 |
| stub | wgrant: Both of those are approved | 06:37 |
| wgrant | stub: Thanks. | 06:38 |
| stub | lifeless: production isn't an issue, if there is an increase, it is <10%. Just when we multiply that by 5... | 06:38 |
| stub | I can't know for sure unless I restore a dump onto an 8.4 system, which I haven't done. | 06:38 |
| lifeless | you could bring up a canonistack instance to try | 06:39 |
| wgrant | We'll have space to do that on sourcherry once the restore is done and we're down to 3 DBs, right? | 06:39 |
| stub | lifeless: I don't have enough historical details to tell. | 06:39 |
| wgrant | Can bring back the 8.4 instance for a few hours | 06:39 |
| stub | lifeless: yes, or chokecherry has enough disk I think. | 06:39 |
| lifeless | or wild :P | 06:40 |
| stub | lifeless: But the why isn't really an issue | 06:40 |
| stub | Interesting, but doesn't change the situation as it isn't severe enough to block PG 9.1 migration | 06:40 |
| stub | Staging updates are the problem. I can change the process a bit to lose one full copy, but that work needs to be done. | 06:42 |
| stub | (Swap the new staging databases into place *before* the replica has build, which isn't too much of an issue as it is usually only done on weekends) | 06:43 |
| * stub wonders why he is consistently typing 'build' instead of 'built' today. | 06:43 | |
| stub | mthaddon, lifeless: Looks like db growth. Just noticed qastaging's db is 305GB while the freshly built lpmain_staging is 316GB. Should have picked that up before. | 07:06 |
| === almaisan-away is now known as al-maisan | ||
| adeuring | good moorning | 07:53 |
| czajkowski | adeuring: ello | 08:03 |
| mabac | hi all. :) so https://code.launchpad.net/~linaro-infrastructure/launchpad/team-engineering-view-ui/+merge/100707 was backed out and the branch has been fixed up. how do we go about re-landing it? | 08:06 |
| mabac | should the last revision be reviewed or can the change simply be landed again? | 08:14 |
| nigelb | StevenK, wgrant: http://pic.nym.se/nRen.gif | 08:18 |
| StevenK | nigelb: So, you take two steps into a bathtub and then slip? | 08:29 |
| nigelb | heh | 08:30 |
| mabac | StevenK, would you have a look at the last revision of https://code.launchpad.net/~linaro-infrastructure/launchpad/team-engineering-view-ui/+merge/100707 and re-land if if possible? | 08:47 |
| czajkowski | mabac: https://dev.launchpad.net/ReviewerSchedule | 08:54 |
| czajkowski | is the schedule StevenK is EOD /asleep | 08:55 |
| mabac | czajkowski, thanks. I'm always confused by the "Europe" tz reviewers being crossed out. | 08:56 |
| mabac | czajkowski, so it looked to me that noone is on call? is it inside the AsiaPac time-slot still? | 08:57 |
| czajkowski | mabac: dont think so | 08:58 |
| StevenK | mabac: Some of the Europe TZ reviewers are struck-out because they are working on MAAS, and not LP at the moment. | 09:22 |
| === al-maisan is now known as almaisan-away | ||
| rick_h | StevenK: ping, sorry, alarm fail, pinging others by hand now. Didn't here back from them in email | 10:35 |
| rick_h | StevenK: you did see the email right? It made it out from my mailbox? | 10:36 |
| mabac | StevenK, ah ok, thanks | 10:45 |
| mabac | rick_h, hi. I feel like I always pounce on you when you get online. ;) would it be possible to ask you for yet another favor? | 10:46 |
| rick_h | mabac: what's this? | 10:47 |
| mabac | rick_h, https://code.launchpad.net/~linaro-infrastructure/launchpad/team-engineering-view-ui/+merge/100707 got rejected and salgado fixed it up tonight. so it needs landing again | 10:48 |
| rick_h | mabac: ok, I'm on call review today and my mentor will be able to ok in a couple of hours. I'll see about getting it through and landing this morning | 10:49 |
| rick_h | will take a few since it's still early here on our side of the world | 10:49 |
| mabac | rick_h, that's absolutely fine of course. thanks a lot! :) | 10:51 |
| czajkowski | rick_h: morning | 10:52 |
| rick_h | czajkowski: morning | 10:59 |
| czajkowski | rick_h: what time is it where you are? | 11:00 |
| rick_h | StevenK: ok, well if you get this sorry. No reply in irc from the other two either. Looks like this is one failed meeting setup | 11:00 |
| StevenK | rick_h: Indeed. :-( | 11:09 |
| StevenK | czajkowski: If my math is right, 7am | 11:09 |
| StevenK | rick_h: I just got home from picking up my wife and shopping, so it's okay. | 11:10 |
| * StevenK is liking the idea of bake-at-home pizzas for dinner ... | 11:10 | |
| nigelb | StevenK: hah. sounds delicious. | 11:11 |
| StevenK | And indeed, it's what my wife and I bought stuff for. :-D | 11:11 |
| nigelb | WIN. | 11:12 |
| === matsubara-afk is now known as matsubara | ||
| nigelb | hah. The linode users are getting pinged out. | 11:17 |
| asac_ | hola! is there an API to query sprint attendees ... or even better to register for a sprint? | 12:18 |
| cjwatson | I don't see any API for sprints at all | 12:20 |
| rick_h | sprints? maybe you're thinking something like the loco system? | 12:20 |
| cjwatson | rick_h: such as https://launchpad.net/sprints/uds-q | 12:21 |
| cjwatson | in fact I suspect asac_ means https://launchpad.net/sprints/lcq2-12 | 12:22 |
| rick_h | lol, learn something new every day...and I work on this stuff. | 12:23 |
| asac_ | cjwatson: yeah. thats what i mean | 12:23 |
| asac_ | we have to ensure that folks that register for connect get registered for the sprint. or at least we have to block submitting our registration form if they are not registered | 12:23 |
| asac_ | so either querying who is registered through API would be nice | 12:23 |
| asac_ | but better would be to register for them because we have all the data in our form already | 12:24 |
| asac_ | flacoste: ^^ | 12:24 |
| asac_ | cjohnston found: https://launchpad.net/sprints/lcq2-12/+attendees-csv for me... which probably can cover for the "get attendees in a machine readable format" use case... | 12:25 |
| asac_ | would still love to register directly though | 12:25 |
| asac_ | spinning more ideas ... is there a launchpad URL trick to pre-populate something like https://launchpad.net/sprints/lcq2-12/+register ? | 12:29 |
| cjohnston | it is prepopulated | 12:29 |
| asac_ | yeah | 12:29 |
| asac_ | i mean ... overloading the defaults | 12:29 |
| cjohnston | if you link them to that and they are logged in, its good to go. | 12:29 |
| asac_ | with something i already had users type elsewhere | 12:29 |
| cjohnston | ahh.. | 12:29 |
| wgrant | asac_: https://launchpad.net/sprints/lcq2-12/+register?field.time_starts=2012-05-29T09:30 | 12:45 |
| wgrant | asac_: You can override the field defaults like that | 12:45 |
| asac_ | wgrant: lovely | 12:46 |
| asac_ | let me try for the attendee | 12:46 |
| wgrant | asac_: You probably want https://launchpad.net/sprints/lcq2-12/+attend, though | 12:46 |
| wgrant | That's the self-attendance form | 12:46 |
| asac_ | wgrant: no | 12:46 |
| asac_ | the problem is that the folks add the nick of launchpad | 12:46 |
| asac_ | on their own | 12:46 |
| asac_ | so he might attend | 12:46 |
| asac_ | byut then i need to check if his nick is really registered | 12:47 |
| asac_ | hmm | 12:47 |
| asac_ | wgrant: do you know if there is a URL to get the launchpad nick? | 12:47 |
| asac_ | the currently logged in? | 12:47 |
| wgrant | What for? | 12:47 |
| wgrant | A third-party application can't access that from a user's browser. | 12:47 |
| === rick_h changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: rick_h* | Firefighting: - | Critical bugtasks: 4*10^2 | ||
| asac_ | to fill it in a external webform | 12:47 |
| cjohnston | asac_: http://connect.linaro.org/register-connect/ has an LP username field | 12:47 |
| asac_ | wgrant: i am talking about a web html form | 12:48 |
| cjohnston | which is automatically filled in | 12:48 |
| asac_ | wgrant: we have a sprint registration form elsewhere ... and they add their launchpad nick there ... now we want to ensure that the user is registered | 12:48 |
| asac_ | otherwise it is a mess as all users will not have a schedule | 12:48 |
| wgrant | asac_: I'm not sure how that relates to getting the Launchpad nick of the current logged in user. | 12:48 |
| wgrant | Don't they give you their nick? | 12:48 |
| asac_ | cjohnston: that is automatically filled in? | 12:48 |
| asac_ | wow | 12:49 |
| cjohnston | yes | 12:49 |
| cjohnston | because you login to LP to fill out the form | 12:49 |
| cjohnston | so its auto populated | 12:49 |
| asac_ | wgrant: seems we do it :) | 12:49 |
| cjohnston | I'm sure its the WP openid plugin thats used | 12:49 |
| asac_ | through openid i guess? | 12:49 |
| cjohnston | that gives us that info | 12:49 |
| wgrant | Yes, you get that through OpenID | 12:49 |
| asac_ | ah its even not changable | 12:49 |
| asac_ | so thats good | 12:49 |
| asac_ | so yeah ... attending url | 12:49 |
| asac_ | with just dates | 12:50 |
| asac_ | can i get the csv file from a separate 3rd party website? | 12:50 |
| asac_ | in js ? | 12:50 |
| wgrant | Browser security will prevent you from obtaining that CSV via AJAX. | 12:50 |
| wgrant | You could grab it with a backend application, however. | 12:50 |
| cjohnston | asac_: what about when you click register, we load in an iframe the https://launchpad.net/sprints/lcq2-12/+register?field.time_starts=2012-05-29T09:30 url and tell them to click save | 12:51 |
| wgrant | that won't work | 12:51 |
| wgrant | Framing Launchpad is forbidden | 12:51 |
| cjohnston | ahh | 12:51 |
| asac_ | wgrant: yeah, so XSS prevention i guess? | 12:52 |
| asac_ | i felt that that would happen | 12:52 |
| asac_ | that list is available to not logged in users? | 12:52 |
| wgrant | asac_: The CSV thing is just normal browser same-origin policy stuff, nothing that Launchpad asks for. | 12:52 |
| * jml hugs testr | 12:52 | |
| asac_ | so just a wget? | 12:52 |
| wgrant | The iframeing is for clickjacking prevention. | 12:52 |
| asac_ | let me try | 12:52 |
| jml | sinzui: ping | 12:53 |
| asac_ | seems not | 12:53 |
| cjohnston | wgrant: /3 | 12:54 |
| cjohnston | sorry. | 12:54 |
| jml | I had forgotten how slow Launchpad tests are. | 12:54 |
| wgrant | They're slow and there's 18000 of them | 12:55 |
| wgrant | Lots of those slow doctests :( | 12:55 |
| jml | yeah. I'm running 81 of them. | 12:55 |
| jml | is there a list of suggestions for things I can do if I'm struggling to phrase my patch with a negative line count? | 12:56 |
| wgrant | Refactor tests to remove duplicated code, delete dead helpers, rip out Blueprint, that sort of thing... | 12:57 |
| jml | but not an actual hit list | 13:00 |
| sinzui | hi jml | 13:02 |
| deryck | Morning, ll. | 13:02 |
| jml | sinzui: hello | 13:02 |
| deryck | all, even | 13:02 |
| rick_h | morn | 13:02 |
| jml | sinzui: I'm multi-tasking a bit now, but I want to talk later about creating private PPAs | 13:03 |
| sinzui | jml: do you want to delete the existing windmill tests that are never run? I think that add up to 2000 lines | 13:03 |
| sinzui | fab | 13:03 |
| flacoste | morning deryck | 13:08 |
| asac_ | hi flacoste !! | 13:08 |
| cjwatson | 2000 lines> that might actually result in an overall net reduction since the LoC policy was announced, then ... | 13:09 |
| flacoste | hey asac | 13:09 |
| salgado | abentley, that PQM failure was because a branch that was a prerequisite for that one had landed and then been reverted | 13:19 |
| abentley | salgado: Okay. Good thing it failed, then :-) | 13:20 |
| salgado | indeed! | 13:20 |
| mabac | rick_h, when you get to it, this is the updated mp for the team engineering view: https://code.launchpad.net/~linaro-infrastructure/launchpad/team-engineering-view-ui/+merge/100956 It's only the last rev that's new. | 13:25 |
| rick_h | mabac: yep, will do, thanks. | 13:26 |
| salgado | mabac, I've also merged the XSS fix into the two other pending branches: https://code.launchpad.net/~linaro-infrastructure/launchpad/upcoming-work-progress-bars/+merge/100808 and https://code.launchpad.net/~salgado/launchpad/person-upcoming-work-view/+merge/100878 | 13:54 |
| salgado | they have been approved already, so it should be just a matter of asking somebody to ec2-land them once the first one has gone through | 13:54 |
| mabac | salgado, cool thanks! | 13:55 |
| asac_ | salgado: mabac: hello my friends :) | 13:57 |
| asac_ | hehe | 13:57 |
| asac_ | salgado: can you brief me on the status of the registration form API? | 13:58 |
| salgado | asac_, hi there. doing some lp hacking as well? :) | 13:58 |
| asac_ | i heard you mihg know something | 13:58 |
| asac_ | i am getting strong | 13:58 |
| asac_ | your merge requests inspired me :) | 13:58 |
| asac_ | now i am trying to find the time | 13:58 |
| asac_ | hehe | 13:58 |
| salgado | I've never heard about that... danilo took all that pain for himself, I'm afraid | 13:58 |
| asac_ | ok | 13:58 |
| asac_ | flacoste: do you have any records/pointers to share? | 13:59 |
| flacoste | asac_: sorry, got dragged in phone calls | 13:59 |
| asac_ | no problem | 13:59 |
| asac_ | i have 1 minute left | 13:59 |
| asac_ | before i have to propose a solution :) | 14:00 |
| asac_ | hehe | 14:00 |
| mabac | asac_, I have to say that the rest of us haven't worked on the registration | 14:00 |
| asac_ | yeah | 14:01 |
| deryck | abentley, abel rolled a rock to my scissors. he's your pre imp. :) | 14:01 |
| asac_ | thats fine | 14:01 |
| abentley | deryck: :-) | 14:01 |
| deryck | rick_h, don't forget to forward that bzr connections discussion stuff to abel, too, please. just so he's in the loop about the last time this came up. | 14:02 |
| rick_h | deryck: will do | 14:02 |
| deryck | rick_h, thanks! | 14:02 |
| === jcsackett changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: jcsackett, rick_h* | Firefighting: - | Critical bugtasks: 4*10^2 | ||
| rick_h | deryck: sent | 14:14 |
| deryck | rick_h, thanks! | 14:15 |
| bac | hi flacoste, i never got that email that you mentioned having sent. can you resend? | 14:18 |
| flacoste | bac: i will | 14:18 |
| bac | thanks! | 14:18 |
| rick_h | salgado: still around? Reviewing and trying to find where upcomingwork is called/used? | 14:25 |
| salgado | rick_h, the view? there's a link to it from the team's main page although it's protected with a feature flag | 14:26 |
| rick_h | salgado: not the class view, but the method in browser/team.py? | 14:27 |
| rick_h | bah, let me check this out, not enough context in the diff | 14:27 |
| salgado | rick_h, oh, that's the method in the TeamMenu thing... it's used to generate the link in the template | 14:28 |
| salgado | tal:define="link context/menu:overview/upcomingwork" | 14:28 |
| rick_h | salgado: ah ok, thanks. I was searching for upcomingwork( and came up empty | 14:29 |
| salgado | rick_h, unless you want to review the whole thing (which is fine :), you can just review the XSS fix which is what was not reviewed by StevenK. this branch was reverted because of that XSS hole so that's the only thing that hasn't been reviewed yet | 14:31 |
| rick_h | salgado: yea, saw that in mabac's branch. You guys threw me off with the superceded while I had it up | 14:31 |
| rick_h | salgado: so sorry, just giving it a run through since I've got to put my name on it :) | 14:32 |
| salgado | rick_h, nothing to be sorry for... it's fine if you want to review it all; just thought I'd mention what happened yesterday in case you were not aware | 14:32 |
| rick_h | salgado: thanks, yep working on keeping/catching up | 14:33 |
| flacoste | asac_: actually, the API to add a reigstree was never implemented | 14:43 |
| flacoste | asac_: i recall danilo wanted to implement it, but I think it was never finished (if started) | 14:43 |
| flacoste | asac_: i can't find an email to the list, so i think it was only an IRC chat where he discussed the concept | 14:45 |
| asac_ | flacoste: do you have logs and can see if you can spot something in 1-2 minutes? otherwise its ok | 14:46 |
| asac_ | i know what to do :) | 14:46 |
| asac_ | well... at least what to propose (e.g. lets do it different) | 14:46 |
| asac_ | i will do that assuming that nothing really happened :) | 14:46 |
| cjwatson | I could use a review of https://code.launchpad.net/~cjwatson/launchpad/publish-proposed/+merge/100985 | 14:51 |
| flacoste | asac_: not that i can easily find, my grep didn't found it :-/ | 14:52 |
| rick_h | cjwatson: will do | 14:52 |
| cjwatson | thanks | 14:53 |
| asac_ | flacoste: allright. thanks for your help | 14:54 |
| flacoste | asac_: sorry, for not having something more concrete :-/ | 15:05 |
| asac_ | no problem at all | 15:05 |
| === salgado is now known as salgado-afk | ||
| cjwatson | rick_h: OK, fixed the problems you identified (thanks!) | 15:51 |
| === matsubara is now known as matsubara-lunch | ||
| cjwatson | I don't have landing privileges, but I guess this needs an ack from a non-* reviewer anyway? | 15:53 |
| rick_h | cjwatson: yea, I've requested jcsackett take a peek and I can make sure to land it once he looks at it | 15:55 |
| cjwatson | cool, thanks | 15:55 |
| === jtv1 is now known as jtv | ||
| rick_h | cjwatson: can you post a commit message on your MP please? | 16:27 |
| cjwatson | rick_h: done | 16:27 |
| rick_h | cjwatson: ok, starting up the land process | 16:29 |
| cjwatson | great, thanks | 16:30 |
| === matsubara-lunch is now known as matsubara | ||
| rick_h | sinzui: ping, quick yay/nay for you. I'm trying to get my email branch notification to pass tests, but hitting tests where the user isn't logged in and so I don't have access to the preferredemail attribute. | 17:19 |
| rick_h | sinzui: so this diff seems to work for the tests that have failed so far: https://pastebin.canonical.com/63886/ | 17:20 |
| rick_h | sinzui: any alarm bells going off for you I should watch out for? | 17:20 |
| sinzui | rick_h, i an a bit apprehensive about the change | 17:21 |
| rick_h | ok, should I instead look at altering the tests then to make sure they're in a login state like the ones I added for this? | 17:22 |
| sinzui | rick_h, When purple squad was hardening objects over the last 6 months, we fixed a lot of tests that did not have logged in users | 17:22 |
| rick_h | sinzui: ok, yea there aren't many. I'm still working through the 11 failures, not all were due to this | 17:23 |
| rick_h | I think test_escaped_message_when_removing_key was the one that I first hit | 17:23 |
| sinzui | rick_h, I think you changes are safe, but they imply someone does not know how to write a test...it is impossible to use launchpad (zope) with out an interaction. Something really must be logged in, or else this is anonymous... | 17:25 |
| rick_h | sinzui: ok, I'll finish going through the tests and the ones that are left I'll take a look at | 17:26 |
| rick_h | that is, those that fail without the remove security proxy | 17:26 |
| rick_h | if I can't figure them out I might ping for assistance to make sure I'm twisting them right | 17:26 |
| sinzui | rick_h, I guess my concern is about the user a few lines above your change | 17:26 |
| sinzui | rick_h, I think the model/emailaddress.py is fine because we do similar changes in models | 17:27 |
| === deryck is now known as deryck[lunch] | ||
| sinzui | rick_h, I think model/emailaddress.py should be kept because deactivated users will get spam | 17:30 |
| rick_h | sinzui: sorry, not following you. what should be kept? | 17:30 |
| sinzui | your second change ensures we do not send spam to deactivated and suspended users | 17:31 |
| rick_h | sinzui: right, sorry. That one isn't goign anywhere. It fixes some of the 11 test failures. I was speaking specifically on the remove proxy thing | 17:32 |
| rick_h | sinzui: so sounds like the suggestion is to back that out, find which of the 11 tests fail on that change, and check if the tests needs updating | 17:32 |
| sinzui | rick_h, The only legitimate reason why for 'user = IPersonViewRestricted(event.user)' failing is because the fields were changes by a job running as someone other than the user who owns the address. | 17:36 |
| sinzui | rick_h, I do not think a job in involved...I think the tests are bad | 17:37 |
| rick_h | sinzui: ok, it's happening in the ssh tests | 17:37 |
| rick_h | doc/sshkey.txt so far | 17:37 |
| sinzui | yep, I anticipated that and already checked that it never calls login | 17:39 |
| sinzui | that test is bogus...it is demonstrating anything can compromise a user's sshkey, which certainly never was true | 17:40 |
| rick_h | logintoken-corner-cases.txt is failing with the same issue as well | 17:40 |
| sinzui | Looks like the first test needs to call login_person(name16) and login_person(name12) | 17:41 |
| rick_h | ok | 17:41 |
| sinzui | rick_h, these tests predate login_person() when they were created, you had to know/get the email address which was not always easy | 17:43 |
| rick_h | xx-add-email fails blankly, and webservice/xx-person is the same unauth'd error | 17:46 |
| rick_h | so down to 4 tests to fix | 17:46 |
| rick_h | sinzui: thanks I'll add that and give it a go and check on the other 4 tests then and not use the removeSecurityProxy in my code itself | 17:46 |
| sinzui | okay | 17:46 |
| mabac | jcsackett, rick_h thanks for the review. I have changed the todo comment to the proper format. | 18:43 |
| rick_h | mabac: ok cool thanks. Pulling update now to help land | 18:43 |
| mabac | rick_h, great thank you | 18:44 |
| mabac | rick_h, will it work to land the other branches salgado mentioned too then? | 18:44 |
| mabac | salgado> mabac, I've also merged the XSS fix into the two other pending branches: https://code.launchpad.net/~linaro-infrastructure/launchpad/upcoming-work-progress-bars/+merge/100808 and https://code.launchpad.net/~salgado/launchpad/person-upcoming-work-view/+merge/100878 | 18:44 |
| rick_h | mabac: ?? sorry didn't peel at other ones | 18:44 |
| mabac | <salgado> they have been approved already, so it should be just a matter of asking somebody to ec2-land them once the first one has gone through | 18:45 |
| rick_h | ah no, those will have to be dealt with on their own I think, looking | 18:45 |
| === deryck[lunch] is now known as deryck | ||
| rick_h | ah ok, yea I'll have to pull each and land them one by one | 18:45 |
| mabac | rick_h, ok. I'll peek back in a while and see if I need to do anything. thanks for looking :) | 18:45 |
| rick_h | mabac: can you set commit messages on the mp please? | 18:46 |
| rick_h | looks like the other two have it set | 18:47 |
| rick_h | sinzui: ping, have a sec for this last test please? | 19:08 |
| sinzui | yes | 19:08 |
| rick_h | https://pastebin.canonical.com/63903/ is the test bit blowing up on me | 19:09 |
| rick_h | https://pastebin.canonical.com/63902/ is the test failure | 19:09 |
| rick_h | the test seems to be doing some trick with trying to help an anonymous user get access, but since it's not logged in the access to the email property fails | 19:09 |
| sinzui | that is crack | 19:09 |
| rick_h | I feel like trying to get the right user logged in to fix my issue breaks the spirit of the test there | 19:10 |
| sinzui | create user, login user, do change, logout | 19:10 |
| sinzui | login_person(ssh_user) | 19:10 |
| rick_h | ok, but then the login(ANONYMOUS) is basically invalid/removed? | 19:10 |
| sinzui | yes it is invalid | 19:11 |
| rick_h | ok, sinzui any hint on this thread._local? https://pastebin.canonical.com/63907/ | 19:14 |
| rick_h | I just moved the login call below the ssh_user = getUtility line and changed it to ssh_user | 19:14 |
| sinzui | yep | 19:15 |
| rick_h | so https://pastebin.canonical.com/63908/ is making the thread._local error on the getByName call | 19:16 |
| rick_h | sinzui: nvm, got it. Have to login first with the email | 19:21 |
| sinzui | okay | 19:22 |
| sinzui | rick_h, sorry the lag. I am still trying to find a reliable ie8 setup to test lp.dev | 19:22 |
| rick_h | sinzui: gotcha, np. I think I finally updated the tests to pass. Had to change a bunch in xx-add-email since there's now two messages for each test | 19:23 |
| sinzui | yep | 19:24 |
| salgado-afk | mabac, rick_h, I've just set the commit message on https://code.launchpad.net/~linaro-infrastructure/launchpad/team-engineering-view-ui/+merge/100956 | 20:58 |
| salgado-afk | jcsackett, maybe you can land that branch? rick_h was waiting for us to set the commit message before he'd do it but it looks like it was too late when I did it | 21:45 |
| rick_h | salgado-afk: I'll try to get it going tonight. Sorry, family dinner time and such. Once the boy's in bed I'll run it | 22:18 |
| salgado-afk | rick_h, no worries, I didn't have high hopes for that anyway as I thought everyone would be gone by now. :) | 22:20 |
| rick_h | salgado-afk: meh, I'm a junkie. I'm also in tomorrow while most people are off so worst case it's first on my todo in the morning | 22:21 |
| rick_h | but I'll get it going in a couple of hours | 22:21 |
| salgado-afk | rick_h, oh, do it tomorrow then! | 22:22 |
| salgado-afk | it won't make any difference to us... I just wanted to have it ready for QA on Monday | 22:22 |
| rick_h | salgado-afk: np, I'll get them in. Just those three right? | 22:24 |
| rick_h | or are there any others I need to know of? | 22:24 |
| salgado-afk | rick_h, nope, just those 3 ones. you might want to submit just the last one, actually, as it includes the previous two | 22:24 |
| rick_h | k, not sure how it works but I'll check it out. | 22:25 |
| rick_h | anyway, have to get the boy to the bath, bbl | 22:25 |
| salgado-afk | thanks a lot, rick_h! | 22:25 |
| === matsubara is now known as matsubara-afk | ||
| [reed] | where should I send possible launchpad security bugs? | 23:17 |
| [reed] | just file them a security bug in launchpad? | 23:17 |
| rick_h | [reed]: yes, file them as security bugs in LP and it'll get notified to most everyone | 23:18 |
| [reed] | thanks | 23:18 |
| [reed] | rick_h: filed, thanks again. | 23:26 |
| rick_h | [reed]: thanks, with the holiday weekend in effect might take a few, but it'll get looked at. | 23:27 |
| [reed] | ah, yes | 23:28 |
| [reed] | I was wondering why Canonical people were saying they were gone tomorrow | 23:28 |
| [reed] | hah | 23:28 |
| * [reed] doesn't have the day off :( | 23:28 | |
| rick_h | yea, US doesn't have it, but most of the other devs do | 23:28 |
| [reed] | ah | 23:29 |
| wgrant | [reed]: Thanks, I've commented on the bug. | 23:44 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
