/srv/irclogs.ubuntu.com/2012/04/10/#launchpad-yellow.txt

bachello frankban -- welcome back11:23
frankbanmorning bac, thank you, how is it going?11:42
bacfrankban: good, thanks.11:43
bacfrankban: hey, i have a review mentor for you!11:43
frankbanbac: cool, who is?11:43
bacraphaƫl (rvba) has volunteered but he cannot start for a couple of weeks until the 12.04 release of MAAS11:43
bachope that's ok.  he's in france so the time zone should be perfect11:44
frankbanit's perfect, I know him, it was my roommate in budapest, thanks bac11:45
bacoh, i did not know that.  glad it worked out.11:45
bacfrankban: perhaps you can coordinate with rvba to see about getting started.  you should probably just pick whichever day is his on-call review day and dedicate that day of the week to working with him.11:46
bacalthough now it does not seem reviewing takes nearly as much time as it used to11:46
frankbancool bac, I will contact him. so the task here is start reviewing code with him until I will be ready to do that by myself?11:52
bacfrankban: he will explain the reviewing process and approach to you.  then, on whatever day he is on call, you'll work with him doing reviews.  you'll do a full review but he will then review your review.  that step must be taken before the developer can treat the MP as approved.11:54
bacas a mentor your reviews are provisional until he approves it.11:54
bacin LP we denote that by putting a '*' on the review type to indicate it must be mentored.  so when you do a code review you'll mark the review type as 'code*'.  later rvba will look at it, and if he agrees, he'll mark it as a 'code' review and then it can be accepted.11:56
bachope that makes sense.  it really is quite straightforward11:56
frankbansure bac, thanks11:57
bacfrankban: thanks for volunteering to take this step.  it really is important for the team and for your development as you get to see all parts of the code base.11:58
gary_posterwelcome back frankban!  I hope you had a great vacation11:59
frankbanmorning gary_poster, thanks, yes, I enjoyed my holidays, an the final dissertation of my girlfriend went very well12:00
bacfrankban: what was her topic?  something related to art history, no?12:09
bacgary_poster: T-0?12:10
gary_posterfrankban, exellent!  congratulations to her12:10
gary_posterfrankban, just approved one of your lpsetup (urandom) MPs with comment12:10
gary_posterbac, yes oops12:10
gary_posterbac benji frankban call ASAP, no later than 2 from now12:10
frankbanbac, architectural designing12:10
bacah, right.12:11
gary_posterbac, I'm < 10 min away fwiw.  then you'll only have a half hour, but so be it13:16
bacok13:17
baclet's try the new super ssh screen sharing https://dev.launchpad.net/yellow/RemoteTerminalBroadcasting13:17
gary_posterbac, cool.  you're driving, I assume?13:24
gary_posterbac, I'm in goldenhorde13:26
bachi gary_poster.  joining now13:28
gary_postercool13:29
gary_posterbac, fwiw I disconnected from the screen sharing13:45
bacgary_poster: just killed it13:46
gary_postercool13:47
bacjuju has now deprecated default-image-id and default-instance-type.13:57
gary_posterah right13:59
gary_posterin favor of constraints13:59
gary_posterwhich I haven't learned how to use yet13:59
gary_posterbenji, would collaborating be useful?14:00
benjigary_poster: sure; let me prepeare14:03
gary_postercool14:04
benjigary_poster: the horde awaits14:07
bacgary_poster: the new --constraints interface to juju looks like it will make the script easier.  no need to rewrite the environments.yaml15:25
bacthe documentation has problems, though, but it seems to be easy to work around15:25
gary_posterawesome bac.  and then I can look at your script to see how the heck it actually works now :-)15:25
bacgary_poster: work-in-progress:  http://pastebin.ubuntu.com/923449/15:26
bacit looks like you can only pass one k=v pair per --constraints param, despite what the docs say15:26
bacand you must get rid of default-instance-type and default-image-id from your environments.yaml15:27
baci'm unsure of the relation between instance-type and cpu settings.  does a c1.xlarge imply cpu=8?15:28
gary_posterbac, the relation is defined by the instance type15:29
gary_posterIOW, a given instance type has a certain number of cores15:29
gary_posteras defined by Amazon15:30
gary_posterbac, look for "virtual cores" in http://aws.amazon.com/ec2/instance-types/15:30
bacgary_poster: so is that the default number of cpus but the --constraint "cpus=n" changes it?15:31
bacas seen here: https://juju.ubuntu.com/DeprecatedEnvironmentSettings15:32
bacgary_poster: nm15:34
bacNote that cpu and mem conflict with instance-type, and should not be specified at the same time; and that setting a service constraint that conflicts with an environment constraint will cause the environment constraint to be ignored for that service.15:34
gary_posterbac, ah! ok cool15:34
* bac -> late lunch + bike17:16
gary_posterbenji, I see you working, but trying to talk to hallyn.  will join in a bit17:26
benjigary_poster: k17:27
gary_posterfrankban, hey.  so, I talked to hallyn17:31
gary_posterhe hadn't seen what I wrote him earlier today17:32
gary_posterhe is +1 on lxc-ip but it can't go into precise17:32
gary_posterwe could install in in our own packages but also contribute it upstream17:32
frankbancool gary_poster, thanks.17:34
gary_posterfrankban, he asks us to file a bug and then attach a patch17:34
gary_posterI'm happy to do whatever will help, or leave it to you.  You doing it means more props for you :-)17:35
gary_poster(to Ubuntu, I mean)17:35
gary_posterfrankban, he also wonders if we can do better than the grep17:35
gary_posterlike, for instance, querying a dhcp server17:36
gary_posterhe also said this:17:36
gary_poster"note that if we add '-q' to lxc's dnsmasq then we can get the ip addr from syslog but i don't see any way to send just the mapping to a file under /var/run/lxc"17:36
gary_posterI'm not clear on how we would use that, but maybe you are, or maybe it would give you an interesting thing to look into17:36
frankbangary_poster: hmm... I have no idea about that right now, but I think it is worth investigating. Didn't know we can avoid using dhcp leases17:38
gary_posterme either :P17:41
gary_posterI'm not sure we can17:41
gary_posterI don't think he is saying "do it this way" but "consider/investigate this way"17:42
gary_postercould be wrong :-)17:42
frankbangot it, I think it's worth trying. I will file a bug for adding lxc-ip, EOD, thanks and good evening gary_poster17:48
gary_posterthanks frankban, have a nice evening17:48
gary_posterbenji, I'm in goldenhorde18:06
benjigary_poster: am I here?18:22
=== garyposter is now known as gary_poster
bacbenji, gary_poster: have you seen this before?  http://paste.ubuntu.com/923796/19:00
bacit seems transient, so i'm wondering if we should put a retry option into the 'run' helper command19:01
benjibac: not that I remember, looks nasty19:01
gary_posterbac, I don't think so either19:02
bacit is killing the script b/c it catches this one exception and then gives up19:02
benjigary_poster: my machine died hard; doing updates and rebooting and then I'll re-join the horde19:14
gary_posterack benji19:14
gary_posterTestProtocolClient is what I was thinking of19:14
benjigary_poster: what does that do?19:15
gary_posterbenji, The ``subunit.TestProtocolClient`` class is a ``unittest.TestResult``19:15
gary_posterextension which will translate a test run into a Subunit stream.19:15
gary_posterbenji, and the "tags" method behaves exactly as I suspected:19:18
gary_posterit has no concept of state19:18
gary_posterif you say there is a tag added,19:18
gary_posterit reports that the tag is added19:19
gary_posterwith no concept of whether you are in a test or not in a test, or whether that tag has been reported recently or not19:19
gary_posterso if you use that as your test result19:19
gary_posterand then you wrap it with something that *does* keep track of state, such as the aggregating thing19:20
gary_posterthen everything should work out fine19:20
gary_posterSo, if the logging test result in testtools has no state19:20
gary_posterthen it would be the closest analog19:21
gary_posterand our test should should show that the logging test result correctly is called with the proper add tags or remove tags19:21
gary_poster*with the subunit semantics*19:22
gary_posterso the real remaining question in my mind is this:19:22
benjigary_poster: so... that means that we should be able to strip out the stateful behavior in ThreadedForwarding<mumble>Result and our Worker<mumble>TestResult and all should be happy19:22
gary_posterbenji, no, because they are responsible for maintaining the subunit behavior, in the current setup.  The only problem, and the question to which I alluded, is this: if these things implement subunit policy, why are they in testtools?19:24
gary_posterand they really should implement subunit policy for our use.  I'm pretty sure, though I'll want to try and convine you verbally when you are back together again to make sure I'm right19:24
benjigood point, moving them might be the thing to do; have you checked to see if they're used elsewhere in testtools?19:24
gary_posterno, will look19:24
benjigary_poster: also there's the point that someone other than subunit might be using them and we'll be yanking them out from under them19:25
gary_posteryeah, benji.  doubtful IMO, but the concern is reasonable and proper.19:25
* benji watches his laptop install 465 updated packages.19:26
gary_posterbenji, ConcurrentTestSuite is the only thing that refers to ThreadsafeForwardingResult19:28
gary_posterin testtools19:28
gary_posterand probably anywhere :-)19:28
gary_posterI suspect that this is what will shake out:19:29
benjicool19:29
gary_poster- jml will tell us that he didn't initially have the idea of per-test tags19:29
gary_poster- jml will say that Robert added the idea19:29
gary_poster- jml will tell us that he wants to push that idea throughout testtools but hasn't gotten around to it19:30
gary_poster- we will be encouraged to add our new bits and bobs to testtools19:30
gary_poster- we will also be encouraged to fix up TestResults' tags, if we are up for it19:31
gary_posterFor the short term, I think we can continue working in testtools19:31
gary_posterWe should not touch the base TestResults19:31
gary_posterwe should change the tests we've been writing to look at logs about the tags19:31
gary_posterWe can then make an MP and raise the questions we have19:32
benjigary_poster: I think that'll work.  I'm going to reboot and rejoin the horde and we can commence on the above.19:32
gary_postercool19:32
* gary_poster back in a sec19:38
benji___gary_poster: I can hear you, but it looks like my virtual self fell asleep19:46
gary_posterbenji___, :-) now you are no longer in room19:47
benjiI think I'm back.19:52
gary_posterbenji, I see you here but not in hangout.  talking to lifeless in -ops19:55
gary_posterbenji, -dev :-)19:55
benjigary_poster: I'm going to do the simpler thing.20:10
gary_posterbenji, cool.  +120:11
bacgary_poster: i just had a quick chat with sean r., the python-memcached bug supervisor.  he said he's put the review on his 'short list' but is very busy.  i think tomorrow morning i'll prepare the fork.20:32
bacman, the juju-ers need to use pyflakes.  it's a mess out there20:51
benjiheh20:51
bacand it would've highlighted the error i just had to chase down20:51
gary_posterbac, python-memcached: glad he is looking at it, but yes, good, +1 on fork.  We can add a card to "tracking" for this after we have the fork landed.20:52
bacgary_poster: yep20:52
gary_posterthe go version of juju has linting built in20:53
gary_posterwell, go has linting built in I mean20:54
gary_posterbut I will miss being able to hack it and stick pdbs in it20:54
gary_postereven in the production instance20:55
benjiyeah, I will definately miss pdb when working in a non-Python language21:00

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!