=== urbanape` is now known as urbanape [08:34] morning! [08:42] Good morning all! [11:07] good morning [11:17] gatox, morning! [11:17] gatox, I have been waiting for your evil machine :) [11:18] mandel, jejeejej i know [11:18] gatox, you know which branches to use? [11:19] gatox, would be lp:~mandel/ubuntuone-dev-tools/mocked-webserver and lp:~mandel/ubuntu-sso-client/fix-activation-tests [11:23] mandel, yep [11:23] mandel, pulling and testing [11:28] gatox, thx, I added a wrapper factory that keeps track of all alive connections and removes them at the end by killing the transport, I really hope that it does the trick === salgado-afk is now known as salgado [11:30] mandel, i run it a couple of times.... and i get always the same failures: http://paste.ubuntu.com/923135/ [11:31] gatox, witch revno of ubunutone-dev-tools do you have? [11:31] mandel, i'm using de mocked-webserver revno 75 [11:32] gatox, ok, so that did not work when the factory is used as a client factory.. [11:32] gatox, dammed, why doesn't it fail in my machine.. [11:32] mandel, it's really weird === nessita1 is now known as nessita [12:54] good morning! [12:55] ralsina, morning! [12:56] ralsina, hi [12:58] hmm [12:58] ok, time for me to go for lunch and take an aspiring.. HTTPClientFactory calls the transport.loseconnection after the deferred is called and that means that we have a connection left there when we leave the test.. [12:58] * mandel hates this twisted at times.. [12:59] mandel, me too :P [13:01] * mandel lunch [13:03] what the heck [13:03] There is a reason why twisted is not called straightforward, you know. [13:03] is it 2012 or 1982? [13:03] dobey: let me check... are we invading islands? No: 2012! [13:03] 21 Jump Street, Three Stooges, Vacation, and Amazon tells me there's new Bonnie Raitt [13:05] dobey: that's a combination of 60s and 90s, so probably it's 1978 or so. [13:05] * ralsina checks to see if we are winning any world cups.... no, not that either. [13:06] 90s? [13:10] hello, all! [13:11] alecu, hi! [13:16] dobey: 21 jump street ran from 1987 to 1991. I thught it was later. [13:17] gatox: what's working? === m_conley_away is now known as m_conley [13:18] ralsina, jejee the problem that i was having with twisted, the client connection when its needed only for ipc, not opening sd for u1sdtool -q and so :P [13:18] gatox: nice [13:18] yeah! [13:26] ralsina, I'm getting an error while running nessita's last branch: http://pastebin.ubuntu.com/923265/ [13:26] ralsina, do you know if I'm missing anything? [13:26] yay, i love useless stack traces :( [13:26] alecu: hi there. Looks odd, will re-check in a few minutes. [13:29] alecu: looking [13:29] alecu: looks like a missing humanize call [13:31] ralsina, right. I thought that my env may be screwed since tests passed both for you and nessita. [13:31] alecu: do you have nightlies up to date? [13:31] alecu: and did you merge trunk? [13:33] ralsina: would you mind a few minutes to look this over? https://code.launchpad.net/~brian.curtin/ubuntuone-windows-installer/909389-firewall-exception/+merge/101137 [13:33] briancurtin: sure! [13:34] ralsina, I did merge trunk. nessita I updated nightlies yesterday, but this also fails if I point PYTHONPATH to sso and u1c trunk [13:36] https://code.launchpad.net/~brian.curtin/ubuntuone-control-panel/c2c-loading/+merge/101246 could also use a look. it's a simple "fix" to move along with windows release - it fixes the Cloud To Computer page [13:39] briancurtin, do we have a bug for the TODO in your branch? [13:40] briancurtin: +1 on the fw exception (tricky stuff about the paths as usual on bitrock) [13:40] alecu: we don't, but i'll make one [13:40] briancurtin: I am not happy about merging c2c-loading [13:40] briancurtin, please, and add the number to the TODO, and I'll approve. [13:41] briancurtin: we could add it as a release-patch but if we put that in trunk, we break it on Linux where it works === yofel_ is now known as yofel [13:41] ralsina, good point [13:41] ralsina: i'm not really happy about it either, and don't know about the linux side of it. keeping it as a release patch would work for me to at least get it moving along [13:42] so should i reject the merge proposal, create the bug, and do it as a release patch? [13:42] briancurtin: ok, let's do that. [13:42] writing up the bug now [13:42] briancurtin: yes, reject the mp, and we manually merge it [14:10] ralsina: https://code.launchpad.net/~dobey/ubuntuone-client/openssl-except/+merge/101308 last one :) [14:10] dobey: I don't believe you :-) [14:10] * mandel back [14:11] dobey: you are not deleting the authors in some files [14:11] dobey: lines 605, 638, 671 and so on [14:11] ralsina: i'm not deleting the authors in any files? [14:11] dobey: ok, since you were updating copyrights... [14:11] dobey: thought you may as well update to the current guideline [14:11] dobey: but it's ok either way [14:14] dobey: +1 [14:14] ah. i didn't remove the Authors lines in any of these branches. but I will happily do that in the future. Author lines in the comment heading are super annoying [14:14] cool [14:14] dobey: should be easy to automate, remove any line that has ^#.*@canonical\.com in it :-) [14:15] HAHA, if you put a comment that is two spaces and try to send as approve, launchpad ooopses [14:16] nice [14:28] gatox, ping! [14:28] mandel, pong [14:28] gatox, evil machine is required :) [14:28] mandel, i know..... [14:28] gatox, hehehe you feel like a tool :P [14:28] gatox, is here: lp:~mandel/ubuntu-sso-client/fix-activation-tests/ [14:29] mandel, i'm taking note of this..... your assistance will required in the near future jejejej [14:29] gatox, attempting to remember the protocol used by the HTTPClientProtocol and force a lose connection in a clean up from the client side :) [14:29] gatox, I know.. tic for tac :P [14:31] mandel, which mockserver should i use?? the one from junk or the branch? [14:32] gatox, junk please, so I see the stupid prints :) [14:32] okas [14:43] CONGRATULATIONS mandel !! all the tests pass, and i've run them several times [14:44] hurray! [14:44] tests on windows are fixed!!!! [14:44] three cheers to mandel [14:45] if someone does something again to them I'll swim to their country and kill them with a spoon, no joking! [14:45] briancurtin, thx! I'll clean the code a little so I can get reviews and we can move to automate things with jenkins :) [14:45] jejejejejee [14:46] BBC news: "a spanish programmer die in the middle of the atlantic ocean" [14:46] jejejejee [14:46] gatox, with the state of the country right now, it would be a surprise :P [14:46] jejee [14:54] gatox, mandel, alecu, thisfred, dobey, briancurtin, urbanape: standup in 6' (who did I forget this time?) [14:54] you forgot Harry [14:56] OMG! Harry! [15:00] me [15:01] me [15:01] me [15:01] me [15:02] alecu, thisfred dobey urbanape ? [15:02] urbanape is on vacation [15:02] me [15:02] briancurtin, ahhhh right [15:02] DONE: u1db split_words mapping u [15:03] ahh [15:03] me [15:03] gatox: go, dobey is last [15:03] DONE: [15:03] Fixed Bug #907479 (opening syncdaemon only when it's necessary). Test in linux: OK, fixing tests on windows. [15:03] TODO: [15:03] Finish with the tests for #907479 and keep working in the other branchs pending. [15:03] BLOCKED: [15:03] No [15:03] Launchpad bug 907479 in Ubuntu One Client "u1sdtool -q should not start syncdaemon when syncdaemon is not running" [Medium,In progress] https://launchpad.net/bugs/907479 [15:03] briancurtin, go [15:04] DONE: testing installer, fighting with readonly tests and setup [15:04] TODO: giving readonly a break for this half day, building a script that will take care of the manual steps of installer building [15:04] NOTE: today is a half day for me, i have to leave in 2 hours [15:04] BLOCKED: none [15:04] NEXT: mandel [15:04] DONE: Fixed all tests on windows for ubuntu-sso-client. [15:04] TODO: Clean the branches a little (lint, comments, remove debugging prints), propose, beg for reviews. Talk with brian about automation. [15:04] BLOCKED: no [15:04] ralsina, please [15:04] DONE: caught up, did some reviews, did some IRL testing of windows release candidate. TODO: try to get the windows release out after the linux release, see if I can fix the "remove local device and everything breaks" bug BLOCKED: feeling kinda sore-throaty NEXT: thisfred [15:05] DONE: u1db split_words mapping in C TODO: refactoring u1db index mappings and extending test suite BLOCKED: no NEXT: alecu [15:05] DONE: sifted thru SD bugs, started with security bug updates [15:05] TODO: mumble with ralsina, security bug [15:05] NEXT: [15:05] EOM? [15:05] crap, security bug [15:05] dobey? [15:06] alecu: let me call you on the phone, mumble is working strange [15:07] oops [15:07] me [15:08] λ DONE: finish bug #968555, reviews [15:08] λ TODO: releases, uploads, SRUs, finish u1db packaging [15:08] λ BLCK: none. [15:08] Error: Launchpad bug 968555 could not be found [15:11] mandel: you introduced bzr pipelines to the team right? [15:12] I am trying to use them, but have some problems [15:12] mainly pushing fails [15:12] and lp doesn't pick up on the prereq branches [15:12] the two may be related [15:13] thisfred, may I see the error you are getting and the commands used? [15:14] mandel, whenever I push, I get http://pastebin.ubuntu.com/923429/ [15:14] maybe I need to set bzr locations differently? [15:15] thisfred, have you done a bzr sync-pipeline first? [15:15] to work around, I used bzr push lp:~thisfred/project/branch [15:15] mandel: possibly not [15:16] thisfred, do that using the first pipe and pointing to lp [15:16] when do I do that? when starting the pipeline [15:16] thisfred, so, you did a reconfigure-pipeline, right? [15:16] or whenever I need to push? [15:16] thisfred, first time you sync, after that you can use push [15:17] mandel: ok, awesome. Yeah I did reconfigure-pipeline [15:17] guess that was the one step missing [15:17] thisfred, :) [15:17] thx! [15:17] thisfred, try that and let me know if it fixed the problem [15:19] mandel: http://pastebin.ubuntu.com/923437/ [15:20] but that could be because those branches were pushed manually already? [15:20] thisfred, bzr sync-pipeline lp:~thisfred/u1db/c-mappings [15:20] oh ok [15:25] * gatox lunch === gatox is now known as gatox_lunch [15:30] https://code.launchpad.net/~dobey/libubuntuone/update-from-trunk/+merge/101396 [15:30] and i am off to get some lunch. bbiab :) === salgado is now known as salgado-lunch === teknico_ is now known as teknico [15:48] alecu, ping === gatox_lunch is now known as gatox [15:52] mandel, pong [15:53] alecu, can you give me a hand with a problem I have with the time checker tests? [15:53] mandel, sure! [15:54] alecu, so, the main problem I have is that if I change the url from http://localhost:portnum to http://127.0.0.1:portnum the tests fail with a HTTP Error 504: Gateway Time-out [15:54] alecu, do you know why? [15:55] alecu, I wanted to remove the need of using localhost if the mockwebserver returns the ip address [15:55] mandel, can you point me at the branch? [15:55] alecu, sure, give me a sec to push it [15:56] mandel, I'm not quite understanding which url you are referring to [15:59] alecu, in lp:~mandel/ubuntu-sso-client/fix-broken-tests revno 957 you will see there is a todo in ubuntu_sso/utils/tests/test_common.py [16:01] alecu, that branch depends on lp:~mandel/ubuntuone-dev-tools/mocked-webserver [16:01] mandel, awesome, I'll take a look now. [16:01] alecu, thx! [16:02] alecu, in any case I can just pass locahost and get it working, it seems that using the ip address just makes it fail on linux.. [16:10] gatox, ping! [16:10] mandel, pong [16:10] gatox, I made some changes in the brach, it was mainly renaming, but can you check in your machine? [16:11] mandel, okkkkkkk [16:11] mandel, pull only fix-activation? [16:11] gatox, lp:~mandel/ubuntu-sso-client/fix-fix-activation-tests and lp:~mandel/ubuntuone-dev-tools/mocked-webserver === salgado-lunch is now known as salgado [16:13] mandel, okas [16:19] mandel, bad news :S [16:19] gatox, tell me, If I broke them I can revert :) [16:19] mandel, the 13 tests failures are back [16:22] gatox, let me revert the changes [16:22] okas [16:33] Lunch time! [16:34] mandel, the 504 error is a very odd one. [16:34] mandel, do you happen to have proxies enabled when running those tests? [16:35] alecu, no, and it gets fixed by removing the ip for localhost === m_conley is now known as m_conley_away [16:36] alecu, I need to go (rugby) will be back later to char about it, nevertheless I've proposed the branhces that fix the tests [16:37] mandel, I'm running the tests on linux, with 127.0.0.1, and all pass :-/ [16:38] alecu, weird.. the fail in mine, wtf? [16:38] mandel, that "504" error really sounds like something a proxy would return. [16:38] alecu, I know.. I was very puzzled.. [16:38] mandel, for instance: http://www.checkupdown.com/status/E504_es.html [16:39] alecu, I read the same page :) [16:39] mandel, it's the top hit for 504 gateway timeout! [16:39] alecu, I need to go, people are waiting, I'll be back and will try to find what is going on [16:40] alecu, good news are, tests are fixed and up for reviews \o/ [16:40] all, I need to go, last week of rugby, laters! [16:40] mandel, awesome, have a good time. [16:42] maybe i should just turn off spell checking in firefox [16:42] so yeah [16:42] can someone please review https://code.launchpad.net/~dobey/libubuntuone/update-from-trunk/+merge/101396 ? [16:43] hmm, where's nessita? [16:46] ralsina: ^^ do i need to do all the releases that nessita normally handles, as well? [16:56] i'm out of here for my half-day, see everyone tomorrow [17:10] * alecu runs to the bank, and for some errands. [17:16] brb === gatox is now known as gatox_brb [17:33] dobey: yes, but alecu will give you a hand [17:33] dobey: sadly he doesn't have upload rights [17:33] dobey: I got the review === m_conley_away is now known as m_conley [17:35] will be a lot of reviews coming soon [17:35] dobey: when did oauth.c oauth.h get deleted? I don't recall that branch [17:36] ralsina: http://bazaar.launchpad.net/~ubuntuone-control-tower/libubuntuone/trunk/revision/150 [17:36] didn't you review that branch? [17:36] ah no [17:36] gatox_brb and thisfred did [17:37] I always approve any deletion [17:38] dobey: ok, approving then! === gatox_brb is now known as gatox [17:54] people, I feel like crap (fever, sore throat), so I am kinda slow today. Dobey, I will do your reviews, gatox, I just gave you the bug I was working on. I am taking some ibuprofen to see if that helps. [17:55] ack [17:57] alecu, ping [18:02] alecu, cancel ping [18:05] https://code.launchpad.net/~dobey/ubuntu-sso-client/update-from-trunk/+merge/101427 [18:05] ralsina: ^^ [18:05] dobey: got it [18:07] dobey: +1 [18:12] alecu, if you can, please, review this branch https://code.launchpad.net/~diegosarmentero/ubuntuone-client/syncdaemon-q/+merge/100984 [18:13] gatox: nessita will need to review it [18:13] or finish reviewing it [18:14] dobey, yes, i know..... but i would like that alecu review it too, because i discuss part of the implementationn with him [18:14] ok [18:31] meh [18:32] why do we have tests that depend on locale :( [18:44] urbanape, ping [18:49] tgall_foo: he's away this week [18:49] tgall_foo: so you probably won't have much luck poking him on IRC. :) [18:50] ahh thanks dobey [18:51] knocked off a number of bugs from the iOS ubuntuone Files app, figured it'd be great to talk to him see what all might be helpful === m_conley is now known as m_conley_away === m_conley_away is now known as m_conley [19:18] ralsina, if you can: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/current-device-removed/+merge/101432 [19:18] gatox: sure [19:18] thanks [19:24] out on errands, will be back in 20/30 minutes === ralsina is now known as ralsina_errands === ralsina_errands is now known as ralsina [20:02] gatox, pong [20:02] alecu, no, i made a cancel ping :P [20:03] alecu, but if you can, i would like that you review the branch about the connect sd [20:07] gatox, reviewing, yes. [20:12] gatox, http://www.youtube.com/watch?v=hUFR2j7PCbk&feature=youtu.be&t=1h38m47s [20:14] alecu, you are awesome!!!!! [20:14] jejejeje [20:16] gatox, I still need to find the part where I show up :P [20:16] alecu, don't you have it?? [20:17] gatox, the youtube link I pasted is the full movie, and I know that at 1h38m47s my name shows up onscreen.... but I can't recall at what part of the film my face shows up, if at all :-) [20:18] gatox, I'm just another extra with a lot of zombie makeup on. [20:22] gatox: +1 [20:22] ralsina, great [20:29] eod here!! see you tomorrow people [20:29] alecu, if you have a minute.... please review this really small branch: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/current-device-removed/+merge/101432 [20:29] byeeeee [20:49] hmm [20:49] haha [20:49] plaga zombie [20:50] ralsina: do we need that branch of diego's, in the release? [20:50] dobey: well, it's a good bugfix [20:51] dobey: there is one other release, right? But it won't be able to go in that one? [20:51] ralsina: today is 3.0.0 [20:51] dobey: so, no more releases [20:51] right, I missed last week's! [20:51] ralsina: there are no more releases before ubuntu 12.04 [20:51] dobey: It would be nice to have it [20:52] though we may be able to SRU things if we need to [20:52] dobey: what's your opinion? It's a quite visible bug :-/ [20:52] well it's a small enough change [20:52] ok, let's do it [20:52] if it fixes it, land it and we'll get it in [20:53] dobey: it's missing one review [20:53] nonsense [20:53] but i'll approve it [20:53] dobey: ack [20:54] i suppose we need to clarify the whole "number of reviews required" thing [21:03] qengho: interesting change of nick, that [21:03] dobey, too many misunderstandings. [21:04] heh. no comfy chair? [21:05] Right. And these kids today (*shakes fist*) have never seen anything older than "Friends" and they think Ruby is cool. [21:06] ugh, kids today [21:11] ralsina: when will you do the win release? tomorrow? [21:20] dobey: assuming the tarballs are done today, yes [21:20] dobey: or rather, we start it tomorrow, will probably finish it on friday [21:21] brb [21:21] ralsina: ok, i still need to do ubuntuone-windows-installer, ubuntuone-client, and ubuntuone-control-panel [21:27] I'm feeling like crap, so I'm calling this an early EOD. [21:27] bye all! === m_conley is now known as m_conley_away [21:34] by alecu [21:34] err, bye [21:34] ralsina: given the time, i think i'll need to get those 3 done in the morning. and uploads tomorrow as well. [21:35] though i might do a couple of the easy no-changes uploads later on tonight [21:36] dobey: there is no point on doing windows-installer anymore, since it installs no code [21:37] or maybe yes, but it has very few changes [21:38] well it's just a tarball release [21:39] it still contains data and/or scripts for building the actual installer, afaik [21:40] right [21:41] EOD for me. dobey, if you propose branches, mail me, I may take a look early tomorrow [21:41] depending on sleepyness [21:41] right [21:41] later :) [21:41] i'm off as well [21:41] dobey: on second thought, windows-installer needs changes for a stable release (like, setting numbers and versions) [21:42] dobey: so either brian or I have to propose that one [21:48] brian's branch bumped the "203" to "1000" or something [21:49] that should be enough :-) === salgado is now known as salgado-afk