[00:00] desrt, oh, putting a warning into it [00:00] desrt, I can do that today [00:04] is jasoncwarner_ moonlighting? https://twitter.com/#!/jasoncwarner/status/190589693774147584 [00:05] robert_ancell: docs updated [00:05] desrt, yay \o/ [00:05] chrisccoulson, hah! owned [00:05] robert_ancell: i appreciate your help on my quest to have "ca.desrt" be the first item in everyone's dconf-editor! [00:06] desrt, I'm going to register aaaa.ac and put some required Ubuntu schema into it [00:07] actually just a .au would beat you :) [00:07] robert_ancell: au. seems like a rather obvious choice for you [00:07] indeed [00:07] desrt, nah, two weeks and I'm outta here! [00:07] back to .nz? [00:08] desrt, yup [00:08] nice. christchurch? [00:08] desrt, Auckland [00:09] seems a bit less exciting, but still nice :) [00:18] hmmm, i guess i'm going to have to set up a KVM instance with oneiric on it [00:19] robert_ancell: you're from nz originally ? [00:20] lifeless, yup, chch [00:20] robert_ancell: TIL [00:42] robert_ancell: Good morning! [00:42] RAOF, hello [00:43] Thinking about wayland experiments for 12.10? [00:43] RAOF, yup, not sure if it has to be wayland but just general improvements there [00:43] RAOF, what time is good for a chat? [00:44] In an hour or so should be good. [00:44] I'll have finished breakfast, etc :) [00:44] RAOF, ok [01:19] robert_ancell: So, how would you like to call? [01:20] slash chat. [01:26] RAOF, google? [04:59] Good morning [05:07] hi pitti [05:17] good morning [05:57] robert_ancell: is there anything further to be done on bug 844044? [05:57] Launchpad bug 844044 in unity-greeter "Unity Greeter - Add Network Login option" [High,Confirmed] https://launchpad.net/bugs/844044 [05:57] robert_ancell: it's marked for precise [05:57] robert_ancell: is that going to stay a manually enabled admin option, or on again by default? [05:58] pitti, it's manually enabled currently, but I still don't really know what design wants [05:58] pitti, perhaps we should just close it and let a new issue be opened if the current solution is not working well [05:58] robert_ancell: yes, it seems the current implementation matches the description [05:59] and the title, too [05:59] robert_ancell: ok, please close then [06:00] robert_ancell: can you reproduce bug 870297? [06:00] Launchpad bug 870297 in lightdm "Lightdm logins not being logged in wtmp" [High,Confirmed] https://launchpad.net/bugs/870297 [06:00] pitti, no, but others seem to be able to [06:00] it's working fine here [06:00] I'll drop the milestone, seems SRUable to me [06:01] yeah, if anyone can work out what's going on [06:03] TheMuso: we can remove the at-spi source now, right? [06:04] pitti: I think so, yes. [06:04] -- precise/universe build deps on libatspi-dev: [06:04] gnome-mag [06:04] java-access-bridge [06:04] pyspi [06:04] TheMuso: oh argh, seems not :/ [06:05] Yeah just double checking myself and saw those. [06:05] TheMuso: or could these be removed along? [06:05] TheMuso: binary depends look better [06:05] -- precise/universe i386 deps on libatspi1.0-0: [06:05] gnome-mag [06:05] python-at-spi [06:05] python-at-spi-dbg [06:05] python-at-spi is itself transitional now, isn't it? [06:05] ah no, that was python-pyatspi [06:05] this is from pyspi [06:05] No, thats different. Python-at-spi is some old old bindings that weren't even used in the latter at-spi v1 days. [06:06] pyspi can certainly go, too [06:06] at-spi source package builds python-pyatspi binary, which was used. [06:06] dogtail needs pyspi, meh [06:06] And yes, gnome-mag and java-access-bridge could be kicked too. [06:07] TheMuso: hm, at this point we need a removal bug to keep track, I think [06:07] Yeah. [06:09] RAOF: any idea about bug 827934 ? [06:09] Launchpad bug 827934 in colord "colord crashed with SIGABRT in raise()" [High,Confirmed] https://launchpad.net/bugs/827934 [06:12] pitti: I looked into it, but didn't make a whole lot of headwind before being pulled away; it seemed to be associated with some other libdbus madness, but I couldn't see anything obvious. [06:17] pitti, so for bug 949782 that would have to be SRU'd as well - do we drop the precise target? [06:17] Launchpad bug 949782 in unity-greeter "No way to disable start-up sound" [Medium,Triaged] https://launchpad.net/bugs/949782 [06:17] robert_ancell: you don't want to upload it to precise final? [06:18] pitti, aren't we past final freeze? [06:18] robert_ancell: it doesn't change UI, it's just a config option, no? [06:18] yes [06:18] robert_ancell: yes, but that just means we are cautious when reviewing patches [06:18] pitti, oh, a "final" freeze :) [06:18] ok, I'll upload it now [06:18] robert_ancell: today is the day when we originally meant to freeze the archive [06:18] but skaet wanted to do it a week earlier, for extra caution [06:19] robert_ancell: freeze == "all uploads are cross-checked by release team", not "nothing can go in any more" [06:19] in the latter case, we could just release :) [06:19] ok [06:20] robert_ancell: hang on [06:20] robert_ancell: do you actually need the canberra context if this option is off? [06:20] pitti, what happened to -proposed? I'm confused now, should I put things in precise-proposed or precise? [06:20] pitti, I guess not [06:20] robert_ancell: you can use -proposed if the package takes long to build or archive skew causes uninstallability [06:20] neither seems to be the case here, though [06:39] robert_ancell: question for you in bug 980532 [06:39] Launchpad bug 980532 in shotwell "Build with unity support" [Wishlist,Triaged] https://launchpad.net/bugs/980532 [06:40] pitti, yup === tkamppeter_ is now known as tkamppeter [07:44] morning folks [07:45] 2 weeks to release and latest updates have left me with no dekstop on boot up, great start to the day :( [07:46] good morning everyone [07:48] chrisccoulson: nothing good about this morning :( === pstolowski is now known as pst === pst is now known as pstolowski [07:50] hey [07:50] has anyone done updates yesterday and run into issues this morning [07:50] hey czajkowski, what sort of issues? [07:50] doing updates now again hoping I can get desktop back [07:51] seb128: machine boots up, login screen arrives, enter password, and it logsin in [07:51] hey seb128, czajkowski [07:51] did you do partial upgrades using proposed? [07:51] am then stuck looking at the wallpaper [07:51] hey chrisccoulson, how are you? [07:51] the dasher and stuff doesnt load [07:52] update and dist-upgrade are being run now [07:52] seb128, yeah, not too bad thanks. had a bit of a panic last night though when i saw https://bugzilla.mozilla.org/show_bug.cgi?id=744847 [07:52] Mozilla bug 744847 in XPCOM "crash in nsAppShell::ProcessNextNativeEvent @ g_main_context_. with Linux kernel 3.0.0-18 on Ubuntu 11.10" [Critical,New: ] [07:52] huge spike in firefox crash volume for people on oneiric ;) [07:53] caused by us [07:53] czajkowski, dpkg -l | grep unity? did you uninstall unity by upgrading at a bad time with proposed enabled? [07:53] oh, gookd robert_ancell did the shotwell change, now I just have to convince pitti to ack the upload ;-) [07:53] czajkowski, see what I wrote before [07:54] chrisccoulson, what did you do to oneiric users?! ;-) [07:54] seb128, we uploaded a broken kernel to proposed which caused applications to crash [07:54] oh, kernel issue? [07:54] "nice" [07:55] yeah, they got over 2000 crash reports from the same 2 signatures since 2nd april [07:56] seb128: unity still there [07:56] czajkowski, can you pastebin your .xsession-errors? [07:56] chrisccoulson, is that a lot of them? [07:56] seb128: if you can tell me how sure :( [07:56] chrisccoulson, I'm surprised so many people run proposed, did that kernel hit upgrades? [07:57] seb128, it's a lot for linux. the 2 signatures are the #1 and #4 top crashes for all linux users [07:57] czajkowski, try to log in, when you get the empty background, ctrl-alt-f1, log in, cp .xsession-errors where somewhere is an usb stick or something [07:58] czajkowski, or somewhere is another dir, then sudo restart lightdm and log into a non unity session if you have one installed [07:58] dont have non unity installed [08:02] seb128: just waiting on upgrades to finsish than shall resrtart lightdm [08:02] thanks for the help [08:05] yay, we get a nice shiny new hire car today :) [08:06] seb128: after updates and reboot still stuck at login same when I restart the lighdm [08:06] *lightdm [08:08] chrisccoulson, new owned car or replacement ranted while you get yours fixed? [08:08] seb128, yeah, it's just whilst my car is repaired [08:14] czajkowski, can you get the log? [08:14] attempting to find a usb key to get it off machine to mail you [08:14] but at my folks house so trying to find this could be interesting [08:15] czajkowski, can you scp to chinstrap maybe? [08:16] czajkowski, i.e log to the vt and scp .xsession-errors chinstrap.canonical.com: [08:18] will try [08:23] seb128: are you available to review a merge proposal? :) [08:23] bkerensa, depends of what is to review? [08:24] seb128: change to the Landscape name in System Settings [08:24] to make it more precise and less vague [08:24] bkerensa, where is the diff? [08:25] seb128: https://code.launchpad.net/~bkerensa/ubuntu/precise/landscape-client/fix-for-962974/+merge/101839/+preview-diff/+files/preview.diff [08:25] oh [08:25] bkerensa, no way [08:25] ;p [08:25] bkerensa, string freeze was 3 weeks ago [08:26] seb128: we need a exception right and thats not happening? [08:26] we can't change it that late [08:26] bkerensa, correct [08:26] you would break all translations [08:26] seb128: yeah [08:26] mpt, ^ [08:27] :P [08:27] (I saw you discussed it on #ubuntu-devel) [08:55] hey seb128 [08:55] seb128_: shotwell> I'm mostly concerned about how much this has been tested [08:56] i. e. new crashers, regressions, UI weirdnesses, etc. [08:56] pitti, hey [08:57] pitti, it was on until yesterday [08:57] oh, no, we lacked the build-depends [08:57] pitti, well, that's the whole code: http://git.yorba.org/cgit.cgi/shotwell/commit/src/UnityProgressBar.vala?id=6199368a3b913c7ecc9d4664c96fc9d58b7fa337 [08:57] pitti, it's really a small enough function to display a progress bar over the launcher icon [08:58] ah, for imports? [08:58] pitti, yes [08:59] seb128_: thanks for the pointer. updated bug, accepting [08:59] pitti, the yorba guys have some rigourous testing as well usually, we have very few important issues with shotwell [08:59] pitti, thanks [09:00] brb, picking "suspend" rather than "log out" in my guest session screwed my IRC [09:00] it won't reconnect to some servers [09:03] seb128, pitti: I put a possible "fix" for #938090 into the report, but its a feable attempt, I get hit by this in software-center too, so ideas are welcome [09:05] bug #938090 [09:05] Launchpad bug 938090 in apport "apport-gtk crashed with SIGSEGV in _gtk_icon_helper_get_storage_type()" [Medium,Confirmed] https://launchpad.net/bugs/938090 [09:05] mvo, hey, wie gehts? [09:05] mvo: hallo! looking [09:06] mvo, oh, I remember we discussed that issue earlier in the cycle [09:06] mvo: oh, can you reproduce this crash? [09:07] seb128: hey, danke, gut! [09:07] pitti: well, not entirely easily, but sort of, is-cneeds to get closed at exactly the right time [09:07] s-c I mean [09:08] mvo, that's bug #911619 back right? [09:08] Launchpad bug 911619 in gwibber "gwibber crashed with SIGSEGV in _gtk_icon_helper_get_storage_type()" [High,Fix released] https://launchpad.net/bugs/911619 [09:11] yeah, I think so [09:11] mvo, bug #914393 quite some duplicates for s-c [09:11] Launchpad bug 914393 in software-center "software-center crashed with SIGSEGV in _gtk_icon_helper_get_storage_type()" [Medium,Confirmed] https://launchpad.net/bugs/914393 [09:13] pitti, mvo: well, it's probably a "use after unref" issue [09:25] mvo: I think I can reproduce [09:25] mvo: I think I can turn that into a test case in apport [09:26] pitti: woah, thats great, looking forward to see that [09:26] mvo: assuming it's related to the spinner (i also have that in apport) [09:27] yeah, in s-c as well [09:28] hm, doesn't seem to be reproducible in apport as easily as in s-c (where I have 100% hit rate) [09:34] mvo: so in both cases it's from calling image.set_from_pixbuf() [09:37] pitti: so not the spinner, but a explict call to that? is it happening on close for you as well? or is that unreleated? [09:37] mvo: I can reproduce the software-center crash, but not the one in apport [09:37] mvo: I'm currently trying to make it crash around that call [09:41] dpm, hey [09:42] heya seb128 [09:42] dpm, how are you? [09:43] pitti: I found that in s-c its crashin in _update_app_icon() and there in self.icon.set_from_pixbuf() and it appears its happening when Gtk.main_quit() is called or while its processing outstanding events, looking further now [09:43] seb128, fine, thanks, and you? How are the final days of release going? [09:43] mvo: right, I suspect something like taht [09:43] mvo: in the apport trace I see an event handling for the "reopen" button, which closes apport [09:43] dpm, I'm good thanks, release seems on track ;-) [09:43] ;-) [09:43] dpm, do you have any clue about bug #978724 [09:43] Launchpad bug 978724 in ubuntu-translations "update-notifier needs to build translation template" [High,Triaged] https://launchpad.net/bugs/978724 [09:44] mvo: but the icon is set way before that reopen button is even displayed, so I'm currently trying to figure out how this can happen [09:44] dpm, update-notifier ships a po/update-notifier.pot in source but it's not being imported by launchpad [09:44] dpm, do you know how to debug those issues? [09:44] pitti: it looks like I could work around it in s-c by simply calling sys.exit(0) after main_quit [09:44] dpm, the template was manually uploaded yesterday but the previous one was from 2011 still, the infos on https://translations.launchpad.net/ubuntu/precise/+source/update-notifier/+pots/update-notifier/+admin look fine though [09:45] mvo: yes, I'll do something similar, as otherwise the apport process hangs until all the other threads are done [09:45] dpm, is there anything special about sources that are not stripped from their translations maybe? [09:45] mvo: that'll fix the behaviour, but I'd still like to find out why this crashes [09:45] pitti: indeed, its just a workaround [09:45] good 'nuff, though [09:45] seb128, ah, I saw Steve's reply, but didn't look further. To debug these issues I generally build the package locally and look at the translations tarball (https://wiki.ubuntu.com/UbuntuDevelopment/Internationalisation/RecipeVerifyingTranslationUploads) Let me have another look at the bug [09:45] mvo, pitti: the issue is not likely when the icon is "set", but rather when it's unrefed [09:46] dpm, thanks [09:46] seb128: really? https://launchpadlibrarian.net/89523197/Stacktrace.txt doesn't look like that [09:46] pitti, why is gtk_image_reset() called? [09:46] is there a way to get the refcount of it easily via pygi? [09:46] seb128, yeah now the https://translations.launchpad.net/ubuntu/precise/+source/update-notifier/+pots/update-notifier/+admin will look ok, as kelemengabor manually uploaded the template [09:47] seb128: not sure, GTK does that by itself; apport just calls gtk_image_set_from_pixbuf [09:47] mvo: myobject.__grefcount__ [09:47] dpm, it was looking ok before as well, out of the import date [09:47] ah, I see [09:47] ta [09:49] pitti, mvo: http://pastebin.ubuntu.com/927656/ that was part of the discussion about that issue in gwibber earlier in the cycle if that's useful === debfx_ is now known as debfx [09:54] dpm, so yeah, following that wiki, pkgbinarymangler doesn't create a _translations.tar.gz for packages on the "don't strip" list [09:54] seb128, I believe I see what happens: as u-n is being blacklisted in pkgbinarymangler, the package does not generate a translations tarball, so neither a .pot file generated during build (which is not created anyway) nor the .pot file included into the package are put in a translations tarball and given to Launchpad. pitti, does that sound about right for a package blacklisted in pkgbinarymangler? As much as I dislike keeping track of templates needin [09:54] g manual attention, one option is to manually upload the template [09:54] yeah, we got to the same conclusion :) [09:54] so pkgbinarymangler bug indeed [09:55] the "don't strip" doesn't mean "don't import" [09:55] ah, right [09:55] it just means "don't clean the binaries" [09:55] gotcha [09:55] dpm, thank for the wiki pointer, I learnt something [09:55] cool :) [09:55] dpm: the .pot generation should not be affected by this, only the stripping and translation tar build [09:55] ack [09:56] pitti, where is launchpad importing the pot from? [09:56] from the tarball [09:56] pitti, if there is no translation tar there is no import? [09:56] so I guess it should not be blacklisted, but u-m should instead set NO_PKG_MANGLE? [09:56] so that the tarball is still being built [09:56] pitti, what's the blacklist for then? [09:57] pkgbinarymangler will not touch blacklisted packages _at all_ [09:57] that's the issue there [09:57] i. e. for packages which just don't want to use LP transltaions and langpacks [09:57] like language-pack* itself, dpkg, iso-codes, and apparently also apt and update-notifier [09:57] pitti, language-selector and update-notifier should probably be dropped from there then and just use NO_PKG_MANGLE? [09:58] yes [09:58] thanks [09:58] bug 562900 [09:58] Launchpad bug 562900 in update-notifier "Please include translations from Launchpad in the package" [Medium,Confirmed] https://launchpad.net/bugs/562900 [09:58] Sweetshark, good morning! A translator pointed out to me that Quicklist items in LO are all in English. I haven't followed that, but he told me that at some point the translations were included in a patch, but dropped later on and the recommendation was to translate them upstream. While that's fair enough, my understanding is that upstream hasn't got any infrastructure to deal with quicklist translations, so there is no way translators can provide the [09:58] m. [09:59] So we end up with a regression: previously translated strings are now in English [09:59] pitti, why did you do it this way by then rather than using the variable? [09:59] Sweetshark, would it be possible to get the translations patch back? [09:59] pitti, sorry for keep you away from the gtk debugging, I'm almost done with questions ;-) [09:59] no special reason, I just merged the proposed change [10:00] but we can revert that, and use NO_PKG_MANGLE, of course [10:00] seb128: actually [10:00] NO_PKG_MANGLE will also not build a translation tarball [10:00] pitti, what do you recommend we do? I'm not sure to understand the pro and con enough to have an opinion [10:00] dpm: ^ [10:01] pitti, the issue is that ideally po and pot should still be imported for those, we want the launchpad side to be uptodate even if we don't strip [10:01] so we don't currently have a way to say "build a translations tarball, but don't strip the mo files" [10:01] ok [10:01] pitti, so let's keep it as a pkgbinarymangler bug open for next cycle [10:01] well, in a way we do [10:02] we need to manually upload the translations and template meanwhile [10:02] you can ask LP to import the pot from the branch [10:02] I do that with apport and jockey upstream branches, it's quite nice [10:02] ah [10:02] pitti, thanks! [10:02] pitti, yes, but only for the upstream project, the Ubuntu package still needs a package upload [10:02] so the apport blacklist and NO_PKG_MANGLE are pretty much equivalent [10:02] for translations, anyway [10:02] apport->pkgbinarymangler? [10:02] the former is better for packages that we sync, as it avoids a packaging delta [10:02] err, yes [10:03] ;-) [10:03] Freudian slip [10:03] dpm, well I guess we should check packages not mangled to see if other templates need an update [10:03] I will do that [10:04] pitti, seb128 in that case, perhaps we keep the templates for those two manually updated and pkgbinarymangler needs a bug requesting a new feature to import templates but not strip .mo files? [10:04] dpm: right [10:04] dpm, while you are here, could you look at bug #979825 ? do you know how,when are ddtp datas syncs done? [10:04] Launchpad bug 979825 in ubuntu-translations "Do a sync with Debian for Ubuntu 12.04 LTS" [Undecided,New] https://launchpad.net/bugs/979825 [10:05] dpm, pitti: let's reuse bug #978724 for the pkgbinarymangler, I'm updating the title [10:05] Launchpad bug 978724 in ubuntu-translations "update-notifier needs to build translation template" [High,Triaged] https://launchpad.net/bugs/978724 [10:05] seb128, that would probably be a question for mvo. I know he does ddtp syncs every now and then, but I don't know how frequently ^^ [10:05] seb128, ack on pkgbinarymangler bug [10:05] pitti: I guess you know this already, but I can confirm that "destroy" is called on self.icon so the priv->icon_helper is cleared but then the icon is used again [10:06] dpm: meh, it turns out its currently broken because debian moved to descriptionless packages files too [10:06] (or we did and that broke it) [10:06] I need to check, but last night when I triggered a sync of it I discovered its currently not finding translations [10:07] bummer [10:12] dpm: noted [10:12] dpm: yes, should be doable. [10:13] pitti: I put some more info in the bug, not sure what the right approach for the fix is though, ideas very welcome [10:13] Sweetshark, cool, do you think it'd be worth re-enabling the old wiki page containing the translations, do a final round call for translations and including them in the patch? [10:14] dpm: upstream basically has the infra, its just that our quicklist l10n patch is very ugly and ad-hoc (which is likely why it broke), so it can not be upstreamed as is. [10:15] Sweetshark, right, but we shouldn't be sacrificing translations because of that [10:15] dpm: sure, sure. [10:17] Sweetshark, np, thanks. So what do you think the next steps are? Do you think it's worth doing a new round call for translations and include them in a new patch, or do you prefer just reviving the old patch even if it means having less translations? [10:18] mvo: heh, I just attached a python reproducer :) [10:18] it's by and large the same [10:18] pitti: I think I have a idea, give me a minute to attach a patch that may or may not work and then I go for lunch :) [10:19] mvo: probalby easiest to just kill all pending signal handlers, or just sys.exit().. [10:21] dpm: as for a final round call, I am abit hesitant. While that stuff is nice to have (and the patch needs to be fixed), I am unsure if I will be able to take care of that given the other issues on my todo list. [10:21] dpm: fwiw the patch is in, it just doesnt work :( [10:22] Sweetshark, I understand, that's why I suggested the second option of just reviving the patch. Does that sound doable (assuming translations still apply)? [10:22] ah, bummer [10:22] seb128, I noticed you did the xdg-user-dirs upload with exported LP translations, thanks! We keep a list of packages that need translations exported on https://wiki.ubuntu.com/NonLanguagePackTranslationDeadline (see "Rebuilding packages" section). Would it be possible that someone from the desktop team does the exports for language-selector, example-content, update-manager, yelp-xsl and (possibly later due to recent string changes) update-notifier? Wo [10:22] uld it be worth filing bugs for each one of those? [10:23] dpm: so, I will try to fix it, but it does not have first priority sorry. [10:23] Thanks Sweetshark, I appreciate it [10:23] dpm, I can do those [10:23] dpm, well maybe mvo can do update-manager [10:23] dpm, but I will look at the list and do language-selector and yelp-xsl to start [10:24] seb128, excellent, thanks! Going forward we should enable translations and message sharing for all of those projects, which would save us from doing the manual exports, as translations would already land in the upstream packages [10:24] err, upstream *projects [10:24] dpm, right [10:25] dpm, well that wouldn't work for xdg-user-dirs shared-mime-info and yelp-xsl [10:25] pitti, seb128: I pushed a (untested) patch to https://bugs.launchpad.net/ubuntu/+source/apport/+bug/938090/comments/10 with some background, that maybe the solution, but I have to admit that I'm not too familiar with the lifecycle of the gobject stuff, so I may be off here [10:25] Launchpad bug 938090 in apport "apport-gtk crashed with SIGSEGV in _gtk_icon_helper_get_storage_type()" [Medium,Confirmed] [10:25] but that would be good for stuff we maintain [10:25] seb128: what do I need to do? just upload? [10:25] seb128, correct. I meant the Ubuntu projects in LP only, sorry. I'll take a TODO to poke maintainers [10:25] mvo, having desrt's to review it would be good if you can wait after lunch [10:26] mvo, that still seems a bug in your code to me though ;-) [10:26] mvo, like you C snipped, don't clean an object after it has been destroyed... [10:26] seb128: I would argue that ;) but yeah, I added code in s-c to not trigger this condition, but at the same time, robustness++ if its not having other issues that I'm not aware of [10:26] mvo, but yeah,I understand bindings do that for you :p [10:27] seb128: right, the C snippet is for demo purpose only, its cleary buggy code, the question is what should happen (segv vs g-crtitiacal) [10:27] pitti: aha, very nice, your python demo is much better as its much close to the real-world case and will not make seb128 complain like my C ;) [10:28] mvo, let's wait for desrt but your patch seems fine to me [10:30] thanks, I put #11 in with a diff that actually compiles and get lunch now :) [10:30] * mvo waves [10:32] mvo: ah, very nice! [11:24] desrt: hey, when you are back it would be great if you could have a look at https://bugs.launchpad.net/ubuntu/+source/apport/+bug/938090/comments/11 and tell me if that makes sense (and maybe the rational for in in comment #10) [11:24] Launchpad bug 938090 in apport "apport-gtk crashed with SIGSEGV in _gtk_icon_helper_get_storage_type()" [Medium,Confirmed] [11:24] seb128: so the patch appears to fix all the known cases of this crash, fingers crossed that its actually the right approach [12:54] dpm: can we arrange for a full precis export next Tuesday, right after the langpack translation deadline? [12:54] dpm: then I can build/upload the final packs next Wed [12:58] pitti, I'll have to arrange a one-off export with the LP guys, but it shouldn't be a problem, yes [12:58] dpm: FYI, we just got another daily set of packages [12:59] dpm: I disabled the cronjob now [12:59] pitti, ok, thanks [13:02] mvo: one comment: if the only thing that the vfunc now does is to chain up then stop overriding it [13:02] mvo: also: file/patch upstream please [13:06] mvo: in general, though, you should be vary of releasing things in finalize instead of dispose when it comes to gtk -- reference cycles creep in this way [13:07] desrt: oh, so should I use dispose instead of finalize? happy to do that, I'm pretty new to this [13:07] mvo: no. that would not help in this case :) [13:07] mvo: really -- you should not access-after-destroy :) [13:07] (destroy is more or less equivalent to dispose, fwiw) [13:07] like gtk_widget_destroy() ends up calling g_object_dispose() [13:08] the trouble with unref in finalize is that if the thing you are unreffing has a reference to some part of the widget tree you could end up with a reference cycle [13:08] in this case i believe that to be unlikely [13:08] the way we usually deal with this is to try to make functions depending on the now-null value to be resiliant to it being null [13:08] desrt: aha, thanks! it seems its mostly a issue with the bindings AIUI, I will clean it up based on your suggestion and file upstream [13:08] which i think is a waste of time, personally :) [13:08] * desrt loves finalize [13:09] so ya... drop the destroy() vfunc override entirely and it looks good to me -- but maybe others have different things to tell you about it [13:10] ok [13:14] * mvo wonders idly why his almost_fixed_height patch in #607447 did not even got a single reply [13:14] because it has almost in the name and people wait for the final version ? :) [13:15] mvo: it's on my list to tackle next cycle [13:15] mvo, nobody is actively maintained that part of GTK I think [13:15] maintaining [13:15] desrt, hey, happy friday! [13:15] mvo: the answer is (a) time constraints and (b) general fear of touching anything inside gtktreeview [13:15] seb128: i'm starting on the beer already :D [13:16] seb128: happy friday to you too [13:16] desrt, chrisccoulson is having a bad influence on you :p [13:16] chrisccoulson: come visit. we'll have beers together. [13:16] heh :) [13:17] talking of beer, my beer delivery still hasn't arrived! [13:17] you have beer DELIVERY? [13:17] my god.. what is this technology? [13:17] desrt, yeah, i order beers that i can't find in local shops :) [13:18] is it a bad situation where you are or do you just have _really_ exotic tastes? :) [13:20] desrt: bug #674050 in bugzilla [13:20] Launchpad bug 674050 in docky "Clicking CPU Monitor applet opens web browser when gnome-system-monitor isn't installed" [Undecided,Invalid] https://launchpad.net/bugs/674050 [13:20]