[08:09] * rye_ logs out for reboot [08:28] Happy Friday, folks! :) [08:49] sweet, somebody stole my IRC nickname === rye_ is now known as rye [08:54] looks like i got it back [08:57] rye, are you sure it was not you :) [08:58] * mandel mandel [08:59] mandel: http://ubuntuone.com/5TVaiFtH9sddWDWTnLwnRT [08:59] mandel: running autoupdate binary directly [09:00] rye, ok, looking [09:00] rye, uhhh did we deploy that! [09:00] ??? [09:00] mandel: yep, 3.0.0 official [09:01] rye, la puta!!! ok, we have to make a new installer, is probable that brian had the trial install when he built it [09:01] maaan, my windows vms became so slow it is painful [09:01] rye, is just a small mistake, but makes us look kind of bad :) [09:01] rye, do you have a bug number for that? [09:01] mandel: well, it definitely raised a wtf look on my face [09:01] mandel: filing one [09:02] rye, please add briancurtin as the person to take care of it, I'll talk with him and ralsina to fix it asap [09:08] mandel: bug #986078 [09:08] Launchpad bug 986078 in Ubuntu One Windows Installer "[3.0.0] AutoUpdate was created with an evaluation version of BitRock InstallBuilder" [Undecided,New] https://launchpad.net/bugs/986078 [09:08] rye, thx! [11:09] good morning! [11:11] gatox, morning, me needs you :) [11:12] mandel, what happend? :P [11:12] gatox, can you please approve the following: https://code.launchpad.net/~mandel/ubuntuone-dev-tools/fix-runtests/+merge/102828 [11:12] * gatox looking.... [11:12] gatox, also, cna you confirm that with the new changes that we have for lp:~urbanape/ubuntu-sso-client/initial-darwin-port we have a segmentation fault? [11:13] mandel, yes..... i confirm that yesterday..... and also a lot of tests fail in windows because an api change..... do you want to see the trace.... i already have them in a paste [11:13] gatox, I think is because glib and qt are being imported at the same time which makes the code import versions 2 and 3 of glib/gtk which brakes things :) [11:13] gatox, no need, as long as it happens to both, I'm ok :) [11:14] mandel, i'm getting this for linux: http://paste.ubuntu.com/937410/ this for windows: http://paste.ubuntu.com/937423/ [11:14] mandel, ahhhh :P ok [11:14] gatox, if you approve the ubuntuone-dev-tools we will have that in jenkins too, I recommend you set you irc client to listen for u1-jenkins in u1-internal [11:15] mandel, roger that [11:15] gatox, in xchat is under prefs->alets->nick names to always highlight :) [11:15] good [11:16] mandel, done [11:16] gatox, the approval or the highlight? [11:18] mandel, highlight [11:18] mandel, and now the approval [11:19] gatox, superb! [11:21] gatox, and since is your review day, can I have a review for https://code.launchpad.net/~mandel/ubuntuone-dev-tools/squid-errors/+merge/102825 and for https://code.launchpad.net/~brian.curtin/ubuntuone-client/run-tests-buildout-cleanup/+merge/102394 [11:21] mandel, jeje i can't say no :P [11:22] gatox, I know, and also the good thing is that you are the first one usually to arrive :) [11:33] gatox, cna you in the mean time look at the one I gave you from brian? [11:34] mandel, i'm reviewing the both branches you gave me [11:34] gatox, sweet! [11:39] mandel, +1 to your branch [11:40] gatox, great :) [11:40] gatox, when that lands I'll be able why we cannot build on L u1-dev-tools [11:43] gatox, this one https://code.launchpad.net/~mandel/ubuntuone-dev-tools/params-runtests/+merge/102836 passes the parameters to runt-tests and skipslint :) [11:43] gatox, if you do me a quick review I would be very very happy [11:44] mandel, ok, on it...... i was looking at brian's branch making sure that doesn't brake already installed system to run-tests...... but i should install a new vm to fully test that :S [11:47] mandel, ohhhhh the lovely GOTO jeje..... +1 on the last branch [11:48] gatox, yeah... batch, beautiful! [11:49] yeyyyyy..... i already have a cleanvm..... i can fully test brian's branch [12:34] gatox, I'm off to have lunch [12:34] * mandel lunch [12:34] mandel, ok [12:44] rye, mandel: we have a license for it, and yes, that means we have to do a new build and sign it. Ok, let's take it as an opportunity to sign the autoupdater while we are at it. [12:44] and good morning [12:44] thisfred: you up already? I want to give you some Qt lessons :-) [12:45] ralsina, good morning [12:47] ralsina: from PyQt4.QtLesson import QtSome [12:47] rye: hehe [12:48] ralsina sorry yes am up :) [12:48] thisfred: ok, here's the deal in 6 lines [12:48] 1) Do the .ui using designer (and add it to the repo) [12:48] I did the first half :) [12:49] 2) compile the .ui using pyuic4 from setup.py and don't add the .py to the repo. [12:49] 3) In your own code, import the generated .py and use setupUi to give you UI [12:49] I did the first half of that as well :) [12:49] 4) Then connect stuff using signals and slots [12:49] 5) ... [12:49] 6) Profit! [12:50] thisfred: I have a tutorial on how to do most of this stuf here: http://lateral.netmanagers.com.ar/stories/BBS47.html [12:50] so what I did (wrong) was throw away the .ui and add the generated code to the repository [12:50] neat! thx [12:52] thisfred: you can re-generate the compiled .py manually after you touch the .ui and add it to the repo, too [12:52] thisfred: but that's bad practice because mybe future versions of the ui compiler are better [12:52] ralsina, right [12:52] Quoting myself from that tutorial: "Let me put that in these terms: IF YOU EDIT THE UI FILE (WITHOUT USING DESIGNER) OR THE GENERATED PYTHON FILE YOU ARE DOING IT WRONG! YOU FAIL! EPIC FAIL!. I hope that got across, because there is at least one tutorial that tells you to do it. DON'T DO IT!!!!" [12:52] so the makefile should take care of generating the code? [12:52] thisfred: right [12:53] thisfred: you could do a Makefile or add something in setup.py like we have in u1cp [12:53] mandel, gatox: yeah, I'll get to the windows API changes this morning. [12:53] the reason I did not do that was, it lives in u1db for now, and I don't want to pollute that with qt builddeps [12:53] hi, all [12:53] but I still want the example code to be runnable [12:53] urbanape, ok [12:53] thisfred: right [12:54] thisfred: then maybe adding the compiled code for the time being is not horrible [12:54] thisfred: alternative: load the .ui file dynamically [12:54] ok, sounds like a decent compromise [12:54] thisfred: and sidestep the whole issue. It's not hard [12:54] thisfred: it does make it slightly harder to package for windows though [12:54] ok, that sounds even better, is that in the tutorial? [12:55] thisfred: I can find you an example [12:55] that would be awesome [12:56] thisfred: https://pastebin.canonical.com/64666/ [12:56] thisfred: sorry about the comments in spanish but it's from a book I was writing ;-) [12:57] thisfred: it assumes the .ui file is in the same folder as the .py that's loading it. Adjust accordingly [12:57] thisfred: after you do that, all the ui components are in self.ui.object_name and such [12:59] thisfred: and that's it. [13:00] thanks! [13:02] Good for my technical Spanish :) [13:02] cargamos los iconos DEL DIABLO! [13:03] I find putting that at the end of every sentence spices things up a bit. [13:06] hmm [13:16] thisfred: there's a lot more where that came from: http://nomuerde.netmanagers.com.ar/5.html [13:17] thisfred: it's a media player, so you will like it ;-) [13:18] it's not quodlibet, so it has one thing going against it :P [13:18] heh, the gui is the easy part. I only partly agree with that :) [13:19] thisfred: hehe [13:19] thisfred: it's the most minimalistic media player humanly possible. It has one icon and you can only listen to one radio station by default :-) === IAmNotThatGuy is now known as Sidewinder1 === Sidewinder1 is now known as IAmNotThatGuy [13:21] * dobey wonders when u1db server will be widely usable, and when android u1db will be ready [13:22] eww [13:23] la GUI es la parte no es tan facil [13:27] dobey: it depens on what GUI and what not-GUI it is [13:27] dobey: but it's easiest to do a functioning GUI than a functioning backend for almost everything [13:27] dobey: although a good frontend is harder than most good backends [13:27] dobey: so, frontend has much more variance [13:28] it's very easy to make a very bad GUI, yes [13:28] but it's also very easy to make a very bad back-end [13:28] making a great GUI is very hard. and harder if you're doing it in English and you're not a native speaker [13:28] * ralsina is guessing thisfred's UI is going to be easier than u1db ;-) [13:29] dobey: that's why I only use icons in sign language [13:29] yeah, demo app doesn't need great UI [13:29] yeah, especially since the ui is not the point of the example code at all [13:29] it needs great comments [13:29] It does :) [13:29] dobey, thisfred: it needs doctests [13:30] so it can have truthul comments [13:30] truthful [13:30] ralsina: meh, I think doctests are good for API, I find them annoying in docstrings [13:31] but I'll keep an open mind, maybe they'll come in handy [13:31] doctests are good for stabbing yourself in all your limbs [13:33] haha [13:33] doctests that are not exhaustive but are good examples, are awesome [13:37] what you need, is a lintian tool which verifies that everything is properly documented [13:38] of course, python also makes that extremely hard to do 100% [13:41] dobey: there is no tool in the universe that can verify anything is properly documented. But I understand what you mean. [13:41] * mandel back [13:42] well, not necessarily understandably documented, but all inputs/outputs/exceptions are in the documentation for a function. and the spelling/grammar is reasonably correct [13:42] ralsina, briancurtin ping [13:42] mandel pong [13:42] mandel: pong [13:43] mandel: what is all this runtests-params nonsense? [13:43] ralsina, briancurtin, got a very cure bug for you, is bug bug #986078 [13:43] Launchpad bug 986078 in Ubuntu One Windows Installer "[3.0.0] AutoUpdate was created with an evaluation version of BitRock InstallBuilder" [Undecided,New] https://launchpad.net/bugs/986078 [13:43] briancurtin, ralsina, and that was deployed to the users :) [13:43] uh [13:43] * ralsina looks at the mail sending brian the license key. Asks for that to be added to the build docs [13:43] briancurtin, hi! i'm trying to test this https://code.launchpad.net/~brian.curtin/ubuntuone-client/run-tests-buildout-cleanup/+merge/102394 i've installed the buildout in a clean vm, and then merge your branch with the one of u1-client inside parts..... how i should run the tests to test this branch? [13:44] heh [13:44] mandel, ralsina: i definitely applied that license, so i'm not sure if it went away or what the deal is...looking now [13:44] briancurtin: ack, please take a look. But don't worry too much. [13:44] bitrock's "we should respond within 12 hours" thing doesn't hold very well does it :( [13:44] dobey: about the version logic? [13:44] dobey, so, the run-tests of ubuntuone-dev-tools was not working (not finding python) and was not forwarding the parsm to u1trial, which mean we could not pass the reporter and get nice reports when running the tests on jenkins [13:44] dobey: they have been responsive for us in the past [13:44] ralsina: about support requests, but that's what i asked for support on yeah :) [13:45] dobey: ack [13:45] dobey, so now you can do run-tests /skip-lint --reporter=subunit [13:45] dobey, and we have the tests of ubuntuone-dev-tools in jenkins like the other projects /cc ralsina [13:45] mandel: oh, that seems rather nasty [13:45] dobey, is fixed, it was a very simple fix in the .bat [13:46] we can now trust that jenkins will tell us when we broke u1-dev-tools on windows [13:46] mandel: yes i saw the branch. but i mean that fix seems nasty [13:46] dobey, oh, yes, is batch, with gotos and all that.. [13:48] ralsina, briancurtin, I would not be to worried, but is something to consider for whenever the .exe comes out of jenkins :) [13:48] we probably need some better magic for that [13:48] oh well [13:48] gatox: so if you already have the lp:~brian.curtin/ubuntuone-windows-installer/buildout-env branch merged, make sure you run "env.bat" from the devsetup folder. that sets the path and some other things up. then in u1client you just run "run-tests.bat" and it should work [13:48] briancurtin, great..... i'll test that [13:50] dobey, I wonder how.. but is the runtests.bat, so I expect some ugliness in there as long as it is just in there [13:50] ralsina, 1-1 whenever you want :) [13:52] briancurtin, FYI we have u1-dev-tools in jenkins, I did some hacks to get run-tests.bat there working, would be nice if at some point you can dome some of your magic in that one too :) [13:53] mandel: what's the issue there? [13:54] briancurtin, well, there I had to fix the way it finds python and pass parameters to the u1-trial, maybe doing the same approach you have done in the buildout branches is better [13:55] mandel: can i see what changes you had to make? [13:55] briancurtin, wow! everything working... nice branch! [13:55] briancurtin, +1 approve [13:55] gatox: cool, thanks! [13:56] briancurtin, for the u1-dev-tools, yes here is a diff: https://code.launchpad.net/~mandel/ubuntuone-dev-tools/params-runtests/+merge/102836 [13:57] dobey, (are you in your tests day?) can you review this one? https://code.launchpad.net/~brian.curtin/ubuntuone-client/run-tests-buildout-cleanup/+merge/102394 i already run this in a working env... and in a clean env installing everything using the buildout [13:57] briancurtin, approved: https://code.launchpad.net/~brian.curtin/ubuntuone-client/run-tests-buildout-cleanup/+merge/102394 [13:57] gatox, I did that one too, so dobey no need [13:58] dobey, no need..... mandel already approve it [13:58] that! :P [13:58] ralsina: pushed the changes so the ui is loaded dynamically. Now 578% nicer! [13:58] thanks! [13:59] thisfred: just doing my job! :-) [13:59] gatox, dobey, would be nice if you take a look at https://code.launchpad.net/~brian.curtin/ubuntu-sso-client/run-tests-buildout-cleanup and https://code.launchpad.net/~brian.curtin/ubuntuone-control-panel/run-tests-buildout-cleanup [13:59] on it! [14:00] * dobey needs to take a vacation [14:02] ralsina: https://launchpadlibrarian.net/102670998/Captura%20de%202012-04-20%2008%3A00%3A00.png <- waht does that say? [14:03] dobey: it's going to merge a UDF with an existing flder [14:03] dobey: and what language is that??? [14:04] * ralsina can kinda read it [14:05] ralsina: it's not spanish? [14:05] dobey: nope [14:05] dobey, nop [14:05] dobey: I would guess romanian [14:05] dobey, is catalan :) [14:06] dobey: or esperanto [14:06] or catalan [14:06] mandel: same thing ;-) [14:06] mandel: made up languages all of them [14:06] ralsina, as old as spanish: http://en.wikipedia.org/wiki/Catalan_language#Middle_Ages:_origin [14:07] mandel: which is also a made up language [14:07] just like all language [14:07] mandel: we should all be speaking in the original indostanic [14:07] dobey, also, dpm is from valencia, so you should have been able to guess it :) [14:08] ralsina: hrmm, i guess that is a stock qt dialog we're creating via code? [14:08] briancurtin, bad news: https://jenkins.errormessaging.com/view/Windows/job/ubuntuone-client-windows-test/36/console [14:08] also, what a horrible set of choices that is [14:08] "yes/no/cancel" [14:08] dobey: not sure, would need to check the code. [14:09] dobey: very not-verbs [14:09] they're not woody at all. rather tinny in fact. [14:10] briancurtin, looks like it cannot find sso, I'll see if I can fix it [14:12] mandel: is that running the new run-tests.bat? i think perhaps this grew a bit too quickly, because im not sure how the new run-tests.bat will run without an environment setup from the buildout [14:12] mandel: and jenkins already has its own deps and python setup underneath it [14:13] oh yeah it is running the new one [14:13] ah i know why it fails [14:13] briancurtin, i tested your branches with a env without the buildout [14:13] briancurtin, do you need me to get in the machine to fix it? [14:13] and they work [14:14] mandel: has your ubuntuone-dev-tools branch with the txwebserver landed? [14:14] urbanape, yes, is in trunk [14:14] k [14:14] mandel: the run-tests.bat does SET PYTHONPATH=..\ubuntu-sso-client;. - so it overwrites the one jenkins setup [14:15] briancurtin, ouch! [14:15] mandel: that makes it much easier to run the default case on a local machine, but on jenkins we don't want to touch it [14:15] mandel: perhaps we add a --jenkins flag or something, which skips setting of the path? [14:15] mandel, are you sure your devtools is in trunk?? i've just run a buildout, etc..... and it keeps getting the txwebserver issue [14:16] gatox: it is in trunk. it is not in the tarball your buildout is pulling [14:16] ahhhhh it seems that the buildout is not downloading the proper dev-tools [14:17] gatox, http://bazaar.launchpad.net/~ubuntuone-control-tower/ubuntuone-dev-tools/trunk/files/head:/ubuntuone/devtools/testing/ [14:17] gatox, is in trunk :) [14:17] gatox: dirspec and devtools should be moved to bzr checkouts under [sources] rather than tarball downloads [14:17] mandel, yes yes..... sorry..... the buildout is downloading another thing [14:17] * dobey said this the other day [14:17] gatox, I'm going to kill you for this! [14:17] :P [14:18] mandel: you have to destroy the resurrection ship first [14:18] briancurtin, hm.. of a --jenkins or we can append the python path, can't we? [14:18] jejejeee [14:18] mandel: i think we'd want to prepend it, to make sure jenkins' stuff is there first [14:19] briancurtin, make sense, can you do a small branch + bug for this [14:19] mandel: yep, doing right now [14:19] briancurtin, and do the same for the other two branches [14:19] yep [14:21] urbanape, let me know if you need any help with your branch, the segfault is probably due to using glib3 and qt at the same time [14:25] gatox: could you add 986068 to your queue, set to medium? [14:25] ralsina, ack! [14:27] briancurtin, approve: https://code.launchpad.net/~brian.curtin/ubuntuone-control-panel/run-tests-buildout-cleanup/+merge/102392 [14:27] briancurtin, and this one only a small need fixing: https://code.launchpad.net/~brian.curtin/ubuntu-sso-client/run-tests-buildout-cleanup/+merge/102393 [14:27] mandel: there is no glib3 :P [14:27] gatox: ah, merge error. i'll fix it [14:28] briancurtin, both tested in an env with and without the buildout, and everything is ok [14:28] dobey, well you know.. what ever is the new thingy [14:29] dobey, I'l terrible with those things.. [14:29] mandel: well qt supports running the glib main loop. so it shouldn't be the cause of any segfaults. there's probably a deeper problem in the tests causing it [14:31] dobey, I'm seen that happening when you have a gi.repository import and import qt but I'm not 100% sure [14:32] mandel: it's possible, but i think that's not necessarily the cause, but merely what you see on top :) [14:33] dobey, yes.. we might need to look deeper. but for that branch makins sure that no gi and qt imports are done when they should not is ok [14:37] gatox: fixed your copyright header comment [14:37] briancurtin, great.... approving it [14:54] meh. next 10 minutes are the most agonizing [14:57] briancurtin, gatox, mandel, dobey, thisfred, urbanape: standup in 4' [14:57] ralsina, ack [14:57] ack [14:57] alecu is on a conference today [15:00] hey, good morning. [15:00] I have a question. [15:01] the control panel is the wizard and the thing where you connect/disconnect, remove devices, etc. [15:01] me [15:01] me [15:01] how do you call that thing? [15:01] me [15:01] me [15:02] me [15:02] me [15:03] me [15:03] DONE: [15:03] Work on mac os (trying to figure it out how to run the tests easier, just using run-tests). Several reviews for mandel and brian. Start working on Bug #986068. [15:03] TODO: [15:03] Finish with Bug #986068, keep doing reviews (review day), try to improve the dev setup for mac. [15:03] BLOCKED: [15:03] No [15:03] Launchpad bug 986068 in Ubuntu One Control Panel trunk "Yes/No/Cancel messages appear untranslated" [Medium,Triaged] https://launchpad.net/bugs/986068 [15:03] thisfred, go [15:03] DONE: u1db demo app UI iteration 1 TODO: add tags and done status to ui BLOCKED: no NEXT: briancurtin [15:03] DONE: got installer automation done, should be able to propose today along with a few other changes to make deployment easier (embedded CRT) [15:03] TODO: propose branches, keep an eye on how jenkins responds to changes [15:03] BLOCKED: none [15:03] NEXT: urbanape [15:04] DONE: Work on darwin branch. TODO: Fix some tests and shared code. BLOCK: None. NEXT: ralsina [15:04] DONE: kid's birthday, cake, reviews, alecu 1-1, administrivia, helped thisfred with qt, little coding, lotsa thinking (hey, it's my thinking month), reports TODO: reviews, more thinking BLOCKED: tired brain, cake make belly hurt NEXT: mandel [15:04] Oh, and weekly call [15:04] DONE: Fixed bug 985004 bug 986125 and bug 986144 which means that u1-dev-tools in on jenkins. Reviews, worked on a domain socket tcp-activation. [15:04] TODO: more tcp activation. 1-1 with ralsina. [15:04] BLOCKED: no [15:04] dobey, please [15:04] Launchpad bug 985004 in ubuntuone-dev-tools trunk "Squid service startup hides errors" [High,In progress] https://launchpad.net/bugs/985004 [15:04] Launchpad bug 986125 in ubuntuone-dev-tools "runtests.bat cannot find python on windows" [High,Fix committed] https://launchpad.net/bugs/986125 [15:04] Launchpad bug 986144 in ubuntuone-dev-tools "runtests.bat does not take parameters" [Medium,Fix committed] https://launchpad.net/bugs/986144 [15:04] λ DONE: team call, bug #962860, review [15:04] λ TODO: reviews, backports, SRUs, u1db packaging/buildsys [15:04] λ BLCK: none. [15:04] Launchpad bug 962860 in libubuntuone (Ubuntu Precise) "The prompt for installing MP3 playback support dialogue box does not fit in a 1024x600 display" [High,Triaged] https://launchpad.net/bugs/962860 [15:04] also, the cake is a lie [15:04] dobey: I beg to differ [15:05] and the spoon does not bend! [15:05] * ralsina is eating delicious, delicious lies [15:05] * thisfred wants lies [15:05] thisfred: cake is good for you. There is a lie. [15:05] So, comments? [15:05] dobey, jejeej the cake is a lie! great game! :D [15:06] ralsina: actually, the organic oreo-like cookies i have are good for you. they have 2g of whole grains per serving, and plenty of antioxidants! :) [15:06] "Roughly translates to "your promised reward is merely a fictitious motivator"." [15:06] yay green tea + sugar. [15:06] comment, fuck twisted and disconnections! turns out that the stupid domains sockets disconnect in a diff way.. [15:06] dobey: antioxidants are actually bad for you, according to latest medical literature [15:07] sorry, frack twisted [15:07] ralsina: government conspiracies are like that. [15:07] mandel: goes to show "domain sockets have good support in twisted" is a cake [15:08] haha [15:08] EOM it is then [15:08] and now. lunch. [15:08] bbiab [15:08] mandel, mumble? [15:08] ralsina, there already :) [15:10] mandel: 1 segundo [15:38] * gatox quick lunch..... brb! === gatox is now known as gatox_lunch [16:20] mandel: for the problematic names from ubuntu_sso/main/perspective_broker, should those just be explicitly skipped for pylint? [16:20] all the ones with studly caps are signal names, not instance methods [16:21] ah, I see [16:21] urbanape, yes, my comment should have been, skip all those complaints that you consider stupid :) [16:21] I left that pylint exclusion in the windows module [16:21] urbanape, yes, you just have to move it and you should be fine [16:22] I think I got it all. pushing. [16:23] urbanape, did you run the tests on linux, I can do it for you if you done have a vm close to you [16:23] I haven't yet, but can [16:24] urbanape, ok [16:27] mandel: also please see my and sidnei's comments on https://code.launchpad.net/~mandel/ubuntuone-dev-tools/squid-errors/+merge/102825 [16:27] dobey, ok [16:36] dobey, new version pushed, I added StringIO as the parent calss of Pipe since it implements a diff API, added \nstdout:\n%s and \nstderr:\n%s for the exception [16:36] dobey, I added the stdout and stderr to be more clear [16:37] urbanape, which revno? [16:37] mandel: cool [16:37] just pushed. 959 [16:39] mandel: and what about the extreme indentation in the diff, now on line 80 of the diff in launchpad? [16:40] dobey, my style, I can put it to the same level of the ( I have no problems [16:41] dobey, I read it better, but I suppose it might be hated by people [16:41] thisfred: needsinfo on your branch [16:43] mandel: oh i see you do that now on the msg = line. also you apparently typed /n instead of \n :) [16:43] dobey, oh my! that is stupid, fixing [16:44] ralsina looking [16:44] thisfred: just suggested some style checking [16:44] thisfred: other than that, it looks good [16:44] dobey, sorted and added more tranditional indentation [16:44] mandel: k, thanks [16:45] dobey, I guess this in the real purpose of rebase in git, hide how stupid one is at the end of the day :) [16:45] ralsina: I use flake8 in vim, which says the code is good... [16:45] thisfred: there is at least a missing docstring around line 224 [16:46] thisfred: also, __init__ should have docstring if it has arguments [16:46] ralsina. Ah yes. Somehow flake8 strips that out. I wish I knew how to make it not do that [16:46] thisfred: if pyflakes + pep8 gives different results, then let's not use lake8 [16:46] flake8 [16:47] it's too flaky [16:47] or send patches :) [16:47] urbanape, we have a segfault in the tests of that branch, so needs fixing again :( [16:47] urbanape, sorry [16:47] why didn't the flake8 people think of that? :P [16:48] ok, EOD for me, all have a great weekend! [16:48] mandel: can you wait until we get your squid branch approved? [16:49] dobey, sure, go ahead :) === gatox_lunch is now known as gatox [16:49] ralsina: [16:49] mandel: or will you be checking it? would like to get it in and see what's happening with lucid :) [16:49] hmm, my pep8 also does not show that warning anymore? [16:49] mandel: yeah, that's okay, I hadn't gotten to that bit yet. Need to follow that up. [16:50] thisfred: pep8 doesn't complain of that. I expected pyflakes to complain. [16:50] ralsina: ah [16:50] thisfred: are you doing pep8 --repeat ? [16:50] ralsina: it does not [16:50] dobey: yeah [16:50] thisfred: carp [16:50] hrmm [16:50] pep8 should though. [16:50] pep8 is what complains about missing docstrings yes [16:51] it's in pep8 [16:51] really? Ok then. [16:51] is it an option? [16:51] no [16:51] not afaik anyway [16:53] thisfred: silly question: are you sure you are checking that file? ;-) [16:53] dobey: so pep8 should check for that, but it does not, nor does pyflakes [16:53] pylint does [16:53] ralsina: ran it with verbose, and checked all the files [16:54] mandel: can you also fix the indentation on line 13 in the diff? [16:54] thisfred: ok [16:56] dobey, that one is correct, is as close as possible to the upper opening ( [16:56] dobey, where yould you like it? [16:57] mandel: it's not correct. it should be +4 of the parent line afaict. if i open emacs and go to that line and press tab, it moves it way over to the left to where i'd expect it to be [16:57] mandel: next line +4 more spaces [16:58] is what i expect when i see a line end with an open paren [16:59] dobey, ok, is style and I'm not very worried about it :) [17:01] dobey, done [17:03] briancurtin: https://code.launchpad.net/~brian.curtin/ubuntu-sso-client/run-tests-buildout-cleanup/+merge/102393/comments/221740 [17:03] mandel: cool, thanks [17:04]