| rsajdok | May I ask someone to review this solution ? https://code.launchpad.net/~ris/loco-team-portal/part-fix-720824c/+merge/94771 | 12:53 |
|---|---|---|
| bbartek | I don´t know where to report this: | 13:59 |
| bbartek | http://www.flickr.com/photos/16102208@N05/6963441066/ | 13:59 |
| bbartek | Screenshot from a link to the Ubuntu website in Facebook | 13:59 |
| bbartek | The icon shows Firefox Thunderbird | 13:59 |
| bbartek | It should show the Ubntu icon | 14:00 |
| mhall119 | bbartek: that's a Facebook issue | 14:58 |
| mhall119 | it seems to be pulling a random image from the site | 14:59 |
| cjohnston | jamestunnicliffe: move the convo in here so that its available to other peoples input please? | 15:34 |
| jamestunnicliffe | yep | 15:37 |
| cjohnston | jamestunnicliffe: http://linaro.chrisjohnston.org/lcq1-12/ | 15:40 |
| jamestunnicliffe | http://imgur.com/5bjeP shows the problem | 15:41 |
| jamestunnicliffe | I would show another image, but imgur just stopped working for me... | 15:42 |
| jamestunnicliffe | hang on. | 15:42 |
| cjohnston | mhall119: bug #987589 | 15:43 |
| ubottu | Launchpad bug 987589 in Linaro Connect Planning "Export attendees from Connect Registration form to Summit" [Critical,Confirmed] https://launchpad.net/bugs/987589 | 15:43 |
| cjohnston | per Joey it is good to go | 15:43 |
| mhall119 | cjohnston: in a meeting | 15:43 |
| mhall119 | I'll check in a minute | 15:43 |
| cjohnston | yup | 15:43 |
| cjohnston | was just makin the ping | 15:43 |
| mhall119 | thanks | 15:43 |
| cjohnston | jamestunnicliffe: ok.. i see that | 15:43 |
| jamestunnicliffe | http://bayimg.com/IAojkaaDd is the same code, but for some reason looks fine. | 15:44 |
| cjohnston | jamestunnicliffe: max-width: 65.333em; /* 980px / 15px (baseline font); 980px + (60px x 2) = 1100px */ | 15:44 |
| cjohnston | that's why.. its only the max-width | 15:44 |
| cjohnston | I'm thinking | 15:45 |
| jamestunnicliffe | Yes, but it expanded in all my tests (see second pic) | 15:45 |
| cjohnston | all of the grid stuff is messed up | 15:45 |
| jamestunnicliffe | The there are some elements scaling up to 100% inside it, which seemed to be pushing it out. | 15:45 |
| cjohnston | Can I merge in my stuff and see what it does? | 15:46 |
| cjohnston | i can always pull it out | 15:46 |
| jamestunnicliffe | yep | 15:48 |
| cjohnston | jamestunnicliffe: applied | 15:52 |
| cjohnston | please use http://linaro.chrisjohnston.org/lcq1-12/ | 15:52 |
| daker | mhall119, no it's not a facebook problem ツ | 15:53 |
| jamestunnicliffe | cjohnston: Ah, you applied it to the Ubuntu site. The merge was into the Linaro theme. | 15:53 |
| cjohnston | no | 15:54 |
| cjohnston | i applied it to summit | 15:54 |
| cjohnston | removed it from linaro theme | 15:54 |
| jamestunnicliffe | Hang on a moment... | 15:54 |
| jamestunnicliffe | OK, that looks fine. | 15:55 |
| jamestunnicliffe | No idea how I screwed mine up so much. | 15:55 |
| cjohnston | i dont think you applied the merge to summit | 15:55 |
| jamestunnicliffe | The wite background still isn't filling the width properly though. | 15:55 |
| cjohnston | what page | 15:55 |
| jamestunnicliffe | (it is nearly, but not qute) | 15:55 |
| jamestunnicliffe | http://linaro.chrisjohnston.org/lcq1-12/ | 15:55 |
| cjohnston | it looks right on lcq2-12 here | 15:55 |
| cjohnston | ahh | 15:55 |
| cjohnston | your right.. it isnt | 15:55 |
| jamestunnicliffe | Oh, I love CSS | 15:56 |
| cjohnston | thats something we can fix tho if thats the only complaint it should be easy | 15:56 |
| cjohnston | i have css | 15:56 |
| jamestunnicliffe | I would personally dump the mobile table view and just hide the elements that you do. | 15:57 |
| cjohnston | what mobile table? | 15:57 |
| jamestunnicliffe | The grey table | 15:57 |
| jamestunnicliffe | that shows up at >900 pixels wide. | 15:58 |
| cjohnston | thats to make the links bigger.. | 15:58 |
| cjohnston | right | 15:58 |
| cjohnston | it stops at 960px | 15:58 |
| jamestunnicliffe | That would be it. | 15:58 |
| cjohnston | that way it gets pads | 15:58 |
| jamestunnicliffe | I would just leave the lists in place (if you haven't changed the CSS around them, they will re-flow down the page) | 15:59 |
| jamestunnicliffe | The problem is, with my desktop browser at half screen width, the mobile site shows up. | 15:59 |
| jamestunnicliffe | There is no need for it. | 15:59 |
| cjohnston | that was the point of it, i don't disagree, but it was so that tablets see it | 15:59 |
| jamestunnicliffe | If my old phone can handle the "full" site, I think tablets are OK :-) | 16:00 |
| jamestunnicliffe | We could just move the social bobbins to the bottom of the page and it will just scale. | 16:01 |
| jamestunnicliffe | No need to hide anything. | 16:01 |
| jamestunnicliffe | cjohnston: in core-grid.css, .inner-wrapper, set width: 100%, get rid of padding. Think that fixes the layout. | 16:13 |
| cjohnston | ok | 16:13 |
| cjohnston | will do in a few.. i need to eat while i can | 16:13 |
| jamestunnicliffe | cjohnston: indeed | 16:17 |
| jamestunnicliffe | cjohnston: Actually that makes the white background fill out, but breaks the grey menu bar at the top (no padding / border) | 16:18 |
| jamestunnicliffe | I think that is the right direction though. | 16:18 |
| jamestunnicliffe | cjohnston: give core.css:232 .nav-secondary "margin: 0 20px" | 16:20 |
| cjohnston | instead or in adition | 16:24 |
| jamestunnicliffe | cjohnston: scratch that, move the .inner-wrapper padding: 0 20px; to core.css (line 263ish) | 16:24 |
| cjohnston | now im confused | 16:24 |
| cjohnston | heh | 16:24 |
| jamestunnicliffe | OK ignore all of above. | 16:24 |
| jamestunnicliffe | move the .inner-wrapper padding: 0 20px; from core-grid.css (all places) to core.css, where some .inner-wrapper stuff is defined at line 263 | 16:25 |
| jamestunnicliffe | And with it, set width: 100% | 16:26 |
| jamestunnicliffe | Arg. No. Hang on. | 16:26 |
| jamestunnicliffe | I promise I am not messing with you. This is just doing my head in. | 16:26 |
| cjohnston | 1 sec | 16:26 |
| jamestunnicliffe | just ignore me :-) | 16:26 |
| === Ronnie1 is now known as Ronnie | ||
| cjohnston | nigelb: can you hit tarmac please | 20:04 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!