| davecheney | niemeyer: do you have any further comments on https://codereview.appspot.com/6215045/ ? | 00:10 |
|---|---|---|
| niemeyer | davecheney: Heya | 00:18 |
| niemeyer | davecheney: Good morning | 00:18 |
| niemeyer | davecheney: I'll have a pass on your branches | 00:19 |
| niemeyer | davecheney: Just back from dinner now | 00:19 |
| niemeyer | davecheney: Will finish Rog's one first, though.. already half way through the massive branch | 00:19 |
| niemeyer | davecheney: ping? | 00:48 |
| davecheney | ack | 00:51 |
| niemeyer | davecheney: Heya | 00:55 |
| niemeyer | davecheney: How are you? | 00:55 |
| davecheney | good | 00:55 |
| davecheney | sorry, was downstairs having breakfast | 00:55 |
| niemeyer | davecheney: No worries at all | 00:55 |
| davecheney | i generally work from when I get up to when sam gets up | 00:55 |
| niemeyer | davecheney: Just wanted to take the chance we're both up and kicking to chat a bit | 00:55 |
| davecheney | sure thing | 00:56 |
| niemeyer | davecheney: Who's Sam? | 00:56 |
| davecheney | my partner | 00:56 |
| davecheney | she's not a morning person | 00:56 |
| niemeyer | davecheney: Aha, I can understand that! :) | 00:56 |
| davecheney | so, what can I do to get those reviews cleared away | 00:57 |
| niemeyer | davecheney: I work in the morning because I interact with the guys in the EU, but it's certainly not my most productive moment in the day | 00:57 |
| niemeyer | davecheney: I'm just finishing that monster review for Rog.. I have yours next up | 00:57 |
| davecheney | no worries | 00:57 |
| niemeyer | davecheney: I think I still have spare energy to get through them | 00:57 |
| davecheney | i'm not blocked at the moment | 00:58 |
| niemeyer | davecheney: How've you been feeling this week with the work-at-home situation? | 00:58 |
| davecheney | it's working well | 00:58 |
| davecheney | i ordered a new X220 | 00:59 |
| davecheney | so when taht arrives i'll be more mobile | 00:59 |
| davecheney | but for the moment i'm just kicking it in the spare room | 00:59 |
| niemeyer | davecheney: Nice. Coincidently, my battery just died today, so I'm stuck in the office :) | 01:06 |
| davecheney | so i read | 01:07 |
| davecheney | li-ions tend to fall off a cliff | 01:07 |
| niemeyer | Phew.. | 01:11 |
| niemeyer | davecheney: Yeah | 01:12 |
| niemeyer | Branch reviewed | 01:12 |
| niemeyer | That was a long oen | 01:12 |
| davecheney | nice work | 01:12 |
| davecheney | i understand, small branches >> large brances | 01:12 |
| andrewsmedina | hi guys | 01:13 |
| andrewsmedina | :D | 01:13 |
| * davecheney waves | 01:16 | |
| niemeyer | davecheney: https://codereview.appspot.com/6215045/ has a review, and LGTM with the points addressed. | 01:23 |
| niemeyer | andrewsmedina: Heya! | 01:23 |
| niemeyer | andrewsmedina: juju team is 24x7 now ;) | 01:23 |
| niemeyer | Well, 24x5 at least! | 01:24 |
| andrewsmedina | I'm 24x7 | 01:24 |
| andrewsmedina | niemeyer: I'm working on https://codereview.appspot.com/6099051/ | 01:24 |
| niemeyer | andrewsmedina: No, I'm serious.. davecheney is in Australia.. we're going round-the-clock now :) | 01:25 |
| davecheney | niemeyer: thanks for https://codereview.appspot.com/6215045/, i'll address those comments and submit | 01:25 |
| andrewsmedina | I will tell you when I finish it | 01:25 |
| niemeyer | davecheney: My pleasure, and thanks | 01:27 |
| niemeyer | andrewsmedina: Super! | 01:27 |
| davecheney | negronjl: re your final comment | 01:28 |
| davecheney | I would personally find it ok if we injected the "name" attribute on the | 01:28 |
| davecheney | environment configuration when reading it out of environments.yaml. | 01:28 |
| davecheney | can I handle that in a later branch ? | 01:28 |
| davecheney | i'll change the config to be a TODO | 01:28 |
| davecheney | niemeyer: did you have a chance to consider the race with AddMachine() ? | 01:32 |
| niemeyer | davecheney: Re. "name", yeah, definitely.. wasn't suggesting it'd be for the same branch. I suggest fixing the "TODO", though. | 01:32 |
| niemeyer | davecheney: re. the race, which race? | 01:33 |
| davecheney | the way state.AddMachine works currently, it's changes are visible to the MachineWatcher while the topology is inconsistent | 01:33 |
| niemeyer | davecheney: Duh.. that kind of thing is the core reason why we have the topology | 01:35 |
| niemeyer | davecheney: I forgot about it when reviewing. Thanks a lot for pointing that out. | 01:35 |
| davecheney | i haven't looked into it too much, but it might be possible to fix the problem by reordering the operations inside AddMachines | 01:36 |
| davecheney | but as it stands now, the MachineWatcher observes /machines changing, but when it calls state.Machine("the name of the key that just arrived"), it can fail because the topology has not yet changed to reflect that | 01:36 |
| niemeyer | davecheney: The only reason we have a central monotonic topology is so that we can get atomicity in that kind of operation | 01:37 |
| niemeyer | davecheney: I suggest a quick look at the watch_machine_states in the Python side | 01:38 |
| davecheney | will do | 01:38 |
| niemeyer | davecheney: If we reorder operations, we have the same problem on the opposite side | 01:38 |
| niemeyer | davecheney: (code reading the topology explodes due to lack of nodes) | 01:39 |
| davecheney | right | 01:39 |
| niemeyer | davecheney: Eventually, we may have to get smarted than that to scale up to more extreme levels | 01:39 |
| niemeyer | smarter | 01:39 |
| niemeyer | davecheney: But then we'll need to consider races, locks, expirations, etc | 01:40 |
| niemeyer | davecheney: The monotonic topology is a cheap way to get going for a long time without having to invest much on scenarios that re unrealistic in the near future | 01:40 |
| davecheney | i think i haven't explain myself properly | 01:41 |
| davecheney | i shouldn't have said the topology is inconsistent | 01:41 |
| davecheney | more that state.Machine() races with state.AddMachine() | 01:41 |
| niemeyer | davecheney: It doesn't | 01:52 |
| niemeyer | davecheney: At least not any more than the fact everything always races with everything | 01:52 |
| niemeyer | davecheney: Changing the topology is atomic.. AddMachine will add to the topology atomically, and state.Machine will read it atomically | 01:53 |
| niemeyer | davecheney: The watcher needs to observe the topology, though, not the nodes themselves | 01:55 |
| niemeyer | davecheney: Btw, when you "lbox submit", the latest changes in the branch are pushed to the codereview | 01:59 |
| niemeyer | davecheney: So, unless you want to have a last look online, the propose preceding it isn't necessary | 01:59 |
| niemeyer | davecheney: Ah, I think I've got the context for what you're talking about now, looking at your branch | 02:02 |
| niemeyer | davecheney: Sorry for the noise | 02:02 |
| davecheney | niemeyer: re lbox propose, yeah I do that so I have a diff of what is the final state | 02:03 |
| davecheney | it probably don't need to do that | 02:03 |
| niemeyer | davecheney: It doesn't bother me.. was just pointing out that submit does send the diff too | 02:04 |
| niemeyer | (since it's not obvious) | 02:04 |
| davecheney | niemeyer: when you say context, you're talking about the comment at the bottom of MachinesWatcher.toMachines | 02:04 |
| niemeyer | davecheney: yeah | 02:04 |
| niemeyer | davecheney: Was just prising the comments, coincidently | 02:04 |
| niemeyer | davecheney: You got a LGTM on it | 02:05 |
| davecheney | nice | 02:05 |
| davecheney | there is a similar problem with doing state.Machine('an id which was just deleted') but for more obvious reasons | 02:06 |
| niemeyer | davecheney: yeah | 02:06 |
| davecheney | niemeyer: thanks for the reviews | 02:15 |
| davecheney | I started to work on the provisioning agent proper yesterday | 02:15 |
| davecheney | so I shold have a wip branch this evening | 02:15 |
| niemeyer | davecheney: Woot | 02:21 |
| davecheney | i have a plan to model the current privider (environs.Environ) as a goroutine | 02:21 |
| davecheney | which should hide the fact that it can reload itself as the environment changes | 02:22 |
| davecheney | without having to require a lot of retry logic | 02:22 |
| niemeyer | davecheney: Btw, would you mind to work on a branch fixing WatchMachines? | 02:24 |
| davecheney | sure | 02:24 |
| davecheney | so, you would like WatchMachines to not return a *Machine unless it is properly visible in the topology ? | 02:25 |
| niemeyer | davecheney: WatchMachines should be a content watcher, not a child watcher | 02:26 |
| niemeyer | davecheney: and watch the topology | 02:26 |
| niemeyer | davecheney: Otherwise it will be notifying about machines before they are visible, which will create all kinds of bugs | 02:27 |
| niemeyer | davecheney: The Python logic already works like that for the same reason | 02:27 |
| davecheney | ok, understood | 02:27 |
| niemeyer | Aaand that's bad time! | 03:20 |
| niemeyer | I mean, good time! | 03:20 |
| niemeyer | Good time for bed! :) | 03:20 |
| niemeyer | Have a good night all | 03:20 |
| niemeyer | davecheney: And a good day to you, Dave | 03:20 |
| davecheney | night mate | 03:45 |
| hazmat | davecheney, x230s are around the corner | 04:18 |
| hazmat | always something i suppose | 04:18 |
| rogpeppe | davecheney: hiya | 06:17 |
| davecheney | hi rog | 06:27 |
| davecheney | hazmat: don't tell me that, i just dropped a gorilla on an x 220 | 06:28 |
| rogpeppe | davecheney: hey, we coincide! | 06:38 |
| davecheney | shazam | 06:39 |
| davecheney | so, after redoing watchmachine, i have to redo it again :) | 06:39 |
| davecheney | oh well, at least I got two commits off my plate today | 06:39 |
| rogpeppe | davecheney: yeah, i saw that. bummer. | 06:39 |
| rogpeppe | davecheney: is it that it can't use the child watcher? | 06:39 |
| davecheney | no, not directly, although i'll probably end up implenting the same logic | 06:40 |
| davecheney | the problem witht eh child watcher is i observe new /machine keys arriving before they exist in the topology | 06:40 |
| davecheney | gustavo says i need to watch the topology insteam | 06:40 |
| rogpeppe | davecheney: i wonder if *anything* can legitimately use the child watcher | 06:40 |
| davecheney | rogpeppe: i'm starting to think not | 06:40 |
| davecheney | still, once we get the provisioning agent right, the machine and unit agents will probably be 95% the same | 06:42 |
| rogpeppe | davecheney: interesting. i'm sure the python version watches children somewhere. but maybe it's wrong. | 06:42 |
| rogpeppe | davecheney: machine agent is simple. the unit agent is a bit more complex as it needs the logic for determining which hook to run when (the core of juju in fact) | 06:43 |
| davecheney | no, it watches the topology, | 06:43 |
| rogpeppe | trunk/juju/state/relation.py:653 | 06:46 |
| rogpeppe | trunk/juju/state/relation.py:839 | 06:47 |
| rogpeppe | davecheney: so there is at least *one* place that watches children | 06:47 |
| rogpeppe | davecheney: i can't immediately work out if it's legit though | 06:48 |
| davecheney | will read in a sec | 06:48 |
| rogpeppe | davecheney: BTW after discussion with gustavo last night, i have an idea for simplifying the ConfigChecker part of EnvironProvider, and making it slightly more statically typed. | 06:52 |
| davecheney | rogpeppe: if you want to do a branch for that, i'll gladly review it | 06:53 |
| rogpeppe | davecheney: cool. it might only be 10 minute's work. i'll have a look now. | 06:54 |
| davecheney | rogpeppe: the part where you pass an untyped 'something' through the Checker and receive another opaque 'something' back which is specific to the Provider that checked it, doesn't make me feel wholesome | 06:55 |
| rogpeppe | davecheney: yeah. i don't mind the second part so much, but now that we mandate that the initial "something" is actually [string]interface{}, we should reflect that in the API. | 06:56 |
| davecheney | rogpeppe: +1 | 06:56 |
| rogpeppe | davecheney: heh, maybe it should return a func() Environ, rather than an opaque "something" | 06:57 |
| rogpeppe | davecheney: then the state would be hidden behind a closure. | 06:57 |
| davecheney | rogpeppe: now that would be more appropriate for Go | 06:59 |
| rogpeppe | davecheney: i think so | 06:59 |
| rogpeppe | davecheney: how about something like this: http://paste.ubuntu.com/991940/ | 07:04 |
| davecheney | btw, state/machine.py ~ 103 sort of does what your child watcher does | 07:05 |
| rogpeppe | davecheney: yeah. i think when i did the child watcher i was misremembering that piece of code. | 07:08 |
| davecheney | well, it does do what your child does, ie it takes an old set, then waits for a new set, the produces a delta of machines added and machines left | 07:09 |
| rogpeppe | davecheney: BTW if you don't mention my IRC nick, i tend not to see your comments (it makes my machine beep...) | 07:09 |
| rogpeppe | davecheney: exactly. i think i'd misremembered the fact that it reads topology not children. | 07:10 |
| davecheney | rogpeppe: np, anyway, i hope the functionality exists inside the topology (haven't looked yet) | 07:10 |
| rogpeppe | davecheney: i don't think there's a similar watcher yet. | 07:11 |
| * davecheney fml | 07:11 | |
| rogpeppe | fml? | 07:12 |
| davecheney | http://www.urbandictionary.com/define.php?term=FML&defid=5145198 | 07:14 |
| rogpeppe | that bad, eh? | 07:14 |
| davecheney | no, not really | 07:17 |
| davecheney | rogpeppe: re http://paste.ubuntu.com/991940/ | 07:24 |
| davecheney | rogpeppe: why produce a func that produces an Environ, why not produce the Environ directly ? | 07:24 |
| rogpeppe | davecheney: because we want to be able to check all the environments in environments.yaml for correctness without instantiating them all. | 07:25 |
| rogpeppe | davecheney: an environment is perfectly entitled to do some expensive operation when opened. | 07:25 |
| davecheney | fair enough | 07:25 |
| rogpeppe | davecheney: i'm liking the way it's looking so far | 07:26 |
| davecheney | rogpeppe: yup, fair point, in that case func(Environ, error) is really just an anonymous type for EnvironProviderHolder, or something | 07:26 |
| davecheney | but it gets the job done | 07:26 |
| rogpeppe | davecheney: yeah. | 07:26 |
| rogpeppe | it could return a Config type. type Config interface { Open() (Environ, error) } | 07:27 |
| rogpeppe | but i don't mind returning a simple function. | 07:28 |
| rogpeppe | although.... | 07:28 |
| davecheney | i'd argue for the functional approach | 07:28 |
| rogpeppe | actually that might be nice. we've already got a config type in ec2 and elsewhere. | 07:28 |
| rogpeppe | and we'd just need to define an Open method on it. | 07:28 |
| rogpeppe | i could go either way | 07:29 |
| davecheney | rogpeppe: so, Check(config map) => Config; Config.Open() => Environ ? | 07:29 |
| rogpeppe | davecheney: yeah | 07:29 |
| rogpeppe | davecheney: i think i prefer that actually. | 07:30 |
| rogpeppe | s/Config/EnvironConfig/ i think | 07:31 |
| rogpeppe | davecheney: current state: http://paste.ubuntu.com/991957/ | 07:33 |
| davecheney | rogpeppe: LGTM | 07:34 |
| davecheney | rogpeppe: how did your networking explorations go ? | 07:34 |
| rogpeppe | davecheney: i totally failed to set up a bpf filter (no idea why - couldn't see anything in the kernel code to indicate why i was getting EINVAL); but i've realised that i *think* i can just use the tun device and get the kernel to do all the filtering for me. | 07:36 |
| rogpeppe | davecheney: had fun on the plane writing a little translator to the bpf VM language. came across a really nice use of defer. | 07:36 |
| davecheney | rogpeppe: as a suggestion, if you're bringing up a tun device, then you can just use IP routing to do what you want | 07:37 |
| rogpeppe | davecheney: exactly. | 07:37 |
| davecheney | rogpeppe: bpf might get you max nerd cred, but IP routing is easier and better understood | 07:37 |
| rogpeppe | davecheney: i just have to work out how to use an etun device because you can't share a network interface across lxc instances | 07:37 |
| rogpeppe | davecheney: but that's probably easy to do through the lxc interface in fact. | 07:38 |
| davecheney | rogpeppe: yeah, lxc has a number of networking options; I would _think_ that we do _not_ want bridging (which is what it does out of the box) | 07:38 |
| rogpeppe | davecheney: yes. | 07:39 |
| davecheney | from experience with OpenVZ, on the host side, you get an interface called venet0, which you assign all the ip's of the containers you're running | 07:39 |
| davecheney | as long as you get the IP packets to the host, it will do the rest | 07:39 |
| rogpeppe | davecheney: i *think* that etun (a kind of interface "pipe") does what i'm after, but i haven't had great joy finding docs. | 07:39 |
| davecheney | essentially the OpenVZ guests are running ppp (think point to point, not ppp serial) links to the host | 07:40 |
| davecheney | so there is layer 3 routing involved | 07:40 |
| rogpeppe | davecheney: the most important thing is being able to read the IP packets generated by the guests from some central point. | 07:40 |
| rogpeppe | davecheney: and that the kernel knows enough to route between local guests. | 07:41 |
| davecheney | yeah, dunno if you can sniff on the host side of an LXC container | 07:41 |
| davecheney | the kernel will be able to route between the local LXC containers | 07:41 |
| davecheney | that sorta comes for free | 07:41 |
| rogpeppe | davecheney: i found this to be a useful intro: http://backreference.org/2010/03/26/tuntap-interface-tutorial/ | 07:42 |
| davecheney | rogpeppe: thanks for the link | 07:43 |
| rogpeppe | davecheney: i got all that stuff working ok. | 07:43 |
| rogpeppe | davecheney: but i haven't put it together with lxc yet | 07:43 |
| davecheney | rogpeppe: ip (iproute2) is an amazing tool, and virtually completely without documentation, unless you've used cisco routers, then it's like second nature | 07:43 |
| rogpeppe | davecheney: it seems ok actually. the syntax isn't too shit. | 07:44 |
| davecheney | rogpeppe: i found it pretty unfriendly to exploration | 07:44 |
| rogpeppe | davecheney: it reminds me of the configuration language you use for talking to the plan 9 ip device | 07:44 |
| davecheney | althoguh i got pretty friendly with ip r s | 07:44 |
| rogpeppe | davecheney: it would be nice to have some decent docs though, it's true. | 07:44 |
| rogpeppe | ip r s? | 07:45 |
| davecheney | ip route show | 07:45 |
| rogpeppe | ah | 07:45 |
| davecheney | ip r a 10.0.0.1/32 gw tun0 | 07:45 |
| davecheney | was another favorite | 07:45 |
| rogpeppe | davecheney: using the ip command beats working out the right argument to pass to the right ioctls... | 07:46 |
| rogpeppe | davecheney: what's the difference between route add and addr add? | 07:47 |
| davecheney | rogpeppe: adding an address to an interface is an endpoint | 07:47 |
| davecheney | adding a route, establishes a possible flow between endpoints | 07:47 |
| rogpeppe | davecheney: ok. that makes sense. | 07:48 |
| rogpeppe | davecheney: in my case though, i'm using an endpoint as a route... | 07:48 |
| davecheney | rogpeppe: yeah, it gets murkey | 07:49 |
| davecheney | traditionally you'll say, ip r a 192.168/16 gw tun0 | 07:49 |
| davecheney | sorry | 07:49 |
| davecheney | ip r a 192.168/16 gw 10.0.0.1 | 07:49 |
| davecheney | that is, send anything for 192.168/16 to 10.0.0.1, it knows what to do | 07:50 |
| rogpeppe | davecheney: is 192.168/16 equiv to 192.168.0.0/16 ? | 07:50 |
| davecheney | but there are more complex combinations, generally when the next hop is either not local to our network, or a point to point link | 07:50 |
| davecheney | yes, http://en.wikipedia.org/wiki/CIDR_notation | 07:50 |
| davecheney | they are all shorthand | 07:51 |
| davecheney | anyway, i'd better get my self together to go out | 07:52 |
| davecheney | devops sydney starts in an hour | 07:52 |
| rogpeppe | davecheney: k | 07:52 |
| rogpeppe | davecheney: have fun | 07:52 |
| davecheney | wd | 07:52 |
| rogpeppe | davecheney: hmm, not obvious from that page that 192.168 is equivalent to 192.168.0.0. | 07:54 |
| rogpeppe | davecheney: i've used 127.1 as an alias for 127.0.0.1 in the past, so it's not universal... | 07:55 |
| fwereade | heya rogpeppe | 09:30 |
| rogpeppe | fwereade: yo man! | 09:30 |
| rogpeppe | fwereade: thought you were off! | 09:30 |
| fwereade | rogpeppe, today's cold and dull :) | 09:31 |
| rogpeppe | fwereade: where r u? | 09:31 |
| fwereade | rogpeppe, my mum's house in gloucestershire | 09:31 |
| rogpeppe | fwereade: ah, cold and grey is par for the course currently... | 09:32 |
| fwereade | rogpeppe, I will almost certainly take a couple more off over the next week but I don't want to entirely cut myself off :) | 09:32 |
| rogpeppe | fwereade: cool. | 09:32 |
| fwereade | rogpeppe, btw, I really enjoyed lord valentine's castle | 10:15 |
| rogpeppe | fwereade: great, innit?! | 10:15 |
| rogpeppe | fwereade: there are sequels... | 10:15 |
| fwereade | rogpeppe, good old-fasjioned gripping yarn, nicely written, cool tech just peeking out of the background | 10:15 |
| rogpeppe | 'xactly | 10:15 |
| rogpeppe | i really liked that world | 10:15 |
| fwereade | rogpeppe, yeah, I was thinking I'd have to look them up :) | 10:16 |
| fwereade | rogpeppe, also there's something quite nice about a world running on tech they don't understand that *doesn't* draw all its drama from the obvious "it's breaking down and nobody understands it" scenario | 10:17 |
| rogpeppe | fwereade: yeah. the tech is not central. | 10:17 |
| rogpeppe | fwereade: i also fondly imagine, though i haven't read it in a while, that it hasn't dated badly. | 10:21 |
| rogpeppe | fwereade: because of its lack of connection to the present day | 10:21 |
| rogpeppe | fwereade: did you ever read Helliconia Spring BTW? | 10:21 |
| fwereade | rogpeppe, perhaps ever such a gentle sepia tinge | 10:21 |
| fwereade | rogpeppe, but quite possibly that was just triggered off it being an old book, becaue I can't think of anything specific | 10:22 |
| fwereade | rogpeppe, nope | 10:22 |
| rogpeppe | fwereade: great series. Brian Aldiss. | 10:22 |
| * fwereade is *sure* he read some of his stuff but can't remember what | 10:22 | |
| * rogpeppe hasn't read any of his stuff in ages, but read most of it years ago. | 10:23 | |
| rogpeppe | fwereade: http://www.amazon.co.uk/Helliconia-Spring-Summer-Hellonica-MASTERWORKS/dp/0575086157/ref=sr_1_1?ie=UTF8&qid=1337250194&sr=8-1 | 10:24 |
| fwereade | rogpeppe, cool, that series has not led me wrong at any time I can recall | 10:24 |
| rogpeppe | fwereade: not sure i've read anything from that series actually | 10:25 |
| rogpeppe | fwereade: the original helliconia covers were definitely better. | 10:25 |
| rogpeppe | fwereade: http://www.amazon.co.uk/Helliconia-Spring-Brian-W-Aldiss/dp/0586053654/ref=sr_1_4?ie=UTF8&qid=1337250194&sr=8-4 | 10:25 |
| rogpeppe | fwereade: http://www.amazon.co.uk/Helliconia-Summer-Panther-Books-Aldiss/dp/0586053662/ref=sr_1_5?ie=UTF8&qid=1337250194&sr=8-5 | 10:26 |
| fwereade | rogpeppe, I haven't read all that many I guess but all the ones I've read have been good | 10:26 |
| rogpeppe | fwereade: http://www.amazon.co.uk/Helliconia-Winter-Brian-Aldiss/dp/0586053670/ref=sr_1_6?ie=UTF8&qid=1337250194&sr=8-6 | 10:26 |
| rogpeppe | :-) | 10:26 |
| fwereade | rogpeppe, yeah, those are much more interesting | 10:26 |
| rogpeppe | fwereade: they're also fairly close to the actual contents of the book, which is unusual | 10:26 |
| fwereade | rogpeppe, I still keenly remember the disappointment of my first don't-judge-etc moment ;) | 10:28 |
| rogpeppe | fwereade: :-) | 10:28 |
| rogpeppe | fwereade: the style isn't as accessible as Valentine's Castle. you can get a good idea from the Look Inside... | 10:29 |
| fwereade | rogpeppe, seems quite pleasing to me | 10:31 |
| fwereade | rogpeppe, I can imagine times I wouldn't be in the mood for it | 10:31 |
| rogpeppe | fwereade: it's definitely lingered in my mind. | 10:31 |
| rogpeppe | fwereade: you might want to have a look at https://codereview.appspot.com/6145043/ | 10:48 |
| rogpeppe | fwereade: it's got quite a bit of new stuff in after discussions with niemeyer | 10:48 |
| rogpeppe | fwereade: in particular, check out the Storage types in environs/interface.go | 10:49 |
| Aram | morning. | 11:16 |
| fwereade | rogpeppe, sorry I missed that, I'll take a look; morning Aram | 11:21 |
| rogpeppe | Aram: hey | 11:22 |
| rogpeppe | fwereade: i've uploaded a new version addressing niemeyer's comments. | 11:44 |
| fwereade | rogpeppe, just saw, thanks | 11:45 |
| fwereade | rogpeppe, and the storage stuff is indeed very pleasing, nice work | 11:48 |
| rogpeppe | fwereade: cool. it's funny how a tiny niggle (ToolsPath in this case) can lead to a significant advance. | 11:51 |
| rogpeppe | fwereade: "This being an interface method says to me that it's done by definition ;)." | 12:02 |
| rogpeppe | fwereade: not quite sure what you mean there | 12:02 |
| rogpeppe | fwereade: "juju1.2.3-precise-i386.tgz" vs "juju-1.2.3-precise-i386.tgz" ? | 12:19 |
| rogpeppe | fwereade: which do you prefer? | 12:19 |
| fwereade | rogpeppe, sorry, it would appear I can't read and failed to notice it was commented out | 12:19 |
| * fwereade looks bashful and goes to eat lunch | 12:19 | |
| rogpeppe | fwereade: np | 12:19 |
| Aram | rogpeppe: juju-1.2.3-precise-i386.tgz is better for awk. | 12:20 |
| rogpeppe | Aram: ok. good enough. that's what i have already. | 12:21 |
| rogpeppe | i just noticed i had also had the other variant in the past | 12:21 |
| * rogpeppe goes for lunch | 12:52 | |
| niemeyer | Morning! | 13:21 |
| fwereade | heya niemeyer | 13:21 |
| niemeyer | fwereade: Heya, how're things going there? | 13:22 |
| niemeyer | fwereade: Still in the uk? | 13:22 |
| fwereade | niemeyer, not bad; cold and wet | 13:22 |
| fwereade | niemeyer, that should answer your followup too ;) | 13:23 |
| niemeyer | Haha :) | 13:23 |
| niemeyer | fwereade: Having fun with the family? | 13:23 |
| fwereade | niemeyer, yeah, it's lovely | 13:23 |
| niemeyer | fwereade: nice | 13:23 |
| fwereade | niemeyer, I think since I have the opportunity I will take tomorrow until tues as a proper holiday if that's ok with you | 13:24 |
| niemeyer | fwereade: Yeah, it's cool | 13:24 |
| fwereade | niemeyer, great, thanks :) | 13:24 |
| niemeyer | fwereade: no worries, good to enjoy the family every once in a while :) | 13:26 |
| fwereade | niemeyer, absolutely :) | 13:26 |
| fwereade | niemeyer, laura brought be a bunch of flowers today, it was awesome :) | 13:27 |
| niemeyer | fwereade: Hah, so sweet :) | 13:27 |
| andrewsmedina | Heya! | 13:35 |
| niemeyer | andrewsmedina: Morning! | 13:35 |
| andrewsmedina | niemeyer: morning! | 13:38 |
| rogpeppe | niemeyer: hiya! | 14:09 |
| niemeyer | rogpeppe: Hey man | 14:13 |
| niemeyer | rogpeppe: How's tricks? | 14:13 |
| rogpeppe | niemeyer: great. am pleased with the last couple of branches. just working on upload-tools, to integrate the upstream stuff. | 14:13 |
| rogpeppe | niemeyer: sorry about the size of the last one | 14:13 |
| rogpeppe | niemeyer: lp doesn't make it easy to split a branch during review | 14:14 |
| niemeyer | rogpeppe: No worries, it was partly self-inflicted :) | 14:14 |
| rogpeppe | niemeyer: i'm hoping you like the new Listen/Close thing in the dummy environ. | 14:15 |
| rogpeppe | niemeyer: that's the only substantive change this time round, i think. | 14:15 |
| niemeyer | rogpeppe: Why do we need it? | 14:15 |
| niemeyer | rogpeppe: Can't we simply Reset a single time in the test? | 14:15 |
| rogpeppe | niemeyer: because we need to be able to signal to the dummy environ that no more changes are coming | 14:15 |
| rogpeppe | niemeyer: we need to Reset to listen; then we need to wait for any changes on the channel. | 14:16 |
| niemeyer | rogpeppe: Ok, that may be done with a single Reset | 14:16 |
| rogpeppe | niemeyer: by closing it, we know there are no more to come. | 14:16 |
| rogpeppe | niemeyer: but we also want to be able introspect the state after the channel has been closed. | 14:16 |
| rogpeppe | niemeyer: so that we can tell that tools have been uploaded for example. | 14:16 |
| rogpeppe | niemeyer: that was why i added the bool arg, but i think Listen/Close is cleaner. | 14:17 |
| niemeyer | rogpeppe: I don't see why we need to do that afterwards.. but either way I like the sound of it too | 14:17 |
| rogpeppe | niemeyer: well, we can't do it before! | 14:18 |
| rogpeppe | pwd | 14:19 |
| niemeyer | rogpeppe: We only need to Reset once in a test.. you then have a channel of events to introspect | 14:21 |
| niemeyer | rogpeppe: You can use that single channel of events in all verifications | 14:21 |
| rogpeppe | niemeyer: yes, but we need to introspect *after* all events have completed. | 14:21 |
| niemeyer | rogpeppe: Not really | 14:22 |
| niemeyer | rogpeppe: There's no intrinsic reason why that would be the case | 14:22 |
| rogpeppe | niemeyer: we don't necessarily know what operations will be performed | 14:22 |
| Aram | what's a branch in this context, it seems to me the branches you're talking about are not VCS branches, right? | 14:22 |
| rogpeppe | Aram: VCS branches, yes | 14:22 |
| Aram | or is bzr different? | 14:22 |
| niemeyer | rogpeppe: Yes, we don't.. welcome to mocking | 14:22 |
| Aram | hmm. | 14:22 |
| niemeyer | rogpeppe: You're asserting that you know it.. | 14:22 |
| rogpeppe | niemeyer: i don't *think* so. | 14:23 |
| rogpeppe | niemeyer: i'm asserting that i know at least one operation that will be performed. and that the files can be downloaded afterwards. | 14:23 |
| rogpeppe | niemeyer: if the channel isn't closed, then i'll have to time out on error, and i don't want to do that. | 14:23 |
| niemeyer | rogpeppe: Huh.. you're asserting a sequence of operations, and closing the channel in a way that explodes if it doesn't work | 14:24 |
| niemeyer | rogpeppe: Anything else done by the environment will cause the test to explode | 14:24 |
| niemeyer | rogpeppe: You might as well do that without resetting in the middle, for example | 14:25 |
| rogpeppe | niemeyer: i'm asserting that the operation does a sequence of operations, yes. i don't think anything will explode if it doesn't work - unless the operation does operations aynchronously after it's returned. | 14:25 |
| niemeyer | rogpeppe: I can't follow you.. "i'm asserting that the operation does" and "i don't think anything will explode if it doesn't work" are not compatible with each other | 14:26 |
| * rogpeppe goes to look at the code again | 14:26 | |
| rogpeppe | niemeyer: what do you mean by "explode"? | 14:27 |
| niemeyer | rogpeppe: The test will explode | 14:27 |
| rogpeppe | niemeyer: nothing will panic, if that's what you mean | 14:27 |
| niemeyer | rogpeppe: Fail | 14:27 |
| rogpeppe | niemeyer: that's what i want to happen | 14:27 |
| niemeyer | rogpeppe: No.. I mean the test will fail | 14:27 |
| rogpeppe | niemeyer: isn't that the correct behaviour? | 14:27 |
| niemeyer | rogpeppe: Yes, and this correct behavior doesn't need Reset in the middle. | 14:28 |
| niemeyer | rogpeppe: It will fail if you don't reset in between things too. | 14:28 |
| rogpeppe | niemeyer: what happens if the operation does no actions? | 14:28 |
| niemeyer | rogpeppe: Yes, what happens? | 14:28 |
| niemeyer | rogpeppe: Today? | 14:28 |
| niemeyer | rogpeppe: The same will happen | 14:28 |
| rogpeppe | niemeyer: i wait for something to arrive on the channel, but nothing arrives. | 14:28 |
| niemeyer | rogpeppe: Yep.. same will happen if you don't reset | 14:29 |
| rogpeppe | niemeyer: no, that's why i have Close. | 14:29 |
| niemeyer | Sorry, I don't get it.. | 14:29 |
| niemeyer | rogpeppe: Reset, A, B, Reset, C, D | 14:29 |
| niemeyer | rogpeppe: Why do you need the Reset in the middle? | 14:29 |
| niemeyer | rogpeppe: Reset the dummy environment, and use a single channel from end to end.. | 14:30 |
| rogpeppe | niemeyer: we need a Reset at the end of the test as well as at the beginning. | 14:30 |
| niemeyer | rogpeppe: That's not the question asked | 14:30 |
| rogpeppe | niemeyer: otherwise what happens when we're expecting to read D but it wasn't sent | 14:30 |
| rogpeppe | ? | 14:30 |
| niemeyer | rogpeppe: Why do you need the Reset in the middle | 14:30 |
| rogpeppe | niemeyer: we don't. we have one Reset at each side of the tested operation (or, in the new way, a Reset at the start and a Close at the end) | 14:31 |
| niemeyer | rogpeppe: Bingo.. we don't need a Reset in the middle, which means we don't need clear, or to change the interface of the dummy package. | 14:32 |
| rogpeppe | niemeyer: there is no Reset in the middle right now. there never has been. | 14:32 |
| niemeyer | rogpeppe: There is.. that's the only reason why you've introduced clear | 14:32 |
| niemeyer | or clean | 14:32 |
| niemeyer | rogpeppe: To reset the environment without actually resetting it | 14:32 |
| niemeyer | rogpeppe: If you only actually reset when the test starts or ends, the current interface suffices | 14:33 |
| rogpeppe | niemeyer: look at cmd_test.go:150 | 14:33 |
| rogpeppe | niemeyer: what happens if the operation fails to send a bootstrap op? | 14:33 |
| niemeyer | Checking | 14:35 |
| niemeyer | rogpeppe: Ok, that sounds fine.. so there is a reason | 14:38 |
| rogpeppe | niemeyer: yes, i was trying to explain to you :-) | 14:38 |
| rogpeppe | niemeyer: sorry if my explanations were a bit shit | 14:39 |
| * rogpeppe is wondering how he could make the comments clearer | 14:40 | |
| niemeyer | rogpeppe: You have a Reset in the middle of the test.. and it wasn't clear why. Denying that the Reset existed was one of the difficulties for me to understand what was going on, at least. | 14:53 |
| niemeyer | rogpeppe: Either way, Listen+Close looks great | 14:54 |
| rogpeppe | niemeyer: yeah, i was unclear sorry. i was confusing "test" and "operation"... | 14:55 |
| rogpeppe | niemeyer: cool. i think it works ok. | 14:55 |
| niemeyer | Lunch time.. back in a moment | 15:16 |
| === marrusl_ is now known as marrusl | ||
| fwereade | need to be away for a while; I'll pop back on later tonight | 15:38 |
| rogpeppe | fwereade: ok. see you tomorrow. | 15:40 |
| * niemeyer waves | 15:58 | |
| niemeyer | robbiew: Do we have a call now? | 15:58 |
| robbiew | yes | 15:58 |
| robbiew | well...in 1.5min...but yes | 15:58 |
| rogpeppe | niemeyer: i'm off a little earlier today. i'll see you tomorrow. | 15:59 |
| niemeyer | rogpeppe: Cool, cheers, I'll try clean things up by the EOD tomorrow (hopefully!) | 15:59 |
| niemeyer | Erm, EOD today | 15:59 |
| niemeyer | robbiew: Cool, welcome back | 15:59 |
| rogpeppe | niemeyer: that would be great. it feels a little cluttered at the moment. i'm trying to avoid criss-cross merges... | 15:59 |
| niemeyer | rogpeppe: Yeah, I've been making my way through it, but still a bit to go | 16:01 |
| robbiew | niemeyer: biobreak..then will send g+ link :) | 16:02 |
| robbiew | TMI | 16:02 |
| niemeyer | robbiew: Ok, I'll send the invite.. just join when you're back | 16:03 |
| niemeyer | robbiew: Sent | 16:04 |
| robbiew | niemeyer: on my way | 16:09 |
| niemeyer | I suspect this is the largest branch/review yet: https://codereview.appspot.com/6145043/ | 18:27 |
| niemeyer | It's an awesome step forward, and it's also a great counter example for branch size :) | 18:27 |
| niemeyer | andrewsmedina: ping | 19:19 |
| niemeyer | andrewsmedina: pingous | 19:42 |
| niemeyer | andrewsmedina: Well, there's a ton of comments form Rog.. I'll put the branch as Work In Progress. Once you re-propose, it will show up in the active reviews again | 19:43 |
| niemeyer | andrewsmedina: If there's anything I can do in between, just ping me please | 19:43 |
| andrewsmedina | niemeyer: Im back | 20:50 |
| andrewsmedina | someone know why juju ssh use hostname instead ip? | 20:51 |
| SpamapS | niemeyer: any word on cs:precise/ubuntu ? | 22:17 |
| niemeyer | SpamapS: I've pinged Tom Haddon several times, without responses, and finally opened an rt ticket.. still waiting | 22:17 |
| niemeyer | SpamapS: devops ftw | 22:18 |
| SpamapS | niemeyer: RT is as agile as a bowling ball in a lake. | 22:22 |
| === asavu_ is now known as asavu | ||
| davecheney | niemeyer: https://codereview.appspot.com/6203083 | 22:52 |
| davecheney | niemeyer: i can't figure out why all this other stuff has leaked into this branch | 22:52 |
| davecheney | niemeyer: i figured it out, the -req this branch was based on was not up to date | 22:59 |
| niemeyer | davecheney: Heya | 23:06 |
| davecheney | niemeyer: hey | 23:06 |
| niemeyer | davecheney: Ah, yeah, easiest is to push the previous branch | 23:06 |
| niemeyer | davecheney: and then propose again.. should clean it up | 23:06 |
| davecheney | niemeyer: is there a way to switch the -req (maybe by hacking the lbox data?) | 23:06 |
| davecheney | niemeyer: yeah, that worked for me | 23:07 |
| niemeyer | davecheney: No, it doesn't work, only if you push it again | 23:33 |
| davecheney | niemeyer: fair enough | 23:36 |
| davecheney | niemeyer: % jujud -v provisioning --zookeeper-servers 127.0.0.1:2181 | 23:38 |
| davecheney | 2012/05/18 09:37:54 JUJU state: opening state; zookeeper addresses: ["127.0.0.1:2181"] | 23:38 |
| davecheney | 2012/05/18 09:37:54 JUJU state: waiting for state to be initialized | 23:38 |
| davecheney | 2012/05/18 09:37:54 JUJU invalid environment configuration: key "kind" was not present in the supplied configuration | 23:38 |
| davecheney | getting there | 23:38 |
| niemeyer | davecheney: Hah, neat! | 23:38 |
| davecheney | niemeyer: i look forward to the feedback from the team, but i'll keep working it this morning, and then move on to another pass at WatchMachines | 23:42 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!