=== fjlacoste is now known as flacoste
bigjoolswallyworld_: are you review bitch today?00:36
wallyworld_bigjools: depends00:36
=== wallyworld_ changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: wallyworld | Firefighting: - | Critical bugs: 3.47*10^2
bigjoolsshame, I was just thinking about lunch at the P&W00:37
wallyworld_bigjools: i can do that a bit later00:37
bigjoolsallrighty then00:37
rick_h_hey, team bonding is only to occur over approve video conference devices :P00:41
bigjoolsrick_h_: we can stare at each other through beer glasses, does that count?00:46
rick_h_hah, as long as the beer glasses aren't too thick where you get *confused*00:46
* StevenK stabs stacking more.01:33
wallyworld_wgrant: when specifying a maintainer for a distro, how often would someone choose a new team that is not in existence yet?01:40
wgrantwallyworld_: Somewhere between never and twice ever, I suspect.01:43
wgrantwallyworld_: For projects it's slightly more relevant, but only barely.01:43
wgrantI would not mourn its loss.01:44
wallyworld_wgrant: good. because the +reassign page for distros has "this is a new team" choice but the js picker will not have that01:44
mwhudsonis that the generic "object reassignment" view?02:06
mwhudsonbecause that one is pretty good evidence that generic views work well approximately never02:07
wallyworld_mwhudson: indeed it is02:15
* wallyworld_ goes to lunch with bigjools02:59
bigjoolsI can't eat any more of wallyworld_04:14
StevenKWell, he is full of cholesterol and coffee.04:15
StevenKwgrant: You object to http://pastebin.ubuntu.com/993569/ ?04:17
wgrantStevenK: Probably.04:31
wgrantStevenK: For one thing it's racy.04:31
wgrantThe existing stuff was already racy.04:31
wgrantBut this is probably worse.04:31
wgrantAnd it's also not clearly the correct behaviour.04:32
StevenKwgrant: But we can't agree on the correct behaviour. :-(04:36
wgrantProbably-buggy implementations of behaviour that hasn't yet been defined are fairly high on my schedule of things to object to.04:37
StevenKBut you also object without that change, and you say that there is nothing to discuss.04:38
wgrantThe two of us probably can't define what the correct behaviour should be, so just us discussing isn't going to be very helpful :()04:39
StevenKwgrant: There, that should make you slightly happier.05:31
wallyworld_StevenK: does your current work replace usages of transitively_private eg "if self.source_branch.transitively_private: do something"06:55
StevenKwallyworld_: I don't think so.07:02
StevenKPerhaps it should07:02
StevenKHowever, that branch is blocked07:02
wallyworld_StevenK: i am making branchcollection work with information_type. but tests are failing because stuff gets and sets private (and there's no hooks to sync info_type)07:03
wallyworld_StevenK: so i might add that in my branch then07:03
StevenKwallyworld_: So, I've discovered that an awful lot of code tests just set branch.explicitly_private directly. It's very annoying.07:04
wallyworld_StevenK: yes, indeed. i'm running into the same thing07:04
wallyworld_StevenK: i might introduce a mutator07:04
StevenKwallyworld_: That might work.07:04
wallyworld_StevenK: so if i do this stuff, it won't stomp on your work i hope07:05
StevenKwallyworld_: I'm going to have to redo part of the work anyway, due to the f&%&$*$^$$ stacking discussion07:05
wgrantwallyworld_: I think you basically have to wait for StevenK.07:05
wgrantDue to the stacking thing.07:05
wallyworld_what stacking thing?07:06
wgrantNeither branch can be deployed until that issue is resolved.07:06
StevenKwallyworld_: Read -dev07:06
StevenKwgrant: You saw it?07:06
wgrantBecause information_type doesn't behave like transitively_private yet.07:06
wallyworld_wgrant: i can deploy my branch because info_type will just be mirroring transitively private07:06
StevenKwallyworld_: The "Branch information_type and stacking" novel on the -dev list, that is.07:06
wgrantwallyworld_: Only if you use a trigger.07:07
wallyworld_ah right. but behind on my email07:07
StevenKwallyworld_: You can not assume that, since transitively_private is done by trigger and information_type is not.07:07
wgrantA mutator won't work07:07
wgrantSince it's done behind Python's back.07:07
wallyworld_sure. i haven't implemented anything yet07:07
StevenKThen don't, and wait for me.07:08
wallyworld_just finding failures in tests07:08
wallyworld_well, i've started the branchcollection work. but i'll park that07:08
* wallyworld_ reads email07:08
wgrantOnce we've solved that it should be pretty easy.07:08
StevenKI'll be auditing on Monday, anyway07:08
wallyworld_wgrant: StevenK: the branchcollectin stuff works, but tests fail due to info_type and private getting out of sync. so i'll come back to that after StevenK does his stuff07:11
wgrantSounds like a plan.07:12
=== wallyworld_ changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: - | Firefighting: - | Critical bugs: 3.47*10^2
wgrantNight wallyworld_.07:13
wallyworld_wgrant: i'm still here. just not ocr :-)07:13
adeuringgood morning07:55
=== adeuring changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: adeuring | Firefighting: - | Critical bugs: 3.47*10^2
danilosjelmer, hi, I see you claimed https://code.launchpad.net/~danilo/launchpad/kill-feedback-requests/+merge/106119: are there any questions you might have about it?09:26
jelmerdanilos: hi09:32
jelmerdanilos: yes, I started reviewing it yesterday. It seemed pretty straightforward09:32
jelmerdanilos: I'll try and finish it today, will ping you if I have any questions.09:33
danilosjelmer, ok, thanks, just making sure you are not blocked waiting on me or anything :)09:33
danilosjelmer, sure things, thanks again09:33
wgrantdanilos: That'll fail the person merge tests.09:34
daniloswgrant, it will? because of the DB fields still in?09:35
wgrantdanilos: Person merge is required to have explicit handling for any person FK involved in a UNIQUE constraint.09:35
wgrantdanilos: You've removed that, so it will complain.09:35
wgrantNormally you land a separate DB patch first which drops the FKs.09:35
wgrantThen you can drop the person merge bits and the rest of the code.09:36
wgrantAnd once that's deployed you can drop the table.09:36
daniloswgrant, right, I was hoping to be able to pass with only one DB patch :)09:36
wgrantSadly not.09:36
danilosbtw, what was the policy, a separate bug for each db-devel landing or can I just reuse the existing bug number?09:36
danilosack, thanks09:38
jamestunnicliffegmb: Mornin'. Now that your code is in https://code.launchpad.net/~dooferlad/launchpad/upcomingwork_show_incomplete_bp/+merge/105846, should I ask the on-call reviewer to take a look?09:43
gmbjamestunnicliffe: Yes, that sounds sane. Don't forget to mention danilos's branch w.r.t LoC. I'll have that reviewed this morning.09:44
danilosgmb, jelmer is on it already :)09:44
gmbdanilos: Ah, cool beans.09:44
* cjwatson looks very confused at dogfood. I'm sure I've screwed something up, but I don't know what09:45
cjwatsondogfood is at r15273; https://dogfood.launchpad.net/+apidoc/devel.html#packageset includes the new relative_build_score property; but:09:46
cjwatson$ lp-shell dogfood devel09:46
cjwatson>>> core = lp.packagesets.getByName(name='core')09:46
cjwatson>>> core.relative_build_score09:46
cjwatsonAttributeError: https://api.dogfood.launchpad.net/devel/package-sets/quantal/core object has no attribute 'relative_build_score'09:46
wgrantcjwatson: The WADL's probably old.09:46
cjwatsonAnyone have any clue what I did wrong?09:46
wgrantEither your cached WADL, or the one on mawson09:46
cjwatsonmawson seems to have it; how do I clear the local cache?09:47
cjwatsonah, let's try nuking this file ...09:48
wgrantSomewhere in ~/.launchpadlib09:48
wgrantIt changes :/09:49
cjwatsongot it, thanks09:49
cjwatson>>> core.relative_build_score09:49
daniloswgrant, fwiw, the following makes person-merge tests pass for me: https://code.launchpad.net/~danilo/launchpad/bug-1000642-db/+merge/10634310:05
wgrantdanilos: Great.10:15
daniloshum, branch is stuck at "updating branch"; I wonder if that's because I first pushed a branch with no changes compared to db-stable (forgot to commit the patch)10:18
danilosor if the branch scanner is just being slow (though, it has been pretty quick lately)10:18
danilosit updated, I guess it was just slow10:25
danilosjamestunnicliffe, I believe you'll need to request another review on https://code.launchpad.net/~dooferlad/launchpad/upcomingwork_show_incomplete_bp/+merge/10584610:54
jamestunnicliffedanilos: I know. I am just attempting to do some more testing, but having a bit of DB trouble.10:55
danilosjamestunnicliffe, ah, ok :)10:55
danilosjelmer, thanks for the review, we'll have to wait for the DB patch to land (stub has approved it) before we can land this12:20
wallyworld_sinzui: is there any reason why the distribution members field is not exported to the webservice  like mirror_admin (for example) is?12:27
sinzuiwallyworld_, there was never a request to export it. The team does not have power12:40
wallyworld_sinzui: if it is not exported, the ajax picker can't work12:49
sinzuiit can be exported12:49
wallyworld_so i would like to wrap the field definition inside exported()12:50
=== wallyworld is now known as wallyworld_
wgrantWe could just drop the field instead.12:53
wgrantThat would be my preference.12:53
sinzuiwgrant, I want to keep it. I would like to add it projects. I would only consider removing it if someone ever implements project team hierarchies AKA project affiliations12:58
wgrantBut the inconsistency with projects is confusing and silly.12:59
sinzuiwgrant, then we give project a members field so that Lp knows that the project has members who are not in an Lp role with power13:04
=== matsubara-afk is now known as matsubara
wgrantsinzui: Can you look at bug #1001181?13:16
_mup_Bug #1001181: Bug, branch and merge proposal views have large amounts of horizontal overflow in Firefox <javascript> <regression> <ui> <Launchpad itself:Triaged> < https://launchpad.net/bugs/1001181 >13:16
mrevelljelmer, Is there a way to view code imports by VCS type? I can't find one, so I'm guessing not.13:20
sinzuiwgrant, It is a regression. Something is  creating a very wide invisible something. I suspect help or a overlay which is visibility: hidden13:20
sinzuithey still take up space13:21
wgrantsinzui: Yeah, that seems to be the issue.13:21
wgrantI don't know quite which element it is, though.13:21
jelmermrevell: the code imports page has a way to list them by type13:21
wgrantPerhaps one of the new intermediate divs you added.13:21
jelmermrevell: e.g. https://code.launchpad.net/+code-imports?field.review_status=&field.review_status-empty-marker=1&field.rcs_type=HG&field.rcs_type-empty-marker=1&submit=Submit13:22
mrevelljelmer, Erk, yes, sorry13:22
sinzuiwgrant, I doubt that since the div would be following the existing rules. I think this might relate to the noscript branches I landed. I was going to remove the last Y.ua.ie hack fro our code today. I will solve this regression first13:23
wgrantsinzui: Unless there was a > rule or something. But yeah, could be noscript.13:23
wallyworldsinzui: i may have missed you reply - am i ok to export the distro members filed so the ajax picker can work?13:31
wallyworld /msg NickServ identify cuteb8913:33
jamestunnicliffeHi, hopefully someone with good Zope Template foo can help. I need to conditionally add a class to a <tbody> element. I am not finding anything useful in the docs.14:54
jcsackettjamestunnicliffe: i'm not TAL expert, but this *might* work. http://pastebin.ubuntu.com/994317/14:58
jcsackettsomeone with better TAL foo could probably come up with something better, but it's a start.14:58
benjijcsackett and jamestunnicliffe: unfortunately that won't work because it's not well formed.  One second, let me see if I can remember the way to do that.15:00
jcsackettbenji: doh, you're right.15:00
benjithe best way is probably to just tal:define the class list conditionally and have a single <tbody> element that uses that definition15:01
jamestunnicliffeSounds reasonable.15:02
=== salgado is now known as salgado-lunch
=== matsubara is now known as matsubara-lunch
=== deryck is now known as deryck[lunch]
jamestunnicliffeHi, I see that the on call reviewer is offline. What is the protocal at this point? Assign the review to launchpad and let someone claim it/17:37
cjwatsonjust leave the merge proposal at the defaults17:39
=== matsubara-lunch is now known as matsubara
=== salgado-lunch is now known as salgado
=== deryck[lunch] is now known as deryck
abentleyderyck: if around, could you please review https://code.launchpad.net/~abentley/maza-lib/basic-auth/+merge/106465 ?20:36
deryckabentley, sure20:50
deryckabentley, looks good to me.  r=me21:02
abentleyderyck: Thanks.21:03
deryckabentley, np.  and have a nice weekend!  I am about to step away now.21:03
abentleyderyck: You too!21:03
kendfingerI have a Code import of the Chromium Git repo. it failed last time, and I am trying again as I see nothing wrong. I tried the SVN repo, but It imported , but I could not branch or browse the code! Anybody else have a problem like this?22:06

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!