| === yofel_ is now known as yofel | ||
| mandel | morning all! | 08:28 |
|---|---|---|
| * mandel update reboot | 09:02 | |
| rye | verterok: morning | 09:43 |
| gatox | good morning! | 11:01 |
| gatox | mandel, i add a comment in the MP | 11:27 |
| mandel | gatox, ok, checking :) | 11:28 |
| mandel | gatox, god I hate that pyflakes does not have disable comments :( | 11:28 |
| gatox | yap | 11:29 |
| mandel | gatox, branch approved.. | 11:29 |
| gatox | mandel, thx | 11:29 |
| gatox | mandel, how was your weekend? | 11:29 |
| gatox | mandel, and hi! jeje | 11:29 |
| mandel | gatox, I might ask you for a review later, the windows tests are broken when I changed the API of the TCP activation in sso so I'm fixing and adding domain sockets in u1-client and u1-cp | 11:30 |
| mandel | gatox, weekend was good, went to buy furniture and not much more :P | 11:30 |
| mandel | gatox, I was at the gym on saturday worked out too much and was tired for the rest of the weekend hehe | 11:30 |
| gatox | mandel, jejejejee | 11:31 |
| mandel | gatox, how was yours, lots of kinet? | 11:33 |
| mandel | gatox, is it worth it? | 11:33 |
| mandel | gatox, I mean, is it fun to play etc.. 'cause I've seen you killing zombies.. and I would have not uploaded that video to the internet :) | 11:33 |
| gatox | mandel, lot of ninja coding, and on saturday we went to my house in carlos paz (perrito, nessita, matiasb and some others)..... in we ate a lotttttttt of asado! | 11:34 |
| gatox | jejeje | 11:34 |
| mandel | gatox, nice! | 11:34 |
| gatox | mandel, yes, the kinect worth it..... is really fun | 11:34 |
| mandel | gatox, I'd love to be there.. specially when my country is going down to hell.. putos politicos | 11:34 |
| gatox | mandel, also.... you can plug it to your computer, and make your own programms using the kinect | 11:34 |
| gatox | mandel, jejeje well i promise an asado if you come to cordoba :P | 11:35 |
| mandel | gatox, would be good to remove the need of a remote.. that way the dog will not distroy it | 11:35 |
| mandel | gatox, I'm jotted down that offer :) | 11:35 |
| gatox | mandel, ahhh my talk in pycon australia was rejected..... so...... not spain soon :( | 11:36 |
| gatox | mandel, i'm planning to take some vacations in japan :D | 11:36 |
| mandel | gatox, oh :( | 11:36 |
| mandel | gatox, I'm going to thailand this year, japan might be nexts holidays | 11:36 |
| gatox | mandel, when you go to visit some new places...... you hire some tourist guide or something..... or tourist package...... or arrange everything by your own? | 11:37 |
| * gatox is trying to decide which is more fun | 11:38 | |
| mandel | gatox, I usually go crazy if I go alone, I usually book a hostal because there you are going to meet students and young people (means going out which is a good thing to do) and then once I have 'friends' I improvise :) | 11:38 |
| mandel | gatox, so for me, student hostals are the way to go | 11:39 |
| gatox | jejeej | 11:39 |
| gatox | yap..... i wanted something more like a tour for japan..... | 11:39 |
| mandel | gatox, I'd buy a guide and then use the train seems to be the best thing to do | 11:41 |
| gatox | yes..... probably | 11:42 |
| mandel | gatox, in my trip to thailand I'm getting there and booking everything from there but knowing a little before hand, for example I'll stay 3 days in the jungle in an elephant trip :) | 11:42 |
| gatox | mandel, wowwwwww | 11:42 |
| gatox | pictures! | 11:42 |
| mandel | gatox, sure, I'm even considering getting eye surgery done so I don't longer need the glasses | 11:43 |
| mandel | gatox, I don't want to get lost in the jungle loose then and get eating by predator :P | 11:43 |
| gatox | jejejeje sounds logic jejeje | 11:43 |
| mandel | gatox, so the ipc on u1-client is using mocker.. I'm very tempted to remove it so that I can add tests for domain sockets too, what do you think? | 11:55 |
| gatox | mandel, the rule is: if you are fixing/adding some tests where it contains mocker now..... REMOVE IT! | 11:55 |
| gatox | (whenever you can) | 11:56 |
| mandel | gatox, well, I think I do have to touch the tests because they are old right now.. :) | 11:56 |
| mandel | gatox, also, I made changes to the code and the tests pass which is not a very good sign.. | 11:56 |
| gatox | jejeje | 11:56 |
| ralsina | Good morning | 12:17 |
| mandel | ralsina, morning! | 12:19 |
| ralsina | Hola mandel, how's things? | 12:19 |
| ralsina | Is the mac port done yet? | 12:20 |
| ralsina | ;-) | 12:20 |
| mandel | ralsina, lol I wish, I'm fixing the windows tests and in the same branch adding support for domain sockets for u1-client and u1-cp which gets us a step closer :) | 12:21 |
| gatox | ralsina, buenas | 12:21 |
| ralsina | mandel: ack, saw jenkins whining a bit ago, which is a good thing | 12:22 |
| mandel | ralsina, then, more fsevents code to increase tests and add integration | 12:22 |
| mandel | ralsina, yeah, this started late my friday (at least first time I got it) I'll try to set up the mac jenkins this afternoon (I have to play with my rooter, ouch!) | 12:22 |
| ralsina | mandel: I just found out I can't use the mini yet because I have no mice | 12:23 |
| ralsina | mandel: so I have to buy one and it's raining :-/ | 12:23 |
| mandel | ralsina, he, your new cat must be very good :P | 12:24 |
| ralsina | mandel: como se llama el ave que incendia los campos mexicanos? | 12:24 |
| mandel | ralsina, ni idea, como? | 12:25 |
| ralsina | mandel: (deci rapido) el pajaro quema maiz | 12:25 |
| karni | rye: FWIW, fresh comments appeared under bug #879342 | 12:25 |
| ubot5 | Launchpad bug 879342 in Ubuntu One Servers "Got status code 302 or 401 using Ubuntu One" [Undecided,Triaged] https://launchpad.net/bugs/879342 | 12:25 |
| gatox | ralsina, jajajaa | 12:26 |
| mandel | ralsina, uf, tan malo como, como se dice autobus (colectivo) en aleman? | 12:26 |
| ralsina | mandel: subanaprietesetrujenbajen? | 12:26 |
| mandel | ralsina, si :) | 12:27 |
| ralsina | mandel: that one was old when I was not | 12:27 |
| ralsina | ;-) | 12:27 |
| rye | karni: slow network connection, timestamp checking. same thing | 12:27 |
| mandel | ralsina, last one, como se dice cuanto cuesta un pajaro en vasco? | 12:27 |
| ralsina | mandel: you told me already | 12:27 |
| ralsina | mandel: acuantolacacatua? | 12:27 |
| karni | rye: Could we mark it as 'in progress' perhaps? Or let them know we're working on it. | 12:27 |
| mandel | ralsina, es cara la cacatua? | 12:27 |
| mandel | ralsina, I need to get new jokes :( | 12:28 |
| rye | karni: in progress | 12:28 |
| karni | rye: thanks | 12:28 |
| ralsina | mandel: OTOH, the one I did about a song with diego in twitter right now? I am fairly proud of that one! | 12:28 |
| ralsina | And enough jokes, let's fix a bug or two | 12:28 |
| mandel | :) | 12:28 |
| gatox | :P | 12:28 |
| alecu | hey ya! hey ya' all! | 12:28 |
| gatox | alecu, hi | 12:29 |
| * rye injects https://code.launchpad.net/~rye/ubuntuone-client/ignore-in-close-write-in-dirs/+merge/106612 - nothing to fix, just test under Ubuntu ^_^ | 12:29 | |
| ralsina | hola alecu! | 12:29 |
| ralsina | rye: looking | 12:29 |
| rye | because if i write an automatic test for this you will all hate me. Setting up ecryptfs directories in tarmac, managing mounts... | 12:30 |
| ralsina | rye: is this the cause of all the weird eCryptfs errors? | 12:30 |
| ralsina | or at least some of them? | 12:30 |
| ralsina | rye: haha | 12:30 |
| rye | ralsina: no, of only one of them: when you cd to ~/Private, syncdaemon explodes and won't synchronize anything until restart | 12:30 |
| ralsina | rye: yes, we will not add tests for that :-) | 12:30 |
| mandel | ok, I'm off to have lunch | 12:31 |
| * mandel lunch | 12:31 | |
| ralsina | Anyone other than rye has branches for review I should look at? | 12:31 |
| alecu | rye, no need to do an integration test for this; but a unit test would be nice. | 12:32 |
| rye | alecu: the thing is that i can't cause pyinotify to trigger this | 12:33 |
| alecu | rye, so, we should at least build a pair of tests that try to send the IN_CLOSE_WRITE and that check whether it was pushed or not. | 12:33 |
| mandel | ralsina, there are a few but I think I went over all of them.. | 12:34 |
| rye | alecu: another thing - we don't seem to have any test that tests for filters like this | 12:34 |
| ralsina | mandel: ok | 12:34 |
| alecu | rye, we should send a synthetic event. But don't worry, I can take care of those tests. | 12:34 |
| alecu | rye, thanks a lot for finding this and for your fix. | 12:34 |
| rye | alecu: it has been sitting in LP for 6 months and today joshuahoover forwarded me a ticket with exactly this problem and I recalled I promised to get it in in some of my blog posts | 12:35 |
| ralsina | alecu: so you will branch from that branch? | 12:35 |
| alecu | ralsina, right | 12:35 |
| ralsina | alecu: ok, cancelling review | 12:36 |
| rye | alecu: so should I unpropose the branch? | 12:44 |
| dobey | huh? | 12:49 |
| alecu | rye, I'm working on the test, then you can add it from my branch so the branch with the fix is still the one you did. | 12:53 |
| dobey | ralsina: https://code.launchpad.net/~dobey/poauth/test-runner/+merge/105874 still has no reviews :) | 12:53 |
| ralsina | dobey: on it | 12:53 |
| rye | alecu: oh, shiny! I get all the credits! | 12:55 |
| alecu | rye, and the karma, yes. | 12:56 |
| * rye loves bzr --author switch | 12:57 | |
| ralsina | dobey: line 107 of the diff, why? | 13:01 |
| ralsina | dobey: same thing in other places, too | 13:01 |
| dobey | ralsina: you mean the new line? | 13:02 |
| dobey | line 187 in the diff isn't a change, either | 13:02 |
| ralsina | dobey:107 not 187 | 13:02 |
| dobey | oh, 107 | 13:02 |
| dobey | doh | 13:02 |
| dobey | because python3 | 13:02 |
| ralsina | dobey: you are using list() on a generator | 13:02 |
| dobey | no | 13:02 |
| ralsina | dobey: both are valid on python 3 | 13:02 |
| dobey | am using list() on a thing that isn't a list | 13:02 |
| dobey | .items() does not return a list on python3 | 13:03 |
| ralsina | dobey: yes items() on py3 is a generator. You can iterate over it just fine | 13:03 |
| ralsina | dobey: https://pastebin.canonical.com/66420/ | 13:04 |
| dobey | tell that to 2to3 | 13:05 |
| ralsina | dobey: do not use 2to3, 2to3 is dumb :-) | 13:05 |
| ralsina | dobey: or, better, explain me the problem. So, if you use 2to3 on that without the list() it fails? | 13:06 |
| dobey | 2to3 just outputs a diff of suggested changes. one of those suggested changes is to include the list() there | 13:06 |
| ralsina | dobey: ok, that one doesn't seem necessary, and is kinda ugly | 13:07 |
| dobey | i can change it to not have the list() i guess | 13:07 |
| ralsina | dobey: please | 13:08 |
| ralsina | dobey: that change only is useful when you are using items in a non-iterative fashion, which it seems is not the case in any place here | 13:10 |
| dobey | pushed | 13:10 |
| ralsina | dobey: you can even tell 2to3 to not suggest those changes with -x dict (but that disables a bnch of other stuff too) | 13:11 |
| dobey | ralsina: also, i guess we do need to backport some things for windows-installer, and maintain a stable branch, if we are going to ever have nightlies, beta, and stable releases for windows | 13:11 |
| ralsina | dobey: yeah | 13:11 |
| ralsina | dobey: it makes sense to have a stable branch that builds from stable and keep trunk building from trunk | 13:11 |
| dobey | i guess i'll do that then | 13:13 |
| ralsina | dobey: should be just a small fix in conf.py | 13:14 |
| rye | erm... how come i have conflicts in https://code.launchpad.net/~rye/ubuntuone-client/ignore-in-close-write-in-dirs-stable-3-0/+merge/106613 ??? | 13:18 |
| rye | oh | 13:18 |
| rye | i know | 13:18 |
| dobey | wow that is a long branch name | 13:18 |
| rye | proposed against trunk | 13:19 |
| rye | dobey: if it breaks, i found a bug :) | 13:19 |
| dobey | rye: not really. unix sockets have a maximum filename length | 13:20 |
| dobey | rye: so if it breaks, your branch name is too long :) | 13:21 |
| rye | yeah, i guess 128 characters | 13:29 |
| dobey | rye: why no unit test? | 13:34 |
| rye | dobey: alecu is working on that since he knows where events can be injected from | 13:34 |
| rye | switched to WIP | 13:35 |
| ralsina | dobey: +1 | 13:36 |
| dobey | morning briancurtin | 13:39 |
| briancurtin | morning dobey | 13:39 |
| dobey | briancurtin: are any of the last 3 changes on https://code.launchpad.net/~ubuntuone-control-tower/ubuntuone-windows-installer/trunk necessary for doing the 3.0.1 release for winodws? | 13:40 |
| briancurtin | dobey: nope, those aren't needed for it | 13:41 |
| dobey | ok, cool | 13:42 |
| alecu | rye, https://code.launchpad.net/~alecu/ubuntuone-client/ignore-in-close-write-in-dirs | 13:42 |
| alecu | rye, (still running the tests on it, though) | 13:42 |
| * mandel back | 13:47 | |
| dobey | briancurtin, ralsina: made the 'release' of windows-installer 3.0.1 with updated xml to change the version to 3.0.1 and build to 1001 | 13:48 |
| ralsina | dobey: awesome, thanks | 13:48 |
| dobey | so you should be able to build a 3.0.1 release for windows now | 13:49 |
| rye | alecu: wow, i spent a couple of days ago trying to come up with the test... and all I was thinking - how to make filesystem send these events | 13:51 |
| ralsina | briancurtin: what dobey said^ | 13:51 |
| briancurtin | ralsina: how should that affect the 3.0.1 installer i already built? i was going to do some last testing this morning then ask if rick got a chance to look at it, then get everything signed | 13:52 |
| ralsina | briancurtin: well, since you already built it, in no way I guess :-) | 13:53 |
| dobey | i thought that was a "candidate" and we'd build a proper thing after the stuff was released | 13:53 |
| ralsina | dobey: the idea of a candidate is that if it's approved, it's shi[pped | 13:54 |
| dobey | ralsina: but the idea of having consistent releases across platforms is that everything is built from things that are released :) | 13:54 |
| ralsina | dobey: yeah, we have a conflict of paradigms here ;-) | 13:56 |
| ralsina | dobey, briancurtin: we need to decide on a worklow here | 13:57 |
| ralsina | flow* | 13:57 |
| ralsina | dobey, briancurtin: and I am sure you two can come up with a nice one | 13:57 |
| ralsina | For this release, just ship the one that's done, for the next one, we have a defined checklist and steps to follow | 13:58 |
| ralsina | dobey: plus, the one that was built on friday should be the exact same code as this one we could build now, really | 13:58 |
| briancurtin | since "creating the release" in LP is something dobey does, at least for now, i'd hate to have him go through any of that, then come back today and say no now we need to include these two branches, do another candidate, come back with another branch, then we finally release | 13:59 |
| ralsina | briancurtin: the main problem being that we keep needing magic branches | 13:59 |
| ralsina | briancurtin: which is something we should aim to get rid of for the next release, anyway | 14:00 |
| briancurtin | id certainly love to get away from that | 14:00 |
| dobey | well, what is the current 3.0.1 installer built from exactly? | 14:00 |
| ralsina | briancurtin: we are all in agreement there. We just need to get it fixed. So, you and I will do it before the next release. Plus, with the nightlies from jenkins, we can get have QA test before we do a "real" release, and avoid all this silly work you have to do now. | 14:01 |
| * ralsina is -1 on english today :-/ | 14:01 | |
| dobey | msinly, i think we should also strive to have reproducible builds on windows as well as linux. | 14:02 |
| briancurtin | dobey: it's from stable 3.0.0 plus https://code.launchpad.net/~brian.curtin/ubuntuone-control-panel/c2c-loading and https://code.launchpad.net/~brian.curtin/ubuntuone-client/fix984407-windows-is_root | 14:02 |
| dobey | err mainly, not msinly | 14:02 |
| dobey | briancurtin: ok i think we definitely need a new installer then | 14:02 |
| ralsina | briancurtin, dobey: isn't windows-is_root in 3-0 now? | 14:02 |
| briancurtin | crap...do we still need mandel's extra logging SSL branch | 14:02 |
| ralsina | briancurtin: no, that's merged | 14:03 |
| briancurtin | yeah, i have no idea what we're doing then | 14:03 |
| mandel | briancurtin, is there :) | 14:03 |
| dobey | ralsina: actually i don't think the extra logging is in stable-3-0 | 14:03 |
| ralsina | dobey: oops, it should, shouldn't it? | 14:03 |
| briancurtin | i do the release from stable-3-0 on the 3.0.0 tag, plus the two branches listed above | 14:03 |
| mandel | ralsina, dobey, briancurtin, it is in trunk.. maybe not in an stable branch | 14:03 |
| briancurtin | so mandel's branch isn't in the stable, so i forgot that one... | 14:04 |
| briancurtin | ugh | 14:04 |
| dobey | there are lots of other branches that should be included in the 3.0.1 release | 14:04 |
| ralsina | briancurtin: ok, let's do one from 3.0.1 tag instead. dobey: we should get mandel's branch in stable, too :-( | 14:04 |
| ralsina | briancurtin: anyway, we probably can't get QA today because it's accounts-releas-day-again | 14:04 |
| briancurtin | ralsina: no problem. i will take a look today and see what i can find on my own, then get them a release whenever they can take it | 14:05 |
| ralsina | mandel: please restate bug #1002208 as a bug? :-) | 14:07 |
| ubot5 | Launchpad bug 1002208 in Ubuntu One Client "Unix domain sockets should be used for the IPC on darwin" [Medium,In progress] https://launchpad.net/bugs/1002208 | 14:07 |
| mandel | ralsina, fuuu ok, on it, I wish my todos would use bug titles.. | 14:08 |
| dobey | i wish bitrock had good version comparison support | 14:13 |
| ralsina | mandel: thing is, a bug should describe something that is wrong, not how we want to fix it | 14:16 |
| joshuahoover | ralsina, briancurtin: i think we can probably do qa on windows in between new accounts work...don't hold up on it for qa...if need be i'll help test again | 14:16 |
| mandel | ralsina, I know, I just keep writing things as my todo list.. | 14:16 |
| ralsina | mandel: so "Darwin is using wrong transport" is a bug title, specially with a description explaining why | 14:16 |
| ralsina | mandel: I used to do the same, but it' tricky to hand bugs over when they are done as todos :-) | 14:17 |
| ralsina | joshuahoover: ack | 14:18 |
| ralsina | joshuahoover: we have some minor branch selection troubles to clear first, but we'll have something today | 14:18 |
| mandel | ralsina, I know.. sorry | 14:18 |
| ralsina | mandel: np | 14:18 |
| * briancurtin rebooting since windows update keeps nagging me | 14:20 | |
| joshuahoover | ralsina: can you update the rt ticket to let IS know it's not coming today and give them an estimate on when they should expect it? i'm thinking wednesday or thursday at this point, but i'll leave that up to you | 14:20 |
| ralsina | joshuahoover: I think it can go out today, if QA can do a minimal run of tests | 14:21 |
| ralsina | joshuahoover: at least put the binaries for signing late today | 14:21 |
| joshuahoover | ralsina: oh, ok...i guess it depends on when we get the installer today...but yeah, assuming we get it before the end of the day today then we should be able to turn it around with testing pretty quick | 14:22 |
| ralsina | joshuahoover: we'll try to get it ASAP and then we'll see | 14:22 |
| ralsina | joshuahoover: worst case it will be uploaded tomorrow morning | 14:23 |
| joshuahoover | ralsina: ok, sounds good | 14:23 |
| * mmcc finishes reading backlog | 14:28 | |
| mmcc | morning all | 14:28 |
| mandel | ralsina, gatox, can I have a very easy review for the following: https://code.launchpad.net/~mandel/ubuntu-sso-client/darwin-ac-cmdline/+merge/106635 I just moved the code out to the correct function and allowed it to be used at package level | 14:29 |
| gatox | mmcc, hi | 14:29 |
| mandel | mmcc, morning!! | 14:29 |
| gatox | mmcc, of course | 14:29 |
| ralsina | gatox: sure | 14:29 |
| rye | YAY 3rd IPC in U1 for Mac OSX | 14:29 |
| ralsina | mmcc: good morning! | 14:29 |
| mandel | mmcc, I did a review I owed you, there are some small things to fix | 14:29 |
| gatox | ohhhh the review was for mandel | 14:29 |
| gatox | mandel, of course | 14:29 |
| gatox | jeje | 14:29 |
| mandel | gatox, te odio -_- | 14:29 |
| mandel | :P | 14:29 |
| * gatox has the ability to ping always the wrong person | 14:29 | |
| mmcc | ok mandel, still going thru emails... | 14:30 |
| * rye goes to the last spanish lesson | 14:31 | |
| ralsina | mandel: +1 | 14:33 |
| mandel | ralsina, thx! | 14:33 |
| gatox | mandel, +1 | 14:37 |
| mandel | gatox, thx, we need to change that to work in a decent manner on darwin but the current imp is ok for what we need atm | 14:38 |
| ralsina | briancurtin, dobey: want to talk about what is and is not in stable-3-0 and what should be in 3.0.1? | 14:42 |
| briancurtin | yes | 14:42 |
| ralsina | briancurtin: good, talk with dobey and I will listen and chime in when needed :-) | 14:43 |
| briancurtin | so at the very least, what i've been using has been stable-3-0 plus the is_root fix (the main point of the release), the c2c fix (allows c2c page to, at the very least, not display "getting information" forever), and it should have included mandel's SSL logging branch | 14:45 |
| briancurtin | i'm certain there is more to release, but i'm not sure if this release is just intended to fix the is_root problem since that is starting to build up support tickets, or if we want to release everything else that has been added since 3.0.0 release | 14:45 |
| dobey | if we're going to release it as 3.0.1, then it should include what's in 3.0.1 (and i guess the ssl logging branch if necessary) | 14:46 |
| dobey | there are definitely other important fixes in the 3.0.1 tarballs which i think should get pushed out in the windows release as well | 14:47 |
| briancurtin | that makes sense to me, i just didnt know what else constituted 3.0.1 | 14:47 |
| briancurtin | since i already forgot the mandel branch, i need to create another installer anyway, so i can do it from 3.0.1 plus our select branches (probably just C2C then) | 14:48 |
| ralsina | briancurtin, dobey: seems to me we rushed the windows bit and should instead have held back until we had 3.0.1 "done" | 14:48 |
| dobey | ralsina: right | 14:48 |
| briancurtin | agreed. i only had my windows hat on, so when we had windows ready, i was ready to roll | 14:48 |
| gatox | mandel, mmcc can we move the fsevents mumble from today to tomorrow?? i'm taking half-day sick after the standup because i'm with a really bad headache | 14:48 |
| ralsina | hopeully this release will be awesome enough that we'll feel no rush to do the next one | 14:48 |
| briancurtin | rather, that one windows fix ready | 14:48 |
| mandel | gatox, I'm ok with it | 14:49 |
| gatox | mandel, thanks! mmcc ? | 14:49 |
| mmcc | yeah, no problem, feel better gatox! | 14:49 |
| gatox | mandel, mmcc thanks! i'll update the event | 14:49 |
| mmcc | I was sick all weekend, I feel your pain :\ | 14:49 |
| gatox | mmcc, bummer..... | 14:50 |
| dobey | briancurtin: the thing is, i don't think we had windows ready, necessarily :) | 14:50 |
| gatox | mmcc, mandel i sent the update | 14:50 |
| mmcc | mandel, just pushed your suggested changes. | 14:50 |
| briancurtin | dobey: i dont *actually* think that either, we just got that is_root branch in so for most people (customers), it was ready in that they'd actually be able to use it | 14:50 |
| mmcc | brb in time for standup... | 14:51 |
| dobey | briancurtin: right. assuming that it didn't break for them on a couple of other bugs in u1-client :) | 14:51 |
| dobey | briancurtin: anyway, it sounds like you need to use the release-3_0_1 tag now, and also include that c2c branch, and the extra ssl logging branch from mandel | 14:52 |
| mandel | mmcc, ok, will take a look in a few mins | 14:52 |
| briancurtin | dobey: so it's that tag from the stable-3-0 *branch*, correct? (just making sure i have the right terminology) | 14:53 |
| dobey | briancurtin: right | 14:53 |
| ralsina | dobey, briancurtin: we could think of something for "patch releases" like we have in ubuntu, where we do a release from a tag + a patch. But numbering gets crazy. | 14:58 |
| gatox | me | 15:00 |
| mmcc | me | 15:00 |
| alecu | me too | 15:01 |
| briancurtin | me | 15:01 |
| gatox | mandel, ralsina dobey ? | 15:01 |
| mandel | me | 15:01 |
| ralsina | me | 15:01 |
| dobey | me | 15:02 |
| gatox | DONE: | 15:02 |
| gatox | Friday: lot of improves in the freaky friday project. Today: Debug Filesystem notifications (not root implementation) tests, a little bit closer. | 15:02 |
| gatox | TODO: | 15:02 |
| gatox | Rest (Take half-day sick leave). | 15:02 |
| gatox | BLOCKED: | 15:02 |
| gatox | No | 15:02 |
| gatox | mmcc, go | 15:02 |
| mmcc | DONE: read up on sandboxing, delinted network detection, made decision doc for osx client | 15:02 |
| mmcc | TODO: daemon on 10.6, packaging | 15:02 |
| mmcc | BLCK: NO | 15:02 |
| mmcc | NEXT: alecu | 15:02 |
| alecu | DONE: finishing security work, some tests for rye's branch | 15:02 |
| alecu | TODO: mumble with mandel, mmcc, gatox: OSX notifications, wrap up security patches | 15:02 |
| alecu | BLOCKED: no | 15:02 |
| alecu | NEXT: briancurtin | 15:02 |
| briancurtin | DONE: half day, release stuff | 15:02 |
| briancurtin | TODO: make a new release based on what we just talked about, test it, etc | 15:02 |
| briancurtin | NOTE: in an hour i have a PSF Board meeting so i'll be around but on the phone | 15:02 |
| briancurtin | BLOCKED: none | 15:02 |
| briancurtin | NEXT: mandel | 15:02 |
| mandel | DONE: Reviews, reviews, reviews. Bug 1002307. Worked on bug 1002208 and bug 1001296 to get ipc on windows back on u1-client and add domain sockets support for darwin. | 15:02 |
| mandel | TODO: More on 1002307 and 1001296 (making the ipc tests with pb run on linux and over both transports), more reviews, fix u1-cp ipc for the same reasons as the above mentioned bugs. | 15:02 |
| mandel | BLOCKED: no | 15:02 |
| mandel | ralsina, please | 15:02 |
| ubot5 | Launchpad bug 1002307 in Ubuntu Single Sign On Client "The darwin implementation of get_activation_cmdline is missing" [Medium,Fix committed] https://launchpad.net/bugs/1002307 | 15:02 |
| ubot5 | Launchpad bug 1002208 in Ubuntu One Client ""Darwin is using wrong transport" [Medium,In progress] https://launchpad.net/bugs/1002208 | 15:02 |
| ubot5 | Launchpad bug 1001296 in Ubuntu One Client "Tests are broken on Windows" [High,In progress] https://launchpad.net/bugs/1001296 | 15:02 |
| ralsina | DONE: bled from my nose all over my notebook (looks like blood is not conductive!), reviews, minor coding, figuring out what bug to hit first, bug triaging, askubuntu answering, canonicaladmining, etc. TODO: fix a bug BLOCKED: no | 15:02 |
| ralsina | dobey! | 15:03 |
| dobey | λ DONE: 1-1 review meeting, 3.0.1 backports, 3.0.1 releases | 15:03 |
| dobey | λ TODO: finish bug #853060, 3.0.1 SRUs, u1-installer 3.0.1 release/SRU | 15:03 |
| dobey | λ BLCK: none. | 15:03 |
| ubot5 | Launchpad bug 853060 in ubuntuone-installer "ubuntuone-installer crashed with GError in function(): Failed to execute child process "ubuntuone-control-panel-gtk" (No such file or directory)" [Critical,In progress] https://launchpad.net/bugs/853060 | 15:03 |
| alecu | ralsina, ugh, nosebleed! are you all right? | 15:03 |
| ralsina | alecu: yeah | 15:03 |
| thisfred | me | 15:03 |
| ralsina | alecu: I have been having sinus issues all morning, and finally blew my nose once too many | 15:03 |
| gatox | alecu, i didn't see you in the guest list of the mumble meeting.... i talked with mandel and mmcc if we can move that for tomorrow.... because i'm about to take half-day sick leave now...... because i'm with a really bad headache | 15:04 |
| thisfred | DONE: productive u1db handover sprint TODO: lots, first thing: u1db combine() mapping BLOCKED: no | 15:04 |
| gatox | alecu, did you receive the update of the calendar event? | 15:04 |
| alecu | gatox, no | 15:04 |
| alecu | gatox: but now I see it updated, yes | 15:05 |
| gatox | alecu, it's ok with you to do it tomorrow? | 15:05 |
| alecu | gatox: oh, yes. No problem. | 15:07 |
| gatox | alecu, thx...... i'm off for today now....... | 15:07 |
| gatox | see you tomorrow! | 15:07 |
| alecu | gatox: bye! | 15:07 |
| ralsina | no comments? | 15:08 |
| ralsina | EOM | 15:09 |
| * alecu will be back in 10' | 15:13 | |
| dobey | ok, need to get lunch. and then lots of SRU uploads and finishing up this installer bug | 15:21 |
| dobey | bbiab | 15:21 |
| thisfred | mandel: I have shared with you jam's windows environment which should be everything required to run u1db tests on windows | 15:40 |
| mandel | thisfred, via email? | 15:40 |
| mandel | thisfred, ok, got it :) | 15:41 |
| thisfred | mandel: via this filesyncing service I heard about ;) | 15:43 |
| alecu | briancurtin, you are aware of the branch that mandel is about to propose that fixes ipc on windows, right? | 15:43 |
| briancurtin | alecu: no | 15:43 |
| alecu | briancurtin, are you releasing from trunk or from the tar.gz? | 15:44 |
| briancurtin | alecu: stable-3-0 branch, release-3_0_1 tag | 15:44 |
| alecu | briancurtin, the branch is for trunk, since one of the recent branches that changed ipc to use unix domain sockets for osx broke ipc on windows. | 15:44 |
| alecu | briancurtin, we should make sure that this issue is not present on 3-0-1 | 15:45 |
| alecu | mandel, what would the symptoms for this be? just ipc not working? | 15:45 |
| alecu | it should be easy to tell :-) | 15:45 |
| briancurtin | alecu: i'm building the installer right now so i'll know in a few minutes what happens | 15:46 |
| alecu | briancurtin, great. | 15:46 |
| ralsina | alecu: that brach never made it to stable-3-0 AFAIK | 15:46 |
| alecu | ralsina, great. And I guess it did not make it to 3-0-1 either. | 15:47 |
| mandel | alecu, I believe as ralsina said that this broke trunk and not stable-3-0 but let me check since it is code in sso | 15:47 |
| * alecu sighes relieved. | 15:47 | |
| * mandel takes a look | 15:47 | |
| ralsina | alecu: shouldn't | 15:47 |
| alecu | briancurtin, ralsina, mandel: what about the branch that logs the ssl details? Why are we manually including it instead of merging it into trunk or stable? | 15:49 |
| mandel | ralsina, briancurtin, alecu, if we are using lp:ubuntu-sso-client/stable-3-0 to build the installer there should be no issues with the release | 15:49 |
| alecu | mandel, great with that. | 15:49 |
| mandel | alecu, is in trunk, I guess it was not moved to the stable branch, no idea why | 15:49 |
| ralsina | alecu: I assumed that branch was merged into stable, seems I assumed wrongly | 15:49 |
| ralsina | alecu: tech leads in 10' | 15:51 |
| alecu | ralsina, thanks. | 15:51 |
| briancurtin | ugh, can't find the bug i reported about sso not working, which i think was related to mandel's IPC issue. LP sucks. | 15:52 |
| mandel | briancurtin, was that in production? 'case the ipc is broken but was never released AFAIK | 15:52 |
| briancurtin | mandel: no it was just on my machine using trunk | 15:53 |
| joshuahoover | ralsina: any ideas on what to tell windows users getting the valicert error? | 15:53 |
| briancurtin | i was trying to debug something the other day and while tests always worked, actually starting up CP and everything else wasnt working | 15:53 |
| mandel | briancurtin, ok, let me know when you get the but num and I'll take a llook asap | 15:53 |
| briancurtin | oh here it is, mandel: https://bugs.launchpad.net/ubuntu-sso-client/+bug/1000407 | 15:55 |
| ubot5 | Ubuntu bug 1000407 in Ubuntu Single Sign On Client "AttributeError on new install" [Undecided,Confirmed] | 15:55 |
| briancurtin | i dont know how, if at all, that is related to your work...but its something that broke recently | 15:55 |
| alecu | briancurtin, https://bugs.launchpad.net/~brian.curtin/+reportedbugs ? | 15:55 |
| ralsina | joshuahoover: we have one of those? | 15:56 |
| joshuahoover | ralsina: more than one | 15:56 |
| joshuahoover | ralsina: at least 2 that i'm looking at right now | 15:56 |
| ralsina | joshuahoover: ok, control panel, certificates, search for the valicert one, "enable for all purposes" | 15:56 |
| ralsina | joshuahoover: specific steps may vary according to windows version | 15:56 |
| mandel | briancurtin, ok, looking | 15:56 |
| joshuahoover | ralsina: k, thanks! | 15:57 |
| mandel | briancurtin, and that one is completely new to me.. :( | 15:57 |
| mandel | all, EOD here, alecu I'll propose the fix for windows tom, I'm getting dirty reactor exceptions on windows and will need to refactor the code to use the u1-devtools code correctly | 16:50 |
| alecu | mandel, great. | 16:52 |
| mandel | alecu, I should be able to propose the cp branch too and we will have all ipc on domain sockets too, but we geed to get the security right as you mentioned last time, I suppose setting the rights of the socket correctly should be more than enough | 16:53 |
| alecu | mandel, should be enough, but not more :-) | 16:53 |
| mandel | alecu, linguistic freedom in my part :) | 16:54 |
| ralsina | I think I will have a lunch | 17:01 |
| dobey | only one of them! :) | 17:01 |
| dobey | so, i wonder how to make this code actually fail for me | 17:02 |
| ralsina | dobey: yes :-) | 17:02 |
| dobey | so i have a branch which i think fixes this installer issue | 17:35 |
| * mmcc going to find a lunch to have | 17:36 | |
| dobey | bah, where is this stupid error coming from, or not as the case may be :( | 17:46 |
| ralsina | dobey: want me to test it? | 17:55 |
| joshuahoover | briancurtin: any update on the windows installer to test? :) | 17:55 |
| briancurtin | joshuahoover: good timing. i'm wrapping up a quick smoke test with it right now before i upload it, will have a link shortly | 17:56 |
| joshuahoover | briancurtin: smoke test? sounds unnecessary ;) | 17:57 |
| briancurtin | joshuahoover: just need to make sure i pulled in the right accessory branches, since i screwed that up last time | 17:57 |
| briancurtin | ...and its good (holds hands up like a touchdown) | 17:58 |
| dobey | ralsina: if you could; lp:~dobey/ubuntuone-installer/fix-aptdaemon | 17:58 |
| ralsina | dobey: on it | 17:59 |
| ralsina | dobey: will make sure I am in such a situation that current package fails, first, then try that oe | 17:59 |
| ralsina | one* | 17:59 |
| dobey | ok | 17:59 |
| briancurtin | joshuahoover: http://ubuntuone.com/7cnc3EWLWTSblGPPPOV7DK | 18:01 |
| briancurtin | sorry for the delay, i got stuck on the phone way too long earlier | 18:01 |
| joshuahoover | briancurtin: cool, thanks | 18:02 |
| joshuahoover | rmcbride, elopio: ^^ | 18:02 |
| elopio | great. | 18:03 |
| rmcbride | (cool | 18:03 |
| ralsina | damn you apt-get for being slower than everything else in my computer | 18:05 |
| ralsina | dobey: branch looks good, but released -installer has decided to work correctly so could not test IRL that it fixes the bug | 18:16 |
| dobey | :( | 18:19 |
| ralsina | dobey: considering the volume of failure, if it fixes it, we will know | 18:20 |
| ralsina | I know I soud like House MD there, though | 18:21 |
| dobey | ralsina: but we need to be able to tell the SRU team how to test it | 18:21 |
| ralsina | dobey: we can still use the "network disabled" test, right? | 18:22 |
| dobey | hmm, let me try on my laptop without network | 18:23 |
| ralsina | dobey: did you commit a partial fix a while ago? I may hve been using nightlies | 18:25 |
| dobey | ralsina: no; i made a fix for a related and similar problem, but apparently not the same one | 18:26 |
| ralsina | dobey: I may have been triggering that one then :-( | 18:26 |
| * briancurtin back in a few minutes, need to pick up a sandwich | 18:27 | |
| dobey | ralsina: i doubt it; that was a long time ago. no way you were triggering it last week :) | 18:29 |
| dobey | oh fun | 18:30 |
| joshuahoover | dobey: 12.04 user with gnome 3 installed is getting this error when trying to open u1-installer...any ideas/pointers? http://paste.ubuntu.com/999508/ | 18:30 |
| dobey | it installed the cached version | 18:30 |
| dobey | joshuahoover: it would appear they have a broken qt or pyqt install | 18:31 |
| dobey | joshuahoover: also, that error is from the control panel :) | 18:32 |
| joshuahoover | dobey: yeah, heh...just going by what the user told me | 18:33 |
| dobey | hrmm, stupid error messages and label widget. | 18:34 |
| ralsina | joshuahoover: broken system, do apt-get dist-upgrade | 18:35 |
| dobey | so it does seem to fix the no network case at least | 18:43 |
| dobey | would like to fix the "clicked cancel in the auth dialog" bug too, but i can't figure out where exactly there error is popping up through | 18:44 |
| ralsina | dobey: closing the installer window half-way through leaves things in a broken state, maybe that's the same thing? | 18:45 |
| dobey | no, that's different | 18:45 |
| ralsina | dobey: ok | 18:46 |
| * briancurtin back | 18:50 | |
| dobey | ralsina: https://code.launchpad.net/~dobey/ubuntuone-installer/fix-aptdaemon/+merge/106693 | 19:05 |
| ralsina | dobey: got it | 19:05 |
| ralsina | dobey: +1 | 19:11 |
| dobey | anyone else want to review that? :) | 19:13 |
| alecu | kinder for me! | 19:19 |
| mmcc | dobey, I took a look at your mp but I've never written any gtk so don't have much context for judgement. looks reasonable - I'm curious about the bare integers for apparently identifying pages in the notebook, eg set_current_page(2). Is there a reason not to use a variable with a readable name there? | 19:24 |
| dobey | less typing than defining constants for all the pages | 19:26 |
| mmcc | okay - well I guess you still need a more knowledgeable reviewer, unless you want to coach me through testing it out :) | 19:30 |
| dobey | i can't even fully test it myself :) | 19:35 |
| dobey | i can only test the case where failure happens due to network being disconnected | 19:35 |
| dobey | but whatever else is causing problems for users, i can't seem to find a way to cause it | 19:36 |
| dobey | and users aren't particularly helpful here. "it just didn't work." | 19:36 |
| mmcc | dobey: ah ok so this is just to get better debugging info | 19:42 |
| dobey | well, it fixes the problem of not doing any error handling at all | 19:43 |
| dobey | which should generally fix the problem for everyone that's having this specific problem | 19:43 |
| dobey | since they'll be able to see the error, fix it, and try again | 19:44 |
| dobey | there are a couple more error cases which i can reproduce, but which I haven't figured out yet either; but they are separate bugs and happen much less often | 19:44 |
| mmcc | dobey, your commit message mentions trying again - how does that work? it looks like if you hit 'cancel', __got_response calls main_quit() - am I getting that right? | 19:57 |
| dobey | mmcc: if you hit close it quits, yes. if you hit install, it tries to install again | 20:03 |
| dobey | mmcc: the error page shows [Install] [Close] as the dialog buttons | 20:03 |
| mmcc | dobey, ok. would it be a lot of work to switch that to [Try Again] [Close] or something? Admittedly it's a nitpick | 20:06 |
| dobey | yes | 20:07 |
| dobey | well, it's a string change | 20:08 |
| mmcc | = translation? | 20:08 |
| dobey | and the whole point of having it just be install there is to avoid the string change | 20:08 |
| dobey | = pain to sru, yeah | 20:08 |
| dobey | and i don't think having it be something else really helps clarify what it does | 20:09 |
| dobey | changing it is only to satisfy pedantry really. it's still going to do the exact same thing that clicking on the install button did in the first place. which is install the stuff, or show the error page again | 20:10 |
| mmcc | fair enough. I don't feel too strongly about it. any complaints with me approving this then? I understand it now. | 20:11 |
| dobey | no complaints from me, no :) | 20:12 |
| mmcc | ok done, thanks for holding my hand there. figured I ought to try to get used to more parts of the code (eg. gtk) | 20:13 |
| ralsina | mmcc: good attitude! | 20:14 |
| * mmcc pats self on back | 20:15 | |
| ralsina | mmcc: BTW, have you claimed a review day in the calendar yet? | 20:15 |
| * mmcc tweaks shoulder | 20:15 | |
| mmcc | ralsina, yes - Tuesday! despite appearances to the contrary, it is not today | 20:15 |
| ralsina | mmcc: hehe | 20:15 |
| ralsina | I think we need to tell mandel to get two half-days instead of a day, because he never has reviews on monday morning | 20:16 |
| ralsina | oh, wait he had 3 or 4 today. Ok then | 20:16 |
| joshuahoover | ralsina: remind me again, this 3.0.1 release will have the fix for "Please don't run the syncdaemon as root", correct? | 20:27 |
| dobey | yes | 20:27 |
| ralsina | joshuahoover: yes | 20:27 |
| joshuahoover | heh, thanks dobey and ralsina :) | 20:27 |
| ralsina | joshuahoover: I expect we will cause you a lot less pain starting with this release :-) | 20:27 |
| joshuahoover | ralsina: i'm hoping! | 20:28 |
| ralsina | I am going to take a slightly early EOD because I feel like crap. briancurtin, the RT is in your hands as discussed, I am now about to have like a dozen ibuprofens or something :-/ | 20:40 |
| briancurtin | ralsina: i was going to wait until i got the go-ahead from rick, leo, or joshua to know they've run their test suite or whatever | 20:41 |
| joshuahoover | "a dozen ibuprofens" ...sounds like the dosage you'd give to a grizzly bear | 20:41 |
| ralsina | joshuahoover: well, I am half grizzly | 20:41 |
| ralsina | father's side | 20:41 |
| ralsina | so just 6 | 20:41 |
| joshuahoover | elopio, rmcbride: any updates on testing the latest 3.0.1 release? | 20:41 |
| joshuahoover | heh | 20:41 |
| ralsina | briancurtin: when you get word, go ahead, and i'll cross ingers | 20:41 |
| ralsina | fingers | 20:41 |
| rmcbride | joshuahoover looking good so far. things are working, changes are syncing | 20:41 |
| joshuahoover | good | 20:42 |
| mmcc | hey, feel better soon ralsina. | 20:43 |
| ralsina | mmcc: will try! | 20:43 |
| ralsina | bye! | 20:43 |
| elopio | joshuahoover: I've just started my testing. No problems so far. | 20:44 |
| joshuahoover | rmcbride, elopio: once you guys are done running through the test cases, please let briancurtin know the results, thanks! | 20:45 |
| rmcbride | will certainly do so | 20:47 |
| joshuahoover | dobey: i heard from a (turkish) user experiencing the valicert problem on ubuntu and the workaround in bug #997326 didn't work, it said the file already existed | 21:24 |
| ubot5 | Launchpad bug 997326 in Ubuntu One Client "Users in Turkey can't connect due to invalid Valicert certificate" [High,Triaged] https://launchpad.net/bugs/997326 | 21:24 |
| dobey | joshuahoover: oh fun | 21:24 |
| joshuahoover | dobey: yeah...sigh | 21:25 |
| * dobey recalls a TMBG song | 21:25 | |
| dobey | joshuahoover: on the other hand. if the file exists for that user, i wonder if it's a broken symlink or something | 21:26 |
| joshuahoover | dobey: hmmm...could be, i suppose i could ask him to delete the current link and try creating it again? | 21:27 |
| dobey | joshuahoover: well, that's assuming the file it's linking to isn't a broken symlink as well | 21:28 |
| joshuahoover | true | 21:28 |
| dobey | on my system it's a symlink that points to a symlink that points to a cert file | 21:30 |
| elopio | rmcbride, joshuahoover, briancurtin, smoke works here. | 21:30 |
| joshuahoover | elopio: thanks! | 21:31 |
| rmcbride | elopio: joshuahoover: briancurtin: yea I'd say smoke and a bit more work fine. I have been messing around with various aspects for a while now | 21:31 |
| briancurtin | thanks for taking a look. now that we have at least 3 people successfully using it i'll go ahead and start getting the binaries signed. let me know if anything does pop up so i can halt the process | 21:34 |
| joshuahoover | elopio, rmcbride: did we capture these latest test results in moztrap? | 21:41 |
| rmcbride | joshuahoover: you know, I did not. I'm working from the windows box doing this, and I hadn't set up the whole browserID thing in it yet | 21:41 |
| rmcbride | (I also forgot Moztrap was working again) | 21:42 |
| rmcbride | I'll get that set up in this location so that it can be recorded properly after I get dinner started | 21:43 |
| elopio | joshuahoover: not all the tests are in moztrap yet. | 21:43 |
| elopio | but I made the runs and recorded some results. | 21:43 |
| joshuahoover | elopio: ah, ok...maybe we can make that part of testing windows next time? either you and/or rmcbride could probably knock out the remaining tests pretty quick next time around | 21:44 |
| briancurtin | binaries are off to be signed | 21:45 |
| joshuahoover | thanks brian! | 21:45 |
| dobey | alright kids. have a good evening! | 21:46 |
| elopio | joshuahoover: sure. I'm copying tests every day. I hope that by the end of the next week all the things from the wiki are updated and on moztrap. | 21:48 |
| joshuahoover | elopio: cool...i would've helped last week but you know, moztrap wasn't available ;) | 21:49 |
| elopio | I know. but don't worry, I'll leave the mac test cases to you so you are not left without the joy of documentatio ;). | 21:52 |
| mmcc | I'm heading out for the night. Today's rathole brought to you by: homebrew, py2app, SIP and PyQt. | 23:07 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!