/srv/irclogs.ubuntu.com/2012/05/25/#launchpad-dev.txt

StevenKwgrant: I'm not sure -- if I print the information_type in the second line of the test it's USERDATA. So it should be that for everything after, right ...00:03
wgrantStevenK: Not if the factory caused the caching to occur00:03
mwhudsonwgrant: i think you told me a while ago that ajax changing a bugtask's target for a single-bugtask bug should cause a page refresh00:07
mwhudsonthis appears to not be the case currently00:08
wgrantHmm00:08
wgrantIt was, but perhaps it broke.00:08
=== wallyworld_ changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: wallyworld | Firefighting: - | Critical bugs: 3.47*10^2
* mwhudson grrs at trying to search for a bug containing the string "403"00:09
mwhudsonwgrant: i should file a bug then?00:11
wgrantmwhudson: Probably.00:14
mwhudson    /* ChoiceSource doesn't seem to function in IE at present, breaking00:16
mwhudson     * all of this AJAX except the assignee and product pickers.00:16
mwhudson     */00:16
mwhudsonbet that comment makes sinzui happy00:16
wgrantNah00:18
wgrantI added that just a couple of months back00:18
wgrantBecause we were about to fix ChoiceSource, and it was entirely broken00:18
mwhudsonwgrant: it looks like there is code to do a refresh around bug task _deletion_00:18
wgrantSo it would have been a major regression to enable it there00:18
mwhudsonnothing around reassignment00:18
wgrantsinzui: Can that be removed now?00:19
wgrantmwhudson: There's meant to be a hook on the context URL change00:19
mwhudsonah00:19
mwhudsoni'm only looking in bugtask_index.js00:20
mwhudsonwould it be somewhere else?00:20
wgrantIt came for free when that was implemented in recipes.00:20
mwhudsonah00:20
mwhudson            Y.on('lp:context:web_link:changed', function(e) {00:22
mwhudson                  window.location = e.new_value;00:22
mwhudson            });00:22
wgrantThat's the one.00:24
wgrantPerhaps it's not updating the cache somehow.00:24
=== matsubara-afk is now known as matsubara
mwhudsonlet's see if it works for recipes00:24
wgrantIndeed.00:24
mwhudsonmy survey says no00:25
mwhudsonyeah00:27
mwhudsonediting the name isn't updating00:27
mwhudsonLP.cache.context.web_link00:27
wgrantFile a bug, I'll criticalify it00:27
mwhudsoni think it probably is00:46
mwhudsonbecause e.g. the name is not being updated in the cache either00:46
wgrant:(00:46
mwhudsonwgrant: do you know where the "update the cache on lp_save" stuff is wired up?00:47
mwhudsonthis function called update_cached_object looks promising00:48
mwhudsonuhhh00:49
mwhudson      if (cached_object.self_link === full_uri) {00:49
wgrantIt matches the cache entry based on URI?00:49
wgrantThat's going to work well :)00:49
mwhudsonyeah00:49
mwhudsonfrom the "did this ever work!?" department...00:50
wgrantIt looks like it might have been broken for a year00:53
wgrantBut surely not00:53
mwhudsondo you have a suspect change?00:55
mwhudson  [r=jcsackett][bug=490826, 721064,00:55
mwhudson        724004] Keep LP.cache up to date with launchpadlib PATCH changes,00:55
mwhudson        and raise update events.00:55
mwhudsonis what i found that touched that area00:55
mwhudsonbut surely that's the basic functionaliy00:55
wgrant14634 is interesting00:57
mwhudsonah yes00:57
mwhudsonit broke the notification because entry.lp_original_uri is now more correct?00:58
wgrantI assume so00:58
wgrantIt's not longer updating the cache00:59
wgrantBecause it uses the post-redirect URI00:59
wgrantI suspect00:59
mwhudsonrings true01:00
mwhudsonnot sure how to fix it though...01:02
StevenKwgrant: It seems visibleByUser is called before the print from the test --how is that possible?01:03
wgrantStevenK: Security proxy in the test, more than likely01:05
StevenKAnd then that's cached? I'm somewhat confused by this mess.01:06
wgrantStevenK: You access a proxied attribute in the factory01:07
wgrantIt calls the security adapter01:07
wgrantWhich calls visibleByUser01:07
wgrantThe security cache caches the adapter's response01:07
StevenKBleh, is this failure caused by transitionToInformationType?01:10
StevenKHm, seems not.01:11
wgrantStevenK: branch.owner01:14
wgrant+            removeSecurityProxy(branch).transitionToInformationType(01:14
wgrant+                information_type, branch.owner, verify_policy=False)01:14
wgrantThat branch.owner call will use the security proxy01:14
StevenKwgrant: I've replaced it with registrant (which I should have done anyway), and it still fails01:14
wgrantStevenK: Huh?01:14
wgrantThat doesn't change anything01:14
wgrantIt's still using the object's proxy01:15
wgrantrSP01:15
StevenKwgrant: registrant is a Person01:15
StevenKNot a Branch01:15
StevenK-                information_type, branch.owner, verify_policy=False)01:15
StevenK+                information_type, registrant, verify_policy=False)01:15
wgrantOh, not branch.registrant01:15
wgrantPossibly branchChanged is doing it01:16
StevenKThis case has no stacking01:16
StevenKSo no branchChanged01:16
wgrantStevenK: Break in visibleByUser01:20
wgrantSo you can see the call stack01:20
wgrantStevenK: s/branch.owner/registrant/ fixes it for me01:23
StevenKIndeed01:23
StevenKPerhaps I hadn't saved01:23
StevenKwgrant: Looks like most of the failures were caused by branch.owner01:33
sinzuiwgrant, mwhudson. We want to remove the refresh rule. The We have not worked out how to refresh the state of other things on the page. There is currently a bug where if you retarget a task, the state of the page is broken in subsequent ajax calls01:36
mwhudsonsinzui: yes01:36
mwhudsonsinzui: however it should be removed by removing it, not having it accidentally break01:36
sinzuiI agree01:36
StevenKsinzui: But I remember fixing that with Tim at the first squad sprint01:37
StevenKPerhaps it was only branches01:37
sinzuiStevenK, I remember it fixed as well.01:38
sinzuiwgrant, StevenK, mwhudson, once we are certain the JS always works, we can remove the inline task edit form. Non-js can go to task/+edit01:38
StevenKThat sounds good01:39
* sinzui thinks StevenK would like to kill that code and tests01:39
StevenKsinzui: Are we certain the JS always works?01:40
mwhudsonhttps://bugs.launchpad.net/launchpad/+bug/1004248/comments/2 fwiw01:40
_mup_Bug #1004248: hook to force page refresh on context url changing is not working <javascript> <regression> <ui> <Launchpad itself:Triaged> < https://launchpad.net/bugs/1004248 >01:40
wgrantsinzui: There's still no other way to retarget -- the AJAX only works between projects.01:41
sinzuiI am not surprised. That bug is probably the root cause of...01:41
sinzuibug 91936901:42
_mup_Bug #919369: acting on a bug task which has been retargeted oopses <404> <bugs> <javascript> <oops> <Launchpad itself:Triaged> < https://launchpad.net/bugs/919369 >01:42
mwhudsonwell01:42
mwhudsoni couldn't tell if _that_ bug was complaining about what happens when someone else has retargeted the bug01:42
mwhudsontask01:42
sinzuiExcellent. I think the bug is a dupe, but this time we got better data01:43
wgrantNot quite01:43
wgrantThe refresh will only happen if you change the current context task01:43
wgrantRetargetting a non-current task will still hit bug #91936901:43
_mup_Bug #919369: acting on a bug task which has been retargeted oopses <404> <bugs> <javascript> <oops> <Launchpad itself:Triaged> < https://launchpad.net/bugs/919369 >01:43
lifelesssinzui: shouldn't you be asleep :P01:44
sinzuino. I should be talking to stevenk or wallyworld_01:45
StevenKsinzui: Oh? Pick your victim01:45
StevenKwgrant: http://pastebin.ubuntu.com/1005775/01:46
sinzuiStevenK,  so I made mwhudson's bug the master since it is the root cause. When  we fix that bug,  we really can remove bug task inline edit forms01:46
StevenKSadly, the root cause isn't really disclosure.01:47
wgrantStevenK: Looks reasonable.01:47
StevenKLet me finally land this thing then01:48
StevenKlifeless: If I testr load from a subunit stream, shouldn't testr failing --list show me the broken tests?01:50
sinzuiStevenK, shall we mumble01:51
lifelessStevenK: absolutely01:54
StevenKsteven@undermined:~/launchpad/lp-branches/branch-use-information_type-redux% zgrep -c '^Traceback' ~/Desktop/branch-use-information_type-redux-r15297.subunit.gz01:57
StevenK1401:57
StevenKlifeless: ^01:57
StevenKsteven@undermined:~/launchpad/lp-branches/branch-use-information_type-redux% testr failing --list | wc -l01:57
StevenK001:57
lifelessStevenK: they may have not failed02:02
lifelessStevenK: passing tests can have attachments too02:02
lifelessStevenK: oopses have Traceback in them, and don't trigger an implicit failure (perhaps they should)02:03
lifelessStevenK: forward me the .gz ?02:03
StevenKlifeless: Is in my homedir on carob.02:03
lifelesswhats your username on carob02:05
StevenK~stevenk02:05
sinzuiwgrant, do you have time to mumble?02:38
wgrantsinzui: Sure02:40
bigjoolsbloody hell, did someone flick the turbo switch on bug searches?03:03
wgrantYes03:04
wgrantI rewrote them from scratch a few weeks ago03:04
StevenKbigjools: \d BugTaskFlat03:05
wgrantThat reminds me03:05
wgrantI need to coerce stub into GINing03:05
bigjoolsnice work03:06
lifelessit is pretty cool stuff03:08
wgrantNot fantastic yet.03:08
wgrantGIN should help in-context searches03:08
wgrantBut contextless (eg. person) searches still suck03:08
wgrantJust a bit less than they did before.03:08
sinzuiwallyworld, are you available to mumble?04:14
wallyworldsinzui: sure, let me get my microphone04:14
wgrantStevenK: Do you have plans to test searches with information_type instead of transitively_private early next week?04:32
StevenKwgrant: Branch searches?04:33
wgrantThat one04:33
StevenKI hadn't considered that, TBH04:33
wgrantIt needs to be done pretty soon04:34
StevenKwgrant: I can look at doing it after the UI work04:36
StevenKwgrant: Or I can drop the UI work and look at it now if you think it's urgent enough04:36
wgrantHopefully the UI won't take more than a couple of days.04:37
wgrantThe backend stuff isn't critical to look at early, as performance is already terrible, but we should get it out of the way soon.04:38
StevenKwgrant: Can you add a card to Next then?04:40
wgrantdone04:42
wallyworldStevenK: wgrant: i already have a card for branch searches using info type, and a 1/2 done branch05:01
StevenKHah05:01
wallyworldi was waiting on steve's info type work to land before being able to finish it05:01
wgrantOh, so you do.05:01
wgrantThat's cheating.05:01
wallyworldwe discussed this last week :-)05:02
wallyworldor was it this week05:02
wgrantHm05:02
wgrantIt was probably on last Friday's call, which I slept through.05:02
wgrantThat would explain it.05:02
wallyworldmayben :-)05:02
wgrantGiven the timing of the bug05:02
StevenKWhat? Lies. You don't sleep.05:02
* wallyworld off to do the school run. traffic will be awesome in the rain, not :-(05:03
wgrantOh, it's horrid up there too?05:03
wgrantIt's been about 8pm all day here05:03
wallyworldyep05:04
wgrantOnly minor flooding.05:04
StevenKIt's bright and sunny here today05:05
wgrantAh05:05
wgrantThe cloud pattern is interesting05:05
wgranthttp://www.bom.gov.au/australia/satellite/05:05
StevenKHaha05:05
wgrantIt like just avoids the southern half of NSW's coast.05:05
bigjoolspissing it down here05:06
wgrantIt's actually almost stopped here05:06
wgrantBut been raining and dark all day until now05:06
StevenKwgrant: http://www.bom.gov.au/products/IDR023.loop.shtml is impressive05:06
wgrantMyeees.05:07
wgrantBetter than it was.05:07
wgrantAnd clearing.05:07
bigjoolsactually only 2.2mm of rain here, although it feels like more05:07
StevenKI think we got ~ 8mm yesterday05:08
wgrant27.2mm here!05:08
StevenKSince 9am?05:08
wgrantYeah05:08
StevenKBloody heck, that would cause a little bit of flooding05:08
wgrantIt's the most we've had in a while.05:09
czajkowskimorning05:58
jtvHi there czajkowski06:29
adeuringgood morning07:30
=== wallyworld changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: - | Firefighting: - | Critical bugs: 3.47*10^2
=== adeuring changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: adeuring | Firefighting: - | Critical bugs: 3.47*10^2
=== allenap` is now known as allenap
=== popey_ is now known as popey
lifelesswgrant: btw, have you seen slow SSO evidence recently?09:57
wgrantlifeless: Not really, no10:02
wgrantlifeless: Bit sad10:02
lifelesswgrant: so it might be fixed?10:08
wgrantlifeless: Ah, I think there are still some timeouts10:10
wgrantAlthough it may be the pgbouncer thing10:10
lifelessstuartm is following up10:14
lifelessI'd like to let him know if we sitll think its happening10:14
=== bac changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: adeuring, bac | Firefighting: - | Critical bugs: 3.47*10^2
bachi adeuring11:56
adeuringhi bac11:56
bacadeuring, nothing in the queue.  yay.11:58
* cjwatson shall try to rectify that :-)11:59
cjwatsonI'm nuking some doctests from orbit11:59
baccjwatson, and i'll gladly review that!12:00
jammgz12:07
mgzhey12:08
=== matsubara-afk is now known as matsubara
rick_h_rvba: did you guys have any sass/less discussion on maas? In the wiki it links to a sass test but thought I recall some less emails in -dev before12:47
rvbaHey rick_h_.  Not really, I talked with Huw about using it a while ago but tbh we didn't push the idea further.12:49
rick_h_rvba: ok, I noticed you guys didn't use either so curious if there was a talk in there/not.12:49
rvbarick_h_: I guess the only reason not to use it right now is lack of time to set it up and refactor the existing css.  But IIRC Huw was very much in favor of using it.12:51
rick_h_ok, cool. I'll bring it up and see about getting it in place from our start. Thanks12:51
=== elmo_ is now known as elmo
cjwatsonbac: https://code.launchpad.net/~cjwatson/launchpad/refactor-customupload-tests/+merge/10738113:49
baccjwatson, looking14:01
=== mbarnett` is now known as mbarnett
=== nhandler_ is now known as nhandler
=== salgado is now known as salgado-lunch
=== deryck is now known as deryck[lunch]
=== salgado-lunch is now known as salgado
=== deryck[lunch] is now known as deryck
=== Noldorin_ is now known as Noldorin
james_whow do I run a specific doctest file?18:56
rick_h_which one james_w ?18:57
james_wrick_h_, lib/lp/soyuz/stories/webservice/xx-archive.txt18:58
rick_h_james_w: think you can do ./bin/test -x -cvvt "xx-archive"18:58
james_wthanks rick_h_18:59
rick_h_np19:00
james_wit runs a few more, but it's better than running them all :-)19:00
rick_h_yea, you can adjust that, it's a regex to narrow it down19:00
rick_h_and stuff like ./bin/test -x -m lp.bugs.model.tests -cvvt "TestBugTaskCreationPackageComponent"19:00
rick_h_but that's not for doctests19:01
rick_h_I'm still working on my tricks for speeding up test runs19:01
cjwatsonjames_w: you can also pass the full relative path from the top of the branch to test -t, since in the doctest case the regex is matched against the full path19:03
james_wand if it's a regex I guess I can use "$" to prevent substring matches from running other doctests in the same dir?19:04
james_wor I guess the .txt in the path will do that19:04
james_wif I want to reject certain values for a property based on values for other values on the object, do I just raise exceptions in the setter?19:07
james_wor maybe I should just let the two things vary independently in this case19:07
james_wwe have "suppress_subscription_notifications" on a PPA, and subscription notifications are only generated if the PPA is private19:08
james_wso it doesn't make sense to have it set to true when the PPA isn't private19:08
james_wbut it's far more code to enforce that than to just let people set a value which has no effect19:08
james_wwhat do people think the approach should be?19:09
james_wand that's not even getting in to having a good UI for setting these things on the web, with dynamically enabled checkboxes and the like19:09

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!