| bac | benji, frankban, gmb: hangout at :10? | 12:07 |
|---|---|---|
| benji | bac: sounds good | 12:07 |
| frankban | bac: ok | 12:07 |
| * bac conjures up hangout | 12:08 | |
| bac | i've invited you all but i cannot find the URL | 12:10 |
| frankban | benji: could you please take a look at https://code.launchpad.net/~frankban/launchpad/bug-993510/+merge/107630 | 14:18 |
| frankban | ? | 14:18 |
| benji | frankban: sure | 14:18 |
| frankban | thanks benji | 14:23 |
| bac | hey benji could you look at https://code.launchpad.net/~bac/launchpad/repeats/+merge/107651 | 15:14 |
| benji | bac: sure | 15:14 |
| benji | bac: I had some questions/suggestions on https://code.launchpad.net/~bac/launchpad/repeats/+merge/107651 | 15:39 |
| bac | thanks benji | 15:41 |
| benji | np | 15:41 |
| frankban | benji: thanks for your review, I've just added a test for that, as you suggested. could you please re-review this change. I have to go now, but I will be back later to land this branch if approved. | 15:47 |
| benji | frankban: cool, will do | 15:47 |
| bac | thanks benji. look again? | 16:08 |
| benji | bac: sure | 16:08 |
| benji | bac: were the .testr.conf changes in there before? | 16:15 |
| bac | gah! | 16:16 |
| bac | i'll back them out | 16:16 |
| benji | cool | 16:16 |
| bac | benji: backed out. is the rest ok? | 16:18 |
| bac | frankban: please ping me when you move your card out of the lane. | 17:24 |
| benji | bac: sorry, I was eating lunch, but you probably saw the email | 17:24 |
| bac | yeah, thanks | 17:24 |
| bac | benji: darn, lifeless didn't like the test duplication fix. i was able to kill ec2 before it landed. | 19:24 |
| bac | benji: could you review the one line MP i have up now? | 19:24 |
| benji | bac: I was just reading his message. I can't say that I agree with his diagnosis. | 19:24 |
| benji | bac: sure | 19:24 |
| benji | bac: approved | 19:26 |
| bac | benji: well, i figure you either have to handle dupes or prevent dupes. if he feels strongly prevention is best for testr then i'm swayable. | 19:27 |
| benji | I don't really have a dog in the fight. If we hadn't already forked and monkeypatched the testrunner then it would be worse. Although I can't say that making a bad situation worse is a good thing to do. | 19:29 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!