[12:07] benji, frankban, gmb: hangout at :10? [12:07] bac: sounds good [12:07] bac: ok [12:08] * bac conjures up hangout [12:10] i've invited you all but i cannot find the URL [14:18] benji: could you please take a look at https://code.launchpad.net/~frankban/launchpad/bug-993510/+merge/107630 [14:18] ? [14:18] frankban: sure [14:23] thanks benji [15:14] hey benji could you look at https://code.launchpad.net/~bac/launchpad/repeats/+merge/107651 [15:14] bac: sure [15:39] bac: I had some questions/suggestions on https://code.launchpad.net/~bac/launchpad/repeats/+merge/107651 [15:41] thanks benji [15:41] np [15:47] benji: thanks for your review, I've just added a test for that, as you suggested. could you please re-review this change. I have to go now, but I will be back later to land this branch if approved. [15:47] frankban: cool, will do [16:08] thanks benji. look again? [16:08] bac: sure [16:15] bac: were the .testr.conf changes in there before? [16:16] gah! [16:16] i'll back them out [16:16] cool [16:18] benji: backed out. is the rest ok? [17:24] frankban: please ping me when you move your card out of the lane. [17:24] bac: sorry, I was eating lunch, but you probably saw the email [17:24] yeah, thanks [19:24] benji: darn, lifeless didn't like the test duplication fix. i was able to kill ec2 before it landed. [19:24] benji: could you review the one line MP i have up now? [19:24] bac: I was just reading his message. I can't say that I agree with his diagnosis. [19:24] bac: sure [19:26] bac: approved [19:27] benji: well, i figure you either have to handle dupes or prevent dupes. if he feels strongly prevention is best for testr then i'm swayable. [19:29] I don't really have a dog in the fight. If we hadn't already forked and monkeypatched the testrunner then it would be worse. Although I can't say that making a bad situation worse is a good thing to do.