| === zumbi_ is now known as Guest88650 | ||
| JamesTait | Good morning, all! :) | 08:57 |
|---|---|---|
| Moscherkobold | good morning | 09:01 |
| czajkowski | aloha | 09:02 |
| Moscherkobold | hi rye, do you have something new for me? :) | 09:03 |
| rye | Moscherkobold: just arrived, let me look at the bug report | 09:04 |
| rye | sooo... fix committed | 09:05 |
| Moscherkobold | this means it should work now? | 09:07 |
| rye | Moscherkobold: no, the code was not deployed yet and I don't see any merge tickets to merge accounts | 09:15 |
| rye | i'll create one and will follow up today (i was off on monday) | 09:15 |
| Moscherkobold | ok, maybe it would be also helpful for me to delete the second account, because it is empty anyway. | 09:18 |
| Moscherkobold | but it is always chosen if i log in on a win pc or on the website | 09:18 |
| czajkowski | aquarius: random question, if you have a file shared out and published on U1 and you make changes on the desktop does it automatically get updated and still shared out on the same link? | 09:19 |
| aquarius | czajkowski, it depends how you edit it :( | 09:20 |
| czajkowski | aquarius: well I reoponed my presentation and made changes on the deskop and saved | 09:21 |
| czajkowski | what other way would you edit it ? | 09:21 |
| rye | Moscherkobold: https://bugs.launchpad.net/ubuntuone-servers/+bug/1005819 - if you have a launchpad account you can subscribe to this bug to be notified when we switch it to fix released | 09:21 |
| ubot5 | Error: ubuntu bug 1005819 not found | 09:21 |
| aquarius | czajkowski, if the program you edit it with just edits the file, then yes. However, quite a few programs don't *actually* do that (and it's very hard to tell what a program does) -- instead, they save your changes to a temp file and then rename the temp file over the top of the existing file. If this happens, it breaks the public URL because it's actually a different file :( | 09:22 |
| aquarius | czajkowski, and... openoffice is one of the programs that does this rename trick :( | 09:22 |
| aquarius | I would dearly love to see this fixed. | 09:22 |
| aquarius | but fixing it is pretty hard | 09:22 |
| czajkowski | aquarius: ahh so that's what happened, had to reshare the presentation as the link died | 09:22 |
| aquarius | czajkowski, yeah. It's really pathologically annoying. :( | 09:22 |
| czajkowski | aquarius: it was really handy to do the talk at the weekend, then the file was already on the web and click share. | 09:22 |
| rye | aquarius: originally we had a path-based publishing... I recall. then somebody complained and we switched. Was it like this? | 09:22 |
| czajkowski | but that kinda bite me last night as needed to make a few changes and add links to stuff I mentioned :/ | 09:23 |
| aquarius | czajkowski, yes. I don't have a very good solution here :( | 09:23 |
| aquarius | rye, path-based publishing fixes this problem, at the cost of others | 09:23 |
| czajkowski | aquarius: no worries if there is a bug about it then I'll go back to sipping my drink and being quiet | 09:23 |
| === JamesTai1 is now known as JamesTait | ||
| Moscherkobold | rye: sry i have no launchpad acc, it would be great if you can keep me up to date? | 09:37 |
| rye | Moscherkobold: could you please PM me your e-mail again so that I add it to my notes? | 09:38 |
| rye | czajkowski: what I do in this case (i use U1 for all the media on my rtg.in.ua web site) is that i put the files somewhere, edit them and after that copy over to original locations thus overwriting the content byt not changing the inodes | 09:38 |
| rye | well, i use a proxy too so that should I break the link i can set up a correct mapping | 09:39 |
| rye | but this is an overkill | 09:39 |
| czajkowski | yeah I just wanted to add a little content | 09:40 |
| czajkowski | no biggie | 09:40 |
| lalejand | Hi everyone | 10:03 |
| lalejand | I just published a zip file from the ubuntuone folder in nautilus | 10:03 |
| lalejand | I can see it is published and see the link on the web U1 interface | 10:04 |
| lalejand | but a right click on the zip file in nautilus still gives me only the "publish" option | 10:04 |
| lalejand | is it a know bug or do I have a problem with my nautilus ? | 10:04 |
| lalejand | "known" | 10:05 |
| rye | lalejand: known bug in nautilus plugin which does not load the list of published files properly | 10:06 |
| lalejand | okay thx. Just have to wait for it to be fixed then :) | 10:06 |
| === JanC_ is now known as JanC | ||
| gatox | good morning! | 11:04 |
| mandel | gatox, morning! | 11:07 |
| mandel | gatox, did you try to run the cp on mac os x? | 11:07 |
| gatox | mandel, hi | 11:15 |
| gatox | mandel, no.... i was stuck with a bug in win | 11:15 |
| gatox | mandel, do you want me to try now? | 11:17 |
| * gatox is still trying to reproduce the bug on windows | 11:17 | |
| mandel | gatox, no worries :) | 11:23 |
| mandel | gatox, just curious | 11:23 |
| alecu | mandel, gatox: holas! | 11:56 |
| gatox | alecu, buenas | 11:57 |
| mandel | alecu, hola! | 12:05 |
| === facundobatista_ is now known as facundobatista | ||
| mandel | gatox, I have a new branch for the fsevents project: https://code.launchpad.net/~mandel/ubuntuone-fsevents-daemon/add-dispatcher-tests/+merge/107766 | 12:28 |
| mandel | gatox, take a look at the description since it tells you how to add OCMock to the $(DEVELOPER_LIBRARY_DIR), specially because the dependency is only related with the tests | 12:28 |
| mandel | gatox, I tried to write a patch method but although I managed to get it running it was terrible code to mantain, so I went with mocks, so sorry in advanc | 12:29 |
| mandel | s/advanc/advance | 12:29 |
| rye | no brians here | 12:38 |
| rye | too | 12:38 |
| mandel | rye, he starts later :) | 12:41 |
| mandel | rye, is briancurtin | 12:42 |
| mandel | ok, lunch time for me | 12:42 |
| * mandel lunch | 12:43 | |
| gatox | mandel, ack | 12:44 |
| ralsina | good morning! | 12:44 |
| gatox | ralsina, hi | 12:44 |
| mandel | ralsina, once I'm back from lunch, can we take a look on how to setup the mac mini so you can run at least the tests for the objective-c code? | 12:44 |
| gatox | mandel, did you mark it as private for anything in particular? | 12:44 |
| ralsina | mandel: sure! | 12:44 |
| mandel | gatox, the entire thing is private | 12:44 |
| ralsina | mandel: I do have a ton of calls today though | 12:44 |
| gatox | ahhhh ok | 12:44 |
| mandel | ralsina, once I'm back I'll let you know and then you can ping me whenever you are free :) | 12:45 |
| mandel | ok, leaving to have tortilla de patatas :) | 12:45 |
| alecu | mandel, oh, no. No mocks, please! | 12:47 |
| dobey | hmm | 12:56 |
| gatox | alecu, the suggested path is what we want! \o/ | 13:00 |
| alecu | gatox, vaaaamos! | 13:00 |
| gatox | alecu, so....... fixing! | 13:01 |
| gatox | alecu, thx for the mumble-time! :P jeje | 13:01 |
| === teknico_ is now known as teknico | ||
| === m_conley_away is now known as m_conley | ||
| gatox | ralsina, alecu when we want to use an icon from the current os theme for u1-cp.... and the os doesn't have that icon.... which would be the proper solution? add the icon to the control panel data folder.... or ignore that icon? | 13:38 |
| * mandel back | 13:38 | |
| ralsina | gatox: add a fallback to data | 13:38 |
| gatox | ralsina, roger | 13:39 |
| ralsina | gatox: operative word "fallback" ;-) | 13:39 |
| mandel | ralsina, let me know when do you have time to set the env for the mac-mini | 13:44 |
| mandel | ralsina, can be tom if you have a very busy day :) | 13:44 |
| ralsina | mandel: tomorrow early sounds good | 13:45 |
| ralsina | mandel: I want to do all my late 1-1s today | 13:45 |
| mandel | ralsina, ok, which reminds me, we skipped lasts week | 13:46 |
| mandel | ralsina, wanna have it or we wait 'til friday? | 13:46 |
| ralsina | mandel: exactly | 13:46 |
| mandel | ralsina, that means, we have it? | 13:47 |
| ralsina | mandel: yes we will ahve it today | 13:48 |
| mandel | ralsina, ack | 13:49 |
| dobey | what is this 1-1 you speak of? | 13:55 |
| dobey | mandel: i don't quite understand your review of my ubuntuone-installer branch | 14:05 |
| mandel | dobey, my questions is, if we have a data file (the logo) why don't we copy it to the correct location in the setup.py, or is that logo coming from somewhere else? | 14:08 |
| dobey | mandel: it is getting picked up/installed automatically | 14:09 |
| mandel | dobey, the other, please add a test that asserts that we do pass the correct path, I know is a simple 'stupid' tests but it is nice to have | 14:09 |
| dobey | mandel: i don't understand what you expect to test exactly | 14:09 |
| mandel | dobey, but what if I get the project and do python setup.py install? the software will work with the logo? | 14:09 |
| dobey | mandel: yes | 14:09 |
| mandel | dobey, with the logo you mean, ok cool :) | 14:09 |
| ralsina | dobey: mythical creature | 14:10 |
| dobey | mandel: debian packages are created by doing setup.py install as well you know :) | 14:10 |
| mandel | dobey, yes, that is why I'm asking :) | 14:10 |
| dobey | and the test, a) isn't so simple, and b) makes no sense | 14:11 |
| mandel | dobey, is simple, self.patch(object, '__find_data_file', function) where function will assert that the passed file is 'u1logo.svg' (which I would store in a const rather than in the middle of the code) | 14:13 |
| dobey | mandel: and it still makes no sense | 14:13 |
| mandel | dobey, in makes sense in the way that if someone by mistake removes it or changes it by accident we will know | 14:13 |
| dobey | asssert that this one string we import in two places, from the same place, is the same | 14:13 |
| dobey | if it's not the same, your system is f'c | 14:13 |
| dobey | f'd | 14:13 |
| dobey | nobody other than me is going to ever touch this code :) | 14:14 |
| mandel | dobey, well, right now, is not imported from anywhere, is just in that call | 14:14 |
| dobey | mandel: until it's a const, and it's imported, and then even if someone does change it, the test will still pass | 14:14 |
| mandel | dobey, and.. while that is very very true (not being touch by any other person) what happens if you do? | 14:14 |
| dobey | the only way the test will fail is if we hard code it in two separate places | 14:15 |
| mandel | dobey, well, then place it as a const, and we might find a middle ground ;) | 14:15 |
| dobey | ubuntuone-instlaler is going to die a very fiery death | 14:15 |
| dobey | what's the point? | 14:15 |
| mandel | dobey, self.__find_data_file(U1_LOGO) is much better than self.__find_data_file('u1logo.svg') | 14:15 |
| dobey | making a constant for a single string is like having a url shortener give you back a longer url than the one you typed in. | 14:17 |
| mandel | dobey, the same point as all other constants | 14:18 |
| mandel | dobey, I don't care about the length of the string, I care than when I get told I have to change the logo I don't have to look for it in the code | 14:18 |
| dobey | mandel: i guarantee that you will never be told to change the logo | 14:19 |
| mandel | dobey, oh... it is not me who I'm worried about, is the aliens that will find this code as the left overs of our civilization! | 14:20 |
| mandel | dobey, also, is good practice and is simpler to understand.. pretty please.. | 14:21 |
| dobey | they will know by the lack of our civilization being around, what idiots we were, already. no need to look at such trifling code | 14:21 |
| dobey | besides, they probably wouldn't understand it anyway, for thousands of years after its discovery | 14:22 |
| dobey | also, it wouldn't test that it is the correct logo. | 14:23 |
| dobey | it would test that we are asking for the filename which we are asking to be loaded, was asked to be loaded | 14:23 |
| mandel | dobey, we are not longer talking about the tests, I know I've lost that battle | 14:24 |
| mandel | dobey, I just want you to create the var and used it, no more | 14:24 |
| dobey | why? | 14:24 |
| dobey | you hate my fingers? | 14:24 |
| mandel | dobey, a little ;) | 14:24 |
| mmcc | Good morning, everyone. Good morning, dobey's fingers. | 14:27 |
| mandel | dobey, is there a problem using an Apache licensed lib with our GPL code? | 14:28 |
| dobey | possibly | 14:29 |
| ralsina | morning mmcc | 14:29 |
| alecu | mandel, on a similar testing note... why on earth did you choose OCMock? | 14:29 |
| mandel | alecu, because there is no bloody simple way to patch methods on objective-c | 14:30 |
| dobey | my fingers have had enough torture from the ethernet cable yesterday | 14:30 |
| mandel | dobey, possibly? what does that mean? | 14:30 |
| dobey | mandel: it means licenses are hard | 14:30 |
| briancurtin | mandel: is there anything holding back https://code.launchpad.net/~ballogy/ubuntu-sso-client/drop-lazr/+merge/107153 from being merged? | 14:30 |
| alecu | mandel, we already had maintenance issues with "mocker-style" tests... | 14:30 |
| mandel | dobey, yes, that is why I asked you, I usually dont care | 14:30 |
| mandel | briancurtin, yes, lack of comment | 14:31 |
| dobey | mandel: i presume you're asking because you want to use an apache licensed library in fsevents-daemon which is GPL? | 14:31 |
| alecu | mandel, oh, right. briancurtin: It's missing the "commit message", so tarmac won't land it. | 14:31 |
| mandel | alecu, briancurtin, fixed :) | 14:31 |
| alecu | mandel, great. | 14:32 |
| mandel | dobey, yes, I want to use the google-toolbox-for-mac to reuse their logger rather than doing dirty tricks with NSLog | 14:32 |
| briancurtin | mandel: cool, thanks | 14:32 |
| mmcc | mandel, what dirty tricks? | 14:33 |
| gatox | alecu, mandel if you have time for a review please: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/tests-failing/+merge/107799 | 14:33 |
| gatox | alecu, mandel this fix u1-cp tests and some problems with the music folder | 14:33 |
| dobey | mandel: http://www.apache.org/licenses/GPL-compatibility.html | 14:33 |
| mandel | mmcc, well NSLog does not log to a file so you have to change that, it does not support debug only messages which means that i have to use templates to create my own log functions by setting a a DEBUG flag | 14:34 |
| mandel | mmcc, I would like to log to asl which would be a nice feature | 14:34 |
| mandel | dobey, thx! | 14:34 |
| alecu | mandel, re: "no bloody simple way to patch methods on objective-c"... perhaps we should look at what other frameworks are building their tests, and see what they use instead. | 14:35 |
| dobey | mandel: but please discuss with mmcc re: his question, before going further :) | 14:35 |
| mandel | dobey, yes | 14:35 |
| alecu | mandel, and we should look at the plenty other objective-c unit test framework that don't do mocking. | 14:35 |
| alecu | mandel, like the one that comes standard with xcode. Or the one from google... | 14:36 |
| mandel | alecu, we are using the one that comes standard with Xcode which is ocunit and recommends ocmock | 14:36 |
| mmcc | mandel, looking at the goog toolbox. I've never really needed a separate logging framework but I'll see what it offers. | 14:36 |
| mandel | alecu, most common ones are GHunit and ocunit, ocunit is in xcode and that is the only reason why I'm using it | 14:37 |
| mmcc | mandel, also I didn't understand what you meant by using templates...? | 14:37 |
| alecu | mandel, that sounds like a good reason. Anyway, -1 at using ocmock. | 14:37 |
| mandel | mmcc, sorry i mean macros.. | 14:37 |
| mmcc | mandel, ah ok. | 14:38 |
| mandel | alecu, I know, but how do you patch the methods? is possible but is a major PITA ( I have looked at using the objective-c runtime method and method_setImplemenation etc..) | 14:38 |
| alecu | mandel, I mean... I still need to take a closer look at how ocmock works, but I'm biased by the previous headaches with python mocker. | 14:38 |
| mandel | alecu, lots of work for what we need | 14:38 |
| mandel | alecu, yes, that is why I added the comment, I don't like using it, I cannot think of I nicer way to do the tests | 14:39 |
| alecu | mandel, then probably "patching methods" is not the way we should be writting tests. | 14:39 |
| alecu | mandel, at least not in objective C. | 14:39 |
| mandel | alecu, yes, it is not, way to much work to be done and is not our job to write a 'patching lib' | 14:40 |
| alecu | mandel, I think we should take a closer look at how people are writting tests with ocunit, or ghunit. | 14:40 |
| dobey | "patching methods" does not work very well in static languages | 14:40 |
| alecu | dobey, right. Though objective C is pretty dynamic. | 14:41 |
| mmcc | sorry I'm not much help here - my previous objective-C projects were not well tested, I've mostly only used python testing frameworks | 14:41 |
| mmcc | alecu, can you catch me up on the issues you had with python mocker? | 14:41 |
| alecu | mmcc, the main issue was with maintainability of the tests. | 14:42 |
| dobey | mmcc: mocking things is bad because it means you end up testing the mocked code, and not the real code; and it makes maintaining the tests much harder | 14:42 |
| mandel | mmcc, is like writing the tests in brain fuck more or less | 14:42 |
| alecu | mmcc, a test with mocker would be understandable only to the person writting it, and only for a few hours... | 14:42 |
| alecu | mmcc, btw: I was responsible for quite a few of those tests, because I liked mocker, and now I'm ashamed. | 14:43 |
| mmcc | heh | 14:43 |
| mandel | same here.. | 14:43 |
| alecu | mmcc, so, we are moving out of mocker for new python tests, and replacing it as we refactor old tests. | 14:43 |
| mmcc | ok | 14:44 |
| alecu | mmcc, also "mocking encourages a bad style of testing that is viral" https://plus.google.com/107994348420168435683/posts/NVc4P3vTZZ9 | 14:44 |
| mandel | mmcc, mainly using patch from twisted.test case | 14:45 |
| mandel | mmcc, alecu, the beauty of that is that he wrote mocker.. | 14:45 |
| alecu | mandel, and that makes him much more trustworthy for recognizing his own errors. right? | 14:48 |
| mandel | alecu, yes, I was not being sarcastic, it was a complement for the statement :) | 14:48 |
| * alecu is shutting down his pristine win 7 vm. This MSDN suscription has payed for itself today! | 14:49 | |
| mandel | alecu, by the way, I remove the kernel header and everything works.. do you have around the errors that you were getting without it? | 14:52 |
| thisfred | me | 15:00 |
| gatox | me | 15:00 |
| briancurtin | me | 15:00 |
| ralsina | mandel alecu mmcc briancurtin gatox thisfred dobey standup in 0 minutes! | 15:00 |
| ralsina | me | 15:00 |
| mandel | me | 15:00 |
| dobey | lies! | 15:00 |
| mmcc | me | 15:00 |
| ralsina | alecu: you! | 15:01 |
| thisfred | DONE: bug #1004540, bug #1004486, bug #1003610 TODO: bug #1003610 BLOCKED: no NEXT: gatox | 15:01 |
| ubot5 | Launchpad bug 1004540 in U1DB "put docs with revno None (as create doc) and a previously deleted document should work, not require you to know the revno of the deleted version" [Medium,In progress] https://launchpad.net/bugs/1004540 | 15:01 |
| ubot5 | Launchpad bug 1004486 in U1DB "db.get_all_docs() that returns all non deleted documents" [Medium,Fix released] https://launchpad.net/bugs/1004486 | 15:01 |
| gatox | DONE: | 15:01 |
| gatox | Propose a branch for the tests failing in u1-cp on windows, and the music folder not being shown correctly. | 15:01 |
| gatox | TODO: | 15:01 |
| gatox | Fix some other u1-cp and sso issues. Go back to fsevents and add the info obtained with the tests in the wiki. | 15:01 |
| gatox | BLOCKED: | 15:01 |
| ubot5 | Launchpad bug 1003610 in U1DB "get_doc() and get_docs() should not return deleted documents by default" [Medium,Fix released] https://launchpad.net/bugs/1003610 | 15:01 |
| gatox | No | 15:01 |
| gatox | briancurtin, go | 15:01 |
| briancurtin | DONE: memorial day, BBQ | 15:01 |
| briancurtin | TODO: remove lazr from buildout/jenkins/installers once the branch lands, look into creating some type of beta channel so we can hook U1 on windows into the jenkins artifacts | 15:01 |
| briancurtin | BLOCKED: no | 15:01 |
| briancurtin | NEXT: ralsina | 15:01 |
| ralsina | DONE: mgmt call, tech leads call, proposed a branch for get_root_dir bug, started working on the mac jenkins stuff TODO: keep working on that, lots of 1-1s blOCKED: no, NEXT briancurtin | 15:01 |
| ralsina | next mandel then! | 15:02 |
| mandel | DONE: bug 1000868 bug 1003519 bug 1003914 bug 1000869 | 15:02 |
| mandel | TODO: 1-1 with ralsina. Talk with mmcc and alecu, no OCMock, then what? | 15:02 |
| mandel | BLOCKED: no | 15:02 |
| mandel | mmcc, please | 15:02 |
| ubot5 | Launchpad bug 1000868 in Ubuntu One FsEvents daemon "Missing script to run tests via the command line." [High,In progress] https://launchpad.net/bugs/1000868 | 15:02 |
| ubot5 | Launchpad bug 1003519 in Ubuntu One FsEvents daemon "Apple headers are present in the project" [High,In progress] https://launchpad.net/bugs/1003519 | 15:02 |
| mmcc | DONE: visible progress in packaging sso-client, ate hamburgers | 15:02 |
| mmcc | TODO: more packaging fun, reviews | 15:02 |
| mmcc | BLCK: NO | 15:02 |
| mmcc | NEXT: alecu ? | 15:02 |
| ubot5 | Launchpad bug 1003914 in Ubuntu One FsEvents daemon "Tests fail when ran from the command line" [High,In progress] https://launchpad.net/bugs/1003914 | 15:02 |
| ubot5 | Launchpad bug 1000869 in Ubuntu One FsEvents daemon "Missing tests for the FSEventsDispatcher class" [Medium,In progress] https://launchpad.net/bugs/1000869 | 15:02 |
| dobey | λ DONE: logo and spacing in installer, reviews, triage, holiday | 15:02 |
| dobey | λ TODO: expenses, set up milestones, triage | 15:02 |
| dobey | λ BLCK: none. | 15:02 |
| thisfred | eh, pasto, that should be TODO: DONE: bug #1004673 | 15:04 |
| ubot5 | Launchpad bug 1004673 in U1DB "Allow code to pass in document factories" [Undecided,New] https://launchpad.net/bugs/1004673 | 15:04 |
| * gatox bank and lunch! | 15:05 | |
| === gatox is now known as gatox_lunch | ||
| ralsina | mandel: wana mumble? | 15:10 |
| mandel | mmcc, so, about logging, what do you usually do for logging to a file just in debug mode, just a macro? | 15:10 |
| mandel | ralsina, sure! | 15:10 |
| mandel | mmcc, I thin asl is a good idea (http://developer.apple.com/library/mac/#documentation/Darwin/Reference/ManPages/man3/asl.3.html) but I don't want to write a logging lib | 15:11 |
| alecu | uh, I totally forgot about the standup. | 15:14 |
| mmcc | mandel, logging to a file for debug isn't something I've really needed to do - when a program wasn't launched from a terminal, the stdout & stderr go to Console.app, which lets you filter the messages, so I've usually just used that | 15:14 |
| alecu | DONE: a fix requested for secpatches, techleads mumble, mumble with gatox re suggested paths, started with SD bug queue | 15:15 |
| alecu | TODO: more SD bug queue, discuss alternative testing framework for osx | 15:15 |
| alecu | BLOCKED: no | 15:15 |
| mmcc | mandel: but I can definitely see where writing to a separate file, and having configurable log levels, can be nice... | 15:17 |
| mandel | mmcc, specially for a daemon.. I don't want it to crash and wonder.. | 15:18 |
| mmcc | mandel, crash and wonder what? if it writes to stderr it'll be in the console... | 15:18 |
| mmcc | but I don't mean to argue - writing to a separate file is good, it's just worth seeing if it's enough of an improvement over what's there to be worth bringing in license issues | 15:19 |
| mandel | mmcc, yes, give me a sec, phone | 15:20 |
| mmcc | mandel - no prob. | 15:20 |
| mmcc | also, why not just use the ASL library as is? looks pretty nice, actually. | 15:25 |
| dobey | ok, need to get lunch. bbiab | 15:30 |
| mandel | mmcc, yes, is one of my options | 15:31 |
| mandel | mmcc, and thinking about it, if adding the google stuff is adding a dep outisde the ecosystem I might as well not use it | 15:33 |
| mandel | oh, and I'm not on the phone anymore :) | 15:34 |
| mmcc | mandel, yeah. looking at the asl manpage, it looks like it'd be pretty quick to set up.. | 15:34 |
| mmcc | mandel: if you need to log from multiple threads it's a little more work, you need to asl_open a handle on each thread | 15:34 |
| mmcc | but otherwise you can just asl_log(NULL, NULL, ASL_LEVEL_DEBUG, "c-string-msg"); | 15:35 |
| mandel | mmcc, which we do, but should not be terrible | 15:35 |
| mmcc | and no other setup | 15:35 |
| mmcc | OTOH, I might suggest just going with NSLog and the console until it doesn't do something we need... unless we're already there? | 15:36 |
| mandel | mmcc, ok, I think I'm convinced to use asl directly | 15:36 |
| mandel | mmcc, right now we use NSLog, I added the logigng to a file as a bug, but I can leave that bug for later :) | 15:36 |
| mandel | mmcc, alecu, os for me the only blocking issue is to OCMock or not OCMock | 15:37 |
| mmcc | mandel, sounds good. | 15:37 |
| mmcc | mandel, so the problem is that you want to write tests more like the ones with twisted's patch()? | 15:37 |
| mandel | mmcc, yes, I want to tests individual methods that interact with other objects and patch/mock those objects | 15:38 |
| mmcc | but ObjC testing is kind of not well developed... | 15:38 |
| mandel | mmcc, I want to assert the correct interaction but not depend on them | 15:38 |
| mandel | mmcc, I've seen this in other places, some platforms are behind the TDD movement etc.. for example, 5 years ago in the .Net world nearly no one did unit tests and now they are in the other extreme | 15:39 |
| mandel | mmcc, as well as with patterns, they did very bad code, now they have as many factories as java :) | 15:39 |
| mmcc | yeah. so, there are ways to replace methods in existing classes, or you could wrap a class and delegate all the methods over to the original object except for the one you want to 'patch'. | 15:40 |
| mmcc | the problem is that there aren't good tools for doing that simply, that I know of | 15:40 |
| mmcc | maybe OCMock can do something like that? but it looks like it's intended to mock whole objects - leading to the problems you guys were talking about earlier | 15:41 |
| mandel | mmcc, well, you can use stubs which is 'like' a patch /cc alecu | 15:42 |
| mandel | mmcc, for example [[[event stub] andReturn: [NSArray]] paths] | 15:42 |
| mandel | mmcc, that will patch the paths method and will always return the same array | 15:43 |
| mandel | mmcc, well, you have to create the nsarray properly :P | 15:44 |
| mmcc | mandel: so, event is an existing object with a 'paths' method, and this replaces it to always return the argument to andReturn: ? | 15:44 |
| mmcc | that sounds a lot like a patch | 15:45 |
| mandel | mmcc, yes, exactly that | 15:45 |
| mandel | mmcc, then you can also do [event expect] which is the same as a patch but with expectations | 15:45 |
| mandel | mmcc, so if paths is not called, we have an assertion error | 15:46 |
| mmcc | mandel: right, looking at ocmock.org now | 15:46 |
| mandel | mmcc, so I think it depends on how we use it, we might abuse expect or use a combination of expect and stub correctly | 15:46 |
| mmcc | there's also swizzling, down at the end - which is also basically patching | 15:47 |
| mandel | mmcc, ha, I did not see that one | 15:47 |
| ralsina | mmcc: swizzling? that's a technical term now? | 15:48 |
| mmcc | ralsina: yes! in objc | 15:48 |
| ralsina | mmcc: omg it is | 15:48 |
| briancurtin | sounds like a dance move | 15:48 |
| ralsina | or the process of manufacturing a slurpee | 15:49 |
| mmcc | ah, I see. so with stub, we don't have a real object, and so we might need to mock a lot of behavior even if the test interacts with only a bit of it... | 15:49 |
| mmcc | but with partial mocking and swizzling we can do what patching does - have the original object around, but only replace one method | 15:49 |
| czajkowski | aquarius: can you personalise the U1 sharing url in any way ? | 15:50 |
| ralsina | mmcc: that kind of faking you get with stubs is a sort of infectious behaviour, it grows until the complexity doesn't pay of | 15:50 |
| aquarius | czajkowski, not with U1 itself, no. With u1.to you can, though :) | 15:50 |
| czajkowski | aquarius: hmm no I was thinking if you're sharing a file, if you personalised the URL then no matter what the update was the url wouldn't change? | 15:51 |
| mmcc | ralsina: right. | 15:51 |
| mmcc | but it looks like we might be able to avoid it and still use ocmock for friendly patching | 15:51 |
| ralsina | mmcc: sounds nice | 15:51 |
| aquarius | czajkowski, ah, right. No. The problem is that a personalised URL would be pointing to a file which is no longer there. (Yes, I know this seems a bit stupid, which is why it's a bug that needs fixing. :)) | 15:51 |
| czajkowski | aquarius: no worries was just racking my brain for a work around in case I do it again | 15:52 |
| ralsina | czajkowski: what you need is a URL immortalizer (AKA: a shortener that you can change where it points to) | 15:52 |
| ralsina | czajkowski: I wrote one, never put it in production anywhere, sadly | 15:52 |
| czajkowski | ralsina: or I need U1 to note that the file I changed and uploaded is the same file and should keep the same published url. but seeing as I can't I'm asking ye annoying questions that have probably been asked before | 15:52 |
| ralsina | czajkowski: not annying at all :-) | 15:53 |
| aquarius | czajkowski, ya. The problem is that U1 is correctly identifying that they are *not* the same file, but that's not useful -- what U1 should do is cope with that situation even though what it's doing is technically right :) | 15:53 |
| czajkowski | technicall V functionality | 15:53 |
| czajkowski | no biggie learnt my lesson :) | 15:54 |
| aquarius | czajkowski, exactly, which is why it's a bug ;) | 15:54 |
| czajkowski | *technically | 15:54 |
| mmcc | mandel, alecu, ralsina : OCMock's "partial mock" is exactly what I described earlier - a 'wrapper' that forwards methods it doesn't know about to the class it wraps. So if you have something you need to patch, you create a partial mock of it, and use 'stub' to replace the one method - everything else goes to the original object. Sounds like just what we need... | 15:54 |
| czajkowski | aquarius: well next time you can't sleep fix zee bug :) | 15:54 |
| aquarius | czajkowski, heh. if it was that easy we'd have fixed it already. Fixing this one is hard. :) | 15:54 |
| czajkowski | aquarius: surely that;s a challenge you should accept | 15:54 |
| czajkowski | :) | 15:54 |
| ralsina | mmcc: yeah, sounds really nice :-) | 15:55 |
| mandel | mmcc, that is what I though.. and then use expect for those method you want to assert against | 15:55 |
| aquarius | czajkowski, sure; the question is merely whether fixing this is more important than the other ninety things I'm doing. :P | 15:55 |
| czajkowski | aquarius: I'd buy you beer if you fixed this one though! | 15:55 |
| aquarius | you mean you won't buy me beer anyway? :) | 15:56 |
| aquarius | srsly, though, it's surprisingly hard. :( | 15:56 |
| czajkowski | aquarius: my kinda beer is baby guinness don't forget that or jaegar bombs! | 15:57 |
| mmcc | mandel, yeah, expect looks useful too - in lieu of blocks, that's the nicest way to patch a method with a replacement that just checks its arguments... | 15:58 |
| mandel | mmcc, yes, I've done that here: https://code.launchpad.net/~mandel/ubuntuone-fsevents-daemon/add-dispatcher-tests/+merge/107766 line 617 | 15:59 |
| mmcc | mandel oh, I didn't see checkWithBlock: - nice | 16:01 |
| mandel | mmcc, yes, I think is a really nice API | 16:01 |
| mmcc | mandel: agreed. I think it can be used for good | 16:01 |
| mmcc | so now the fun bit - their license isn't obviously a well-known one. Not GPL, looks bsd-ish. Seems compatible. Is my license pattern matcher broken? https://github.com/erikdoe/ocmock/blob/master/Source/License.txt | 16:03 |
| mandel | mmcc, and know is when i swear in spanish agains lawers licenses and their mothers.. | 16:04 |
| mandel | mmcc, seems too, but I'm not sure.. | 16:05 |
| alecu | mmcc, mandel: we can have ocmock as a build dependency, since it's not something we would be redistributing, right? | 16:05 |
| mandel | alecu, yes, is just for the tests target, nothing gets shipped | 16:05 |
| alecu | mandel, then we should not have a license issue with using ocmock. | 16:05 |
| alecu | mandel, btw: what's "^BOOL" in the checkWithBlocks? | 16:06 |
| mandel | alecu, and is not even a build dep, you can build the FSEvents target without it, is a test dep | 16:06 |
| mandel | alecu, is a block, being very rough, a lambda that returns a BOOL | 16:06 |
| alecu | mandel, what's with the "^" ? | 16:06 |
| mandel | alecu, block syntax: http://thirdcog.eu/pwcblocks/#objcblocks | 16:07 |
| alecu | "To define a block variable, the ^ operator is used" | 16:07 |
| mandel | alecu, and you can name blocks using the same ugly syntax | 16:08 |
| * alecu realizes he has done no Objective C code since iOS 2 | 16:08 | |
| mandel | alecu, is not the same the ^BOOL(ConfigMessage *msg) than BOOL(^checkArg)(ConfigMessage *) | 16:11 |
| mandel | alecu, and one has to be careful with __block and the possible retain of self etc.. is a little messy specially with arc, but does the trick for the tests | 16:12 |
| mandel | alecu, in the other code I use selectors and performSelector which is nicer is the method is implemented by the class | 16:12 |
| * mandel should stop talking about objc | 16:12 | |
| mmcc | mandel - no, keep talking until I understand what you just wrote :) | 16:13 |
| mmcc | in which other code are you using performSelector? | 16:13 |
| briancurtin | weird...that lazr change seems to fail because ithere are lint warnings for win32 stuff? | 16:14 |
| briancurtin | s/warnings/errors | 16:15 |
| mandel | mmcc, me being super lazy, take a look at line 312 and line 425 of the https://code.launchpad.net/~mandel/ubuntuone-fsevents-daemon/add-dispatcher-tests/+merge/107766 | 16:15 |
| mandel | mmcc, there I define a dict with the selector name and the message type, then I loop looking for the type and execute the selector, which is nicer than writing a huge if statement | 16:16 |
| mandel | mmcc, but is me taking advantage of the lang to write as little as possible | 16:16 |
| mandel | briancurtin, hm, let me check | 16:16 |
| mandel | briancurtin, fails due to 41: [W0611] Unused import oauth | 16:17 |
| mandel | I think the rest is garbage from the setup.py build, but I'm not sure | 16:18 |
| briancurtin | mandel: which is BS because that change has nothing to do with the branch. i wish that stuff was smarter | 16:18 |
| mandel | briancurtin, yes, and the major PITA is that we do not own the branch so we have to go after the community guy.. | 16:19 |
| mmcc | mandel: that'd be a pretty easy branch to re-create on our own | 16:19 |
| ralsina | mandel: branch from the branch and use bzr --author | 16:20 |
| ralsina | briancurtin: you too ^ (and here's what I meant: http://blogs.gnome.org/jamesh/2008/05/12/bzr-commit-author/) | 16:21 |
| mandel | ralsina, I had no idea that could be done! | 16:21 |
| ralsina | mandel: bzr has a bazillion options noone remembers. That is one :-) | 16:22 |
| mmcc | of course I'd want to thank this guy all over the commit messages :) how did he know I would need this for mac packaging! | 16:22 |
| mandel | mmcc, arch and mac have something in common hehehe | 16:23 |
| gatox_lunch | back | 16:23 |
| === gatox_lunch is now known as gatox | ||
| mandel | or was it gentoo, what ever :P | 16:23 |
| ralsina | mmcc: looks like a MIT/X11 thing | 16:24 |
| mmcc | ralsina: the OCMock license? | 16:24 |
| ralsina | mmcc: worse, it's the BSD with attribution license, which is incompatible :-/ | 16:24 |
| ralsina | mmcc: yes, the OCMock license | 16:24 |
| ralsina | mmcc: good news are, we don't need to do derivatives, do we? | 16:25 |
| mandel | alecu, mmcc, so, do we classify OCMock as evil? Do I find a diff way to run the tests? | 16:25 |
| mandel | mmcc, is just a test dep nothing for the project | 16:25 |
| ralsina | dobey: does https://github.com/erikdoe/ocmock/blob/master/Source/License.txt look evil to you too? | 16:25 |
| mandel | ralsina, that was for you ^ | 16:25 |
| mmcc | ralsina: no, we don't need to do derivatives | 16:25 |
| alecu | mandel, no tool is evil. It's how you use it! | 16:25 |
| ralsina | mandel: if you subclass something from OCMock and ship it with our code, we are shipping a derivative | 16:25 |
| mmcc | mandel: I vote for using OCMock. | 16:26 |
| mandel | alecu, dammed... that makes anything I use is evil then hehehe | 16:26 |
| alecu | mandel, so, if you find no better way to "patch" in Objective C, go ahead an use OCMock. | 16:26 |
| mmcc | ralsina: we're not doing that, just a test dep and no subclassing | 16:26 |
| alecu | mandel, but let's not use it for "mocker-style" tests. | 16:26 |
| ralsina | mmcc: #include'ing or linking? | 16:26 |
| briancurtin | mandel: so how should we go forward with this lazr MP? should i jump in and do the fixes with --author? | 16:26 |
| mmcc | ralsina: both, in a separate test bundle that we do not need to ship... | 16:26 |
| mandel | briancurtin, yes please! | 16:26 |
| ralsina | mmcc: but we do ship everything, because it's open source. | 16:27 |
| ralsina | mmcc: even if we only "ship it" via launchpad | 16:27 |
| mmcc | ralsina: I get that - so I guess I don't understand why BSD + attr is incompatible | 16:27 |
| ralsina | mmcc: "in all documents and publicity | 16:27 |
| ralsina | pertaining to direct or indirect use of this code or its derivatives." | 16:27 |
| ralsina | mmcc: we are not mentioning ocmock on TV ads if we ever do one ;-) | 16:28 |
| mmcc | ralsina: ah ok. yeah, weird. I would bet lots of $ that no one really abides by that | 16:28 |
| mmcc | not that that helps us | 16:28 |
| ralsina | mmcc: look at the small letters in apple ads. You will be surprised. | 16:28 |
| mmcc | ralsina: I do believe you... hmmm. | 16:30 |
| ralsina | mmcc: let's get dobey's opinion since he knows lots about this, and if we still have doubts, we can always ask legal. | 16:30 |
| ralsina | Chipaca: just in case you have an opinion, does https://github.com/erikdoe/ocmock/blob/master/Source/License.txt look like a GPL-incompatible BSD-like license to you? | 16:30 |
| * alecu will get some lunch | 16:31 | |
| mmcc | hmm, chromium uses (used?) ocmock: http://code.google.com/p/chromium/issues/detail?id=28291 | 16:32 |
| mandel | briancurtin, can we get you input for https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/tests-failing/+merge/107799 | 16:33 |
| briancurtin | mandel: certainly, i'll take a look after i figure out this lazr thing | 16:34 |
| dobey | ralsina: evil? | 16:34 |
| ralsina | dobey: a publicity-requiring bsd-like license, gpl-incompatible? | 16:34 |
| dobey | ah yes, it is evil | 16:34 |
| ralsina | dobey: ok, next thing is to know if that evil affects us for theintended usage | 16:35 |
| dobey | ralsina: well, actually it's weird | 16:35 |
| ralsina | dobey: it's also a non-standard example of such, yes | 16:35 |
| dobey | usually the license would say you CANNOT use "x" in advertising/publicity/etc | 16:35 |
| mandel | jesus.. why are this license things so hard! | 16:36 |
| * ralsina is someday going to create a robot that trawls github for custom licenses, and then tap the authors with a spoon | 16:36 | |
| mmcc | ohloh.net claims ocmock is 'new bsd' but I don't know who set that | 16:36 |
| dobey | i hope the spoon is filed down first ;) | 16:36 |
| dobey | mmcc: not a lawyer :) | 16:36 |
| ralsina | dobey: it says "credit is given... in all documents and publicity" | 16:36 |
| ralsina | dobey: http://twitchfilm.com/reviews/2008/10/2008-dead-channelsthe-horribly-slow-murderer-with-the-extremely-inefficient.php | 16:37 |
| dobey | ralsina: right; it says that credit must be given. | 16:37 |
| dobey | haha | 16:37 |
| ralsina | dobey: watch it in youtube, it's awesome | 16:38 |
| dobey | aww | 16:38 |
| dobey | it's not on amazon | 16:38 |
| mmcc | no licensing discussion on ocmock forums | 16:38 |
| dobey | but interestingly, i searched for it on amazon, and the only results were "Max Payne" games | 16:38 |
| ralsina | dobey: http://www.youtube.com/watch?v=9VDvgL58h_Y it's the official channel | 16:39 |
| dobey | hmm | 16:41 |
| mmcc | any reason I shouldn't ping the author and ask about relicensing? | 16:41 |
| ralsina | mmcc: none | 16:41 |
| ralsina | mmcc: go ahead and ping. Either relicensing or clarification. | 16:41 |
| ralsina | mmcc: if he is willing to say using it is not covered by the publicity requirements, I'm ok with that | 16:41 |
| mmcc | ralsina: aha, ok - I was going to ask what that'd look like :) | 16:42 |
| gatox | mandel, can you take a look at this please: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/tests-failing/+merge/107799 so we fix the problems in cp for windows | 16:43 |
| ralsina | dobey: in other news, I proposed this https://code.launchpad.net/~ralsina/ubuntuone-control-panel/decrypt-errors-3-0/+merge/107671 | 16:43 |
| mandel | gatox, I was already doing it and ask briancurtin for help ;) | 16:43 |
| ralsina | dobey: only to 3-0 because it doesn't happen in trunk anymore since we switched to endpoints, apparently | 16:44 |
| dobey | ralsina: i saw a branch for trunk as well though? | 16:44 |
| ralsina | dobey: that was a misunderstanding on my part and I rejected it | 16:45 |
| gatox | mandel, ahhh ok | 16:45 |
| dobey | ralsina: but i saw it proposed again after you rejected? | 16:45 |
| ralsina | dobey: that was because I was sleepy | 16:45 |
| ralsina | dobey: and clicked on the wrong link ;-) | 16:46 |
| dobey | oh, it was deleted | 16:46 |
| mandel | gatox, is there a tests for _process_name? | 16:46 |
| gatox | mandel, nop..... also someone told me once that we don't test private methods | 16:47 |
| dobey | ralsina: i think we need to wait for sidnei to review my branch to add the quantal tarmac and split up the trunk and stable landing, and restart the instances after it lands. currently, the trunk stuff (nightlies) breaks the stable-3-0 cp tests | 16:47 |
| Chipaca | ralsina: that license appears to be MIT | 16:47 |
| gatox | mandel, do you think i should add a test for that? | 16:48 |
| ralsina | Chipaca: but it has a publicity requirement | 16:48 |
| mandel | gatox, maybe not for the tests directly, but would be nice to test the method that uses it when we get a ~/ and when we don't | 16:48 |
| mandel | gatox, I think it has some logic that we should ensure that is correct in all possible cases | 16:49 |
| briancurtin | mandel, ralsina: I'm getting "Transport operation not possible: readonly transport" when pushing to that branch with the --author commits | 16:49 |
| Chipaca | ralsina: ah, you're right | 16:49 |
| ralsina | briancurtin: no, push to a branch you own | 16:49 |
| dobey | Chipaca: but modified | 16:49 |
| dobey | insanity | 16:49 |
| mandel | briancurtin, I think you have to push to a diff location because the lp branch is owned by the other person | 16:49 |
| ralsina | briancurtin: then your branch will have two authors | 16:49 |
| gatox | mandel, ok..... i'll take a look at that... | 16:49 |
| mandel | gatox, thx! | 16:49 |
| dobey | it is basically not considered "free software" by the FSF/SFLC | 16:49 |
| mandel | gatox, I wond add any comments and that way is not block by me EOD in a few secs hehe | 16:50 |
| gatox | mandel, okk | 16:50 |
| mandel | ralsina, mmcc we can always look at kiwi as an alternative: https://github.com/allending/Kiwi it provides a similar feature but I think that the lib is over the top and the license might also be an issue: https://github.com/allending/Kiwi/blob/master/License.txt | 16:54 |
| dobey | gatox: hah, yes, it is an issue | 16:55 |
| ralsina | mandel: no, that one is a standar MIT/X license | 16:55 |
| ralsina | dobey: really? | 16:55 |
| * ralsina rereads | 16:55 | |
| dobey | err, mandel, sorry | 16:55 |
| dobey | ralsina: yes, because it's BSD with advert clause | 16:55 |
| ralsina | oh, in the documents, crap | 16:55 |
| dobey | cf. item 3 in that License.txt | 16:55 |
| * ralsina moves the spoonbot project in the priority queue | 16:56 | |
| dobey | do we really need any of those? | 16:56 |
| ralsina | dobey: well, yes i we want to do testing | 16:56 |
| dobey | can we not use the testing stuff in xcode as i saw mentioned earlier? | 16:56 |
| ralsina | dobey: these are nicer | 16:56 |
| mandel | dobey, we could move to GHUnit but I don't think it has patching/mocking | 16:57 |
| mmcc | built-in xcode testing doesn't do patching | 16:57 |
| mmcc | we can also write our own... :) | 16:58 |
| * mmcc writing an email to ask OCUnit guy about attribution | 16:58 | |
| mandel | dobey, would this be an issue: https://github.com/gabriel/gh-unit/blob/master/LICENSE | 16:59 |
| mandel | but I don't think it has patching/mocking | 16:59 |
| ralsina | mandel: that one is ok | 17:00 |
| dobey | that looks like straight MIT | 17:00 |
| ralsina | mandel: that's a "non-attribution BSD/MIT like license" | 17:01 |
| mandel | ralsina, dobey, os I wanted to know how the tests are in the iOS files app and got this: http://bazaar.launchpad.net/~ubuntuone-ios-client-team/ubuntuone-ios-files/trunk/files/head:/FilesTests/ | 17:01 |
| ralsina | mandel: I thought the iOS team lead said "we don't do tests because we are awesome"? | 17:02 |
| mandel | ralsina, I suppose that is the case :( | 17:02 |
| mandel | ralsina, or they are hidden :) | 17:02 |
| briancurtin | mandel: i know you're leaving soon, would you mind looking at this MP quickly? https://code.launchpad.net/~brian.curtin/ubuntu-sso-client/drop-lazr-lint-fixes/+merge/107834 it's by György Balló plus two lint fixes | 17:03 |
| briancurtin | alecu ^^ since you reviewed that originally, would you mind taking another quick look? | 17:03 |
| ralsina | launchpad doesn't say "Gyorgy ft Brian Curtin". Another lost marketing opportunity. | 17:04 |
| mandel | briancurtin, sure, let me run the branch to see if we have lin issues in P | 17:04 |
| mandel | briancurtin, although I did it last time and did not have them.. | 17:04 |
| mmcc | The iOS test suite looks about like standard operating procedure for testing with ObjC. | 17:05 |
| mmcc | :( | 17:05 |
| mandel | mmcc, so, no testing, dammed | 17:05 |
| mmcc | took *years* for XCode to include any kind of test framework | 17:05 |
| mandel | mmcc, well, that is what we have to deal with :) | 17:06 |
| mmcc | I guess XCode predates unit testing... NeXT projectbuilder is pretty old at this point | 17:06 |
| ralsina | mmcc: unit testing was defined in 1987 ;-) | 17:07 |
| ralsina | mmcc: but yeah, noone cared until 2007 | 17:07 |
| * mmcc wikipedia'd NeXt - nextstep 1 shipped 1989 | 17:08 | |
| ralsina | http://aulas.carlosserrao.net/lib/exe/fetch.php?media=0910:1008-1987_ieee_standard_for_software_unit_testing.pdf | 17:08 |
| ralsina | Yes, unit testing is a IEEE standard since december 1986 | 17:08 |
| ralsina | that is our feel bad datum of the evening | 17:09 |
| mandel | ralsina, so I'm just 3 years older than unit testing.. | 17:09 |
| mmcc | glacial progress :( | 17:09 |
| mandel | no wonder I'm like this, I had no tests.. :P | 17:09 |
| mmcc | makes distributed VC adoption seem super fast by comparison | 17:09 |
| ralsina | mandel: that's why you crash ;-) | 17:09 |
| ralsina | mmcc: yeah | 17:09 |
| * mmcc thought he saw pics of mandel unit-testing his liver over the weekend | 17:10 | |
| mandel | briancurtin, +1 I got no lint issues on P | 17:10 |
| mandel | mmcc, he, hehehe I took them, it was not me :) | 17:10 |
| mmcc | mandel: understood :) | 17:11 |
| mmcc | anyway, lunchtime... hopefully OCMock guy replies while I'm eating | 17:11 |
| mandel | mmcc, superb, I'm off to rugby, let me know anything that happens | 17:12 |
| ralsina | And I am going to the bank | 17:12 |
| mandel | mmcc, I want to increase that test coverage and them remove ARC which is going to be interesting | 17:12 |
| mandel | ralsina, I can sell you a spanish one if you want ;) | 17:12 |
| ralsina | mandel: ha! | 17:12 |
| dobey | heh | 17:12 |
| * ralsina has nice bridge-property in brooklyn | 17:13 | |
| gatox | mandel, i added a test with ~/.... should i ask you for the re-review or someone else? | 17:19 |
| dobey | oh i guess i have to deal with all the insanity for SRU now too | 17:20 |
| gatox | briancurtin, do you have some time to review this branch please? https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/tests-failing/+merge/107799 | 17:28 |
| briancurtin | gatox: yes i will | 17:28 |
| gatox | briancurtin, thanks! | 17:28 |
| dobey | bugger. new server case only has 2x2.5" hot swap drive bays, and no where to mount a 3.5" internal | 17:34 |
| gatox | facundobatista, ping | 17:47 |
| facundobatista | gatox, pong | 17:48 |
| gatox | facundobatista, are you still able to reproduce this bug with the latest code in trunk? https://bugs.launchpad.net/ubuntuone-client/+bug/998079 | 17:48 |
| ubot5 | Ubuntu bug 998079 in Ubuntu One Client "--publish-file doesn't end correctly for non-ascii paths" [High,Confirmed] | 17:48 |
| gatox | facundobatista, and if you can..... could you update the trace or give me a paste..... because there was several changes there | 17:48 |
| facundobatista | gatox, you can't? | 17:49 |
| gatox | facundobatista, i confuse it with another bug.... i can test this one....... sorry | 17:50 |
| * gatox testing.... | 17:50 | |
| facundobatista | gatox, :) | 17:50 |
| gatox | facundobatista, yep..... working on that.... sorry for the confusino | 17:52 |
| facundobatista | gatox, no problemo | 17:52 |
| * gatox needs to restart....... brb | 17:57 | |
| dobey | ralsina: do the dates/milestones on https://launchpad.net/dirspec/stable-4-0 look reasonable to you? | 18:05 |
| ralsina | dobey: looking | 18:05 |
| ralsina | dobey: nothing bad jumps at me, so +1 | 18:05 |
| ralsina | dobey: looks nicely aligned to freezes too | 18:06 |
| ralsina | dobey: we may need to finetune the specific release process since qa will have automated testing, but it should be a change for the best :-) | 18:06 |
| dobey | yeah, i was trying to keep them aligned to freezes. so some are 1 week apart, and others are 3 weeks apart. | 18:06 |
| ralsina | dobey: I don't mind making two releases when close to a freeze, helps keep things clean | 18:07 |
| briancurtin | gatox: +1 on u1cp fixes | 18:07 |
| dobey | ralsina: right, and i made these all be mondays as well | 18:07 |
| gatox | briancurtin, great, thanks! | 18:07 |
| gatox | ralsina, are you free for a review? | 18:07 |
| ralsina | gatox: sure | 18:07 |
| dobey | so we have sufficient time to test/upload before freezes | 18:07 |
| gatox | ralsina, this will fix our tests on windows and the folders not being shown pretty: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/tests-failing | 18:08 |
| ralsina | gatox: yay | 18:08 |
| dobey | i'll go ahead and set up the same milestones for the other projects then | 18:08 |
| ralsina | dobey: great work, like it a lot. | 18:08 |
| ralsina | gatox: I don't understand lines 40-41 of the diff | 18:14 |
| gatox | ralsina, we always have the display_name, but not always the suggested_path | 18:14 |
| ralsina | gatox: is it so that you get the fancy name instead of the path for the MUSIC_PATH? | 18:15 |
| ralsina | ahhhh ok | 18:15 |
| gatox | ralsina, we prefer the suggested_path, but if it's not there..... use the display_name | 18:15 |
| ralsina | gatox: also: why would self.user_home be None, and how is it useful for it to be '' ? | 18:16 |
| gatox | ralsina, the none check for user_home was in the previous logic, and be '' would avoid replacing anything in that case | 18:17 |
| ralsina | oh, there's a replace right after that | 18:17 |
| ralsina | ok +1 gatox | 18:17 |
| gatox | ralsina, cool! | 18:18 |
| ralsina | gatox: this is the last red light in jenkins? | 18:18 |
| gatox | ralsina, yes | 18:18 |
| gatox | at least it should | 18:18 |
| ralsina | \o/ | 18:18 |
| briancurtin | ralsina: in removing some lazr stuff from sso's setup.py, i realized that the py2exe command for SSO's setup.py is very out of date. is it used for anything by anyone, or was that moved into windows-installer? | 18:43 |
| ralsina | briancurtin: not used at all | 18:43 |
| briancurtin | alrighty then, removing | 18:44 |
| dobey | briancurtin: can you make that lazr bug that was assigned to you affects ubuntu-sso-client as well, and commit --fixes= to that sso branch which removes that bit from setup.py? | 18:44 |
| briancurtin | dobey: will do | 18:45 |
| gatox | does anyone knows why i cannot run the tests for test_tools.py in u1-client?? | 18:55 |
| gatox | it keeps failing with timeout | 18:55 |
| gatox | but if i run the whole suit is ok | 18:55 |
| dobey | gatox: sounds like isolation problems | 19:00 |
| gatox | dobey, sound like a PITA to try to fix this particular bug :P | 19:00 |
| dobey | gatox: as always | 19:01 |
| mmcc | briancurtin: am I right that the windows-installer setup.py is intended to be run from buildout-env/scripts/devsetup/parts/ubuntuone-windows-installer/scripts/ ? | 19:26 |
| briancurtin | mmcc: what do you want to do? | 19:26 |
| mmcc | briancurtin: understand the intent of its relative paths | 19:27 |
| mmcc | briancurtin: so I can reuse some of it for the mac setup :) | 19:27 |
| briancurtin | mmcc: yeah, the scripts/setup.py is run from that scripts/ directory | 19:27 |
| briancurtin | mmcc: build_installer.py automates the few steps we'd have to run, and then it automates the actual installer build | 19:28 |
| mmcc | briancurtin: I must have an out of date tree - I don't have a build_installer | 19:29 |
| mmcc | (.py) | 19:29 |
| briancurtin | mmcc: i think i pushed it a week or maybe week and a half ago | 19:29 |
| mmcc | briancurtin: ok, no biggie. so I guess if the windows-installer project is going to be a mac/win 'distribution tools' project, I could just slap my setup-mac.py in that same dir? | 19:30 |
| briancurtin | mmcc: it's the script that powers https://jenkins.errormessaging.com/view/Windows/job/ubuntuone-windows-installer/ - giving us a nightly installer (except EC2 is currently down, ugh) | 19:30 |
| mmcc | briancurtin: yeah, I figured it was related | 19:30 |
| briancurtin | mmcc: for the time being, probably | 19:30 |
| mmcc | briancurtin: ok, thanks. | 19:30 |
| briancurtin | mmcc: although at some point here maybe we should make some separation now that the mac things are really picking up steam | 19:30 |
| briancurtin | mmcc: the buildout stuff (under -installer) should go somewhere, and mac really should be ubuntuone-mac-installer or something | 19:31 |
| briancurtin | but for today, i'd say under -windows-installer is the best option | 19:31 |
| mmcc | briancurtin: maybe. I'm not sure there's going to be much other than the different setup.py | 19:31 |
| dobey | briancurtin: put the mac stuff under windows-installer | 19:31 |
| dobey | mmcc: ^^ | 19:31 |
| dobey | we're going to rename it soon | 19:32 |
| ralsina | +1 to what dobey said | 19:32 |
| mmcc | ack | 19:32 |
| gatox | ok..... eod for me! see you tomorrow pepoles! | 20:05 |
| gatox | :P | 20:05 |
| ralsina | bye gatox | 20:05 |
| gatox | ralsina, bye | 20:05 |
| dobey | ugh, so late already | 20:06 |
| briancurtin | yessss. all windows projects are green in jenkins (actually, blue) | 20:10 |
| ralsina | blue's good! | 20:11 |
| briancurtin | i just wonder why they chose blue, or if we can configure it. green is better :) | 20:11 |
| dobey | i'm pretty sure we can change the theme if we want | 20:14 |
| dobey | i'm also pretty sure that the UX of jenkins is atrocious, and it could use a lot of work | 20:14 |
| dobey | also, i am sad that the one pretzel shop that was relatively close to me, and not in a mall, is no more :( | 20:15 |
| mmcc | dobey: pretzel shop not in a mall? do tell… | 20:19 |
| mmcc | if you're near a Whole Foods, I've found good soft pretzels there | 20:19 |
| dobey | mmcc: http://www.phillysoftpretzelfactory.com/ | 20:20 |
| dobey | i don't think there's a whole foods anywhere down here | 20:20 |
| briancurtin | we should make jenkins look like that site | 20:20 |
| mmcc | those look really good. | 20:20 |
| dobey | they are really good | 20:20 |
| dobey | but there's only 1 in all of VA now it seems | 20:21 |
| dobey | and i really don't want to drive to williamsburg to get some pretzels | 20:21 |
| mmcc | none in Texas :( | 20:22 |
| ralsina | dobey: it's sad that most other free CI tools are *worse* | 20:24 |
| mmcc | ... but there is one a half block away from my old college apartment and ten minutes from my old house. BORN TOO SOON :\ | 20:24 |
| dobey | heh | 20:25 |
| ralsina | Am I really unlucky of XCode is a crashy piece of dung produced by a dung beetle? | 20:25 |
| mmcc | ralsina: it's not you | 20:25 |
| ralsina | mmcc: also, the mini fails to come back from suspend about 66% of the time | 20:26 |
| mmcc | ralsina: I'm unfamiliar with that one. Is it new? | 20:27 |
| ralsina | mmcc: it's about a month old | 20:27 |
| ralsina | mmcc: I had never suspended it before today though | 20:27 |
| mmcc | ralsina: https://twitter.com/urbanape/status/206028141926420482 | 20:27 |
| ralsina | mmcc: ha | 20:28 |
| mmcc | ralsina: hmm, I'm not sure what to suggest. I'm told 10.7 is not as stable as 10.6 | 20:28 |
| ralsina | <homer>it's funny because it happens to other people</homer> | 20:28 |
| ralsina | mmcc: it's ok, I can live with it, since it's not my main device | 20:28 |
| mmcc | ralsina: also http://textfromxcode.tumblr.com/ | 20:29 |
| elopio | ralsina or briancurtin, is bug #938102 fixed on the windows installer available from jenkins? | 20:29 |
| ubot5 | Launchpad bug 938102 in ubuntuone-control-panel (Ubuntu Precise) "Qt control panel should accept qt command line options" [Undecided,Fix released] https://launchpad.net/bugs/938102 | 20:29 |
| ralsina | elopio: yes | 20:30 |
| elopio | ralsina: so, any idea why the control panel is not available for testability? | 20:31 |
| ralsina | elopio: none whatsoever | 20:31 |
| ralsina | elopio: you sure you don't have a u1cp running already? | 20:31 |
| elopio | it was a pain to have it all installed, but the sample qt applications work fine now. | 20:31 |
| elopio | ralsina: I've tried killing everything. | 20:32 |
| elopio | ralsina: it's also weird that you can't launch the cp from testability visualizer. | 20:32 |
| ralsina | elopio: I never got the visualizer working :-/ | 20:33 |
| elopio | ralsina: what's the exe you use to open it? ubuntuone-control-panel-qt from the dists folder? | 20:33 |
| ralsina | elopio: yes | 20:33 |
| ralsina | elopio: try running it with -reverse if it looks insane, then it's taking the arguments | 20:33 |
| ralsina | elopio: could be you need to install the testability driver in a place where our copy of Qt (that we ship with the app) can find it | 20:34 |
| ralsina | elopio: or we may need to build the installers with the testability driver builtin | 20:34 |
| elopio | ralsina: it looks insane. | 20:34 |
| elopio | ralsina: that might be it. I installed the qt sdk for windows. | 20:35 |
| ralsina | elopio: ok, then it's not the code | 20:35 |
| elopio | and it seems that the sample apps use that one. | 20:35 |
| ralsina | elopio: yeah, we bundle a copy of qt, so testability is not there for it | 20:35 |
| ralsina | elopio, briancurtin: you two may have to talk a little about this | 20:35 |
| elopio | briancurtin: :D | 20:36 |
| briancurtin | yeah im not sure what testability is (besides as a word) | 20:38 |
| mmcc | buildout question: would it be difficult to make the bootstrap step generate my setup-mac.py, similar to how the buildout's python exe gets generated? I have a path clash that is breaking the setup calls to bzr, and that's one way out | 20:39 |
| elopio | briancurtin: it's the qt user testing framework: projects.developer.nokia.com/Testabilitydriver | 20:39 |
| mmcc | looks like the other way will be to hardcode the path to homebrew's installation of bzrlib in the setup script | 20:40 |
| mmcc | also, just to check that I'm not going crazy - can someone with a mac set up try running bzr from the same shell that they've got the dev env setup? | 20:42 |
| elopio | briancurtin: according to what I've read, testability is included in latest qt. But this might be required: http://projects.developer.nokia.com/Testabilitydriver/wiki/WindowsHowToStart#ModifyingyourQtapplicationtoloadthetestabilityinterface | 20:43 |
| briancurtin | elopio: ah, we recently stopped using the latest qt and went one version back. i'll look into this | 20:45 |
| elopio | and on my qt sdk there's a testability.dll | 20:45 |
| elopio | that's what we might be missing. | 20:45 |
| elopio | thanks briancurtin. | 20:46 |
| ralsina | briancurtin: we moved back because of the SSL bug, right? | 20:48 |
| briancurtin | yeah | 20:48 |
| ralsina | briancurtin: if yes, then we may be able to move forward again | 20:48 |
| ralsina | briancurtin: after we finally fix it, of course. Or at least for jenkins, so that elopio can run the tests | 20:49 |
| briancurtin | ralsina: hm, jenkins may actually still be on the new version. i haven't messed with any of the versions that jenkins currently has, but i'll check in a bit | 20:50 |
| * mmcc now understands why this worked on windows. bzr's run-bzr.bat sets the path explicitly | 20:52 | |
| ralsina | briancurtin: ack | 20:57 |
| ralsina | briancurtin: it may not be shipped and if it's a plugin, it may not even work if shipped | 20:57 |
| mmcc | mmcc: no, that's not it. but bzr on windows is packaged differently enough to be the reason. | 20:57 |
| ralsina | EOD for me | 21:00 |
| ralsina | elopio: will get it fixed, promise! | 21:01 |
| elopio | ralsina: :) | 21:01 |
| ralsina | briancurtin: keep me posted if you figure something out, I will try to do something early tomorrow morning | 21:01 |
| briancurtin | ralsina: will do | 21:01 |
| ralsina | bye ! | 21:01 |
| elopio | in the meantime, I'll continue playing with it in ubuntu, that's now working like a charm. | 21:01 |
| elopio | bye. | 21:02 |
| === m_conley is now known as m_conley_away | ||
| * dobey wonders how to ssh into a running vm instance in virtualbox | 21:23 | |
| tetris4 | hello, am trying to import ubuntu one to Chakra | 21:56 |
| tetris4 | I managed to build all the deps and packages using ArchLinux PKGBUILDs | 21:57 |
| tetris4 | but I get this: http://paste.chakra-project.org/1794 | 21:57 |
| tetris4 | can someone tell me what did I miss? | 21:57 |
| dobey | gsettings is a command from glib | 22:17 |
| dobey | ah, you're missing the proxy schema though, which comes from gsettings-desktop-schemas | 22:18 |
| dobey | but i need to go now | 22:19 |
| tetris4 | dobey: np, thnx for responding | 22:20 |
| tetris4 | gsettings is gnome based? | 22:20 |
| tetris4 | i was hoping the new client could work without gnome dependencies | 22:20 |
| dobey | gsettings is part of glib | 22:23 |
| tetris4 | yeah, I ran gsettings and I can see i have it | 22:24 |
| tetris4 | will try to install desktop-schemas too | 22:25 |
| tetris4 | ahh..k00l, now it runs! | 22:29 |
| tetris4 | but gives this error: DBusException The name org.freedesktop.secrets was not provided by any .service files | 22:30 |
| tetris4 | with this output when ran from cli: http://paste.chakra-project.org/1796 | 22:31 |
| tetris4 | and installing ksecrets made it work! nice | 22:38 |
| mmcc | time for me to go. see you all tomorrow | 22:41 |
| tetris4 | gn | 22:44 |
| tetris4 | No such method "ReadAlias" in interface 'org.freedesktop.Secret.Service' at object p... | 22:48 |
| tetris4 | my latest error, with this cli output: http://paste.chakra-project.org/1797 | 22:48 |
| tetris4 | looks like ksecrets is broken atm..so probably that is the issue | 23:05 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!