| speakman | Any updates on pixel-smooth scrolling in Chromium? | 07:40 |
|---|---|---|
| === ara is now known as Guest64238 | ||
| === MacSlow is now known as MacSlow|lunch | ||
| bregma | hey guys, could I get a review of https://code.launchpad.net/~bregma/libgrip/lp-872022/+merge/107877 ?? | 14:20 |
| dandrader | I know nothing about that code base | 14:28 |
| Satoris | Why does moving it outside the if fix the crash? To me it would seem to make it be called more often (which is the cause of the crash, if I understand correctly). | 14:35 |
| bregma | the signal was being called for every widget in the visual stack rather than just for the top-level widget peered with a window, resulting in dereferences of a deleted pointer | 14:37 |
| bregma | it's convoluted | 14:37 |
| bregma | very convoluted | 14:37 |
| Satoris | An X/GTK issue convoluted? Why, I never. | 14:38 |
| Satoris | So calling it the first time makes the other calls not happen or something convoluteder? | 14:40 |
| bregma | removing the toplevel_notify_cb slot on the lower-level widgets and re-queing on the higher-level widget until the top-level widget is peered with a window results in the toplevel_mapped_cb callback only being called once, instead of for each widget | 14:43 |
| === MacSlow|lunch is now known as MacSlow | ||
| === dandrader is now known as dandrader|afk | ||
| === dandrader|afk is now known as dandrader | ||
| === dandrader is now known as dandrader|lunch | ||
| === dandrader|lunch is now known as dandrader | ||
| === dandrader is now known as dandrader|afk | ||
| === dandrader|afk is now known as dandrader | ||
| doug | hey, what does the pinch threshold (minimum ratio of 1.1) solve? | 22:13 |
| doug | like, what problems it keeps from happening... | 22:14 |
| dandrader | doug, it defines by how much you have to spread your fingers apart so that it's considered a pinch gesture | 22:42 |
| dandrader | doug, if the value is too small, virtually any gesture will be considered as a pinch | 22:42 |
| dandrader | since there's always some small variation in the distance between fingers when performing any gesture | 22:43 |
| dandrader | or, conversely, by how much you have to bring them together | 22:44 |
| dandrader | well, gotta go now | 22:44 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!