[00:25] thomi, this patch seems to fix it for me: http://paste.ubuntu.com/1039976/. Not sure if I'm missing anything there, seems to be simple [00:25] to be too simple [00:25] hahaaaa! [00:26] So what do we do now? [00:27] thomi, open an upstream bug and see what they say, patch the ubuntu package if they take too long and we think it's a good patch [00:27] cool. [00:43] thomi, https://bugzilla.gnome.org/show_bug.cgi?id=678059 [00:43] Gnome bug 678059 in general "memory leak in pango_layout_get_extents" [Normal,Unconfirmed] [00:53] robert_ancell: wonderful, thanks. I'll keep ane ye on it [01:09] thomi, does this effect precise? [01:11] robert_ancell: yes [01:12] thomi, are you familiar with https://wiki.ubuntu.com/StableReleaseUpdates? [01:13] robert_ancell: uhhh, I am now [01:15] robert_ancell: I guess that gets done by whoever manages the pango packages for us? [01:16] thomi, well, for it to qualify as an SRU we need to know how severe the problem is, can you describe how much of a problem it is in precise? i.e. is it just a few k here and there or does it bring unity to a halt over time [01:16] I can do the rest [01:18] brb [01:21] robert_ancell: that's hard to say with certainly. I don't think anyone has reported that unity dies because of this leak, but it certainly shows up in our valgrind logs a lot. By my estimate, at least 20% of all the leaks reported by valgrind are this pango issue [01:21] thomi, so is it worth backporting? [01:21] I think so. We should probably see what thumper thinks [01:26] oh, he's gone offline [01:27] ok, well prod him some and he can get back to me if he thinks it is worth it [01:27] it's in quantal now [01:27] and upstream accepted the patch [01:30] robert_ancell: awesome, thanks. He should be abck online soon, I'll ask him [01:46] robert_ancell: You're the proud owner of a radeon card in your devel rig, right? [01:51] robert_ancell: have you fixed that bug already? [02:06] thomas [02:06] oops, entirely the wrong window === jalcine is now known as Jacky [03:58] RAOF, nah, I got rid of that machine [03:58] robert_ancell: Ah, so you're an intel man now? Superb. [03:58] Or, indeed nouveau. Both of those have less crackful xwayland patches ;) [03:59] RAOF, so we can be blissfully unaware of problems? [03:59] No, so I can unblock you without rewriting the radeon patch first. [03:59] cool === _thumper_ is now known as thumper [06:03] good morning [06:08] hi didrocks, just the person I need :) [06:09] didrocks: http://paste.ubuntu.com/1040330/ [06:09] that's in natty [06:13] micahg: hey, this is the package sil2100 gave to you? [06:13] didrocks: yep [06:14] hum, let's see with him, when he's around [06:14] micahg: I'm not even sure what was used [06:14] micahg: has this been uploaded? [06:14] didrocks: it built fine on oneiric and precise [06:14] well, the branches are different ;) [06:15] didrocks: http://bazaar.launchpad.net/~sil2100/unity-2d/natty-security/revision/549 [06:15] micahg: thanks, I'll check with him [08:16] hey [08:18] salut seb128 :) [08:18] didrocks, lut, en forme ? [08:18] seb128: ça va bien, et toi? :) [08:18] nickel ;-) [08:23] bonjour seb128 [08:23] * pitti waves to the desk-TOP!-ers [08:23] pitti, hey, wie gehts? [08:23] gut, danke! [08:24] pitti, how is QA doing? ;-) [08:24] was a bit tired this morning, went to bed late [08:24] but the game was great to watch [08:24] pitti, 2 wins in 2 games, not bad ;-) [08:24] seb128: fairly well indeed! I'm posting my progress to G+ (QA team policy), if you are intested [08:24] seb128: I just finished my remaining "desktop backlog" work items, ported more stuff to python3 (language-selector, ubuntu-drivers-common, etc.) [08:25] great to see aptdaemon-py3 in quantal now [08:25] great [08:25] seb128: so I concentrate on the autopkgtests now [08:25] I worked on udisks2's test suite upstream, and now want to make it succeed in jenkins [08:25] it already uncovered two real and nontrivial bugs, so it's so worth having [08:25] once udisks is covered, I go "up" to gvfs [08:25] that's my current plan, anyway [08:26] seb128: yeah, Gomez is on fire :) [08:26] cool, I'm looking forward that ;-) [08:27] moin! [08:27] hey Sweetshark [08:27] hey pitti ;) [08:27] pitti, jenkins says that udisk2 testing is red? first step set it up, next step make it work...? ;-) [08:27] seb128, didrocks, pitti: heya [08:28] good morning Sweetshark [08:32] seb128: right; need to find out why "modprobe scsi_debug" fails in that VM [08:32] seb128: same problem as in the old udisks 1 adt [08:32] oh, ok [08:32] it says "memory error", but that has 4 GB of RAM === tkamppeter_ is now known as tkamppeter [09:02] mvo, mpt hello michael, is there an easy way to get a package -> application from software-center? [09:03] hey glatzor, how are you? [09:03] mvo, mpt would like to merge error notification dialogs ("your cache is broken") and resolution confirmation dialog ("do you want to remove the following packages to repair your cache?") into a single dialog [09:04] seb128, hello, I am fine! and yourself? [09:04] glatzor, I'm good thanks [09:04] glatzor: yes, you can use something like db=softwarecenter.db.database.StoreDatabase(); db.get_apps_for_pkgname("foo") and that will give you a bunch of docids that you can then use to get the real application object [09:05] glatzor, thanks for the aptdaemon SRU, could you make the bugs SRU compliant though (impact, test case, regression potential), the SRU team will not review it until that's done, they started being strict on that because we had too many SRUs not testable or tested without those infos and they were never moving to -updates [09:07] good morning desktop team [09:08] chrisccoulson, good morning firefox team ;-) [09:08] lol [09:08] chrisccoulson, how are you today? [09:09] seb128, yeah, not too bad thanks. how are you? [09:09] chrisccoulson, a bit tired but good otherwise [09:09] looking forward the end of week :p [09:09] mvo, so a possible way could be to add an optional argument to AptErrorDialog. I would like to avoid a software-center dependency on python3-gtk3widgets :) [09:09] glatzor: I'm adding testcases now if you could double check them once I'm done, that would be awsome [09:09] glatzor: haha, understandable [09:09] mvo, if the package_app_mapper is specified the error dialog will show applications instead of packages [09:10] glatzor: sounds good [09:10] glatzor: building r840 gives me test failures, that is known, right? [09:11] mvo, aptdaemon is now aware of the internet connection (a side effect of the pkcompat) so I could improve the download failed dialogs on the daemon side [09:12] mvo, 845 is the way to go [09:12] mvo, the test suite is now in a good shape. [09:13] glatzor: aha, so I was just outdated [09:13] mvo, funnily packagekit will in the futrure support parallel transactions. I think about enabling this already now in pkcompat :) [09:16] glatzor: http://paste.ubuntu.com/1040491/ is what I get from r845 in bzr-buildpackage [09:20] glatzor: I added testcases to the bugs in the SRU now, please double check if you have time [09:25] glatzor: aha, that seems to be something in quantal, looking at this now [09:25] glatzor: nothing releated to your code :) [09:26] glatzor: so are we good to upload? I will update the changelog (if you are not on it already) [09:29] mvo, should I invite ubuntu-core-dev to aptdaemon-developers? [09:29] glatzor: sounds good [09:29] glatzor: I will also fix the lintian*tags* rename in the .install file === alan_g is now known as alan_g|tea [09:36] glatzor: ubuntu-quantal branch is updated, so I can upload whenever you want [09:41] glatzor: one file overwrite issue in fake-polkit.py, so python3-aptdaemon.test and python-aptdaemon.test can not be installed at the same time, should that go to aptdaemon instead? [09:47] mvo, sorry I am away for some time. see you then [09:47] glatzor: so I fix it in whatever way I see fit? or shall I wait ;) ? [10:03] waow, crash inside the intel driver [10:04] go intel ;-) [10:05] seb128: it's all because of you! I took intel because you never had issues with it :) [10:05] I still don't have issues! ;-) [10:05] and one small crash to completely changed my mind, of course :p [10:27] hello mvo [10:27] mvo, I am on the train now so the connection could be a little bit flanky [10:27] mvo, I updated ubuntu-quantal since we can now drop the test_suite_fixes [10:28] glatzor: aha, ok [10:28] glatzor: I updated it as well :) [10:28] glatzor: so the delay from 0.5s -> 2.5s is no longer needed? [10:29] glatzor: I don't see a (new) commit in ubuntu-quantal, did you push this yet? [10:30] mvo, it is still required. But I changed it in upstream [10:31] glatzor: ok [10:31] glatzor: thanks, I updated the quantal branch to point to r846 now [10:39] seb128: https://lists.ubuntu.com/archives/technical-board/2012-June/001310.html heh, Ubuntu/Canonical will just grow itself some mor people comfortable to review LibreOffice commits ;-> [10:39] Sweetshark, lol [10:39] good luck to them ;-) [10:40] riight === MacSlow is now known as MacSlow|lunch [10:42] mvo, I haven't tried the simulate test on a build daemon. so this issue could still exist. but perhaps it was just a side effect of another patch [10:42] test [10:46] glatzor: oh, good to know, lets see [10:46] glatzor: I can alway add it back if it ftbfs [10:50] mvo, mpt, so what do you think about a aptdaemon.gtk3widgets.SmartErrorDialog ? [10:50] thanks mvo [10:53] mvo, I would like to make this re-usable by sessioninstaller and update-manager [10:57] mvo see you [11:01] oh, that gnome-settings-daemon crash is i386 only? [11:01] fun ;) [11:02] chrisccoulson, is it? [11:03] i386 users are nice people, why so much hate :p [11:03] seb128, yeah, it looks like it [11:03] indeed [11:06] ok, i'll ask for someone to get a valgrind log whilst i set up a more appropriate environment [11:06] just in case something tramples over the GOT :) [11:09] chrisccoulson, GOT? [11:09] chrisccoulson, you can grab mterry when he gets online, he was complaining about how annoying the issue is the other day [11:09] chrisccoulson, he can probably get you a valgrind ;-) [11:09] seb128, the global offset table. the GOT entry will either have a pointer back to the plt (to call in to the linker), or a pointer to the real function [11:10] but if that gets overwritten, then it will go quite wrong :) [11:10] oh ok [11:21] seb128, also, rebuilding gnome-settings-daemon with LDFLAGS=-Wl,-z,relro,-z,now would expose if the issue is memory corruption [11:22] as that would make it crash where the error occurs :) [11:36] chrisccoulson: FYI, I juts got bug #196058, had to edit the file manually to get it back to not fullscreen [11:36] Launchpad bug 196058 in thunderbird "Thunderbird starts in a full-screen mode and cannot be restored" [Undecided,Confirmed] https://launchpad.net/bugs/196058 [11:39] didrocks, oh, fun ;) [11:39] chrisccoulson: I wouldn't use that term TBH ;) [11:40] didrocks, no, i meant it is fun for me ;) [11:40] chrisccoulson: you have weird ways of enjoying bugs ;) [11:43] didrocks, heh, he was on my g-s-d plt "fun" first, keep your party for later ;-) [11:44] seb128: I don't care, I edited the file and it's fine for me. Seems the issue isn't new though (from 2008) [11:44] k ;-) [12:19] DENIED! [12:19] "PPA exceeded its size limit (4452.00 of 4096.00 MiB)" [12:21] oh, fantastic! no crash on i386 for me here ;) [12:21] i guess mterry will need to feed me information :) === MacSlow|lunch is now known as MacSlow [13:18] chrisccoulson, you got a mterry! [13:19] mterry, hey ;-) how are you ? [13:19] hi mterry! [13:19] uh oh [13:19] mterry, too late to pretend not being here :p === mterry is now known as rickspencer [13:20] lol === rickspencer is now known as mterry [13:20] What's up? [13:20] mterry, chrisccoulson is looked at the plt g-s-d issue [13:20] mterry, he needs debug infos from you [13:20] mterry, since you get the issue [13:20] seb128, ah yeah, I saw his comment go by. chrisccoulson, you want valgrind output? [13:21] mterry, yes please :) [13:21] i can't seem to recreate it here === zyga is now known as zyga-afk [13:46] mterry, are you on the valgrind thing or should I give it a try (I can but I don't want to dup work if you started) [13:46] chrisccoulson, really? interesting. I uploaded a valgrind [13:46] seb128, sorry, I got delayed, but it's there now [13:47] mterry, np, you are on i386 right? [13:47] seb128, yup [13:47] i386 4 eva [13:48] ;-) [13:48] ==26228== Invalid read of size 4 [13:48] ==26228== at 0x1027EF00: ??? (in /usr/lib/gnome-settings-daemon-3.0/libmouse.so) [13:48] ==26228== by 0x10281EC4: gsd_mouse_manager_idle_cb (gsd-mouse-manager.c:1124) [13:48] tadada [13:49] I wonder why the first frame lacks symbols when the second one has the infos [14:00] wow. as if you need more than 3 lines in order to know exactly what the problem is there [14:01] seb128, because the first frame is the plt magic. probably doesn't correspond to a given line [14:01] mterry, could be yes [14:02] desrt, the log is longer than that, I didn't want to flood the channel ;-) https://bugs.launchpad.net/ubuntu/+source/gnome-settings-daemon/+bug/1007588/+attachment/3189382/+files/valgrind.log [14:02] Ubuntu bug 1007588 in gnome-settings-daemon "[mouse]: gnome-settings-daemon SIGSEGV in gdk_device_manager_list_devices@plt()" [High,Confirmed] [14:02] seb128: i wasn't being sarcastic. totally classic class of problem [14:02] and it always has exactly one of two solutions [14:03] the problem is that someone dispatches an idle then destroys the object before the idle has a chance to run [14:03] the solutions: [14:03] 1) have the idle itself hold a ref on the object and free it from the handler function [14:03] 2) when scheduling the idle, save the source ID number and cancel it from the finalize of the object, if pending [14:04] desrt, weird think is that this issue just happens on i386 when building with gcc 4.7 [14:04] desrt, precise with gcc 4.6 with the same gtk and g-s-d has no bug [14:04] seb128: it's probably an issue on the other platforms too, but you 'get lucky' [14:04] chrisccoulson, ^ [14:04] these kinds of errors are so common all over GNOME that i'd hesitate quite a lot to finger gcc [14:06] desrt, well, we got 0 of those issues in precise, the code didn't change and we get a lot of this in quantal after a rebuild, and people said that rebuilding on gcc 4.6 "fixes" it [14:06] mterry, seb128, thanks. will look in a few moments [14:06] but yeah, maybe for some reason we get "lucky" and the code generated by gcc 4.6 is on the right side of the race :p [14:07] huh [14:07] http://git.gnome.org/browse/gnome-settings-daemon/commit/?id=e98c9079eec9cd9f6f27dd7813d96d6ba536e6c2 [14:07] ^ should have fixed that bug [14:08] desrt, I don't think this is a classic idle callback bug. It's dying in the plt code for handling shared libraries [14:08] ya... [14:08] i'm starting to agree [14:08] now that i see that the bug got fixed over a year ago [14:08] it used to be a classic idle bug ;) [14:09] ;-) [14:11] yeah, i don't think it's that either [14:11] although, i was hoping to see an invalid write in the valgrind log [14:11] damn ;) [14:12] mterry, this is easy for you to reproduce? [14:13] one more possibility [14:13] this is a plugin, right? [14:14] is it possible that the plugin is unloaded when the idle fires? [14:14] * desrt takes that back because of the proper cancelling... [14:16] chrisccoulson, every time [14:17] mterry, and the trigger is changing your monitor resolution? [14:18] chrisccoulson, no, the trigger is just doing nothing. The bug has some misleading data about monitors, but it has nothing to do with that [14:18] chrisccoulson, if I just wait a few seconds, it will crash [14:18] mterry, oh, that makes more sense [14:18] thanks! [14:18] I've been living unthemed for a while. :( [14:18] ok, i'll try again in a second [14:19] * desrt thinks chrisccoulson and mterry get to spend the next 3 days performing the fun task of reducing this crash to an irrefutable testcase to present to doko [14:20] (or finding the real bug on the way...) [14:20] heh [14:20] * chrisccoulson fires up kvm again === zyga-afk is now known as zyga [14:51] mterry, it still isn't crashing here. could you make it crash again in gdb please, and show me the output of "info registers"? :) [14:51] chrisccoulson, yup! [14:53] chrisccoulson, http://pastebin.ubuntu.com/1040903/ [14:53] mterry, thanks [14:56] oh my [14:56] ebx 0x0 [14:56] that's meant to be the base address of the got :) [14:57] i guess that's where the "invalid read at address 0x38" comes from in your valgrind log [14:57] this is going to be fun [15:05] mterry, ok, could you try again please, but this time do "watch $ebx == 0x0"? [15:05] chrisccoulson, sure [15:05] hopefully you will hit that once, be able to get a stacktrace, and when you continue you should hopefully see it crash [15:05] fingers crossed :) [15:06] ok, I hit the breakpoint [15:06] excellent [15:07] chrisccoulson, do you want a dump of registers every time I hit the watch point? [15:07] mterry, just a stacktrace. are you hitting it more than once? [15:07] i was hoping it would just be once :) [15:07] chrisccoulson, oh, I see your above comment [15:08] chrisccoulson, yah, all over the place [15:08] mterry, and it's always a different call stack? [15:09] chrisccoulson, yeah mostly [15:09] hmmm, that's a shame [15:09] chrisccoulson, I can send some of them to you? [15:09] yeah, i can take a look [15:09] thanks [15:10] chrisccoulson, http://pastebin.ubuntu.com/1040940/ [15:11] mterry, oh, of course. it might be better to first break on main, and then set up the watch [15:11] to get all of the linker stuff out of the way first :) [15:11] chrisccoulson, k, will do [15:13] chrisccoulson, now I'm going through a bunch of locale loading. hopefully it will end soon [15:13] mterry, restart it, break on main, once you hit it, add the break on ebx [15:14] that should be easier [15:14] seb128, that's what I did [15:14] setlocale is after main [15:15] parse args also does some similar things... [15:15] hmmm, that's a pain :( [15:24] mvo, do you know what glatzor meant by "aptdaemon.gtk3widgets.SmartErrorDialog"? [15:28] chrisccoulson, now I'm getting some from the plugin loads [15:33] mpt: I think he means that apps need removing when fixing broken dependencies [15:33] mpt: i.e. instead of saying "the package gedit-foo needs rmoeval" he wants to show reall appname and icon [15:35] mvo, that would be nifty. I sketched that dialog at , but showing real application names would be a great improvement. [15:35] chrisccoulson, mterry: can't you script gdb to bt, c automatically when it reach those b? [15:35] chrisccoulson, and look at the log what was the last bt before the segfault? [15:36] seb128, ooh [15:36] mterry, http://stackoverflow.com/questions/2388799/automate-gdb-show-backtrace-at-every-call-to-function-puts [15:36] I forgot gdb could do that [15:37] mterry, something like that? [15:37] yah, just a simple bt; c should do [15:37] * mterry waits for next natural break [15:39] heh, i should remember how to do that too :) [15:40] chrisccoulson, OK, commands set. It will still take some time to get results. It's really slow when it has to watch that register [15:40] yeah, i can imagine :) [15:53] * mpt wonders idly about dropping the "Statistics" tab from Software Sources [15:57] mpt, move it to the privacy panel in system settings? [15:57] seb128, ooh, good idea [16:00] If we're not careful, though, soon we'll end up with people sending their software inventory in three different ways: USC recommendations, metrics, and popcon [16:01] I wonder if that panel shouldn't be protected by your password [16:01] mpt, that's a good point, I'm not sure popcon has ever been a good metric, we should perhaps just drop it [16:01] it's likely to be a place where you note down stuff you'd rather other people not see [16:01] Laney, your keyring is not protected by your password, why would that panel be? [16:01] Laney, if somebody got physical access to your user account you are screwed anyway [16:02] Oh, not three ways. Four. With the fourth being OneConf. :-) [16:02] Laney, same for i.e your firefox passwords [16:02] I'm not talking about the sophisticated attacker here [16:02] but yes, those could be protected too [16:02] but creating a false sense of security is probably a valid argument against doing it [16:02] Laney, I don't need to be a sophisticated attacker, if I've access to your email I can read your email, user your webbrowser to connect to any of the site you stored credential for, etc [16:03] if I've access to your account* [16:03] Laney, I don't think the infos in that panel are sensitive over i.e emails [16:04] mpt, yeah, let's drop popcon ... want to email ubuntu-devel to suggest that? [16:05] mterry, is it still going? [16:06] chrisccoulson, yes [16:06] mterry, oh, i didn't expect it to take this long :) [16:06] i hope this turns out to be worthwhile [16:07] i wouldn't want to waste your time ;) [16:07] micahg, what's happening with bug 1010466? [16:07] Launchpad bug 1010466 in unity-2d "dropdown boxes on sites stop working" [Medium,In progress] https://launchpad.net/bugs/1010466 [16:07] chrisccoulson: natty didn't build, waiting to hear back [16:07] micahg, hear back from? [16:08] chrisccoulson: didrocks or sil2100 [16:08] micahg: sil2100 told me that he saw that with you [16:08] didrocks: ah, yeah, he fixed it already :) [16:09] * micahg will get that uploaded [16:09] should go out today then [16:09] thanks [16:10] seb128, yep. That would get it from four down to three. I just discussed it briefly with ev, and he has vague ideas to get from three down to one. :-) [16:58] chrisccoulson, still not done. :( [16:59] mterry, oh :( [17:00] that is taking much longer than i thought it would ;) [17:00] dconf reads also trigger the read... [17:00] the watch I mean [17:01] it's all desrt's fault! [17:01] :) [17:08] * didrocks waves good evening [17:08] * desrt wonders what's going on [17:23] desrt, don't pretend it's not your fault! ;-) [18:31] hey kenvandine , i have a friend who changed their default group to be 'users' and now empathy has write permission errors for items that allow for logging and saving connections [18:32] bug #1013921 [18:37] * kenvandine wonders where the url is from the bot [18:39] bcurtiswx, ubot2 must be upset with us [18:39] ok, so it isn't my machine.. thought it was [18:39] bcurtiswx, oh... i can't find a bug with that number [18:40] bug #1013291 [18:40] Launchpad bug 1013291 in empathy "changing users default group causes file write permissions" [Undecided,New] https://launchpad.net/bugs/1013291 [18:40] i see what I did there [18:42] file write permission errors** [18:46] oh [18:48] anyways, the user changed their default group in /etc/group to 'users' and it seems to have caused empathy issues in saving items [18:48] bcurtiswx, that is apparmor related [18:48] i don't think it is the group [18:49] it is the homedir [18:49] look at /etc/apparmor.d/tunables/home [18:50] bcurtiswx, you can edit /etc/apparmor.d/tunables/home.d/ubuntu [18:50] kenvandine, so that should be @{HOMEDIRS}=/heise1/ ? [18:50] yeah [18:51] @{HOMEDIRS}=/home/ /heise1/ [18:51] i guess [18:51] it is a space separated list [18:51] in home.d/ubuntu or just home ? [18:52] you put overrides in /etc/apparmor.d/tunables/home.d/ubuntu [18:52] ok [18:52] the packaged defaults are in the other [18:52] this is probably breaking more than telepathy [18:52] so should we worry about this not changing if a user changes their home directory and doesn't know to change anything else? [18:53] not sure what we can do to help them :/ [18:53] hmm [18:54] that just seems bad though... [18:54] brb [18:55] bcurtiswx, pretty much everything that ships an apparmor profile relies on @{HOME} [18:55] users shouldn't really change their homedir without knowing the implications... but there isn't really a good way to warn them [19:00] they used the command 'usermod' [19:02] kenvandine, you'd think if thats the case then using usermod would know to change that value as well [19:03] or warn them that it probably isn't a good idea :/ [19:05] either way there needs to be something done so basic desktop functionality isn't lost with a change of the homedir. IDK how often this happens or not though... [19:15] bcurtiswx, change user directory doesn't seem a real usecase but rather a "what can I do to break my system" thing [19:16] bcurtiswx, the users who know how to do that should know better [19:22] seb128, can't disagree, just wanted to make sure it wasn't something we should fix that we are not. [19:27] kenvandine, thanks :) [19:27] bcurtiswx, np [22:05] robert_ancell: morning [22:05] robert_ancell: how can I test out your new pango fix? [22:05] thumper, hello [22:05] thumper, install quantal? [22:05] robert_ancell: I'd like to run valgrind again and see if it is good [22:05] robert_ancell: so... about precise... [22:05] thumper, it's not too hard to do a precise package [22:06] robert_ancell: I think it would me nice to SRU, as it effects every app that uses pango to draw text [22:06] robert_ancell: which is a lot (I think) [22:06] thumper, can you write out the SRU for it? [22:06] I can see the bug, but I don't know how severe it is [22:07] hmm.. I wonder if I can convince a minion to do it :) [22:16] thumper, ok, I did all the SRU stuff in bug 837145, you just need to write the test case for it [22:16] Launchpad bug 837145 in pango1.0 "Memory leak in pango_layout_get_extents" [Undecided,Fix released] https://launchpad.net/bugs/837145 [22:17] robert_ancell: ok, thanks... I'll try to get to this this afternoon [22:31] RAOF, do you do SRUs? [22:36] robert_ancell: do you know what type of details are needed for a test-case? [22:36] so far we just use valgrind [22:40] thumper, yeah, I was just going to check with someone like RAOF how detailed they need to be. [22:40] robert_ancell: ok, cool [22:40] They normally need to be pretty clear, i.e. "run these commands" [22:40]