/srv/irclogs.ubuntu.com/2012/06/14/#ubuntuone.txt

=== _thumper_ is now known as thumper
mmccman, I really want to just get control panel to show a live panel before I go to sleep... it contacts SSO just fine but won't show the signin page06:21
mandelmorning all!08:49
JamesTaitGood morning all! :D08:53
ryeuhm... oopses?10:20
gatoxgood morning!11:09
mandelgatox, morning!11:11
gatoxmandel, hi11:11
mandelgatox, I still have to do the review, sorry I started to try to launch sd in mac and I have been seen some issues with ipc and creds..11:11
mandelgatox, so things start to go bannanas in interesting ways :)11:12
gatoxmandel, and you were expecting something else? jeje11:12
mandelgatox, no, is some what good news.. I think11:12
ralsinagoof morning!12:26
gatoxralsina, hi12:31
mandelok, lunch for me :)12:33
mandelralsina, goof goof, how let the dogs out?12:34
* facundobatista would appreciate a review on https://code.launchpad.net/~facundo/ubuntuone-client/fix-failure-handling/+merge/10969912:36
gatoxfacundobatista, i can do it12:41
facundobatistagatox, gracias12:42
gatoxfacundobatista, i'm going to try to run the tests for u1-client from trunk..... to see what happend, because i'm getting a lot of failures with yours12:55
gatoxmaybe i need to upgrade too12:55
gatoxfacundobatista, +1 (i wasn't up to date the first time i run the tests)13:26
facundobatistagatox, awesome, thanks13:26
facundobatistadobey, done! thanks13:34
=== zyga is now known as zyga-afk
alecuhello, all!13:47
gatoxalecu, hi!13:49
* mandel back!13:50
dobeyhmm. apparently need to think about goals for next april, and then cast them in virtual stone soon14:00
ralsinadobey: yes, that stone is not going to cast itself14:04
ralsinaalecu: 1-1?14:04
alecuralsina: sure! let me first pause the xcode 4.5 preview download, or we won't be able to mumble!14:05
ralsinasure14:05
ralsinadobey: looks like the certificate symlink is not a universal workaround https://bugs.launchpad.net/bugs/99732614:05
ubot5`Ubuntu bug 997326 in Ubuntu One Client "Users in Turkey can't connect due to invalid Valicert certificate" [High,Triaged]14:05
dobeyralsina: i saw that last message and have no idea what language that is or what the message is. but i can presume it is "File exists"14:06
ralsinadobey: yes, file exists, in russian14:06
* rye detected word "Russian" and no, that's not one14:16
ryeturkish14:17
alecuralsina: https://wiki.ubuntu.com/SyncMenu14:18
ryeyay, menu, with uncomprehensible [ON|||] switch...14:28
ryewhat about offline mode?14:28
dobeywhat about it?14:28
ryedobey: as in greyed-out cloud - https://wiki.ubuntu.com/SyncMenu can be in synced, syncing or error14:29
dobeywell, it better not be a cloud14:30
dobeybut aside from that, i don't know14:30
dobeyyou'll have to discuss no offline/unavailable mode with mpt i guess14:30
dobeybut indeed it does beg the question of what happens if you turn them all [||||OFF]14:31
dobeybriancurtin, ralsina: quick sanity check for https://code.launchpad.net/~dobey/ubuntu-sso-client/update-3-0/+merge/110177 ?14:36
briancurtindobey: looking14:37
briancurtindobey: approved14:47
dobeythanks14:47
=== zyga-afk is now known as zyga
mmccmorning folks. hah - I left a line of text sitting here from last night.14:50
gatoxmmcc, hi14:50
mmccI was going to say "ok, time to sleep. control panel hangs after setting the current widget to the setup wizard, which is never reflected in the UI. "14:50
mmcchi gatox :)14:50
dobeywell, guess i won't use the new mic today14:52
ralsinammcc: are we trying to start u1cp already? Whoa :-)14:54
mmccralsina: yeah, SSO works, and the main .app launches u1cp, so I figured that was the place to go next so we could build something that does something when you double-click it14:55
mmcc(which it does, now, it shows the progress overlay then goes to sleep)14:56
ralsinammcc: ok, the overlay is probably because it's trying to connect to syncdaemon which is not even starting14:57
mmccralsina: ok - thanks for the clue, I was stalled looking at the debug prints, which don't seem to mention syncdaemon. here's the current output: http://paste.ubuntu.com/1040918/14:59
gatoxteam call?14:59
mandelmmcc, can I have a re-review of https://code.launchpad.net/~mandel/ubuntuone-fsevents-daemon/add-fsevent-tests/+merge/109537 I have made all the changes you requested except those related to the mem management because with ARC release, retain, autorelease etc.. return compilation errors14:59
mmccit gets to where it should show the new account wizard, but doesn't.14:59
mmccmandel: ok, will do.14:59
ralsinainteresting14:59
mandelmmcc, I have also made the methods class methods and removed OCMock from the tests by switch method implementations using the objective-c runtime15:00
mmccmandel: have you removed OCMock completely? wow15:01
mandelmmcc, well, just form those new tests, not completely in all tests :(15:01
dobeyrye: awesome. the "ON/OFF" switches are also translated. so really fun in other languages15:01
mandelmmcc, I'll try in the next iteration, by the way, what happened with the license?15:01
mmccmandel: ah, ok. I actually thought we were OK using OCMock...15:02
mandelmmcc, no idea, that is why I'm asking :)15:02
mandelwe can talk about it over mumble15:02
mmccyup15:02
ralsinateam call, team!15:02
dobeythisfred: mumble15:03
mmccmandel: here's my credentials fix: http://paste.ubuntu.com/1040977/15:47
mmccsome of these 'windows.py' modules need to be renamed to something like 'non_dbus.py', since they're the same for mac and win15:48
mandelmmcc, I was going to say just that15:48
mandelmmcc, something like pb_credentials.py or something of the type15:48
mandelmmcc, the probably change is that we have to add a diff description of the transport, that is tcp for windows, unix domain sockets on mac15:49
mandelmmcc, lets add a bug for that, add a fix just for this and then merge it in trunk asap15:49
mmccsure.15:49
mmccyou want to add the bugs or should I?15:50
gatoxmmcc, ralsina the systemtrayicon is working on mac, just test it15:53
dobeygatox: awesome15:54
mmccgatox, how are you testing it?15:54
dobeyso we just need to clean that up to match ubuntu15:54
gatoxdisclaimer: is not working for u1 :P....... i just test it with another qt application i made15:54
gatoxso, qt supports that15:54
mmccah, ok. well, great! thanks for checking15:54
dobeyu1 is probably not working due to the other issues with starting cp at the moment15:54
gatoxdobey, right15:55
gatoxalecu, we should mumble later if you want....... i'm going to start looking at my branch and see how i can split it into pieces :P15:59
mmccmandel, I'll add bugs for the credentials dbus import error and the refactoring16:03
mmccthe refactoring to avoid naming things 'windows.py' will also need to rename a few 'test_windows' scripts, which are currently ignored on osx and shouldn't be, if they're not really specific to windows...16:03
mandelmmcc, sweet, do you want me to take care of them? I'll be leaving soon (got a python-madrid meeting) but I should have that fix early in the morning tom16:03
mandelmmcc, yes, there is a good amount of refactoring to do, is not hard but is tedious16:04
mmccI've already got the dbus import fix, I'll do that one right away. the refactoring might not be urgent?16:04
mandelmmcc, hmm we can take a look, I need to see if the transport used is correct or not16:06
mandelmmcc, I don't want to land a quick fix, trunk should be as best as we can do :)16:06
mandelis the holy grail ;)16:06
mmccmandel, right - I just made platform.credentials import windows as source on darwin too, and I thought the decision to use domain sockets was made elsewhere... but I am not sure16:07
mandelmmcc, exactly, that is what I want to check, it should be made in sso16:08
=== salgado is now known as salgado-lunch
mandelmmcc, the creds_manager is an speciallization of sso for u1 so it should be ok, but better double check16:08
mandelmmcc, and update the tests16:08
mmccmandel, yes it is - platform.credentials.windows imports get_sso_client from ubuntu_sso, which has a darwin implementation16:09
mmccso I think we're OK - client's platform.credentials.windows will end up using the domain sockets16:10
mmccon darwin16:10
mandelmmcc, ok, cool, then lets do the simple renaming in that branch and you can propose it and I'll do the review :)16:11
mmccmandel: ok, sure.16:11
dobeyoff to get lunch, bbiab16:12
* gatox lunch16:15
=== gatox is now known as gatox_lunch
mandelmmcc, once you are done with the previous review, can you take alook at https://code.launchpad.net/~mandel/ubuntuone-fsevents-daemon/improve-python-client/+merge/10892616:17
mmcc mandel, ok16:22
mmccmandel, so before I push this, what do you think about windows.py -> ipc_service.py and linux.py -> dbus_service.py ?16:24
mandelmmcc, sounds good, although, how do we name the others? just to be consistent16:24
mmccmandel which others?16:25
mandelmmcc, under platform, thereare other packages that have diff impl for windows/linux/darwin16:26
mmccmandel do you mean the tests? I'm not sure, but as dobey said a while back, maybe we should just be skipping tests for other platforms and not ignoring them in the run-tests scripts?16:26
mandelmmcc, yes, but the ipc one can be ran on all platforms16:26
mandelmmcc, the linux one is the ones to be skipped16:26
mmccyes, sorry I wasn't clear - I meant don't ignore, just skip the dbus tests on win/mac16:27
mmccalthough I guess I don't need to rename test_linux.py16:28
mmccI'll just rename test_windows so it runs on mac (and as you said it's ok if it runs on linux too)16:28
mandelmmcc, no, just leave it like that, rename the other to test_ipc_service.py and get it run on mac, windows and linux16:28
mmcctest_windows -> test_ipc16:28
mmccyep16:28
mmccbut for the other platform packages, I don't know if there's a good consistent naming. but we weren't going to make that change here anyway, right?16:29
mmccI think it'll be case by case, where if we find common implementations like this we just move away from naming them by platform, make sense?16:30
mandelmmcc, certainly, I agree 100% on not using the platform, I just wanted to make sure we are consistent in the naming16:34
mandelmmcc, I usually think, if I die, will the next poor soul to maintain this understand what I was doing? if the answer is yes, we are ok :)16:34
mmccmandel: heh. makes sense. but I'm not sure what you mean by consistent then. if we name platform/credentials/dbus_service.py because it uses dbus, how do we keep that consistent with a different platform/ submodule that is also for linux but doesn't involve dbus, for instance?16:37
mmccmandel: or do you just mean "make sure the names make sense, consistently"?16:37
mandelmmcc, the second one :)16:37
mandelmmcc, make sure it makes sense16:37
mmccmandel ok, got it! thanks for bearing with me there.16:38
mandelmmcc, I know I don't make sense some times :)16:38
mmccspeaking of consistency, in ubuntuone-client, run-mac-tests runs test_zg_listener and fails to import zeitgeist. I thought we fixed that?16:39
mandelmmcc, is a spanish thing, we don't say things, we ask questions, is weird16:39
mandelmmcc, uh, that is bad, add a other bug, fix it and propose the fis in the same branch, we can fix more than one bug if they are small16:39
mmccok, will do16:40
mandelok, EOD here I have a python-madrid meeting to go, walk dog and hope spain wins the match if not I'm sure there will be riots!16:43
ralsinamandel: buy the referee! On credit!16:44
* briancurtin coffee/lunch run, back shortly16:44
mmcclater, mandel.16:45
mandelralsina, well we have 100.000 millions, right? hehehe16:46
mmccso, have we ever really run the ubuntuone-client tests? mandel, gatox?16:46
mmccthey are emphatically not passing16:46
mandelmmcc, u1-client, no I don't think so16:46
mmccoh - I remember. we haven't, just the platform/ module16:47
mandelmmcc, u1/platform/os_helper yes, rest is not16:47
mandelmmcc, exactly :)16:47
ralsinamandel: exactly! Free money! ;-)16:50
mmcclunch17:09
=== gatox_lunch is now known as gatox
=== tetris4_ is now known as tetris4
dobeyhmm17:21
=== salgado-lunch is now known as salgado
dobeyralsina: why is https://bugs.launchpad.net/ubuntuone-control-panel/+bug/1002377 not fixed in trunk, but is marked fix committed for it?17:54
ubot5`Ubuntu bug 1002377 in Ubuntu One Control Panel stable-4-0 "Errors when failing to contact syncdaemon are cryptic" [Undecided,New]17:54
ralsinadobey: in trunk that was fixed in another way17:54
ralsinadobey: endpoints17:54
dobeyah right17:54
ralsinawe could mark it invalid on trunk since when we get to try it it didn't reproduce17:55
dobeyralsina: is it also windows-only?17:56
ralsinadobey:  yes17:56
ralsinadobey: found that it was windows-only later17:56
dobeyok17:57
=== yofel_ is now known as yofel
dobeybriancurtin, ralsina: https://code.launchpad.net/~dobey/ubuntuone-control-panel/update-3-0/+merge/11037818:14
ralsinadobey: on it18:14
briancurtindobey: looking18:15
ralsinadobey: looks ok18:18
briancurtindobey: approved18:25
dobeythanks18:25
* briancurtin brb, reboot18:25
dobeyhrmm. u1-client 3.0 is going to be a bit of pain18:32
dobeybecause of the API change issue18:33
dobeyor maybe not. duh18:35
gatoxalecu, i have this branch for review.... i'm splitting the big branch.... this one is basically some refactoring to prepare the things for later: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/darwin-fsevents-1/+merge/11038218:43
alecugatox: awesome!18:43
alecugatox: do you still want to mumble? we can do it now.18:43
gatoxalecu, no, the mumble was just to talk if you have any suggestion on how to do this, because there are several things that are really related and depend on each other, so it's kind of tricky to see how to split it..... but i'm doing it18:45
alecugatox: ok18:45
briancurtindobey: how much is left to finish the 3.0.2 release? (just trying to plan when to start the windows installer stuff)18:57
dobeybriancurtin: cp is about done, then client, and quick releases of all the other things that don't have code changes18:58
briancurtindobey: cool, thanks. let me know if you need reviews on them18:58
dobeyi will18:59
mmccI really should keep up with updates better... stalled trying to test a branch waiting for the known world to download19:11
ralsinahave to go on school run will be back soon19:12
mmccnot really stalled, doing reviews, but still. updates be slow!19:12
dobeyoh that reminds me19:13
dobeybriancurtin, ralsina: https://code.launchpad.net/~dobey/ubuntuone-client/update-3-0/+merge/11039619:38
briancurtindobey: looking19:41
ralsinadobey: looks good19:56
briancurtinsame, approved19:58
mmccbriancurtin, ralsina if you need more reviews: https://code.launchpad.net/~mikemc/ubuntuone-windows-installer/setup-mac/+merge/110155 and https://code.launchpad.net/~mikemc/ubuntu-sso-client/fix-1012837-raise-and-shine/+merge/11016720:00
mmccralsina: I know you had at least one of those already in your queue, just pinging :)20:01
ralsinammcc, briancurtin: dibs on the second one! ;-)20:01
briancurtini'm on review duty today so i'll take a look at anything20:01
mmccthanks!20:02
gatoxok, i'm leaving..... i'll keep splitting my branch tomorrow :P20:03
gatoxsee you tomorrow people!20:03
briancurtinmmcc: setup-mac is a needs fixing, but it's minor. i get dinged for it myself all the time so i'm just passing the tip along20:08
ralsinadobey: remember that problem I have with g_dbus_connection_real_closed blah blah on sso tests?20:10
mmccbriancurtin: thanks. I did not know about alphabetizing. makes some sense though. certainly any agreed-on system is better than whatever I do by default...20:11
ralsinadobey: turns out that we have a comment saying that there is a "sleep 3" in run-tests to avoid that. Maybe it's just that my disk is slo20:11
ralsinaw20:11
mmccbriancurtin: does it matter if I'm mixing "import foo" lines with "from bar import baz"? just sort by toplevel package name?20:12
dobeyi don't think the sleep avoids it. i think it just makes it so it doesn't cause the tests to break completely in tarmac20:13
mmccor can I just do M-x sort-lines and be happy? it puts "from" lines first :)20:13
dobeymmcc: "import foo" go in a block before a block of "from bar import baz"20:14
briancurtinmmcc: on top of what dobey said, another general convention (from pep 8) is to order all of the blocks by stdlib first, third-party second, then your own library stuff last20:15
dobeyalthough there are of course some weird cases where you have to deal with try/except and such; which go on their own, or similar special cases20:15
ralsinawtf, pylint is complaining about TODOs now?20:15
dobeyuh, it always has20:15
dobeybut it doesn't fail them20:16
ralsinadobey: https://pastebin.canonical.com/68168/20:16
dobeywell, u1lint doesn't20:16
dobeyralsina: yes, they get printed20:16
ralsinadobey: ok then20:16
dobeyralsina: but echo $? will be 0 unless there are other issues in there :)20:16
ralsinammcc: global +1 on the second branch20:16
mmccok, thanks guys. I guess I need M-x pep8-order-imports .. gotta be around here somewhere20:17
ralsinammcc: it only hurts when it's a new file. after that insert-sort is enough :-)20:18
ralsinaAnd what a good thing it is that mandel did not see that line20:18
dobeyi don't think we bother with the suggested multi-sort stuff from the pep20:18
ralsinaas long as it's reasonably sorted, we're ok. And stdlib / 3rd party / own imports with one line in between20:22
mmccok20:22
ralsinaEOD for me20:28
ralsinaI am going to pretend to have accidentally broken all my headsets and speakers tomorrow. See you all on IRC :-)20:29
mmccok, I just got pep8 installed on my mac, and now I've got an hour of new fixes for setup-mac :)20:30
mmccmaybe it's just the font I'm using, but I *like* spaces around keyword/parameter equalses :(20:43
alecummcc: monaco?20:48
mmccalecu, yeah monaco 10, no antialias20:48
alecummcc: probably it's because of the dpi... You now need a retina mbp :-)20:49
mmccheh, I'm sure that'd do it. I wonder how much code I could fit onscreen at 1:1 on a retina mbp20:50
dobeya lot i guess20:51
dobeywell, depending on what font size you use20:56
mmccbriancurtin - fixed the imports and many other pep8 complaints on the setup-mac branch...20:56
mmccdobey: safe to assume I'm using monaco 10pt20:56
dobeythen probably the same amount of code you fit on the screen now20:57
dobeyit would just a whole lot better20:57
briancurtinjust reading "10pt" hurt my eyes20:57
dobeyyou people and your gigantic fonts20:57
dobeyand it's really really hard to lie to osx about the screen's dpi20:58
mmccyeah, I guess it depends on how they scale fonts. they have a few modes for apps. I need to learn more. looking forward to those WWDC session videos20:58
dobeyi'm using Envy Code R 5pt in my terminals21:01
dobeyand i configured x to think the dpi is ~70 instead of ~11021:01
mmcc5pt, whee21:01
mmccI just messed around with Quartz Debug to see what the world looks like on my monitor in 144dpi. emacs was not happy21:02
dobeyheh21:02
dobeyyeah, in emacs i use 6pt21:03
mmccbeautiful big window close button, drawing half an inch into the window21:03
briancurtin14pt consolas here21:03
mmcc6pt Monaco is literally unreadable over here. might look into this envy code R tho21:04
briancurtinworks nicely with rotated monitors and guide lines at 79 char in vim and visual studio. ends up being like 85 char visible on screen21:04
mmcc85 char for the whole screen? couldn't handle that, I like a good 4-wide emacs window ;)21:06
dobeybriancurtin: for windows-installer, do we need to merge the build-out and build_installer.py related changes to -3-0 for the release?21:11
briancurtindobey: i could do without it for right now since i can create the right installer out of my trunk dev setup, but in the name of reproducability they probably should be merged21:14
dobeyok21:14
=== tetris4_ is now known as tetris4
dobeybriancurtin: https://code.launchpad.net/~dobey/ubuntuone-windows-installer/update-3-0/+merge/11042121:20
briancurtinmmcc: this is what it ends up looking like http://i.imgur.com/KXcRd.jpg - the center monitor's scrollbar is the 79 char marker so everything should fit on the screen, the right has that red marker at 7921:21
dobeythe glenlivet. mmm21:22
mmccwhat's plural of the glenlivet? glenlivets or glenslivet?21:22
briancurtindelicious21:23
dobey+121:23
mmcc"a good start"21:23
dobeyi wnat a really high res LED display21:24
dobeybut alas21:25
mmccbriancurtin: I approve of your multimonitor big fontage.21:25
mmccbut with my sickness, I would eventually have a single emacs frame spread across all of those monitors21:25
dobeyi should go to shenzen and see if i can get some company to make some as a "side project"21:25
mmccno dobey, we don't want Apple disappearing you as you stumble onto their next iMac supply chain21:31
dobeybriancurtin: does that windows installer branch look good?21:36
briancurtindobey: looking righ tnow21:36
dobeycool21:36
briancurtindobey: yeah that's fine, approved21:37
dobeythanks21:37
dobeyas soon as that lands, i can make the tarball/tag, and i think that should be all the projects needed for doing a win release21:38
briancurtinexcellent21:38
=== salgado is now known as salgado-afk
mmcchey guys, what's the story with get_ssl_context argument mismatch in ubuntuone-client/trunk ? There's a fix for that but it's not landed yet, or what?21:48
dobeymmcc: on ubuntu using nightlies?21:48
mmccon windows, sorry21:48
mmccon ubuntu using nightlies it works fine. ironed that out a few hours ago21:49
dobeyusing trunk?21:49
dobeyor the automated build? or what?21:49
mmccno, using a branch that should be up to date with trunk.21:49
mmccbut now that I've bugged you I realize I should check that, brb21:49
mmccI only made this branch today, so...21:50
dobeybriancurtin: for the automated builds, are we using seconds since epoch, or a more readable date-time stamp like 20120612121212?21:50
dobeymmcc: the fix to use the new api in client trunk landed at r125421:51
dobeywhich was on tuesday...21:52
briancurtindobey: ubuntuone-4.1-windows-installer-20120612-210451.exe is an example21:52
dobeymaybe you have an old storage-protocol then21:52
briancurtintimestamp = time.strftime("%Y%m%d-%H%M%S", time.gmtime())21:52
dobeyok, cool21:52
mmccdobey, yeah my branch is up to date with trunk. I'll check storage-protocol.21:52
mmccthanks21:52
dobeybriancurtin: ok, windows-installer 3.0.2 released/tagged21:55
dobeybriancurtin: let me know if i somehow managed to overlook a project we need a release for on win21:56
briancurtindobey: i will try to take a look shortly, if not first thing tomorrow morning (i might have to take off soon)21:57
dobeyok. i need to head off. if i did miss something, please e-mail/telegraph/whatever and i'll get it taken care of and we can get it built21:58
dobeyhave a good evening everyone21:58
briancurtinawesome, thanks21:58
mmcchey briancurtin, do I need to do a build/install step on windows for the storage-protocol? I have the version of the storage-protocol branch that fixes that get_ssl_context error, but I'm still seeing it when running tests in the u1-client branch...22:31
mmccanyway, here's the merge proposal I was trying to test: https://code.launchpad.net/~mikemc/ubuntuone-client/fix-1013261-darwins-got-credentials/+merge/11043122:34
mmccall tests pass on linux, the affected tests all pass on windows and macos. can't get all the windows u1-client tests to pass for the reason above...22:35
* mmcc needs to read the quit messages. 22:36

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!