frankban | hi gmb, would you like to review a "intuition driven: please don't ask" branch? | 11:07 |
---|---|---|
gmb | frankban, Sure :) | 11:07 |
frankban | thanks gmb: https://code.launchpad.net/~frankban/launchpad/bug-1015318/+merge/111577 | 11:08 |
gmb | frankban, I'd add a comment above the call to self.prepare() that explains why you're also prepare()ing a RevisionMailJob. Other than that it looks fine to me. | 11:11 |
frankban | gmb: ok, will do it | 11:12 |
gmb | Cool | 11:12 |
frankban | gmb: something like "Enable RevisionMailJob to let celery activate a new connection before trying to flush sent emails calling pop_remote_notifications." could work? | 11:16 |
gmb | frankban, Yep, that's fine | 11:17 |
bac | good morning my euro friends | 11:31 |
gary_poster | bac benji frankban gmb https://plus.google.com/hangouts/_/1792d88c3ec15ab46b83312c83f94ecc0c1189b1?authuser=1&hl=en-US ready when you are | 12:10 |
gmb | yarp | 12:10 |
gmb | Please stand by. G+ is having one of its scheduled madnesses. | 12:14 |
bac | http://en.wikipedia.org/wiki/Bernard_Shaw_(journalist) | 12:24 |
bac | google: cnn correspondent hides under desk | 12:25 |
* bac avoided pulling a Tycho Brahe, but just barely | 14:02 | |
frankban | gary_poster: for bug 1002820: do you remember if the new error occurred during rabbit start or stop? | 14:19 |
_mup_ | Bug #1002820: lp.testing.layers.RabbitMQLayer:setUp times out rarely/intermittently in parallel tests <paralleltest> <qa-untestable> <Launchpad itself:Fix Released by frankban> < https://launchpad.net/bugs/1002820 > | 14:19 |
gary_poster | frankban, I think it was start. Could be wrong, sorry. | 14:29 |
frankban | np | 14:29 |
bac | gary_poster: you could post a companion piece to this: http://www.omgubuntu.co.uk/2012/06/can-ubuntu-on-a-system76-laptop-meet-photographers-needs?utm_source=feedburner&utm_medium=feed&utm_campaign=Feed%3A+d0od+%28OMG%21+Ubuntu%21%29&utm_content=FaceBook | 14:31 |
bac | Can a System76 Ubuntu Laptop Meet One Developer's Needs? | 14:31 |
gary_poster | bac, :-) I saw that link from System 76, yeah. I don't want to hurt them, and right now, even if the computer came back great tomorrow, I feel I'd be generous giving them a 6/10, which is far from a recommendation. :-/ | 14:33 |
bac | gary_poster: spamaps bugs filed: https://code.launchpad.net/~yellow/charm-tools/trunk/+merge/101554 | 14:53 |
gary_poster | great bac. thank you | 14:53 |
gary_poster | benji, should I move your "init command" card to landing or are you still responding to review? | 15:04 |
benji | gary_poster: I am very close to landing, so that would be fine. | 15:04 |
gary_poster | cool thx | 15:04 |
frankban | gary_poster: could you please review https://code.launchpad.net/~frankban/launchpad/bug-1002820-again-and-again/+merge/111608 ? | 15:13 |
frankban | I am testing the new egg in ec2 | 15:14 |
gary_poster | frankban, approved, thank you | 15:19 |
frankban | gary_poster: thanks, what do you think about giving another chance to bug 1011847 too? that test is sick and tired, and maybe wants to be killed, but... | 15:29 |
_mup_ | Bug #1011847: lp.services.webapp.tests.test_error.TestDatabaseErrorViews.test_disconnectionerror_view_integration fails intermittently/rarely in parallel tests <paralleltest> <qa-untestable> <Launchpad itself:Fix Released by frankban> < https://launchpad.net/bugs/1011847 > | 15:29 |
gary_poster | frankban, ok, sure, one more whirl in that direction. :-) | 15:31 |
gary_poster | frankban, that change will affect both of the failing lib/lp/services/webapp/tests/test_error.py tests right? | 15:45 |
frankban | gary_poster: yes | 15:48 |
gary_poster | cool frankban approved thank you | 15:49 |
benji | I'm going to have thunderstorms rolling through here for the next couple of hours, so if I get disconnected, that's why. | 18:08 |
gary_poster | bac, btw I understood from flacoste that diogo might be able to quickly help with jenkins too if we need it. apparently there is a qa lab that we can get quick turn-around on. | 18:58 |
gary_poster | when you talk to him it might be nice to get some details | 18:59 |
bac | gary_poster: excellente | 18:59 |
gary_poster | but low priority | 18:59 |
gary_poster | yeah | 18:59 |
bac | due to his globe-trotting ways it'll have to be monday morning. i'll email him now to give him a heads up so we can connect early. | 18:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!