| === cyphermox is now known as cyphermox_ | ||
| === cyphermox_ is now known as cyphermox | ||
| emdub | cjwatson: do you know if #855921 was supposed to be resolved in precise? i am seeing the same bug in 12.04-server. | 04:58 |
|---|---|---|
| xnox | bug 855921 | 08:11 |
| ubot2 | Launchpad bug 855921 in netcfg "does not honor netcfg/choose_interface in preseed" [Undecided,Confirmed] https://launchpad.net/bugs/855921 | 08:11 |
| bdmurray | ev: bug 1018032 might be worth looking at | 16:16 |
| ubot2 | Launchpad bug 1018032 in apport "Unable to file crash report in Quantal" [Undecided,New] https://launchpad.net/bugs/1018032 | 16:16 |
| ev | bdmurray: yeah, a few people have pointed that out. Haven't had a chance to look at it yet. Unrelated to errors.ubuntu.com (it refers to Launchpad as a crash database), but I'll see what I can come up with if pitti doesn't beat me to it. | 16:17 |
| CIA-12 | ubiquity: stgraber * r5523 ubiquity/ubiquity/ (nm.py plugins/ubi-wireless.py): Merge fix for bug 929092 by James M. Leddy | 21:33 |
| ubot2 | Launchpad bug 929092 in oem-priority/quantal "ubiquity crashed with DBusException in call_blocking(): org.freedesktop.DBus.GLib.UnmappedError.NmSettingWirelessSecurityErrorQuark.Code1: Failed to determine AP security information" [Critical,Confirmed] https://launchpad.net/bugs/929092 | 21:33 |
| stgraber | hmm, looks like we no longer run pyflakes? Merging that branch pyflakes actually found an unused import in ubi-wireless that's been there for a little while | 21:34 |
| cjwatson | We certainly do | 21:35 |
| CIA-12 | ubiquity: stgraber * r5524 ubiquity/ubiquity/plugins/ubi-wireless.py: Unused import | 21:35 |
| cjwatson | clean: check | 21:35 |
| cjwatson | and | 21:35 |
| cjwatson | check: | 21:35 |
| cjwatson | ... | 21:35 |
| cjwatson | ./tests/run-pyflakes | 21:35 |
| stgraber | stgraber@castiana:~/data/code/ubiquity/ubiquity$ tests/run-pyflakes | 21:36 |
| stgraber | stgraber@castiana:~/data/code/ubiquity/ubiquity$ pyflakes ubiquity/plugins/ubi-wireless.py | 21:36 |
| stgraber | ubiquity/plugins/ubi-wireless.py:33: 'nm' imported but unused | 21:36 |
| stgraber | stgraber@castiana:~/data/code/ubiquity/ubiquity$ | 21:36 |
| stgraber | oh, it's in .excludes... wondering why... | 21:37 |
| stgraber | ev added it to the exclude list, though AFAICS, pyflakes is actually right, nm isn't used in __init__ | 21:38 |
| cjwatson | eh, must have made sense at one point | 21:38 |
| stgraber | yeah... anyway, will drop it from the exclude list too then | 21:39 |
| cjwatson | I wonder if there was something about importing the module having side-effects | 21:39 |
| CIA-12 | ubiquity: stgraber * r5525 ubiquity/tests/pyflakes.exclude: Drop ubi-wireless from pyflakes exclude list | 21:39 |
| cjwatson | Which it does seem to, although I don't know if they're relevant | 21:39 |
| cjwatson | It registers the NetworkManagerWidget type | 21:40 |
| cjwatson | Which is used by the wireless UI. I think you may be incorrect to remove it | 21:40 |
| cjwatson | But it could use a comment! | 21:40 |
| stgraber | sounds like it, will revert my change and add a comment :) | 21:40 |
| cjwatson | Maybe something should artificially reference something in the module as a neater way to silence pyflakes | 21:41 |
| cjwatson | Also, is ~/data/code/ just to mess with people's heads when you paste something? | 21:42 |
| infinity | cjwatson: Where does your build junk live? | 21:43 |
| cjwatson | ~/src/ubuntu/ | 21:43 |
| infinity | ~/build/$project is vaguely a standard in my house. | 21:43 |
| CIA-12 | ubiquity: stgraber * r5526 ubiquity/ (tests/pyflakes.exclude ubiquity/plugins/ubi-wireless.py): Turns out, this 'unused' import is actually required to register NetworkManagerWidget. Revert last two commits and add a comment to ubi-wireless. | 21:43 |
| CIA-12 | ubiquity: stgraber * r5527 ubiquity/debian/changelog: Add missing changelog entry for James' change. | 21:46 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!