| ajmitch | well that's a bit large to review - someone submitted mozilla seamonkey to the ARB | 05:10 |
|---|---|---|
| ersi | how nice | 05:30 |
| dholbach | good morning | 07:04 |
| dholbach | ajmitch, did you see the merge proposal from mhall119? looks like he perfected the dir() usage :) | 07:39 |
| dholbach | mhall119, in http://bazaar.launchpad.net/~ubuntu-app-review-contributors/arb-lint/trunk/view/head:/lint/sourcepackage.py#L28 I thought I would be able to get rid of lines 28-29 now, but that doesn't seem to work | 08:04 |
| dholbach | ajmitch, highvoltage, wendar: do you think we can add some examples to https://wiki.ubuntu.com/AppReviewBoard/AppsSprint? | 08:08 |
| dholbach | I think it's the only bit we still need to do to announce the initiative | 08:08 |
| dholbach | ajmitch, wendar, stgraber, any suggestions for tests we should be adding to arb-lint? I just added something about debian/copyright and DEP5 | 08:25 |
| dholbach | I might need help for a proper test of what's allowed and what's not allowed in/outside /opt | 08:26 |
| dholbach | https://wiki.ubuntu.com/AppReviewBoard/Review/Guidelines might have to be updated for precise | 09:48 |
| dholbach | ajmitch, wendar, highvoltage, stgraber: I just filed a couple of bugs on arb-lint: https://bugs.launchpad.net/arb-lint - some of them should probably quite easy to fix | 09:54 |
| dholbach | it's what I teased out of the guidelines which might make sense to test | 09:54 |
| ajmitch | dholbach: looks like you've been very busy | 10:50 |
| * ajmitch was just looking through the code, will have to leave comments on it tomorrow | 10:59 | |
| dholbach | ajmitch, a bit here and a bit there | 11:05 |
| dholbach | ajmitch, wendar, highvoltage, stgraber, mhall119, james_w, achuni: if you have a little bit of time, please let me know what you think: http://daniel.holba.ch/temp/apps-sprint.html :) | 12:21 |
| mhall119 | dholbach: re http://bazaar.launchpad.net/~ubuntu-app-review-contributors/arb-lint/trunk/view/head:/lint/sourcepackage.py#L28, why would you get rid of line 28 and 29? | 12:53 |
| dholbach | mhall119, I thought the new mechanism wouldn't run a method twice even if it was required in multiple places | 13:40 |
| highvoltage | dholbach: nice post | 13:41 |
| dholbach | highvoltage, cool - I was just wondering if I was missing anything | 13:42 |
| highvoltage | well, there's quite a bit I need to absorb myself. I still haven't tried pkgme, the apps-brancher or arb-lint. so it's kind of nice as a summary of some of the things I still need to do, too :) | 13:44 |
| dholbach | hah, great | 13:44 |
| dholbach | highvoltage, these are the tests which arb-lint already has: http://paste.ubuntu.com/1066031/ | 13:44 |
| dholbach | so there's still a bit to do, but when I ran it on a couple of apps it already gave me a few things which could/should be fixed | 13:45 |
| highvoltage | nice | 13:45 |
| dholbach | highvoltage, I was wondering if for the apps sprint we should use something like Trello to organise who's working on what and in which state it is | 13:46 |
| dholbach | I like how it's very visual and you see everything at a glance | 13:46 |
| dholbach | but I wouldn't want to impose some new tool on everybody, especially if myApps already handles different kinds of queues | 13:47 |
| mhall119 | dholbach: it won't run it twice when doing dependency resolution | 13:54 |
| mhall119 | dholbach: but it will still run it twice if some other code calls it | 13:54 |
| dholbach | hum, let me try again then | 13:54 |
| mhall119 | so if you call find_B, and find_B has @requires('field_A'), it will call find_A() | 13:55 |
| mhall119 | if you call find_C(), and find_C() also @requires('field_A'), it won't call it again | 13:55 |
| mhall119 | but, if you call find_A(), it won't stop that call from going through | 13:56 |
| dholbach | mhall119, try http://paste.ubuntu.com/1066048/ with trunk | 13:56 |
| dholbach | it gets called twice | 13:56 |
| mhall119 | right | 13:57 |
| mhall119 | it's called one because it's required by another function | 13:57 |
| mhall119 | then your test.py code is calling it again, because it starts with find_ | 13:57 |
| dholbach | huuuuuuuuuum | 13:57 |
| dholbach | hrmhrmhrmhrmhrm | 13:57 |
| dholbach | it'd be nice if it'd just get called once :) | 13:58 |
| mhall119 | I can make it avoid calling it again, even when other code tries to call it directly | 13:58 |
| dholbach | then test.py would need to be cleverer | 13:58 |
| dholbach | mhall119, did the blog post look alright to you? | 14:04 |
| mhall119 | dholbach: yeah | 14:05 |
| mhall119 | sorry, I thought I mentioned that | 14:05 |
| dholbach | cool thanks | 14:05 |
| dholbach | no worries | 14:05 |
| mhall119 | np | 14:05 |
| mhall119 | dholbach: I think we should have a "how to join and what to do" blog post for the ARB helpers team | 14:05 |
| dholbach | yep, although I think I'd prefer it if somebody from the ARB would write it | 14:06 |
| mhall119 | then spam the heck out of it to get volunteers in | 14:06 |
| dholbach | as I'm still not 100% sure how everything works :) | 14:06 |
| dholbach | coolbhavi, what do you think of http://daniel.holba.ch/temp/apps-sprint.html? | 14:17 |
| coolbhavi | dholbach, I cant think of a better way of explanation :) It looks great! | 14:19 |
| dholbach | awesome, thanks | 14:20 |
| mhall119 | 34 apps that I know of being written for the showdown contest | 14:39 |
| vibhav | wow | 14:39 |
| vibhav | Many of my friends to came to know about this contest | 14:39 |
| mhall119 | make that 35, just got another one :) | 14:40 |
| dholbach | ajmitch, coolbhavi, highvoltage, stgraber, wendar: we will have to fix https://bugs.launchpad.net/apps-brancher/+bug/1019300 quite soon | 14:41 |
| wendar | dholbach: ? | 14:45 |
| dholbach | wendar, which point are you wondering about? I think I mentioned you a couple of times in the last few lines :) | 14:45 |
| wendar | apps brancher? It's still experimental, so are bugs worth pinging everyone about? | 14:46 |
| wendar | signal-to-noise ratio | 14:47 |
| wendar | dholbach: a very cool idea, btw :) | 14:48 |
| dholbach | sorry about that - I just thought that it'd provide a very simple way to get all apps (no matter if they're branches, in PPAs or tarballs) in a consistent way and it'd make sense for the app showdown | 14:48 |
| dholbach | but feel free to ignore the ping | 14:49 |
| wendar | dholbach: it's a cool tool | 14:50 |
| wendar | dholbach: well, I haven't used it yet, but I like the potential | 14:51 |
| wendar | dholbach: have you been granted permission to do ARB stuff on work time now? | 14:55 |
| wendar | dholbach: if so, I could set you some assignments, structure your time for maximum impact | 14:55 |
| dholbach | it might be good to discuss on the mailing list what needs to be done most importantly | 14:58 |
| wendar | dholbach: app triage, app fixing, app review, app voting | 15:04 |
| wendar | dholbach: the developer's experience on their way through the review process is the top priority, and responsiveness is the key to that | 15:04 |
| wendar | dholbach: it's actually pretty simple, it just requires an investment of time | 15:05 |
| wendar | dholbach: so if you have time, we'll happily use it :) | 15:07 |
| dholbach | right, that's why I felt the apps-brancher and arb-lint would help being more responsive - also I put up a few apps for vote | 15:08 |
| wendar | dholbach: much appreciated | 15:08 |
| wendar | dholbach: and apologies that I still haven't had time to look at either of the tools, or review the apps up for vote | 15:09 |
| coolbhavi | dholbach, same here I have it on my todo this weekend | 15:09 |
| dholbach | don't worry - it happens to all of us every other time | 15:09 |
| coolbhavi | wendar, hey | 15:10 |
| wendar | hi coolbhavi | 15:10 |
| wendar | dholbach: I might look at restructuring my time so that I only review votable apps, once we have enough arb-helpers | 15:10 |
| wendar | dholbach: the problem now is that there's not really much I can do in a 2 hour snippet of time | 15:11 |
| coolbhavi | wendar, I'm sorry that m not attending ARB meetings of late as 21 UTC would be like early morning 02.30 here | 15:11 |
| wendar | dholbach: at least, not when I'm trying to tend the queue | 15:11 |
| wendar | coolbhavi: no worries, we changed the schedule because of other conflicts, knowing that no time would work for everyone | 15:12 |
| dholbach | I hope we can get some new reviewers through the Apps Sprint | 15:12 |
| wendar | coolbhavi: but, I hope you'll be able to make some of the times next week | 15:12 |
| wendar | coolbhavi: even if it's only an hour or two sometime during the few days | 15:13 |
| coolbhavi | wendar, sure! I am actually looking forward to the app sprint | 15:13 |
| wendar | dholbach: yes, and we also need to find a good way to be more engaged with the arb-helpers who already volunteered | 15:13 |
| wendar | dholbach: we haven't really established a good workflow there, to let them feel confident that they know what to pickup next and work on | 15:14 |
| dholbach | absolutely - I hope that training will work well there | 15:14 |
| dholbach | yes | 15:14 |
| vibhav | What exactly is the app sprint? | 15:26 |
| mhall119 | vibhav: http://daniel.holba.ch/temp/apps-sprint.html | 15:29 |
| PaoloRotolo | Hi all! | 15:39 |
| wendar | Hi PaoloRotolo | 15:44 |
| PaoloRotolo | wendar, Hi! | 15:45 |
| dholbach | who can punt the PDF submissions into the other queue? (Revista Espírito Livre) | 16:13 |
| dholbach | also the Ubuntistas magazine | 16:13 |
| stgraber | I can do that | 16:14 |
| dholbach | when I looked the queue, I wondered if https://myapps.developer.ubuntu.com/dev/apps/1081/ shouldn't be rejected as it looks to be a fork of chromium (not sure though), but with 37M very likely not in an 'app format' | 16:14 |
| stgraber | dholbach: moved all the "Revista Espírito Livre" to commercial, let me know if you spot more | 16:19 |
| dholbach | stgraber, https://myapps.developer.ubuntu.com/dev/apps/1074/ | 16:20 |
| stgraber | gone | 16:21 |
| dholbach | great | 16:21 |
| dholbach | stgraber, what do you think about https://myapps.developer.ubuntu.com/dev/apps/1081/? | 16:22 |
| stgraber | dholbach: well, no source provided to start with and even if they did provide the source, it'd likely be way too big for ARB | 16:23 |
| dholbach | yes, that's what I thought too, plus it's likely a fork | 16:24 |
| dholbach | should it just be rejected? | 16:24 |
| dholbach | with a pointer to https://wiki.ubuntu.com/UbuntuDevelopment/NewPackages maybe? | 16:24 |
| stgraber | I can move to commercial as it seems to be developed by a company but I doubt anyone wants another copy of webkit :) | 16:25 |
| stgraber | TBH, I wouldn't even let that thing in the archive | 16:25 |
| stgraber | we have enough copies of webkit that it's causing us problems updating them all every month or so already | 16:26 |
| dholbach | shall I add a standard reply for "huge apps"? | 16:27 |
| dholbach | maybe something like this: "We are sorry to inform you that this app is outside the scope of the App Review Board. Our focus is on lightweight apps. We are generally looking for the kind of apps which could be reviewed for functionality and security in about an hour reading through the code. https://wiki.ubuntu.com/UbuntuDevelopment/NewPackages might suit you better. | 16:27 |
| dholbach | " | 16:27 |
| dholbach | wendar, ^ do you think this might work for huge apps - if so I'd add it to the wiki and arb-lint as a canned response | 16:28 |
| stgraber | +1 | 16:28 |
| dholbach | ok, put onto the wiki and arb-lint | 16:36 |
| dholbach | and with that I think I call it a day - it's definitely time for dinner over here :) | 16:36 |
| dholbach | have a great weekend everyone | 16:36 |
| stgraber | thanks, you too | 16:36 |
| dholbach | :) | 16:36 |
| wendar | ajmitch: meeting time? (or, am I off in time-zone?) | 21:01 |
| ajmitch | yes, sorry I got distracted fora few minutes :) | 21:02 |
| ajmitch | highvoltage, stgraber: arb meeting ping | 21:03 |
| highvoltage | ah right. the 5pm on a friday meeting | 21:03 |
| highvoltage | hi everyone! | 21:03 |
| ajmitch | yeah, sorry about the time | 21:04 |
| highvoltage | I guess it's worse for you anyway :) | 21:04 |
| stgraber | hello (pretending I didn't completely forget about the meeting) | 21:04 |
| ajmitch | <-- #ubuntu-meeting | 21:04 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!