mmcc` | I'll just leave this question here for tomorrow: does anyone test the sso client on windows from the command line? I made changes to get_activation_cmdline to use the buildout python to run subprocesses during development, and was looking to see if similar changes were necessary for windows, but it looks like it'll always look in the registry for the path to the subprocess, which means that I can't run eg. ubuntu-sso-login-qt from | 06:29 |
---|---|---|
mmcc` | command line on windows. Am I missing something? | 06:29 |
=== mthaddon` is now known as mthaddon | ||
JamesTait | Happy Friday, folks! :-D | 08:53 |
Myrtti | yay Friday \o/ | 08:59 |
gatox | good morning! | 11:16 |
alecu | holas! | 12:13 |
gatox | alecu, buenas | 12:17 |
rye | ralsina: do you happen to know who is our contact in Tomboy project? | 12:22 |
czajkowski | aloha | 12:26 |
alecu | rye: I think it is Sandy Armstrong | 12:33 |
dobey | rye: sandy is the only person i know that really works on it; though not sure how much anyone hacks on it any more | 12:50 |
dobey | czajkowski: can't say aloha. it's too early for me to drink my lovely hawaiian beer | 12:51 |
czajkowski | dobey: never too early! | 12:51 |
czajkowski | dobey: oh but as you're alive! how do I snyc my tomboy notes up now ? | 12:52 |
dobey | czajkowski: what do you mean? tomboy should sync the notes just fine, the same way it always has | 12:52 |
czajkowski | hmmm | 12:54 |
ralsina | rye: nope | 12:54 |
ralsina | rye: we have not had one in a long time, I think. As in "before I joined" | 12:55 |
dobey | well, we never really had a specific "official" contact in tomboy afaik | 12:56 |
czajkowski | dobey: just checked nope my notes don't go to U1 any more :S any idea what I need to do ? | 13:31 |
dobey | czajkowski: i have no idea. check your configuration? run it in a terminal with "tomboy --debug" perhaps? | 13:33 |
czajkowski | dobey: http://pastebin.ubuntu.com/1066018/ | 13:35 |
czajkowski | c | 13:36 |
dobey | that looks ok i guess. is the configuration correct? | 13:37 |
alecu | ralsina, all: it seems my isp has left me marooned again today. | 13:38 |
alecu | ralsina: is it working fine for you? | 13:38 |
ralsina | alecu: internet? Yes, but I am not in telecentro :-) | 13:39 |
alecu | and just as I said so, my modem has upstream again. | 13:39 |
dobey | czajkowski: rye is probably a better person to help with that though :) | 13:42 |
rye | czajkowski: reading | 13:50 |
rye | czajkowski: could you please try syncing and see whether that prints anything? | 13:50 |
czajkowski | rye: dobey sorry was helping someone else. | 13:53 |
czajkowski | rye: won't let me sync it http://twitpic.com/a1unrn/full | 13:53 |
rye | czajkowski: uhm... Local Folder? | 13:54 |
rye | czajkowski: that's not Ubuntu One service, are you sure? | 13:54 |
dobey | rye: notice it's disabled | 13:54 |
dobey | rye: she can't select any service | 13:54 |
dobey | seems like possibly a tomboy issue though, and nothing to do with u1 | 13:55 |
czajkowski | :( | 13:55 |
czajkowski | dobey: dont say it's so I've more of a chance of getting it fixed if it's U1 | 13:55 |
rye | dobey: yes, disabled, but to switch to another method one needs to clear | 13:58 |
rye | czajkowski: what happens when you synchronize with the current settings? | 13:59 |
czajkowski | rye: http://twitpic.com/a1uree/full | 14:00 |
rye | czajkowski: uhm, you are syncing with local folder, not Ubuntu One | 14:05 |
czajkowski | it wont let me select U1 | 14:05 |
rye | czajkowski: what do you mean "it won't let me" - disabled menu? Then you will need to "Clear" the sync state before switching | 14:06 |
rye | czajkowski: also, bug https://bugs.launchpad.net/ubuntu/+source/tomboy/+bug/1019256 | 14:06 |
ubot5 | Ubuntu bug 1019256 in tomboy (Ubuntu) "Tomboy should trim trailing "/" in WebSyncPreferencesWidget" [Undecided,New] | 14:06 |
rye | czajkowski: so in order to switch you will need to use https://one.ubuntu.com/notes as the URL, without the trailing slash (or install updated tomboy with the patch which I haven't yet published anywhere) | 14:07 |
czajkowski | awwwww | 14:08 |
* czajkowski hugs rye | 14:08 | |
czajkowski | beers for you | 14:08 |
=== zyga is now known as zyga-food | ||
dobey | ralsina: cmake2 is merged! :) | 14:29 |
ralsina | dobey: yay! | 14:31 |
ralsina | dobey: cmake3 needs reviews then ;-) | 14:31 |
dobey | yeah i know :) | 14:32 |
ralsina | dobey: and then I can wash my eyeballs from that kind of thing for a while | 14:32 |
mmcc` | Good morning folks, let's have a random Alan Perlis quote: "Prolonged contact with the computer turns mathematicians into clerks and vice versa." | 14:37 |
=== mmcc` is now known as mmcc | ||
ralsina | mmcc: good morning. And good quote :-) | 14:41 |
* ralsina is now very far on the clerk side of the axis | 14:42 | |
dobey | stop trolling! | 14:43 |
ralsina | dobey: I stopped! | 14:50 |
ralsina | Why do I have Iain Lane's objectives up for review???? | 14:51 |
dobey | lol | 14:52 |
ralsina | Oh, I love allhand's things that look like buttons, but where you have to click on the letters | 14:52 |
ralsina | eric, rejected, let's see what happened. Are you fired now? | 14:52 |
dobey | also the channel mismatches | 14:53 |
thisfred | ralsina: yay, early weekend! | 14:53 |
ralsina | Oh, he's on "desktop" and allhands has him filed on the wrong team. Fun. | 14:53 |
dobey | ralsina: i guess you should give him some objectives. maybe he can do python3! :) | 14:54 |
dobey | twisted needs lubbins | 14:54 |
thisfred | that'd be a fantastic idea. If you let me port twisted to python 3, I can guarantee I'll run it into the ground for good. | 14:55 |
thisfred | ralsina: I'm on a team? :( | 14:56 |
thisfred | :) | 14:56 |
ralsina | thisfred: you are in two! | 14:56 |
thisfred | w00t | 14:56 |
thisfred | twice the meetings! | 14:56 |
ralsina | thisfred: but we are selling you to a Belgrade team for rights to the churro stand and a ball to be named later. | 14:57 |
mmcc | so does anyone actually run the windows SSO client from the command line, eg. for testing? | 14:57 |
ralsina | mmcc: good question. I am guessing no. | 14:57 |
mmcc | ralsina: so am I, because it might have never worked | 14:57 |
thisfred | ralsina: at least I'll get to play | 14:57 |
ralsina | mmcc: but u1cp starts it and it works then ;-) | 14:58 |
briancurtin | mmcc: only when i really need to, which isn't often. otherwise i just let the SSO from the latest release run | 14:58 |
mmcc | ralsina: yes it should - the only way it knows how to find the path to the SSO backend is using the registry | 14:58 |
mmcc | whic is why I asked | 14:58 |
mmcc | briancurtin: that makes sense. have you needed to since I joined and mandel did the tcpactivation refactoring? | 14:59 |
ralsina | mmcc: there should be a last resort which is "starting the binary from the same place where the sso binary is" | 14:59 |
briancurtin | mmcc: not sure | 14:59 |
ralsina | or rather, where the u1cp binary is | 14:59 |
briancurtin | pretty likely since you joined, no idea about tcpactivation | 14:59 |
mmcc | ralsina: agreed. that's what it does for finding the other binaries, but tcpactivation has a different code path | 14:59 |
ralsina | mmcc: oh, free inconsistencies. Fun. | 15:00 |
thisfred | me | 15:00 |
dobey | thisfred: it's always about you, isn't it | 15:00 |
mmcc | heh | 15:00 |
thisfred | solipsism is the only reasonable stance | 15:00 |
mmcc | me | 15:00 |
dobey | me | 15:01 |
briancurtin | ah crap, typing now | 15:01 |
gatox | me | 15:02 |
briancurtin | me | 15:02 |
ralsina | me | 15:02 |
alecu | me | 15:03 |
dobey | thisfred: go | 15:03 |
thisfred | DONE: Bug #999029 TODO: objectives | max document size implementation (no bug yet) BLOCKED: no NEXT: mmcc | 15:03 |
mmcc | DONE: dev path fixes, packaging fixes, fixed bug 1018125 | 15:03 |
mmcc | TODO: more path fixes, land said fixes, send a .app to ralsina | 15:03 |
mmcc | BLOCK: no | 15:03 |
mmcc | NEXT: DOBEY | 15:03 |
ubot5 | Launchpad bug 999029 in U1DB "make test suite cleaner for no c_backend_wrapper" [Low,In progress] https://launchpad.net/bugs/999029 | 15:03 |
ubot5 | Launchpad bug 1018125 in Ubuntu One Client "u1sdtool and ubuntuone-syncdaemon import gireactor,dbus when platform != win32" [Medium,Confirmed] https://launchpad.net/bugs/1018125 | 15:03 |
dobey | DONE: team call, chat with mvo about gtk sso move, tarmac tweaks, cmake2 review, started 3.0.2 SRUs | 15:03 |
dobey | TODO: objectives, reviews, finish 3.0.2 SRUs, poke at some bugs | 15:03 |
dobey | BLCK: None. | 15:03 |
dobey | gatox: go | 15:03 |
gatox | DONE: | 15:03 |
gatox | Reviews and Refactor (see the pattern? :P) | 15:03 |
gatox | TODO: | 15:03 |
gatox | Finish with tests refactoring TODAY. objectives | 15:03 |
gatox | BLOCKED: | 15:03 |
gatox | No | 15:03 |
gatox | briancurtin, go | 15:03 |
briancurtin | DONE: python 3, read up on unicode, started the unicode changes branch | 15:03 |
briancurtin | TODO: fix up a few branches, push on with unicode | 15:03 |
briancurtin | BLOCKED: no | 15:03 |
briancurtin | NOTE: doctors appt this afternoon so i will need to shift some time around. i'll probably be gone for a while in my afternoon but stick around through early evening | 15:03 |
briancurtin | NEXT: ralsina | 15:03 |
ralsina | DONE: merged cmake2, proposed cmake3, carefully avoiding doing a cmake4, team call, 1-1s TODO: fix a bug, lots of emails tell you all to DO YOUR OBJECTIVES (done now) BLOCKED: no NEXT alecu | 15:04 |
alecu | DONE: team hangout with hats, reviews, played with the t3k branch | 15:04 |
alecu | TODO: objectives, more t3k | 15:04 |
alecu | BLOCKED: no | 15:04 |
ralsina | comments? | 15:04 |
ralsina | DO YOUR OBJECTIVES? | 15:04 |
ralsina | Talk to me if you don't know what to do about them | 15:04 |
thisfred | that would be me | 15:05 |
* ralsina opens the guinness book of world records and starts assigning at random | 15:05 | |
gatox | jjajaja | 15:05 |
ralsina | thisfred: "walk more than 2.3 miles holding a raw egg in a small spoon" | 15:05 |
dobey | 1) be taller. 2) be a shot caller. 3) be a baller. | 15:05 |
dobey | done! | 15:05 |
* alecu picks "grow the longest beard" | 15:05 | |
thisfred | I'm pretty good at chugging beer, and eating biscuits and whistling | 15:05 |
ralsina | thisfred: at the same time? impressive! | 15:06 |
briancurtin | how and where do we do these objectives? "all hands" something? | 15:06 |
ralsina | briancurtin: allhands.canonical.com | 15:06 |
mmcc | objective: c | 15:06 |
thisfred | hehe | 15:06 |
dobey | i guess nobody got my joke | 15:07 |
alecu | mmcc: lolz | 15:07 |
alecu | dobey: sorry, no :-( | 15:07 |
briancurtin | i got that one | 15:07 |
thisfred | dobey: well, i got the song quote | 15:07 |
ralsina | dobey: the ship has sailed on be taller for all of us | 15:08 |
mmcc | ralsina: not me I sleep upside-down | 15:08 |
thisfred | we can make it a stretch goal | 15:08 |
ralsina | dobey: and I have not seen mike, but only thisfred and brian can claim to have succeeded | 15:08 |
thisfred | instantdrumroll.com | 15:08 |
mmcc | thisfred: BOOM | 15:08 |
ralsina | why on earth are objectives due on a saturday? | 15:08 |
briancurtin | oh man we have to give target dates? | 15:08 |
alecu | I think now I do: "Lil Troy---Wanna be a baller" | 15:09 |
thisfred | briancurtin: target date is april 2013 | 15:09 |
ralsina | briancurtin: april 2013 is good for that, unless you really expect to achieve something earlier | 15:09 |
gatox | ralsina, so everyone who forgot to do it during the week, can do it :P | 15:09 |
thisfred | alecu: no that's not it, I think | 15:09 |
gatox | (like me) | 15:09 |
briancurtin | i was going to put them all on christmas day, as presents to the team | 15:09 |
ralsina | You guys *can* set things to earlier dates if you feel ambitious | 15:09 |
thisfred | alecu: skee-lo | 15:09 |
ralsina | but I have to *approve* them by tomorrow. I am not approving on saturday, people | 15:09 |
dobey | why oh why am i not getting any audio out of flash/html5 :-/ | 15:10 |
gatox | ok, lunch for me! | 15:10 |
=== gatox is now known as gatox_lunch | ||
dobey | "survive the return of quetzlcoatl" | 15:10 |
dobey | really, that's my only goal for this year. well that, and go see The Hobbit. they happen at roughly the same time | 15:11 |
thisfred | learn to pronounce quetzlcoatl | 15:11 |
ralsina | thisfred: it sounds just like it's written | 15:12 |
thisfred | create new meme: lol-axolotls | 15:12 |
thisfred | oh, too late http://cheezburger.com/1563258112 | 15:13 |
thisfred | climb popocatepetl | 15:14 |
ralsina | thisfred: climbing active volcanos is bad. Specially if you carry an axolotl | 15:14 |
thisfred | Well I would have it carry me, but it'd probably walk right into the volcano mouth, with its lack of eyesight | 15:15 |
thisfred | axolotl, the other white meat | 15:17 |
alecu | crap, that's an ugly animal. | 15:24 |
dobey | why do credit card companies always make it so hard to close an account | 15:25 |
ralsina | dobey: should be obvious | 15:25 |
dobey | s/obvious/illegal/ | 15:25 |
dobey | well, time to get lunch | 15:28 |
dobey | bbiab | 15:28 |
thisfred | alecu: it's like working from | 15:30 |
thisfred | home: when you spend all your life in the dark, you can afford to be ;) | 15:30 |
=== salgado is now known as salgado-lunch | ||
thisfred | at least if you don't have a webcam | 15:39 |
=== teknico_ is now known as teknico | ||
* alecu has lunch and runs errands | 15:48 | |
=== yofel_ is now known as yofel | ||
mmcc | windows question - on my machine, when activation queries the registry for the path to sso-client, it gets back 'e:\ubuntu-sso-client\use-tcp-activation\dist\windows-ubuntu-sso-client.exe', and I don't have an e: drive, so that fails. that's OK - I've never installed U1 on this VM and maybe that path is something strange from my test setup? | 16:12 |
briancurtin | mmcc: that's from the test setup | 16:12 |
mmcc | ok, so my question is: is it OK to use os.path.exists to test what I get from the registry in order to fall back to the exe in the source tree? | 16:13 |
mmcc | the nonexistant e: drive threw me | 16:13 |
ralsina | mmcc: sure | 16:13 |
mmcc | or should I only use the registry one if sys.frozen isn't defined? | 16:14 |
mmcc | because now I'm not sure how you'd test changes to the sso backend on windows without editing the registry, if you've already installed it at some point ... | 16:15 |
briancurtin | mmcc: i think that would work | 16:15 |
briancurtin | i guess only ever try the registry on sys.frozen, and always have the fallback to source tree | 16:15 |
mmcc | briancurtin: ok, I think it'd work too - it's what we do in the other function that looks for exes | 16:15 |
mmcc | sounds good! | 16:15 |
=== gatox_lunch is now known as gatox | ||
briancurtin | is it just me or does the 'next' button on the objective page not work? | 16:24 |
briancurtin | (on chrome) | 16:24 |
briancurtin | oh nevermind, i had a blank objective added | 16:24 |
=== teknico_ is now known as teknico | ||
=== zyga-food is now known as zyga | ||
mmcc | dobey, gatox - I have a few merges from last night and this morning for you guys to look at: | 16:56 |
gatox | mmcc, do you need reviews? | 16:57 |
mmcc | https://code.launchpad.net/~mikemc/ubuntuone-client/fix-1018125-darwin-no-gireactor/+merge/112702 | 16:57 |
gatox | mmcc, i was expecting you to let me know when you update one of the reviews with mandel comments | 16:57 |
mmcc | https://code.launchpad.net/~mikemc/ubuntu-sso-client/fix-992593-backend-path-darwin-pkgd/+merge/112709 and https://code.launchpad.net/~mikemc/ubuntu-sso-client/fix-1018924-use-buildout-python/+merge/112813 | 16:57 |
mmcc | gatox, I'm not aware of anything pending with mandel's comments... which branch is that about? | 16:58 |
gatox | mmcc, i'll review them right now | 16:58 |
gatox | mmcc, question...... why tihs: if sys.platform not in ('win32', 'darwin'): | 17:01 |
gatox | and not: if sys.platform == 'linux2': | 17:01 |
gatox | just asking.... | 17:01 |
ralsina | hey, a lunch! | 17:03 |
mmcc | gatox, no great reason. didn't actually know the sys.platform constant for linux, I would've guessed 'linux', so I'm glad I did it the other way :) | 17:08 |
gatox | mmcc, i think is more clear to say "do this just for linux", what do you think? | 17:10 |
dobey | mmcc: ok, i'll look at them as soon as i can | 17:10 |
mmcc | gatox sure, I'm happy to change it | 17:11 |
mmcc | ok gatox, pushed that change. | 17:14 |
gatox | mmcc, thx | 17:14 |
mmcc | btw, for that no-gireactor branch, note that (at least with trunk), those scripts still don't actually work - this fix is just for their imports... | 17:14 |
gatox | mmcc, ok, roger that...... so i shouldn't run the tests for that? | 17:15 |
mmcc | gatox, do the unit tests even cover these scripts? | 17:16 |
gatox | mmcc, there is no test for that :P | 17:16 |
gatox | mmcc, jeje was just the standard reaction jeje | 17:16 |
gatox | mmcc, +1 | 17:17 |
mmcc | gatox: right :) if you wanted to be super thorough you could merge this branch with your fsevents branch and test them IRL that way, but we'll be doing that soon anyway | 17:17 |
mmcc | thx | 17:17 |
=== salgado-lunch is now known as salgado | ||
gatox | mmcc, let me know if i'm being annoying :P i added a need fixing here: https://code.launchpad.net/~mikemc/ubuntu-sso-client/fix-992593-backend-path-darwin-pkgd/+merge/112709 | 17:26 |
gatox | but should be easy to do | 17:26 |
mmcc | gatox, not annoying, good idea. thanks :) | 17:28 |
gatox | mmcc, and this one: https://code.launchpad.net/~mikemc/ubuntu-sso-client/fix-1018924-use-buildout-python/+merge/112813 seems to be in the same situation, i don't think there are pre-existing tests for that | 17:30 |
dobey | isn't there a good reason to avoid doing " " + foo? | 17:34 |
gatox | dobey, it think " %s" % foo is better according some comments | 17:35 |
gatox | thisfred, ^ | 17:35 |
dobey | right, that's whata i thought. but i was hoping someone had a link pointing to something that documented why | 17:35 |
mmcc | dobey, you mean "python " + foo right? I'm not actually doing " " + am i? | 17:36 |
thisfred | dobey: it's slower than doing ''.join(list), but it only matters for large numbers of strings | 17:36 |
dobey | mmcc: i mean "string literal" + foo | 17:36 |
thisfred | so for a single plus outside of a loop, it's fine | 17:37 |
thisfred | in my book | 17:37 |
thisfred | there may be other books | 17:37 |
beuno | it's also more forgiving about types | 17:37 |
briancurtin | where do i buy a copy of the thisfred book | 17:37 |
dobey | beuno: % or +? | 17:37 |
beuno | dobey, % | 17:37 |
beuno | it casts it to a string | 17:37 |
dobey | right | 17:37 |
beuno | so you don't worry about what foo is | 17:37 |
thisfred | briancurtin: it's currently out of print | 17:38 |
thisfred | beuno: I would argue that that's a downside of % | 17:38 |
thisfred | ;) | 17:38 |
thisfred | well of %s specifically | 17:39 |
beuno | that's why your book is out of print :p | 17:39 |
thisfred | hehe | 17:39 |
mmcc | ok so for this use case, we have two things that are definitely short and definitelt strings, and it's done once, so ok to use "" + var? | 17:42 |
mmcc | ok, time for lunch. will push some new tests when I get back | 18:06 |
=== daker is now known as daker_ | ||
=== daker_ is now known as daker__ | ||
briancurtin | lunch/doctor | 18:17 |
rye | ralsina: ok, if we have some fix upstream, whom do we contact to get it packaged in Ubuntu? | 19:20 |
ralsina | rye: I suppose their mailing list | 19:20 |
dobey | rye: fix for what? | 19:23 |
rye | dobey: tomboy https://bugs.launchpad.net/ubuntu/+source/tomboy/+bug/1019256 | 19:26 |
ubot5 | Ubuntu bug 1019256 in tomboy (Ubuntu) "Tomboy should trim trailing "/" in WebSyncPreferencesWidget" [Undecided,New] | 19:26 |
dobey | rye: is it fixed in quantal? upstream bug says fix released, but is it in a new version that's already in quantal? | 19:29 |
dobey | oh i guess not | 19:29 |
dobey | it was merged upstream today | 19:29 |
dobey | rye: you can do it yourself. but it needs to be done in quantal first, then an sru for precise could be done | 19:30 |
rye | dobey: quantal.... hmmm | 19:55 |
gatox | ok, EOD for me..... | 20:10 |
* gatox goes away cursing twisted.... | 20:10 | |
alecu | bye gatox! sorry about that :-) | 20:17 |
alecu | ralsina: I've sent the objectives. Please take a look when you can. | 20:17 |
* alecu needs to take Amelia to swiming lessons. | 20:18 | |
ralsina | alecu: will do tonight | 20:18 |
alecu | ralsina: great. | 20:18 |
dobey | bah can't think of a third :-/ | 20:33 |
* briancurtin back | 20:41 | |
rhys | question. Anyone have a problem where ubuntu-one moves a file to the trash and doesn't update it? For me I have this fun problem where Ubuntu one will just "eat" some files and i have to restore from backup. | 20:42 |
dobey | rhys: files that are deleted from the server either via the web site, or other connected machines, will get moved to trash in all the other clients | 20:45 |
rhys | ok.. but this is my keepass file. No machine I have is deleting this. | 20:46 |
rhys | is there a log I can look at to see whats getting deleted where? | 20:46 |
dobey | in ~/.cache/ubuntuone/log/syncdaemon.log | 20:46 |
dobey | there should be several similar files, as the logs get rotated | 20:47 |
salgado | rhys, does that happen when you use keepass and save changes to the file? | 20:47 |
rhys | salgado: it would have to. nothing else touches that file. | 20:48 |
salgado | rhys, I ask because it sounds similar to what happens with gnucash files: bug 953621 | 20:49 |
ubot5 | Launchpad bug 809370 in Ubuntu One Client "duplicate for #953621 hardlinks dont make PyInotify say CLOSE_WRITE and content never gets uploaded" [High,Confirmed] https://launchpad.net/bugs/809370 | 20:49 |
dobey | salgado: you've seen it before, or have the same issue? | 20:49 |
dobey | ah | 20:49 |
rhys | ah. | 20:53 |
rhys | Yeah, because it only seems to happen with my keepass file. It has happened exactly once with cryptkeeper, which opens/closes encryptfs files via fuse. | 20:54 |
ralsina | dobey: cmake 3 was missing a push | 21:23 |
dobey | oh weird. the lp merge proposals ui changed again | 21:25 |
dobey | weird | 21:26 |
dobey | make dist made a tar.bz2 file, though the cpack generator is set to TGZ in the CMakelists.txt | 21:26 |
ralsina | dobey: the bz2 is done by the dist target | 21:27 |
ralsina | the tgz you would get with make package but that would be a tarball of the installed files | 21:27 |
ralsina | you can laugh at the deb it does by setting the cpck generator to DEB ;-) | 21:27 |
dobey | ugh :) | 21:28 |
dobey | hrmm, seeming some issues | 21:29 |
ralsina | not surprised | 21:29 |
rhys | dobey: salgado: does this mean its a client problem and not a Ubuntu One problem? | 21:31 |
ralsina | Have to go pick my son from a birthday party. Will be back later checking objectives and such. Have a nice weekend! | 21:33 |
ralsina | dobey: just put all the needsfixing you see, that branch surely needs some extra loving, it's just that I don't quite know the expected results | 21:34 |
dobey | ralsina: yeah, understand. i'm doing. have a good weekend :) | 21:37 |
dobey | rhys: i think that bug means it's possibly a kernel or pyinotify problem. | 21:38 |
ralsina | dobey: if you never do a make check, the .so is not built and is not installed. Is that enough? | 21:39 |
* ralsina guesses no ;-) | 21:40 | |
dobey | no | 21:40 |
rhys | dobey: is there anything I can contribute to the fixing of this bug? | 21:40 |
dobey | rhys: i'm sorry, but i don't know. best would probably be to keep up with the bug report that salgado linked | 21:41 |
dobey | ok, i need to get out of here | 21:56 |
dobey | have a good weekend everyone! | 21:56 |
briancurtin | see ya dobey | 21:56 |
mmcc | bye dobey have a good one | 21:56 |
briancurtin | is there any guideline we have for when merge proposals get too big? i'm at 510 lines right now for Python 3 unicode work, and I'm maybe 25% done...thinking i should just submit this one now | 22:08 |
briancurtin | i just dont want to have some 4000 line difft that no one will look at | 22:09 |
mmcc | thought we said to keep it below 1k lines? it came up a while back, around when diego's first fsevents branch loomed, darkening the sky | 22:09 |
briancurtin | ah yeah i kind of remember that | 22:10 |
mmcc | might even have been 500 lines... 500 soundslike a good chunk size if that makes sense to stop there | 22:10 |
ralsina | briancurtin: you can just do half first and another half later | 22:31 |
ralsina | 1K lines is the usual threshold | 22:31 |
ralsina | 500 is better, but over 1K is unbearable | 22:31 |
briancurtin | agreed. i'll see if it makes sense to push on past 510 organizationally, otherwise i'll start a new one | 22:31 |
mmcc | do we use the 'resubmit' review comment type? what for? | 22:32 |
mmcc | eg, if gatox suggested I add tests and I add tests, do I note that with a 'resubmit' comment or is that not what that means | 22:33 |
briancurtin | and i'm out of here. enjoy the weekend all | 23:02 |
mmcc | ok, didn't quite get as far as I'd hoped but it's time to head out. Just a couple of executable path bugs to squash and we should be in the same good shape mandel saw earlier | 23:38 |
mmcc | bye | 23:38 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!