| wgrant | cjwatson: Do you think your seriesless copy change is OK to deploy? | 01:28 |
|---|---|---|
| cjwatson | I'm just trying it out | 01:29 |
| cjwatson | If I can bend dogfood to my will | 01:29 |
| wgrant | Heh | 01:29 |
| cjwatson | Hum, copying https://dogfood.launchpad.net/~cjwatson/+archive/openssh/+packages to https://dogfood.launchpad.net/~cjwatson/+archive/dogfood-copy-target/+packages not obviously successful | 01:31 |
| cjwatson | Oh, maybe copyPackages is just not set up for this to work | 01:32 |
| wgrant | cjwatson: What broke? | 01:32 |
| cjwatson | Yeah, it worked as far as it went but from_series=None is useless | 01:32 |
| wgrant | It may uniqueify the sources. | 01:32 |
| wgrant | Ah | 01:32 |
| cjwatson | But the to_series=None side of it worked fine | 01:32 |
| cjwatson | Let's try +copy-packages then | 01:32 |
| cjwatson | https://dogfood.launchpad.net/~cjwatson/+archive/dogfood-copy-target/+packages looks OK to me, libpipeline was copied with +copy-packages | 01:35 |
| cjwatson | So it's just the permission bug you spotted, which I think we thought was currently fairly academic because PPAs are all published to main and that's the most restrictive component for Ubuntu? | 01:36 |
| wgrant | Indeed, looks reasonable. | 01:36 |
| cjwatson | The only slight awkwardness with qa-oking that is that I attached the other branch to the same bug ... but I guess I can deal with that later | 01:37 |
| cjwatson | marked qa-ok for now anyway | 01:38 |
| wgrant | cjwatson: It'll revert to qa-needstesting once the next branch hits qastaging. | 01:38 |
| cjwatson | Yeah | 01:39 |
| cjwatson | I'll do a bit more testing with the relaxed feature flags on dogfood tomorrow; I want to see whether the cause for soyuz.copypackageppa.enabled being off is still valid | 01:41 |
| cjwatson | AFAICS there'd be no reason not to experimentally lower soyuz.derived_series.max_synchronous_syncs after this is deployed, but it will probably only get any meaningful use if we can also switch on soyuz.copypackageppa.enabled | 01:42 |
| cjwatson | At least for beta testers | 01:42 |
| cjwatson | I can probably get the LibreOffice guys to try it ;-) | 01:43 |
| * cjwatson goes back to bed, immediate duty done | 01:43 | |
| wgrant | Night cjwatson, thanks. | 01:46 |
| StevenK | Bleh, buildout is still convinced it wants 'django', but it's 'Django' :-( | 02:22 |
| nigelb | o_O LP depends on django now? | 02:22 |
| mwhudson | StevenK: i have both Django and django in my versions.cfg :/ | 02:24 |
| StevenK | Hm, I think that actually worked. | 02:26 |
| rick_h_ | wallyworld_: r=me with a few small picks | 02:55 |
| rick_h_ | thanks for the updates! | 02:56 |
| wallyworld_ | rick_h_: awesome, thanks for the detailed review | 02:56 |
| rick_h_ | wallyworld_: yea, sorry for being picky, tring hard to take some ownership of the JS and help improve things so I appreciate the time to make the small improvements | 02:57 |
| wallyworld_ | rick_h_: no need to apologise, our js is poor in many places | 02:57 |
| wallyworld_ | so it's great you are doing this | 02:58 |
| wallyworld_ | rick_h_: many of the things you picked up on were cargo culted so there's a lot to fix | 02:58 |
| rick_h_ | wallyworld_: yea, trying to do a goold old fashioned line the in sand. :) | 02:59 |
| rick_h_ | wallyworld_: cool, I know I hate when I get long reviews so and irc isn't the best so want to make sure things come across well | 02:59 |
| wallyworld_ | well, we gotta start fixing somewhere/sometime, now is as good a time as any | 02:59 |
| rick_h_ | with you and jcsackett and sinzui doing some awesome stuff I'm feeling there's hope | 03:00 |
| wallyworld_ | well, it's getting better slowly, but there's a lot of code to fix, and way too much code without test coverage | 03:01 |
| rick_h_ | yea, it's scary sometimes, but as long as it's getting better | 03:02 |
| rick_h_ | and hopefully as things get cleaner they get easier | 03:02 |
| wgrant | Heh | 03:02 |
| wgrant | Bug #800515 and bug #1016454 | 03:02 |
| _mup_ | Bug #800515: Enable "NotAutomatic: yes" for -proposed <soyuz-publish> <Launchpad itself:Triaged> < https://launchpad.net/bugs/800515 > | 03:02 |
| wgrant | Dupes filed a year to the day apart | 03:03 |
| wallyworld_ | having standard templates really helps, but there's still a lot of inconsistancy in terms of patterns etc | 03:03 |
| wgrant | 3 hours off, though :( | 03:03 |
| rick_h_ | wallyworld_: yea, it is. I've talked with deryck and one of my goals for this next year to try to get a couple of really polished JS modules as the gold standard. | 03:03 |
| rick_h_ | if you've got a question, refer to these kind of things | 03:03 |
| rick_h_ | but anway, past my bed time, but I saw your review come up and I wanted to try to unblock you asap. | 03:04 |
| wallyworld_ | rick_h_: we also have way too much code that just adds methods to a namespace instead of using widgets. i used widgets for the sharing stuff and it makes it sooo much easier | 03:04 |
| wallyworld_ | rick_h_: thanks for reviewing and unblocking, i really apprciate it | 03:04 |
| rick_h_ | right, exactly. Widgets/Plugins, and I'm working on getting YUI 3.5 which adds Views | 03:04 |
| wallyworld_ | \o/or 3.5, can't wait | 03:05 |
| rick_h_ | so looking forward to doing a real View containing several Widgets | 03:05 |
| wallyworld_ | s/or/for | 03:05 |
| wallyworld_ | yeah, mvc | 03:05 |
| rick_h_ | yea, gotten through all the code in app/blueprint/bugs and onto the code module | 03:05 |
| rick_h_ | I'll have an email in the morning with the work/hits so far. | 03:05 |
| rick_h_ | and probably turning on the combo loader for all this week unless osmeone brings up a blocker | 03:05 |
| wallyworld_ | looking forward to it | 03:06 |
| rick_h_ | so I'm pushing hard for 3.5 sooner vs later | 03:06 |
| rick_h_ | anyway, wheee | 03:06 |
| rick_h_ | night | 03:06 |
| wallyworld_ | awesome | 03:06 |
| wallyworld_ | goofnight | 03:06 |
| lifeless | wgrant: care to update the disklessarchives diagram ? | 03:18 |
| wgrant | lifeless: Have you finished your edits? | 03:22 |
| lifeless | I believe so | 03:23 |
| lifeless | it was slow on saving was all | 03:23 |
| StevenK | wgrant: How do you feel about reviewing https://code.launchpad.net/~stevenk/launchpad/auditor-layer/+merge/112962 ? | 04:49 |
| wgrant | StevenK: That looks pretty vile | 04:59 |
| wgrant | Shouldn't we not be testing against the real thing? | 04:59 |
| wgrant | How is its DB managed? | 04:59 |
| wgrant | etc | 04:59 |
| StevenK | Real thing, as in production auditor? | 05:01 |
| StevenK | As this is an established pattern for at least longpoll | 05:02 |
| wgrant | One pre-SOA service does not an SOA pattern make. | 05:02 |
| StevenK | That ^ was the plan that lifeless and I agreed on at least. | 05:04 |
| lifeless | wgrant: your double negative has confused me, can you rephrase ? | 05:09 |
| wgrant | lifeless: I thought the SOA guidelines said to test against a (network) fake. | 05:09 |
| wgrant | Not the real DB-backed service. | 05:10 |
| lifeless | wgrant: yes, which sqlite is ~= too | 05:10 |
| lifeless | wgrant: in memory sqlite that is | 05:10 |
| StevenK | Not sure if the default config of auditor is in-memory, but that can be fixed. | 05:10 |
| lifeless | wgrant: I agree its not as lean as a reimplementation with no django at all, for instance, but its certainly fitting the spirit of the SOA, that it should be cheap to spin up, config-free etc. | 05:11 |
| wgrant | If it's throw-away SQLite, then sure :) | 05:12 |
| wgrant | lifeless: The reference implementation shouldn't have Django at all either, but I think I lost that argument... | 05:13 |
| lifeless | wgrant: my understanding is that it is, or will be. | 05:13 |
| lifeless | I kindof think that that config should be in the fixture itself, to reduce the window for surprise, but for now its ok, I think. | 05:13 |
| StevenK | wgrant: So it's still vile, or you're refusing to deal with the MP? :-P | 05:35 |
| StevenK | wgrant: https://code.launchpad.net/~stevenk/launchpad/populate-branch-aag/+merge/112264 should be easy to review | 06:26 |
| adeuring | good morning | 07:38 |
| jam1 | can anyone help quickly with a testing question? | 07:40 |
| jam1 | I have a test that does "login('email@address')" and I'd like to change it to use 'with person_logged_in(...)' | 07:40 |
| jam1 | however the context manager takes a user object, not an email. | 07:40 |
| jam1 | how does one get one of those from an email address | 07:40 |
| === jam1 is now known as jam | ||
| lifeless | jam: there is a test helper module with consants | 07:43 |
| lifeless | jam: there is also a context manager that can deal with emails, I think | 07:43 |
| lifeless | jam: but the specific answer is PersonSet.find(email), IIRC. | 07:43 |
| jam | lifeless: there is admin_logged_in, anonymous_* celebrity_* and person_* | 07:44 |
| wgrant | jam: Which test? | 07:45 |
| jam | wgrant: I'm converting a doctest to a unittest | 07:45 |
| wgrant | An email address is usually a sign that it's doing something horribly wrong. | 07:45 |
| wgrant | Which address? | 07:45 |
| jam | wgrant: https://code.launchpad.net/~jameinel/launchpad/py27-xmlrpc-auth-1019292/+merge/112792 | 07:46 |
| jam | wgrant: it is just trying to assert that the XMLRPC api is using a different user than whatever the current context is | 07:46 |
| wgrant | admin_logged_in is correct there. | 07:46 |
| wgrant | Oh | 07:46 |
| wgrant | Hm | 07:46 |
| wgrant | It's using foo.bar, but just as some random user. That's a bit odd. | 07:47 |
| lifeless | fubared | 07:47 |
| wgrant | Since foo.bar is an admin, it's a bit silly to use it to test that it's something arbitrary user | 07:47 |
| wgrant | Just create a new one | 07:47 |
| wgrant | self.factory.makePerson() | 07:47 |
| wgrant | Use that | 07:47 |
| lifeless | jam: general rules of thumb: | 07:49 |
| lifeless | - using existing admins is ok but not brillirant | 07:49 |
| jam | wgrant: ObjectFactory has no attribute makePerson | 07:50 |
| lifeless | - using existing persons is generally a bad idea as it ties you to sample data | 07:50 |
| lifeless | - better to bring up just what you need from scratch using the helpers | 07:50 |
| lifeless | jam: on developer LOC credit; the idea is to shrink, not stay static :) | 07:58 |
| wgrant | jam: It does so... | 08:01 |
| wgrant | lifeless: Creating new people frequently has major test suite performance implications, so I introduced admin_logged_in which always uses an existing one. | 08:02 |
| lifeless | perhaps wrong test base class? | 08:02 |
| wgrant | But in this case it's just one, and it's meant to be an arbitrary person, so makePerson is correct. | 08:02 |
| lifeless | wgrant: yes, I know - tis a workaround though. | 08:02 |
| === almaisan-away is now known as al-maisan | ||
| === al-maisan is now known as almaisan-away | ||
| StevenK | wgrant: Can I have your attention now? :-) | 08:09 |
| czajkowski | morning | 08:09 |
| wgrant | StevenK: Indeed, sorry, let me see | 08:12 |
| wgrant | 64+ branch_to_artifact = dict([(artifact.branch_id, artifact) | 08:13 |
| wgrant | 65+ for artifact in artifacts]) | 08:13 |
| wgrant | tsk | 08:13 |
| wgrant | bad linebreak is bad | 08:13 |
| StevenK | wgrant: What would you recommend? | 08:14 |
| wgrant | StevenK: http://www.python.org/dev/peps/pep-0008/#indentation | 08:18 |
| wgrant | StevenK: Convention is to say: | 08:18 |
| wgrant | dict( | 08:18 |
| wgrant | [(artifact.branch_id, artifact) for artifact in artifacts]) | 08:18 |
| wgrant | branch_to_artifact = dict( | 08:18 |
| wgrant | [(artifact.branch_id, artifact) for artifact in artifacts]) | 08:18 |
| wgrant | That's the one. | 08:19 |
| stub | And you can probably drop the square brackets | 08:20 |
| StevenK | It's a list comphresion in a dict() call | 08:21 |
| wgrant | StevenK: A generator expression in a dict() call should work just as well | 08:21 |
| StevenK | wgrant: I've pushed up a change | 08:27 |
| wgrant | StevenK: Thanks, r=me | 08:32 |
| Laney | https://code.launchpad.net/~laney/launchpad/db-proposed-not-automatic-pre-release/+merge/112134 updated; could somebody review/land? | 09:10 |
| mgz | jam: using `nohup bin/test -vvv >~/test_out.log 2>~/test_err.log &` seems good | 09:43 |
| lifeless | mgz: testr run :> | 09:49 |
| mgz | testr was introducing subunit borkédness | 09:51 |
| jam | lifeless: that doesn't give any progress feedback (vs tee), etc. And yeah, subunit had some 2.7 issues (skip tests would cause broken stream) | 09:51 |
| jam | I think gmb fixed that with a newer zope.testing, though. | 09:52 |
| gmb | Yep. The dependency update should be landing in LP devel today. | 09:52 |
| jam | gmb: I think it already did. At least, ISTR failing to start the test suite because it couldn't find a new enough zope.testing. Though maybe that was an unrelated zope.testing change | 09:53 |
| gmb | O.o | 09:53 |
| gmb | jam, devel still has p15, the 2.7 stuff is p16. | 09:53 |
| gmb | I think | 09:53 |
| * gmb checks | 09:53 | |
| gmb | jam, Yes, Still on p15 in devel. | 09:54 |
| gmb | p16 will be on its way to ec2 shortly | 09:54 |
| jam | gmb: probably devel rev 15470 which bumped it to r15. That was about 1.5weeks ago, but the checkout on my desktop was a bit old | 09:58 |
| lifeless | jam: ah, true enough | 10:04 |
| lifeless | jam: subunit itself should be 2.7 safe; been using it for months on 2.7 | 10:04 |
| jam | lifeless: yeah, zope.testing didn't handle skips, and in 2.6 unittest didn't support them either. So testtools passed them through as success. | 10:05 |
| jam | In 2.7, unittest gets an 'addSkip' which wasn't getting sent on to the subunit stream | 10:05 |
| lifeless | ah | 10:05 |
| lifeless | win ;> | 10:05 |
| jam | so you would see the test start | 10:05 |
| jam | but not ever finish | 10:05 |
| jml | perhaps stopTest should emit some kind of warning if that happens. | 10:06 |
| jam | jml: would have probably made tracking down the failure easier | 10:08 |
| === matsubara is now known as matsubara-afk | ||
| === benji changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: benji | Firefighting: - | Critical bugs: 4.0*10^2 | ||
| === almaisan-away is now known as al-maisan | ||
| === al-maisan is now known as almaisan-away | ||
| rick_h_ | adeuring: ivory https://plus.google.com/hangouts/_/ef4e3eeb2016cc8910d1dc31949a0597da77f5f0?authuser=0&hl=en-US | 13:31 |
| rick_h_ | benji: can you take a peek when you get a chance please? https://code.launchpad.net/~rharding/launchpad/code_yui35_one/+merge/113031 | 14:04 |
| benji | rick_h_: sure | 14:04 |
| mgz | hm, test for js stuff hung at: | 14:38 |
| mgz | write(2, "\n(test:2741): Gdk-CRITICAL **: g"..., 10 | 14:38 |
| mgz | presumably related to not having X running | 14:39 |
| * mgz kills the layer | 14:39 | |
| jelmer | mgz: you might want to run inside of xvfb-run | 14:41 |
| mgz | presumably, will try that when the run completes | 14:42 |
| rick_h_ | mgz: yea, I had to do that with running tests in lxc | 14:55 |
| jam | mgz: lp.translations.tests.test_translationtemplatesbuildbehavior.TestTranslationTemplatesBuildBehavior.test_updateBuild_WAITING_notarballERROR:root:Slave returned no filemap. | 14:57 |
| jam | ERROR:root:Build produced no tarball. | 14:57 |
| jam | Failure in test lp.soyuz.tests.test_packageupload.PackageUploadTestCase.test_realiseUpload_for_delayed_copies | 14:58 |
| jam | mgz: ^^ | 14:58 |
| mgz | jam: also lp.services.mail.tests.test_stub.test_simple_sendmail | 15:01 |
| mgz | again email header wrapping | 15:02 |
| mgz | Failed example: message['X-Generated-By'] | 15:02 |
| mgz | Expected: 'Launchpad (canonical.com); Revision="1999";\n\tInstance="launchpad-lazr.conf"' | 15:02 |
| mgz | Got: 'Launchpad (canonical.com); Revision="1999";\n Instance="launchpad-lazr.conf"' | 15:02 |
| mgz | slightly different doctest issue in lib/lp/services/webapp/doc/test_adapter.txt | 15:03 |
| ivory | sinzui: could you take a look at this? https://code.launchpad.net/~ivo-kracht/launchpad/bug-1013281/+merge/113062 | 15:06 |
| mgz | that last one is trivial, is a threading.Event object, and new in Python 2.7 returns the internal flag object rather than None | 15:06 |
| sinzui | thank you ivory. Do you want me to land this? | 15:11 |
| ivory | sinzui: adeuring will do it but thank you nevertheless | 15:14 |
| mgz | Total duration of test run 18883.5 seconds. | 15:16 |
| jelmer | benji: Thanks for the review! | 15:23 |
| benji | jelmer: my pleasure | 15:24 |
| Laney | benji: could you help me to land https://code.launchpad.net/~laney/launchpad/db-proposed-not-automatic-pre-release/+merge/112134 please? | 15:25 |
| benji | Laney: sure; how can I help? "ec2 land" it? | 15:25 |
| Laney | I don't know the commands you guys run :P | 15:25 |
| Laney | I guess that's the one :) | 15:26 |
| benji | hmm, given that there is a DB change, I'll have to refresh my memory on the right way to handle that | 15:27 |
| cjwatson | ec2 land works for db-devel | 15:28 |
| cjwatson | Shouldn't require anything especially special | 15:28 |
| cjwatson | (The branch is targeted correctly) | 15:29 |
| benji | yep, the target looks good; I'm firing off a job now | 15:30 |
| Laney | ta | 15:31 |
| benji | Laney: the MP needs a commit message and then I'll try again. | 15:41 |
| Laney | benji: there | 15:42 |
| === Ursinha_ is now known as Guest65630 | ||
| benji | Laney: PQM doesn't like newlines in commit messages. I have removed them and submitted. The EC2 instance is starting now. | 15:59 |
| Laney | benji: OK. So it's just the "short description" it wants then, for future reference? | 16:00 |
| benji | Laney: I don't know of a prescribed guideline. I like your commit message as-is. | 16:00 |
| Laney | well I usually try to keep the first line under 72ish when writing them | 16:01 |
| === salgado is now known as salgado-lunch | ||
| === matsubara-afk is now known as matsubara | ||
| === salgado-lunch is now known as salgado | ||
| cjwatson | benji: I have a couple of split-outs from queue-api up for review to start with; do those look like a more reasonable level of granularity? | 17:10 |
| benji | cjwatson: I'll take a look. | 17:11 |
| cjwatson | I'm still juggling branches locally to find the next thing to separate | 17:11 |
| cjwatson | Probably the read-only bits of the webservice exports | 17:13 |
| sinzui | czajkowski, test-system failures are critical, not low. Lp's mailman installation is brittle, we cannot tolerate missing test coverage | 17:27 |
| benji | cjwatson: looking good; the only thing I spotted was some extra parens (details in the comment) | 17:31 |
| mgz | sinzui: I had some luck poking things with mailman, manually creating parent directories makes tests pass, but then oddly the buildmailman.py in make starts failing from not having any lists | 17:46 |
| mgz | does buildmailman.py just need fixing to be better about creating needed directories and tolerating different state? | 17:46 |
| sinzui | mgz, I think it needs fixing for the lxc case. Mailman always has at least one list. There is a control list that out code must discount. if it was not created, Mailman goes tits up | 17:47 |
| sinzui | mgz, Other developers have reported problems were /tmp/var/mailman was not created properly, so I think this is an old issue | 17:48 |
| mgz | did seem odd no one else had run into problems, I'll dig a bit further and see where I get | 17:51 |
| benji | gary_poster: indeed | 17:57 |
| cjwatson | benji: ta | 18:29 |
| === matsubara is now known as matsubara-afk | ||
| mgz | okay, that's all the remaining py27 things I've logged as having issues, though didn't get complete run due to mailman and X issues | 20:16 |
| rick_h_ | jcsackett: ping, if you remove the renderUI in the extending class does it still work right? You shouldn't need it since it's not doing anything extra? | 21:17 |
| rick_h_ | jcsackett: r=me with the two notes. | 21:27 |
| === salgado is now known as salgado-afk | ||
| sinzui | StevenK, wallyworld_, jcsackett https://dev.launchpad.net/Projects/Disclosure | 22:14 |
| sinzui | https://bugs.launchpad.net/launchpad/+bugs?field.tag=disclosure+privacy-transitions&field.tags_combinator=ALL | 22:21 |
| sinzui | https://bugs.launchpad.net/launchpad/+bugs?field.tag=disclosure+information-type&field.tags_combinator=ALL | 22:33 |
| === wgrant is now known as Guest78124 | ||
| === Guest78124 is now known as wgrant_ | ||
| wgrant_ | Grar | 22:36 |
| StevenK | Haha | 22:37 |
| wgrant_ | This 3G is so slow I'm not actually sure it's 3G at all | 22:37 |
| StevenK | Hahahaha, Optus 3G | 22:38 |
| wgrant_ | No mobile coverage is very good around here :) | 22:39 |
| === benji changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: - | Firefighting: - | Critical bugs: 4.0*10^2 | ||
| wgrant_ | ooh | 23:51 |
| wgrant_ | flashing lights | 23:51 |
| wgrant_ | maybe they have fixed it | 23:51 |
| lifeless | wgrant: where are you ? | 23:52 |
| wgrant | lifeless: Some HFC fault took the entire street's phone and Internet out from about 4am until 90 seconds ago. | 23:53 |
| lifeless | wgrant: \o/ | 23:55 |
| StevenK | wgrant: Six hour outage. Pretty short for Optus. | 23:56 |
| wgrant | Apparently their monitoring sucks enough that I was the first to report it, at around 8:10. | 23:56 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!