StevenK | wgrant: Bwahahaha | 00:01 |
---|---|---|
* StevenK stabs buildbot | 01:37 | |
nigelb | wgrant: Maybe you are the monitoring :) | 01:50 |
nigelb | I'm contemplating writing a vagrant script for LP. | 01:50 |
nigelb | So that it spins up a virtual machine in one command. | 01:50 |
nigelb | Because I'm lazy. | 01:51 |
nigelb | StevenK: A local python job posting wanted "experience with Launchpad" | 01:51 |
StevenK | Haha | 01:55 |
nigelb | I was tempted to apply and ask if my "experience" was sufficient ;-) | 01:55 |
lifeless | nigelb: elliot wrote one. | 02:04 |
nigelb | lifeless: oh. Is it around somwhere? | 02:04 |
lifeless | dunno | 02:05 |
rick_h_ | lifeless: around? Want to check on the info I should be looking into with rt combo loader/convoy? | 02:14 |
lifeless | -> ops | 02:16 |
statik | nigelb, lifeless: the vagrant script I wrote didn't actually bring up LP, it was when I was experimenting with the microservice stuff | 03:46 |
statik | some good docs here though https://speakerdeck.com/u/mitchellh/p/develop-and-test-configuration-management-scripts-with-vagrant | 03:46 |
nigelb | ah! | 03:47 |
wallyworld_ | StevenK: around? | 03:49 |
lifeless | nigelb: in NZ now? | 03:57 |
lifeless | statik: o/ wotcha. Off the boat now? | 03:57 |
nigelb | lifeless: not yet :) | 03:59 |
nigelb | I hope I get to NZ in time for kiwipycon. | 03:59 |
lifeless | cool | 04:02 |
lifeless | I might get to entertain you then :) | 04:02 |
nigelb | I heard :) | 04:02 |
StevenK | wallyworld_: Was noming. What's up? | 04:03 |
wallyworld_ | StevenK: i think there's a 2nd issue with the change to bug info type in the privacy portlet but i wanted a 2nd opinion | 04:03 |
wallyworld_ | the issue is that we are now calling the transitionToInfoType api directly | 04:04 |
wallyworld_ | but previously the view would have been used via a post | 04:04 |
wallyworld_ | and the view would have published a change event | 04:04 |
wallyworld_ | but we don't do that now | 04:04 |
wallyworld_ | and in fact, the non js version does use the view so does do the event | 04:04 |
wallyworld_ | am i missing something? | 04:05 |
StevenK | Which event? | 04:05 |
wallyworld_ | ObjectModifiedEvent | 04:05 |
StevenK | That should be fired via the JS calls transitionToInformationType over the API | 04:05 |
wallyworld_ | i couldn't see where in transitionToInformationType it was fired | 04:06 |
StevenK | It isn't | 04:06 |
StevenK | It's done in the LAZR machinery | 04:06 |
wallyworld_ | oh, so the api layer fires the event? | 04:06 |
StevenK | Yah | 04:06 |
wallyworld_ | ah, ok. makes sense now. thanks | 04:06 |
wallyworld_ | i didn;t realise the lazr stuff didi that | 04:07 |
statik | lifeless: yep, back in real life, finishing up an 18-hour first day on the new job :) | 04:07 |
lifeless | enjoying it ? | 04:07 |
StevenK | wallyworld_: Neither did I, until I figured out why the heck I was getting two visibility change events for a bug. | 04:07 |
statik | yeah man I love the firehose feeling at the start of a project | 04:07 |
wallyworld_ | StevenK: ah yeah, i do recall that now | 04:08 |
* StevenK stabs buildbot and sets it on fire. | 04:13 | |
lifeless | statik: nice. And you said it was rails ? | 04:14 |
StevenK | building | 04:15 |
StevenK | ETA in | 04:15 |
StevenK | ~ 6 hrs 53 mins | 04:15 |
spm | heya statik! | 04:15 |
StevenK | Really, buildbot? REALLY? | 04:16 |
huwshimi | Why do I get the feeling Launchpad is not playing nice with my virtualhosts | 05:05 |
StevenK | wgrant, wallyworld_: https://code.launchpad.net/~stevenk/launchpad/no-proprietary-multi-pillar-bug-vocab/+merge/113149 | 05:09 |
wallyworld_ | StevenK: do you need both context and IBug.providedBy(context) or does providedBy error on being passed None? | 05:11 |
StevenK | wallyworld_: IBug.providedBy(None) returns False, so I'll drop the first bit | 05:12 |
wallyworld_ | StevenK: i'd replace 'PROPRIETARY' in the test by InformationType.PROPRIETARY.value or whatever the correct expr is | 05:12 |
StevenK | wallyworld_: How? It isn't there! | 05:13 |
StevenK | I'm trying to look it up by the token | 05:13 |
wallyworld_ | sure but you can get the token from the enum | 05:13 |
StevenK | wallyworld_: The existing test for proprietary_information_type.disabled uses PROPRIETARY | 05:14 |
wallyworld_ | you mean 'PROPRIETARY' with the ''? | 05:14 |
StevenK | Yup | 05:14 |
wallyworld_ | ok then | 05:14 |
wallyworld_ | StevenK: i'd also simplify the if statement for the proprieryary_allowed, i don't think it adds much value having 2 booleans | 05:15 |
StevenK | wallyworld_: We need them. The first one is backed onto the feature flag | 05:15 |
StevenK | It will be simplified when proprietary_information_type.disabled dies | 05:16 |
wallyworld_ | so why no 'if not proprietary_disabled and IBug.providedBy(context)....' | 05:16 |
wallyworld_ | not | 05:16 |
StevenK | Oh | 05:16 |
StevenK | I get it | 05:16 |
wallyworld_ | just a thought since it's verbose with the extra boolean and it reads ok without i think | 05:17 |
StevenK | wallyworld_: http://pastebin.ubuntu.com/1072538/ | 05:18 |
StevenK | It reads better against -r submit:, but meh | 05:18 |
wallyworld_ | i think it's not quite right? | 05:19 |
StevenK | The test passes | 05:19 |
wallyworld_ | ah, i missed the () around the 2nd bit | 05:20 |
StevenK | I'm looking forward to display_userdata_as_private.enabled dying, the vocab will shrink in the wash remarkably. | 05:21 |
wallyworld_ | i think it will read better without the (). if not proprietary_disabled or not IBug.providedBy(context) or len(context.bugtasks) < 2 | 05:21 |
StevenK | wallyworld_: That will cause PROPRIETARY to leak | 05:22 |
wallyworld_ | it's meant to the equivalent to your condition, but with the () removed | 05:22 |
wallyworld_ | i think i have an or where i want an and | 05:23 |
wallyworld_ | whatever works | 05:23 |
StevenK | wallyworld_: So I'm going to need brackets anyway, since there is a line break in the middle | 05:24 |
wallyworld_ | yeah, maybe put the () bit on the second line | 05:24 |
wallyworld_ | so it's all together | 05:24 |
StevenK | if not proprietary_disabled and not ( | 05:24 |
StevenK | IBug.providedBy(context) and | 05:24 |
StevenK | Sigh | 05:25 |
StevenK | IBug.providedBy(context) and len(context.bugtasks) > 1): | 05:25 |
StevenK | That will likely cause wgrant to murder me. | 05:25 |
wallyworld_ | if not proprietary_disabled and | 05:26 |
wallyworld_ | not(....) | 05:26 |
wallyworld_ | whatever you feel is best, i don't mind | 05:27 |
wallyworld_ | r=me anyway | 05:28 |
StevenK | wallyworld_: Did you notice me fixing your test? :-) | 05:29 |
wallyworld_ | oh, didn't realise it was my test. thans :-) | 05:29 |
StevenK | wallyworld_: I thought test_vocabulary_items_project was yours | 05:29 |
wallyworld_ | it may have been | 05:30 |
wallyworld_ | probably was | 05:30 |
wallyworld_ | i just can't recall right at the moment | 05:30 |
wallyworld_ | my head is stuck in info type js mollasis | 05:30 |
wgrant | StevenK: Wrong | 05:31 |
wgrant | StevenK: The bugtask count isn't relevant -- it's the number of distinct pillars that matters. | 05:32 |
StevenK | wgrant: Ah, so I need .affected_pillars | 05:32 |
StevenK | wallyworld_: http://imgur.com/gallery/L29C6 | 05:37 |
wallyworld_ | StevenK: lol. i had heard about a google streetview car crashing | 05:38 |
=== matsubara-afk is now known as matsubara | ||
StevenK | wgrant: http://pastebin.ubuntu.com/1072565/ is more to your liking? | 05:49 |
=== Guest65630 is now known as Ursinha | ||
=== Ursinha is now known as Guest68258 | ||
wgrant | StevenK: Something like that, yeah | 06:15 |
StevenK | ssl.SSLError: [Errno 8] _ssl.c:504: EOF occurred in violation of protocol | 06:17 |
StevenK | zsh: exit 1 ec2 land --no-qa | 06:17 |
StevenK | Blink | 06:17 |
huwshimi | Someone please approve this: https://code.launchpad.net/~huwshimi/launchpad-news-wordpress-theme/hold-me-back-im-fixing-the-type/+merge/113159 | 06:32 |
* huwshimi is ducking out for a minute, will be back later | 06:35 | |
adeuring | good morning | 07:17 |
=== gmb changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: gmb | Firefighting: - | Critical bugs: 4.0*10^2 | ||
mgz | gmb: where was yellow's launchpad kanban updating script? | 09:00 |
gmb | mgz lp:lp2kanban. | 09:01 |
mgz | ta | 09:01 |
czajkowski | maxb: gmb morning | 09:09 |
gmb | Morning czajkowski. | 09:09 |
czajkowski | gmb: hows things up north | 09:11 |
czajkowski | is it grimm and wet like London :/ | 09:11 |
gmb | czajkowski, That's what we call "summer" | 09:12 |
gmb | But I can spot a teeny tiny bit of blue sky | 09:12 |
gmb | So all is not lost. | 09:12 |
maxb | czajkowski: a bit grey today, I suppose, but Saturday was lovely at least :-) | 09:18 |
czajkowski | maxb: lets hope it's nice this Saturday too :) | 09:18 |
jam | gmb: you're on-call today? I think mgz has 3 nice-and-tiny branches up for review if you feel like starting off easy | 09:28 |
gmb | jam, I'll take a look presently. Thanks for the heads-up. | 09:30 |
jam | (I'm trying to see if I can get a clean run on precise today on my desktop, we're pretty close) | 09:30 |
gmb | Awesome | 09:30 |
jam | well, it won't happen *today* given the commit queue, but something like that. | 09:30 |
gmb | jam Incidentally, when run in parallel, I said we only ran 1800 tests. That's not true; it's just that buildbot only _reports_ that many tests. We ran 18,000. So the stream is broken again somewhere. | 09:31 |
gmb | Haven't had chance to try looking into it yet though. | 09:31 |
jam | gmb: joy... but i'm glad to hear that the test suite is running without hanging/etc. | 09:31 |
gmb | Indeed | 09:31 |
mgz | reminds me, I haven't checked what subunit does with NUL characters yet | 09:32 |
mgz | I don't think it minds. | 09:32 |
lifeless | binary safe stream | 09:34 |
lifeless | particularly if you are using the chunk serialiser | 09:34 |
lifeless | (which LP is) | 09:34 |
gmb | mgz, Approved all your branches. | 10:36 |
mgz | ta... will have to create these cards in the next lane then :) | 10:38 |
=== rick_h_ changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: gmb, rick_h | Firefighting: - | Critical bugs: 4.0*10^2 | ||
* gmb -> afk for an appointment | 10:50 | |
danilos | gmb, hi, I wonder if you can please ec2 submit https://code.launchpad.net/~danilo/launchpad/bug-1000642-drop/+merge/112306 for me (stub submitted it but it seems to have failed with something unrelated to the branch: https://pastebin.canonical.com/69307/) | 10:50 |
danilos | damn, bad timing :) | 10:50 |
rick_h_ | danilos: I can take a peek | 10:50 |
danilos | rick_h_, thanks | 10:50 |
=== matsubara is now known as matsubara-afk | ||
rick_h_ | danilos: ok, off to ec2 land | 11:02 |
danilos | rick_h_, ta | 11:10 |
cjwatson | gmb,rick_h_: Might an OCR be able to have a look over https://code.launchpad.net/~cjwatson/launchpad/queue-api-readonly/+merge/113202 ? | 12:32 |
cjwatson | Extracted from a previous much bigger branch. | 12:32 |
rick_h_ | cjwatson: looking up | 12:32 |
cjwatson | Still 920 lines, oops, I thought it would be a bit shorter than that. | 12:32 |
cjwatson | I can split it up further if I have to. This seems like a fairly reasonable logical chunk though. | 12:34 |
rick_h_ | ok, will take a peek. I'll feel better knowing it could have been worse :) | 12:34 |
cjwatson | The original was 1647 | 12:35 |
rick_h_ | cjwatson: r=me with two points to bring up | 13:27 |
cjwatson | rick_h_: Thanks. Do you think len() is preferable there then? It was within the same object so I figured the "privacy" (insofar as Python has any) didn't matter. | 13:30 |
rick_h_ | cjwatson: yea, especially since you changed the other cases, it's one part consistant at that point as well | 13:30 |
cjwatson | len(self.sources) will involve constructing a concrete list, although maybe that doesn't matter since it's short and will be cached. | 13:30 |
rick_h_ | I guess when I wrote the point I initially wondered if you were doing that to avoid the cache | 13:31 |
rick_h_ | but then didn't seem like it so figured if you were going to use/go through the cache everyone should | 13:31 |
cjwatson | Fair | 13:31 |
rick_h_ | to avoid one method saying one thing "there's 2 here" but the cache not saying that | 13:32 |
cjwatson | #245 was a drive-by what-I-thought-was-a-bug-fix, but I can't prove off the top of my head that it's correct so how about I just drop it - it's not required as part of this branch | 13:32 |
rick_h_ | not that I see a bug with mix matched results/etc but just letting you know where my brain's at reading it | 13:32 |
cjwatson | Yeah | 13:32 |
rick_h_ | yea, sorry I'm just not all a pro enough at this and chaning r/o on stuff makes me want to find a list of people writing to it to make sure no one is | 13:33 |
cjwatson | Not a problem | 13:33 |
deryck | adeuring, https://plus.google.com/hangouts/_/3ac5f6358bc446e2018dedac8a0d188891410910?authuser=0&hl=en | 13:34 |
=== benji___ is now known as benji | ||
adeuring | rick_h_: could you please review this MP: https://code.launchpad.net/~adeuring/lazr.jobrunner/bug-1015667/+merge/113228? | 14:52 |
rick_h_ | adeuring: sure thing | 14:53 |
rick_h_ | abentley: didn't you do some magic to look at the queue payload without pulling it out of the queue? | 14:57 |
abentley | rick_h_: Yes, you basically just read the queue without confirming that you've read the messages. It's the core of from lazr.jobrunner.celerytask import list_queued, and abel's already looked at it. | 14:59 |
rick_h_ | ok, so my thing with this is that the function is called 'inspect-queue' which seems innocous, but it clears things. | 15:00 |
rick_h_ | should it stick things back on the queue? | 15:00 |
adeuring | rick_h_: well... the fact that the messages are gone can be a positive side effect | 15:01 |
adeuring | in our case | 15:01 |
rick_h_ | right, I understand in our use case, but I'm looking at this from the outside as someone who gets this package and tries to use it | 15:01 |
rick_h_ | would clear-queues be better? | 15:02 |
rick_h_ | at least then someone coming along would be a bit more hesitant to run the command | 15:02 |
adeuring | rick_h_: ok, makes sense | 15:02 |
rick_h_ | adeuring: ok r=me with naming clarification. Thanks. | 15:04 |
adeuring | rick_h_: thanks! | 15:04 |
abentley | rick_h_: It's mystifying to me that drain_queues(retain=True) doesn't work, but abel says it doesn't. | 15:04 |
rick_h_ | abentley: yea, I'm not tinkered with any of this so taking that stuff at face value as far as review goes. | 15:05 |
rick_h_ | abentley: is there some way to tell what the local branch name was from a branch pushed to LP? | 15:11 |
abentley | rick_h_: The branch nick in the revisions defaults to the last component of the path. | 15:12 |
rick_h_ | right, but I pushed it to a manual name and don't have that branch locally so I must have messed up and been on an existing branch | 15:13 |
rick_h_ | now in the confusion can't tell where the changes I made yesterday are :/ | 15:13 |
abentley | rick_h_: Pushing it up to a manual name is not going to change the branch nicks in the revisions. | 15:14 |
ivory | rick_h_: could you take a look at this? https://code.launchpad.net/~ivo-kracht/launchpad/bug-921901/+merge/113234 | 15:15 |
abentley | rick_h_: "bzr log --long -l1 lp:$BRANCHNAME" should tell you the last path component of the branch. | 15:15 |
rick_h_ | ty much abentley | 15:15 |
rick_h_ | ivory: I'm not following the bug that you're fixing here. When I look at the current live site, the tag links match what the bug says they should. | 15:23 |
rick_h_ | ivory: what was the difference in the generated urls you altered? | 15:24 |
ivory | rick_h_: as i understand it they should link to a project group | 15:27 |
rick_h_ | ivory: so I'm seeing: http://pastebin.ubuntu.com/1073255/ | 15:28 |
rick_h_ | the only difference I can see is there's a trailing / in the "Should be" urls | 15:29 |
ivory | rick_h_: thats weird because i'm at launchpad/+bugs/... if i click on a tag | 15:31 |
ivory | instead of launchpad-project/+bugs/... | 15:31 |
rick_h_ | oh oh ok, I was looking at the tags in the sidebar, not in the buglisting themselves | 15:32 |
rick_h_ | I don't have those enabled by default in my buglisting so missed the reference. | 15:32 |
ivory | ah ok i should have said that they must be enabled | 15:33 |
rick_h_ | naw, my fault "bug column tags" should have been my clue | 15:34 |
rick_h_ | thanks, anyway, reviewing right now :) | 15:34 |
rick_h_ | ivory: r=me | 15:35 |
adeuring | rick_h_: another review. please: https://code.launchpad.net/~adeuring/launchpad/bug-1015667/+merge/113245 | 15:48 |
rick_h_ | if ! tmux has-session -t coms; then tmux new-session -s coms -n email -d mutt \; new-window -n irc -d "ssh db" | 15:49 |
rick_h_ | fi | 15:49 |
rick_h_ | adeuring: on it | 15:49 |
rick_h_ | oops | 15:49 |
adeuring | rick_h_: thanks! | 15:49 |
rick_h_ | adeuring: r=me | 15:53 |
adeuring | rick_h_: thanks again! | 15:53 |
yaguang | hi,all | 16:31 |
yaguang | I am installing launchpad in my local envirenment | 16:31 |
yaguang | now everything works well except for mail serivces | 16:32 |
yaguang | all mail are send to localhost | 16:32 |
yaguang | so the user can not receive any mail notifications | 16:32 |
yaguang | i have installed postfix and mailman | 16:33 |
yaguang | and i can send mail by using the CLI mail tool | 16:33 |
yaguang | can any one help me on configing mail | 16:33 |
=== matsubara-afk is now known as matsubara | ||
yaguang | any one? | 16:43 |
sinzui | yaguang, the development instance is not designed to send out emails | 16:49 |
sinzui | yaguang, Lp distributed version is for testing and development so it is does not provide the entire Lp stack and configuration needed to run for production use. | 16:50 |
yaguang | so if I like to deployment a local launchpad just the same as https://launchpad.net | 16:50 |
yaguang | shouldn't I use a development branch ? | 16:51 |
yaguang | is it ? | 16:51 |
sinzui | I think this is just a config issue, but I do not know what must be set. yaguang the files under lib/canonical are not free. You need to replace the images to run the instance for any non-testing use | 16:52 |
sinzui | yaguang, everything under lib/lp is free to change and distribute | 16:52 |
yaguang | thanks | 16:53 |
yaguang | now I see all mail is send to localhost | 16:54 |
sinzui | yaguang, There are 2 kinds of config in each dir under ./configs | 16:54 |
sinzui | the zcml sets up zope services, of which mail might belong. there is also a -lazr.conf file that sets most of the host names and certainly knows about email | 16:55 |
yaguang | the mail header now is like this | 16:57 |
yaguang | From root@localhost Fri Jun 29 05:42:06 2012 | 16:57 |
yaguang | X-Original-To: root@localhost | 16:57 |
yaguang | MIME-Version: 1.0 | 16:57 |
yaguang | Content-Type: text/plain; charset="utf-8" | 16:58 |
yaguang | Content-Transfer-Encoding: quoted-printable | 16:58 |
yaguang | Date: Fri, 29 Jun 2012 05:42:04 -0000 | 16:58 |
yaguang | From: Launchpad Bug Tracker <21@bugs.launchpad.sinasws.com> | 16:58 |
yaguang | To: freedomhui@gmail.com | 16:58 |
yaguang | Reply-To: Bug 21 <21@bugs.launchpad.sinasws.com> | 16:58 |
_mup_ | Bug #21: "Display Settings:" "untranslated" shows translated entries <lp-translations> <Launchpad itself:Fix Released by carlos> < https://launchpad.net/bugs/21 > | 16:58 |
yaguang | Sender: bounces@canonical.com | 16:58 |
=== deryck is now known as deryck[lunch] | ||
rick_h_ | jcsackett: heh so spoke too soon, these tests in test_distroseriesdifferences are going to need some updates for wait()/timing issues. | 17:47 |
=== Ursinha is now known as Ursinha-lunch | ||
jcsackett | rick_h_: well damn. | 18:04 |
rick_h_ | jcsackett: just a heads up since you were asking about it. I've filed an XXX and will try to get back to it, but a bit much atm. | 18:04 |
jcsackett | dig. | 18:12 |
=== rick_h_ changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: gmb | Firefighting: - | Critical bugs: 4.0*10^2 | ||
=== deryck[lunch] is now known as deryck | ||
=== matsubara is now known as matsubara-afk | ||
sinzui | jcsackett, do you have time for a talk? | 20:51 |
jcsackett | sinzui: sure. give me a moment to find a google+ compatible device. :-) | 20:52 |
jcsackett | sinzui: had a few flubs, hangout started now | 21:00 |
* sinzui no see you | 21:01 | |
jcsackett | it's telling me you're not online. | 21:01 |
* sinzui restarts | 21:02 | |
sinzui | Well I see a whole lot of black screen after I joined your hangout | 21:03 |
jcsackett | huh. | 21:03 |
jcsackett | i'm not even in a hangout now. | 21:03 |
* jcsackett bummed that in the 21st century video chat still involves so much faffing about. | 21:03 | |
sinzui | I just got that message | 21:03 |
sinzui | create another hangout and I will poll for it | 21:04 |
jcsackett | ok. | 21:06 |
wallyworld_ | wgrant: sinzui: http://people.canonical.com/~ianb/enhanced-newteam-picker.png | 22:04 |
Bert_2 | Hi, on https://dev.launchpad.net/Running/LXC it says that the usage of 12.04 is highly adviced, however the command to create the lxc container has lucid and not precise in it, is this a mistake ? | 23:42 |
StevenK | The host should be precise, the container should be lucid | 23:45 |
Bert_2 | StevenK: could you tell me why the container is best to be lucid ? | 23:45 |
StevenK | Because the production environment of Launchpad is still lucid for the time being. | 23:45 |
Bert_2 | I see, perfect | 23:46 |
StevenK | wgrant: Getting confused -- I want to check getUtility(IAccessArtifactGrant).findByArtifact([self], [user]) , or am I missing something? | 23:52 |
StevenK | wallyworld_: Your QA for r15542 is up. | 23:53 |
wgrant | StevenK: That will check artifact grants for that user, ignoring team memberships and policy grants. It is useless for access checks. | 23:54 |
StevenK | wgrant: I couldn't figure what the heck IBug.userCanView() was calling, I got to bugtasksearch and went cross-eyed. | 23:56 |
wgrant | StevenK: get_bug_privacy_filter | 23:57 |
StevenK | Ah | 23:58 |
wgrant | You can see what the job does. | 23:58 |
Bert_2 | I am for some reason not able to login to the newly created lxc container, not with ubuntu ubuntu or my regular login (which I get from ldap), is this normal ? | 23:58 |
wgrant | Bert_2: lxc-create copies the system user across by default. If it has no local password that's probably not going to work well. | 23:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!