/srv/irclogs.ubuntu.com/2012/07/03/#launchpad-dev.txt

StevenKwgrant: Bwahahaha00:01
* StevenK stabs buildbot01:37
nigelbwgrant: Maybe you are the monitoring :)01:50
nigelbI'm contemplating writing a vagrant script for LP.01:50
nigelbSo that it spins up a virtual machine in one command.01:50
nigelbBecause I'm lazy.01:51
nigelbStevenK: A local python job posting wanted "experience with Launchpad"01:51
StevenKHaha01:55
nigelbI was tempted to apply and ask if my "experience" was sufficient ;-)01:55
lifelessnigelb: elliot wrote one.02:04
nigelblifeless: oh. Is it around somwhere?02:04
lifelessdunno02:05
rick_h_lifeless: around? Want to check on the info I should be looking into with rt combo loader/convoy?02:14
lifeless-> ops02:16
statiknigelb, lifeless: the vagrant script I wrote didn't actually bring up LP, it was when I was experimenting with the microservice stuff03:46
statiksome good docs here though https://speakerdeck.com/u/mitchellh/p/develop-and-test-configuration-management-scripts-with-vagrant03:46
nigelbah!03:47
wallyworld_StevenK: around?03:49
lifelessnigelb: in NZ now?03:57
lifelessstatik: o/ wotcha. Off the boat now?03:57
nigelblifeless: not yet :)03:59
nigelbI hope I get to NZ in time for kiwipycon.03:59
lifelesscool04:02
lifelessI might get to entertain you then :)04:02
nigelbI heard :)04:02
StevenKwallyworld_: Was noming. What's up?04:03
wallyworld_StevenK: i think there's a 2nd issue with the change to bug info type in the privacy portlet but i wanted a 2nd opinion04:03
wallyworld_the issue is that we are now calling the transitionToInfoType api directly04:04
wallyworld_but previously the view would have been used via a post04:04
wallyworld_and the view would have published a change event04:04
wallyworld_but we don't do that now04:04
wallyworld_and in fact, the non js version does use the view so does do the event04:04
wallyworld_am i missing something?04:05
StevenKWhich event?04:05
wallyworld_ObjectModifiedEvent04:05
StevenKThat should be fired via the JS calls transitionToInformationType over the API04:05
wallyworld_i couldn't see where in transitionToInformationType it was fired04:06
StevenKIt isn't04:06
StevenKIt's done in the LAZR machinery04:06
wallyworld_oh, so the api layer fires the event?04:06
StevenKYah04:06
wallyworld_ah, ok. makes sense now. thanks04:06
wallyworld_i didn;t realise the lazr stuff didi that04:07
statiklifeless: yep, back in real life, finishing up an 18-hour first day on the new job :)04:07
lifelessenjoying it ?04:07
StevenKwallyworld_: Neither did I, until I figured out why the heck I was getting two visibility change events for a bug.04:07
statikyeah man I love the firehose feeling at the start of a project04:07
wallyworld_StevenK: ah yeah, i do recall that now04:08
* StevenK stabs buildbot and sets it on fire.04:13
lifelessstatik: nice. And you said it was rails ?04:14
StevenKbuilding04:15
StevenKETA in04:15
StevenK~ 6 hrs 53 mins04:15
spmheya statik!04:15
StevenKReally, buildbot? REALLY?04:16
huwshimiWhy do I get the feeling Launchpad is not playing nice with my virtualhosts05:05
StevenKwgrant, wallyworld_: https://code.launchpad.net/~stevenk/launchpad/no-proprietary-multi-pillar-bug-vocab/+merge/11314905:09
wallyworld_StevenK: do you need both context and IBug.providedBy(context) or does providedBy error on being passed None?05:11
StevenKwallyworld_: IBug.providedBy(None) returns False, so I'll drop the first bit05:12
wallyworld_StevenK: i'd replace 'PROPRIETARY' in the test by InformationType.PROPRIETARY.value or whatever the correct expr is05:12
StevenKwallyworld_: How? It isn't there!05:13
StevenKI'm trying to look it up by the token05:13
wallyworld_sure but you can get the token from the enum05:13
StevenKwallyworld_: The existing test for proprietary_information_type.disabled uses PROPRIETARY05:14
wallyworld_you mean 'PROPRIETARY' with the ''?05:14
StevenKYup05:14
wallyworld_ok then05:14
wallyworld_StevenK: i'd also simplify the if statement for the proprieryary_allowed, i don't think it adds much value having 2 booleans05:15
StevenKwallyworld_: We need them. The first one is backed onto the feature flag05:15
StevenKIt will be simplified when proprietary_information_type.disabled dies05:16
wallyworld_so why no 'if not proprietary_disabled and IBug.providedBy(context)....'05:16
wallyworld_not05:16
StevenKOh05:16
StevenKI get it05:16
wallyworld_just a thought since it's verbose with the extra boolean and it reads ok without i think05:17
StevenKwallyworld_: http://pastebin.ubuntu.com/1072538/05:18
StevenKIt reads better against -r submit:, but meh05:18
wallyworld_i think it's not quite right?05:19
StevenKThe test passes05:19
wallyworld_ah, i missed the () around the 2nd bit05:20
StevenKI'm looking forward to display_userdata_as_private.enabled dying, the vocab will shrink in the wash remarkably.05:21
wallyworld_i think it will read better without the (). if not proprietary_disabled or not IBug.providedBy(context) or len(context.bugtasks) < 205:21
StevenKwallyworld_: That will cause PROPRIETARY to leak05:22
wallyworld_ it's meant to the equivalent to your condition, but with the () removed05:22
wallyworld_i think i have an or where i want an and05:23
wallyworld_whatever works05:23
StevenKwallyworld_: So I'm going to need brackets anyway, since there is a line break in the middle05:24
wallyworld_yeah, maybe put the () bit on the second line05:24
wallyworld_so it's all together05:24
StevenKif not proprietary_disabled and not (05:24
StevenK    IBug.providedBy(context) and05:24
StevenKSigh05:25
StevenK    IBug.providedBy(context) and len(context.bugtasks) > 1):05:25
StevenKThat will likely cause wgrant to murder me.05:25
wallyworld_if not proprietary_disabled and05:26
wallyworld_not(....)05:26
wallyworld_whatever you feel is best, i don't mind05:27
wallyworld_r=me anyway05:28
StevenKwallyworld_: Did you notice me fixing your test? :-)05:29
wallyworld_oh, didn't realise it was my test. thans :-)05:29
StevenKwallyworld_: I thought test_vocabulary_items_project was yours05:29
wallyworld_it may have been05:30
wallyworld_probably was05:30
wallyworld_i just can't recall right at the moment05:30
wallyworld_my head is stuck in info type js mollasis05:30
wgrantStevenK: Wrong05:31
wgrantStevenK: The bugtask count isn't relevant -- it's the number of distinct pillars that matters.05:32
StevenKwgrant: Ah, so I need .affected_pillars05:32
StevenKwallyworld_: http://imgur.com/gallery/L29C605:37
wallyworld_StevenK: lol. i had heard about a google streetview car crashing05:38
=== matsubara-afk is now known as matsubara
StevenKwgrant: http://pastebin.ubuntu.com/1072565/ is more to your liking?05:49
=== Guest65630 is now known as Ursinha
=== Ursinha is now known as Guest68258
wgrantStevenK: Something like that, yeah06:15
StevenKssl.SSLError: [Errno 8] _ssl.c:504: EOF occurred in violation of protocol06:17
StevenKzsh: exit 1     ec2 land --no-qa06:17
StevenKBlink06:17
huwshimiSomeone please approve this: https://code.launchpad.net/~huwshimi/launchpad-news-wordpress-theme/hold-me-back-im-fixing-the-type/+merge/11315906:32
* huwshimi is ducking out for a minute, will be back later06:35
adeuringgood morning07:17
=== gmb changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: gmb | Firefighting: - | Critical bugs: 4.0*10^2
mgzgmb: where was yellow's launchpad kanban updating script?09:00
gmbmgz lp:lp2kanban.09:01
mgzta09:01
czajkowskimaxb: gmb morning09:09
gmbMorning czajkowski.09:09
czajkowskigmb: hows things up north09:11
czajkowskiis it grimm and wet like London :/09:11
gmbczajkowski, That's what we call "summer"09:12
gmbBut I can spot a teeny tiny bit of blue sky09:12
gmbSo all is not lost.09:12
maxbczajkowski: a bit grey today, I suppose, but Saturday was lovely at least :-)09:18
czajkowskimaxb: lets hope it's nice this Saturday too :)09:18
jamgmb: you're on-call today? I think mgz has 3 nice-and-tiny branches up for review if you feel like starting off easy09:28
gmbjam, I'll take a look presently. Thanks for the heads-up.09:30
jam(I'm trying to see if I can get a clean run on precise today on my desktop, we're pretty close)09:30
gmbAwesome09:30
jamwell, it won't happen *today* given the commit queue, but something like that.09:30
gmbjam Incidentally, when run in parallel, I said we only ran 1800 tests. That's not true; it's just that buildbot only _reports_ that many tests. We ran 18,000. So the stream is broken again somewhere.09:31
gmbHaven't had chance to try looking into it yet though.09:31
jamgmb: joy... but i'm glad to hear that the test suite is running without hanging/etc.09:31
gmbIndeed09:31
mgzreminds me, I haven't checked what subunit does with NUL characters yet09:32
mgzI don't think it minds.09:32
lifelessbinary safe stream09:34
lifelessparticularly if you are using the chunk serialiser09:34
lifeless(which LP is)09:34
gmbmgz, Approved all your branches.10:36
mgzta... will have to create these cards in the next lane then :)10:38
=== rick_h_ changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: gmb, rick_h | Firefighting: - | Critical bugs: 4.0*10^2
* gmb -> afk for an appointment10:50
danilosgmb, hi, I wonder if you can please ec2 submit https://code.launchpad.net/~danilo/launchpad/bug-1000642-drop/+merge/112306 for me (stub submitted it but it seems to have failed with something unrelated to the branch: https://pastebin.canonical.com/69307/)10:50
danilosdamn, bad timing :)10:50
rick_h_danilos: I can take a peek10:50
danilosrick_h_, thanks10:50
=== matsubara is now known as matsubara-afk
rick_h_danilos: ok, off to ec2 land11:02
danilosrick_h_, ta11:10
cjwatsongmb,rick_h_: Might an OCR be able to have a look over https://code.launchpad.net/~cjwatson/launchpad/queue-api-readonly/+merge/113202 ?12:32
cjwatsonExtracted from a previous much bigger branch.12:32
rick_h_cjwatson: looking up12:32
cjwatsonStill 920 lines, oops, I thought it would be a bit shorter than that.12:32
cjwatsonI can split it up further if I have to.  This seems like a fairly reasonable logical chunk though.12:34
rick_h_ok, will take a peek. I'll feel better knowing it could have been worse :)12:34
cjwatsonThe original was 164712:35
rick_h_cjwatson: r=me with two points to bring up13:27
cjwatsonrick_h_: Thanks.  Do you think len() is preferable there then?  It was within the same object so I figured the "privacy" (insofar as Python has any) didn't matter.13:30
rick_h_cjwatson: yea, especially since you changed the other cases, it's one part consistant at that point as well13:30
cjwatsonlen(self.sources) will involve constructing a concrete list, although maybe that doesn't matter since it's short and will be cached.13:30
rick_h_I guess when I wrote the point I initially wondered if you were doing that to avoid the cache13:31
rick_h_but then didn't seem like it so figured if you were going to use/go through the cache everyone should13:31
cjwatsonFair13:31
rick_h_to avoid one method saying one thing "there's 2 here" but the cache not saying that13:32
cjwatson#245 was a drive-by what-I-thought-was-a-bug-fix, but I can't prove off the top of my head that it's correct so how about I just drop it - it's not required as part of this branch13:32
rick_h_not that I see a bug with mix matched results/etc but just letting you know where my brain's at reading it13:32
cjwatsonYeah13:32
rick_h_yea, sorry I'm just not all a pro enough at this and chaning r/o on stuff makes me want to find a list of people writing to it to make sure no one is13:33
cjwatsonNot a problem13:33
deryckadeuring, https://plus.google.com/hangouts/_/3ac5f6358bc446e2018dedac8a0d188891410910?authuser=0&hl=en13:34
=== benji___ is now known as benji
adeuringrick_h_: could you please review this MP: https://code.launchpad.net/~adeuring/lazr.jobrunner/bug-1015667/+merge/113228?14:52
rick_h_adeuring: sure thing14:53
rick_h_abentley: didn't you do some magic to look at the queue payload without pulling it out of the queue?14:57
abentleyrick_h_: Yes, you basically just read the queue without confirming that you've read the messages.  It's the core of from lazr.jobrunner.celerytask import list_queued, and abel's already looked at it.14:59
rick_h_ok, so my thing with this is that the function is called 'inspect-queue' which seems innocous, but it clears things.15:00
rick_h_should it stick things back on the queue?15:00
adeuringrick_h_: well... the fact that the messages are gone can be a positive side effect15:01
adeuringin our case15:01
rick_h_right, I understand in our use case, but I'm looking at this from the outside as someone who gets this package and tries to use it15:01
rick_h_would clear-queues be better?15:02
rick_h_at least then someone coming along would be a bit more hesitant to run the command15:02
adeuringrick_h_: ok, makes sense15:02
rick_h_adeuring: ok r=me with naming clarification. Thanks.15:04
adeuringrick_h_: thanks!15:04
abentleyrick_h_: It's mystifying to me that drain_queues(retain=True) doesn't work, but abel says it doesn't.15:04
rick_h_abentley: yea, I'm not tinkered with any of this so taking that stuff at face value as far as review goes.15:05
rick_h_abentley: is there some way to tell what the local branch name was from a branch pushed to LP?15:11
abentleyrick_h_: The branch nick in the revisions defaults to the last component of the path.15:12
rick_h_right, but I pushed it to a manual name and don't have that branch locally so I must have messed up and been on an existing branch15:13
rick_h_now in the confusion can't tell where the changes I made yesterday are :/15:13
abentleyrick_h_: Pushing it up to a manual name is not going to change the branch nicks in the revisions.15:14
ivoryrick_h_: could you take a look at this?  https://code.launchpad.net/~ivo-kracht/launchpad/bug-921901/+merge/11323415:15
abentleyrick_h_: "bzr log --long -l1 lp:$BRANCHNAME" should tell you the last path component of the branch.15:15
rick_h_ty much abentley15:15
rick_h_ivory: I'm not following the bug that you're fixing here. When I look at the current live site, the tag links match what the bug says they should.15:23
rick_h_ivory: what was the difference in the generated urls you altered?15:24
ivoryrick_h_: as i understand it they should link to a project group15:27
rick_h_ivory: so I'm seeing: http://pastebin.ubuntu.com/1073255/15:28
rick_h_the only difference I can see is there's a trailing / in the "Should be" urls15:29
ivoryrick_h_: thats weird because i'm at launchpad/+bugs/... if i click on a tag15:31
ivoryinstead of launchpad-project/+bugs/...15:31
rick_h_oh oh ok, I was looking at the tags in the sidebar, not in the buglisting themselves15:32
rick_h_I don't have those enabled by default in my buglisting so missed the reference.15:32
ivoryah ok i should have said that they must be enabled15:33
rick_h_naw, my fault "bug column tags" should have been my clue15:34
rick_h_thanks, anyway, reviewing right now :)15:34
rick_h_ivory: r=me15:35
adeuringrick_h_: another review. please: https://code.launchpad.net/~adeuring/launchpad/bug-1015667/+merge/11324515:48
rick_h_if ! tmux has-session -t coms; then tmux new-session -s coms -n email -d mutt \; new-window -n irc -d "ssh db"15:49
rick_h_fi15:49
rick_h_adeuring: on it15:49
rick_h_oops15:49
adeuringrick_h_: thanks!15:49
rick_h_adeuring: r=me15:53
adeuringrick_h_: thanks again!15:53
yaguanghi,all16:31
yaguangI am installing launchpad  in my local envirenment16:31
yaguangnow everything works well except for mail serivces16:32
yaguangall mail are send to localhost16:32
yaguangso the user can not receive any  mail notifications16:32
yaguangi have installed postfix  and mailman16:33
yaguangand  i can send mail by using the CLI mail  tool16:33
yaguangcan any one help me  on configing mail16:33
=== matsubara-afk is now known as matsubara
yaguangany one?16:43
sinzuiyaguang, the development instance is  not designed to send out emails16:49
sinzuiyaguang, Lp distributed version is for testing and development so it is does not provide the entire Lp stack and configuration needed to run for production use.16:50
yaguangso if I like to deployment a local launchpad  just the same as  https://launchpad.net16:50
yaguangshouldn't  I use  a development  branch ?16:51
yaguangis it ?16:51
sinzuiI think this is just a config issue, but I do not know what must be set. yaguang the files under lib/canonical are not free. You need to replace the images to run the instance for any non-testing use16:52
sinzuiyaguang, everything under lib/lp is free to change and distribute16:52
yaguangthanks16:53
yaguangnow  I see all mail is send to  localhost16:54
sinzuiyaguang, There are 2 kinds of config in each dir under ./configs16:54
sinzuithe zcml sets up zope services, of which mail might belong. there is also a -lazr.conf file that sets most of the host names and certainly knows about email16:55
yaguangthe mail header now is like this16:57
yaguangFrom root@localhost  Fri Jun 29 05:42:06 201216:57
yaguangX-Original-To: root@localhost16:57
yaguangMIME-Version: 1.016:57
yaguangContent-Type: text/plain; charset="utf-8"16:58
yaguangContent-Transfer-Encoding: quoted-printable16:58
yaguangDate: Fri, 29 Jun 2012 05:42:04 -000016:58
yaguangFrom: Launchpad Bug Tracker <21@bugs.launchpad.sinasws.com>16:58
yaguangTo: freedomhui@gmail.com16:58
yaguangReply-To: Bug 21 <21@bugs.launchpad.sinasws.com>16:58
_mup_Bug #21: "Display Settings:" "untranslated" shows translated entries <lp-translations> <Launchpad itself:Fix Released by carlos> < https://launchpad.net/bugs/21 >16:58
yaguangSender: bounces@canonical.com16:58
=== deryck is now known as deryck[lunch]
rick_h_jcsackett: heh so spoke too soon, these tests in test_distroseriesdifferences are going to need some updates for wait()/timing issues.17:47
=== Ursinha is now known as Ursinha-lunch
jcsackettrick_h_: well damn.18:04
rick_h_jcsackett: just a heads up since you were asking about it. I've filed an XXX and will try to get back to it, but a bit much atm.18:04
jcsackettdig.18:12
=== rick_h_ changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: gmb | Firefighting: - | Critical bugs: 4.0*10^2
=== deryck[lunch] is now known as deryck
=== matsubara is now known as matsubara-afk
sinzuijcsackett, do you have time for a talk?20:51
jcsackettsinzui: sure. give me a moment to find a google+ compatible device. :-)20:52
jcsackettsinzui: had a few flubs, hangout started now21:00
* sinzui no see you21:01
jcsackettit's telling me you're not online.21:01
* sinzui restarts21:02
sinzuiWell I see a whole lot of black screen after I joined your hangout21:03
jcsacketthuh.21:03
jcsacketti'm not even in a hangout now.21:03
* jcsackett bummed that in the 21st century video chat still involves so much faffing about.21:03
sinzuiI just got that message21:03
sinzuicreate another hangout and I will poll for it21:04
jcsackettok.21:06
wallyworld_wgrant: sinzui: http://people.canonical.com/~ianb/enhanced-newteam-picker.png22:04
Bert_2Hi, on https://dev.launchpad.net/Running/LXC it says that the usage of 12.04 is highly adviced, however the command to create the lxc container has lucid and not precise in it, is this a mistake ?23:42
StevenKThe host should be precise, the container should be lucid23:45
Bert_2StevenK: could you tell me why the container is best to be lucid ?23:45
StevenKBecause the production environment of Launchpad is still lucid for the time being.23:45
Bert_2I see, perfect23:46
StevenKwgrant: Getting confused -- I want to check getUtility(IAccessArtifactGrant).findByArtifact([self], [user]) , or am I missing something?23:52
StevenKwallyworld_: Your QA for r15542 is up.23:53
wgrantStevenK: That will check artifact grants for that user, ignoring team memberships and policy grants. It is useless for access checks.23:54
StevenKwgrant: I couldn't figure what the heck IBug.userCanView() was calling, I got to bugtasksearch and went cross-eyed.23:56
wgrantStevenK: get_bug_privacy_filter23:57
StevenKAh23:58
wgrantYou can see what the job does.23:58
Bert_2I am for some reason not able to login to the newly created lxc container, not with ubuntu ubuntu or my regular login (which I get from ldap), is this normal ?23:58
wgrantBert_2: lxc-create copies the system user across by default. If it has no local password that's probably not going to work well.23:59

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!