/srv/irclogs.ubuntu.com/2012/07/03/#ubuntu-unity.txt

justjinxedso is 1.4 million votes enough for developers to decide to allow users to move the unity bar? ;)02:04
=== Guest84007 is now known as mfisch
=== mfisch is now known as Guest4997
thumperjustjinxed: where are these theoretical 1.4 million votes?02:41
thumperjustjinxed: however it is more complicated than that02:42
thumperit isn't the developers blocking it, but the designers02:42
justjinxedMy question is more an IF than IS. Id like to know how to contact the responsible parties. I've read a number of varying opinions from the "team" but it's hard to pinpoint if any of them are an authority or not.02:44
justjinxedand now I must run for now, :( guess ill come back tomorrow and finish hunting them down :)02:46
sil2100Trevinho: give me a sign when you're around07:55
popeysil2100, he'll be around from ~14UTC07:57
sil2100grrr07:57
sil2100Thanks07:57
smspillazanyone on this channel with an intel chip willing to test something quickly for me ?08:33
smspillazintel graphics hardware08:33
didrockssil2100: hey, I hope you are looking at the merge request and what I'm currently doing as soon, it will be your turn to do it :)08:42
didrockspopey: FYI ^08:42
sil2100didrocks: which MRQ?08:43
didrockssil2100: all of them, and the packaging update I'm doing, what is failing and such08:43
sil2100didrocks: since I'm looking at the Ibus one right now08:43
didrockssil2100: I mean, you need to monitor all merge request, look at when/why they are failing…08:43
sil2100didrocks: ok, looking at those as well, but I have to deal with some unity-lens thing right now08:44
didrockssil2100: indeed, but that shouldn't prevent monitoring merge requests :)08:45
didrocksjuts a kind reminder, I won't remind you anymore of this then ;)08:45
sil2100didrocks: but please do, since otherwise I won't know that I screwed up again ;) And we don't want that happening too frequently!08:45
didrockssil2100: well, I will reject the upload then, so you will learn that way ;)08:46
sil2100;)08:46
Mirvsmspillaz: o/ , although a meeting soon08:47
smspillazMirv: thanks, though I found a volunteer08:47
Mirvsmspillaz: ok, great08:47
sil2100seb128: hi!08:49
seb128sil2100, hey, how are you?08:49
sil2100seb128: fine, although it's really hot here in Poland, how about you?08:50
sil2100The heat is killing me08:50
seb128sil2100, I'm good, weather is just nice here (around 23°C)08:50
sil2100seb128: remember the SRU for unity-lens-video that we made last week?08:51
seb128sil2100, yes, it got accepted yesterday08:51
seb128is there an issue with it?08:51
sil2100seb128: no, no issue, but David found another fix08:52
seb128sil2100, for what issue?08:52
sil2100I mean, the busy dbus issue that was seemingly fixed with this version - he found one more place where the bug might happen and fixed it yesterday as well08:53
sil2100So it would be nice if we could release, ekhm, another SRU with the one more fix...08:53
sil2100...would that be possible?08:53
davidcalleseb128, dbus crash, there is a second dbus call in the code (for zeitgeist). I missed it last week.08:53
davidcalleseb128, sorry about that.08:54
seb128davidcalle, no worry08:54
seb128sil2100, yes, just do an update on top of the previous one08:54
sil2100seb128: is there a specific branch I should use? Or you don't care about bzr history?08:54
seb128sil2100, don't care about the history for the SRU08:56
seb128sil2100, but you can use the vcs for the quantal upload08:56
sil2100seb128: will do! Thanks08:56
seb128yw!08:56
=== yofel_ is now known as yofel
sil2100seb128: https://code.launchpad.net/~sil2100/unity-lens-videos/unity-lens-video-precise <- I pushed here again09:15
mhr3sil2100, btw for lenses != music, you'll just patch the icon paths? (/me hopes he doesn't need to do releases because of that)09:17
sil2100mhr3: no, I just patched those09:18
mhr3\o/09:18
=== zyga_ is now known as zyga
sil2100didrocks: just a quick question - if there is a green signal from everyone about unity stack trunk freeze, you're able to freeze it for a day? Or is there someone else I'll have to ask then?09:23
didrockssil2100: no, just tell me when to freeze :)09:24
didrockssil2100: and tell me for which projects I need to freeze09:24
didrocks(once ok)09:24
sil2100didrocks: thanks! For now I need to resolve this ibus issue though... need Trevinho for that best09:24
didrocksmhr3: it sucks to have to change the image path name btw at every new major version of unity09:24
didrocksyep :)09:24
mhr3didrocks, indeed, thoughts on where to centralize it?09:26
didrocksmhr3: I don't get why the path need to be versionned in fact09:26
mhr3didrocks, that makes two of us :)09:26
MCR1Hi :) Who is maintaining the Unity-team/staging PPA quantal ? Unity is broken there: Depends: compiz-core-abiversion-2012030509:26
didrocksmhr3: \o/09:26
didrocksMCR1: the ppa is automatic09:27
mhr3didrocks, perhaps a "current" symlink if nothing else ?09:27
didrocksMCR1: as told on it, it can have temporary ABI break and shouldn't be used09:27
mhr3didrocks, i mean instead of the version number09:28
didrocksyou want a symlink to the current version number?09:28
didrocksI'll try to start the discussion and discuss about that09:28
mhr3whatever to get of it09:28
didrocksand maybe we can discuss even more about the discussion09:29
sil2100didrocks, mhr3: maybe we'd like to have that for this release?09:29
didrocks:)09:29
didrockssil2100: no, the timing is too short09:29
mhr3sil2100, yea... i don't think all of us are that fast :)09:29
didrockssil2100: let's transition, and maybe transition again09:29
sil2100didrocks: ok09:29
didrocks(from 5 to 6 to I hope unversionned)09:29
MCR1The PPA also features a new Compiz version I would like to try to give feedback on fixed bugs, but the ABI break makes it impossible to test Unity with it :(09:30
didrocksMCR1: yeah, you need to ensure you have compiz and unity built against the same ABI version09:30
didrocksthe ABI break should be transient and fixed automatically when you get the next unity rebuild09:31
sil2100hm, the nux/unity fix for ibus that Trevinho is recommending seems to change the nux API09:31
didrocksMCR1: that's why I put this stenza on the ppa description:09:31
didrocksThis archive contains the latest builds generated from trunk, that have passed the unit tests, but didn't pass the user acceptance (autopilot) tests yet.09:31
didrocksUnless you are a developer and know what you do here, you should probably use the "unity-team/ppa" instead.09:31
MCR1Will it work if I build Unity from source ?09:32
didrocksMCR1: yeah, get the compiz from the ppa, install the -dev package and rebuild unity from source09:32
didrocksor wait for the next unity version coming to the ppa09:32
MCR1ok, thx a lot 4 the info.09:32
didrocksMCR1: yw :)09:32
didrockssil2100: not an issue, you plan to merge the nux bump to version 3, right?09:32
didrocksI still didn't see the packaging changes for it09:33
didrocksand the branch isn't merged yet but I think it's on your roadmap09:33
sil2100didrocks: I have it all prepared locally, since I'll have to refresh it when the freeze is on09:33
didrockssil2100: hum, you don't have the branch which defines the API version 3, right?09:34
sil2100didrocks: right now I can't do anything because I don't know if any important changes won't need to be merged in09:34
didrocksit's not merged AFAIK09:34
didrocksso not sure what you prepared09:34
sil2100didrocks: it's not, since it's waiting for right-before-the-freeze - since nux and unity need to have the 3.0 change merged in the same time, otherwise unity auto-merger won't work09:35
didrockssil2100: yeah, but it doesn't need to be right before the freeze09:35
didrocksyou do the nux work, push the branch, approve the merge09:35
didrocksthen, you do the unity work, push the branch, approve the merge09:35
sil2100didrocks: but with unity and nux we still wait for the ibus fix to get reviewed09:36
didrockssil2100: that's not a pre-requesite to this change, right?09:37
MCR1Is there a wiki or even better a script somewhere that helps me with building Unity from source ?09:37
sil2100didrocks: yes, but we want unity to be able to perform auto-build after merging the ibus fix, right?09:37
sil2100didrocks: once I merge in the 3.0 changes it won't build09:38
sil2100didrocks: or does the autobuilder use the nux trunk for building unity?09:38
didrockssil2100: why?09:38
didrockssil2100: it always take the new version of everything09:38
didrockswe won't be able to do without it otherwise09:39
sil2100didrocks: so it's not using -proposed? Just fresh from the trunks?09:39
didrocksremember my "local repo" I showed and emphasized many teams during the week sprint :)09:39
didrocksyeah09:39
didrocksthey are constantly adding API, without that, the merger won't work09:39
sil2100Still, since we want to release a new tarball, I'd like to have all the changes in the tarball09:39
didrockssil2100: what's the link with that?09:40
sil2100So, if I release the new tarball now, and then add the ibus fix, I'll have to add it as a patch, right?09:40
didrocksI don't speak about a release09:40
didrocksI'm speaking about 2 branches to merge09:40
didrocksto bump the new api09:40
didrocksand also, about the packaging update you need to do for it09:40
sil2100Ah, k09:40
didrocksyou can do that right now instead of waiting on the ibus fix :)09:41
sil2100I was talking about the packaging update09:41
didrockspackaging udpate != tarball09:41
didrocksso, what you need to do:09:41
sil2100But on the other hand, I could probably for now just do a packaging update with normal patches09:41
didrocks- ensure jay's nux branch is ok, pushing an updated packaging for version 3, approve the nux merge09:41
sil2100And then just release everything as a new tarball09:41
didrocks- ensure jay's unity branch is ok, pushing an updated packaging for version 3, approve the unity merge09:42
didrocksand that's it09:42
sil2100Well, we were already testing Jay's branch09:42
didrockswhy are you speaking about patches? :/09:42
sil2100Since my ppa uses nux 3.0 now anyway09:42
didrocksI'm speaking about merge in trunk09:42
sil2100Yes, but with the merge to trunk we need to do a merge to packaging too, right?09:42
didrocksbut they are not merged in trunk, right?09:42
didrocksyeah09:42
didrocksthat's why I'm telling, doing it now09:42
didrocksand approving the trunk merge09:42
sil2100They are not, but those won't work if you don't merge into packaging, right?09:42
didrocksnow09:43
didrocks:)09:43
sil2100So that's why I'm taalking about packaging09:43
didrocks11:41:57   didrocks | - ensure jay's nux branch is ok, pushing an updated packaging for version 3, approve the nux merge09:43
sil2100That's what I'll do now09:43
didrocksand same for unity09:43
didrocksthanks :)09:43
didrocksping me to review your packaging update09:43
sil2100As I said, we already tested nux 3.009:43
didrocksand that I push it09:43
sil2100So it'll just be an easy task09:43
didrocksgreat09:44
didrockssil2100: there is no difference than any other package update09:44
didrocksyou see that I'm updating a lot the packaging in advance of time09:44
didrockslike because of new files09:44
didrocksor because of path changes09:44
didrocksthat's exactly the same case here09:44
didrocks(or new build-dep)09:44
sil2100didrocks: sorry about that, now when I think about it I could have really just pushed it sooner09:51
didrockssil2100: no worry, hope you get it now ;)09:51
didrocksit's really like any other package update09:51
sil2100didrocks: I just seemed to got locked-up in the idea that I need to wait with the packaging for the tarball09:51
didrockssil2100: fortunatly not :)09:51
sil2100didrocks: that it doesn't make sense to push it now if the tarball will be released later ;p09:52
didrockssil2100: at least, we will get this hopefully merged and built before trevhino is here for the ibus thingy09:52
didrocksjust ping me with the package update09:52
sil2100didrocks: the thing is that I thought that it's not good to do it without the new tarball - since we're essentially changing the name to nux-3.0, where the version number in packaging will be still 2.*09:53
didrockssil2100: no09:53
didrockssil2100: you are changing the packaging now09:53
didrocksand we will push it just before setting the merge proposal to approve09:53
didrocksand so, we will get the new packaging :)09:53
sil2100Just to get this straight - can I change the major number of the nux version to 3 ?09:54
sil2100In packaging?09:54
sil2100Since normally, when changing the major number, I was doing a merge-upstream with the new tarball09:57
sil2100didrocks: ^ ;)09:59
didrockssil2100: right10:01
didrockssil2100: change the packaging and push it to me :)10:01
MCR1didrocks, regarding: https://code.launchpad.net/~mc-return/compiz/compiz.merge-plugin-stackswitch/+merge/111736 - do you mean our discussion here ?10:08
didrocksMCR1: no, was in private with duflu10:09
didrocks(PM)10:09
MCR1ah, ok - *confused*10:09
sil2100didrocks: https://code.launchpad.net/~sil2100/nux/ubuntu-3.0 <- ;) ?10:10
sil2100brb10:10
didrocksMCR1: basically, we are using the packaging to build an upstream source to push to the ppa, as you added some files and nobody updated the package, it failed10:11
didrocksMCR1: now, it's fine10:11
MCR1didrocks: I am working on getting *forgotten* plug-ins to lp:compiz, we did not have that problem with workspacenames though10:11
MCR1but if it is fine now, it is great 8-)10:12
MCR1thanx10:12
didrocksyw :)10:13
didrockssil2100: looks good to me :)10:13
didrockssil2100: pushed, you can ack the nux merge now10:16
sil2100didrocks: approved10:41
sil2100(commit message was missing)10:41
sil2100;)10:41
didrockssil2100: well, you approved it before pushing the branch, thanks god you forgot the commit message :)10:42
sil2100didrocks: I did? I think I did that by accident - damn, good for that missing commit message...10:43
sil2100didrocks: eh, conflict10:58
sil2100Oh, right, but I can push to that branch actually10:58
sil2100Fixing10:59
MCR1Yeah, my second contribution to Ubuntu/Compiz: http://bazaar.launchpad.net/~compiz-team/compiz/0.9.8/revision/327711:06
MCR1:)11:06
MCR1btw, I also got a contribution for Unity: https://code.launchpad.net/~mc-return/unity/unity.merge-reduce-png-filesizes/+merge/11097811:10
=== MacSlow is now known as MacSlow|lunch
didrocksMCR1: sweet! let's wait for upstream to review them :)11:28
didrocksMCR1: btw, about the recompression, we already have that automatically on the binary package11:29
MCR1didrocks: It is nothing special, but probably should be done11:29
MCR1your png files are not compressed very well11:29
MCR1I used Trimage image compressor to optimize them11:30
MCR1ofc more could be done11:30
MCR1most of the files could use indexed colors as well (8bit instead of 24+8bit) without any visual regression as most of the files do not use more than 256 colors anyway11:31
MCR1and alpha is empty11:31
sil2100didrocks: I also prepared a distro branch for unity 6.0 with the new nux: https://code.launchpad.net/~sil2100/unity/ubuntu-6.011:32
sil2100But nux is still building11:33
MCR1didrocks: You can check it yourself: simply install the package trimage and drag and drop all .png files there11:33
didrocksMCR1: hum, weird, we maybe have dh_scour which is broken then11:33
MCR1didrocks: you will save around 80kB11:33
didrockssil2100: well, that's fine, we can ack it now11:33
didrockssil2100: as my dep system is working :)11:33
didrockssil2100: FYI, I'm merging you content11:34
didrockssil2100: as you didn't get the latest unity packaging branch11:34
MCR1Once I got my build and test system for Unity/Compiz working here I plan to help with fixing more important stuff as well :)11:35
didrockssil2100: libnux-3.0-dev (>= 3.0.0-0ubuntu1), is somewhat wrong as a build-dep11:35
didrocksMCR1: sweet!11:35
didrockssil2100: better to take 3.0.0 to enable backporting11:36
didrockssil2100: I'm fixing that11:36
sil2100didrocks: ah, ok, sorry about that11:37
didrockssil2100: and you dont' want to bump the version yet on that case :)11:37
sil2100You mean, unity to 6.0?11:38
didrockssil2100: yeah11:38
didrocksdo that once you will release :)11:38
didrockssil2100: pushed to lp:ubuntu/unity11:38
didrocksyou can approve the MR11:38
sil2100Why not now? Since I already bumped the version for nux to 3.0, right? So we theoretically could have done the same for unity?11:39
didrockssil2100: because merge-upstream won't be happy11:39
didrockssil2100: I didn't change it for nux but it should have been 3.0~something11:39
didrockssil2100: because now, the version in the staging ppa are higher than the revision that would be in the distro11:40
sil2100Ah, right, we'll have to do the trick you did with compiz on the sprint11:40
didrocksit will be 3.0+bzr<foo>11:40
didrockseven if they are older11:40
sil2100Right11:41
sil2100didrocks: the tests failed for the unity nux-3.0 branch12:32
sil2100Could not open X display?12:32
didrockssil2100: there is no X in the merger12:32
sil2100xvfb?12:32
didrocksyep12:33
didrockssil2100: you should check that with upstream12:33
didrocksseems a test is flacky or broken with the new nux :)12:33
sil2100But it doesn't even say which test failed, geh12:34
sil2100I'll pick this up with Jay once he's back12:34
didrockssil2100: well, all the output is from upstream, they should fix it to tell which one :)12:35
sil2100Annoyiiiing!12:37
sil2100;)12:37
didrocksheh ;)12:37
=== MacSlow|lunch is now known as MacSlow
=== _salem is now known as salem_
sil2100seb128: how's the unity-lens-video SRU branch? Was it ok?13:07
seb128sil2100, sorry I was out when you pinged and I got busy, I will have a look now13:08
sil2100seb128: thanks13:08
seb128sil2100, yw!13:12
sil2100Trevinho: regarding that ibus fix13:52
sil2100Trevinho: was that something that got recently introduced? That it's broken?13:52
sil2100Trevinho: and I see you modify the nux headers13:53
Trevinhosil2100: we had some issues... first of all we didn't properly filter the meta keys in textentry, also we didn't support ibus release activation key... so I wanted to change the thing from nux...13:54
sil2100Trevinho: well, I'm waiting for Brandon as well to be honest - I have some bug-related things for him!13:57
sil2100But anyway, I think that it would be REALLY nice to have this ibus thing fixed with 6.913:58
sil2100*6.013:58
=== Guest4997 is now known as mfisch
sil2100So I'd say it's a bit of a blocking issue - although if jaytaoko will think that it's a risky change or something, we'll then release without it13:59
Trevinhosil2100: code is fixed... so... we only have to get it in trunk :)13:59
sil2100Trevinho: ;)13:59
didrocksTrevinho: is it a regression from 5.x ?14:00
sil2100Trevinho: but commits on both sides are needed, right? Bot the nux and unity side14:00
=== arges is now known as arges_afk
Trevinhodidrocks: mhmh a little... I pushed a different branch in 5.0 that fixes the key filtering without changing nux and being a little bit permissive to avoid breakage...14:01
Trevinhosil2100: yes, we need both nux and unity14:01
didrockssil2100: so it's a regression, and we won't take it into quantal without the bug fixed :)14:02
jaytaokoTrevinho: so you are trying to get your branches in for this release?14:04
sil2100didrocks: so it's, like I said, a blocking issue then? But for reals ;)14:04
sil2100jaytaoko: well, it seems to be an urgent fix then14:04
didrockswell, it is, right, no regrssion for us14:04
didrocksshould have been dealt earlier, but well14:04
Trevinhodidrocks: yes I opened a bug to track it since I discovered: https://bugs.launchpad.net/unity/+bug/101635414:05
ubot5Ubuntu bug 1016354 in unity "IBus can't be activated on dash or HUD since r2428" [High,In progress]14:05
Trevinhojaytaoko: we should yes14:05
jaytaokosil2100: as I said to Trevinho before, the code looks fine. But I was hoping bschaefer could give a second opinion because I don't know the details of the issues14:05
jaytaokosil2100: bschaefer is not awake yet I think (eastern US)14:06
sil2100jaytaoko: could you test build it and see if it doesn't break anything obvious?14:06
jaytaokosil2100: sorry bschaefer is in western US14:07
jaytaokosil2100: sure14:07
sil2100jaytaoko: thanks!14:08
didrockssil2100: also, do you know about the compiz release status?14:09
didrocksas Timo is doing it14:09
sil2100didrocks: not sure, I knew he was busy yesterday, but I'll ask him in a moment14:11
didrockssil2100: keep me in touch please :)14:11
sil2100didrocks: for bug #1016354 , should I also attach nux and the nux branch?14:20
ubot5Launchpad bug 1016354 in unity "IBus can't be activated on dash or HUD since r2428" [High,In progress] https://launchpad.net/bugs/101635414:20
sil2100Since essentially it's being fixed by two merges14:20
sil2100In unity and nux14:22
didrockssil2100: yeah14:25
jaytaokosil2100: the nux branches compile but I am getting errors in the tests14:26
jaytaokosil2100: so as it is, we cannot merge this branch just yet: lp:~3v1n0/nux/text-entry-virtual-clipboard14:30
jaytaokoTrevinho: ^^^ are you getting errors will running "make check" for the branch?14:30
Trevinhojaytaoko: mmh, I'll try... but my tests run fine14:32
sil2100hmm14:32
Trevinhojaytaoko: what's failing there?14:33
jaytaokoTrevinho: http://pastebin.ubuntu.com/1073170/  there are more test failing...14:36
jaytaokoTrevinho: I am trying nux trunk...14:36
sil2100Trevinho: we merged in some nux-3.0 changes in trunk14:37
sil2100Trevinho: are you trying it on trunk..?14:37
Trevinhojaytaoko: mhm weird... they all passed here yesterday...14:39
* Trevinho checks14:39
Trevinhokamstrup: ok.. found the issue... when ibus-daemon is running some of them fails... maybe I should fix that14:40
leo-unglaubi have a problem with the current nightly of unity..14:40
leo-unglaubinstalled via the ppa http://ppa.launchpad.net/unity-team/staging/ubuntu14:41
leo-unglaubthis is now trying to triggern an dist-upgrade14:41
leo-unglaubwitch failes..14:41
leo-unglaubit always means that there is no ubuntu-desktop package found14:42
leo-unglaubbut the meta package is installed14:42
leo-unglaubif i do the upgrade from the sell myself, it works fine14:42
leo-unglaubjust so you know this bug..14:42
leo-unglaubif you need any  additional informations, please let me know14:42
sil2100Trevinho: how's the test issue?14:45
Trevinhosil2100: I'm fixing now... some tests fails when ibus-daemon is running14:45
Trevinhosil2100: I didn't think to that since I thought that make check was running without ibs14:46
Trevinhoibus*14:46
sil2100Trevinho: excellent! Thanks14:47
=== dandrader is now known as dandrader|afl
=== dandrader|afl is now known as dandrader|afk
sil2100andyrock: hi!14:50
sil2100andyrock: are you around?14:50
andyrocksil2100, yeah but i'm studying14:51
andyrockdo you want me to SRU something?14:51
sil2100andyrock: well, nothing urgent ;)14:52
andyrocksil2100, shoot! :)14:52
sil2100andyrock: I was wondering maybe if the fix for bug #934062 is SRUable as well ;)14:53
ubot5Launchpad bug 934062 in unity (Ubuntu) ""Keyboard Shortcuts" overlay can cause annoyance" [High,In progress] https://launchpad.net/bugs/93406214:53
andyrocksil2100, yes it's SRUable14:53
andyrockhave we the SRU freeze today?14:53
sil2100andyrock: no, today was supposed to be quantal freeze, but we'll do that tomorrow14:54
andyrockso i can SRU it this evening...14:54
andyrocki can ask someone to review it14:54
sil2100andyrock: the SRU freeze will be probably be around end of the week if anything14:55
andyrockcool14:55
andyrockso i think i have to SRU 2-3 branches14:56
sil2100andyrock: ooo, thanks! ;)14:56
andyrocknp14:56
seb128sil2100, davidcalle: video lens new SRU uploaded, thanks15:02
davidcalleseb128, thank you15:03
sil2100seb128: thanks \o/15:04
jaytaokoTrevinho: areyou getting the test errors?15:05
Trevinhojaytaoko: only when enabling ibus-daemon15:06
Trevinhojaytaoko: however, I've fixed the first branch...15:06
Trevinhojaytaoko: fixing the second now15:06
jaytaokoTrevinho: ok15:06
Trevinhojaytaoko: this should be fine for merging, tough https://code.launchpad.net/~3v1n0/nux/text-entry-meta-filters15:07
jaytaokoTrevinho: ok. so I need to get two nux branches, right?15:10
jaytaokoTrevinho: first lp:~3v1n0/nux/text-entry-meta-filters and then lp:~3v1n0/nux/text-entry-virtual-clipboard15:11
Trevinhojaytaoko: there were two branches... with dependency15:11
Trevinhojaytaoko: yep15:11
jaytaokoTrevinho: right! so I am merging them with nux trunk before compiling15:11
sil2100didrocks: if we get this ibus fix merged into unity and nux, would you mind doing the freeze tomorrow?15:15
didrockssil2100: sure, a pity that wasn't dealt before15:16
didrockssil2100: or we can freeze now15:16
didrocksthen, they get the release critical branches with "UNBLOCK"15:17
didrockswhich can be the case of the ibus onces15:17
sil2100didrocks: that wouldn't be a problem?15:22
sil2100i.e. freezing for a whole night?15:22
Trevinhodidrocks: sorry, I should have done this before... But I wanted to finish other stuff..15:24
Trevinhojaytaoko: the problem with tests when ibus is running is that... we use an async call to check if an event has been filtered... this can cause troubles, since we always return true in IBusIMEContext::FilterKeyEvent15:25
jaytaokoTrevinho: are your branch fixing a release critical issue?15:25
Trevinhojaytaoko: well, the ibus break is critical...15:25
jaytaokoTrevinho: hmm! that is why I think we should get bschaefer15:25
Trevinhojaytaoko: I agree15:26
jaytaokosil2100: how much  trouble is it for you to postpone the release?15:26
didrockssil2100: as you wish for the time of freezing15:27
didrockssil2100: just hope that they won't introduce regressions if we don't freeze :)15:27
sil2100jaytaoko: well, hm, we had plans on releasing unity stack this week15:28
sil2100jaytaoko: how much more time do you need?15:28
jaytaokosil2100: it is to leave time for bschaefer to have a look at the branches before they are merged15:30
bschaeferjaytaoko, have a look at which branches?15:31
sil2100jaytaoko: this can be done - would you ensure that Brandon looks at those today?15:31
sil2100Ah!15:31
sil2100;)15:31
sil2100bschaefer: hi15:31
bschaefersil2100, hello!15:31
jaytaokobschaefer: hello15:31
bschaeferjaytaoko, hello, and good morning haha15:31
jaytaokobschaefer: can you review these branches: https://code.launchpad.net/~3v1n0/nux/text-entry-virtual-clipboard/+merge/11314515:32
bschaeferyes15:32
bschaeferjaytaoko, let me take sometime to run some test on it15:32
sil2100bschaefer: thanks15:33
bschaefersil2100, np!15:33
sil2100jaytaoko, bschaefer: could you guys try merging the tested fix till tomorrow?15:33
sil2100Since then we'll just do the release tomorrow15:33
bschaefertill tomorrow or by tomorrow?15:33
sil2100didrocks: would you prefer to freeze today? You have more experience here ;)15:34
sil2100bschaefer: so that it's merged in by tomorrow morning15:34
sil2100bschaefer: since we need this fixed for the release, it's currently a blocking issue15:34
bschaefersil2100, yup, its 8:30 am here, Ill make sure it is merge by then15:34
sil2100bschaefer: \o/15:34
jaytaokobschaefer: and run the "make check" please.15:34
bschaeferjaytaoko, will do!15:35
sil2100Damn, a nasty storm here15:35
Trevinhohi bschaefer15:37
bschaeferTrevinho, hello! So far these changes look nice :)15:37
Trevinhobschaefer: for the 2nd one (virtual clipboard) wait few seconds since I've failing tess when ibus-daemon is running15:37
* bschaefer broke is pinyin15:37
bschaeferTrevinho, alright, Im installing it right now15:37
didrockssil2100: it's really as you wish ;) if you don't care about redoing all the tests tomorrow, it's fine to only freeze tomorrow15:38
Trevinhobschaefer: they fail due to the fact that ime_>FilterKeyEvent is async (which is good), but it desn't give us the event15:38
Trevinhobut I guess that adding some timeout would fix it15:38
sil2100didrocks: so hm, is it a big bother to freeze the trunk now?15:39
sil2100bschaefer, Trevinho: would you mind?15:39
sil2100I would ask for a freeze now, and unfreeze it around tomorrow15:39
bschaeferTrevinho, hmm that sounds like a good fix for that...could you do an idle to wait for it?15:39
didrockssil2100: ask upstream :)15:39
bschaeferthat might slow it down though15:39
sil2100And the ibus fix would be added as an UNBLOCK15:39
bschaeferTrevinho, hmm I just got a compiling error15:40
sil2100bschaefer: ^ ?15:40
sil2100Trevinho: ^ ? ;)15:40
bschaeferTrevinho, http://pastebin.ubuntu.com/1073278/15:41
sil2100Would you guys mind a freeze with the current state of trunk?15:41
sil2100+ the ibus patch when ready?15:41
bschaeferTrevinho, you missed a comma in the printf15:41
jaytaokoTrevinho: make check fails to build15:42
Trevinhoprobably I've pushed a bad version :o15:42
Trevinhobschaefer: which branch?15:42
* sil2100 feels ignored while there is thunder near his apartment15:42
sil2100;)15:42
bschaeferTrevinho, https://code.launchpad.net/~3v1n0/nux/text-entry-virtual-clipboard/+merge/11314515:43
bschaeferline 24515:43
Trevinhobschaefer: wait few minutes for it15:43
bschaeferTrevinho, alright!15:43
sil2100didrocks: it seems they're busy, so we'll do the freeze tomorrow - I'll just re-test it then15:44
jaytaokoTrevinho: gtest-nux-textentry.cpp: error: ‘ime_’ was not declared in this scope15:45
didrockssil2100: sure15:45
Trevinhojaytaoko: I don't get that here... but maybe I didn't push the fix... I'll send it soon15:46
=== zyga is now known as zyga-food
jaytaokobschaefer: are you able to compile the test? I am getting some errors...15:54
bschaeferjaytaoko, yeah i was able to compile all the gtest15:54
sil2100mhr3: the enable-introspection branch failed merging, some test has failed15:54
sil2100https://jenkins.qa.ubuntu.com/job/automerge-bamf/78/console15:54
bschaeferjaytaoko, hmm the only error I get is running it under sudo because ibus doesn't connect if so15:54
sil2100mhr3: for bamf15:54
bschaeferTrevinho, you should extend the time on the test also15:55
bschaeferthe g-test-textentry15:56
mhr3sil2100, the log doesn't really show why15:56
Trevinhobschaefer: where? however I'm quite done...15:56
bschaeferTrevinho, 43615:56
bschaeferline, the 4000015:56
mhr3Trevinho, did you see it? i'm not sure the accessibility thing is fatal15:56
bschaeferTrevinho, done as in you have to go to sleep now?15:56
mhr3Trevinho, (talking about https://jenkins.qa.ubuntu.com/job/automerge-bamf/78/console )15:56
Trevinhomhr3: no sorry... I'm busy with another branch15:56
Trevinhomhr3: I'll check it later15:57
mhr3ok15:57
mhr3sil2100, anyway that branch is very low prio15:57
sil2100mhr3: k, we'll merge it in after the release then15:58
mhr3fine with me15:58
mhr3it'd expect we'd be frozen by now15:58
sil2100mhr3: for now maybe don't concern with it - we'll have less testing to do tomorrow if this doesn't get merged15:58
sil2100mhr3: yep15:58
mhr3sil2100, is the ibus fix really blocking you though? you could just freeze now and test everything else15:59
sil2100mhr3: well, I couldn't get an ACK from upstream, so I decided just to do the freeze tomorrow morning16:00
sil2100Trevinho, bschaefer, jaytaoko: just don't merge in too many things till tomorrow besides the ibus fix16:00
bschaeferjaytaoko, hmm let me test it again, maybe I was running the wrong rev16:00
* mhr3 laughs at sil2100's last request16:00
sil2100Since we're theoretically on freeze now16:00
sil2100mhr3: :(16:00
sil2100;)16:00
mhr3sil2100, you know you do have the power to enforce that, right?!16:01
sil2100Ouch, ok guys, the thunders are getting to intense - and it's anyway my time to go16:01
jaytaokosil2100: nothing will be merged today except for the issue we we are working on with iBus16:01
sil2100mhr3: I know, I know.. well, didrocks has the power though, not me :D16:01
sil2100jaytaoko: thank you!16:01
didrocksI have the power \o/16:01
sil2100See you tomorrow everyone16:01
bschaeferhaha16:01
didrockssee you sil210016:01
bschaefersil2100, have a good night16:01
jaytaokodidrocks: is nux frozen? can you activate the freeze?16:01
jaytaokosil2100: cheers16:02
didrocksjaytaoko: hum, it seems sil2100 wanted to freeze tomorrow16:02
jaytaokodidrocks: I think we won't merge anything except for the issue we are working on. And we can use UNBLOCK. I want to avoid anyone mergeing anything before the release is done.16:03
Trevinhodamn, fighting with a random crash16:03
didrocksjaytaoko: Well, I would rather freeze the whole stack or not TBH16:04
mhr3voluntary freeze, that's new :)16:04
didrocksI can of course just freeze nux if you want16:04
didrocksmhr3: btw, in the sessions about things that didn't work last cycle, didn't you notice the freeze wasn't mentionned? :)16:04
mhr3didrocks, but there were emails about it, no?16:05
mhr3i think that everyone sees that it's necesarry, but it should be done a bit differently16:05
jaytaokodidrocks: ok, so lets wait tomorrow. I will send an email to make people aware they should not merge anything in nux today and until the freeze is lifted16:05
didrocksmhr3: I'm still open and hope we can branch, commit in both and then merge back switching the mainlines16:06
didrocksmhr3: so that the tagged version is in trunk now :)16:06
mhr3yea, i thought that's how it'd work this cycle16:06
bschaeferTrevinho, what random crash?16:07
didrocksmhr3: well, I proposed that for the previous cycle already16:07
didrocksmhr3: but it seems popey and mmrazik didn't want this16:07
didrocksmhr3: like swichting the mainline16:08
didrocksso I wait for them to solve the issue and coming with a release process enabling that :)16:08
mhr3hmm, well not my call, you do have my +1 there though16:08
bschaeferjaytaoko, yeah, I can run the gtest, they just fail on the copy/paste stuff16:21
bschaeferare you still having that ime_ thing?16:21
Trevinhojaytaoko, bschaefer ok.,.. I'm done with lp:~3v1n0/nux/text-entry-virtual-clipboard16:23
Trevinhoplease check the review soon16:23
bschaeferTrevinho, pulling changes!16:23
jaytaokobschaefer: I need to get the branches again... doing it now16:24
Trevinhobschaefer and jaytaoko sorry fo rthe delay... I've noticed before that I didn't send the fixed revision I tought (for the 2nd branch)...16:26
bschaeferTrevinho, jaytaoko awesome all the new test pass, Im going to run the full make check now though16:26
bschaeferTrevinho, no worries!16:26
bschaeferTrevinho, hmm did you notice the deadkey test were failing?16:33
bschaeferTrevinho, its not your branch though16:33
Trevinhobschaefer: which ones?16:34
bschaeferxtest-test-textentry-deadkeys16:34
bschaeferxtest-text-entry-deadkeys16:34
Trevinhobschaefer: they don't either run here.. :o16:35
bschaeferyeah, just wanted to make sure. Hmm, can you manually test a dead key?16:35
bschaeferTrevinho, ill manual test it, I just wanna make sure that other branch didn't stop those from working :(16:35
Trevinhobschaefer: I don't know :)16:35
Trevinhobschaefer: but I get an X error16:36
bschaeferyeah16:36
bschaeferI think its something is getting passed out of range for X16:36
bschaeferTrevinho, ooo16:36
bschaeferTrevinho, you get the error because you r keyboard doesn't have the dead key16:36
bschaeferTrevinho, because your keyboard layout doesn.t16:36
Trevinhobschaefer: ah, ok16:36
bschaeferTrevinho, forgot about that haha...16:36
* bschaefer should add a check for that16:37
bschaeferTrevinho, let me test it with unity, just to be sure copy/paste still works haha16:37
Trevinhobschaefer: I need to help my gf with some home stuff..  see you later16:38
bschaeferTrevinho, no worries! Cya16:39
bschaeferTrevinho, i also have to go sign a lease soon16:39
bschaeferjaytaoko, hows the branch going for you?16:46
bschaeferjaytaoko, i think I was missing that pre req, but everything still worked w/o it16:46
jaytaokobschaefer: ./InputMethodIBus.cpp:377:7: error: 'key_event' was not declared in this scope16:46
jaytaokobschaefer: are you getting this error with lp:~3v1n0/nux/text-entry-virtual-clipboard16:47
bschaeferjaytaoko, hmm no, but im compiling with the pre req branch now16:48
bschaeferjaytaoko, and everything just compiled :(16:48
jaytaokoyes, I am also using the pre req branch16:49
bschaeferyeah everything just finished on my sudo make -j416:49
bschaeferwith out an error...hmm16:49
jaytaokoTrevinho: ok, I took nux trunk and I merged lp:~3v1n0/nux/text-entry-meta-filters in it. This compiles fine.16:50
jaytaokobschaefer: Trevinho: then I merged lp:~3v1n0/nux/text-entry-virtual-clipboard and try to compile. This fails16:51
bschaeferjaytaoko, hmm I just did this: bzr branch lp:~3v1n0/nux/text-entry-meta-filters16:51
jaytaokobschaefer: Trevinho: am I missing some libs?16:51
bschaeferthen: bzr merge lp:~3v1n0/nux/text-entry-virtual-clipboard16:51
bschaeferjaytaoko, maybe something didn't get merged right?16:51
jaytaokobschaefer: Trevinho: get merge trunk and then  merge the 2 branches into it. Then compile.16:52
bschaeferjaytaoko, will do16:52
bschaeferjaytaoko, also Trevinho is away for now16:53
bschaeferjaytaoko, Text conflict in Nux/TextEntry.cpp16:54
bschaeferText conflict in tests/gtest-nux-textentry.cpp16:54
bschaefer2 conflicts encountered.16:54
bschaeferI get conflicts when I merge16:54
bschaeferthe virtual-clipboard16:54
jaytaokobschaefer: hmm I don't get the conflicts16:55
bschaeferI just did this16:55
bschaeferbzr branch lp:nux16:55
bschaefercd nux16:55
bschaeferbzr merge lp:~...meta16:55
bschaeferbzr merge lp:~clipboard16:55
bschaeferthen conflicts on the second one16:55
jaytaokobschaefer: starting from scratch again16:56
bschaeferjaytaoko, i have to go for like 30-40 min16:56
bschaeferjaytaoko, i have to sign a lease to an apartment, so i can live somewhere haha16:56
jaytaokobschaefer: no problem! talk to you later16:56
bschaeferjaytaoko, yup! Good luck!16:56
jaytaokobschaefer: thanks :)16:56
Trevinhobschaefer: back17:11
Trevinhojaytaoko: any problem?17:12
Trevinhojaytaoko: just re-checked... all merges and compiles fine here17:23
jaytaokoTrevinho: I took nux trunk them merged the 2 branches. It fails at the build.17:23
Trevinhojaytaoko: maybe you did it too early (I pushed the updates ~1h ago)?17:24
jaytaokoTrevinho: http://pastebin.ubuntu.com/1073429/17:24
jaytaokoTrevinho: I took the branches 15 minutes ago17:25
Trevinhojaytaoko: right... and why my branch compiles!?? :o17:25
Trevinhojaytaoko: however I'm fixing it now17:25
Trevinhojaytaoko: ok, fixed17:26
jaytaokoTrevinho: ok, getting...17:26
=== dandrader|afk is now known as dandrader
jaytaokoTrevinho: ok, now it compiles17:32
jaytaokoTrevinho: I am getting some failures in the tests17:32
Trevinhojaytaoko: which ones?17:33
jaytaokoTrevinho: they are related to iBus.17:33
jaytaokoViewSendKeyComboNux: TextEntry is only Preedit: Failed17:33
jaytaokoNux: TextEntry is "请问儿童有": Failed17:33
jaytaokoTrevinho: ^17:33
Trevinhojaytaoko: I have the same issue...17:33
Trevinhojaytaoko: brandon told me that it was correct btw17:33
jaytaokoTrevinho: I think bschaefer can help17:33
Trevinhojaytaoko: the problem there is that I I write qwerty on the terminal with ibus, I get the same string that nux gets...17:34
Trevinhojaytaoko: was you getting that even in trunk?17:34
jaytaokoTrevinho: I have restarted iBus. The test works now17:35
Trevinhojaytaoko: I don't think that this is caused by my branch... It seems like something that can fail randomly...17:36
jaytaokoTrevinho: ok, so bschaefer will be back in an hour or so, I will get him to review your branch. If all is fine, then we can merge17:38
jaytaokoTrevinho: do you have a unity branch for this as well?17:38
Trevinhojaytaoko: ok cool... sorry for the errors... :/17:38
Trevinhojaytaoko: yep17:38
Trevinhojaytaoko: https://code.launchpad.net/~3v1n0/unity/im-textentry-rewrite-ibus-fix17:38
Trevinhojaytaoko: plus these AP tests https://code.launchpad.net/~3v1n0/unity/ibus-press-release-tests17:39
jaytaokoTrevinho: no problem. I will try the unity branch as well. Is there an automated test for the unity branch or do I need to test manually?17:39
Trevinhojaytaoko: there are both unit tests (./test-gtest --gtest_filter=TestIM*)17:40
Trevinhojaytaoko: and ap tests (in the branch above)17:40
bschaeferback!18:01
Trevinhobschaefer: so.. give the branches a new try :)18:01
bschaeferTrevinho, jaytaoko hello, sorry had to sign a lease haha18:01
bschaeferTrevinho, I did!18:01
bschaeferI think, or are there new changed?18:01
Trevinhobschaefer: cool... ;)18:02
Trevinhobschaefer: i fixed some compilation troubles and tests when ibus is running18:02
bschaeferTrevinho, awesome, let me pull those changes18:02
bschaeferwas just reading above. So why that test fails is your pinyin has a preference18:03
bschaeferit is learning what you type haha, so it will change sometimes, a fix would be to change it to ninhao18:03
bschaefer"ninhao" because that is a real word haha18:03
jaytaokobschaefer: welcome back.18:08
jaytaokobschaefer: so, I was able to compile after Trevinho did a fix18:08
bschaeferjaytaoko, thank you! Sorry, I just had to get that taken care of.18:08
bschaeferjaytaoko, awesome!18:09
jaytaokobschaefer: the iBus tests sometimes fails...18:10
bschaeferjaytaoko, hmm when you do "qwerty"?18:10
jaytaokobschaefer: it seems that are some conditions that can cause them to fail, but it does not happen all the time18:10
jaytaokobschaefer: yes18:10
bschaeferjaytaoko, yeah  because this is what I get when I type it18:10
bschaefer请问儿童有18:10
bschaefersooo a think a good fix would be to change it from "qwerty" to "ninhao"18:11
bschaefersince one is an actual word18:11
bschaeferjaytaoko, what happens is other tests that are going on that use pinyin cache the characters your select18:11
bschaeferTrevinho, ^18:13
bschaeferif you wouldn't mind changing it in your branch18:13
jaytaokobschaefer: ok, is this something that can be done today? or should we wait?18:13
bschaeferjaytaoko, all we should have to do is change the test just a little18:13
bschaeferjaytaoko, should be a very easy fix!18:13
Trevinhobschaefer: sorry? Should I change to ninhao?18:14
bschaeferTrevinho, change "qwerty" to "ninhao"18:14
bschaeferthen change "请问儿童有“ to "您好“18:14
bschaeferthat should fix that case18:15
bschaeferjaytaoko, other then that everything is looking good in your branch?18:19
jaytaokobschaefer: yes18:19
bschaeferjaytaoko, awesome, i have no clue why mine would compile...18:20
bschaeferjaytaoko, but mine was also looking good18:20
* bschaefer is running the tests again18:20
=== dandrader is now known as dandrader|afk
Trevinhobschaefer: I've pushed it, now it works....18:29
Trevinhobschaefer: so... once your tests pass, let's unblock and approve all the branches ;)18:29
bschaeferTrevinho, awesome! Thanks18:31
bschaeferill run it again just to be sure :)18:31
=== dandrader|afk is now known as dandrader
bschaeferTrevinho, approved both branch :)18:37
bschaeferjaytaoko, new tests were just pushed18:37
Trevinhocool, thanks18:37
bschaeferor a new one was18:37
bschaeferto fix the one that was failing for you18:38
bschaefernp!18:38
Trevinhobschaefer: have you checked the unity ones as well? :)18:38
bschaeferTrevinho, hmm well it compiled with unity but yeah I need to run those test!!18:39
bschaeferTrevinho, whooo18:42
bschaeferTrevinho, I got a crash18:42
bschaeferTrevinho, when I try and type into the dash...18:43
Trevinhobschaefer: hm...18:43
Trevinhobschaefer: stacktrace?18:43
* bschaefer gets bt18:43
bschaeferyeah one sec18:43
jaytaokobschaefer: Trevinho: can you check that we can merge https://code.launchpad.net/~3v1n0/unity/im-textentry-rewrite-ibus-fix into unity trunk and it will compile. I tried but it failed...18:43
=== jaytaoko is now known as jaytaoko|lunch
* Trevinho checks18:44
jaytaoko|lunchbschaefer: Trevinho: it also looks like unity trunk fails to build? I wonder if it is my system18:45
bschaeferTrevinho, http://pastebin.ubuntu.com/1073557/18:46
bschaeferjaytaoko|lunch, hmm I just compiled mine, but then running it causes a crash18:46
Trevinhobschaefer: it seems like you don't have an updated unity there..18:47
Trevinhoor am I wrong18:47
Trevinho?18:47
Trevinhobschaefer: we don't have anymore unity::IMTextEntry::InspectKeyEvent but yours run it...18:48
bschaeferTrevinho, yeah let me double check that...18:48
bschaeferTrevinho, oo run your new unity bracnh duhh18:48
mhr3still no more jhbuild converts?18:49
mhr3you people like building everything yourself, don't you :)18:49
Trevinhoeheh :(18:49
bschaeferidk what jhbuild is!18:49
Trevinho(wrong bracket))18:49
mhr3bschaefer, let's call it magic that can build the whole unity stack18:50
mhr3and run it without installing it system-wide18:50
bschaefermhr3, well I don't believe in magic! Its scary18:50
bschaeferwell I have bash scripts that build branchs...so I don't have to type much haha18:50
mhr3try to build the *whole* stack sir :P18:51
bschaeferI will manually!18:51
bschaefermhr3, haha, but Ill look into it18:51
bschaeferthat sounds nice18:51
mhr3lp:unity-jhbuild ;) it has a readme18:52
bschaeferno way! is it up to date?18:52
mhr3bschaefer, good question :)18:52
bschaeferhaha18:52
mhr3fwiw it's a gnome tool, so some docs can be found there as well18:54
bschaefercool, I should be able to get it working...18:54
bschaeferwait so this freeze on unity, is it for the 5.0 branch?18:55
bschaeferor 6.0 as well18:55
bschaeferTrevinho, hmm Im still getting a crash with your branch ... but now the bt wont give me anything ...18:58
Trevinhobschaefer: weird... need to have dinner now... see you later19:00
bschaeferTrevinho, yeah...hmm Ill see what I can figure out in the meantime19:00
=== jaytaoko|lunch is now known as jaytaoko
bschaeferTrevinho, sweet, something got messed up but now it doesn't crash! yay19:34
* bschaefer is running ap test now19:34
jaytaokobschaefer: Trevinho: how is it going?19:40
bschaeferjaytaoko, hey, going well19:44
bschaeferjaytaoko, i just got that branch up and working and all test seem to pass19:45
bschaeferjaytaoko, hmm actually I need to test these dead keys19:45
bschaeferthey seem to be failing for me :(19:45
bschaeferjaytaoko, hows the branch going for you?19:48
jaytaokobschaefer: something is wrong on my system... I need to update before I can compile the unity branch19:49
bschaeferjaytaoko, that sucks :(19:50
bschaeferim worried compose/dead keys might be broken...now I have remember how to do those hahah19:50
jaytaokobschaefer: yeah, I forgot about it as well19:51
jaytaokobschaefer: need to reboot19:51
bschaeferok19:51
bschaeferjaytaoko, it looks like multi key/dead keys is having problems19:55
bschaeferjaytaoko, its just bugging now19:55
bschaeferbuggy*19:55
jaytaokobschaefer: hmm we will have to fix :-(19:58
bschaeferTrevinho,  :( soo your branch is breaking multi key/ dead keys... Ill dig into it until you get back!19:58
bschaeferjaytaoko, o yeah, Im thinking it has to do with the KEY_UP event19:58
bschaeferjaytaoko, and im hopping we can just ignore those keys when checking for dead keys19:59
jaytaokobschaefer: ok19:59
Trevinhobschaefer: bacl20:03
Trevinhoback*20:03
bschaeferTrevinho, hey, sooo dead keys and compose mode isn't working anymore20:04
bschaeferTrevinho, i think I know why and have fixed it from the manual test20:04
Trevinhobschaefer: compose was working here...20:04
bschaeferfor a manual test...but the test still fail half the time...but I just started looking at it20:04
bschaeferTrevinho, it was working buggy ish though,20:05
bschaeferTrevinho, if you setxkmap fr20:05
bschaeferthen hit square bracket then delete20:05
bschaeferit deletes that space, which isn't correct20:05
bschaeferTrevinho, http://pastebin.ubuntu.com/1073690/20:06
bschaeferthat seems to fix a lot of the problems20:06
bschaeferbut there is still a problem...hmm20:08
Trevinhobschaefer: how dead keys are actually working?20:28
bschaeferTrevinho, well the deadkeys might be working, im just testing compose keys right now20:28
bschaeferTrevinho, and it isn't working well in the dash...20:28
bschaeferto test compose keys:20:29
bschaefersetxkbmap fr20:29
bschaeferthen press: '[' + 'o'20:29
bschaeferthat should give you ô20:29
Trevinhowhat's happening instead?20:30
Trevinhosetting it to italian, if I do ^+o I get that..20:31
bschaeferTrevinho, it works like half the time and in the dash...or doesn't work at all20:32
bschaeferTrevinho, that pastebin I sent you fixes it in nux, but now im having problems getting unity to read my updated nux20:32
Trevinhomh ok20:32
bschaeferTrevinho, also once you have your multi key set try the test for them20:33
bschaeferumm20:33
bschaefer./xtest-text-entry-deadkeys20:33
bschaefer(it tests compose keys rather then dead keys...I didn't know the difference back then haha)20:33
bschaeferTrevinho, how do you set it to italian?20:35
Trevinhobschaefer: I've just enabled the compose key from g-c-c20:36
bschaeferTrevinho, hmm20:37
bschaeferTrevinho, whats the multi key for italian?20:37
bschaeferI wanna test that out20:37
Trevinhobschaefer: from g-c-c you can set to any key... I set to caps lock20:37
bschaeferTrevinho, ok, let me try that out20:37
bschaeferTrevinho, it doesn't work for me :(20:44
bschaeferTrevinho, did you get the deadkey test for nux working?20:45
Trevinhobschaefer: sorry, I was checking AP... now I do that20:48
bschaeferTrevinho, no worries!20:48
bschaeferTrevinho, i just want to make sure not to piss off didrocks haha20:48
Trevinhothomi: I've this one too https://code.launchpad.net/~3v1n0/unity/ibus-press-release-tests/+merge/113147 ;)20:48
Trevinhobschaefer: we must be sure not to break anything... we're playing with the fire! :)20:49
Trevinhobschaefer: should I test that with your fix or not?20:49
bschaeferTrevinho, i know! Its hard, cause I don't speak or use any of those language settings so I have to re learn it agian haha20:49
bschaeferTrevinho, first test with what you have20:49
bschaeferTrevinho, with your italian set up20:49
bschaeferTrevinho, if it fails then test my fix20:50
bschaeferFire is fun to play with though20:50
thomiTrevinho: I'm not so sure about that test.20:50
thomiwhy do you hold the activate keys down?20:51
Trevinhothomi: because I need to check if the activation happens on key release or on key press20:51
thomihmm....20:52
* thomi investigates further20:52
Trevinhoso bschaefer yes.. it fails (but yesterday when I tried it was working! :/)20:52
* Trevinho checks the bschaefer patch20:52
bschaeferTrevinho, hmm20:52
bschaeferTrevinho, its not a patch haha, its just surrounds the dead keys/compose to avoid the key up20:52
thomiTrevinho: THe set_gconf_option in setUp is to make sure that the activation key is Ctrl+Space?20:54
thomi...because that's the default, right?20:54
Trevinhothomi: yes...20:55
Trevinhothomi: in that way we're independent from configurations... we set our values, so no one should break it20:55
thomiTrevinho: sure20:55
thomihmm, this isn't an issue with your code, but autopilot should take care of adding the cleanup inside set_gconf_option20:57
thomilike set_compiz_option does20:57
Trevinhobschaefer: I've added your patch... now it works... but I've some failures anyway...20:57
Trevinhobschaefer: I don't know if it depends on the keyboard layout20:57
bschaeferTrevinho, yeah, it seems to fix it a bit20:57
TrevinhoI've kept the italian20:57
bschaeferTrevinho, no it shouldn't20:57
bschaeferTrevinho, it sends the multi key to x11, but it needs to exist on the layouy20:57
bschaeferTrevinho, i was still getting failures, but when I tried to test it on unity it didn't use my updated nux20:58
bschaeferwhich is what im working on now to much sure it works in unity...(you can also test it under ~/nux/examples/test-foucs...20:58
bschaefersomething like that20:58
thomiTrevinho: the issue I have is that you've changed the way activate_ibus works, which is used by the existing tests.20:59
Trevinhothomi: well, yes.. but it just does what it did before, it just checks more than before21:00
thomiit used to press_and_release the activation keycombo & then wait for the ime_active signal. Now it presses the activation keycombo, waits for the signal and then releases the key combo21:00
thomiTrevinho: the only different is where the assert goes. I don't think we should be checking for the activation signal half way through a keypress21:01
thomi...especially since this changes all the existing ibus tests.21:01
Trevinhothomi: well... yes, but if the activation happens after the release, that's wrong21:02
thomihmmmm21:02
thomiok21:02
thomianother issue is that if the activation is successful you'll generate a release when you shouldn't21:02
thomisince the addCleanup will proc in both cases21:02
thomiI wonder if there's a way around that?21:02
Trevinhothomi: yes... I thought about that...21:03
Trevinhothomi: isn't releasing a released key a non-issue?21:03
* thomi checks21:03
thomiTrevinho: it'll still generate a key rwelease event, which may confuse things21:04
thomiTrevinho: also, can you update the docstrings on activate_ibus_on_release and deactivate_ibus_on_release.I'm not sure what they're supposed to do21:06
Trevinhook21:07
bschaefer Trevinho ok, I think my fix fixes it for unity, but ill have to take a look at why half the test fail21:08
bschaeferTrevinho, in nux, but doing manual test, it seems to like it...21:09
Trevinhobschaefer: mhmh... weird21:10
TrevinhoI don't think I've changed anything that should break that... I mean, I've just added two safety check for null character...21:10
bschaeferTrevinho, yeah, but I wrote those test a while ago...21:10
bschaeferTrevinho, remember the deadkeys test didn't work because of the X11 error21:11
bschaeferTrevinho, since they keyboard layout you had didn't have a compose key21:11
Trevinhobschaefer: I have enabled the compose key21:11
bschaeferTrevinho, sending the KEY_UP keys through the dead key checks messed up its look ahead stuff21:11
bschaeferTrevinho, hmm21:11
bschaeferTrevinho, did you yesterday to test it?21:12
Trevinhobschaefer: I'm gettiing this btw http://paste.ubuntu.com/1073821/21:12
bschaeferTrevinho, yeah it seems like the very first key stroke messes up sometimes...21:12
Trevinhobschaefer: do you have the same?21:12
bschaeferTrevinho, yeah!21:13
bschaeferits not 100% fixed, but at lease we reduced it from 100% failure to some what working21:13
leo-unglaubhey guys...21:13
leo-unglaubi need help21:14
leo-unglaubthe latest unity update killt my laptop21:14
thumperkilled in what way?21:14
leo-unglaubit removed my ubuntu-desktop package and endet with a dependency error21:14
Trevinhobschaefer: it doesn't seem to work in my dash/hud at all tough21:15
leo-unglaubi get the folowing error21:15
bschaeferTrevinho, are you sure it is using the new nux? Cause I had a problem where unity wasnt using the new version...21:15
Trevinhoyep21:16
bschaeferbut ive got mine working :(21:16
bschaeferhmm21:16
leo-unglaubcan't install unity, it depends on unity-common = 5.12+bzr2444ubuntu0+709 but 5.12+bzr2445ubuntu0+709 should be installed21:16
bschaeferTrevinho, does it work for you under the nux example21:16
bschaefertext entry focus thing21:17
leo-unglaubhow can i fix this?21:19
Trevinholeo-unglaub: try to manually install unity and unity-common= 5.1x (check the last official version via apt-cache policy unity)21:22
leo-unglaubTrevinho: installing manually doesn't work...21:23
leo-unglaubwould i help to remove the ppa?21:23
Trevinholeo-unglaub: neither if you specify the version via apt-get install unity=version?21:24
* bschaefer -> coffee21:26
leo-unglaubTrevinho: hmm, doesn't work...21:27
Trevinhobschaefer: you know what? deadkeys is failing even in trunk...21:27
bschaeferTrevinho, really?21:28
bschaeferTrevinho, shit....21:28
Trevinhobschaefer: it looks like that21:28
Trevinhocan you try as well?21:28
bschaeferTrevinho, yeah, let me get trunk and build it21:29
leo-unglaubsorry, i have a bad inet conenction here. all 5 minutes a damn disconnect21:37
leo-unglaubif i try to install unity again i get21:38
leo-unglaubunity : Hängt ab von: libunity-core-5.0-5 (= 5.12-0ubuntu1.1) soll aber nicht installiert w21:38
leo-unglaubin english, this means: depends on libunity-core-5.0-5 (= 5.12-0ubuntu1.1) , but this should not be installed21:38
leo-unglaubmy current dpkg status for unity*21:39
leo-unglaubhttp://pastebin.com/m7t5JBSi21:39
bschaeferTrevinho, hmm it works for me...but I need to revert my nux21:42
leo-unglaubdamn internet conenction here...do you need more informations for my problem?21:49
=== salem_ is now known as _salem

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!