| === facundobatista_ is now known as facubar | ||
| === zumbi is now known as Guest42808 | ||
| JamesTait | Good morning all! :-D | 08:32 |
|---|---|---|
| rye | away | 08:42 |
| === yofel_ is now known as yofel | ||
| === zyga_ is now known as zyga | ||
| === Guest42808 is now known as zumbi | ||
| gatox | good morning! | 11:04 |
| daveonearth | Can anyone tell me why the Ubuntu One logo is not in place for the iphone app? | 12:10 |
| alecu | top of the morning to y'all! | 12:16 |
| alecu | daveonearth: how is it not in place? can you take a screenshot? | 12:17 |
| gatox | alecu, hi | 12:20 |
| daveonearth | Hi alecu | 12:23 |
| daveonearth | It is just not the new Logo | 12:23 |
| daveonearth | its an orange file with a standard 'synch' round arrow | 12:24 |
| ralsina | good morning! | 12:25 |
| gatox | ralsina, hi | 12:30 |
| * briancurtin coffee, back in a few minutes | 14:22 | |
| alecu | mmcc: this branch is not being merged by tarmac because it lacks "commit message": https://code.launchpad.net/~mikemc/ubuntuone-control-panel/fix-1018614-darwin-raise/+merge/112493 | 14:24 |
| dobey | brb | 14:35 |
| * briancurtin back | 14:37 | |
| thisfred | me | 15:00 |
| gatox | me | 15:00 |
| briancurtin | me | 15:00 |
| gatox | ralsina, alecu mmcc dobey standup? | 15:04 |
| gatox | did i forget anyone? | 15:04 |
| ralsina | me | 15:04 |
| gatox | ralsina, no, i did'nt forget you :P | 15:04 |
| gatox | jejejeje | 15:04 |
| thisfred | DONE: https://code.launchpad.net/~thisfred/u1db/unconfuse_sync_info/+merge/113214 bug #1019333 TODO: bug #1019333, BLOCKED: no NEXT: gatox | 15:05 |
| ubot5 | Launchpad bug 1019333 in U1DB "When InvalidGeneration is raised proceed with sync anyway" [High,Confirmed] https://launchpad.net/bugs/1019333 | 15:05 |
| dobey | me | 15:05 |
| gatox | DONE: | 15:05 |
| gatox | Reviews, and refactoring (finally is looking good) | 15:05 |
| gatox | TODO: | 15:05 |
| gatox | Finish with refactoring TODAY! | 15:05 |
| gatox | BLOCKED: | 15:05 |
| gatox | No | 15:05 |
| gatox | briancurtin, go | 15:05 |
| briancurtin | DONE: fixed up stringio branch, started on py3-unicode part 2 | 15:05 |
| briancurtin | TODO: work on py3-unicode part 2 | 15:05 |
| briancurtin | BLOCKED: no | 15:05 |
| briancurtin | NEXT: ralsina | 15:05 |
| alecu | me (writing notes) | 15:06 |
| mmcc` | me | 15:06 |
| dobey | ralsina: ? | 15:06 |
| ralsina | DONE: tech leads, mgmt call, 1-1s cmake tweaking, canonicaladmin TODO: cmake tweaking if needed, bug triaging (are late there) BLOCKED: no | 15:06 |
| ralsina | sorry, was otp | 15:07 |
| dobey | DONE: 3.0.2 SRU uploads, | 15:07 |
| dobey | TODO: finish cmake3 review, bug poking | 15:07 |
| dobey | BLCK: None. | 15:07 |
| dobey | alecu: go | 15:07 |
| alecu | DONE: some reviews, struggled to get a running buildout on mac, techleads mumble | 15:08 |
| alecu | TODO: catch up with briancurtin before his holidays | 15:08 |
| alecu | BLOCKED: no | 15:08 |
| alecu | NEXT: mmcc | 15:08 |
| mmcc` | DONE: path fixes,investigated how we launch SD on windows | 15:08 |
| mmcc` | TODO: improve fix for change to shebangs | 15:08 |
| mmcc` | BLCK: none | 15:08 |
| mmcc` | NEXT: ? | 15:08 |
| mmcc` | NOTE: need to be afk a bit today so only partial holiday tomorrow | 15:09 |
| ralsina | Comments? | 15:09 |
| alecu | mmcc`: this branch is not being merged by tarmac because it lacks "commit message": https://code.launchpad.net/~mikemc/ubuntuone-control-panel/fix-1018614-darwin-raise/+merge/112493 | 15:10 |
| ralsina | Tomorrow is US independence day, monday is Argentina's | 15:10 |
| dobey | indeed | 15:10 |
| mmcc` | alecu, ok, I'll go fix that. thanks | 15:10 |
| alecu | ralsina: and weekend is pycamp! | 15:10 |
| ralsina | plus, most of the .ar gang is taking friday off | 15:10 |
| * dobey will be off tomorrow | 15:10 | |
| ralsina | so, reviews are going to be hard to find. Ping mercilessly. | 15:10 |
| ralsina | EOM? | 15:12 |
| gatox | eom! | 15:12 |
| gatox | and start of lunch | 15:13 |
| === gatox is now known as gatox_lunch | ||
| mmcc` | So, we have some apparently dead code on windows: in u1client, platform/tools/windows.py uses the wrong registry key to find the path to syncdaemon in get_sd_install_path(), which will (I think) never get called because checking is_already_running causes the tcpactivation code to spawn SD using a path it gets get_activation_cmdline, imported from SSO... | 15:17 |
| mmcc` | had some fun with this last night :) but in order to make sure SSO client doesn't need to know the path to syncdaemon, I wanted to make u1client use get_sd_install_path everywhere and so I needed to know which reg key was right | 15:19 |
| briancurtin | mmcc`: i think the tcpactivation and get_activation_cmdline stuff is newer, or at least more recently touched, so there probably is some older stuff remaining that could possibly be removed | 15:21 |
| briancurtin | i believe that was made smarter or bulked up or something more recently around proxy work | 15:21 |
| mmcc` | briancurtin: yes, it is newer. So, there's no way any reg keys would be getting set aside from that installer XML file? | 15:22 |
| briancurtin | mmcc`: not that i know of off the top of my head | 15:22 |
| mmcc` | ok, good | 15:22 |
| briancurtin | mmcc`: a quick check for anything registry related would be to grep for winreg and you'll find everything | 15:23 |
| briancurtin | and everything is not much :) | 15:24 |
| mmcc` | briancurtin: yeah, I did that once, will double-check | 15:24 |
| dobey | ok, need to get lunch, bbiab | 15:44 |
| === zyga is now known as zyga-food | ||
| === gatox_lunch is now known as gatox | ||
| === mmcc_ is now known as mmcc | ||
| rye | ping ralsina, if SD stops working right after 2012-06-17 22:48:57,953 - ubuntuone.SyncDaemon.OffloadQueue - DEBUG - Using temporary file: 'c:\\users\\username\\appdata\\local\\temp\\tmp3dttxi' - what can I do to get more information about this - CP can't contact SD and SD seems to have reached nirvana, but not in a good way | 16:45 |
| briancurtin | rye: does that file exist? | 16:48 |
| briancurtin | (i don't know the answer to the general question, just looking through the code) | 16:48 |
| alecu | rye: what is the version of u1 that's giving that error? | 16:51 |
| rye | alecu: 3.0.2 around 2012-06-19, ralsina by the way, is current 3.0.2 writing 3.0.2 in the log file? | 16:54 |
| rye | briancurtin: that file is not supposed to exist - that's a temporary one for offloading the in-memory request queue | 16:54 |
| === m_conley_away is now known as m_conley | ||
| rye | verterok: it looks like tritcask usage can trigger a bug in eCryptfs causing the metadata item to become unreadable | 17:01 |
| ralsina | rye: AFAIK, having it say 3.0.2 is in the pre-release checklist :-) | 17:02 |
| verterok | rye: hmm, is there something we can do about it? | 17:06 |
| rye | verterok: ask ecryptfs not to cause data loss? | 17:08 |
| verterok | rye: jaja | 17:08 |
| verterok | rye: do you know what action by tritcask is causing ecryptfs to loss data? | 17:09 |
| mandel_ | alecu, ping! | 17:09 |
| mandel_ | gatox, any reviews I can do while I listen to bad very bad italian tv? | 17:09 |
| ralsina | mandel_: is there any other kind of italian tv? | 17:09 |
| gatox | mandel_, not right now.... i'm finishing with the refactor TODAY... so i'm fully focus on that and nothing new | 17:10 |
| rye | ralsina: yet the logs have 3.0.0, please add this to check list again :) | 17:10 |
| mandel_ | gatox, still refactoring! wow! | 17:10 |
| ralsina | briancurtin: see what rye said ^ | 17:11 |
| mandel_ | ralsina, I don't think so.. but if there is, lets called x :) | 17:11 |
| briancurtin | is this only a windows thing? | 17:11 |
| alecu | mandel_: pong! | 17:11 |
| gatox | mandel_, i needed to restart the test refactor for darwin4.... everything was broken | 17:11 |
| ralsina | briancurtin: yes, on linux, clientdefs.py is generated by autotools, on windows it has to be donemanually | 17:11 |
| rye | verterok: not really, in all cases people weren't doing much, and then SUDDENLY ecryptfs corrupts the lower file | 17:11 |
| briancurtin | ok | 17:11 |
| * rye relocates again | 17:11 | |
| mandel_ | alecu, did you have the time to look at my fsevents branch? | 17:11 |
| verterok | rye: oh, that's nice (not) :-( | 17:12 |
| alecu | mandel_: no. Get back to europython, get out in florence, meet tourist chicks. You'll have your review when you get back :-) | 17:13 |
| alecu | mandel_: how's europython so far, btw? | 17:13 |
| mandel_ | alecu, I can multi task hehe :) | 17:14 |
| mandel_ | alecu, but ok, I'll be around if you need me | 17:14 |
| mandel_ | alecu, I went to a couple of advance talks that I found very interesting, the keynotes where very similar form the pycon ones so I did find them more boring | 17:15 |
| mandel_ | alecu, lots of pypy happening which is really great to hear about | 17:15 |
| briancurtin | i'll be back in a bit. combined lunch + bike shop run | 17:18 |
| alecu | mandel_: more pypy is awesome, yes. | 17:20 |
| mmcc | hi mandel_ - hope you're having a good trip! | 17:21 |
| mandel_ | mmcc, hello! | 17:22 |
| mmcc | mandel_ this path change is more fun than we expected - did you know we had functions for finding the path to syncdaemon in both u1 client and sso client? and only the one in sso client actually works on windows? | 17:22 |
| mmcc | (if you don't know, now you know… ) | 17:22 |
| mandel_ | mmcc, no, I had no idea.. oh my god! | 17:23 |
| mandel_ | mmcc, that is terrible (that it happens) is great that you found it :) | 17:23 |
| mmcc | heh. not sure I'd go so far as terrible, but yeah it's good to get it cleaned up | 17:24 |
| mmcc | so i'm working on a branch that makes u1client find its own path to sd, so SSO doesn't need to know about where sd is installed | 17:24 |
| mmcc | and it uses the right registry key on windows | 17:24 |
| mmcc | I have found many skeletons on this journey | 17:24 |
| mandel_ | mmcc, was it using the wrong registry key? | 17:26 |
| mandel_ | mmcc, what the.. how did we even work on windows? | 17:26 |
| mmcc | mandel_ - the one in ubuntuone/platform/tools/windows.py was. | 17:26 |
| mmcc | that function was called get_sd_install_path | 17:26 |
| mmcc | the function get_activation_cmdline in SSO uses the right one | 17:26 |
| mandel_ | mmcc, but is using SD_INSTALL_PATH, is not that correct? | 17:27 |
| mmcc | no | 17:28 |
| mandel_ | mmcc, and what is that? | 17:29 |
| mmcc | the one that we set in the windows installer is "path-ubuntuone-syncdaemon" | 17:29 |
| mmcc | the reg key "SyncDaemonInstallPath" is never set anywhere | 17:29 |
| mandel_ | mmcc, that looks like someone changed it in sso and did not bother to change it in the tools from ubuntuone.. I hate that we have that much until code in sso | 17:30 |
| mandel_ | mmcc, if you need reviews let me know, now I'm going to tr and find pizza, it cannot be hard in italy :) | 17:30 |
| mmcc | the only way this works is that tcpactivation is starting the service using the command line from its description, and the start() method in tools/perspective_broker.py is never called | 17:30 |
| mmcc | mandel_ yes it shouldn't be in sso at all, I'm moving it back into u1client | 17:31 |
| mandel_ | mmcc, superb, that is a much better idea, let me know if you need any help | 17:31 |
| mandel_ | ok, I'm off to visit florence... | 17:32 |
| mandel_ | all, laters! | 17:32 |
| mmcc | mandel_ I would like your confirmation that I'm understanding tcpactivation correctly, | 17:32 |
| mmcc | whoops | 17:32 |
| mmcc | I'll check later(s) | 17:32 |
| briancurtin | ralsina: 1-1? | 18:24 |
| ralsina | briancurtin: sure, let's do it on IRC | 18:24 |
| ralsina | brb errands | 19:18 |
| gatox | alecu, ping | 19:33 |
| alecu | gatox: pong | 19:36 |
| gatox | alecu, i finish with the refactor, and everything is working..... the problem is that it says that the diff is 2420 lines (+874/-1003) 7 files modified | 19:37 |
| gatox | but..... almost all of them are deletions | 19:37 |
| alecu | gatox: are those the test being refactored? | 19:40 |
| gatox | alecu, yes | 19:41 |
| gatox | the original branch without the refactoring was 839 lines | 19:41 |
| gatox | alecu, so.... is that ok?? or do you have any magic idea? | 19:44 |
| gatox | alecu, this is the branch: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/darwin4-fsevents/+merge/111914 | 19:44 |
| alecu | gatox: what were the changes added before refactoring the tests? | 19:49 |
| alecu | gatox: can't you split those things in two? | 19:49 |
| alecu | gatox: the 839 lines first, then the refactoring of the tests. | 19:49 |
| gatox | alecu, yes..... but it would be a lot of code...... without tests...... and then another branch with the tests | 19:50 |
| gatox | ahhhhhhh | 19:50 |
| gatox | sooooooo..... you want me to do the refactoring in another branch | 19:50 |
| gatox | ? | 19:50 |
| alecu | gatox: I thought that was what we discussed with you and mandel! | 19:50 |
| alecu | gatox: or perhaps I got that backwards? | 19:50 |
| gatox | no..... we discuss that i should do the refactor in the same branch to not land ugly code | 19:51 |
| gatox | ok..... i'll propose 2 branches..... give me a couple of minutes | 19:51 |
| * gatox reverting..... | 19:51 | |
| gatox | again....... :S | 19:51 |
| alecu | gatox: I thought that was at -3... and you and mandel convinced me of doing all the refactoring fo the tests later | 19:52 |
| gatox | i would prefer to do it in a diff branch :P | 19:52 |
| alecu | gatox: you should *demand* mandel to give the bzr pipeline talk again. | 19:52 |
| gatox | alecu, i don't trust in mandel | 19:53 |
| gatox | jejejeje | 19:53 |
| alecu | gatox: neither do I !!! | 19:53 |
| gatox | alecu, so, now this is without the refactoring: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/darwin4-fsevents/+merge/111914 | 19:54 |
| gatox | now i'll propose another one with the refactoring | 19:54 |
| gatox | alecu, you'll need to wait that launchpad updated | 19:54 |
| gatox | updates | 19:54 |
| gatox | alecu, ok..... so this one is the final one for filesystem notifications: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/darwin4-fsevents/+merge/111914 ....... and this one is for the tests refactoring: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/darwin-tests-refactoring/+merge/113289 | 20:02 |
| gatox | the last one has some conflicts..... i'm fixing it | 20:04 |
| gatox | alecu, but it also shows a lot of lines in the diff: 2654 lines (+672/-1489) 3 files modified | 20:06 |
| gatox | butttttttt..... 1489 are deletions | 20:07 |
| gatox | alecu, there are the two branches.... now i'll email mandel about this (he says he like to review branches while he listen to talks :P) | 20:08 |
| gatox | ok..... email sent..... and EOD for me! | 20:10 |
| alecu | gatox: ???? how comes the second branch is bigger than when they were merged? | 20:10 |
| gatox | alecu, magic | 20:11 |
| gatox | alecu, probably..... because some of the lines in darwin 4 are tests that i'm adding..... and i the next one i'm removing those lines to refactor them... or something like that | 20:12 |
| alecu | ack | 20:13 |
| gatox | alecu, i already sent an email to mandel.... so.... i'm off for today (and happy! :D) | 20:13 |
| gatox | alecu, let me know how the review goes :P | 20:13 |
| dobey | need to run. later all. | 20:46 |
| alecu | briancurtin: a couple more lint issues here: https://code.launchpad.net/~brian.curtin/ubuntu-sso-client/py3-urllib/+merge/112429 | 21:00 |
| briancurtin | i wish lint was actually useful, or it worked on windows | 21:01 |
| briancurtin | or something | 21:01 |
| alecu | briancurtin: sorry about that... | 21:04 |
| briancurtin | alecu: it's not your fault! none of these changes show lint notices on my box, which is weird | 21:05 |
| briancurtin | so i think everything's fine when i push the branch | 21:05 |
| alecu | briancurtin: I usually run my windows virtualbox from ubuntu, and I share the source tree from the host to every devel guest. | 21:05 |
| alecu | briancurtin: perhaps that can help you with this. | 21:05 |
| alecu | briancurtin: I'm using virtualbox's "shared folders" but surely vmware has something similar. | 21:05 |
| briancurtin | i run directly on windows. now that i have a better VMware setup i should probably try again to get a dev environment running on ubuntu | 21:06 |
| alecu | briancurtin: don't worry about that just now... but I can give you a hand with that after your holiday if you need. | 21:07 |
| briancurtin | last time i tried to set it up, something about LXC didn't work or there was a version mismatch...ended up never figuring it out | 21:07 |
| briancurtin | but that was months ago | 21:07 |
| alecu | briancurtin: lxc as in "linux containers" ? weird. | 21:08 |
| briancurtin | yeah, that was a part of the directions and someone helped me try to set it up, but we couldnt get it running | 21:08 |
| alecu | briancurtin: that's a bit weird. lxc is a way to do lightweight virtualization, to have linux running on top of linux, and it's mostly used instead of vmware... I do not use lxc at all right now, just heavyweight VMs with windows and all ubuntu versions running on top of a single Precise. | 21:13 |
| mmcc | alecu, I'm wondering if there's a HOWTO somewhere for using xbox shared folders with source trees - I tried to set that up a while ago but ran into permissions issues in the goest... | 21:16 |
| mmcc | s/guest/goest/ | 21:16 |
| mmcc | er. you know… guest | 21:16 |
| alecu | mmcc: right. And virtualbox, right? | 21:16 |
| alecu | :-) | 21:16 |
| mmcc | yes. hah! | 21:16 |
| mmcc | I typed v box, and os x 10.7 autocorrects like iPhones do :( | 21:17 |
| alecu | mmcc: hahahahahaah | 21:17 |
| mmcc | earlier today I typed 'd obey' and it wrote 'dopey' | 21:17 |
| mmcc | :( | 21:17 |
| alecu | lolz | 21:17 |
| alecu | mmcc: I don't have a HOWTO, but here's what I do: | 21:18 |
| alecu | mmcc: I just mount my ~/canonical folder from my host in my ~/canonical folder in the guest | 21:18 |
| alecu | mmcc: and I always run bzr from the host | 21:19 |
| alecu | mmcc: if I run it on the guest, then the guest would say that every file was added the execute bit | 21:19 |
| alecu | mmcc: so my rule is to never use it there. | 21:19 |
| alecu | mmcc: but I can edit from any guest though. | 21:20 |
| mmcc | alecu, interesting. I'll have to give that a try | 21:20 |
| briancurtin | alecu: py3-urllib should be corrected, at least for the lint warnings related to my stuff (the TODO are others) | 21:26 |
| alecu | briancurtin: great. Yes, the other ones are there in trunk too. | 21:26 |
| alecu | briancurtin: in py3-StringIO there seems to be an unneeded "import sys" | 21:27 |
| briancurtin | alecu: where at? | 21:28 |
| briancurtin | alecu: ah i see | 21:28 |
| alecu | briancurtin: +1 to py3-urllib | 21:36 |
| briancurtin | alecu: thanks! | 21:36 |
| mmcc | Ok I have to run again, sorry I've been out of touch a bit today. I'm going to work more tonight, should have branches for this path setup problem tested and ready tomorrow. I'll be working tomorrow morning. | 21:46 |
| mmcc | s/this problem/all these problems/ | 21:46 |
| alecu | briancurtin: I think that while replacing u"..." -> "" in any given file, we should also replace any "" -> "".encode("utf-8"). | 22:08 |
| alecu | briancurtin: for instance, in one of the test files we are checking mixing both types of strings, and replacing only one makes no sense... | 22:09 |
| alecu | briancurtin: let me find it. | 22:09 |
| briancurtin | could be. unicode/bytes/str isn't something i've ever had to care about so weird stuff probably slipped in | 22:10 |
| alecu | briancurtin: for instance, test_get_simple_token_name and related. | 22:10 |
| alecu | briancurtin: btw: I think that "compat.text_type" looks weird, but I think we'll get used to that :P | 22:11 |
| alecu | briancurtin: it beats having to guess whether the file was updated or not. | 22:12 |
| briancurtin | yeah it's not the greatest | 22:12 |
| alecu | briancurtin: hhmmm... I seem that we *can't* blindly replace "" -> "".encode("utf-8") | 22:15 |
| alecu | briancurtin: either | 22:15 |
| alecu | briancurtin: it looks like some tests already assume the implicit unicode to bytes comparison as in py2. | 22:15 |
| briancurtin | alecu: here is the remaining diff of parts that i haven't covered - https://pastebin.canonical.com/69391/ | 22:18 |
| briancurtin | i haven't looked into this part yet, but i dont think we need to do anything about the filter/list-comp change since we just use the result as an iterator anyway | 22:19 |
| briancurtin | the self.next() vs next(self) part looks like a 2to3 confusion, since i think that next() call is something inside PyQt IIRC. we will probably have to tackle that part once we can actually run with PyQt on Py3 | 22:20 |
| alecu | briancurtin: right. | 22:20 |
| briancurtin | i don't know a good strategy to port the metaclass stuff, haven't really looked into that yet | 22:20 |
| briancurtin | and with that, it's EOD. i would like to stick around but i have to go do a bunch of last minute shopping before the vacation | 22:22 |
| alecu | briancurtin: have a great time! | 22:22 |
| briancurtin | alecu: will do. see you soon! | 22:22 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!