[12:02] gmb hi. I made an "approve" review of https://code.launchpad.net/~gmb/lpsetup/make-lp-lxc-ip-discoverable-bug-1019181/+merge/113955 albeit with a bit of muttering in the comments. [12:02] gary_poster, I think we should make a "kill doctests in lpsetup" card. The unittests I've found for inithost aren't all that comprehensive, and I'd started down the doctest road earlier... Might make a good branch for this afternoon, actually... [12:03] cool, gmb, sounds good [12:04] gary_poster, So, would you rather have something like "if os.path.exists(path1): elseif os.path.exists(path2): else: explode? [12:05] gmb, in a "that's yucky and inconvenient but more paranoid" sort of way, yes. I'd lean that way. OTOH, I could understand someone not leaning that way under the circumstances, which is why I approved as is [12:06] gary_poster, I'm easy either way - I just took the path of least ugliness. [12:07] gmb, ack. you choose. reviewer privilege is to mutter, developer privilege is to decide when to ignore muttering. :-) [12:07] * gmb adds that to the reviewer checklist. [12:07] :-) [12:08] gary_poster, I'll go for paranoia, just to get my paranoia out of the way early in the week. [12:08] :-) ok [12:09] bac benji gmb https://plus.google.com/hangouts/_/e7868bb3734212293bb6e76928d75059512d29dc?authuser=1&hl=en-US [12:10] gary_poster, Is that at the end of our static URL? [12:10] gmb, oh booh, I forgot [12:10] no [12:10] Ok. [12:10] gmb, are you there already? [12:41] * gmb -> lunches [13:00] gary_poster: i'm creating a hangout [13:00] bac try our shared one [13:50] * benji reboots [14:19] bac, So, pre-commit.sh in lpsetup... does a lot of lint spewage mean failure? [14:20] (I'm assuming so, because my tests are passing but the branch won't land because pre-commit.sh fails) [14:20] yes, it should not spew, gmb [14:21] Um. [14:21] bac, I see 139 lines of spew [14:21] http://paste.ubuntu.com/1082829/ [14:23] gmb: try running pre-commit.sh in trunk, after pulling [14:24] bac, Nope, still spews. [14:24] bac, You don't have some kind of global config for pocketlint do you? [14:24] gmb: no b/c it passed in tarmac for me on friday, so there is nothing environmental for me that makes it work [14:24] Oh. [14:24] That's... [14:24] vexing [14:25] gmb: but it did fail on tarmac for you? [14:25] bac, Yes [14:26] bac, Ah, might be pep8 that's failing... [14:26] (Rather than pocketlint) [14:26] Oh, no, it's both. [14:28] gmb: your pep8 and pocketlint are both in /usr/bin? [14:28] bac, pep8 is in /usr/local/bin [14:28] gmb: who owns that? [14:29] i mean dpkg -S [14:29] bac, root [14:29] sorry, see above [14:29] python-pocket-lint: /usr/lib/python2.7/dist-packages/pocketlint/contrib/pep8.py [14:29] python-pocket-lint: /usr/share/pyshared/pocketlint/contrib/pep8.py [14:30] gmb, I just freshly installed everything and ran tests to try and help. on precise I don't see the errors you got in trunk [14:30] Oh... [14:31] gmb: are the tarmac failures shown in your MP? if so, which is it? [14:31] /usr/bin/pocketlint [14:31] /usr/bin/pep8 [14:33] bac, Oh, actually... No, Tarmac is full of test failures. Which is disappointing but, I've just realised, to be expected... [14:33] So clearly noise is on my machine, not on tarmac (I was looking at the log before, not the MP) [14:33] I'll look at that later, when I've fixed the tests. [14:33] Maybe _I've_ got some global config. [14:38] gary_poster, Haha. So, paranoia causes the test suite to break, because checking for the existence of a file that's not going to be installed on the test machine at import time is always going to fail. [14:38] So I'm going to switch back to less-paranoid-and-more-elegant-anyway. [14:38] gmb, ok cool [15:17] hey benji, you are running tests on inithost and bac and I just saw something we did there that could never possibly work. I could make a card for it, but I suspect you'll need to change it yourself. Is your branch fairly up to date--say, you have all the code from Friday? If so, in inithost.initialize, there is a section with comment "# Set up Apache modules". That needs to be dedented to be run as root. [15:18] benji, are you already going to be fixing that, or should I make a card? [15:19] benji, over here! :-) ok thanks [15:19] pfft [15:19] :-) [15:32] gary_poster: https://code.launchpad.net/~bac/lpsetup/install-lxc-rename/+merge/113992 [16:01] why does the canonicaladmin leave calendar sort in reverse order by first name? is that some kind of statement? [16:01] * bac -> lunches [18:01] hey gary_poster, i'm trying to reconcile the card you created with the tasks in the hangout notes. [18:03] gary_poster: this card just seems to be an expansion of item 3 in the notes. that's how i'm proceeding. [18:14] bac, ok. I *think it was 3 + 4 [18:17] gary_poster: if 3+4 it will require a lot more than that card specified. that's ok, just trying to ensure we're on the same page. [18:17] bac, I like small branches, small cards. Divide up as you think would be best [18:18] bac, also if you'd like to pair again just let me know. [18:18] gary_poster: sure. now is fine. [18:18] bac, I'm in the "usual" channel--or I will be in a moment after I prepare [19:09] bac you left channel [19:09] ok [20:46] bac you left channel [21:21] benji, your test runner is so polite that it aplogizes if there is a failure! :-) I have questions but will send on email so you can have an evening. Thanks! [21:24] gary_poster: rockstar accepted the tarmac fix and will merge it shortly [21:24] bac, yay!