[05:58] <PaoloRotolo> Good morning
[06:01] <coolbhavi> good morning PaoloRotolo
[06:01] <PaoloRotolo> Hi coolbhavi
[06:11] <dpm> good morning
[06:24] <PaoloRotolo> Good morning dpm
[06:24] <dpm> hey PaoloRotolo, how are you? :)
[06:24] <PaoloRotolo> dpm, fine, thanks :)
[06:24] <dpm> nice
[06:25] <dpm> wow, lots of apps being submitted for the app showdown!
[06:26] <PaoloRotolo> dpm, yes, 14 app in 7 hours
[06:28] <PaoloRotolo> uhm, look this app: https://myapps.developer.ubuntu.com/dev/apps/1249/
[06:30] <PaoloRotolo> it looks like an terminal-only app
[06:49] <PaoloRotolo> Good morning dholbach
[06:49] <dholbach> good morning
[06:49] <dholbach> ciao PaoloRotolo
[06:49] <PaoloRotolo> :)
[06:49] <dholbach> come stai? cosa fai?
[06:49] <dholbach> ajmitch, the queue is pretty full :)
[06:50] <dholbach> ajmitch, we've got to make a decision on what we do in terms of "we propose changes, they get overwritten next time 'quickly package' is run"
[06:50] <PaoloRotolo> dholbach, yeah, only 14 app in 7 hours ;)
[06:51] <dholbach> PaoloRotolo, plus all the other ones which were in there already :)
[06:51] <PaoloRotolo> right
[06:52] <PaoloRotolo> BTW, this looks like interesting: https://myapps.developer.ubuntu.com/dev/apps/1249/
[06:52] <PaoloRotolo> It maybe a terminal-only app
[06:53] <PaoloRotolo> is*
[07:14] <dholbach> dpm, I broke the apps brancher on Friday and almost put it back together yesterday - I hope just a bit more time will sort it out
[07:16] <dpm> ok, thanks for the heads up
[07:16] <dpm> Refactoring, refactoring.... :-)
[07:16] <dholbach> I almost rewrote it completely
[07:16] <dholbach> but I guess that's just how things work
[07:17]  * dpm hugs dholbach
[07:18] <dpm> dholbach, here's the bug I was telling you about last week re: p-d-e, it seems it is confirmed, it's not only me: the p-d-e version in -proposed makes quickly throw Unicode errors and fail - https://bugs.launchpad.net/quickly/+bug/1021969
[07:20] <dpm> The only related thing I can see in the changelog is  "auto.py: Fix crash when encountering an UTF-8 Python source code file.", but there is no bug # associated with that change
[07:20] <dholbach> dpm, http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/quantal/python-distutils-extra/quantal/revision/41 maybe?
[07:25] <dpm> ah, nice one, thanks
[07:25]  * dpm looks
[07:29] <didrocks> needing help? :)
[07:30]  * didrocks just finished his email backlog
[07:30] <didrocks> hey dpm
[07:30] <dpm> hey didrocks, help would be awesome :)
[07:30] <dpm> I think there are two things at play here:
[07:30] <didrocks> so, I saw an email about crash, let me look at it again
[07:30] <didrocks> yeah?
[07:31] <dpm> the latest p-d-e in precise-proposed and quickly don't play along well
[07:31] <didrocks> you are speaking about https://bugs.launchpad.net/quickly/+bug/1021969
[07:31] <dpm> one thing is about Unicode warnings
[07:31] <didrocks> isn't it?
[07:31] <dpm> yeah
[07:32] <dpm> so looking closely at it
[07:32] <dpm> the Unicode issue are only warnings
[07:32] <dpm> the real issue is the debconf 6 or debconf 8 dependency check
[07:32] <dpm> I think
[07:33] <didrocks> well, let's look to fix them :)
[07:33] <dpm> awesome :)
[07:33] <didrocks> so, first thing first, the warning
[07:33] <didrocks> I'm on quantal
[07:33] <dpm> there's bug 995653 on p-d-e, which might be related
[07:34] <didrocks> should I just quickly create an app
[07:34] <didrocks> and try to package it?
[07:34] <didrocks> sorry, started to lag…
[07:34] <didrocks>  didrocks | I'm on quantal
[07:34] <didrocks>  didrocks | should I just quickly create an app
[07:34] <didrocks>  didrocks | and try to package it?
[07:35] <dpm> didrocks, I could confirm the bug with a test app and just packaging it, yeah, but...
[07:35] <dpm> I assume the p-d-e fix is in Quantal, not sure about the last Quickly fix
[07:35] <didrocks> dpm: let me try, upgrading to latest first
[07:35] <didrocks> ah
[07:35] <didrocks> you mean the commit that dholbach pointed at isn't in precise?
[07:36] <dpm> the commit he pointed at is in precise-proposed
[07:36] <dpm> for p-d-e
[07:36] <dpm> 2.33-0ubuntu0.1
[07:37] <didrocks> ah
[07:37] <didrocks> so, I should get the same crash in quantal, one sec
[07:37] <dpm> python-distutils-extra |     2.32-2 |       precise | source, all
[07:37] <dpm> python-distutils-extra | 2.33-0ubuntu0.1 | precise-proposed | source, all
[07:37] <dpm> python-distutils-extra |     2.33-1 |       quantal | source, all
[07:38] <dpm> But for Quickly
[07:38] <dpm>    quickly | 12.04-0ubuntu1 | precise/universe | source, all
[07:38] <dpm>    quickly | 12.04-0ubuntu2 | precise-updates/universe | source, all
[07:38] <dpm>    quickly | 12.04-0ubuntu3 | precise-proposed/universe | source, all
[07:38] <dpm>    quickly | 12.05-0ubuntu1 | quantal/universe | source, all
[07:38] <didrocks> let me try try try :)
[07:39] <dpm> So I'm not sure if the fix in 12.04-0ubuntu3 from precise-proposed is in Quantal
[07:39] <didrocks> ok, getting the warning!
[07:39] <didrocks> quickly create ubuntu-application foo
[07:39] <didrocks> cd foo
[07:39] <didrocks> quickly package
[07:39] <dpm> ok, good, that's a start :)
[07:39] <didrocks> now, let's see ;)
[07:44] <dholbach> dpm, I just deployed http://bazaar.launchpad.net/~ubuntu-app-review-contributors/apps-brancher/trunk/revision/64 - let's see how it goes
[07:44] <dpm> cool
[07:44] <didrocks> dholbach: "deployed"?
[07:45] <dholbach> yeah, put it on appbot@holba.ch
[07:45]  * didrocks looks the bzr history, something is weird :)
[07:45] <didrocks> there is a bot running your lint app?
[07:46] <dpm> they are two apps: one is the apps-brancher, which dumps myapps.d.u.c submissions into bzr branches for review - that's what the bot runs
[07:46] <dholbach> what is this?
[07:46] <dholbach> Waiting to hear from Launchpad about your decision...
[07:46] <dholbach> Please set a password for your new keyring
[07:46] <dholbach> I never got that from py-launchpadlib
[07:46] <dpm> the other app is arb-lint, which is run manually, if I'm not mistaken
[07:47] <dholbach> dpm, correct
[07:49] <dpm> dholbach, there is only one mention of a keyring in https://help.launchpad.net/API/launchpadlib/, not sure what the message above could be
[07:49] <didrocks> the message it the "please ack this app with your credential in launchpad"
[07:49] <didrocks> is*
[07:49] <didrocks> the one opening your browser
[07:50] <dholbach> it opened w3m
[07:50] <dholbach> and I put in all the data
[07:50] <dholbach> I hope it doesn't want a passphrase whenever I start the script
[07:50] <dholbach> ... or I'll be a bit unhappy
[07:51] <didrocks> you don't really need one AFAIK
[07:51] <dholbach> argh
[07:51] <dholbach> it needs one
[07:53] <didrocks> urgh
[07:53] <dholbach> this looks wrong too: https://launchpad.net/+authorize-token?oauth_token=<blablabla>&allow_permission=DESKTOP_INTEGRATION
[07:53] <dholbach> I don't think I want DESKTOP_INTGRATION on my server
[07:54] <didrocks> dholbach: that's weird, for all my bots, I don't need that, I just bound it once to launchpad and no passphrase
[07:56] <dholbach> yeah, same here
 dholbach: http://www.mail-archive.com/launchpad-users@lists.launchpad.net/msg01653.html
 "5. If your script is not intended for interactive use, pass in a credentials_file argument to login_with() to avoid the keyring.
[07:59] <didrocks> interesting
[08:01] <dpm> dholbach, it seems https://help.launchpad.net/API/launchpadlib/#Authenticated_access_for_website_integration does not mention the credentials_file, though
[08:02] <dpm> It also mentions: "You might have noticed that system is pretty hacky. It hasn't gotten much attention, because we don't know of any third-party websites that are integrating Launchpad functionality in a way that requires OAuth tokens."
[08:02] <dpm> ouch
[08:03] <didrocks> ok, got the line about the warning
[08:03] <dholbach> ok, it's running now
[08:03] <dholbach> http://appbot.holba.ch/log/log.txt
[08:04] <didrocks> oh got it
[08:04] <didrocks> we are forcing the utf-8 encoding
[08:04] <didrocks> and the string itself tells "it's ok, it's utf-8"
[08:05] <dholbach> I'm out to take the dog for a walk, brb
[08:18] <dpm> "XKCD Browser was submitted to the ARB"
[08:18] <dpm> nice :)
[08:21] <didrocks> dholbach: dpm: ok, got some chat with pitti about the actual issue , I'll file a bug, mark the current p-d-e verification failed, do a test case and fix it
[08:22] <dpm> didrocks, wow, awesome, thanks!
[08:22] <didrocks> yw :)
[08:25] <dpm> didrocks, if you've got some time to look at the 'quickly.templatetools.CantUpdateFile: debhelper (>= 6), was not found in the file ' crash on quickly 12.04-0ubuntu3, that would help us a lot too, as I've already seen 3 o 4 appshowdown participants hitting it
[08:25] <dpm> on https://bugs.launchpad.net/quickly/+bug/1021969, I mean
[08:25] <didrocks> dpm: yeah, let me look at that next
[08:25] <dpm> excellent
[08:25] <didrocks> dpm: doing some meeting, fixing p-d-e, then on that
[08:25]  * dpm hugs didrocks
[08:25] <didrocks> dpm: I want to organize some public hangouts as well on how we can improve the whole thing
[08:25]  * didrocks hugs dpm
[08:27] <dpm> didrocks, oh definitely, I like the idea! We'll be a bit busy with the voting the first days of the week, but let's chat and we can organize some hangouts by the end of the week/start of the next one
[08:27] <didrocks> dpm: excellent!
[09:06] <dholbach> dpm, I think it's working now - search for "Name: 'teatime'" in http://appbot.holba.ch/log/log.txt :)
[09:06] <dholbach> it find the stupid text file, then finds the ppa info in there then branches the source package from there
[09:06] <dholbach> we've got to sort out the submission process
[09:07] <dholbach> it's so error-prone :-(
[09:09] <didrocks> dholbach: fix proposed, do you fancy a backport for the SRU? I can do the quantal upload
[09:09] <dpm> dholbach, I agree, the "upload something" box should be replaced by something sensible
[09:09] <didrocks> or I can backport to precise if you want :)
[09:09] <dholbach> didrocks, no time - I've got to get the brancher working and then start reviewing like 100 apps :/
[09:10] <didrocks> ok, will do then
[09:10] <dholbach> thanks a lot
[09:10] <dholbach> the next time we meet the first round(s) will be on me :)
[09:10] <didrocks> \o/
[09:11] <dpm> yeah, thanks didrocks, and I'll get the next
[09:11] <didrocks> thanks dholbach, dpm :)
[09:11] <didrocks> ok, once it's done, let's look at the next issue
[09:13] <dpm> dholbach, would it be possible to get a list of all apps in the queue with your apps brancher and with not too much effort, so that I can more easily find out which apps are part of the showdown? I can look at the Trello board and to mhall119's spreadsheet, but those are manually updated, and it would be nice to be able to cross-check with an automatically generated list
[09:18] <dholbach> right now all I have is https://code.launchpad.net/ubuntu-app-reviews and http://appbot.holba.ch/log/log.txt
[09:18] <dholbach> dpm, and the brancher currently still fails on some "special" submissions, so I'm fixing those issues as we speak
[09:20] <dpm> dholbach, ok, cool. No rush on me, I'll update either the Trello or the spreadsheet and if you've managed to do your fixes, I'll cross-check with the apps brancher output
[09:22] <dholbach> dpm, I'll set myself a time limit, so I don't spend all day trying to fix the brancher
[09:22] <dpm> ok, sounds sensible
[09:27] <dholbach> but I think I ironed out quite a few issues already
[09:35] <didrocks> dpm: https://bugs.launchpad.net/quickly/+bug/1021969 is not the one about debhelper? right?
[09:38] <dpm> didrocks, I think it is, looking at the terminal output, I see "quickly.templatetools.CantUpdateFile: debhelper (>= 6), was not found in the file /home/crazycoder/testme/debian/control" - I think the latest Quickly SRU in precise-proposed looks for the debhelper >=6 line to add to the debian/control file, but p-d-e in precise-proposed or whatever generates the control file creates it with debhelper >=8 ?
[09:38] <dpm> so it cannot find the line to replace
[09:38] <didrocks> dpm: oh silly me, I stopped at the warnings :/
[09:39] <didrocks> ok, so the same bug has 2 issues
[09:39] <dpm> yeah
[09:39] <dpm> I got distracted by the warnings too at first
[09:39] <didrocks> hum, do we have his project?
[09:39] <didrocks> to reproduce the issue?
[09:39] <didrocks> oh
[09:39] <didrocks> it's mterry's update
[09:40] <didrocks> ah, his update will fail with all new created projects :/
[09:41] <didrocks> dpm: I don't understand, do you know how 12.04-0ubuntu3 can be in precise-proposed where nothing was released in quantal?
[09:41] <dpm> yes, it can be reproduced with a new test project and p-d-e from -proposed
[09:42] <didrocks> yeah, I know why
[09:43] <didrocks> dpm: still wondering, did you have to pay the SRU team so that they let Quickly in without an upload to quantal? :)
[09:43] <dpm> hahaha
[09:43] <didrocks> dpm: like, if I prepare another fix, will they let us do the same? (you can do your small magic, trick?)
[09:44] <dpm> didrocks, it was a critical bug, as no one could use 'submitubuntu' for the app showdown. mterry was really helpful and fixed it really quickly and uploaded it to precise-proposed. Then I added the testcase and modified the description to qualify for SRU, and asked the sru team to approve the -proposed upload. I probably made a mistake in following the SRU rules
[09:44] <dpm> I can try :)
[09:44] <didrocks> dpm: let's see ;)
[09:45] <didrocks> dpm: I'll separate that in another bug report to make things clear
[09:45] <didrocks> we can argue, "it's a one line fix, what can it break?" ;)
[09:46] <dpm> famous last words?
[09:47] <dpm> ok, I need to drive someone to the airport, I'll be back in ~40 min
[09:48] <didrocks> dpm: yeah, famous last words :)
[09:48] <didrocks> sure
[09:49] <dpm> ok, bbl!
[10:17] <didrocks> dpm-bbl: when you get back, I will appreciate some tests from you on quantal :)
[10:18] <didrocks> http://paste.ubuntu.com/1082514/
[10:19] <didrocks> tell me, if it works, I'll push that to -proposed immediatly :)
[10:51] <dholbach> dpm, I hope I just found the last really weird bug (apps having the suggested package name of '0.1')
[10:51] <dholbach> I'll re-run the whole thing again and hope it'll work - I'll take a break in the meantime
[10:51] <dholbach> if it doesn't meet our expectations, I'll leave it for now
[10:51] <dpm> dholbach, ok
[10:52] <dpm> didrocks, I'm still on 12.04. Would it help if I test it there?
[11:05] <dpm> didrocks, I'm getting this after applying the above patch to 12.04's quickly: http://pastebin.ubuntu.com/1082563/
[11:10] <PaoloRotolo> Can I help you?
[11:15] <dpm> PaoloRotolo, sure, we're trying to fix https://bugs.launchpad.net/quickly/+bug/1021969, if you happen to be in Quantal and fancy applying that patch ^ and see if it works for you, that'd be helpful
[11:15] <didrocks> back before shower :)
[11:15] <didrocks> oupsss, my bad :)
[11:15] <didrocks> let me fix that
[11:16] <PaoloRotolo> dpm, uhm, I'm in Precise
[11:16] <didrocks> dpm: add templatetools in front of CantUpdateFile please
[11:16] <dpm> ok
[11:17] <didrocks> templatetools.CantUpdateFile :)
[11:21] <didrocks> dpm: keep me posted ;)
[11:21]  * didrocks takes a shower, bbiab
[11:21] <dpm> didrocks, it seems it failed: http://pastebin.ubuntu.com/1082569/
[11:22] <didrocks> dpm: weird, it seems it applied it though
[11:22] <didrocks> dpm: can you pastebin debian/control please?
[11:22] <didrocks> sorry
[11:22] <didrocks> debian/foo/DEBIAN/control
[11:24] <dpm> sure
[11:25] <dpm> didrocks, http://pastebin.ubuntu.com/1082574/
[11:25] <dpm> ah, wait
[11:26] <didrocks> there is no Build-deps line
[11:26] <dpm> didrocks, http://pastebin.ubuntu.com/1082578/
[11:27] <didrocks> waow
[11:27] <didrocks> how is it possible?
[11:27] <didrocks> dpm: I guess mterry's patch never worked, right?
[11:28] <didrocks> it misses build-deps
[11:28] <didrocks> in the previous version for SRU
[11:28] <dpm> it did work with the stable p-d-e
[11:28] <didrocks> dpm: that's weird, were you using the version from -proposed?
[11:28] <didrocks> are you sure? I can clearly see what misses ;)
[11:28] <didrocks> trunk worked because there is not the typo
[11:28] <dpm> let me give you the versions
[11:28] <didrocks> but the version in -proposed has this typo
[11:29] <dpm> dpm@avenc:/tmp/foo$ apt-cache policy quickly python-distutils-extra
[11:29] <dpm> quickly:
[11:29] <dpm>   Instaŀlat: 12.04-0ubuntu3
[11:29] <dpm>   Candidat:  12.04-0ubuntu3
[11:29] <dpm>   Taula de versió:
[11:29] <dpm>  *** 12.04-0ubuntu3 0
[11:29] <didrocks> weird
[11:29] <dpm>         500 http://archive.ubuntu.com/ubuntu/ precise-proposed/universe amd64 Packages
[11:29] <dpm>         100 /var/lib/dpkg/status
[11:29] <dpm>      12.04-0ubuntu2 0
[11:29] <didrocks> anyway, fixed
[11:29] <dpm>         500 http://archive.ubuntu.com/ubuntu/ precise-updates/universe amd64 Packages
[11:29] <dpm>      12.04-0ubuntu1 0
[11:29] <dpm>         500 http://archive.ubuntu.com/ubuntu/ precise/universe amd64 Packages
[11:29] <dpm> python-distutils-extra:
[11:29] <dpm>   Instaŀlat: 2.33-0ubuntu0.1
[11:29] <dpm>   Candidat:  2.33-0ubuntu0.1
[11:29] <dpm>   Taula de versió:
[11:29] <dpm>  *** 2.33-0ubuntu0.1 0
[11:29] <dpm>         500 http://archive.ubuntu.com/ubuntu/ precise-proposed/main amd64 Packages
[11:29] <dpm>         100 /var/lib/dpkg/status
[11:29] <didrocks> dpm: can you try to reapply the patch?
[11:29] <dpm>      2.32-2 0
[11:30] <dpm>         500 http://archive.ubuntu.com/ubuntu/ precise/main amd64 Packages
[11:30] <dpm> didrocks, sure, where's the new patch?
[11:30] <didrocks> like, reinstall the ubuntu-template package from -proposed
[11:30] <didrocks> (with --reinstall)
[11:30] <didrocks> and then, I'll give you the patch
[11:30] <dpm> ah, gotcha
[11:30] <didrocks> dpm: sorry, I don't have a precise machine to test :/
[11:30] <dpm> np
[11:31] <dpm> didrocks, ok, reinstalled
[11:32] <didrocks> dpm: http://paste.ubuntu.com/1082592/
[11:32] <didrocks> dpm: see the missing Build-depends in the diff?
[11:32] <didrocks> for the first stanza
[11:32] <didrocks> not sure how it could have worked without that
[11:33] <dpm> didrocks, that is really weird - I wrote and verified the test case on https://bugs.launchpad.net/quickly/+bug/1018038
[11:33] <dpm> anyway, let me apply the patch
[11:34] <didrocks> dpm: are you sure you weren't using a trunk quickly? ;)
[11:34] <didrocks> with the add_path
[11:34] <didrocks> it will take this one
[11:34] <didrocks> (trunk doesn't have this typo)
[11:34] <dpm> no, I tend to use packages for everything
[11:34] <dpm> so no quickly trunk
[11:34] <didrocks> dpm: oh wait
[11:34] <didrocks> dpm: there is an extra space
[11:34] <didrocks> Build-Depends:
[11:34] <didrocks> with 2 spaces
[11:34] <didrocks> please remove one the 4 trimes
[11:34] <didrocks> times*
[11:35] <didrocks> I can redo the patch if you want :)
[11:36] <dpm> no, don't worry, let me look at it
[11:39] <dpm> didrocks, success! http://paste.ubuntu.com/1082598/ :-)
[11:39] <didrocks> \o/
[11:39]  * didrocks pushes
[11:40] <didrocks> dpm: I have clearly no idea how the previous version worked TBH in -proposed
[11:41] <dpm> no idea too, but it seems it worked for the app showdown submitters too
[11:41] <didrocks> dpm: ok, it's waiting the SRU team to ack in -proposed
[11:41] <dpm> cool, thanks!
[11:41]  * didrocks is puzzled, maybe they updated first with something else and so it's silently skipped
[11:41] <didrocks> anyway, when running I had a lot of ideas for Quickly
[11:41] <didrocks> and make it entirely testable
[11:41] <didrocks> I'll write that down after my shower :)
[11:42] <dpm> cool :)
[11:42] <dpm> I've got https://bugs.launchpad.net/ubuntu/+source/quickly/+bug/1021675 also queued up for either you or mterry, but it's not as important as the previous one, so it can wait
[11:49] <didrocks> let me have a quick look
[11:51] <didrocks> dpm: easy to fix, I can sneak that in the previous upload
[11:51] <didrocks> dpm: you didn't ping anyone yet to get it approved, right?
[11:52] <dpm> didrocks, that'd be cool, yeah. No, I haven't talked to anyone yet
[11:52] <didrocks> but if so, you have to my guinea pig again as I don't have the needed setup :/
[11:52] <dholbach> mhall119, dpm: I don't know why the apps-brancher does this, but at some stage it starts importing the same apps (from PPAs, I think) into different directories
[11:52] <dholbach> ie.: "Successfully imported '/tmp/apps-brancher/tarballs/teatime/teatime-unity_12.06+bzr60~precise1.dsc' into '/home/appbot/production/apps-brancher/data/branches/tagplayer'."
[11:53] <dholbach> and I couldn't figure out why
[11:53] <dholbach> I'll give up and review stuff manually
[11:53] <dholbach> ... after I grabbed a quick lunch
[11:53] <dholbach> if you're bored, lp:apps-brancher should have the newest code :)
[11:53]  * dpm puts on guinea pig's hat to help didrocks
[11:53] <dpm> or should it be ears?
[11:54] <dpm> dholbach, ok, let me finish with the quickly bugs testing and preparing the apps voting list first, and then I can see if I can help in any way
[11:55] <didrocks> dpm: a hat is fine :)
[11:55]  * didrocks wakes up his regexp foo
[11:58] <didrocks> fixed :)
[11:59] <didrocks> no need for guinea pig even
[11:59] <didrocks> I tried manuallly an a file
[11:59] <didrocks> on*
[11:59] <didrocks> should be good
[12:01] <didrocks> dpm: it's waiting unapproved in -proposed, completing the bug, you can ping someone if you want
[12:01] <dpm> thanks didrocks!
[13:00] <dholbach> back
[13:06] <coolbhavi> dholbach, good noon
[13:08] <dholbach> hi coolbhavi
[13:14] <didrocks> dholbach: how many submission do you have to review guys?
[13:14] <didrocks> hey coolbhavi
[13:14] <dholbach> LOADS
[13:14] <dholbach> 100+
[13:15] <didrocks> waow, would you make some stats about the number of Quickly apps?
[13:15] <didrocks> or can I build building those stats?
[13:15] <didrocks> would be interesting to know :)
[13:15] <coolbhavi> hey didrocks so we have our task cut out this week :)
[13:16] <didrocks> coolbhavi: I truly believe you :)
[13:53] <dholbach> didrocks, dpm, mhall119: I think I fixed the apps-brancher
[13:53] <dholbach> what a mess :)
[13:53] <dholbach> I cleared all the cache again and it's going through the queue
[13:54] <didrocks> dholbach: what does the apps-brancher does? it downloads all the entries and project them in directories?
[13:54] <dholbach> it's a bit more complicated
[13:54] <dholbach> basically it just tries to put all the incoming submissions into a coherent form
[13:55] <dholbach> it puts all of these crazy things into a bzr branch:
[13:55] <dholbach>  - tarballs
[13:55] <dholbach>  - source packages in tarballs
[13:55] <dholbach>  - branches in feedback page comments
[13:55] <dholbach>  - branches mentioned in uploaded text files
[13:55] <dholbach>  - source packages from ppas mentioned in feedback page comments
[13:55] <dholbach>  - source packages from ppas mentioned in uploaded text files
[13:56] <dholbach> that's it
[13:56] <dholbach> its output is here: http://appbot.holba.ch/log/log.txt and here: https://code.launchpad.net/ubuntu-app-reviews
[13:56] <dholbach> oh and runs pkgme if necessary
[13:57] <dholbach> some of the imports were broken because it got confused by which import strategy it should follow
[13:57] <dholbach> but I hope I fixed that now
[13:57] <dholbach> and it pushes with --overwrite
[13:57] <dholbach> so I hope we'll be fine once its done
[13:59] <dholbach> didrocks, ^
[14:00] <didrocks> dholbach: oh wow :)
[14:00] <didrocks> you did get serious about it :)
[14:01] <didrocks> the comments on an entry is done in a special web?
[14:01] <dholbach> it'd be good if we just expected branches in myapps :)
[14:01] <dholbach> https://myapps.developer.ubuntu.com/dev/apps/350/ → "Feedback" tab → https://myapps.developer.ubuntu.com/dev/apps/350/feedback/
[14:05] <didrocks> dholbach: so you prefer feedback inside a branch rather than in a web ui?
[14:06] <didrocks> dholbach: does anybody develop myapps still?
[14:06] <dholbach> yes, it's developed by the commercial apps team
[14:06] <dholbach> it'd be good to just have one branch we have to worry about
[14:08] <didrocks> yeah
[14:22] <dholbach> dpm, mhall119: I set up http://pad.ubuntu.com/PHDShTbnFi
[14:37] <dholbach> dpm, mhall119, coolbhavi, highvoltage: does http://pad.ubuntu.com/PHDShTbnFi look alright to you?
[14:38] <coolbhavi> dholbach, seems good here... :) thanks dholbach
[14:39] <dpm> looks good to me dholbach, I'd just add the exact steps how to do: 'get the source of a app showdown submission'
[14:40] <dholbach> yes, that's just a little bit less clear right now as the apps brancher is still running
[14:41] <coolbhavi> dpm, usually I have seen a source link or else I get it from a ppa if its there.. Please correct me if I'm wrong here
[14:41] <mhall119> dholbach: what is putting packages into ppa:ubuntu-app-review-contributors/ppa?
[14:41] <dholbach> mhall119, nothing, but arb-lint is there
[14:41] <mhall119> ah, ok
[14:42] <dholbach> I'll have a look at pictag
[14:43] <mhall119> coolbhavi: wendar: stgraber: ajmitch: https://docs.google.com/a/canonical.com/spreadsheet/ccc?key=0AofbdH5hl5CbdGxXQVFVXy1BTTI3NUY4a0F2bGFZSlE#gid=0 is what I've been using to track submissions so far
[14:52] <dholbach> didrocks, I just had a chat with an app submitter about his app and it seems like somewhere during his app development, the /opt changes in debian/rules were reverted: https://launchpadlibrarian.net/109545227/pictag_12.07.9_12.07.11.diff.gz
[14:52] <dholbach> any idea what might have caused this?
[14:53] <didrocks> dholbach: it's reverted if he doesn't use submitubuntu but just quickly share or quickly release
[14:53]  * didrocks notes down and "/opt mode"
[14:53] <dholbach> ok, so this might mean that we maybe run into other cases where this has happened
[14:54] <didrocks> yeah, if people doesn't use the same command
[14:54] <dholbach> ok, I'll bear that in mind for the reviews
[14:54] <didrocks> dholbach: interesting case, I'm adding a note about a swith to keep it into /opt :)
[14:54] <dholbach> I'll add it to the pad
[14:57] <dholbach> added to http://pad.ubuntu.com/PHDShTbnFi
[14:58] <dholbach> ciao PaoloRotolo
[14:58] <PaoloRotolo> ciao dholbach :)
[14:58] <dholbach> come stai?
[14:58] <PaoloRotolo> dholbach, bene ;)
[14:58] <dholbach> didrocks, do we have an example of a good --extras debian/rules online somewhere?
[15:02] <mhall119> dholbach: how does apps-brancher pick which package and version in a PPA to use?
[15:02] <dholbach> the newest version and the package based on what's in myapps
[15:03] <mhall119> dholbach: um, we might have a problem...
[15:03] <mhall119> https://myapps.developer.ubuntu.com/dev/apps/1141/ is for 'webbar', but when I click the uploaded file, it's got info for gtkreddit
[15:07] <dholbach> let me have a look
[15:07] <dholbach> ah yes
[15:08] <dholbach> it might be worth checking in with the CA team
[15:08] <dholbach> it might be some overly aggressive caching
[15:08] <dholbach> or a bug
[15:08] <dholbach> or a problem of the submitter (too much copy/paste) :)
[15:09] <dholbach> it seems like the apps-brancher finished, I'll have it have a go again and see what happens
[15:10] <mhall119> dholbach: looks to be different submitters, so I'm thinking a bug in the upload
[15:15] <dholbach> didrocks, did we decide what we do with .rtupdate files?
[15:15] <dholbach> bah, barry and doko are still not around
[15:16] <didrocks> dholbach: well, it's not really needed TBH, but I see no objection of keeping it for now
[15:16] <dholbach> ^ ajmitch, highvoltage, stgraber, wendar, coolbhavi: we have a bit of a problem with .rtupdate files - I'd like to have your opinion
[15:16] <dholbach> we have for example files like usr/share/python/runtime.d/protoborsa.rtupdate
[15:16] <didrocks> and when the times come, we can see fixing that directly in dh_python
[15:16] <dholbach> ...created by dh_python2 - it seems like they are only needed in case a new python is installed
[15:17] <didrocks> it is, I made some more research this week-end
[15:17] <didrocks> and it's the case
[15:17] <dholbach> I filed a bug at https://bugs.launchpad.net/ubuntu/+source/python-distutils-extra/+bug/1021207
[15:17] <dholbach> ok, in that case I'll just write a small snippet to remove the file and make a note of it in the arb-lint warning
[15:17] <dholbach> so we can fix them
[15:17] <dholbach> and still get them into the software center
[15:21] <didrocks> dholbach: why do you want to remove them?
[15:21] <mhall119> dholbach: if you see another mismatch between submission app and uploaded file app, let me know and I'll file a bug against this
[15:21] <mhall119> noodles says it's possible there's a race condition in the upload
[15:21] <didrocks> it's making no more harm than a desktop file AFAIK :)
[15:21] <dholbach> mhall119, cool
[15:21] <mhall119> a second example should confirm that
[15:22] <dholbach> didrocks, the TB was unhappy with files outside /opt
[15:22]  * didrocks will get the /opt killed soon :)
[15:22] <didrocks> it's really a hack
[15:22] <didrocks> not supported
[15:22] <didrocks> I told it from day 0
[15:22] <dholbach> so I'd prefer to get the app in before having to go through another few weeks of discussion
[15:22] <dholbach> didrocks, you're not alone
[15:22] <didrocks> dholbach: I have strong args now :)
[15:23] <dholbach> haha
[15:23] <mhall119> didrocks: if you can kill /opt/, I'll buy you a beer at UDS
[15:23] <mhall119> two even
[15:23] <mhall119> and a nice beer, not the cheap ones
[15:23]  * didrocks has 3 beers proposal today :)
[15:23] <didrocks> I will get drunk at UDS :)
[15:24] <highvoltage> good morning dholbach
[15:24] <dholbach> hey highvoltage
[15:34] <mhall119> dholbach: please check https://code.launchpad.net/~ubuntu-app-review-contributors/ubuntu-app-reviews/adbassist
[15:34] <mhall119> it seems to have code for a different project
[15:35] <coolbhavi> dpm, I just copied you on a app submission mail query
[15:35] <dholbach> mhall119, in a sec
[15:35] <dholbach> just need to update arb-lint for the .rtupdate thing
[15:36] <dholbach> I also updated http://pad.ubuntu.com/PHDShTbnFi
[15:38] <coolbhavi> mhall119, right it shows tagplayer
[15:39] <dholbach> mhall119, coolbhavi: adbassist fixed - please let me know when you should run into any of these
[15:40] <coolbhavi> sure dholbach let me checkout
[15:40] <dholbach> (or: check out the apps-brancher, read the readme file and ./retry https://myapps.developer.ubuntu.com/dev/apps/<nr>/) :-)
[15:42] <mhall119> dholbach: thanks
[15:42]  * dholbach will have a look at Slidewall
[15:42] <mhall119> coolbhavi: PM me your email and I'll give you write access to the spreadsheet
[15:43] <dpm> coolbhavi, replied, thanks!
[15:44] <coolbhavi> thanks dpm!
[15:51] <dholbach> I put another few small updates into http://pad.ubuntu.com/PHDShTbnFi
[15:54] <dholbach> slidewall looks like it's ready :)
[15:57]  * dholbach sent a vote mail to the ARB
[15:57]  * dholbach has a look at lightread
[16:03] <highvoltage> nice
[16:04] <coolbhavi> highvoltage, do we still use XB-Screenshot-Url and other XB fields
[16:04] <coolbhavi> ?
[16:05] <dholbach> lightread is unfortunately not ready yet
[16:08]  * dholbach has a look at miv
[16:13]  * PaoloRotolo has a look at cuttlefish
[16:13] <PaoloRotolo> dholbach, arb-lint says that "the app might be too big to be reviewed by the ARB."
[16:13] <dholbach> PaoloRotolo, how big is it?
[16:14] <PaoloRotolo> dholbach, It has 33 source  files and 3838 lines of code.
[16:14] <PaoloRotolo> (arb-lint says this)
[16:14] <PaoloRotolo> that*
[16:14] <dholbach> maybe that's not too bad then :)
[16:14] <dholbach> feel free to ignore what arb-lint says :)
[16:15] <dholbach> miv is not ready either :/
[16:15] <PaoloRotolo> dholbach, ok,thanks :) Can we change 'copyright' now?
[16:16] <dholbach> PaoloRotolo, it's not necessary
[16:16] <dholbach> we talked about it a couple of days ago
[16:16] <dholbach> have a look at http://pad.ubuntu.com/PHDShTbnFi - I tried to clarify the process for reviewing a bit
[16:16] <dholbach> let me know if anything on there is not clear enough
[16:17]  * dholbach has a look at "correct me"
[16:18] <PaoloRotolo> dholbach, I read your mail, and you have modified the copyright in Slidewall
[16:18] <dholbach> PaoloRotolo, ah ok, yes - you're right
[16:18] <dholbach> that was just a few wrong entries
[16:18] <wendar> dholbach: what's that with the .rtupdate files?
[16:18] <dholbach> not an update to DEP5
[16:19] <PaoloRotolo> dholbach, sure, thanks
[16:19] <dholbach> wendar, they get created by dh_python2, seem to be only run (if at all) by the python{,3} maintainer scripts if an update to a new version happens - they are placed in usr/lib
[16:20] <wendar> dholbach: we mostly don't use dh_python2
[16:20] <wendar> dholbach: we don't actually use any of its features for arb apps
[16:20] <wendar> dholbach: and, it does have a nasty habit of leaving files outside /opt
[16:20] <dholbach> wendar, most of the current apps produced with quickly have it and the only files I found this time were these .rtupdate files
[16:21] <wendar> dholbach: we can probably give those a pass for quickly this cycle
[16:21] <wendar> dholbach: see if we can tweak quickly for next cycle
[16:23] <dholbach> wendar, so you'd say we just ignore the existence of the usr/share/python/runtime.d/*.rtupdate files?
[16:24]  * dholbach has a look at TickIt
[16:25] <wendar> dholbach: yes, I think they fit the general category of files that currenly only work outside of /opt
[16:25] <wendar> dholbach: which, we have a general exception for
[16:25] <dholbach> ok, works for me
[16:25] <dholbach> I'll update arb-lint to not complain about them
[16:25] <wendar> dholbach: though, it's worth checking if they actually do work outside of opt
[16:26] <wendar> keep the check in arb-lint though
[16:26] <dholbach> yes, I'll just rephrase it to indicate that nothing needs to be changed
[16:26] <PaoloRotolo> Ok, cuttlefish is ready for me :) I'm writing a mail
[16:26] <wendar> or, can you make it skip the check on quickly apps?
[16:26] <wendar> (do you have a way to tell in arb-lint if you're dealing with a quickly app?)
[16:27] <dholbach> wendar, I'll test if there's a .quickly file
[16:27] <dholbach> will let you know in a bit
[16:27] <wendar> dholbach: sounds good
[16:27] <dholbach> wendar, does http://pad.ubuntu.com/PHDShTbnFi roughly look OK to you for reviewing the app showdown apps?
[16:28] <wendar> dholbach: ack, sorry, I don't have my Ubuntu SSO password here at work
[16:28] <dholbach> hang on
[16:29] <dholbach> http://paste.ubuntu.com/1083017/
[16:31] <wendar> dholbach: that looks good
[16:32] <dholbach> sweet
[16:32] <dholbach> thanks
[16:32] <wendar> dholbach: maybe a little more explicit that arb-lint errors, or missing the guidelines listed are reasons to hold or fix the package?
[16:32] <wendar> dholbach: and then, include instructions on how to submit the app for vote
[16:32] <didrocks> wendar: hey ;)
[16:33] <wendar> dholbach: (no more complicated than sending an email to the app-review-board mailing list)
[16:33] <dholbach> wendar, yes, I guess that's what we're currently in the process of figuring out: what constitutes a "no go", what can be fixed easily in a separate branch and put to vote, etc
[16:33] <wendar> didrocks: hiya!
[16:33] <dholbach> I just started putting the instructions together a while ago
[16:33] <didrocks> wendar: I plan doing some Quickly hangouts next week (once the review is near the end) on a big refactoring and focus change. I want the ARB to be onboard with this, will you want to join?
[16:33] <didrocks> would*
[16:33] <wendar> dholbach: they look great, thanks!
[16:34] <dholbach> wendar, I changed arb-lint to stop complaining about .rtupdate files originating from quickly apps
[16:34] <wendar> dholbach: if we're not sure yet what's a holdable issue, could the ARB board offer to be available on IRC to answer questions from the arb-contributors?
[16:35] <dholbach> sure, everybody who reviews these apps is currently in here, so I guess you'll be pinged :)
[16:35] <wendar> didrocks: next week is OSCON, so my schedule may be a little tricky
[16:35] <wendar> didrocks: but, if I know the times in advance, I can plan to find a quiet room for the hangout
[16:35] <didrocks> wendar: hum ok, would you want to send an email? (or maybe we'll be able to do other hangouts later on)
[16:35] <didrocks> wendar: let's try that :)
[16:35] <didrocks> I plan to have 3/4 ones
[16:35] <wendar> didrocks: (as long as it's not right during my talk :)
[16:35] <didrocks> the first one being the ARB
[16:36] <didrocks> wendar: let's try to be reasonable :)
[16:36] <wendar> didrocks: that sounds cool
[16:37] <wendar> dholbach: hopefully, we can convert any questions into a helpful wiki page, so future arb-contributors have an easier startup
[16:38] <dholbach> agreed
[16:39] <wendar> dholbach: oh, and feel free to put your instructions up on the wiki in the AppReviewBoard/Review/... space
[16:39] <dholbach> sure, once they've settled down a bit :)
[16:40] <wendar> dholbach: yup, whenever you're comfortable posting them
[16:40] <dholbach> will do
[16:42]  * dholbach has a look at indicator-odometer
[16:45] <dpm> it seems Facebook has now been open-sourced and moved development to Launchpad: https://launchpad.net/facebook :-)
[16:47] <dholbach> indicator-odometer is not ready yet :/
[16:47]  * dholbach has a look at liberedit
[16:49] <dholbach> crêpe suzette - this is an interesting build failure: http://paste.ubuntu.com/1083044/
[16:49] <dholbach> didrocks, ^
[16:50]  * didrocks wants crêpe :)
[16:51] <didrocks> dholbach: shouldn't it be rather Gtk.TreeStore.new(str, str)
[16:51] <didrocks> ?
[16:51] <dholbach> didrocks, I don't know - but I can ask the submitter - I was just surprised than any of this would happen during the build
[16:52] <didrocks> dholbach: oh, this can happens, because during the build, python-distutils-extra has to import the modules
[16:52] <didrocks> to detect the dependencies
[16:53] <stgraber> dholbach: for slidewall: No name for the copyright holder? Why is there multiple entries in debian/changelog? Pretty bad English in short-description/description. debian/compat and debian/control don't seem to agree on the debhelper version.
[16:53] <didrocks> so some code can run if they want code running on import
[16:53] <didrocks> (which is a bad practice)
[16:56] <dholbach> stgraber, multiple entries because of quickly, ppas, etc - sorry - I'll fix it
[16:57] <dholbach> looks like it will be harder to get any of the apps in - I'll see which kinds of checks I can put into arb-lint
[17:00] <dpm> man it's now the 4th app I review for voting that has the participation details containing data from another app...
[17:02] <stgraber> :)
[17:03] <dholbach> didrocks, can we have something which forces quickly users to enter their name and email address? :)
[17:03] <didrocks> dholbach: well, it's forcing to use launchpad :)
[17:03] <didrocks> and it has the email address then
[17:04] <dholbach> some had their real name missing in debian/changelog, etc
[17:04] <didrocks> why? people are not providing them publically on lp neither in the submission?
[17:04] <dholbach> but maybe they were corner cases
[17:04] <didrocks> it should use as DEBEMAIL the name they put
[17:04] <didrocks> for quickly :)
[17:04] <didrocks> (and launchpad ;))
[17:06] <dholbach> ok, I'll keep an eye out to see if there's more cases
[17:06] <dholbach> stgraber, updated the branch
[17:08]  * dholbach has a look at Qtiko
[17:12] <stgraber> W: slidewall source: unused-build-dependency-on-cdbs
[17:13] <dholbach> stgraber, fixed
[17:13] <stgraber> W: slidewall source: ancient-standards-version 3.8.3 (current is 3.9.3)
[17:13] <stgraber> dholbach: ^
[17:13] <stgraber> dholbach: similar to what I said to Paolo by e-mail, you also bundle a python/runtime.d directory in the binary package, the directory is empty but it still shouldn't be there
[17:13] <stgraber> the rest, AFAICT looks good
[17:13] <stgraber> (haven't run it, just checked pre/post build)
[17:13] <dholbach> stgraber, I just talked to wendar and she said that it'd be fine to leave it in there
[17:14] <dholbach> and fixed the standards-version too
[17:15] <stgraber> dholbach: so, I'm not against allowing the .rtupdate files as they are indeed useful in case of a python upgrade, but I'm clearly against shipping an empty directory
[17:16] <dholbach> ok, I'll put the file back
[17:16] <stgraber> so you either ship it or remove it completely, but the current situation in both your packaging and Paolo is somewhere in the middle (letting dh create /usr/share/python/runtime.d/ but removing its content)
[17:16] <dholbach> fixed
[17:19] <stgraber> dholbach: +1ed
[17:20] <dholbach> yeeehaw
[17:20] <dholbach> thanks a bunch
[17:20] <stgraber> dholbach: is that quicky generating broken packaging? I notice a lot of similarities between your packaging and Paolo's
[17:21] <dholbach> stgraber, some folks might have used older versions of quickly/p-d-e
[17:21] <dholbach> some fixes are still in -proposed, etc
[17:22] <dholbach> this app showdown was/is going to be a stress test for a lot of pieces in the puzzle :)
[17:24] <dholbach> mhall119, dpm: I updated http://pad.ubuntu.com/PHDShTbnFi as far as I could and sent a couple of reviews in
[17:24] <dholbach> I'll have a quick stab at trying to fix some of the bugs in arb-lint
[17:25] <dholbach> but then will soon go to grab dinner and call it a day
[17:42] <mhall119> dholbach: didrocks: did you guys see we got an AppArmour GUI as one of the submissions?
[17:42] <dholbach> nice
[17:42] <didrocks> mhall119: oh, I didn't! really really nice indeed :)
[17:43] <mhall119> https://myapps.developer.ubuntu.com/dev/apps/1222/
[17:44] <dpm> dholbach, ok
[17:45] <dpm> mhall119, I saw that one too, I thought it was pretty cool!
[17:52] <dholbach> can somebody add http://pad.ubuntu.com/PHDShTbnFi for the app showdown review dance to the /topic?
[17:52] <dholbach> ... please ... :)
[17:53]  * dholbach has a look at pictag again
[18:09] <dpm> mhall119, the PPA column is now complete on the spreadsheet, so it should be ready for csv export. How are you getting on with the script?
[18:09] <dholbach> alright my friends
[18:09] <dholbach> time to call it a day
[18:09] <dholbach> see you tomorrow
[18:10] <mhall119> dpm: in progress, using a bunch of dholbach's code
[18:10] <mhall119> bye dholbach
[18:10] <dpm> mhall119, cool, thanks. So do you think it might work and might be a good way to install the PPAs?
[18:11] <dpm> well, the packages from ppas, I mean
[18:11] <dholbach> :)
[18:12] <dpm> btw, we've got nearly 140 apps for the contest!
[18:21] <mhall119> dpm: yeah, once I get the info I can make a script to do whatever we want
[18:29] <dpm> great
[18:45] <mhall119> 143 known apps, 130 submitted
[18:59] <mhall119> FYI, we're having some problems with the uploaded file links: https://bugs.launchpad.net/developer-portal/+bug/1022697
[20:55] <ajmitch> so looking at the queue now, we don't get to sleep this week, I guess
[21:21] <stgraber> ajmitch: and for the next year or so ;)
[21:27] <wendar> ajmitch: it's pretty intense
[21:27] <wendar> ajmitch: I'd say the only way it's going to happen is if the arb-contributors handle it
[21:28] <wendar> ajmitch: and also, that we (ARB board) should prioritize older apps, and apps that aren't part of the showdown
[21:28] <ajmitch> we still nee to have time to review & vote everything that comes through
[21:29] <wendar> ajmitch: dholbach has got a good handle on the showdown, and I suspect could bring some work hours to bear on them
[21:29] <ajmitch> right, he's done a lot for organising that
[21:29] <wendar> ajmitch: true, but in theory they'll be lighter reviews, since they're (all?) quickly apps, and have already been arb-linted
[21:29] <ajmitch> we're still the only people who can approve & upload :)
[21:30] <wendar> ajmitch: and, if we find an issue, we can flag it and let the arb-contributors know to hold all apps that have that problem
[21:30] <wendar> ajmitch: it's adaptive pre-filtering on what we see :)
[21:30] <stgraber> yeah, so far I caused 3 fixes in arb-lint today ;)
[21:31] <wendar> ajmitch: still, agreed, I don't know how we're going to manage it
[21:31] <stgraber> I'll have to find new things to be picky about ;)
[21:31] <wendar> ajmitch: and I'm pretty much out of commission until my talk at OSCON next week
[21:31] <ajmitch> this app showdown has certainly found a few interesting bugs in quickly & related bits
[21:31] <ajmitch> wendar: fair enough :)
[21:31] <wendar> ajmitch: though, after the talk, I've got nothing else but astrophysics on my plate :)
[21:31] <ajmitch> heh
[21:31] <ajmitch> that sounds fun
[21:32] <wendar> (in non-work hours, anyway)
[21:32] <wendar> it is fun :)
[21:32]  * ajmitch has nothing except helping organise a conference - that doesn't take much time, right? :)
[21:32] <wendar> ha, ha, famous last words :)
[21:32] <wendar> which conference?
[21:32] <ajmitch> kiwi pycon
[21:32] <wendar> sweet!
[22:27] <mhall119> wendar: ajmitch: can you guys change "Suggested package name" in MyApps?
[22:28] <mhall119> or is that only for the submitter?
[22:29] <wendar> mhall119: we can't change suggested package name, but we set the actual released package name
[22:30] <mhall119> ok
[22:33] <mhall119> w 61
[22:34] <ajmitch> mhall119: running into issues with odd data being submitted?
[22:38] <mhall119> ajmitch: just people either not grokking the purpose of the field, or it just not matching the name of the package in their PPA
[22:40]  * ajmitch did see some submissions where they put their own name in the application name field