[05:58] Good morning [06:01] good morning PaoloRotolo [06:01] Hi coolbhavi [06:11] good morning [06:24] Good morning dpm [06:24] hey PaoloRotolo, how are you? :) [06:24] dpm, fine, thanks :) [06:24] nice [06:25] wow, lots of apps being submitted for the app showdown! [06:26] dpm, yes, 14 app in 7 hours [06:28] uhm, look this app: https://myapps.developer.ubuntu.com/dev/apps/1249/ [06:30] it looks like an terminal-only app [06:49] Good morning dholbach [06:49] good morning [06:49] ciao PaoloRotolo [06:49] :) [06:49] come stai? cosa fai? [06:49] ajmitch, the queue is pretty full :) [06:50] ajmitch, we've got to make a decision on what we do in terms of "we propose changes, they get overwritten next time 'quickly package' is run" [06:50] dholbach, yeah, only 14 app in 7 hours ;) [06:51] PaoloRotolo, plus all the other ones which were in there already :) [06:51] right [06:52] BTW, this looks like interesting: https://myapps.developer.ubuntu.com/dev/apps/1249/ [06:52] It maybe a terminal-only app [06:53] is* [07:14] dpm, I broke the apps brancher on Friday and almost put it back together yesterday - I hope just a bit more time will sort it out [07:16] ok, thanks for the heads up [07:16] Refactoring, refactoring.... :-) [07:16] I almost rewrote it completely [07:16] but I guess that's just how things work [07:17] * dpm hugs dholbach [07:18] dholbach, here's the bug I was telling you about last week re: p-d-e, it seems it is confirmed, it's not only me: the p-d-e version in -proposed makes quickly throw Unicode errors and fail - https://bugs.launchpad.net/quickly/+bug/1021969 [07:20] The only related thing I can see in the changelog is "auto.py: Fix crash when encountering an UTF-8 Python source code file.", but there is no bug # associated with that change [07:20] dpm, http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/quantal/python-distutils-extra/quantal/revision/41 maybe? [07:25] ah, nice one, thanks [07:25] * dpm looks [07:29] needing help? :) [07:30] * didrocks just finished his email backlog [07:30] hey dpm [07:30] hey didrocks, help would be awesome :) [07:30] I think there are two things at play here: [07:30] so, I saw an email about crash, let me look at it again [07:30] yeah? [07:31] the latest p-d-e in precise-proposed and quickly don't play along well [07:31] you are speaking about https://bugs.launchpad.net/quickly/+bug/1021969 [07:31] one thing is about Unicode warnings [07:31] isn't it? [07:31] yeah [07:32] so looking closely at it [07:32] the Unicode issue are only warnings [07:32] the real issue is the debconf 6 or debconf 8 dependency check [07:32] I think [07:33] well, let's look to fix them :) [07:33] awesome :) [07:33] so, first thing first, the warning [07:33] I'm on quantal [07:33] there's bug 995653 on p-d-e, which might be related [07:34] should I just quickly create an app [07:34] and try to package it? [07:34] sorry, started to lag… [07:34] didrocks | I'm on quantal [07:34] didrocks | should I just quickly create an app [07:34] didrocks | and try to package it? [07:35] didrocks, I could confirm the bug with a test app and just packaging it, yeah, but... [07:35] I assume the p-d-e fix is in Quantal, not sure about the last Quickly fix [07:35] dpm: let me try, upgrading to latest first [07:35] ah [07:35] you mean the commit that dholbach pointed at isn't in precise? [07:36] the commit he pointed at is in precise-proposed [07:36] for p-d-e [07:36] 2.33-0ubuntu0.1 [07:37] ah [07:37] so, I should get the same crash in quantal, one sec [07:37] python-distutils-extra | 2.32-2 | precise | source, all [07:37] python-distutils-extra | 2.33-0ubuntu0.1 | precise-proposed | source, all [07:37] python-distutils-extra | 2.33-1 | quantal | source, all [07:38] But for Quickly [07:38] quickly | 12.04-0ubuntu1 | precise/universe | source, all [07:38] quickly | 12.04-0ubuntu2 | precise-updates/universe | source, all [07:38] quickly | 12.04-0ubuntu3 | precise-proposed/universe | source, all [07:38] quickly | 12.05-0ubuntu1 | quantal/universe | source, all [07:38] let me try try try :) [07:39] So I'm not sure if the fix in 12.04-0ubuntu3 from precise-proposed is in Quantal [07:39] ok, getting the warning! [07:39] quickly create ubuntu-application foo [07:39] cd foo [07:39] quickly package [07:39] ok, good, that's a start :) [07:39] now, let's see ;) [07:44] dpm, I just deployed http://bazaar.launchpad.net/~ubuntu-app-review-contributors/apps-brancher/trunk/revision/64 - let's see how it goes [07:44] cool [07:44] dholbach: "deployed"? [07:45] yeah, put it on appbot@holba.ch [07:45] * didrocks looks the bzr history, something is weird :) [07:45] there is a bot running your lint app? [07:46] they are two apps: one is the apps-brancher, which dumps myapps.d.u.c submissions into bzr branches for review - that's what the bot runs [07:46] what is this? [07:46] Waiting to hear from Launchpad about your decision... [07:46] Please set a password for your new keyring [07:46] I never got that from py-launchpadlib [07:46] the other app is arb-lint, which is run manually, if I'm not mistaken [07:47] dpm, correct [07:49] dholbach, there is only one mention of a keyring in https://help.launchpad.net/API/launchpadlib/, not sure what the message above could be [07:49] the message it the "please ack this app with your credential in launchpad" [07:49] is* [07:49] the one opening your browser [07:50] it opened w3m [07:50] and I put in all the data [07:50] I hope it doesn't want a passphrase whenever I start the script [07:50] ... or I'll be a bit unhappy [07:51] you don't really need one AFAIK [07:51] argh [07:51] it needs one [07:53] urgh [07:53] this looks wrong too: https://launchpad.net/+authorize-token?oauth_token=&allow_permission=DESKTOP_INTEGRATION [07:53] I don't think I want DESKTOP_INTGRATION on my server [07:54] dholbach: that's weird, for all my bots, I don't need that, I just bound it once to launchpad and no passphrase [07:56] yeah, same here [07:57] dholbach: http://www.mail-archive.com/launchpad-users@lists.launchpad.net/msg01653.html [07:57] "5. If your script is not intended for interactive use, pass in a credentials_file argument to login_with() to avoid the keyring. [07:59] interesting [08:01] dholbach, it seems https://help.launchpad.net/API/launchpadlib/#Authenticated_access_for_website_integration does not mention the credentials_file, though [08:02] It also mentions: "You might have noticed that system is pretty hacky. It hasn't gotten much attention, because we don't know of any third-party websites that are integrating Launchpad functionality in a way that requires OAuth tokens." [08:02] ouch [08:03] ok, got the line about the warning [08:03] ok, it's running now [08:03] http://appbot.holba.ch/log/log.txt [08:04] oh got it [08:04] we are forcing the utf-8 encoding [08:04] and the string itself tells "it's ok, it's utf-8" [08:05] I'm out to take the dog for a walk, brb [08:18] "XKCD Browser was submitted to the ARB" [08:18] nice :) [08:21] dholbach: dpm: ok, got some chat with pitti about the actual issue , I'll file a bug, mark the current p-d-e verification failed, do a test case and fix it [08:22] didrocks, wow, awesome, thanks! [08:22] yw :) [08:25] didrocks, if you've got some time to look at the 'quickly.templatetools.CantUpdateFile: debhelper (>= 6), was not found in the file ' crash on quickly 12.04-0ubuntu3, that would help us a lot too, as I've already seen 3 o 4 appshowdown participants hitting it [08:25] on https://bugs.launchpad.net/quickly/+bug/1021969, I mean [08:25] dpm: yeah, let me look at that next [08:25] excellent [08:25] dpm: doing some meeting, fixing p-d-e, then on that [08:25] * dpm hugs didrocks [08:25] dpm: I want to organize some public hangouts as well on how we can improve the whole thing [08:25] * didrocks hugs dpm [08:27] didrocks, oh definitely, I like the idea! We'll be a bit busy with the voting the first days of the week, but let's chat and we can organize some hangouts by the end of the week/start of the next one [08:27] dpm: excellent! [09:06] dpm, I think it's working now - search for "Name: 'teatime'" in http://appbot.holba.ch/log/log.txt :) [09:06] it find the stupid text file, then finds the ppa info in there then branches the source package from there [09:06] we've got to sort out the submission process [09:07] it's so error-prone :-( [09:09] dholbach: fix proposed, do you fancy a backport for the SRU? I can do the quantal upload [09:09] dholbach, I agree, the "upload something" box should be replaced by something sensible [09:09] or I can backport to precise if you want :) [09:09] didrocks, no time - I've got to get the brancher working and then start reviewing like 100 apps :/ [09:10] ok, will do then [09:10] thanks a lot [09:10] the next time we meet the first round(s) will be on me :) [09:10] \o/ [09:11] yeah, thanks didrocks, and I'll get the next [09:11] thanks dholbach, dpm :) [09:11] ok, once it's done, let's look at the next issue [09:13] dholbach, would it be possible to get a list of all apps in the queue with your apps brancher and with not too much effort, so that I can more easily find out which apps are part of the showdown? I can look at the Trello board and to mhall119's spreadsheet, but those are manually updated, and it would be nice to be able to cross-check with an automatically generated list [09:18] right now all I have is https://code.launchpad.net/ubuntu-app-reviews and http://appbot.holba.ch/log/log.txt [09:18] dpm, and the brancher currently still fails on some "special" submissions, so I'm fixing those issues as we speak [09:20] dholbach, ok, cool. No rush on me, I'll update either the Trello or the spreadsheet and if you've managed to do your fixes, I'll cross-check with the apps brancher output [09:22] dpm, I'll set myself a time limit, so I don't spend all day trying to fix the brancher [09:22] ok, sounds sensible [09:27] but I think I ironed out quite a few issues already [09:35] dpm: https://bugs.launchpad.net/quickly/+bug/1021969 is not the one about debhelper? right? [09:38] didrocks, I think it is, looking at the terminal output, I see "quickly.templatetools.CantUpdateFile: debhelper (>= 6), was not found in the file /home/crazycoder/testme/debian/control" - I think the latest Quickly SRU in precise-proposed looks for the debhelper >=6 line to add to the debian/control file, but p-d-e in precise-proposed or whatever generates the control file creates it with debhelper >=8 ? [09:38] so it cannot find the line to replace [09:38] dpm: oh silly me, I stopped at the warnings :/ [09:39] ok, so the same bug has 2 issues [09:39] yeah [09:39] I got distracted by the warnings too at first [09:39] hum, do we have his project? [09:39] to reproduce the issue? [09:39] oh [09:39] it's mterry's update [09:40] ah, his update will fail with all new created projects :/ [09:41] dpm: I don't understand, do you know how 12.04-0ubuntu3 can be in precise-proposed where nothing was released in quantal? [09:41] yes, it can be reproduced with a new test project and p-d-e from -proposed [09:42] yeah, I know why [09:43] dpm: still wondering, did you have to pay the SRU team so that they let Quickly in without an upload to quantal? :) [09:43] hahaha [09:43] dpm: like, if I prepare another fix, will they let us do the same? (you can do your small magic, trick?) [09:44] didrocks, it was a critical bug, as no one could use 'submitubuntu' for the app showdown. mterry was really helpful and fixed it really quickly and uploaded it to precise-proposed. Then I added the testcase and modified the description to qualify for SRU, and asked the sru team to approve the -proposed upload. I probably made a mistake in following the SRU rules [09:44] I can try :) [09:44] dpm: let's see ;) [09:45] dpm: I'll separate that in another bug report to make things clear [09:45] we can argue, "it's a one line fix, what can it break?" ;) [09:46] famous last words? [09:47] ok, I need to drive someone to the airport, I'll be back in ~40 min [09:48] dpm: yeah, famous last words :) [09:48] sure [09:49] ok, bbl! === dpm is now known as dpm-bbl [10:17] dpm-bbl: when you get back, I will appreciate some tests from you on quantal :) [10:18] http://paste.ubuntu.com/1082514/ [10:19] tell me, if it works, I'll push that to -proposed immediatly :) === dpm-bbl is now known as dpm [10:51] dpm, I hope I just found the last really weird bug (apps having the suggested package name of '0.1') [10:51] I'll re-run the whole thing again and hope it'll work - I'll take a break in the meantime [10:51] if it doesn't meet our expectations, I'll leave it for now [10:51] dholbach, ok [10:52] didrocks, I'm still on 12.04. Would it help if I test it there? [11:05] didrocks, I'm getting this after applying the above patch to 12.04's quickly: http://pastebin.ubuntu.com/1082563/ [11:10] Can I help you? [11:15] PaoloRotolo, sure, we're trying to fix https://bugs.launchpad.net/quickly/+bug/1021969, if you happen to be in Quantal and fancy applying that patch ^ and see if it works for you, that'd be helpful [11:15] back before shower :) [11:15] oupsss, my bad :) [11:15] let me fix that [11:16] dpm, uhm, I'm in Precise [11:16] dpm: add templatetools in front of CantUpdateFile please [11:16] ok [11:17] templatetools.CantUpdateFile :) [11:21] dpm: keep me posted ;) [11:21] * didrocks takes a shower, bbiab [11:21] didrocks, it seems it failed: http://pastebin.ubuntu.com/1082569/ [11:22] dpm: weird, it seems it applied it though [11:22] dpm: can you pastebin debian/control please? [11:22] sorry [11:22] debian/foo/DEBIAN/control [11:24] sure [11:25] didrocks, http://pastebin.ubuntu.com/1082574/ [11:25] ah, wait [11:26] there is no Build-deps line [11:26] didrocks, http://pastebin.ubuntu.com/1082578/ [11:27] waow [11:27] how is it possible? [11:27] dpm: I guess mterry's patch never worked, right? [11:28] it misses build-deps [11:28] in the previous version for SRU [11:28] it did work with the stable p-d-e [11:28] dpm: that's weird, were you using the version from -proposed? [11:28] are you sure? I can clearly see what misses ;) [11:28] trunk worked because there is not the typo [11:28] let me give you the versions [11:28] but the version in -proposed has this typo [11:29] dpm@avenc:/tmp/foo$ apt-cache policy quickly python-distutils-extra [11:29] quickly: [11:29] Instaŀlat: 12.04-0ubuntu3 [11:29] Candidat: 12.04-0ubuntu3 [11:29] Taula de versió: [11:29] *** 12.04-0ubuntu3 0 [11:29] weird [11:29] 500 http://archive.ubuntu.com/ubuntu/ precise-proposed/universe amd64 Packages [11:29] 100 /var/lib/dpkg/status [11:29] 12.04-0ubuntu2 0 [11:29] anyway, fixed [11:29] 500 http://archive.ubuntu.com/ubuntu/ precise-updates/universe amd64 Packages [11:29] 12.04-0ubuntu1 0 [11:29] 500 http://archive.ubuntu.com/ubuntu/ precise/universe amd64 Packages [11:29] python-distutils-extra: [11:29] Instaŀlat: 2.33-0ubuntu0.1 [11:29] Candidat: 2.33-0ubuntu0.1 [11:29] Taula de versió: [11:29] *** 2.33-0ubuntu0.1 0 [11:29] 500 http://archive.ubuntu.com/ubuntu/ precise-proposed/main amd64 Packages [11:29] 100 /var/lib/dpkg/status [11:29] dpm: can you try to reapply the patch? [11:29] 2.32-2 0 [11:30] 500 http://archive.ubuntu.com/ubuntu/ precise/main amd64 Packages [11:30] didrocks, sure, where's the new patch? [11:30] like, reinstall the ubuntu-template package from -proposed [11:30] (with --reinstall) [11:30] and then, I'll give you the patch [11:30] ah, gotcha [11:30] dpm: sorry, I don't have a precise machine to test :/ [11:30] np [11:31] didrocks, ok, reinstalled [11:32] dpm: http://paste.ubuntu.com/1082592/ [11:32] dpm: see the missing Build-depends in the diff? [11:32] for the first stanza [11:32] not sure how it could have worked without that [11:33] didrocks, that is really weird - I wrote and verified the test case on https://bugs.launchpad.net/quickly/+bug/1018038 [11:33] anyway, let me apply the patch [11:34] dpm: are you sure you weren't using a trunk quickly? ;) [11:34] with the add_path [11:34] it will take this one [11:34] (trunk doesn't have this typo) [11:34] no, I tend to use packages for everything [11:34] so no quickly trunk [11:34] dpm: oh wait [11:34] dpm: there is an extra space [11:34] Build-Depends: [11:34] with 2 spaces [11:34] please remove one the 4 trimes [11:34] times* [11:35] I can redo the patch if you want :) [11:36] no, don't worry, let me look at it [11:39] didrocks, success! http://paste.ubuntu.com/1082598/ :-) [11:39] \o/ [11:39] * didrocks pushes [11:40] dpm: I have clearly no idea how the previous version worked TBH in -proposed [11:41] no idea too, but it seems it worked for the app showdown submitters too [11:41] dpm: ok, it's waiting the SRU team to ack in -proposed [11:41] cool, thanks! [11:41] * didrocks is puzzled, maybe they updated first with something else and so it's silently skipped [11:41] anyway, when running I had a lot of ideas for Quickly [11:41] and make it entirely testable [11:41] I'll write that down after my shower :) [11:42] cool :) [11:42] I've got https://bugs.launchpad.net/ubuntu/+source/quickly/+bug/1021675 also queued up for either you or mterry, but it's not as important as the previous one, so it can wait [11:49] let me have a quick look [11:51] dpm: easy to fix, I can sneak that in the previous upload [11:51] dpm: you didn't ping anyone yet to get it approved, right? [11:52] didrocks, that'd be cool, yeah. No, I haven't talked to anyone yet [11:52] but if so, you have to my guinea pig again as I don't have the needed setup :/ [11:52] mhall119, dpm: I don't know why the apps-brancher does this, but at some stage it starts importing the same apps (from PPAs, I think) into different directories [11:52] ie.: "Successfully imported '/tmp/apps-brancher/tarballs/teatime/teatime-unity_12.06+bzr60~precise1.dsc' into '/home/appbot/production/apps-brancher/data/branches/tagplayer'." [11:53] and I couldn't figure out why [11:53] I'll give up and review stuff manually [11:53] ... after I grabbed a quick lunch [11:53] if you're bored, lp:apps-brancher should have the newest code :) [11:53] * dpm puts on guinea pig's hat to help didrocks [11:53] or should it be ears? [11:54] dholbach, ok, let me finish with the quickly bugs testing and preparing the apps voting list first, and then I can see if I can help in any way [11:55] dpm: a hat is fine :) [11:55] * didrocks wakes up his regexp foo [11:58] fixed :) [11:59] no need for guinea pig even [11:59] I tried manuallly an a file [11:59] on* [11:59] should be good [12:01] dpm: it's waiting unapproved in -proposed, completing the bug, you can ping someone if you want [12:01] thanks didrocks! [13:00] back [13:06] dholbach, good noon [13:08] hi coolbhavi [13:14] dholbach: how many submission do you have to review guys? [13:14] hey coolbhavi [13:14] LOADS [13:14] 100+ [13:15] waow, would you make some stats about the number of Quickly apps? [13:15] or can I build building those stats? [13:15] would be interesting to know :) [13:15] hey didrocks so we have our task cut out this week :) [13:16] coolbhavi: I truly believe you :) [13:53] didrocks, dpm, mhall119: I think I fixed the apps-brancher [13:53] what a mess :) [13:53] I cleared all the cache again and it's going through the queue [13:54] dholbach: what does the apps-brancher does? it downloads all the entries and project them in directories? [13:54] it's a bit more complicated [13:54] basically it just tries to put all the incoming submissions into a coherent form [13:55] it puts all of these crazy things into a bzr branch: [13:55] - tarballs [13:55] - source packages in tarballs [13:55] - branches in feedback page comments [13:55] - branches mentioned in uploaded text files [13:55] - source packages from ppas mentioned in feedback page comments [13:55] - source packages from ppas mentioned in uploaded text files [13:56] that's it [13:56] its output is here: http://appbot.holba.ch/log/log.txt and here: https://code.launchpad.net/ubuntu-app-reviews [13:56] oh and runs pkgme if necessary [13:57] some of the imports were broken because it got confused by which import strategy it should follow [13:57] but I hope I fixed that now [13:57] and it pushes with --overwrite [13:57] so I hope we'll be fine once its done [13:59] didrocks, ^ [14:00] dholbach: oh wow :) [14:00] you did get serious about it :) [14:01] the comments on an entry is done in a special web? [14:01] it'd be good if we just expected branches in myapps :) [14:01] https://myapps.developer.ubuntu.com/dev/apps/350/ → "Feedback" tab → https://myapps.developer.ubuntu.com/dev/apps/350/feedback/ [14:05] dholbach: so you prefer feedback inside a branch rather than in a web ui? [14:06] dholbach: does anybody develop myapps still? [14:06] yes, it's developed by the commercial apps team [14:06] it'd be good to just have one branch we have to worry about [14:08] yeah [14:22] dpm, mhall119: I set up http://pad.ubuntu.com/PHDShTbnFi [14:37] dpm, mhall119, coolbhavi, highvoltage: does http://pad.ubuntu.com/PHDShTbnFi look alright to you? [14:38] dholbach, seems good here... :) thanks dholbach [14:39] looks good to me dholbach, I'd just add the exact steps how to do: 'get the source of a app showdown submission' [14:40] yes, that's just a little bit less clear right now as the apps brancher is still running [14:41] dpm, usually I have seen a source link or else I get it from a ppa if its there.. Please correct me if I'm wrong here [14:41] dholbach: what is putting packages into ppa:ubuntu-app-review-contributors/ppa? [14:41] mhall119, nothing, but arb-lint is there [14:41] ah, ok [14:42] I'll have a look at pictag [14:43] coolbhavi: wendar: stgraber: ajmitch: https://docs.google.com/a/canonical.com/spreadsheet/ccc?key=0AofbdH5hl5CbdGxXQVFVXy1BTTI3NUY4a0F2bGFZSlE#gid=0 is what I've been using to track submissions so far [14:52] didrocks, I just had a chat with an app submitter about his app and it seems like somewhere during his app development, the /opt changes in debian/rules were reverted: https://launchpadlibrarian.net/109545227/pictag_12.07.9_12.07.11.diff.gz [14:52] any idea what might have caused this? [14:53] dholbach: it's reverted if he doesn't use submitubuntu but just quickly share or quickly release [14:53] * didrocks notes down and "/opt mode" [14:53] ok, so this might mean that we maybe run into other cases where this has happened [14:54] yeah, if people doesn't use the same command [14:54] ok, I'll bear that in mind for the reviews [14:54] dholbach: interesting case, I'm adding a note about a swith to keep it into /opt :) [14:54] I'll add it to the pad [14:57] added to http://pad.ubuntu.com/PHDShTbnFi [14:58] ciao PaoloRotolo [14:58] ciao dholbach :) [14:58] come stai? [14:58] dholbach, bene ;) [14:58] didrocks, do we have an example of a good --extras debian/rules online somewhere? [15:02] dholbach: how does apps-brancher pick which package and version in a PPA to use? [15:02] the newest version and the package based on what's in myapps [15:03] dholbach: um, we might have a problem... [15:03] https://myapps.developer.ubuntu.com/dev/apps/1141/ is for 'webbar', but when I click the uploaded file, it's got info for gtkreddit [15:07] let me have a look [15:07] ah yes [15:08] it might be worth checking in with the CA team [15:08] it might be some overly aggressive caching [15:08] or a bug [15:08] or a problem of the submitter (too much copy/paste) :) [15:09] it seems like the apps-brancher finished, I'll have it have a go again and see what happens [15:10] dholbach: looks to be different submitters, so I'm thinking a bug in the upload [15:15] didrocks, did we decide what we do with .rtupdate files? [15:15] bah, barry and doko are still not around [15:16] dholbach: well, it's not really needed TBH, but I see no objection of keeping it for now [15:16]