| === Anxi80 is now known as 17SABLW46 | ||
| coolbhavi | jono: hi how are you? | 02:07 |
|---|---|---|
| PaoloRotolo | Hi all! | 06:14 |
| PaoloRotolo | Good morning dpm | 06:43 |
| dpm | hey PaoloRotolo, good morning :) | 06:43 |
| coolbhavi | hi dpm good morning! | 06:50 |
| PaoloRotolo | hi coolbhavi | 06:51 |
| coolbhavi | dpm: I am curious to get my hands on voting :) | 06:51 |
| dpm | hi coolbhavi, I'm still working on the final list, it should be ready by today | 06:52 |
| coolbhavi | ok dpm :) hi PaoloRotolo gm!! | 06:53 |
| PaoloRotolo | Good morning dholbach | 06:56 |
| dholbach | good morning | 06:56 |
| dholbach | ciao PaoloRotolo | 06:56 |
| coolbhavi | good morning dholbach :) | 06:57 |
| dholbach | hey coolbhavi | 06:57 |
| PaoloRotolo | I'm fixing the cuttlefish's issues | 07:01 |
| * dholbach has a look at flashgen | 08:17 | |
| dholbach | can somebody please add http://pad.ubuntu.com/PHDShTbnFi to the topic instead of the apps sprint | 08:25 |
| dholbach | flashgen is up for vote! | 08:27 |
| * dholbach has a look at Number Tic-Tac-Toe | 08:31 | |
| * dholbach has a look at Sprite Creator | 08:36 | |
| * dholbach has a look at Cuckoo Alarm | 08:48 | |
| dholbach | salut didrocks | 09:01 |
| dholbach | comment ça va? qu'est-ce qui ce passe en France? | 09:02 |
| didrocks | guten morgen dholbach. Nothing special, it will rain soon so I'll try to hurry to do some exercice outside. Everything is fine otherwise :) | 09:03 |
| didrocks | dholbach: and for you, what's up in Germany? | 09:03 |
| dholbach | app reviews | 09:03 |
| dholbach | app reviews | 09:03 |
| dholbach | app reviews | 09:03 |
| dholbach | app reviews | 09:03 |
| dholbach | app reviews | 09:03 |
| dholbach | and Cuckoo Alarm is up for vote! | 09:08 |
| * dholbach has a look at Monxcleyr Soundboard | 09:13 | |
| dholbach | and Monxcleyr Soundboard is ready for votes | 09:27 |
| ajmitch | dholbach: hi, sorry I've been absent but I'll get time to look over some apps & vote tomorrow night | 10:57 |
| PaoloRotolo | ok, you have a new mail ;) | 11:13 |
| dholbach | great, thanks ajmitch | 11:18 |
| * dholbach has a look at XKCD Browser | 11:53 | |
| * dholbach has a look at minicast | 11:57 | |
| dholbach | hello bhavani_ | 11:59 |
| bhavani_ | hey dholbach :) oops I just realised I hadnt logged out of office | 12:00 |
| dholbach | hum, is the archive slow for anyone else too? | 12:07 |
| bhavani_ | dholbach, my internet speed here always hovers around 50kbps download rate.. so not much difference here | 12:09 |
| dholbach | ok, I'll shut up then :-P | 12:10 |
| dholbach | how's India? :) | 12:10 |
| bhavani_ | dholbach, its cool here and weather is great :) and germany? | 12:10 |
| dholbach | Berlin is not as warm as Bangalore, but still great weather :) | 12:11 |
| bhavani_ | the temperatures here are around 24 25 C and it never goes beyond 33 C on avg through the year | 12:14 |
| bhavani_ | dholbach, when trying to build pictag from source I get: if [ -d debian/pictag/opt/extras.ubuntu.com/pictag/share/glib-2.0/schemas ]; then glib-compile-schemas debian/pictag/opt/extras.ubuntu.com/pictag/share/glib-2.0/schemas; fi | 12:23 |
| bhavani_ | /bin/sh: 1: glib-compile-schemas: not found | 12:23 |
| dholbach | bhavani_, add libglib2.0-bin as a build dependency | 12:23 |
| * dholbach has a look at eater | 12:25 | |
| bhavani_ | dholbach, ok thanks! I just pulled out your latest branch.. Thanks again! | 12:25 |
| bhavani_ | dholbach, builds flawless I am installing and running now | 12:30 |
| dholbach | alright, I'll go for lunch now | 12:36 |
| dholbach | see you in a bit and for more reviews later on :) | 12:36 |
| bhavani_ | dholbach, enjoy +1 on pictag here | 12:39 |
| bhavani_ | :) | 12:39 |
| dholbach | awesome | 12:42 |
| * bhavani_ is downloading cuckoo | 12:46 | |
| bhavani_ | dholbach, the longest package description I have seen in quite some time phew! | 12:49 |
| bhavani_ | btw I found a typo here I guess: Cuckoo utilizes the powerful | 12:50 |
| bhavani_ | GStreamer media framework to play the your media files. | 12:50 |
| bhavani_ | dholbach, cuckoo builds installs fine here +1 except that long description :) | 13:09 |
| stgraber | dholbach: for flashgen, only "issue" I found is that /opt/extras.ubuntu.com/flashgen/flashgen_lib/edict.py shouldn't have a shebang as it's not an executable script (just meant to be imported) | 13:55 |
| stgraber | dholbach: not sure if that's within the scope of arb-lint, but you may want to ask submitters to run pyflakes on their code, it's a bit of a disaster so far ;) | 14:14 |
| dpm | wow, you guys are on a voting roll, good work everyone! | 14:18 |
| stgraber | I'm more complaining about issues than voting really, but yeah, doing some reviews | 14:20 |
| dpm | :) | 14:22 |
| stgraber | right, even ARB for now, that's all the [vote] entries processed | 14:27 |
| stgraber | didrocks: indicator.py, is that quickly generating it? | 14:27 |
| didrocks | stgraber: the default is, whith add quickly indicator | 14:27 |
| didrocks | quickly add indicator | 14:28 |
| stgraber | didrocks: if so, the template should be changed to remove the shebang as that's not an executable script, causes lintian to complain... | 14:28 |
| didrocks | then, anyone can rewrite it :) | 14:28 |
| * didrocks looks at the template | 14:28 | |
| stgraber | AFAICT it's meant to be imported, not executed | 14:28 |
| didrocks | stgraber: indeed, it contains it, please file a bug | 14:28 |
| didrocks | and it only need an impotr | 14:29 |
| didrocks | import* | 14:29 |
| PaoloRotolo | Hi all! | 14:33 |
| bhavani_ | hi PaoloRotolo | 14:33 |
| PaoloRotolo | hi bhavani_ | 14:34 |
| stgraber | didrocks: https://bugs.launchpad.net/quickly/+bug/1023000 | 14:35 |
| didrocks | stgraber: excellent, thanks! Will process with all the Quickly feedback when I get time :) | 14:35 |
| bhavani_ | stgraber, yes running pyflakes on arb apps is a heartbreak to see a page full of warnings | 14:38 |
| dholbach | didrocks, does quickly/p-d-e put a shebang line into indicator.py? | 14:39 |
| dholbach | "/opt/extras.ubuntu.com/cuckoo/cuckoo/indicator.py shouldn't have a | 14:39 |
| dholbach | shebang as it's not an executable script (just meant to be imported)" | 14:39 |
| stgraber | dholbach: see above discussion :) | 14:39 |
| dholbach | ah yes | 14:39 |
| dholbach | awesome | 14:40 |
| stgraber | didrocks: do you currently run any pre-build test in quickly? could you have it run pyflakes? so far most of the submissions are a bit of a disaster in that regards (unsused imports, unused variables, unused functions, ...) | 14:41 |
| didrocks | stgraber: well, do you really care about that? I think the whole goal of this is to make development easier, not to force coding style or particular quality | 14:41 |
| didrocks | there is nothing force on build, we can think of a quickly quality | 14:42 |
| didrocks | which can run that | 14:42 |
| didrocks | but pyflakes doesn't support python3 yet | 14:42 |
| stgraber | didrocks: quickly quality would be good. pyflakes is confused with mixed python2/python3 but on pure python3 it doesn't fail too badly, we're still using it against update-manager/ubiquity/... since our python3 port | 14:43 |
| didrocks | stgraber: it doesn't fail but doesn't particular work either :) | 14:43 |
| didrocks | like all the new syntax is unknown to it | 14:44 |
| didrocks | stgraber: I agree on inner product | 14:44 |
| didrocks | not sure for external, like "forcing" doesn't sound good to me | 14:44 |
| stgraber | pyflakes doesn't enforce much coding style and is good at spotting obvious mistakes (missing imports, using undefined variables, ...) and everything it spots is usually pretty trivial to fix | 14:45 |
| didrocks | right, but I mean, doing that as a prebuilt would mean enforcing :) | 14:45 |
| stgraber | not really | 14:45 |
| stgraber | you could do it like lintian in debuild, run it, print the output but not fail | 14:45 |
| stgraber | that's enough to make the developer feel bad without pissing him off ;) | 14:46 |
| dholbach | it'd be nice if we would distinguish between "SUPER GRAVE PROBLEM" and "some nitpicking" | 14:46 |
| stgraber | in ubiquity we have an exlusion list, listing a list of pyflakes warnings we ignore (we can also do per-file ignore) | 14:49 |
| highvoltage | dholbach: what would you like to distinguish? it sounds like a distinction already. | 14:49 |
| stgraber | currently only used for a single file where we import a module but don't use it, on purpose (as importing that module loads a custom gobject module that's then used later in that function though a gi call) | 14:50 |
| dholbach | things like "unnecessary import of module X" should be visibly marked as "some nitpicking" and not like it was something we'd block a review on | 14:50 |
| * highvoltage catches up with scrollback properly and gets more context | 14:50 | |
| dholbach | or a superfluous shebang line | 14:50 |
| highvoltage | so basically, the policy should have "requirements" and "recommends". | 14:51 |
| dholbach | but sure, the less a lint tool has to complain about, the better | 14:51 |
| stgraber | dholbach: well, the shebang one was spotted by lintian. The extra imports I'd consider as strong recommendation of fixing as they'll lead to unnecessary dependencies | 14:52 |
| * dholbach nods | 14:53 | |
| stgraber | so yeah, I won't -1 an app because the code is full of useless variables/functions/import, but the fact that pyflakes shows me a screen full of output makes it harder for me to review the code and a lot more likely for me to say "can't review in less than 2 hours => kthxbye rejected" | 14:54 |
| dholbach | hum | 14:56 |
| dholbach | now I get this: | 14:56 |
| dholbach | setup.py: cannot connect to X server | 14:56 |
| dholbach | dh_auto_build: python setup.py build --force returned exit code 1 | 14:56 |
| stgraber | sounds like someone is importing Gtk/Gdk/... outside of a class | 14:57 |
| dholbach | ah ok | 15:00 |
| dholbach | pictag has +3! YEEHAW! | 15:00 |
| dholbach | flashgen has +3 too! | 15:01 |
| highvoltage | is the trello list up to date? can I trust it and mark my whole arb submission list as read? | 15:05 |
| stgraber | dholbach: yeah, we have 3 items pending upload | 15:05 |
| dholbach | highvoltage, some might have responded already, so they might have to be moved back | 15:06 |
| highvoltage | dholbach: what template do people use to create these packages? I know there's a bug in dh_make about it, but if we provide some other template then I think it would be nice if we change the dep5 link to the copyright-format-1 link | 15:10 |
| highvoltage | (sorry I guess that borders on nitpicking :p) | 15:10 |
| highvoltage | (but I like having nice things) | 15:10 |
| dholbach | highvoltage, some use differing versions of quickly, others use dh-make I guess, some do it manually | 15:11 |
| dholbach | but the vast majority use quickly | 15:11 |
| dholbach | it'd be great if we would not block on stuff like DEP5 | 15:12 |
| dholbach | getting through all the apps is a lot of work already :) | 15:12 |
| highvoltage | dholbach: yep, not blocking on it | 15:13 |
| stgraber | as long as the link is valid I'm not going to block on it, if the link is invalid, then I'll certainly block | 15:18 |
| stgraber | cuttlefish joins the ready-for-upload list | 15:22 |
| dholbach | can somebody put http://pad.ubuntu.com/PHDShTbnFi into the topic instead of the AppsSprint? | 15:22 |
| dholbach | yeehaw | 15:22 |
| highvoltage | stgraber: heh, except that you didn't :) | 15:22 |
| highvoltage | stgraber: cuttlefish links to http://anonscm.debian.org/viewvc/dep/web/deps/dep5.mdwn?view=co&revision=135 | 15:22 |
| highvoltage | (or more explicitely, http://svn.debian.org/wsvn/dep/web/deps/dep5.mdwn?op=file&rev=135) | 15:22 |
| stgraber | gah... | 15:23 |
| highvoltage | I would rather suggest removing the Format: field completely for this package | 15:23 |
| PaoloRotolo | dholbach, hi :) Uhm, how I can update "trello"? | 15:23 |
| PaoloRotolo | I've read this page http://pad.ubuntu.com/PHDShTbnFi | 15:23 |
| highvoltage | (since I doubt it's a valid dep5/cf1 file to begin with) | 15:23 |
| stgraber | right, they're all wrong... let me drop all my +1 for now, waiting for these to be fixed | 15:23 |
| PaoloRotolo | highvoltage, ok, thanks. I'm removing it. | 15:24 |
| highvoltage | thanks PaoloRotolo, you rock. | 15:25 |
| PaoloRotolo | :D | 15:25 |
| highvoltage | PaoloRotolo: we might have to get some concensus on that, I'm not sure if stgraber and others will specifically want a machine readable copyright file, but I don't think it's essential for ARB apps at the moment | 15:25 |
| highvoltage | PaoloRotolo: I think it's better to not claim that it's machine readable when it isn't, though | 15:26 |
| stgraber | highvoltage: debian/copyright needs to be valid for me to upload it, it's the one file I'm the most picky about. If it's not DEP5, then don't make it look like it's. | 15:26 |
| highvoltage | (and sorry if that sentence was hard to parse, but I think you'll get it :p) | 15:26 |
| highvoltage | stgraber: yes that's basically what I meant | 15:27 |
| PaoloRotolo | highvoltage, ok, you're right :) | 15:27 |
| highvoltage | stgraber: but does it /have/ to be dep5/cf1 for you to approve it? | 15:27 |
| stgraber | now, as I'm comparing with licensecheck, if it's not DEP5, I can't automatically confirm that the package is ok, which is making it more of a pain to review | 15:27 |
| highvoltage | stgraber: that's not currently a hard requirement elsewhere in Ubuntu as far as I'm aware, so it seems a bit harsh | 15:27 |
| stgraber | highvoltage: for me to review the package, considering the amount we have in the queue, yes | 15:27 |
| highvoltage | stgraber: fair enough. | 15:28 |
| stgraber | I won't -1 if it's not a valid dep5, but I won't vote either | 15:28 |
| PaoloRotolo | stgraber, done :) https://code.launchpad.net/~paolorotolo/ubuntu-app-reviews/cuttlefish | 15:33 |
| dholbach | can somebody please update the topic? | 15:34 |
| dholbach | ie http://pad.ubuntu.com/PHDShTbnFi instead of the AppsSprint link | 15:34 |
| PaoloRotolo | dholbach, BTW, how I can update "trello" :)? | 15:34 |
| * dholbach has a look at UberWriter | 15:34 | |
| dholbach | PaoloRotolo, invited you, you should have an email | 15:35 |
| PaoloRotolo | dholbach, yes, thanks a lot, you're awesome :D | 15:36 |
| dholbach | YOU are! :) | 15:36 |
| * highvoltage has insufficient rights to change topic | 15:37 | |
| stgraber | PaoloRotolo: +1ed, thanks | 15:37 |
| PaoloRotolo | stgraber, thanks you :) | 15:37 |
| stgraber | btw, "config-edit -application dpkg-copyright -ui none" is pretty useful to check the validity of debian/copyright | 15:37 |
| dholbach | didrocks, this could all be so easy if quickly didn't have all these bugs :-P | 15:51 |
| dholbach | PaoloRotolo, feel free to go wild on the DEP5 | 15:52 |
| dholbach | it seems the ARB wants these changes | 15:52 |
| PaoloRotolo | dholbach, ok :D | 15:52 |
| didrocks | dholbach: well, most of the bugs are new requirements/extensions without any maintenance on Quickly | 15:54 |
| didrocks | like if this /opt thing wasn't mandated, which Quickly has never been designed for, there would be no bug :p | 15:54 |
| dholbach | didrocks, yeah yeah, try to talk your way out of it :-P | 15:55 |
| * dholbach hugs didrocks | 15:55 | |
| didrocks | tsss :p | 15:56 |
| mhall119 | dholbach: are we fixing arb-lint warnings, or just errors? | 15:56 |
| * didrocks hugs dholbach | 15:56 | |
| mhall119 | also, the .rtupdate file, is that being allowed to live outside of /opt/? | 15:57 |
| dholbach | mhall119, where did you install arb-lint from? | 15:57 |
| dholbach | I pushed it to ppa:ubuntu-app-review-contributors/ppa now with a change for .rtupdate | 15:57 |
| PaoloRotolo | dholbach, the apps on trello are automatically created? | 15:58 |
| dholbach | PaoloRotolo, no, you might have to create them if they're not there | 15:58 |
| mhall119 | dholbach: upgraded, thanks | 16:00 |
| PaoloRotolo | dholbach, ok. So, I'm going to create on trello the new submissions. | 16:00 |
| dholbach | PaoloRotolo, I just did it for the ones I reviewed - so whenever I had a look I moved it to the Trello | 16:01 |
| dholbach | might be easier | 16:01 |
| dholbach | stgraber, debian/copyright was written by an older python-distutils-extra | 16:02 |
| dholbach | it will mean having to fix this in almost ALL submissions | 16:02 |
| mhall119 | dholbach: should Build-Depends be using debhelper >= 8? | 16:02 |
| dholbach | mhall119, yes, it should match debian/compat | 16:03 |
| dholbach | another bug of p-d-e/quickly | 16:03 |
| PaoloRotolo | ok, I must go now. See you later :) | 16:03 |
| dholbach | if there's a cdbs build-dep you can remove it too if it's not used in debian/rules | 16:03 |
| mhall119 | dholbach: yup, arb-lint caught that one | 16:04 |
| dholbach | cool | 16:04 |
| mhall119 | lintian complained about the debhelper version | 16:04 |
| highvoltage | 11:52 < dholbach> it seems the ARB wants these changes | 16:07 |
| highvoltage | dholbach: why wouldn't we? | 16:07 |
| dholbach | because it is caused by an old version of python-distutils-extra | 16:07 |
| dholbach | so we will have to fix this in almost all the submissions | 16:07 |
| dholbach | it creates a lot of work and going through the queue already is a lot of work | 16:07 |
| highvoltage | indeed, it's only stgraber so far that requires it for a +1, and at least he doesn't -1 on it. | 16:08 |
| highvoltage | I just don't want it to lie. | 16:08 |
| highvoltage | (ideally) | 16:08 |
| dholbach | sure | 16:08 |
| dholbach | didrocks, do you know how I can fix this? | 16:10 |
| dholbach | setup.py: cannot connect to X server | 16:10 |
| dholbach | dh_auto_build: python setup.py build --force returned exit code 1 | 16:10 |
| mhall119 | dholbach: ok, I'm reviewing unity-launcher-toggle in MyApps | 16:11 |
| dholbach | cool | 16:11 |
| mhall119 | which button at the bottom do I click to send it for a vote? | 16:11 |
| dholbach | I just wrote an email | 16:11 |
| didrocks | dholbach: hum, you are getting that when? | 16:11 |
| mhall119 | ok, so you didn't leave a review on the entry in MyApps? | 16:12 |
| dholbach | didrocks, trying to build it | 16:12 |
| didrocks | dholbach: inside your session? | 16:12 |
| didrocks | or in a pbuilder? | 16:12 |
| dholbach | mhall119, I did send it via "needs info" and then sent an email to the ARB | 16:12 |
| mhall119 | ok | 16:12 |
| dholbach | theoretically that's a bit confusing but it got the mail out and off the main queue | 16:12 |
| dholbach | didrocks, in my session ,yes | 16:12 |
| didrocks | dholbach: can you pastebin the setup.py? | 16:13 |
| dholbach | sure | 16:13 |
| didrocks | it seems it's trying to do weird thing | 16:13 |
| didrocks | things* | 16:13 |
| dholbach | didrocks, http://paste.ubuntu.com/1084736/ | 16:13 |
| dholbach | mhall119, good work | 16:15 |
| mhall119 | \o/ | 16:15 |
| dholbach | mhall119, I put something like "Thanks a lot for your submission. This is a review for inclusion into the Ubuntu Software Center." at the top of my review to make it clear that this is not coming from a judge | 16:15 |
| mhall119 | only took me, what 30 minutes? | 16:16 |
| dholbach | but I guess it's clear enough already | 16:16 |
| * dholbach hugs mhall119 | 16:16 | |
| mhall119 | dholbach: ah, good idea, I'll include that from now on | 16:16 |
| dholbach | didrocks, I can put up the whole branch if you want | 16:19 |
| didrocks | dholbach: sorry, got into some unity things | 16:19 |
| didrocks | looking | 16:19 |
| dholbach | lp:~dholbach/ubuntu-app-reviews/monxcleyr-soundboard | 16:20 |
| didrocks | nothing special at first sight | 16:20 |
| didrocks | looking at the branch | 16:20 |
| dholbach | mhall119, oh, and I recently started CCing the app author on the vote mail as well | 16:20 |
| dholbach | let me document that in the pad a bit more clearly | 16:21 |
| didrocks | dholbach: no issue here with bzr bd | 16:21 |
| dholbach | this has been a learning experience :) | 16:21 |
| dholbach | didrocks, hum | 16:21 |
| dholbach | weird | 16:21 |
| dholbach | I run 'bzr bd' and get | 16:21 |
| dholbach | setup.py: cannot connect to X server | 16:21 |
| dholbach | dh_auto_build: python setup.py build --force returned exit code 1 | 16:21 |
| didrocks | dholbach: my computer is better than yours :p | 16:22 |
| dholbach | obviously | 16:22 |
| didrocks | hum, what can make that happens? | 16:22 |
| dholbach | let me try in pbuilder | 16:22 |
| didrocks | even emptying the DISPLAY variable | 16:22 |
| didrocks | works fine | 16:22 |
| didrocks | not sure why it tries to connect something to X for you | 16:22 |
| didrocks | debian/rules doesn't do anything special | 16:23 |
| didrocks | zomg, all this /opt stuff is really aweful when reading it | 16:23 |
| didrocks | dholbach: my only bet is that something is running the tests for you under fakeroot | 16:24 |
| highvoltage | dholbach: do you know if hivemind and cooking lens still require voting? | 16:24 |
| dholbach | didrocks, so autoinstall runs "python setup.py build --force ", right? | 16:25 |
| dholbach | didrocks, if you run it manually does it start the app for you? | 16:25 |
| dholbach | highvoltage, IIRC cooking lens requires a fix to get all the translations to /opt | 16:25 |
| dholbach | I would need to look into my mails to see where things stand there | 16:26 |
| dholbach | didrocks, sorry, when I said "autoinstall" I meant dh_auto_build | 16:28 |
| dholbach | in pbuilder it builds fine | 16:28 |
| * highvoltage has arb email folder down from 254 emails to 8 that needs attention (that feels better) | 16:28 | |
| mhall119 | dholbach: I'm not seeing an ubuntu-app-reviews branch for https://myapps.developer.ubuntu.com/dev/apps/1106/ | 16:32 |
| didrocks | dholbach: no, it doesn't run the app for me :/ | 16:32 |
| dholbach | mhall119, let me retry it | 16:32 |
| didrocks | dholbach: I'm wondering if you have a build-dep triggering a behavior where the tests are running | 16:32 |
| dholbach | mhall119, Suggested package name "C:\fakepath\centric" :-( | 16:33 |
| dholbach | let me go and fix it | 16:33 |
| dholbach | GRRRRRRRRRRRRRRRRRRR | 16:33 |
| mhall119 | dholbach: others that had it got put into branches called cfakepath<name> | 16:34 |
| mhall119 | but not centric | 16:34 |
| dholbach | mhall119, lp:~ubuntu-app-review-contributors/ubuntu-app-reviews/cfakepathcentric | 16:35 |
| dholbach | didrocks, HA! | 16:35 |
| mhall119 | thanks dholbach | 16:35 |
| dholbach | didrocks, try installing all the dependencies of the package, then test-build it again :-) | 16:35 |
| dholbach | mhall119, work around was: find upstream branch, add it as a comment on the apps' feedback page, in apps-brancher run ./retry http://<app-link> | 16:36 |
| mhall119 | dholbach: is libglib2.0-bin required for all quickly-derived apps? | 16:37 |
| dholbach | mhall119, no, not for all, only the ones which do something with glib-compile-schemas | 16:38 |
| dholbach | might be worth having arb-lint check it | 16:38 |
| dholbach | I'll file a bug and see if I get to it today | 16:38 |
| dholbach | https://bugs.launchpad.net/arb-lint/+bug/1023052 | 16:39 |
| mhall119 | dholbach: if it's not packaged for /opt/ what should I do with it? | 16:40 |
| dholbach | mhall119, I usually fix all the other bits and tell the app author to resubmit it using 'quickly submitubuntu' | 16:40 |
| mhall119 | nvm, I see it at the bottom of the etherpad, tanks | 16:40 |
| mhall119 | will running submitubuntu over-write everything I just fixed? | 16:41 |
| dholbach | it might overwrite some of it, but I guess they could take some of the bits from your branch then | 16:43 |
| dholbach | hm | 16:43 |
| * dholbach has a look at Convertik | 16:58 | |
| dholbach | LOL!!!! | 16:59 |
| dholbach | dpkg-checkbuilddeps: Unmet build dependencies: some-other-package | 16:59 |
| dholbach | very funny | 16:59 |
| dholbach | haha | 16:59 |
| mhall119 | dholbach: E: These files are outside opt/extras.ubuntu.com/download-monitor and shouldn't be: - etc/apport/crashdb.conf.d/download-monitor-crashdb.conf | 17:00 |
| dholbach | ah yes, hang on | 17:00 |
| dholbach | I fixed this in some app today - let me see if I can find it somewhere | 17:00 |
| dholbach | mhall119, http://bazaar.launchpad.net/~dholbach/ubuntu-app-reviews/cuckoo/revision/59 | 17:02 |
| dholbach | I'll update it in arb-lint | 17:02 |
| dholbach | I solved it better in cuckoo than in the other example | 17:03 |
| dholbach | ok, Convertik is a no-go | 17:08 |
| mhall119 | dholbach: that did it,thanks | 17:08 |
| * dholbach has a look at Pictoric | 17:09 | |
| dholbach | a shame, it's not ready yet | 17:15 |
| dholbach | ok, tickit is still not ready | 17:24 |
| * dholbach has a look at WikiTron | 17:26 | |
| dholbach | not ready either :/ | 17:29 |
| dholbach | LOL | 17:31 |
| dholbach | I tried out one of those desktop background changer apps | 17:31 |
| dholbach | and it set a picture of when I got a ticket for overspeeding | 17:32 |
| dholbach | hahahaha | 17:32 |
| dholbach | what a funny surprise :) | 17:32 |
| mhall119 | lol | 17:33 |
| dholbach | I totally forgot that it was still running and hadn't looked at the desktop for a while :) | 17:33 |
| * dholbach has a look at Ivolution | 17:34 | |
| * dholbach has a look at rapit-get | 17:39 | |
| dholbach | not ready either | 17:44 |
| * dholbach has a look at Ubuntu Application Manager | 17:45 | |
| mhall119 | highvoltage: thanks for the quick votes :) | 17:48 |
| * mhall119 breaks for lunch | 17:49 | |
| dholbach | mhall119, enjoy | 17:49 |
| dholbach | alright my friends - I call it a day - see you all tomorrow! | 17:59 |
| dholbach | happy reviewing! | 17:59 |
| highvoltage | mhall119: I'm at debconf without purpose or direction for today so I can deal well with incomming stuff :) | 18:19 |
| mhall119 | highvoltage: nice, can you be at debconf every day? | 18:23 |
| highvoltage | mhall119: lol | 18:23 |
| mhall119 | highvoltage: are you adding your -1 feedback to the MyApps entry? | 18:25 |
| mhall119 | also, doesn't http://bazaar.launchpad.net/~mhall119/ubuntu-app-reviews/gr8s/view/head:/debian/copyright cover the .pot file, even if it has a generic copyright header? | 18:26 |
| highvoltage | mhall119: indeed. I still don't like the idea of vague/incomplete/confusing/incorrect copyright headers. If it's an absolute pain to fix then I guess we could let it slide. | 18:32 |
| highvoltage | mhall119: (back in a few moments) | 18:33 |
| mhall119 | it's not an absolute pain to fix it once, but with the number of submissions we have to process little things will add up fast | 18:34 |
| asomething | Hi all. Jumping in and trying to do some reviews here. Should I assume the extras has the same policy as the official archives re:embedded libraries? myagenda seems to have an embedded copy of Sqlite... | 18:39 |
| asomething | and can I tell the author that he can still push a fix for that even though it's past the deadline? | 18:40 |
| mhall119 | asomething: as long as the change (a) doesn't change the functionality of the app and (b) is necessary to meed the packaging requirements, we will allow the change after the deadline | 18:41 |
| mhall119 | but we have to make sure it doesn't give the author any unfair advantage over other contestants | 18:41 |
| mhall119 | highvoltage: back yet? | 19:21 |
| asomething | was there ever a decision on rtupdate files? | 19:23 |
| mhall119 | asomething: they are allowed, IIUC | 19:23 |
| asomething | mhall119, thanks. makes sense to me, but arb-lint still complains | 19:24 |
| mhall119 | asomething: apt-get update and apt-get install arb-lint | 19:25 |
| mhall119 | the latest version doesn't complain anymore | 19:26 |
| asomething | cool | 19:26 |
| highvoltage | mhall119: am now, so yes, it didn't actually occur to me at the time to comment on the myapps pages, I'll add it as feedback (and not an actual -1 on there) | 19:43 |
| mhall119 | highvoltage: how do you specify public domain in debian/copyright? | 19:57 |
| mhall119 | pyengish has some files GPLv3 and some public domain | 19:59 |
| mhall119 | but debian/copyright says all are GPLv3 | 19:59 |
| mhall119 | highvoltage: also, can you take a look at https://code.launchpad.net/~ubuntu-app-review-contributors/ubuntu-app-reviews/pymi ? They're doing something odd with their python files, installing them into /opt/extras.ubuntu.com/pymi/lib/python2.7/dist-packages/ | 20:03 |
| mhall119 | but I don't know if that's an easy change to a build file or not | 20:03 |
| asomething | mhall119, from http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ "When the License field in a paragraph has the short name public-domain, the remaining lines of the field must explain exactly what exemption the corresponding files for that paragraph have from default copyright restrictions." I usually take that to mean a verbatim copy of the text declaring something to be public domain | 20:04 |
| highvoltage | mhall119: from what I unders.... (ah asomething just pasted the exact same link and paragraph I wanted to :) ) | 20:05 |
| asomething | ;-) | 20:05 |
| mhall119 | heh | 20:05 |
| mhall119 | so should I tell the developer to fix the file according to the debian spec, or just fix it myself? | 20:06 |
| mhall119 | the header used is just: | 20:06 |
| mhall119 | ### BEGIN LICENSE | 20:06 |
| mhall119 | # This file is in the public domain | 20:06 |
| mhall119 | ### END LICENSE | 20:06 |
| mhall119 | for everything but ./pyenglish/*.py | 20:06 |
| highvoltage | mhall119: you can fix it yourself | 20:08 |
| highvoltage | mhall119: I just suggest telling them that you've done so | 20:09 |
| mhall119 | highvoltage: is http://paste.ubuntu.com/1085098/ the correct format if the files are http://paste.ubuntu.com/1085072/ ? | 20:12 |
| asomething | mhall119, looks right to me. I usually put the full GPL header though | 20:14 |
| mhall119 | asomething: that much was already there, from quickly | 20:15 |
| asomething | hmm... how about apport files outside of opt/? I've got one with etc/apport/crashdb.conf.d/cookety-app-crashdb.conf | 20:15 |
| mhall119 | asomething: dholbach had a fix for that, let me find it | 20:17 |
| mhall119 | dang it, bazaar.lp.net is throwing 503's | 20:17 |
| mhall119 | asomething: http://paste.ubuntu.com/1085116/ was the fix for the crashdb stuff I made to winconn | 20:23 |
| asomething | mhall119, thanks! | 20:23 |
| mhall119 | you should be able to copy/paste it then s/winconn/<your_app>/ | 20:23 |
| mhall119 | highvoltage: do we need to fix depends-on-essential-package-without-using-version depends | 20:40 |
| highvoltage | mhall119: which package? | 20:42 |
| mhall119 | sbk is the app, it depends on stuff like bash, tar, etc | 20:42 |
| mhall119 | highvoltage: also I don't know what needlessly-depends-on-awk means | 20:43 |
| mhall119 | if it calls awk, why shouldn't it depend on it? | 20:44 |
| highvoltage | mhall119: I would think so, but I doubt something like that would be a problem for an extras app | 20:46 |
| mhall119 | switching it to depend on gawk makes Lintian happy | 20:47 |
| george_e | I heard that some assistance is needed for reviewing applications. | 23:15 |
| george_e | Since I have an application currently pending review, I also tried running 'arb-lint' on my application and received a warning and an error. | 23:21 |
| george_e | http://dpaste.com/769241/ | 23:21 |
| george_e | The error (regarding files not in /opt) really can't be avoided... because of the way the application integrates into the operating system (Nautilus in particular), it is a requirement that those files be in those locations. | 23:22 |
| george_e | (Especially the manpage.) | 23:22 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!