| gary_poster | benji, some small conflicts in https://code.launchpad.net/~benji/lpsetup/bug-1023519-store-version-information/+merge/114736 | 11:58 |
|---|---|---|
| benji | gary_poster: thanks; looking | 12:00 |
| gary_poster | welcome | 12:01 |
| benji | gary_poster: fixed and pushed | 12:03 |
| bac | hi gary_poster | 12:03 |
| bac | i re-ran lxc-install last night and it failed on make schema. looks like it is trying to do that in the wrong directory | 12:04 |
| benji | you know, Launchpad really should email you when an MP has a conflict | 12:06 |
| gary_poster | bac ok | 12:12 |
| gary_poster | bac benji frankban http://tinyurl.com/yellowsquad | 12:12 |
| gary_poster | http://codesinger.blogspot.com/2012/07/yellow-squad-weekly-topics-july-6.html | 13:02 |
| bac | benji: done | 14:44 |
| benji | bac: thanks | 14:45 |
| benji | bac: I responded tou your (excellet) review https://code.launchpad.net/~benji/lpsetup/bug-1023519-store-version-information/+merge/114736/comments/246891 | 15:15 |
| benji | if all that sounds good I will go ahead and mark the MP as approved | 15:16 |
| bac | benji: sounds good. thanks. | 15:18 |
| bac | gary_poster: i got my branch to work and have created a new branch and MP: https://code.launchpad.net/~bac/lpsetup/fix-inithost-install-lxc-deux/+merge/114896 | 16:03 |
| gary_poster | bac, reviewing | 16:04 |
| gary_poster | bac fully approved (vote and status) | 16:07 |
| bac | thanks gary_poster | 16:14 |
| * bac -> BLT | 16:14 | |
| frankban | gary_poster: unfortunately I can not create a fake repository under /tmp/, because then init-repo complains about repository not being inside my home directory. | 16:23 |
| frankban | gary_poster: I can think about 2 solutions: 1) create the repository inside a temporary dir in the home or 2) this is an integration test that must be run using juju | 16:24 |
| gary_poster | frankban, as to #2, we want it part of the integration juju tests anyway (also, I guess? I thought you were working on an integration test) | 16:25 |
| gary_poster | frankban, but as to 1, yeah, why not? | 16:25 |
| gary_poster | frankban, you can pass dir to tempfile functions, looks like | 16:26 |
| frankban | gary_poster: yes | 16:26 |
| frankban | gary_poster: what I'd like to do is: | 16:26 |
| frankban | 1. create a fake source repository using a template (as we discussed) under /tmp/ | 16:26 |
| frankban | 2. test init-repo passing --source [fake source] with and without --checkout | 16:27 |
| frankban | 3. check the command does not raise errors | 16:27 |
| frankban | 4. check for the fake file to be correctly present in the checkout (or in the branch if --no-checkout is passed) | 16:28 |
| frankban | 5. destroy the source, destroy the target, done. | 16:28 |
| gary_poster | frankban, sounds great, except make step 1 work with source in ~/[tempdir] (or checkout/[tempdir]?), right? | 16:29 |
| frankban | (the fake file is just one test file added and committed to the source | 16:29 |
| gary_poster | frankban, please as I said on call, eventually I want fake repo to have more contents | 16:30 |
| frankban | gary_poster: the source file can be in /tmp/, it can be everywhere, the repository to create must be under ~ | 16:30 |
| gary_poster | frankban, oh, right. | 16:30 |
| gary_poster | my sentence "please as I said on call," was edited badly. just meant "as I said on call" | 16:31 |
| frankban | gary_poster: yes, we can reuse the fake source for integration tests in the future | 16:31 |
| gary_poster | great | 16:31 |
| frankban | gary_poster: so, for this unit tests, i am going to create a temp repository in the home, right? | 16:32 |
| gary_poster | frankban, right. To be ore specific, you are going to use tempdir to create a tempdir in ~; then you will make repo in ~/[tempdir], right? | 16:33 |
| gary_poster | s/ore/more/ | 16:33 |
| frankban | gary_poster: yes, repository will be something like tempfile.mktemp(dir='~') | 16:35 |
| gary_poster | frankban, perfect | 16:36 |
| frankban | gary_poster: for the lpsetup package, it's near my EOD and I will try to add these changes to my branch, so... | 16:37 |
| * gary_poster listens | 16:38 | |
| frankban | gary_poster: I don't think I can take care of that | 16:41 |
| gary_poster | frankban, sure, of course! would you like to pass it off to someone else, or save it for Monday, or pass it off to someone else, and in case they don't finish it you'll do it on Monday? :-) | 16:42 |
| frankban | gary_poster: I meant I can not take care of building a new lpsetup package, I can do that on Monday, or I pass it off if you need the new package today | 16:45 |
| gary_poster | frankban, oh duh, sorry | 16:46 |
| gary_poster | frankban, cool, thanks for letting me know | 16:46 |
| gary_poster | I didn't read carefully enough and missed the transition | 16:46 |
| frankban | gary_poster: cool, np | 17:09 |
| bac | gary_poster, benji: regarding versioning, it seems we need to keep track of 1) contents of deleted files, 2) names of modified files, and 3) names of added files on a per-version basis. when the version changes we can 1) restore the deleted files, 2) unmodify the ones we changed if we put fences around beginning and end of our changes, 3) remove the added files. | 19:48 |
| bac | we cannot restore modified files to the original since the dev or system could've made other changes in the meantime. perhaps this is obvious and you've already noted it. | 19:49 |
| gary_poster | bac, agreed. benji, we had a list of four items on a google doc. do you still have that hanging around? | 19:49 |
| gary_poster | four things that we thought we ought to save | 19:50 |
| gary_poster | probably can find | 19:50 |
| benji | gary_poster: yep, one sec | 19:50 |
| benji | bac, they are in this bug: https://bugs.launchpad.net/lpsetup/+bug/1023519 | 19:50 |
| _mup_ | Bug #1023519: Store version information <lpsetup:In Progress by benji> < https://launchpad.net/bugs/1023519 > | 19:51 |
| bac | i read that bug this morning but it doesn't state explicitly what i was thinking above | 19:51 |
| gary_poster | bac, true. what you wrote has thought through some of the points more thoroughly. | 19:53 |
| gary_poster | bac, perhaps it would be worthwhile to add that as a comment to the bug, or to update the description. Beyond that... | 19:53 |
| bac | sure | 19:53 |
| gary_poster | bac, I was trying to think if I could see a card that ought to be made from that, but I don't see one--unless we don't add the footers yet? | 19:55 |
| bac | we do not add footers | 19:55 |
| gary_poster | if we don't add the footer "fence" that would be worth a card | 19:55 |
| gary_poster | +1 for card then, bac. Thank you. | 19:56 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!