[01:19] mhall119: Sorry... long work day. I'm finally free for rest of the evening. [02:12] Hmm... F5 Notifier's .desktop file doesn't seem to end up in the right place... [02:18] mhall119: This isn't good... I've got everything ready for F5 Notifier except... the .desktop doesn't end up in the DEB. The .desktop.in file exists and the setup.py file hasn't been modified... [02:19] I really have no idea what's going on here. [02:19] Ah... wait a minute... [02:20] "copying build/share/applications/f5-notifier.desktop -> /home/nathan/Documents/repositories/f5-notifier/debian/f5-notifier/opt/extras.ubuntu.com/f5-notifier/share/applications" [02:20] Why is the .desktop file going to /opt??? [02:21] * george_e sits back to think about this for a minute... [02:38] Somewhere along the line, the 'extra-' prefix isn't getting added to the .desktop filename. [02:38] * george_e does some further investigation... [02:42] AHA! It appears that the rules file somehow had the wrong filename. [02:43] Yup, that fixes it up. [04:14] george_e: f5 notifier vote was emailed to the ubuntu-app-devel list? [04:14] Whaaaat? [04:14] * george_e slaps forehead. [04:14] No wonder it wasn't showing up in the list. [04:15] ajmitch: There, I sent it to the correct list. [04:16] Do I need to send another email to the app-devel list explaining the error? [04:16] ...or will everyone just figure out what happened? [04:16] I think we can figure it out [04:16] I was just surprised to see it in a different mail folder :) [04:20] Sorry about that. [04:20] That's what I get for using autocomplete in Gmail. [04:26] ajmitch: Could you replace the etherpad link to https://wiki.ubuntu.com/AppReviewBoard/Review/Showdown [04:32] * vibhav is having a look at fuelexpensetracker === ajmitch changed the topic of #ubuntu-arb to: Ubuntu Application Review Board | https://wiki.ubuntu.com/AppReviewBoard | https://wiki.ubuntu.com/AppReviewBoard/Review/Showdown | Feel free to ask, we're not always staring at our screens so please hang around for an answer [04:45] thanks [06:59] Good morning! [07:02] good morning [07:02] Good morning dholbach :) [07:03] ciao PaoloRotolo [07:03] And as for me... good night everyone :) [07:03] seems we got a lot of helpers yesterday :) [07:03] hey george_e [07:04] how are you all doing? :) [07:04] dholbach: Yes? [07:04] george_e, good night then :) [07:04] PaoloRotolo, come stai? [07:04] dholbach, tutto bene, grazie :P [07:04] cosa fai? [07:05] I think there were lots of submissions to myapps from Italians [07:06] dholbach, right :D [07:09] dholbach, ehm, what we should do with this: https://myapps.developer.ubuntu.com/dev/apps/1249/? [07:10] It is without title, maybe a terminal-only app, don't have a PPA [07:10] doesn't* [07:10] did you have a look at https://myapps.developer.ubuntu.com/site_media/arb/packages/2012/07/appshowdownfiles_1.tar? [07:10] ah, terminal-only? [07:11] dholbach, the server app is terminal only [07:11] and the client? [07:11] From the description "a server application run from the commandline and a client application." [07:11] I'm trying the client [07:12] dholbach, btw, it hasn't a PPA [07:12] We have only 2 .deb in the .tar archive [07:12] OH OK [07:13] you could reply with https://wiki.ubuntu.com/AppReviewBoard/Review/Responses#Submitted_binary_package [07:14] oh, it says this too: This is the result of my failed attempt at using quickly to make a ppa for the App Showdown... [07:14] it's an unfortunate app XD [07:14] good morning all [07:14] yes [07:15] hi dpm [07:15] Good morning dpm! [07:16] buon giourno PaoloRotolo :) [07:16] *giorno [07:17] dpm, ahahah, thanks :D [07:26] ajmitch, around to publish a few more apps? ;-) [07:35] hi popey [07:35] hi [07:37] hey popey [07:43] dholbach, can I reject this: https://myapps.developer.ubuntu.com/dev/apps/1106/ ? [07:43] It is the old version of https://myapps.developer.ubuntu.com/dev/apps/1317/ [07:43] dpm, ^? [07:44] looking... [07:44] He says "now I will resubmit my application as the email requested." [07:46] PaoloRotolo, let me e-mail him, CC'ing you asking him to withdraw one of the submissions. If he doesn't reply, then we can reject it. [07:49] dpm, ok [08:00] PaoloRotolo, done [08:01] thanks for the heads up! [08:01] dpm, you're welcome [08:08] dholbach, uhm, I can't find the OmgUbuntu launcher here: https://code.launchpad.net/ubuntu-app-reviews/+branches [08:08] please, can you help me? [08:08] PaoloRotolo, can you give me the app url in myapps? [08:08] dholbach, of course: https://myapps.developer.ubuntu.com/dev/apps/1314/ [08:09] grazie [08:09] dholbach, prego :) [08:10] PaoloRotolo, lp:~ubuntu-app-review-contributors/ubuntu-app-reviews/omgubuntu-unity [08:10] dholbach, oh, thanks! [08:11] certo :) [08:27] * dholbach has a look at postman [08:30] dholbach, sorry again. If one application is a Launcher for Unity, the app files must be installed in a different directory than /opt [08:30] like my "Ubuntu-it Launcher" or "OMGubuntu launcher" [08:33] hum? which file? [08:38] dholbach, http://bazaar.launchpad.net/~uitlauncher-dev/uitlauncher/packaging/view/head:/install [08:38] ah yes, the icons should be in /opt too [08:38] but the .desktop file should be /usr/share/applications/extras-somethinglauncherblabla.desktop [08:38] dholbach, ok, icons in /opt and .desktop in /usr/share, right? [08:39] yep [08:40] dholbach, ok, thanks [08:40] is anyone of you still on precise? if so, could you test and see if lp:~dholbach/ubuntu-app-reviews/postman works for you? [08:40] maybe in a vm [08:41] for me it seems to have a memory leak and is unhappy with compiz [08:41] but maybe that's a quantal issue [08:41] dholbach, I'm on Precise. I'm downloading it [08:42] be careful - I had to Ctrl-Alt-F1 and kill the postman process from there [08:43] ok [08:50] dholbach, all good from here [08:50] ok [08:50] so it works fine for you? [08:51] dholbach, http://ubuntuone.com/2PzKfTYsG3mIexKmrNlMVC [08:51] yes [08:51] perfect, thanks [08:51] dholbach, you're welcome :) [08:51] I just submitted a few other questions, once they're resolved we can get it up for vote [08:51] grazie mille, amico mio :) [08:55] dholbach, di nulla :) [09:19] Ok, omgubuntu just reviewed lp:~paolorotolo/ubuntu-app-reviews/omgubuntu-unity [09:19] dholbach, a couple of people asked me yesterday about this, and I see there's someone else on the ARB list asking the same too. So I created an Ask Ubuntu FAQ-like question - does the answer look sensible to you? http://askubuntu.com/q/163096/9781 [09:20] sounds good, but maybe didrocks or mterry can confirm? [09:21] I'm not too familiar with what quickly does exactly [09:21] dpm, it's good :) [09:21] brb [09:22] dholbach, I've left Quickly out of the answer, so that it works for all apps, given that quickly modifies the control and rules files on each packaging command run [09:22] thanks for the review PaoloRotolo and dholbach [09:28] dpm, you're welcome [09:30] I see something about quickly :) I want to ask if someone here is in a contact with it. Developing my package I found that quickly is broken in some points and posted a couple of merge requests, however I see the quickly merge requests are not often reviewed. [09:33] trkv, thanks for your contributions. didrocks and mterry are the contact points for Quickly as main developers, but they are not online now. You might want to ping them later on or join the dedicated #quickly IRC channel, which is where most people interested in contributing to Quickly hang out [09:33] hi fader_, you're not online yet, but nice to see your here! :-) [09:33] ok, will ping them there [09:34] cool [09:34] trkv, actually, didrocks is online there, so you might want to ping him [09:49] nice [09:53] Actually I don't want to disturb or hurry ARB reviewers, but I'm a bit nervous about my package haven't even appeared on trello yet) When will be the estimated end of reviewing process? [09:55] trkv, Hi! [09:56] trkv, can you give me the app url in myapps? [09:56] https://myapps.developer.ubuntu.com/dev/apps/1177/ [09:57] stgraber, wendar, highvoltage, ajmitch: any opinion on the last comment in https://myapps.developer.ubuntu.com/dev/apps/1118/feedback/? [10:02] trkv, https://trello.com/card/parcel-tracker/4fee2215cee295013c0862ba/186 :) [10:05] PaoloRotolo: thanks, will wait :) [10:05] trkv, you're welcome [10:15] dholbach, so that's where you are hidding? ;-) [10:15] seb128, hey seb :-) [10:15] https://wiki.ubuntu.com/AppReviewBoard/Review/Showdown is what we're doing here :) [10:15] hey Daniel [10:15] * dholbach hugs seb128 [10:15] * seb128 hugs dholbach [10:15] comment ça va mon ami? [10:16] qu'est-ce qui se passe en France? [10:16] dholbach, ca va bien, il pleut en France ! [10:16] oui, c'est la même chose ici [10:18] dholbach, is there a list or something for coordination? [10:18] like "stuff people are looking at", "ones available for review" [10:18] there's https://trello.com/board/ubuntu-arb-submissions/4fee2215cee295013c0862ba but I think a lot of the unreviewed apps are not on there, but only on https://myapps.developer.ubuntu.com/dev/arb/ [10:19] I can go through the list and give you a few which I know are not reviewed yet [10:19] seb128: run away, dholbach will ask you to review packages soon! :) [10:19] lol [10:19] https://myapps.developer.ubuntu.com/dev/apps/1289/ for example [10:19] or https://myapps.developer.ubuntu.com/dev/apps/1259/ [10:20] or https://myapps.developer.ubuntu.com/dev/apps/1260/ [10:20] lol [10:20] dholbach, ok, I can have a look to "nudge" [10:20] there should be branches available at https://code.launchpad.net/ubuntu-app-reviews/+branches - if there are none, let me know [10:20] seb128, https://wiki.ubuntu.com/AppReviewBoard/Review/Showdown explains how to install 'arb-lint' - a small tool which checks for the most common problems [10:20] dholbach, ok [10:20] * dholbach has another look at roundball [10:21] dholbach, how do I tell people I'm looking at "nudge" so other don't start on it? [10:21] yeah, just mention it in the channel [10:21] :) [10:30] wohoo, we've got seb128 as guest reviewer! [10:30] awesome [10:30] seb128, Welcome! [10:30] dpm, if seb128 does reviews like he does GNOME updates or reviews bugs, we should be done in half an hour [10:31] * dholbach goes to put some beer into the fridge [10:31] dholbach, yeah, I think we should start thinking of closing shop after lunch now that he's here [10:31] lol [10:31] <3 [10:31] * dpm hugs seb128 [10:31] * seb128 hugs dpm dholbach [10:31] PaoloRotolo, thanks ;-) [10:36] hello [10:36] I received message from ARB: The icons in /usr/share/icons should be installed to /opt/extras.ubuntu.com/mirrorcam too [10:36] hey robotex_ [10:36] yes [10:37] that's correct [10:37] In debial/install I have following lines: icons/* /usr/share/pixmaps/ icons/* /opt/extras.ubuntu.com/mirrorcam/icons/ So, I must change it to: icons/* /usr/share/icons/ icons/* /opt/extras.ubuntu.com/mirrorcam/ am I right? [10:37] yes, and you might have to change some bits in your code as well - you can always just try to run 'debuild' and run 'less' on the resulting .deb file in '..' [10:37] Icons must be in /usr/share/icons and /opt/extras/ubuntu.com/ ? [10:38] no [10:38] dholbach, dpkg -c .deb is easier than less [10:38] just one place, so for example /opt/extras.ubuntu.com/mirrorcam/share/icons [10:38] in /opt/extras/ubuntu.com//icons? [10:39] or dpkg -c .deb - as seb128 says [10:39] * dholbach has a look at menulibre [10:39] and then I must to run "debuild -S" and update PPA? [10:39] dholbach, btw I can't find a vcs for nudge, https://code.launchpad.net/~ubuntu-app-review-contributors/ubuntu-app-reviews/nudge doesn't work and it doesn't seem to be in https://code.launchpad.net/ubuntu-app-reviews/+branches [10:40] robotex_, sounds good, yes [10:40] seb128, one sec [10:40] I'm ubuntu showdown participilant [10:40] Ok, I will try [10:41] seb128, try lp:~ubuntu-app-review-contributors/ubuntu-app-reviews/nudge again [10:41] dholbach, works [10:41] sweet [10:41] dholbach, what did I do wrong? [10:41] dholbach, danke [10:41] seb128, nothing - I ran the apps-brancher on it again :) [10:41] dholbach, ok [10:43] can you help me to remember command to update package in PPA? [10:43] robotex_, debuild -S -sa; cd ..; dput mirrorcam_*.changes [10:44] for my ppa that's ppa:dholbach/ppa [10:44] ok [10:44] thanks [10:45] robotex_, you might find this useful: http://askubuntu.com/q/163096/9781 (it's essentially what dholbach is explaining you) [10:45] And when will I do this, how can I notice you to review changes? [10:46] adding some feedback comment in myapps as explained above, or pinging someone here, or sending an e-mail to the App Review Board mailing list [10:46] and menulibre is ready for vote :-D [10:46] \o/ [10:48] dholbach, is that normal that nudge is not listed on https://trello.com/board/ubuntu-arb-submissions/4fee2215cee295013c0862ba "Needs Review"? [10:50] seb128, yes, new apps are not on there - I'm happy to put it on there for you - or if log into to Trello, I can also give you access - as you like it [10:50] dholbach, does it need to be there? I'm happy to skip that if that's not required, I was just trying to follow the wiki [10:51] yeah, just leave it - I'm happy to place it wherever you decide it should go [10:51] the standard route for everything is: [10:51] - check out app [10:51] - if it does not install to /opt reply back tell them to use 'quickly submitubuntu' or if they don't use quickly fix it manually [10:51] - if there's just a few small problems: provide a branch with updates [10:52] - put up for vote if there's no pressing issues [10:52] https://lists.ubuntu.com/archives/app-review-board/2012-July/001459.html is an example of a 'vote' mail [10:52] dholbach, thanks [10:53] sometimes they have license issues or the app is just too broken to be submitted [10:53] but that's understandable - the app authors had 3 weeks time [10:53] which is not too much :) [10:53] but a lot of the apps fill a nice niche and work well [10:53] dholbach, yeah, the one I look at is similar to your example, small packaging tweaks needed [10:53] let me fix and push and email [10:53] you're a hero [10:53] do I need to subscribe to that list to send a vote email? [10:54] no, I think dpm can moderate it through [10:54] or wendar and stgraber can [10:54] ok [10:54] dholbach, I can't moderate it, I think stgraber is the moderator [10:54] * dholbach nods [10:54] * dholbach has a look at MapRoj [10:55] dholbach, you can leave MapRoj for later, it did not qualify for the contest [10:55] dholbach, [10:55] - Format-Specification: http://svn.debian.org/wsvn/dep/web/deps/dep5.mdwn?op=file&rev=135 [10:55] dpm, ok [10:55] + http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ [10:55] do we have a tool generating those wrong urls? [10:55] seb128, http://bazaar.launchpad.net/~dholbach/ubuntu-app-reviews/harvestwidget/view/head:/debian/copyright you can use [10:55] in which case is somebody working on fixing it? [10:55] seb128, it was an old version of quickly or p-d-e [10:56] ok [10:56] I think it's fixed already, but not in -updates yet [10:56] or something [10:56] ok [10:56] danke [10:56] I'm good I think [10:56] yeah, they are in -proposed the fixes [10:56] * dpm yoda talks [10:56] * dholbach a look at TubeReply has [10:57] :) [11:01] unfortunately not ready yet [11:04] dpm, stgraber: can you please reply to https://myapps.developer.ubuntu.com/dev/apps/1222/feedback/? [11:04] looking... [11:04] * dholbach has a look at ptnotes [11:09] comment added on ^ [11:11] thanks [11:11] lunch time [11:49] dholbach, can I do https://myapps.developer.ubuntu.com/dev/apps/1260/ (trading cards)? [11:49] if nobody say no I'm starting on it :p [11:49] sure [11:50] dholbach, and you should take longer than half an hour to eat ;-) [11:51] dholbach, btw I did sent a vote email and pushed a branch with small fixes for "nudge" [11:54] dholbach, btw where do you get your list of unclaimed sources? if I want to look and pick some extra ones? [12:07] hi all good evening! [12:51] seb128, https://myapps.developer.ubuntu.com/dev/arb/ [12:52] and from there I just picked some where it said that they wanted to participated in the contest and which didn'T have any comments on their feedback page [12:56] dholbach, ok, so I can review https://myapps.developer.ubuntu.com/dev/apps/1150/ "Unity bookmarks", [12:56] ? [12:57] yep, sounds good :) [12:58] seb128: NEW packages, stop reviewing! :) [12:58] :p [12:59] didrocks, shut up [12:59] dholbach: come on, you are on holidays after just 2 days of work! ;) [12:59] take your summer hat ;) [13:00] no summer hat for me yet :) [13:00] it's the Berlin way, they are all slackers there ;-) [13:00] seb128: thanks \o. [13:00] didrocks, yw [13:00] very funny to hear that from the French [13:01] 40-50 holidays per year + 20 guaranteed strike days [13:01] etc etc :-P [13:01] you forgot the 25 days to recover after holidays [13:01] dholbach: 50? no, we doubled since you had those numbers [13:01] ;-) [13:01] that's it - I'm moving to France! [13:03] I'll go and get something from the shop around the corner - brb [13:03] that's just an illustration of what we told :) [13:11] hey dholbach didrocks [13:12] hey bhavani_ :) [13:12] didrocks, :) how are you doing? [13:12] bhavani_: I'm fine, thanks ;) yourself? [13:13] didrocks, doing fine :) thanks! [13:13] hey dpm :) [13:16] hey bhavani_, started with the voting yet? :) [13:17] dpm, installing ppa's from script :) slow connection :( m gonna start it this night... yourself? [13:19] I haven't started yet, but I'm about to :) [13:21] dholbach, dpm: do I need to do anything when I'm done reviewing something? just did "unity-bookmark", I sent a vote email and pushed a vcs [13:21] doing https://myapps.developer.ubuntu.com/dev/apps/1182/ "Trip Planner" [13:23] seb128, other than adding a feedback message for the app developer to merge your fixes in myapps, I think that's it, but dholbach has done a bunch of reviews and he should be able to confirm and point you to the boilerplate replies [13:23] dpm, well, I Cced them on my vote email [13:23] dpm, https://wiki.ubuntu.com/AppReviewBoard/Review/Showdown says to comment only if the app is not good to go [13:25] seb128, we should at least change the status, but that would require someone with permissions. bhavani_, do you think you can change the status of https://myapps.developer.ubuntu.com/dev/apps/1182/ to indicate that it's up for vote? [13:25] no [13:26] it's not, I just started on this one [13:26] https://myapps.developer.ubuntu.com/dev/apps/1259/ [13:26] is [13:26] https://myapps.developer.ubuntu.com/dev/apps/1150/ [13:26] as well [13:30] I changed to review in progress [13:35] seb128, dpm since its under review and to vote I changed to review in progress [13:36] dpm, btw the ppa script is pretty cool [13:36] :) [13:36] bhavani_, all the credit goes to mhall119 for it [13:37] mhall119, cool script :) thanks! [13:38] which script? [13:39] I updated my app https://myapps.developer.ubuntu.com/dev/apps/1298/ Please, review it again [13:40] mhall119, ppa installer script for app showdown :) [13:40] mhall119 I'd like to know how to get started. [13:43] * bhavani_ is almost done with installation of app showdown packages and is all exited :) [13:44] Parker: https://wiki.ubuntu.com/AppReviewBoard/Review/Showdown has the step by step instructions [13:44] basically you get the app, build it, fix any packaging warnings you get from debuild and arb-lint, then email the ARB when it's ready [13:45] oh, i got email: [13:45] Rejected: File mirrorcam_1.0-0extras12.04.1.tar.gz already exists in robotex, but uploaded version has different contents. See more information about this error in https://help.launchpad.net/Packaging/UploadErrors. Files specified in DSC are broken or missing, skipping package unpack verification. [13:45] how to fix this? [13:46] robotex: you have to increase the version, I suppose [13:46] robotex: you need to increment the version number for each new build [13:47] in debian/control ? [13:47] in debian/changelog [13:47] you need a new entry [13:47] new entry at start of file or at the end? [13:50] hum [13:50] I can't add comments :-( [13:50] " [13:50] Access forbidden [13:50] You just tried to access a feature which you don't have permission to use. [13:50] Only the owner of an application can do that. [13:50] " [13:50] https://myapps.developer.ubuntu.com/dev/apps/1182/ is buggy [13:50] how do I tell the author? [13:53] I changed changelog but version still 1.0 after building [13:53] mirrorcam (1.0-0extras12.04.1) precise; urgency=low * Initial Release. -- Nicholas Shatokhin Mon, 09 Jul 2012 12:07:59 +0300 mirrorcam (1.1-0extras12.04.1) precise; urgency=low * Fixed ARB suggestions -- Nicholas Shatokhin Mon, 13 Jul 2012 16:48:59 +0300 [13:54] seb128: at the bottom of the page is a "Review" button [13:54] click then and there'll be a form at the bottom where you can leave the author comments/instructions [13:54] use the "Needs information" button [13:54] you may need to be added to a group [13:55] ajmitch: ^^ ? [13:55] dholbach: ^^ maybe you know [13:56] yeah, I fixed this ^_^ [13:56] mhall119, right, I don't have access, do you? [13:56] seb128: yes [13:56] mhall119, can you post http://pastebin.ubuntu.com/1089879/ on https://myapps.developer.ubuntu.com/dev/apps/1182/ ? [13:56] So, now I need just comment my app and wait for review again, am I right? [13:57] seb128, let me add you [13:57] seb128: done [13:57] dholbach, what am I signing for? [13:57] mhall119, thanks [13:57] more work :) [13:57] tata [13:57] done [13:57] dholbach, is that a trick of yours to enroll me in new duties? [13:57] you're done of these fine people now: https://launchpad.net/~ubuntu-app-review-contributors/+mugshots [13:58] lol [13:58] dholbach, danke I guesS? [13:58] ;-) [13:58] :) [13:58] de rien mon ami [13:59] * dholbach makes some tea and puts on some loud music [13:59] more apps! [13:59] Hi. I've uploaded a package to Launchpad but accidentally included the .bzr directory. Once I realized, I canceled the build from the Launchpad website. Is it possible to delete the package file or do I have to re-upload with an incremented version? [14:00] antiquark, the latter should fix it [14:00] dholbach: Thanks [14:01] dpm, wasn't https://myapps.developer.ubuntu.com/dev/apps/1062/ rejected? [14:01] I'm reviewing https://myapps.developer.ubuntu.com/dev/apps/1209/ "Indicator Remindor" [14:01] dholbach, it was [14:02] dpm, but it's back? [14:02] yeah, changes accepted by PPA. My app https://myapps.developer.ubuntu.com/dev/apps/1298/ [14:02] dholbach, I asked for someone from the ARB to reject it, but I think the status wasn't changed. I haven't e-mailed the developer either [14:03] dpm, dholbach sorry I missed the conversation... can I be of some help here? [14:04] bhavani_, the question was if https://myapps.developer.ubuntu.com/dev/apps/1062/ should be rejected [14:05] dholbach, ok got it.... btw based on what grounds? [14:06] dholbach, are apps allowed to install stuff in /etc/xdg/autostart? [14:06] bhavani_, read Allison's comment on the feedback page [14:06] stgraber, can you answer seb128's question? ^ [14:06] dholbach, just a moment [14:09] dholbach, ah got it! [14:09] great [14:10] so ll press the reject button now because it contains some objectionable content [14:10] seb128: I'd be tempted to say no, but it's not a case that we have explicitly discussed yet. Personally I'd consider that as a "system setting" which we usually don't allow for ARB apps. [14:11] seb128: so I'd much prefer they don't and instead offer an autostart option in the app that adds the launcher in .local/share (or wherever autostart is these days) [14:11] seb128, I got a mail you reviewed my app, and suggested some changes, but I get an error while trying to merge.. is there a workaround or should I just manually edit the files and commit those? [14:12] this is what I get: http://paste.ubuntu.com/1089908/ [14:13] lemaire, hey [14:14] lemaire, I branched from lp:~ubuntu-app-review-contributors/ubuntu-app-reviews/unity-bookmarks [14:14] not sure why they are not common [14:14] lemaire, but anyway feel free to apply the diff manually [14:15] lemaire, http://bazaar.launchpad.net/~seb128/ubuntu-app-reviews/unity-bookmarks/diff/2 [14:15] lemaire, patch -p0 < thisfile [14:15] thanks [14:16] lemaire, feel free to keep you detailed changelog, I just merged to one entry since that's the common practice [14:16] lemaire, yw [14:16] is there anything else I need to do, because in myapps it still says pending review and it's not in trello [14:16] i'm just checking to see if everything is ok :D [14:17] stgraber, thanks, that's an appindicator in this case, but yeah, .local seems better [14:17] dholbach, mhall119, dpm: ^ is there anything to do for lemaire? I reviewed and approved his app and sent a vote email and he's merging my tweaks in his vcs [14:18] no, that should be it [14:18] ok, thanks guys [14:18] perhaps just change status to review in progress [14:19] dholbach: we have "Maps" on the trello twice, once from doctormo in "Voting" and once from you in "Waiting on Developer" [14:19] oops [14:20] lemaire: which app? [14:20] we haven't gotten everything on the Trello yet [14:20] https://myapps.developer.ubuntu.com/dev/apps/1150/ [14:20] mhall119, I don't see a vote for 'maps' on the mailing list [14:20] dholbach: me neither, he must not have sent it (or it's being moderated?) [14:21] ah, maybe yes [14:21] maybe stgraber can moderate the queue (or add somebody to the admins list for the mailing list?) [14:21] lemaire: I've added it to the Trello [14:21] I'll have a look at "Interest Calculation" [14:22] lemaire: you app is part of the list that the judges are reviewing though, so don't worry [14:22] mhall119, thanks :) [14:22] ah no, that's also up for vote by doctormo [14:23] bhavani_, ajmitch, stgraber, wendar: is there a way to get apps off of https://myapps.developer.ubuntu.com/dev/arb/ if they are voted on? is there a state for that? :) [14:23] it'd make reviewing certainly easier [14:23] dholbach: yeah, I need to go through the moderation queue. wendar also has access [14:23] dholbach, I still don't have access to the review thing :-( [14:24] seb128, can you log out and log back in again? you should now be in the right team [14:24] stgraber, do you have enough list moderators? [14:24] dholbach, I use review in progress for that [14:24] bhavani_, so you just click on "start review" and then? [14:25] dholbach, waouh a new big orange button is there! ;-) [14:25] and keep it like that till I comment [14:25] seb128, feel the new power! [14:25] bhavani_, ah ok [14:25] gotcha [14:25] * mhall119 is going to start calling them BOBs [14:26] :) [14:26] dholbach: it's usually fine as I'm adding people to the whitelist as I go. Just processed the queue now [14:26] dholbach, so, I've a package that's not quite good yet (install a buggy etc, use /etc and lacks a depends) ... should I pick "ask for informations" or "reject"? [14:26] dholbach, dpm rejected https://myapps.developer.ubuntu.com/dev/apps/1062/ now [14:27] stgraber, ok great [14:28] I'll take a leaf out of bhavani's book and mark a couple of 'vote in progress' apps as 'review in progress' [14:28] so we get them off the mainpage [14:28] dholbach, ? [14:29] seb128, ie: "Interest Calculation" is on the main page with "pending review" [14:29] and that's although it's up for vote already [14:29] dholbach, you missed my question I guess [14:29] dholbach, read 3 minutes back the yellow line :p [14:29] oh sorry [14:29] seb128, ask for information [14:29] danke [14:30] reject is more like "the idea of your app is wrong" [14:30] or something :) [14:30] gotcha [14:32] bhavani_, nice trick :) [14:32] * dholbach cleans up https://myapps.developer.ubuntu.com/dev/arb/ [14:33] :) [14:34] * dholbach documents the trick on https://wiki.ubuntu.com/AppReviewBoard/Review/Showdown [14:39] dpm, is there a way to save the survey sheet somewhere so that we can carry on voting from where we left at a later stage? === trkv_ is now known as trkv [14:41] can the "Revista Espirito Livre" submissions be punted over to commercial apps? [14:43] * almien appreciates everyone is inundated with apps here, but I wrote one for the contest and not entirely sure that it got "entered", whatever that means. Any way to check? [14:43] dholbach: sure, hold on a sec [14:43] sweet [14:45] dholbach: done [14:46] stgraber, thanks [14:46] mhall119, did you submit myshortcuts for vote? [14:46] it says so on Trello, but maybe I missed the mail [14:47] How many applications in the review query? [14:47] bhavani_, yes [14:47] you don't have to do anything special, results are already saved [14:48] so you can leave voting and then let's say tomorrow, open the same link and the saved results will still be there [14:48] dpm, ah thanks dpm [14:53] ok, all the apps which are up for voting are off of https://myapps.developer.ubuntu.com/dev/arb/ now [14:53] should make it a little bit easier to pick [14:54] emphasis on "a little bit" ;-) [14:54] * dholbach has a look at Spellathon [14:59] stgraber, https://myapps.developer.ubuntu.com/dev/apps/1291/ seems to be in the ARB queue with a price of 2.99$ - can it be punted over as well? [14:59] * dholbach has another look at Postman [15:01] dholbach: done. Wondering how it go in there to start with... [15:02] same here dholbach [15:02] access forbidden [15:03] dholbach: sent to vote on the 10th [15:03] yeah, no idea - I just saw it on the main page [15:12] can anyone of you who still runs precise build and test lp:~dholbach/ubuntu-app-reviews/postman? [15:12] on quantal it messes with compiz :) [15:15] dholbach: builds fine, only arb-lint warning is about the size of it, only lintian warning is about /opt/ [15:15] test-run [15:15] it builds fine for me too :) [15:16] and successfully runs [15:16] great [15:16] can't test if it works ok [15:17] then I have a quantal issue which prevents it from working [15:17] but GUI is ok [15:17] and it can be safely submitted for vote [15:17] thanks trkv_! [15:19] dholbach: works fine for me [15:19] sweet [15:19] thanks guys [15:19] up for vote [15:19] yeehaw [15:20] \o/ [15:20] it looks really nice too [15:20] oh wow [15:20] "quickly quickly quickly is the bad of bad when i went to submit my project ask my name project and search in lauanchpad and give project number.I am very angry.quickly bad bad bad :(" [15:20] ? [15:21] https://myapps.developer.ubuntu.com/dev/apps/1302/ [15:21] maybe somebody can help him [15:22] * dholbach has another look at Convertik [15:23] dholbach: I replied, there is no "Roundball" project [15:24] that's probably his issue [15:35] o/ [15:37] can somebody help with https://myapps.developer.ubuntu.com/dev/apps/1055/feedback/? [15:38] * vibhav takes a look [15:39] Sadly, I have no Idea [15:39] why it is not working :( [15:44] can anyone with an android phone build and test lp:~dholbach/ubuntu-app-reviews/blubphone? [15:49] Hi all! [15:51] * bhavani_ testing blubphone as a part of showdown judgement now dholbach [15:51] hey PaoloRotolo [15:51] I see at this https://myapps.developer.ubuntu.com/dev/arb/ many applications that was sent few monts ago. How much Ubuntu Showdown parcipilants applications? [15:51] Hi jono [15:51] hey PaoloRotolo [15:52] hello bhavani_ :) [15:52] PaoloRotolo hi [15:52] hey robotex_ [15:54] * dholbach has a look at "Positive" [15:54] * PaoloRotolo has a look at "Wiimap" [15:55] * bhavani_ thinks tastebook and cookety app are somewhat similar [15:56] hi jono [15:56] hey bhavani_! [15:56] bhavani_, still I think we should review them all :) [15:57] so the one the users like best or is developed best can succeed [15:57] dholbach, agreed :) [15:57] can anybody review my showdown application? https://myapps.developer.ubuntu.com/dev/apps/1298/ [15:58] jono, I pinged you 3 times on irc other day in a gap of 25 mins sorry for that [15:58] robotex_, I'll have a look at it when I'm done with the one I'm reviewing right now [15:58] bhavani_, no worries! [15:58] bhavani_, keep pinging him - I don't think jono is busy enough yet [15:58] :-P [15:58] dholbach, :) [15:59] * bhavani_ fears jono a bit :P [15:59] he loves it when his irc client is blinking like a christmas tree [15:59] :) [16:00] bhavani_, heh, you have nothing to fear :-) [16:01] :-) how are you doing jono btw? [16:01] , ok, thanks [16:01] bhavani_, great! how are you? [16:02] robotex_: I use the "cheese" in the case of lacking mirror :) [16:02] jono, me too doing good playing around with apps since past week or so and loving it [16:03] :) [16:03] As I can't review apps can someone please review this https://myapps.developer.ubuntu.com/dev/apps/947/ with this text http://paste.ubuntu.com/1088477/ [16:04] :) [16:04] bhavani_, awesome, thanks for all your help! [16:05] robotex_: don't want to say you've done the useless work, but the functionality is obviously duplicated) [16:06] jono, no mention! If I am of some help in a small way to a wonderful community ll be more than happy :) [16:06] bhavani_, :-) [16:07] * bhavani_ just finds a german language app in desktop facebook app and requests dholbach to test :) [16:08] uhm, Wiimapp can't "map" my Wii :( [16:09] my app is simle and lightweight [16:09] robotex_: could you tell me the list of deb-package dependencies, please? [16:10] bhavani_, did the android app work for you? [16:10] and unpacked size [16:10] dholbach, yes seemed cool [16:10] :) [16:10] bhavani_, and works? [16:10] ok, now it works :D [16:10] robotex_, did you update it in the ppa? [16:10] yes it works here [16:10] ... just wondering where to check for the update [16:11] bhavani_, thanks, submitting for vote [16:11] I use samsung galaxy [16:11] and it worked [16:11] cool [16:12] current version is 1.1 [16:12] I changed COPYING and icons path [16:12] then updated with dput [16:12] :) alright dholbach time to sleep here :) night all! [16:13] for building or for running? [16:13] robotex_: for running [16:13] robotex_, perfect, thanks [16:13] bhavani_, good night! [16:14] trkv, libqt4-opengl, libcv2.3, libhighgui2.3, libopencv-core2.3, libopencv-highgui2.3, libopencv-imgproc2.3, libqt4-core, libqt4-gui, libqt4-declarative [16:15] robotex_, reviewing now [16:15] btw, has anyone considered porting the well-known git-hook to bzr? (I mean the one that shots the commiter and saves image in commit metadata) Is it ever possible? [16:16] robotex_: I'm not sure that all these dependencies weight totally less than cheese ones :) [16:16] but for what purposes your mirror needs opencv? O_o [16:17] trkv, camera capture [16:18] trkv, cheese a good app but if I need a mirror I want just run app and use it. I don't want to seek and select mirror effect. I was inspired by mac apps [16:18] ok, ok, I don't want to say it's useless) [16:19] trkv, when I searched mirror in Software Center by query "Mirror" I found nothing [16:20] it's obviously a problem [16:21] dholbach, not having the icons in /usr/share/icons/hicolor will make the apps un-customizable and they might look out of place if users use different themes. I think icons should be allowed in /usr/share/icons/hicolor. Should I raise the topic on the ML? [16:22] OwaisL, yes, that'd be nice - can you use app-review-board@lists.u.c? [16:22] trkv, so when I didn't found mirror, I decided to create it. I don't know about cheese. Sorry :( [16:22] dholbach, not sure. Let me try. [16:22] OwaisL, thanks [16:23] robotex_: not a problem) however, doesn't Qt itself contain classes for camera? I think I've seen something like that in qtmultimediakit [16:24] robotex_, with the changes in lp:~dholbach/ubuntu-app-reviews/mirrorcam it's ready to go [16:25] putting it up for vote [16:25] , unfortunatelly not [16:26] robotex_: take a look at http://bit.ly/NqVAeV [16:26] , It can plays files, but it is can't work with camera [16:26] Qt Mobility can, Qt Desktop can't [16:26] qt-mobility is packaged for ubuntu so you can give it a try [16:28] , but I will try it and if I can use it on Desktop I will change it in next versions [16:28] , need I to do something now? I see status "Needs information" [16:29] robotex_, you can merge the changes I put up in that branch [16:29] robotex_, I CCed you in the mail to the app review board who will now vote on the app [16:30] , so I need to merge changes and update version in PPA, am I right? [16:30] robotex_, I sent the ARB a link to my branch, but having both branches in sync will be better, yes [16:32] , will app have status "Published" somewhen? What can I do for this? [16:32] nothing, sit back and have a cup of tea :) [16:33] everybody's very busy because loads of apps were sent in the last days, but your app is with the right people now [16:33] , ok, thanks :) [16:33] rock on! [16:35] * dholbach has a look at ShowMyFaves [16:36] oh, God. Somebody loves my app http://iloveubuntu.net/transform-your-computer-mirror-mirrorcam :) [16:39] robotex_: heh, there's a second one — iheartubuntu.com, check if you appeared there too) [16:44] nice :) [16:46] dholbach, I don't have the permission to leave comments on those app reviews [16:49] mterry, hang on [16:50] you might have to log out and log in again [16:51] robotex_: I've just run the camera app from Qt examples, so you probably need to investigate it more thoroughly) [16:52] , ok, thanks for you advice [16:53] just imho, opencv for taking an image from camera is something like libreoffice for code editing) [16:54] :) [16:54] * dholbach has a look at liberedit [16:57] * dholbach has a look at Nulloy Music Player [17:14] wendar, ajmitch, highvoltage, stgraber, dpm: I thought I should let you know that I just rejected https://myapps.developer.ubuntu.com/dev/apps/1210/ [17:14] let me know if that was unsuitable [17:14] https://myapps.developer.ubuntu.com/dev/apps/1232/ should probably be rejected too [17:18] hey guys [17:19] I need a little help merging your code and stuff [17:19] mhall119, there are a lot of duplicates on the Trello [17:19] mhall119, I'll archive them all :-( [17:19] does anyone got a minute or two or thirty :D and could assist me? [17:20] dholbach, I saw it on the list. What did you mean by 'bundled code'? [17:20] dpm, upstream source code of other libraries [17:21] dholbach, oh, you mean it was bundling libs instead of using those from the archive? [17:21] one of them was in the archive already [17:21] 2 others weren't [17:21] at any rate it was clearly nothing you could review in an hour [17:25] alright [17:25] time to call it a day [17:25] have a great weekend everybody [17:26] bye [17:27] are ubuntu channels typically used at weekends? [17:27] bye! d [17:27] Anyone still reviewing? [17:34] almien, they are usually quieter, but people do hang around here. Many people who work as a day job in Ubuntu like to take a break during the weekend, though :) [17:40] dh [17:42] If I try to merge uarb-changes from their branch, it moves all my existing files to foo.moved, bar.moved, etc instead of really merging stuff? This shouldnt be like that, should it? [17:42] dholbach: that's perfect, thanks! [17:43] dholbach: we don't vote on rejections when the cause is one of common ones (like being far too large) [18:20] Hi everyone, we had to review our app for the showdown, but when we do a debuild -S and a dput to our ppa with the changes file, launchpad reject the push. It seems to be because we didn't changed the version number. How can we changed the version number ? Do we have the right to change this version number for the contest ? [18:27] ShowMyFaves: The appropriate file to change is debian/changelog [18:28] Thank you, so we have to change the version number in that file ? [18:30] ShowMyFaves: Yes, if it says, for example, 12.07.3, change it to 12.07.4 [18:30] jbisch: ok thank you, we will try this right now [18:39] jbisch: This is working, thank you. Good luck for the review process ! and thank you for you job! [18:39] Erm... is this the right place to voice a concern? [18:40] ShowMyFaves: You're very welcome. Best of luck! [18:40] Anyone? [18:42] I noticed that Nulloy Music Player was rejected because "...our focus is on lightweight apps...". I assume that corresponds with the warning generated by arb-lint? [18:43] mhall119: I think it was yesterday that I ran across a warning like that for Deltify (IIRC) and you said that could be ignored. [18:44] But now it seems like that might be a problem... and I'm mentioning this because I received a similar warning for my submission. [18:44] george_e: that warning is geared more towards the app author, we can just send it to the ARB for voting and they can decide [18:45] mhall119: So it could still be rejected though because it's "too big"? [18:45] * george_e is starting to become concerned... [18:46] george_e: Make sure it's really source code that's causing the warning. I reviewed an anagram solve that had a huge text file mapping between scrambled text and words. [18:47] I can take a look... [18:48] looks like the bulk of it is in the 3rdParty directory [18:49] Hmm... arb-lint reports that "...it has 45 source files" which is odd - if you add up the .h and .cpp files, I get 60. And if you only include the .cpp files, I get 30. [18:49] It's reporting 3815 lines of code... [18:51] wendar: stgraber: ajmitch: can any of you comment on Nulloy? [18:52] I am currently reviewing Fogger. The developer is claiming that he accidently removed important functionally just before the deadline and requests permission to push a new version to his ppa. How should I proceed? https://myapps.developer.ubuntu.com/dev/apps/1227 [18:52] george_e: size of the app is one of the guidelines [18:52] looks like dholbach rejected it [18:52] george_e: but, it's not a specific number of lines of code [18:52] george_e: it's more a general guideline of overall complexity [18:53] george_e: for the rule of thumb, if you don't feel like you can do a comprehensive code review in about an hour [18:53] george_e: it's probably too complex [18:53] Well, each file begins with a 15-line license header, so 60*15 = 900 lines of comments. [18:54] That brings the number down by 25%. [18:54] george_e: yeah, don't get tied up in the lines of code :) [18:54] I'm still very concerned though... [18:54] george_e: just fix what you can and send it to the ARB [18:54] george_e: would you feel comfortable saying that you've reviewed every line of code, and know it doesn't have security problems? [18:54] If it is rejected, can I quickly strip out a bunch of functionality in a desperate attempt to shrink the codebase? [18:55] george_e: you can do that later, it doesn't have to be done quickly [18:55] wendar: More than once. I have gone through each file more than once. [18:55] george_e: then it's fine [18:55] I hope so :) [18:55] george_e: the point of the restriction isn't to kick out an app because it has one line too many [18:56] george_e: apps submitted for the contest will be judged as long as they can be installed from your PPA [18:56] george_e: the idea is that some packages really should be reviewed by the Ubuntu Developers or Debian Developers [18:56] Oh, okay. [18:56] if they aren't accepted by the ARB because of something like this, they are still qualified for the contest [18:56] * george_e breathes a sigh of relief. [18:56] :) [18:56] Thanks everyone. [18:56] relax, it's friday [18:57] jbisch: from the ARB perspective, I'd say let the Fogger developer submit the update [18:58] jbisch: but, I can't speak for the contest rules [18:58] wendar: Thanks, I'll tell the developer to do so [18:58] jbisch: Fogger should submit updates, yes,but the judging will be based on what was submitted by the deadline [18:58] mhall119: Alright, thanks [18:58] .... mhall119: ah, that's what I was going to suggest :) [18:58] we can't allow anything after that, even if it's reverting back to something that was there before [18:58] it wouldn't be fair [18:59] mhall119: I agree [18:59] all we're allowing is packaging related fixes [19:22] jan-simon: we have instructions up at https://wiki.ubuntu.com/AppReviewBoard/Review/Showdown [19:22] thank u [19:23] basically you get a branch of the code, try building it. If it builds, run arb-lint. Fix whatever warnings you can, then email it to the ARB for voting [19:24] Hey guys, I was away. Is there a problem with Fogger? [19:27] OwaisL: jbisch was told there may have been some functionality removed right before the contest deadline [19:30] I am currently reviewing the version in the ppa. There are just some minor changes that I will push to my ppa. [19:37] I'm having trouble with Fogger. I can create apps fine, but when I go to run one of them, it just shows a window with the app's name and a frozen spinner. [19:40] jbisch: put that in the Feedback comments for the author [19:41] along with the specific version number you are testing [19:41] jbisch, I think the frozen spinner is a gtk issue, my fried always gets frozen spinners. Can you run /opt/extras.ubuntu.com/fogger/bin/fogger appid and check the output [19:41] "/opt/extras.ubuntu.com/fogger/bin/fogger -l" will show you the app ids [19:43] OwaisL: http://paste.ubuntu.com/1090433/ is the output [19:43] Thanks, checking [19:43] OwaisL: Both apps have the issue [19:44] Are you behind a proxy? [19:45] jbisch, ^ and can I have the version you are testing please? [19:45] I meant output of "/opt/extras.ubuntu.com/bin/fogger/ 5e8a5709f662f8d401f7a00e6137f9ca " [19:46] No proxy, and I can navigate to both sites via my web browser. [19:46] Ah, I think I know what the issue is. Are you on Quantal? [19:46] Quantal has a bug in libsoup [19:46] Yep [19:46] exactly [19:46] wait [19:46] libsoup-CRITICAL **: soup_session_send_request_async: assertion `use_thread_context' failed [19:46] ^ This must be the issue [19:47] re [19:47] stgraber: hello! Phoenix87 had a question about postinst/prerm [19:48] OwaisL: Must be, I'll send you some small changes to make, but I'll let a reviewer with precise finish reviewing. [19:49] stgraber: when I manually package my app and send it to launchpad, the prerm and postinst scripts are not included in the final deb [19:49] the same happens if i manually package my app on my machine [19:49] since it's going to install in /opt this causes some issues with python modules [19:49] which are not updated [19:51] jbisch, thanks! [19:51] jbisch, BTW link to libsoup bug https://bugs.launchpad.net/ubuntu/+source/libsoup2.4/+bug/1011473 [19:51] OwaisL: Thanks [19:52] Phoenix87: you app shouldn't isntall system-wide python modules [19:53] mhall119: well anyway i guess that python must be "informed" about where to look for the modules building up my app [19:54] and i think that this is done by the postinst script [19:57] Phoenix87, ah... that's why. The wrapper script that quickly makes should handle that [19:57] Phoenix87, it has some logic to see if it's being run from /opt and adjusts PYTHONPATH as needed [19:58] Phoenix87: what mterry said [19:59] mterry: yep and in fact including those scripts makes my app runnable with "/opt/extras.ubuntu.com/gtumbler/bin/gtumbler" [19:59] if you're not using quickly, you'll need to make your executable set sys.path to include your other python modules [20:00] mhall119: but including those scripts in debian seems to solve this issue. Wouldn't this be OK? [20:01] Phoenix87, right, but you're saying your wrapper script doesn't find the module itself? Does it not have those /opt detecting lines in it? [20:01] What's the error you get without the postinst scripts [20:01] ? [20:01] mterry: without prerm and postinst the wrapper can't find the modules [20:02] with those scripts in debian/ the wrapper works fine [20:02] Phoenix87, what's the exact error? Can you see the lines in your wrapper that detect /opt and adjust sys.path? [20:03] mterry: this is the postinst that fixes this issue: http://pastebin.ubuntu.com/1090465/ . I'm not sure this is instructing the wrapper to use the correct sys.path. It might be though [20:05] the wrapper has this line: syspath = sys.path[:] # copy to avoid infinite loop in pending objects [20:05] Phoenix87, right, but I'm saying the Right way for this to be fixed is to not use postinst, and have the wrapper adjust sys.path. Which it should be doing. So the fact that it's not doing that for you is the bug. I'm trying to figure out why that's happening, which is why I'm asking for the exact error or a pastebin of your wrapper or something [20:05] so i guess it is doing the job [20:05] Phoenix87, does it look like this? http://pastebin.ubuntu.com/1090471/ [20:08] sorry i couldn't write on chan [20:09] mterry: i guess they match [20:09] http://pastebin.ubuntu.com/1090471/ [20:09] Oh, couldn't write, but you could read? [20:09] oops [20:11] hello [20:12] mterry: i guess not [20:13] I'm the creator of this app: https://myapps.developer.ubuntu.com/dev/apps/1152/ that is called protoborsa.. I would like to know why in trelloboard this application result as "waiting on developer" ... [20:13] Phoenix87_, say again? [20:15] what does it mean "waiting on developer"? how can I change it? thanks you [20:15] crazycoder1999, sorry, I don't know. Maybe stgraber does? [20:15] Phoenix87_, what did you mean? [20:18] mterry: i guess i couldn't read either [20:18] Did you see http://pastebin.ubuntu.com/1090471/ ? [20:18] Phoenix87_, ^ [20:19] mterry: yep I saw it and i replied with the link to the source code of my app [20:19] crazycoder1999: looks like you had some conversation with dholbach, if you feel you've done what he's asked I'll move the card to "Reply from Developer" [20:19] there you can find the wrapper [20:20] mterry: http://bazaar.launchpad.net/~phoenix1987/gtumbler/trunk/view/head:/bin/gtumbler [20:20] Phoenix87_, sorry, didn't get that link [20:20] ok [20:20] mterry: it's ok [20:20] Phoenix87_, ok, so looks roughly right. So can I have the actual error when you try to run it without the postinst? [20:21] (if you have it handy) [20:21] mterry: pretty simple: try "import nopackagewiththisname" in python, and that's the error i get without postinst [20:22] mterry: the wrapper is trying to import the module gtumbler (last 2 lines in the wrapper) [20:23] but without postinst it can't find any module named gtumbler [20:23] Phoenix87_, sounds like you have to start adding print statements or something in that block that detects if you're running in /opt. For some reason either that block isn't being run or it's confused [20:23] Debug that block and you should be able to figure it out [20:23] Not that much code there to be wrong [20:24] It looks like right code. [20:24] mterry: I didn't mention this because I thought it is obvious, but those prerm and postinst are taken from the deb generetad by quickly package --extras (11.10) [20:25] mterry: what I'm saying is that they aren't explicitly in the debian/ folder, but they are included in the deb generated by quickly [20:25] ops.. sorry @mhall119 for the double msg.. I just want to know if everything is ok with my app.. or I have to change something and what.. nothing else..thanks you [20:25] I didn't write postinst nor prerm [20:26] i just extracted them from the deb generated by quickly into debian/ and then I manually packaged my app [20:26] Phoenix87_: hmmm, could be that pysupport doesn't work right, everybody else is using dh_python2 [20:26] Phoenix87_, sure. I understand, but 11.10 quickly does several things the Old Way (like pysupport, postinst, desktop file in wrong place) [20:26] crazycoder1999: just waiting on someone to be available to pickup the review again, that's all [20:27] Phoenix87_, the ARB doesn't like postinst, so we try to make them unnecessary with the wrapper script [20:27] mterry: i see [20:27] yeah, avoid maintainer scripts whenever humanly possible [20:27] mhall119: Sorry we weren't able to connect up last night. By the time I got off work, you were already gone. If y'all still need some help with reviews, just let me know how I can help. [20:27] then I'll try some magic with quickly on 12.04 then [20:28] mhall119: anyway, my app is in the Waiting on Developer list on Trello but doesn't show up in the Contestants list. How is that so? [20:28] jvrbanac: we still do, daniel posted step-by-step instructions here: https://wiki.ubuntu.com/AppReviewBoard/Review/Showdown [20:28] Ok awesome. Reading now... [20:31] Phoenix87_: was there a build for Precise in your PPA before the deadline? [20:32] absolutely [20:34] Phoenix87_: I'll check with the others in the morning [20:40] mhall119: http://bazaar.launchpad.net/~phoenix1987/gtumbler/trunk/revision/7 [20:41] mhall119: the build for precise exists since July 2 [20:42] Removing the icons from /usr/share breaks functionality but I'm fixing it. What do I do after this? Should I push to a new branch as my current trunk is way way ahead? [20:42] jbisch, mhall119 [20:43] * crazycoder1999 never do "spaghetti" while you are on irc... :/ [20:46] Phoenix87_: looks like it wasn't showing up in the Dash for the judges to launch [20:47] that could be the cause [20:48] keep up the great work ubuntuappshowdown! bye [20:52] mhall119: Hey, at what time was the deadline on 9th? :) I think a wrong version might have been as reviewed. Can you please confirm if this version qualifies? https://launchpad.net/~loneowais/+archive/fogger/+sourcepub/2555798/+listing-archive-extra [20:52] Thanks! [20:56] mhall119: i see but this is related to this .desktop issue we were discussing here [20:58] mhall119: am I still on time to fix this? [20:59] it all worked fine untill I had to apply the changes suggested by dholback, which forced me to abandon quickly and manually package my app [21:00] why must be the app files in /opt/extras.ubuntu.com? [21:04] OwaisL: I reviewed the latest version in your ppa. You may push changes to your ppa, but for the purposes of the app showdown, they will not be considered [21:06] jbisch, that is understood but I just got confused by seeing that submit date on 0.7.1 was 09 Jul 2012 21:55:06 +0530. That should qualify it right? May be I'm wrong, just trying to confirm. [21:07] Does +0530 depict my timezone or does it imply 5.30 should be added to the preceding time ? [21:08] jan-simon: that's the requirement for getting them into the extras archive [21:09] ok, i've read the fhs the as well, and so it's seems to be reasonable [21:09] the app i'm reviewing is installing in /opt [21:10] OwaisL: looks like 0.1.7.2 [21:12] Phoenix87_: you have all the time in the world to get it through the ARB [21:12] mhall199, You mean 0.1.7.2 should be reviewed? [21:12] but unfortunately we had to go with what was available at the deadline [21:12] OwaisL: that's what I got on my testing VM I setup for this [21:14] mhall119, thanks! [21:33] hi, please help us to add our pub on ubuntu ads : http://meta.askubuntu.com/a/3684 ! vote for us ! [21:34] mhall119: I had to rebuild my app in order to make the changes I've been told to appy by dholbach, and this is why the judges couldn't find my app in the dash. I don't think it's my fault... [21:35] mhall119: when ubuntusubmitted throuh quickly it used to show up in the dash, for the .desktop file was handled well [21:35] but since I had to change the copyright file I had to do things manually and the .desktop file got excluded [21:45] hmm, changes to the copyright file shouldn't change where anything was placed in the package, something else must have changed [21:46] and running debuild or bzr builddeb manually would use the same packaging info as the last "quickly submitubuntu" created [21:47] mhall119: quickly runs additional scripts that i probably missed when manually packaging everything [21:47] so that the .desktop file was not installed correctly [21:47] i'm still trying to solve this issue [21:47] those scripts just update the packaing files in debian/ [21:48] so they should have been identical (except for the copyright file) when you manually rebuilt it [21:48] mhall119: as we were discussing with mterry it is likely that quickly handles the .desktop file as awell and that probably there is a bug in the 11.10 version [21:48] Phoenix87_: I'll talk to dholbach about it in the morning to get a better understanding [21:50] mhall119: quick question. I went through the page you linked me to, all of that stuff make sense. Do we just pick any app in the "Needs Review" category or are they done in a specific order? [21:50] mhall119: i think i finally solved this: i used the 12.04 version of quickly package --extra to have the rules file created without the bug [21:50] ^makes [21:50] i copied this file over [21:50] manually packaged [21:50] and now my app shows in the dash [21:50] jvrbanac: no specific order, just move it to "Being reviewed" when you start on it [21:51] gtumbler_12.07.5_all.deb is currently building on launchpad [21:51] k [21:51] Phoenix87_: I'll talk to dholbach and dpm in the morning to see if it can be included in the judging [21:51] mhall119: ok thank you [21:53] mhall119: I don't believe I can move things on Trello as I am not a member on the board. [21:54] ajmitch: ^^ can you add jvrbanac to the board? [21:54] Thanks! [22:07] mterry: thank you very much for your assistance. [22:08] Phoenix87_, anytime! [22:27] mhall119, jbisch: Fixed! https://myapps.developer.ubuntu.com/dev/apps/1227/feedback/ [22:44] mterry: Are all the apps reviewed now? [22:59] does every source code file has to have a copyright section? [23:12] jan-simon: no, the debian/copyright file can specify for all of them [23:13] mhall119: ok. i finished my review, where should i submit it, and can you take a quick look at it? [23:13] doctormon: there's still about 30 that haven't been reviewed yet [23:14] jan-simon: put is to a bzr branch on launchpad, then send that link to the app-review-board mailing list saying it's ready for a vote [23:14] ok, but there are some issues with the package. [23:15] in that case just state the problems, instead of saying it's ready for a vote [23:15] ok [23:15] and CC the app author in the email [23:16] mhall119, is it possible to have the judges vote on the submitted version but publish the latest version in SC so users get the improvements I've made since submission? [23:16] OwaisL: absolutely [23:17] mhall119, that's great! I'll prepare the trunk for arb in the morning and submit. [23:17] Thanks a lot for you help! [23:18] cool, good luck [23:18] Good Night! [23:19] Thanks@ [23:19] s/@/!