/srv/irclogs.ubuntu.com/2012/07/13/#ubuntuone.txt

ottadinihello, just joined to ask for some help.04:49
ottadiniIt seems I may have lost an entire dir tree due to a failed sync with U1.04:50
ottadiniThe folder structure is there, but no files.04:50
ottadiniu1sdtool status reports it is idle.04:51
ottadiniHow it happened: I dragged a folder that was already a UDF and being synced with U1 into the 'Ubuntu One' folder in Nautilus.04:54
ottadiniMinutes later I reversed this, and copied the directory back to its original location.04:55
ottadiniEnd result: no files, just the directory tree.04:55
ottadiniI have checked online at my account on one.ubuntu.com, and same result.04:57
=== zyga-afk is now known as zyga
=== teknico_ is now known as teknico
JamesTaitGood morning all! Happy Friday the 13th! >:-)08:49
popey:( my quantal machine has been "uploading" some files for about a month now08:59
popeyso i removed all the files from the folder in nautilus just now..09:00
popeysyncdaemon still seems to be chatting away about the files in its log09:00
popeyand sync is "in progress"09:00
popeyI stop and start and it still things it's uploading files which I moved out of that synced folder09:01
mandelpopey, our staff is very very broken in Q atm10:42
mandelpopey, sorry :(10:43
mandelpopey, with the move to python3, the mac port etc.. we are overwhelmed atm but afaik ralsina is going to look into the problems10:43
popeymandel, ok :)11:02
gatoxgood morning!11:09
gatoxmandel, hi11:09
mandelgatox, morning! feeling any better?11:09
gatoxmandel, MUCH, i slept all the day yesterday........ did you do anything with my branches yesterday?11:10
mandelgatox, I approved darwin4 I'm going to propose one with the daemon, I have move notify processor to its own package which removes circular importans and I have added a darwin only command line arg to choose if the deamon is used :)11:11
mandelgatox, my I have reviews: https://code.launchpad.net/~mandel/ubuntuone-client/fsevents-daemon/+merge/114836 :)11:12
gatoxyes11:12
gatoxmandel, 2163 lines?? and you complain about me...... shame on you! :P11:13
mandelgatox, wait, missing dep!11:14
mandelgive me a sec11:14
mandelgatox, oh no, looks like a move is not considered a move..11:15
mandelbad bzr..11:15
gatoxmandel, did you do bzr mv?11:16
mandelgatox, afaik yes, but in one of the pump when wrong and I have to resolve a conflict.. maybe that screwed up the diff11:16
mandelgatox, you can see there is a large delete and then the same code added later..11:16
gatoxok11:17
mandelgatox, sorry for the PITA11:17
gatox:P i'm kidding11:18
mandelgatox, regarding the NotifyProcessor, in a later branch I have moved it to filesystem_notifications/notify_processor/ that was we can remove a circular import issue we had and make things cleaner11:19
gatoxmandel, where are we having a circular import?11:20
mandelgatox, in you look in notify_processor you will see there is a XXX: circular import comment, I have fixed that11:20
mandelgatox, mainly because later I was having a circular import when trying to reuse the notify processor you added, the fsevents and the fsevents_daemon can share it11:21
gatoxahhhhhhh yes, the one in the __init__ i remember11:23
mandelgatox, exactly, so that is out, which I think is a good move :)11:24
mandelgatox, I'm starting to wonder (although won't change it) what is the need of having platform infront of everything, but that is a minor detail11:24
mandelgatox, the code is looking a lot better know, we might be able to port it to the sp3 ;)11:24
gatoxsp3? ps3?11:25
mandelgatox, sorry ps311:26
mandelgatox, one hand is faster than the other.. :P11:26
mandelor was I thinking about xp sp311:26
mandel..11:26
gatoxjejej11:26
gatoxyou are such a windows lover..... maybe was that11:26
mandelmaybe..11:27
mandelgatox, early lunch for me, ok?11:40
* mandel lunch11:41
gatoxmandel, ack11:44
* gatox realize that mandel's branch is going to cause conflicts in the refactor one.... fun not11:56
gatoxmandel, mmmmm something don't look right..... shouldn't this be depending on darwin4?? i see some changes that are already in trunk11:58
gatoxmmm i think there is some kind of problem merging darwin4.... first time i see this on launchpad: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/darwin4-fsevents/+merge/11440512:04
ralsinagood morning!12:19
ralsinahow are you today gatox?12:19
gatoxralsina, fine..... today was 100% rest :P12:19
gatoxralsina, do you know what it means "This proposal supersedes" here: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/darwin4-fsevents/+merge/11440512:20
ralsinagatox: looking...12:20
gatoxi'm trying to look for some doc or something, but i can't find anything clear enough12:20
gatoxor how to fix it12:20
ralsinagatox: that this branch was proposed twice and this is the newer one12:20
ralsinathat's not bad, AFAIK12:20
gatoxralsina, aja..... but why is not being merged?12:20
gatoxahhhhh12:21
gatoxcommit message12:21
gatoxit seems i forget to include that when i repropose12:22
=== zyga is now known as zyga-food
=== zyga-food is now known as zyga
alecuhello!12:47
alecugatox: I see that darwin4 has landed. Awesome!12:51
alecugatox: I've created a bug for the deferred stop and the thread join fun. I'll probably be working on that.12:51
gatoxalecu, yes, i saw it12:53
gatoxalecu, ahhhh.... i thought it was for me :P12:53
dobeyhrmm13:04
dobeyno reviews on https://code.launchpad.net/~dobey/dirspec/python3/+merge/114713 :-/13:05
=== yofel_ is now known as yofel
gatoxalecu, ping13:19
gatoxalecu, when you are back......  is this the bug you were talking about? https://bugs.launchpad.net/ubuntuone-client/+bug/1024102 i see that is assigned to me, and i was going to add it to the tests-refactoring branch13:23
ubot5Ubuntu bug 1024102 in Ubuntu One Client "Deferred should be fired when a watch is stopped" [Undecided,New]13:23
gatoxmandel, ping when you are back.... i've some questions about your branch13:24
dobeygatox: maybe you should review https://code.launchpad.net/~mikemc/ubuntuone-client/use-dirspec-get-cmdline/+merge/11472013:27
gatoxdobey, ack13:27
dobeymandel: 2163 lines?!13:35
dobeybriancurtin: any more work on the py3-unicode branch? it's still needs fixing from alecu13:37
* alecu is back13:38
gatoxalecu, when you are back......  is this the bug you were talking about? https://bugs.launchpad.net/ubuntuone-client/+bug/1024102 i see that is assigned to me, and i was going to add it to the tests-refactoring13:39
ubot5Ubuntu bug 1024102 in Ubuntu One Client "Deferred should be fired when a watch is stopped" [Undecided,New]13:39
alecugatox: that's the bug, yes. I assigned it to you, but ralsina told us yesterday that you may start working on a different project13:39
gatoxalecu, ahhhhh ok13:39
alecugatox: that's why I said I might be working on fixing that.13:39
gatoxohhh i miss the meeting.....13:40
briancurtindobey: i haven't gotten to that one. i'll take a look today (but i'll be gone for a while in the morning through late afternoon)13:40
ralsinagatox: yes, I am planning on switching you to the menu/indicator thing starting next week13:40
gatoxanyone know what i'm going to be doing? :P13:40
briancurtins/late/mid13:40
alecugatox: you are being moved to work on the u1 port to VMS.13:40
gatoxralsina, ohhhhh great!! \o/13:40
gatoxalecu, haah13:40
alecugatox: or was it OS/2?13:40
gatoxralsina, cool!13:40
ralsinagatox: see ⟰13:40
dobeypython 413:40
ralsinadobey: writing it!13:41
* ralsina liked VMS. Sniff.13:41
dobeyit's the version of python where guido hits senility, and it's more like brainfuck than python13:41
gatoxalecu, ok..... so..... if you are going to do that..... i think this is ready for review: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/darwin-tests-refactoring/+merge/113289 (about the comments: we already talk about the assert_logs removal, and i removed the unnecesary setUp for TestNotifyProcessor)13:42
alecugatox: ack13:43
alecudobey: I'm running the tests for ~dobey/dirspec/python3, and I'm getting an error when running the python2 tests on Precise.13:49
alecudobey: should I be running them on quantal?13:49
dobeyalecu: python2 or python3?13:50
dobeyalecu: the tests are passing for me on precise13:52
=== teknico_ is now known as teknico
alecudobey: I'm getting these errors when running on precise: http://pastebin.ubuntu.com/1089886/14:02
alecudobey: I'm updating to see if I had something really old.14:02
dobeyalecu: there is a testools in the nightlies PPA, that is needed14:06
dobeyalecu: and you'll need python3-setuptools and python3-testtools14:08
dobeyupdated the description about that14:11
mandelgatox, shoot14:14
mandeldobey, yes, there was some code moves and turns out to be bigger than expected14:15
mandeldobey, is mainly a copy paste to a diff module to be honest14:15
gatoxmandel, i'm seeing some lines that shouldn't be there because are changes from trunk..... or am i missing something?14:15
dobeybzr mv didn't work? :)14:15
gatoxmandel, for example: class TestWatchManager(BaseTwistedTestCase):14:16
gatox77+ """Test the watch manager."""14:16
gatoxand the tests in there14:16
mandeldobey, no because it was not the entiry module :(14:16
mandelgatox, which line of the diff?14:16
ralsinadobey: how do you feel about uploading dirspec to pypi.python.org eventually14:16
dobeyralsina: "eventually" sounds fine. perhaps with the release on monday14:17
gatoxmandel, 76.... also.....  test_stop_multiple has no longer that implementation, we remove the time.sleep14:17
mandelgatox, hm.. there was probably a miss merge somewhere..14:17
* mandel hates having so many branches..14:18
ralsinadobey: yes, after release is ok14:18
mandelgatox, let me remerge and see what can be fixed14:18
alecudobey: I've updated everything, installed python3-testtools, but I still get that error in python 2, and now the same error with python 314:18
gatoxmandel, ack14:18
dobeyalecu: weird14:19
dobeyalecu: what does "ls -lhd ~/.config/x" show?14:24
briancurtingoing to do my apartment thing, back hopefully soon14:24
dobeyalecu: seems like you have a file or directory at ~/.config/x14:25
dobeyalecu: indeed, if i touch ~/.config/x, the test then fails14:26
dobeywonder how you got that file :)14:26
dobeyanyway, need to run an errand. brb14:26
mandelgatox, branch updated14:41
gatoxmandel, ack14:41
mandelgatox, he, the diff lost 500 lines :)14:44
gatox:P14:44
mandelgatox, nad if the bzr mv had worked the diff would be smaller..14:45
gatoxmmcc, ping14:57
mmccgatox pong14:57
gatoxmmcc, i put a need fixing here: https://code.launchpad.net/~mikemc/ubuntuone-client/use-dirspec-get-cmdline/+merge/114720 because that lint error is causing problems to run the tests on linux14:58
mmccgatox, ok thanks. wonder why that didn't show up when I ran them :\14:59
mandelme15:00
gatoxme15:00
mmccme15:00
dobeymeh15:00
ralsiname15:01
ralsinaalecu, thisfred: standup15:03
thisfredne15:03
ralsinabrian is away for a bit15:03
thisfredme15:03
alecume15:03
ralsinaso alecu is last, go mandel15:03
mandelDONE: Proposed fsevents daemon code for u1-client. Added a new branch that removes cicle imports from the NotifyProcessor code. Added a new command line arg just for darwin.15:03
mandelTODO: Split file system monitor for better import. Propose the branches. Be done with fsevents, although if gatox is moved there are a number of bugs that should be assigned to me next week regarding fsevents :(15:03
mandelBLOCKED: no15:03
mandelgatox, please15:03
gatoxDONE:15:04
gatoxTake the day off yesterday to reload the health battery. Reviews, small fix in tests-refactoring (NEED REVIEWS FOR THIS). Sent email to ralsina, alecu and lisette about the file publisher in the indicator menu, start reading the syncmenu wiki and X platform desktop indicator menus document.15:04
gatoxTODO:15:04
gatoxFinish with those documents. Keep reviewing branches and fixing fsevents related bugs.15:04
gatoxBLOCKED:15:04
gatoxNo15:04
gatoxmmcc, go15:04
mmccDONE: finished path finding, hacked on setup-mac15:04
mmccTODO: cleanup u1client branch, more setup-mac, reduce package size15:04
mmccBLCK:15:04
mmccNEXT: dobeh15:04
dobeyDONE: team call, bug #1024003, bug #1016224, backported quantal software-center to nightlies to unbreak packages from sso-gtk removal15:04
ubot5Launchpad bug 1024003 in dirspec (Ubuntu Quantal) "Unnecessarily requires twisted trial for running tests" [Undecided,Triaged] https://launchpad.net/bugs/102400315:04
dobeyTODO: reviews, investigate twisted-less dev-tools, work on some reorg to drop ubuntuone-installer for good, SRU verification poking15:04
ubot5Launchpad bug 1016224 in dirspec trunk "Does not work with Python 3.x" [Undecided,In progress] https://launchpad.net/bugs/101622415:04
dobeyBLCK: None.15:04
dobeyralsina15:04
ralsinaDONE: team call, reviews, VM haggling, talked a lot with lisette, contractor wrangling, some reviews, little coding TODO: more of the same,  try to debug lists on quantal BLOCKED: coughing a whole lot.  NOTE: mandel, we can delay gatox's switch a couple of days more if needed NEXT thisfred15:04
thisfredDONE: worry about txids in u1db TODO: write better integration tests that do the worrying for me BLOCKED: no, but I could use a few clones or a time machine NEXT: alecu15:04
gatoxmandel, i've right now 2 issues related to non-root fsevents, do you have any other in mind?15:06
* alecu is writting notes15:06
alecuDONE: many reviews, 1-1 and team meetings, rebuilt my broken thunderbird setup15:08
alecuTODO: catch up with briancurtin and py3k15:08
alecuBLOCKED: no15:08
dobeyEOM?15:10
alecuNEXT: briancurtin (when he returns)15:10
dobeyalecu: did you see my replies about my branch and the failing test?15:11
alecudobey: yes, I've just ran the tests after deleting .config/x, and all tests passed.15:11
dobeyah ok15:11
alecudobey: are we going to use "from __future__ import unicode_literals, print_function" in a given module even though we don't use print there?15:13
alecudobey: I think it's a good convention, so +1 to i.15:13
alecuit15:13
dobeyalecu: i think we should, in case anyone adds a print it will complain even on python215:14
dobeyit's good to keep the code from regressing in that syntax15:14
alecuyup15:15
mmccgatox, mandel - darwin4-fsevents doesn't fix the tests, right? just checking if I should be expecting passes15:15
dobeymmcc: i guess according to jenkins, it doesn't15:16
gatoxmmcc, all the tests inside filesystem_notifications15:16
mandeldobey, that is windows work that was broken by someone else. I have it in my radar to fix it asap15:17
mandeldobey,  or pass the ball ;)15:17
dobeyok, well fix it :)15:17
mmccalright.15:18
mandeldobey, yes yes I will but I need longer days hehe15:18
dobeyheh15:18
mmccdobey, regarding your comment about adding ubuntuone/utils.py - I'm glad you noticed. I was going to ask for specific feedback on that in the MP but forgot. I really didn't know where to put it, but I guess syncdaemon/utils.py would work, as long as there aren't any circular imports created...15:24
dobeywell, the circular imports would exist regardless of where it lives, if there are any. that's a separate problem to where the module itself lives15:25
alecudobey: in assert_utf8_bytes the value.decode(...) was changed to value.encode(...). I can't understand why that change makes sense.15:26
dobeyalecu: python3 doesn't have decode on the data type that value is; only encode15:26
mmccdobey, I meant because utils is used in platform/tools and platform/ipc, which are imported by syncdaemon, so if I move utils into syncdaemon, then platform <---imports--> syncdaemon, but i think it'll work out anyway15:27
alecudobey: in assert_utf8_bytes, value should be a sequence of bytes, so it only has "decode", not encode.15:27
dobeymmcc: ah, but syncdaemon.utils itself doesn't import those, so it's not circular. also i think we should move all the other code to be under syncdaemon at some point as well15:28
alecudobey: also unicode_path() has the same issue.15:29
dobeyalecu: i think that was broken before then15:29
mmccdobey: righto - it's ok as long as syncdaemon.__init__ doesn't import them. which it doesn't. and I agree, someone ought to do that. maybe when manuel gets his longer days or borrows eric's time machine15:30
thisfredMINE15:30
mandelthis one I have to share because is just funny, the spanish government just defined funerals as 'entertainment' to increase the VAT on them.. hehehe15:32
dobeyalecu: happy to fix it to be the other way around, but not sure exactly how to do that at the moment.15:33
dobeyand i need to get lunch15:33
alecumandel: that's a killer tax!15:34
mandelalecu, lol15:34
mandeldobey, which all other code?15:36
dobeykiller party man!15:37
dobeymandel: everything under ubuntuone/ in ubuntuone-client, which is not already under ubuntuone/syncdaemon/15:37
dobeymandel: don't worry about it though15:38
mandeldobey, you mean getting out of platform and moving it to syncdaemon?15:38
mandeldobey, it does make sense because it is a lot cleaner know, is a matter of getting time like mmcc said :)15:38
mandeldobey, I'm had that in my mind for some time15:38
dobeymandel: i mean, i really haven't thought about how to do it exactly yet, but it seems like everything should be under there, that is in ubuntuone-client15:38
dobeyanywya15:39
dobeyneed to get lunch15:39
dobeybbiab :)15:39
gatoxlunch for me!15:52
=== gatox is now known as gatox_lunch
mandelgatox_lunch, ralsina ping!16:10
ralsinamandel: pong16:10
mandelralsina, can you run the windows tests from trunk and let me know if all but one pass?16:11
ralsinamandel: not right now16:11
ralsinamandel: that was the case last week16:11
mandelralsina, i have some timeout failures but it might well be that I have a slow machine..16:11
ralsinamandel: jenkins seems to say that's still true16:11
mandelok16:12
mmccmandel, which windows tests? u1-client?16:13
mandelmmcc, yes16:14
mmccmandel, I am about to run those, I'll let you know. it was the case yesterday - only one failure, having to do with unicode paths16:14
mandelmmcc, awesome, please let me know16:15
mmccreally would it have killed them to make 'cd E:\' work like it does everywhere else?16:17
mandelmmcc, probably the did it so support some old dos program..16:18
mmccwell, I get the *reason* - it's that E: is a 'drive' not a 'directory', and they're really different things, but seriously.16:18
mmccand the fact that the right way is just to type the drive name with no command? who came up with that16:19
mmcc</rant>16:19
mmccand for some reason python.exe wasn't on my path anymore? winDOOOWSS!16:25
* mmcc shakes fist16:25
briancurtinugh, 2 hours and only saw one apartment. at least it was a decent place16:27
=== gatox_lunch is now known as gatox
gatoxmandel, pong16:31
mandelgatox, I was going to ask you to run the windows tests but mmcc is on that :)16:31
gatoxok!16:31
mandelgatox, I have an other branch for review, is refactoring and some tiny changes but since there is no bzr mv --line 22-50 the diff looks bigger than the number of changes16:32
mandelgatox, is https://code.launchpad.net/~mandel/ubuntuone-client/unify-processors/+merge/11490616:32
gatoxmandel, ok..... i'll finish with the reviews no16:33
gatoxnow16:33
mandelgatox, haha I though you said no :P16:35
mandelgatox, I imagined you as joda hahaha16:35
gatoxjaajajaj16:36
gatoxLOL16:36
gatoxmandel, also.... i need your review here: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/darwin-tests-refactoring/+merge/11328916:39
mandelgatox, we are the masters of the large reviews lol16:40
dobeyhmm16:40
gatoxmandel, jejeje it's a valuable skill jeje16:41
mandelgatox, so that branch, just changes the darwin tests, is that right?16:41
gatoxmandel, no.... windows too...... move all the common code to common.py16:41
gatoxdoesn't add or remove anything.... just move things16:42
mmccgatox, dobey reviews requested for this guy: https://code.launchpad.net/~mikemc/ubuntuone-windows-installer/setup-mac-add-sd/+merge/11474916:42
gatoxwell...... it removes repeated code, but you know what i mean16:42
gatoxmmcc, ack16:42
gatoxmmcc, let me know when you fix the other one16:42
mmccgatox, ok, a couple minutes. made larger changes due to dobey's comments, testing on win/linux now16:43
gatoxmmcc, ack16:43
mandelgatox, ack16:43
mandelgatox, it will have conflicts with mine.. but I'll fix those later :)16:44
mmccdoes everyone just always set TRIAL_TEMP_DIR to something short on windows, or am I the only unlucky one with long paths to branches? should we just set it in env.bat?16:44
gatoxmandel, yes, your turn to fix now!16:44
mandelmmcc, we all set trial_temp_dir, that was the reason we added it :)16:45
mmccmandel, right but do you set it manually or what16:45
mandelmmcc, you can set it as env var for windows16:46
mandelmmcc, look for environment variable in the control center on windows 7 and will show you where to add it16:46
mmccmandel, ok that's what I was looking for, thanks.16:47
mandelnp16:47
mandelgatox, needs fixing, lint issue!16:52
gatoxbloody hell16:52
mandelgatox, lol16:53
dobeyheh16:55
mandelfu**, my income taxes just went up 140%.. hijos de la gran pu..17:01
* mandel looks for a shot-gun to go to the demonstration17:02
mmccmandel, ouch17:03
mmccmandel, before you go to the revolution, I'm sure you'll want to know that u1client trunk still has just that one windows failing test.17:03
mandelmmcc, yes, in a single day.. also VAT went up 160%17:03
mmccmandel, also http://paste.ubuntu.com/1090200/17:03
mandelmmcc, awesome, so is my slow vm :)17:03
dobeyugh17:04
mmccmandel, how slow? mine's awfully slow too - note the 617 seconds those tests take17:04
mandelmmcc, slower.. I need to see what is wrong with the setup17:04
mmccmandel, press the turbo button on the front of your minitower17:05
dobeypython standard lib is so… conflicted17:05
mandelhahs and the social security tax went up a 250%!!!17:07
mandelmmcc, lol I loved those turbo buttons :)17:07
* ralsina suspects mandel needs a refresher in percentages17:11
ralsinaas in: going from 10 to 14 is not a 140% raise17:11
mandelralsina, some things have gone in the VAT from 8% to 21% which is a 160% and all the other changes are the same (smaller diff)17:15
ralsinamandel: he, here's 21% for everything. Ecept phones, there's 37.5%17:16
mandelralsina, then I'm move from a 18% to a 21% plus an extra 21% on top of that one + social secury has gone from around 100 eur to 35017:16
mandelralsina, but did they increase it in a single day? oh, while they have 30.000 million eurs to the banks...17:17
mandels/have/gave17:17
ralsinasee? plenty of money there! ;-)17:18
dobeywelcome to america17:18
dobeyonly 350eur for social security? Man, our republican conservatives would love to live in Spain I bet!17:19
mandeldobey, well, most of madrid is on strikes round now blocking streets etc..17:20
mmccdobey, I bet they wouldn't: http://en.wikipedia.org/wiki/Spanish_National_Health_System17:20
dobeymandel: good thing i didn't take a holiday to madrid then17:21
mandelmmcc, yes, we are waaaay to the left17:22
mandeldobey, never know, might be fun, did you see the video of the miners?17:22
ralsinadobey: we need to package pyasn1 for python3 for Q sometime in the next few weeks, to upload to main17:23
mmccok folks, lunchtime for me, u1 client path branch tests are running now, I'll check in and ping for a re review in a few mintues17:23
mmccor minweds, minthurs , you know, whenever17:23
dobeyralsina: huh?17:23
ralsinadobey: missing dependency for twisted pythn317:24
dobeyoh, twisted.conch uses it apparently17:24
ralsinadobey: yep17:25
ralsinadobey: forget about it, barry will do it17:25
dobeyok17:25
mmccuh, linux u1-client tests failed with this error I don't recognize, in filesystem_notifications:  http://paste.ubuntu.com/1090236  anyone recognize?17:27
* mmcc lunchtime for real17:27
=== salgado is now known as salgado-lunch
dobeyos.path methods do not return bytes :(17:31
ralsinadobey: they should if they get bytes17:31
gatoxdobey, python3?17:31
dobeygatox: both 2 and 317:40
gatoxdobey, for python3 i don't know..... but for 2 it should be as ralsina says17:40
ralsinafor python3 it's the same thing17:41
ralsinaif you give it bytes you get bytes17:41
ralsinadobey: what specific function?17:41
mandelok, eod for me17:51
mandelsee you all on monday!17:51
gatoxmandel, bye17:54
gatoxmandel, also.... lint issue fixed here: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/darwin-tests-refactoring/+merge/11328917:54
gatoxand +1 to your branch... the one with the 1500 lines diff17:54
dobeyralsina: some methods only accept strings (like os.path.join)17:57
ralsinadobey: nope17:57
gatoxdobey,17:58
gatox>>> os.path.join(u'asd', 'foo')17:58
gatoxu'asd/foo'17:58
ralsinadobey: https://pastebin.canonical.com/70055/17:58
gatoxralsina, we are really creative with the examples :P17:58
briancurtinos.path.join(b"C:\\lol", "rofl".encode("utf8"))17:59
ralsinadobey, gatox: however, it's a bad idea to pass one unicode and one bytes because there will be an implicit str.decode(ascii) there somewhere17:59
ralsinabriancurtin: "rofl".encode("utf8") is just evil :-)17:59
ralsinaunless it's python 3 of course17:59
briancurtinbut you can do it!17:59
briancurtinjust to add to the examples18:00
ralsinayou can also put ketchup on fries. Doesn't mean it's right ;-)18:00
briancurtinsriracha goes on fries18:00
gatoxyou have my attention18:00
ralsina+1 on sriracha on fries -1 on encoding bytes ;-)18:00
gatoxwhat sriracha is?18:00
ralsinagatox: hot sauce18:00
gatoxahhh18:00
briancurtinit's like a hot ketchup. more of a paste-like thing than liquidy hot sauce18:01
gatoxalso...... cheddar (melt) with fries..... it's awesome!18:01
dobey'r'.encode().decode().encode().encode().decode()18:01
gatoxcheddar cheese18:01
dobeypython2 is fun!18:01
dobeyi guess dirspec should enforce bytes everywhere though18:01
dobeybeing a file path thing18:01
dobeyalecu, ralsina, briancurtin: does that sound right?18:02
=== salgado-lunch is now known as salgado
alecudobey: "should enforce bytes" <- I agree for python 2. I'm still not sure it's the proper api for python 3 libraries, but since we'll be using it mostly from u1, bytes on python 3 sounds right.18:08
ralsinadobey, alecu: whatever, as long as it's consistent18:09
dobeyalecu: well, filesystem paths are bytes. and it's basically impossible to enforce bytes on one version and strings on another. either we enforce unicode strings everywhere, or bytes everywhere18:11
ralsinaon py3 where there's no automatic conversion, ad thus no risk of mixing them up, it doesn't matter as much18:11
dobeypreviously, the code was doing a mix, which is why this diff is a bit large18:11
alecudobey: "filesystem paths are bytes" only on linux.18:11
alecubut yes, and bytes everywhere sounds good for our usecase.18:12
dobeyalecu: they're bytes everywhere. on windows they're just a much smaller subset of possible bytes, and it's easier to get a reliable encoding for the bytes they're in :)18:12
dobeyok18:13
dobeyi don't care either way, but we have to enforce either bytes or unicode strings, and not dilly dally somewhere in the middle :)18:14
dobeyalecu: https://code.launchpad.net/~dobey/dirspec/python3/+merge/114713 is updated and changes stuff to be bytes everywhere18:18
dobeygatox: ^^ if you could please review that too18:20
gatoxdobey, ack18:20
* briancurtin lunch + doctor run18:31
ralsinaoh, lunch sounds like a cool concept18:36
* ralsina investigates 18:36
dobeyralsina: given the temperature there, maybe you should eat a hot lunch18:37
gatoxdobey, i'm getting this running the tests for dirspec-python3 http://paste.ubuntu.com/1090342/18:40
gatoxdo you know what i'm missing?18:41
gatoxi have python3-(testtools|setuptools)18:41
mmccso did anyone recognize this: http://paste.ubuntu.com/1090236 test_zip_release_lock_compression_error failing on linux?18:43
dobeygatox: do you have python-testtools installed? that's python 2.7 that's failing there18:46
dobeymmcc: i've seen it a couple times now, but not sure why it happens18:47
dobeymmcc: i'm tempted to add a skip for that test and file a bug if it keeps happening (and a bug isn't already filed)18:47
mmccoh, it's intermittent? I"ll rerun and see if I see it again...18:47
gatoxdobey, i have it for python3 but not for 2 :P18:48
dobeymmcc: yeah; it might be system load related too, not sure18:49
mmccdobey: interesting. that'd make sense. this was the first time I'd tried running the tests in both VMs at once on this poor old mac mini18:50
dobeyah18:50
gatoxdobey, +1 https://code.launchpad.net/~dobey/dirspec/python3/+merge/11471318:50
dobeygatox: thanks. though i just realized, i bet the tests are broken on mac/win now :)18:51
dobeyactually, no. windows is still using trial18:52
dobeyforgot about that18:52
mmccok, tests finally finished. dobey, gatox: can you revisit your reviews here: https://code.launchpad.net/~mikemc/ubuntuone-client/use-dirspec-get-cmdline/+merge/11472018:59
dobeygatox, alecu: can you also run the python3 branch tests on osx and/or win now? i've now updated the run-tests and run-tests.bat19:00
gatoxmmcc, i'm on that right now19:01
gatoxdobey, ok.... but it might take a while... i need to install python3 and stuff con win/mac19:02
dobeygatox: no you don't need to install python3 there19:02
gatoxah just run the tests....19:02
dobeygatox: we aren't using python3 on win/mac. i've updated the run-tests to only run the python3 tests when it's available now19:02
dobeygatox: but need to make sure the tests aren't broken on those platforms under python219:03
dobeygatox: and i'm not sure if the way i changed the run-tests.bat for windows is correct to run the setup.py build test clean19:03
ralsinapython3 u1 for mac/win is a post ROFLing Rhino release thing19:03
dobeyyou might need to install setuptools/testtools though if they aren't already there19:04
dobeyand i guess we will need to update the buildout to include them if they aren't being included already19:04
gatoxdobey, yep.... i need to install that19:05
mmccdobey or gatox, trivial merge: https://code.launchpad.net/~mikemc/ubuntuone-windows-installer/fix-1024518/+merge/11492419:06
gatoxmmcc, looking after dobey 's19:06
dobeymmcc: +119:08
mmccthx19:08
gatoxdobey, i have 3 failures on windows for your branch19:10
gatoxdobey, should i change it to need fixing?19:10
dobeygatox: i guess so :P19:10
gatoxmmcc, +1 and globally approve19:11
gatoxdobey, i'll copy the trace there19:11
gatoxdobey, there: https://code.launchpad.net/~dobey/dirspec/python3/+merge/11471319:12
alecukindertime!19:12
dobeygatox: ah, thanks. i wonder if these are broken in trunk already too :)19:13
gatoxalecu, have fun playing with the other kids! :P19:14
dobeygatox: those tests should be fixed on windows now in r1419:20
gatoxdobey, ack.... checking19:21
gatoxdobey everything is fine on windows, but i'm trying to run the tests on mac and it seems that is trying to use distutils instead of testtools.... so i'm taking a look at that19:38
dobeyinstead of setuptools?19:40
dobeyhmm19:41
gatoxwhen it does: python setup.py build test....... it can't recognize "test" command19:42
dobeyhmm19:43
dobeysounds like you're missing setuptools19:43
dobeygatox: is it running system python instead of buildout python? or did you install setuptools into the wrong place?19:44
gatoxi've setuptools installed in the system, and i was trying to run the tests with the system python....... should i use the buildout one?19:46
dobeyi don't know. i presume you should use the buildout one19:47
dobeybut i have to run right now19:47
dobeybrb19:47
gatoxdobey, yes, using the python from the buildout works, approving branch19:52
ralsinaI think I just coughed a small piece of lung20:02
gatox:S20:02
* ralsina calls the cat to perform a quick field analysis20:02
ralsinaI better go lay down for a couple of days. Mail me if you need me.20:03
ralsinano, not lung. \o/20:03
gatoxralsina, roger that! get better!20:03
ralsinaSee you all on monday!20:03
gatoxralsina, bye20:04
mmccbye ralsina, feel better20:04
alecuthat sounds disgusting! get well, boss!20:05
gatoxand EOD for me!! see you on monday people....20:08
* gatox goes to play with QML20:08
mmccoh gatox, did I miss you? you had a really minor needs-fixing on https://code.launchpad.net/~mikemc/ubuntuone-client/use-dirspec-get-cmdline/+merge/114720 that I've fixed…20:13
mmccah, nevermind - enjoy your weekend :)20:15
gatoxmmcc, do you need it right now?? or can i do it later today or tomorrow morning?20:15
mmccgatox, do it on monday, have a great weekend!20:15
gatoxmmcc, ok then! see you20:15
dobeyhrmm20:30
dobeyneed another review20:31
dobeymmcc: want to do a review? :)20:37
mmccdobey, you bet your ass I do20:40
mmccI mean, yes20:40
dobeymmcc: https://code.launchpad.net/~dobey/dirspec/python3/+merge/11471320:40
mmccdobey, +1. and do you have time to revisit your needs-info on https://code.launchpad.net/~mikemc/ubuntu-sso-client/use-dirspec-get-program-path/+merge/114690 ? I agreed and did a little constant cleanup.21:09
mmccbut I could use a second opinion on something I noticed while doing that. in ubuntu_sso/__init__.py, we add '.exe' to two of the four exe names we might launch... I'm not sure why it's only those two, and I think the changes I've made might now result in .exe.exe in those cases21:10
dobeyhrmm21:11
mmccI'm going to try to build the exe on windows and test it...21:11
mmccis briancurtin still around? I'm wondering how to get debug logging set and where to look for logs when I run the packaged thing on windows21:12
dobeymmcc: i guess that probably needs to be removed, and the '.exe' needs to be added in the get_bin_cmd() wrapper?21:12
mmccdobey, it's there in the wrapper already21:12
mmccer, it's in dirspec I mean21:12
dobeymmcc: ah, then i'd remove it from the __init__.py there21:13
dobeyit also looks weird and out of place in that location anyway21:13
mmcc_get_exe_path_frozen_win32 does it now21:13
dobeyah right21:13
dobeyyeah, remove that from sso then21:13
mmccwow so much rain this week. poor grass thinks it can start growing again21:18
dobeyyeah, i need to cut my weeds21:19
dobeyand i need to go now21:19
dobeymmcc: remove that + '.exe' bit from sso, and i'll re-review later21:19
dobeyhave a good weekend :)21:20
briancurtinmmcc: to get debug logging you set U1_DEBUG=True as an environment variable. at least for syncdaemon you need to additionally run it with the --debug flag21:21
briancurtinmmcc: i'll get the log path21:21
briancurtinmmcc: C:\Users\brian\AppData\Local\xdg\cache\ubuntuone\log is where my logs end up21:21
mmccthanks briancurtin21:21
mmcclooks like I need to install intltool? briancurtin is that supposed to be in the buildout , or do I install it somewhere else/21:36
mmcc?21:36
briancurtinmmcc: you don't need that. i guess at some point we should remove whatever causes that error message to come up. ive never had it21:36
mmccbriancurtin: so you just ignore it and continue?21:48
briancurtinyep21:48
mmcc(sorry, stepped away for a minute to rescue a lawn ornament from the deluge. that's right, a metal rooster)21:48
briancurtini forget where it even comes up, but yeah, not needed21:48
mmccit tries to run intltool-update as part of setup.py prepare21:49
briancurtinah yes21:49
mmccunless you're talking about the rooster, which is for real absolutely needed.21:49
mmcchrm, seems like it died in py2exe - http://paste.ubuntu.com/1090611 - I say seems because the error text is "The operation completed successfully" ?!21:53
briancurtinah crap. i have no idea why that happens...i lost a lot of time to that, and i still dont get it. what i had to do was remove py2exe from the buildout setup, install py2exe for the system python in C:\Python27, then it worked21:54
briancurtinthat didn't used to happen, and i have no explaination for why it started happening21:55
mmccok, I'll go do that. thanks. should I add a note about this to the wiki page, or somewhere else?21:56
mmccalso, should I get the latest from the website or install the same version as the egg in the buildout?21:59
mmccnevermind, same version21:59
briancurtinmmcc: maybe add a note, but i'd like to actually figure it out at some point, before anyone else has to setup another environment22:03
briancurtinmmcc: there's also a patch you need to apply to py2exe if you're going to be building the binaries and potentially the installers. well, there's no patch, but i can tell you what exactly to change22:04
mmccok, shoot22:04
briancurtinin C:\Python27\Lib\site-packages\py2exe\boot_common.py22:04
briancurtininside that sys.frozen block starting at ~line 45, remove whatever that big class is near the top and just make it look like this https://pastebin.canonical.com/70082/22:05
mmccok, will do.22:06
briancurtinsys.stderr should be set to a Blackhole, which renders whatever that other class is irrelevant22:06
mmccbriancurtin: if you're still around, I've got built .exe's but should I be able to just run them from dist? I'm getting an importerror for pkg_resources trying to run control-panel22:34
briancurtinyeah you should just be able to run from dist. what's the exact ImportError you're getting?22:35
mmccno module named pkg_resources22:35
mmccI'm just running ubuntuone-control-panel-qt.exe with no args22:36
briancurtinhmm, that's a part of distribute22:37
briancurtin>>> pkg_resources22:37
briancurtin<module 'pkg_resources' from 'c:\Python27\lib\site-packages\distribute-0.6.25-py2.7.egg\pkg_resources.pyc'>22:37
briancurtinwhen you just open a python prompt and do the same, do you have pkg_resources, and if so where?22:37
mmccbriancurtin: http://paste.ubuntu.com/109067522:40
mmccah, shoot, I have to run for dinner - if that makes sense, let me know and I'll give another try later. have a great weekend!22:41
briancurtinmmcc: maybe try installing distribute for your site-wide python, then remove the egg path from bin/python-script.py so it uses the system one, then regenerate the binaries22:41
briancurtini think its a similar thing to the py2exe problem22:41
briancurtinhave a good weekend man22:41

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!