[08:18] <mgz> morning
[08:19] <jelmer> sup mgz
[19:58] <rafaelmartins> hi all. supposing that I have a repo 'X', published at lp, and a clone 'Y' of it, hosted on my own infra. I add a tag 'foo' to Y, and want to push some changes I did at 'Y' to 'X', is it possible to leave the 'foo' tag local to 'Y', without get it propagated to 'X'?
[20:01] <jelmer> rafaelmartins: not really, at least not with the bzr cli
[20:04] <rafaelmartins> jelmer, too bad. there's another way though?
[20:04] <jelmer> rafaelmartins: you could probably script something using the Python API
[20:04] <rafaelmartins> hmm
[20:05] <rafaelmartins> thanks for the info, jelmer
[20:12] <ccxCZ> how do I check in a script if there are any changes in a working tree?
[20:13] <ccxCZ> something better than [[ $(bzr stat -VS | wc -l) -gt 1 ]] possibly?
[20:14] <jelmer> ccxCZ: IIRC the exit code of 'bzr status' also changes if there are modifications in the working tree
[20:16] <ccxCZ> doesn't seem so
[20:28] <trkv> Hi all, can anoyone help me with bzr api, please?
[20:28] <jelmer> ccxCZ: I guess checking the output of 'bzr status' or 'bzr diff' is the safest bet in that case
[20:28] <ccxCZ> yeah, I went for [[ -n "$( bzr stat -SV)" ]] in the end
[20:28] <jelmer> ccxCZ: another option is running
[20:28] <jelmer> ccxCZ:  bzr version-info --check-clean | grep "clean: True"
[20:29] <jelmer> hi trkv
[20:29] <trkv> hi
[20:29] <jelmer> trkv: what's your question? perhaps somebody here can help
[20:30] <trkv> I want to write a plugin storing some info in the branch metadata during the commit (i.e. store one string with each commit)
[20:31] <trkv> however looking to the info about hooks I see that I shouldn't modify future_tree or tree_delta during the pre_commit hook
[20:31] <trkv> and I'm unsure how to modify the commit at the post_commit hook
[20:32] <jelmer> trkv: you can't modify the tree during pre_commit, but you can modify it during start_commit
[20:32] <jelmer> trkv: the branch and commit metadata is also not a part of the tree
[20:34] <trkv> hm, so what should I do at start_commit stage? I thought there should be available modifiable Commit object at some moment :)
[20:36] <jelmer> you can modify the tree in the start_commit stage I think
[20:44] <trkv> jelmer: I've just looked at MutableTree and still have no idea how to access current commit from it :(
[20:51] <jelmer> trkv: What do you mean with the current commit?
[20:52] <trkv> the commit I'm going to perform
[20:59] <jelmer> trkv: there is no information about the current commit in start_commit
[20:59] <jelmer> only during pre_commit
[21:02] <trkv> and during pre_commit I can't modify info... deadend >.<
[21:03] <jelmer> trkv: during pre_commit you can't modify the tree, but you can modify the commit or branch metadata
[21:05] <Noldorin> jelmer: hey there. what does bzr-bookmarks do, may i ask?
[21:06] <Noldorin> i didn't find any real description online...
[21:10] <jelmer> Noldorin: I think it provides shortcuts for URLs
[21:10] <Noldorin> jelmer: oh it said you were the co-ordinator on lp :)
[21:10] <jelmer> hello nz
[21:11] <jelmer> Noldorin: huh, where does it say that?
[21:11] <Noldorin> jelmer: sorry, i mean "top contributor" https://launchpad.net/bzr-bookmarks
[21:11] <jelmer> Noldorin: ah, that's probably just because I triaged bugs
[21:11] <Noldorin> i did not check, just assumed you were involved heh
[21:11] <Noldorin> ah okay
[21:11] <Noldorin> fair enough
[22:00] <trkv> jelmer: It seems that when i modify local.repository.get_revision(future_revid).properties in pre_commit hook, nothing changes actually. Is it real to save my changes at that moment?
[22:01] <jelmer> trkv: right, you need to change the properties of the Commit object
[22:02] <jelmer> trkv: You shouldn't be able to make that call btw, because the revision doesn't exist yet
[22:02] <trkv> oh, that was the first question I asked)
[22:02] <trkv> how to obtain Commit object at the pre_commit
[22:03] <jelmer> trkv: it should be one of the arguments to the hook
[22:03] <trkv> yep, but it isn't
[22:03] <trkv> (local, master, old_revno, old_revid, future_revno, future_revid, tree_delta, future_tree) are all the arguments
[22:04] <trkv> and tree_delta, future_tree shouldn't be modified
[22:04] <jelmer> ah, that actually happens after the commit is made but before the branch is updated
[22:04] <jelmer> trkv: you want the Commit pre_commit hook, not the Branch pre_commit hook
[22:05] <jelmer> hmm, except there is no such thing
[22:05] <jelmer> trkv: Sorry, I don't remember where this is exactly and I don't have time to dig deeper at the moment
[22:06] <trkv> ok, may be I can return and ask you tomorrow (or some day later if you have no time tomorrow)?)
[22:08] <jelmer> trkv: you might want to ask on the mailing list, where your question will reach a wider audience
[22:08] <jelmer> though I should also be around tomorrow during European working hours
[22:09] <trkv> ok, it's bazaar@l.c.o, yep?
[22:09] <jelmer> trkv: yep
[22:10] <trkv> thanks, I'll won't bother you anymore)
[22:10] <trkv> good night