[07:00] hey sil2100, how were your holidays? [07:02] didrocks: hello, thanks, not bad [07:02] Although very busy, so as always I didn't even start resting properly ;) [07:03] sil2100: yeah, that's the issue with one week vacations :) [07:06] sil2100: FYI, we have some unity regressions with unity 6.0 [07:06] sil2100: can you look at backporting the existing fixes? there is also those branches that I think we need (please investigate with duflu): [07:06] https://bugs.launchpad.net/compiz/+bug/1019337 [07:06] Ubuntu bug 1019337 in Compiz Core "gtk-window-decorator crashes with BadWindow (invalid Window parameter), from XGetWindowProperty() from get_frame_type()" [High,In progress] [07:07] https://code.launchpad.net/~vanvugt/compiz/fix-1019337.2/+merge/114597 [07:07] https://bugs.launchpad.net/unity/+bug/1024911 [07:07] Ubuntu bug 1024911 in unity "[regression] [unity 6.0] Fullscreen windows flicker and/or never redraw properly if panel_opacity<1.0 or dash is opened." [High,In progress] [07:07] and we need a fix for bug #1024459 [07:07] Launchpad bug 1024459 in unity "panel and launcher blinks when using libreoffice presenter/spreadsheet" [High,In progress] https://launchpad.net/bugs/1024459 [07:07] didrocks: thanks! Will look at those once I get up-to-date with e-mail [07:07] sil2100: also compiz gsettings isn't there yet [07:07] so we need it :) [07:07] didrocks: did the compiz release happen? [07:07] no [07:07] Mirv went on holidays before getting it done :( [07:08] so in priority order I would say: [07:08] Ouch, ok, we'll handle that then - but first the regressions I think? [07:08] - unity fixes backported and unity SDRU [07:08] yeah, in // with the SRU :) [07:08] check with duflu if he's working on the latest bugs [07:08] and ensure we really need the other merge fixes [07:09] and meanwhile look at remaining MR not review for 5.0 [07:09] reviewed* [07:09] sil2100: there are some emails on the PS ML about mandatory branches for the 5.0 unity SRU [07:09] Aye aye, yessir :) [07:09] so you can leverage both in parallel :) [07:09] sil2100: good luck and… welcome back \o/ [07:09] sil2100, also, the failure to merge https://code.launchpad.net/~mhr3/unity/update-core-preview-api/+merge/112756 needs to be looked at [07:09] sil2100, and hello :) [07:10] mhr3: hello ;) Ok, will look [07:10] Good to be back \o/ [07:10] "on the road again!" [07:11] road... to hell? :) [07:12] heh ;) [08:01] didrocks: Hi :) I would need your help x2 I guess. Do you have a minute ? [08:01] MCR1: yeah? [08:01] for your MR, we need tests :) [08:01] is the code style documented somewhere? any reason for method names starting with a upper case letter? seems uncommon. [08:01] didrocks: Do you mean the one with the compression ? [08:02] MCR1: well, for each new plugins :) [08:02] for compiz [08:02] for the compression, I don't think it's needed [08:02] just get some designer's feedback [08:03] didrocks: Why does this need designer feedback - I did not change one pixel ? [08:04] MCR1: to ensure that there is no visible change at all [08:04] seems that Cimi already tried what you did [08:04] and saw a difference [08:04] so I prefer they can reviewed, as seb told you on the MR :) [08:06] didrocks: I can guarantee that no difference is visible, but I also can understand that you do not want to trust all those binaries ;), that is why I suggested someone could reproduce it by simply installing trimage and dropping all pngs in there... [08:06] MCR1: yeah, please ensure you ping JohnLea when he's around or Cimi :) [08:07] didrocks: ok. [08:08] didrocks: Second question: I fixed a bitesize bug in font-manager: rn/font-manager/font-manager.fix-961034/+merge/114991 [08:08] sorry, https://code.launchpad.net/~mc-return/font-manager/font-manager.fix-961034/+merge/114991 [08:08] MCR1: oh nice! please subscribe the sponsoring team, so that today's patch pilot can look at it :) [08:09] didrocks: Is this the Font Manager Team ? [08:10] MCR1: no, I don't really know about upstream, I'm speaking about downstream here, as getting the patch into ubuntu :) [08:10] didrocks: So who should I add to the reviewers ? [08:12] MCR1: if you don't want to wait on upstream, please follow the ubuntu sponsorship process: https://wiki.ubuntu.com/Bugs/Patches [08:12] and https://wiki.ubuntu.com/Bugs/HowToFix [08:13] didrocks: Thanx for the links - will save them and study those :) [08:13] MCR1: yw ;) do not hesitate if you have any question! [08:47] JohnLea: hey, how are you? [08:54] seb128: hello! [08:54] sil2100, hey, how are you? had nice holidays? [08:56] seb128: busy ones, but nice, thanks - and how are you? [08:57] sil2100, I'm good thanks [08:59] seb128: I'm catching up on things right now - I saw an e-mail from Timo saying that some SRU (compiz? unity?) was in the process of being released [08:59] Did any SRU besides the lenses got released? [09:00] From the unity side? [09:00] sil2100, no [09:00] sil2100: it's not really, that's what I pinged you this morning [09:00] * didrocks wasn't explicit enough maybe, but did a full summary at 9AM [09:00] sil2100, there is a need to redo a compiz update over the previous SRU one, a regression was detected (decorator segfault) which duflu fixed since [09:00] seb128: already gave the full links this morning FYI :) [09:01] ok [09:01] sil2100, check what didrocks wrote to you I guess ;-) [09:01] bug lists, branches to merge [09:01] didrocks: ah, ok, since I just read an e-mail that stated that one of them was already pending for release, so I thought that at least something went in ;) [09:01] seb128: ok, just making sure - thanks! [09:01] sil2100: no, nothing since you last worked :( [09:01] yw! [09:01] welcome back to crazy unity world ;-) [09:02] sil2100: I think popey also have the information about what happened and can give them to you :) [09:02] didrocks, sil2100: the music lens SRU got in [09:02] well it's in the queue [09:02] so one thing happened :p [09:03] yeah, was mostly done when sil2100 was leaving as it's mostly the same than the release :p [09:10] sil2100: also for compiz, I gave a full list to Mirv about commits that I think we should backport (it's on the ML I guess) [09:14] I saw that e-mail indeed [09:34] hey guys o/ [09:35] i am just feeling a little excited. i just submitted my first merge proposal for a bitesize bug. https://bugs.launchpad.net/unity/+bug/937334 let me know how to improve on that. Thanks again. [09:35] Ubuntu bug 937334 in unity "Unity shortcut overlay needs to include shortcut for video lens" [Low,In progress] [09:36] jokerdino, hey, well done! [09:36] thanks. [09:36] didrocks; hyia [09:36] i wasn't sure how it actually works. so, thought I would try first and learn from mistakes. [09:37] hey JohnLea, how was your week-end? [09:37] didrocks; good but wet; summer here is terrible [09:37] didrocks; and yours? [09:37] jokerdino, can you do before,after screenshots? as commented on the bug that will need design input, see JohnLea's comment as well on the bug [09:38] oh sure. i have it. [09:38] jokerdino, adding a line will have an impact on the layout and size of the overlay [09:38] hm that's right. [09:38] but i couldn't see much obvious difference though [09:38] JohnLea: was nice, enjoyed the national fest, fireworks… avoiding the rain :) [09:39] jokerdino; thanks for looking at this, email the screenshot to john.lea@canonical.com [09:39] can you add them to the bug as well? [09:39] alright. will do both. [09:39] JohnLea: I wanted to have your input on bug #907464. I didn't think that design had to be involved as it really seem like a bug to me, but bilal asked for it :) [09:39] Launchpad bug 907464 in unity (Ubuntu) "top panel should not go over fullscreen window in multi-monitor case" [Undecided,Incomplete] https://launchpad.net/bugs/907464 [09:41] didrocks; I've updated the bug with all the correct statuses, bilal will now be happy ;-) You were right, but better safe than sorry [09:41] JohnLea: excellent! thanks :) [09:42] seb128, JohnLea: added; emailed [09:42] jokerdino, thanks [09:46] jokerdino; +1 from me, adding comment to this effect to the bug now. Thanks for fixing ;-) If you are ever looking for more bugs to fix ;-) , take a look at the list under the heading "Design changes signed off but not handed over" @ http://people.canonical.com/~platform/design/designer.html or [09:46] under heading "unity" @ http://people.canonical.com/~platform/design/upstream.html [09:47] will do more fixing in the future. thanks much for positive feedback :-D [09:48] jokerdino; np, ping me on IRC if you are looking at a bug and have any questions [09:49] sure sir. [10:03] JohnLea: I would need your help too, I guess: https://code.launchpad.net/~mc-return/unity/unity.merge-reduce-png-filesizes/+merge/110978 [10:28] MCR1; looking now [10:31] JohnLea: Thanks a lot. Unfortunately I have some more design decisions for you to make, just tell me when you are ready for those ;) [10:32] MCR1; as the assets will be visually unchanged by the proposed branch, no design signoff is needed. It's purely a technical decision, so I'll point you back to Seb128. For what it's worth it looks like a good change to me, but as it is not a user facing change it is outside of my remit [10:32] MCR1; what are the other questions, I'm ready ;-) [10:32] JohnLea: Oh that are many. Where should I start ? [10:33] MCR1; start with the changes that are closest to landing ;-) [10:34] JohnLea: Well, I would say that bug 1022743 is quite important. [10:34] Launchpad bug 1022743 in unity (Ubuntu) "Hardcoded Unity shortcuts create multiple Compiz problems" [Low,Confirmed] https://launchpad.net/bugs/1022743 [10:35] JohnLea: Imho the way Compiz/Unity share their shortcuts is currently very wrong creating multiple troubles. [10:36] MCR1; there is also the companion bug, https://bugs.launchpad.net/ayatana-design/+bug/775434 [10:36] Ubuntu bug 775434 in unity "Keyboard shortcut - Make Unity keyboard shortcuts configurable" [Medium,Triaged] [10:37] JohnLea: I did not see that one, but from the title I have to agree. :) [10:38] MCR1; I was just discussing moving one shortcut from CCSM to this panel with popey this morning. But really we want to get all the shortcuts defined in a single place, and almost all configurable. [10:38] JohnLea: This is imho one of the most important problems we have. It is also a problem with the type of shortcuts. [10:38] (the 'almost' bit of the above sentence refers to things like the SUPER key which we might want to make configurable because of the complexity of what is bound to it [10:39] ^ 'not want' I meant [10:40] MCR1; are you volunteering to have a look at fixing this ;-) If so the best way to start would be by pinging didrocks as he knows this area of code well, and will be ultimately responsible for accepting your patches [10:41] JohnLea: A big problem is the type of shortcuts as Compiz should know and control all keys, otherwise this creates multiple problems... [10:42] MCR1; yes, and the Compiz shortcuts should be exposed through the 'keyboard shortcuts' panel. [10:42] which is missing atm [10:43] JohnLea: Sure, I would like to fix that - and I think I would be capable to take a shot at it - I just need to find the commit, which transformed the Alt HUD key-shortcut from hardcoded to Compiz. [10:44] JohnLea: And then imitate that for all the other keys ;) [10:47] MCR1; there is *a lot* of special behaviour around both the SUPER and ALT key, so I would start by exposing all the other keys, and then get to these last. It might be that SUPER has to stay non-configurable, but the companion keys used with SUPER can be changed e.g SUPER+V could be changed to SUPER+Y, but not SHIFT+V. You should see what I mean when you look at the code. If we can get all the keys *other* than ALT and SUPER configurable and ex [10:47] posed in the 'keyboard shortcuts' overlay we will be doing well, and once that is done take a look at ALT [10:48] JohnLea: ALT is already configurable afaik [10:49] JohnLea: But I know what you mean - I am still in the process of trying to analyze all this code, but there is definitely room for improvements there [10:49] MCR1; cool, the more we can make configurable the better, perhaps it is just SUPER that will have to stay fixed in the first iteration of this improvement? [10:52] MCR1; basically the intent would be to make as many keyboard shortcuts as possible configurable and exposed in the keyboard shortcuts panel. Another tricky one might be 'Ctrl + Super + Cursor down' ( see https://docs.google.com/a/canonical.com/document/d/1jqeKtIJwqLtl58Wk_fqjr9Rrgxn9zsouCYOo-cZsLSE/edit?hl=en_GB ) which should perform different actions based on the state of the currently focused window. Not implemented yet, but I think it is on [10:52] didrock's todo list? [10:52] JohnLea: I am very glad that we agree 100% on this :) I will try my best to work on it, but I might need help of the guys who worked on that part of the code... [10:53] JohnLea: I already talked with smspillaz about that problem, I guess with some hints from him (when he is back) we can get things done 8-) [10:55] MCR1; while we are talking, one other thing that needs to be added to the compiz keyboard shortcuts is the ability to bind two different shortcuts to the same action. This would be very useful for supporting shortcuts that are depreciated or users are used to from other platforms in addition to the default shortcuts [10:57] MCR1; smspillaz will be away for another couple of weeks, didrocks is the person who should be able to help you out with any questions. [10:57] JohnLea: Compiz is already capable of doing two different actionswith the same shortcut. It will warn you, but allows to do that - but I like your "two different shortcuts to the same action" idea also very much :) [10:58] MCR1; cool ;-) I think there is some issue with the 'two different actions' because I asked smspillaz about it 2 or 3 months ago and he said it didn't work but would be easy to fix. [10:58] JohnLea: Ok, then I'll nerve him. I am very satisfied that you agree on those hardcoded hell, because that is one of the most important problems. [10:59] JohnLea: For smspillaz everything is easy to fix ;) [10:59] MCR1; I am very happy that you are taking a look at this, it is a bit of a neglected area in need of some rejuvenation. [11:00] JohnLea: He is a coding genius. Do not expect my coding qualities to be even near his level ;) [11:01] MCR1; as long as your coding qualities are of a sufficient level to get your code accepted by didrocks we are good ;-) [11:02] JohnLea: We'll see ;) [11:22] didrocks, one thing, I have just read that thread about accessibility always on on GNOME 3.6 [11:22] API: yeah? [11:22] fwiw, the port to the new atk-bridge library is [11:22] was proposed to be merge [11:22] I saw your branch, thanks :) [11:22] https://code.launchpad.net/~apinheiro/unity/a11y-a11y-always-on [11:23] ah ok [11:23] let's wait on upstream to look at it :) [11:23] it was about that, not sure if alex launi is stil reviewing unity branches [11:23] wait on upstream? === MacSlow is now known as MacSlow|lunch [11:23] API: btw, what's the actual status of a11y in unity? [11:23] API: well, the other dx guys ;) [11:23] API: is it full, what's missing, [11:23] didrocks, so it is ok on setting alex launi to review the branch? [11:23] didrocks, about the status [11:24] at this moment my old extra-a11y ppa is not required [11:24] API: no, just set the unity-team as reviewer [11:24] as all the branches get merged [11:24] didrocks, ok, will change the reviewer [11:24] API: so, is it fully accessible? [11:24] resuming a11y status [11:24] yep :) [11:24] I reviewed the status [11:24] launcher works [11:24] dash and alt+f2 also works (with some "buts") [11:25] alt+tab switcher changed a little since the last time I worked on that [11:25] so it would be required a review [11:25] panel service still works [11:25] so in summary, there are stuff working [11:25] but still room for improvement [11:25] API: so, it's usable for a daily usage in your opinion? [11:33] didrocks, sorry, adding a comment to the merge review and adding unity-team to the reviewer list [11:33] API: no worry ;) [11:33] well, unity is usable for a daily if no other option is available [11:33] but as I said, there are some "buts" and some new stuff since the last time I worked on that [11:33] ok, thanks for the status API :) [11:34] so I guess that using it daily will get people frustrated [11:34] as there are other options as xfce, gnome-shell, and still unity2d [11:35] API: possibly, yeah… [11:51] c [12:00] didrocks: so that you're up-to-date - I just built the new unity 6.0 regression fixes packages and will test those, and in the meantime I am also preparing MRQ branches for compiz SRU with some (most) of the commits you marked in your e-mail [12:25] sil2100: great great! :) [12:28] didrocks: some of the commits you pointed at are already merged into the 0.9.7 source branch btw. ;) [12:29] sil2100: great, but we aren't basing from the branch, isn't it? [12:29] sil2100: IIRC, you added patches manually? [12:30] didrocks: well, I was cherry-picking every fix that went into 0.9.7 branch earlier - not sure about now, since Timo was doing the patches last week [12:30] ok [12:31] Since it's not so easy as with the new packaging branches you made :( [12:31] sil2100: thanks for the notice :) [12:31] yeah [12:31] With the new one it's just a lazy bzr merge neede ;) [12:31] that's why now that upstream is in bzr, I switched to that :) [12:31] *needed [12:31] wasn't possible when they were in git :) === _salem is now known as salem_ [12:44] didrocks: btw. since I see that Timo ported as a distro-patch the fix for LP: #994841 [12:44] didrocks: I remember you said that it's not necessary before, since it's just related to tests? [12:49] sil2100: indeed, it's not necessary to us [12:50] didrocks: ok, so I remove it [12:50] thanks ;) === MacSlow|lunch is now known as MacSlow === zyga is now known as zyga-food [13:17] didrocks: regarding the compiz SRU, I'd like Sam to approve one MRQ before setting it to approved - since no one from the compiz team yet approved it, although they did comment that it seems ok [13:17] https://code.launchpad.net/~vanvugt/compiz/fix-1019337.2/+merge/114597 [13:17] And it's a very important branch [13:17] sil2100: sam isn't around for some weeks [13:17] sil2100: so you need to find someone else I'm afraid [13:18] the code is fine. However, I'm not sure it's fixing the issue [13:18] but this code can't harm [13:18] didrocks: the previous MRQ that went already in was supposed to fix it, this is a follow-up more or less [13:19] didrocks: you think I can approve it? [13:19] sil2100: yeah, I can only say the this code makes sense and can do no harm :) [13:19] so yeah, you can approve it I guess [13:19] Thanks \o/ [13:19] sil2100, didrocks: the bug points to a ppa and 3 users confirmed the ppa fixes the issue [13:19] not sure what commit Mirv's included in there though [13:19] but it's easy to check out [13:20] ok, good ;) [13:20] thanks seb128 [13:20] yw [13:20] sil2100: go on then ^ [13:21] seb128: I have the packaging branch, so I see that the 2 fixes in mention are in, so indeed [13:21] seb128: thanks for the notice! [13:21] didrocks, yw! [13:22] seb128: completion issue infected you now? :) [13:22] sil2100, yw! [13:22] didrocks, it seems so, though I can't blame mines on my IRC client ;-) [13:22] heh [13:24] 6.0 regression fixes in trunk, cherry-picking [13:27] didrocks: lp:~sil2100/unity/ubuntu_quantal_fixes [13:28] sil2100: sweet! already tested? [13:29] didrocks: for now I tested if the fixes work, but I can perform manual-tests or similar if needed [13:29] didrocks: should I create a doc for it as always and proceed with all the tests, or just this is sufficient? [13:30] sil2100: just create a small doc telling that the fixes work and you didn't notice any regression [13:30] sil2100: just do the tests that seems sensible to those fixes [13:31] didrocks: ACK! Proceeding with that in a moment though, I'll just finish some compiz bzr'ing [13:32] sure :) [13:32] sil2100: the branch looks good, I'm downgrading compiz (as I tested latest trunk) and rebuilding unity === zyga-food is now known as zyga-food] === zyga-food] is now known as zyga-food [13:51] didrocks: https://docs.google.com/a/canonical.com/document/d/1UsC-oNhBmxHTi-2caZHaZ3YiyUA5SR7IqofdoBhgjRc/edit# [13:52] sil2100: on a meeting, back afterwards :) [13:52] sil2100: it's running fine btw :) [13:52] didrocks: I also proposed some fixes and the .2 branch to lp:compiz-core/0.9.7 if anything [13:52] didrocks: so we should be ready for compiz SRU tomorrow \o/ [13:53] didrocks: good luck on the meeting [13:54] brb in a moment, storm === zyga-food is now known as zyga [14:24] Back === dandrader is now known as dandrader|afk === dandrader|afk is now known as dandrader [15:02] didrocks: can't notice any regressions in the new 6.0 branch [15:02] sil2100: neither do I [15:02] sil2100: I'll upload it I guess :) [15:02] didrocks: \o/ thank you [15:02] sil2100: thanks you! :) [15:02] now compiz SRU? ;) [15:02] and unity one? [15:03] didrocks: as for compiz SRU - we'll wait for Daniel to be back tomorrow to comment on the 2-3 additional fixes I asked for merging - if he says that these are valid SRU commits and get approved, we're almost done I think [15:03] didrocks: I prepared the packaging branch with updated patches [15:04] ok, the branches on the ML are all merged? [15:04] there is the software-center one [15:04] and the first super + W IIRC [15:05] didrocks: you mean the two unity ones for the software center? Not yet merged, but I think we can approve those [15:05] didrocks: the super + W fix is still a '?' [15:05] sil2100: there are 2 things about it [15:05] sil2100: there is the bug [15:05] about "windows flying away" [15:06] this is a just a bug and should be fixed [15:06] the second is under discussion :) [15:06] Ah, ok ;) [15:07] didrocks: ok, I'll look at this windows flying away bug then [15:07] didrocks: what about the software center fixes for unity? In your opinion, can those get into 5.0? [15:08] sil2100: yeah, once properly reviewed [15:09] Orajt [15:10] Shit, storm again, brb in a moment (again) [15:10] eh [15:28] Trevinho, andyrock, bschaefer: anyone of you around by any chance? [15:28] * Trevinho present [15:29] Trevinho: are you particulary busy right now ;) ? [15:29] sil2100: not yet [15:29] Since we would need someone from unity to review https://code.launchpad.net/~bilalakhtar/unity/5.0series-sru-software-center-integration-fixes/+merge/110214 and https://code.launchpad.net/~gary-lasker/unity/software-center-launcher-integration-tests-for-5.0/+merge/114241 [15:29] As we would like those to land in the nearest SRU [15:29] ok, I'll check them [15:29] sil2100, im around [15:29] bschaefer: ^ [15:29] * bschaefer got randomly logged out [15:29] :) [15:30] Trevinho, bschaefer: just looking for someone who might test these MRQs (or one MRQ, as the other are just tests), browse through the code and approve if all is OK [15:31] sil2100, yeah I can give them a test :), my day just started [15:31] Excellent [15:31] Thanks [15:31] np! [15:44] sil2100, pong [15:51] andyrock: hi! Trevinho and bschaefer are already dealing with my problem :) [15:52] sil2100, ok... I was watching the tv for le tour de france :) [16:01] Ok everyone, need to jump out to the bank now and for dinner - see you tomorrow! [16:14] om26er, can you update the status of this bug? https://bugs.launchpad.net/unity/+bug/962395 [16:14] Ubuntu bug 962395 in unity (Ubuntu) "drive icon disappears from unity launcher while still mounted" [Medium,Fix released] [16:14] I mean adding unity 5.0 and Ubuntu (Precise) [16:14] :) [16:15] andyrock, looking [16:17] om26er, thank you [16:17] andyrock, done ;-) === dandrader is now known as dandrader|lunch === dandrader|lunch is now known as dandrader === dandrader is now known as dandrader|afk === dandrader|afk is now known as dandrader === yofel_ is now known as yofel === alecu is now known as alecu86 === alecu86 is now known as alecu === salem_ is now known as _salem