[04:52] any ubuntuone core teamers up? [08:37] Good morning all! :) [08:50] morning all! [09:58] mornign [09:58] mandel: have a good weekend :) [10:16] czajkowski, so so :) [10:16] czajkowski, ran a lot hehehe [10:19] I'm sure! [10:20] mandel: do you happen to know if there are any plans to make the web U1 more useful? Ie. Under files/photos being able to sort the pictures by dates or size/name ? [10:21] czajkowski, yes, there are works to change the web, when, no idea [10:21] cool wont report the bug so [10:21] czajkowski, but I know that you can ask beuno about it [10:21] czajkowski, do report the bug :) [10:21] czajkowski, maybe something was forgotten [10:21] I have OODLES of pictures due to phone uploading them automatically which I love, but no way to sort them now [10:22] aquarius: ^^ [10:22] czajkowski, maybe JamesTait can give us some info ;) [10:22] mandel: I'll end up pinging everyone now at this rate :) [10:22] maybe in #canonical though.. [10:22] czajkowski, ask in #u1-internal more info is usually found there [10:23] ah well tis a public question I dont mind waiting to have the chat here. thanks though [10:23] czajkowski: Hi! :) [10:23] JamesTait: HELLO! [10:25] czajkowski: There's always something happening in the web UI. :) [10:25] can it be made nicer :) [10:25] czajkowski: I think the focus of our attention at the moment is more performance, though. [10:26] JamesTait: http://twitpic.com/a8lkd0/full thats only 1/4 of a page [10:27] I love U1 on my phone for files! it's brilliant, and I love the way I now have a back up of my pics. But not being able to make sense of all them ther on the web is a bit frustrating as I delete some on my phone and spring clean it sometimes. I need to be able to sort through the colums so I can update it there also [10:27] czajkowski: There's an awful lot going on behind the scenes at the moment which will make the web UI more responsive, and enable us to develop more "value-add" services around people's files and other synchronised data. [10:28] great stuff [10:28] thanks [10:28] Like re-enabling Facebook contact sync, for example. ;) [10:34] am still trying to work out how to get my phone to use the pictures from Fb it used to on old phone, but not this one. Which means I'e no clue when people ring who Im talking to as useless with faces/names [10:56] good morning [11:02] ralsina, ping! are you here?? we have a mumble with lisettte if you can [11:13] hello gatox, I am starting mumble [11:14] sorry I'm late, had to go to a bar [11:14] ralsina, no problem! [11:47] ralsina, early drinking ;) [11:48] hola mandel! [11:48] mandel: computers are driving me to drink [11:48] * ralsina waits for google's driverless cars for that joke to work [11:50] ralsina, hehehe [11:50] ralsina, I know the feeling :) [11:51] ralsina, do you feel able to do a review? [11:52] mandel: sure [11:52] ralsina, superb! here it is: https://code.launchpad.net/~mandel/ubuntuone-client/unify-processors [11:53] mandel: looking [11:53] ralsina, I'm so close to get these things landing today :) [11:53] mandel: said the terrorist in the jet [11:53] ok, bad taste [11:53] ralsina, lol [11:54] ralsina, my taste [11:54] ralsina, but yeah, proposing the changes for the code that allows to pass the monitor via command line using --fs_monitor=default or --fs_monitor=daemon [11:54] To compensate http://icanhascheezburger.files.wordpress.com/2012/07/funny-pictures-cyoot-kitteh-of-teh-day-look-at-me-not-crying-over-spilt-milk.jpg [11:54] yay [11:56] mandel, use items insteadof iteritems for python3 compatibility [11:56] or at least for not-more-incompatibility [11:56] ralsina, where did I use that? [11:57] mandel: line 26 of the diff [11:57] ralsina, can you add that in the comment? I did a move from one to another so is possible old code [11:58] mandel: there [11:58] is there something broken in your bzr mv? ;-) [11:59] oh, not a mv, just a move-out [11:59] ok, other than that it looks good on a quick code review [11:59] ralsina, yes, I was moving part of the code out of a file to make the import nicer [12:00] ralsina, is later used to have more than one implementation on darwin and not re-implement the notifier [12:09] ralsina, question, items is present in python2.6? and which is the latests python we support? [12:09] mandel: items is in 2.4 or so [12:09] great! [12:09] mandel: it's just that it's slightly less efficient because it's not a generator [12:11] ack [12:12] ralsina, I'm running the tests, I'll push asap and will let you know [12:17] * mandel wonders why or tests are sooo slow [12:18] alecu, please let me know when you are here [12:20] have to go back to the mothership [12:20] will be back online in 15' or so [12:32] ralsina, change pushed [12:47] mandel: re-looking [12:47] holas [12:48] dobey, buenas! [12:49] I'm off to have lunch :) [12:49] bbl [12:49] * mandel lunch [12:50] mandel: buen provecho [12:51] dobey, gracias! ha este paso hablaras espanol todo el rato :) [12:52] heh [13:00] hopefully can get all these releases done today, and done quickly [13:12] brb... need to restart! [13:31] mandel: +1 === zyga is now known as zyga-afk [13:39] hrmm, dailies broken for dirspec on natty/lucid now though, because of python3 stuff [13:49] good day, sunshine! [13:49] gatox: ehlo! [13:49] alecu, hi [13:49] alecu, do you have 5 min to mumble? [13:49] gatox: for you sir? [13:49] gatox: always! [13:49] alecu, :D thx [13:50] on mumble! [13:51] * mandel back [13:51] ralsina, thx! [13:54] dobey: it has BEEN. For over a WEEK [13:54] weak. [13:59] he [14:08] alecu, do you think you will have time to finish the review for https://code.launchpad.net/~mandel/ubuntuone-client/fsevents-daemon/+merge/114836 [14:09] alecu, sorry for begin a PITA but is blocking some other branches :) [14:29] ralsina, last branch regarding fsevents on darwin proposed: https://code.launchpad.net/~mandel/ubuntuone-client/daemon-options/+merge/115354 if that pass we are in a situation in which we can run u1 using the fsevents work from gatox or the daemon [14:29] the default is the fsevents one but we can talk on how to integrate this with the installer work [14:29] mandel: am on call (for a change) but will look at it [14:30] ralsina, thx [14:30] brb, need to run an errand. [14:30] briancurtin, are you dealing with the broken test on windows? [14:30] mandel: can you write the commit message in the standard format ? Like " - Added command line option to choose filesystem monitor (LP:1234567)." [14:30] ralsina, do you have a couple of minutes to mumble?? alecu and i are already there [14:31] ralsina, is there a bug number? [14:32] ralsina, I'll create a bug [14:32] mandel: didnt know they were broken. i guess i need to set a notification to watch u1-internal [14:33] briancurtin, you can add one in the irc client to tell you when jenkins cries :) [14:33] briancurtin, if you are not I can take care of it, seems like a unicode error.. which is weird 'cause we should have not touched anything regarding the config [14:34] gatox: I just finished 90 minutes of mumble, I'll be there in 2' [14:34] mandel: either way is fine with me. i'm working on making dirspec tests work with buildout but i can switch to this unicode thing [14:35] briancurtin, I'll take care of it then, it should not be too much work and I don't like to have broken tests :) [14:40] gatox: I [14:41] 'm back [14:41] alecu, gatox: mumble then? [15:02] me [15:02] me [15:03] me [15:03] me [15:04] meh === zyga-afk is now known as zyga [15:05] me-otp [15:05] me [15:05] me [15:06] briancurtin: go [15:06] DONE: trying to make sure i get unicode correct [15:06] TODO: finish up this dirspec/buildout thing, unicode [15:06] NEXT: ralsina [15:06] DONE: manuel 1-1 call, design call, pre-mgmt-call call, mgmt call, alecu+gatox call, gatox+lisette call, tech leads call, see a theme here? design reviews, reviews TODO: more 1-1s? more reviews, etc. BLOCKED: no NOTE: starting vacation tomorrow if big boss approves , will be around anyway in a limited role NEXT gatox [15:07] DONE: [15:07] Mumble and mumble, reviews, read menu docs. [15:07] TODO: [15:07] Fix branch with refactor. Start working on the indicator menu. [15:07] BLOCKED: [15:07] No [15:07] COMMENT: [15:07] vacation from July 23 to July 31 [15:07] thisfred, go [15:07] DONE: investigation into parser generators that work with C and Python. Gave up on that for now TODO: implement combine mapping BLOCKED: no NEXT: dobey [15:07] DONE: reviews, fix up dirspec python3 branch from reviews, SRU verification, holiday [15:07] TODO: releases/uploads, investigate twisted-less dev-tools, work on some reorg to drop ubuntuone-installer for good, finish SRU verification poking [15:07] BLCK: None. [15:07] alecu: go [15:08] DONE: discussed dbusmenu with charles, and then with gatox and ralsina, worked on the fixes requested in review for the upstream twisted bug that opened spurious consoles on windows [15:08] TODO: walkthru statusaggregator with gatox, do mac reviews, more twisted, more py3k [15:08] BLOCKED: no [15:08] NEXT: mmcc [15:08] DONE: reviews, symlink packaging, config file debugging [15:08] TODO: more reviews, finish symlink .app, mb help fix dirspec jenkins [15:08] BLCK: none [15:08] NOTE: Still want to discuss ubuntu-sso-ssl-certificate-qt launching [15:08] NEXT: mandel [15:08] DONE: Proposed all branches to finish the events work. [15:08] TODO: fix bug 1025694. Get reviews. [15:08] BLOCKED: no yet reviews are a must [15:08] Launchpad bug 1025694 in Ubuntu One Client "Config test failing on windows" [Medium,In progress] https://launchpad.net/bugs/1025694 [15:09] mmcc: let me know if you want to mumble re: ubuntu-sso-ssl-certificate-qt [15:09] mmcc, what is wrong with jenkins? [15:10] mandel, it needs to get a new dirspec - the changes we just made in u1-client require dirspec trunk [15:10] mmcc, told you last night I fixed it :) [15:10] mmcc: the tl;dr about ubuntu-sso-ssl-certificate-qt is that we are not using it right now, and we won't be using it in the foreseable future. [15:10] mmcc, should be in the backlog, around my 10 m or something like that [15:11] mandel: oh, great then. I thought you said you knew how, didn't realize it was fixed already :) thanks! [15:11] mmcc, no problem :) [15:11] alecu, ok - that explains how it could be broken and no one noticed :) [15:11] alecu, we might as well remove it, right? [15:12] mmcc: that's for allowing the user to use a broken cert. We should not provide broken certs ;-) [15:12] alecu: well, it should be unbroken by the sso-client branch I've put together, anyway, since it used the same API as the proxy-creds dialog [15:13] dobey: when you get a chance, the sso-client path finding branch needs your re-review: https://code.launchpad.net/~mikemc/ubuntu-sso-client/use-dirspec-get-program-path/+merge/114690 [15:14] mmcc: why "unbroken"? [15:14] mmcc: thanks, i thought there was one of those i needed to re-poke :) [15:16] alecu, i'm lookint at statusaggregator and it seems quite simple, so maybe we don't need the walkthrough [15:17] alecu, the way it is now, before my fix, utils/runner/qt.py spawn_program() would look at the sso-ssl-certificat-qt exe name and see that it doesn't end in .exe, and try to run it as 'python.exe ubuntu-sso-ssl-certificate-qt'. -- this was because there was code in ubuntu_sso/__init__ to add .exe to the executable names if sys.frozen=True, but that code left out the sso-ssl name. [15:17] ralsina: actually, it was for allowing the user to accept a broken cert from a proxy, iirc; and we don't provide those certs :) [15:17] alecu if you're really curious there's more detail in my comments here: https://code.launchpad.net/~mikemc/ubuntu-sso-client/use-dirspec-get-program-path/+merge/114690 [15:17] dobey: even worse, we don't support proxy certs ;-) [15:18] alecu, so, i'm going to count until 5.... and if you don't answer i'll assume you agree with me and have lunch... [15:18] :P [15:18] ok then! :D lunch for gatox \o/ [15:18] ralsina: right, it's a half complete feature, so i don't think that program ever actually gets launched, currently [15:19] dobey: yes. We should disable it from the bundles [15:19] ralsina: eh, i don't think saving the 30 bytes or whatever it is for that script is a big enough gain for the trouble to do that :) [15:20] dobey: on windows it's like 4k. And on mac before we do symlinks, it's probably 150MB :-) [15:20] ralsina: I'm doing symlinks now. still, I'll leave it out anyway [15:20] well, fixing the py2app problem on mac will fix that :P [15:21] * gatox lunch === gatox is now known as gatox_lunch [15:21] (gr72) Hey guys, i downloaded the ubuntu one app for android, and it keeps trying to use my google account affiliated with my android tablet. And it wont allow me to use the account I made from my browser. [15:21] karni: ^^ [15:22] gr72: Hi [15:22] gr72: What do you mean by "it keeps tring to use your google account" ? [15:22] gr72: or, should I say, what do you mean by "it wont allow you to use.." ? [15:23] gr72: You can log in with any account you want. U1F > Menu > Settings > Preferences > Advanced settings > Remove from U1, then log in with whatever e-mail you have registered on Ubuntu One [15:23] When i try to login fom the app, it automatically fills in my gmail e,ail that i have associated with my android tablet, and when i try to use the login that i regestered from my browser, it bringa up a window saying that ubuntu one doesnt support multiple accounts amd that i need to delete one [15:23] Ok ill try that. One se. [15:24] gr72: remove the Ubuntu One account from your Accnts & Sync, then upgrade Ubuntu One Files [15:24] gr72: Where have you downloaded the apk from? [15:24] Google play. [15:26] gr72: You have to remove your Ubuntu One account from the Accounts & Sync first. U1F does not support multiple accounts at that time. [15:27] Sorry,how do i upgrade an app? And yes i've removed it fom accounts and syn [15:27] This is my firat android. [15:27] gr72: If you downloaded it today from google play, you have the most recent version :) [15:27] Kk [15:27] gr72: I see, good for you! :) [15:28] gr72: I'll have to go away now for a call, but I'll be around soon. I'll answer any of your questions. [15:28] Thanks, i dislike apple, and android is open source. And thanks, ill try to login now. [15:30] dobey, did you see that failed merge? it's just those lint errors stopping it right? looks like most of them are it not finding devtools... [15:30] mmcc: ah crap. your branch failed to land [15:30] mmcc: yes, i know what the problem is. will fix it immediately after lunch [15:31] dobey ok cool, thanks!. let me know if you need me to do anything. [15:31] also [15:31] i hate pylint [15:31] +1 [15:32] pylint is broken, and we depend on a patch to logilab-astng (i think that's the right one of the cacaphony of libraries logilab provides and pylint requires), which fixes our use case, but presumably breaks other use cases. [15:32] i wish we could just move everything over to pyflakes [15:33] anyway [15:33] going to lunch. bbiab [15:33] karni: im now getting an authntication error saying that the login is unauthorized. [15:34] dobey: pyflakes has its own issues. I am using it in a personal project and when it gives you a bogus warning there's no way to disable it except twisting your code to its taste [15:35] gr72: Please go to Date & time settings of your device and make sure "Automatic" is selected, as well as time zone is properly set. [15:35] gr72: This "unauthorized" problem is almost always related to wrong time settings. [15:35] ralsina: so we can get those issues fixed; and much more easily than in pylint, which is way overly complex, and we have to patch anyway for it to work for us. [15:35] anyway, really lunch [15:36] dobey: bon appetit! [15:36] I dont have an automatic optin, btw this is samsung galaxy 10.1 tab. [15:36] *option [15:37] gr72: Could you make sure your tablet time is close to your computer time (hopefully it syncs with NTP) [15:38] I made the ubuntu one acciunt from my tablet. I dont run ubuntu at home, I run arch and qubesOS. [15:38] *account [15:38] ah I see [15:39] gr72: But you do have a clock there, don't you :) [15:39] gr72: Your tablet date/time is most probably off. That is the problem. [15:40] O.k. One sec. [15:43] karni: thanks. That worked. I had the wrong timezone and it was off by a minute. [15:44] gr72: hah :) the minute is nothing, but wrong timezone indeed doesn't help :) awesome! thanks [15:46] No, thank you. Another random question. Has ubuntu one thought about joining the 'cloud' computing area? Do you think adding an 'openstack' feature to ubuntu would help you any? === salgado is now known as salgado-lunch [15:53] gr7.. No. [16:06] dobey, ping === beuno is now known as beuno-lunch === gatox_lunch is now known as gatox === beuno-lunch is now known as beuno [16:40] I have a style question - we have a few deep module hierarchies like a/b/c/d, and in a/__init__ we do things like foo = a.b.c.d.foo -- is this just because it's nicer to import a.foo elsewhere or what? I can understand if it's something like platform.darwin.foo and we want to access it as platform.foo, but there are other cases where there's only one implementation and we still have a 'shortcut' assignment... [16:41] mandel: hi [16:41] dobey, hello! [16:41] mmcc: i'd say we shouldn't do that, in general. the specific platform-spcific abstraction case is special though, of ocurse [16:42] dobey, question, when you made the move away from ubuntu_sso.xdg you removed a call to native_path that was doing a decode('utf8') to the xdg_path, was that intended? [16:43] dobey, that is the reason why tests fail on windows [16:43] could just be a mistake very easy to solve :) [16:43] ack dobey, that sounds like a good rule of thumb to me... [16:43] mandel: yes. [16:44] dobey, yes intended, yes re-add it? [16:44] mandel: yes, intended. can you point to the specific call that was doing that, and is breaking that test, so i can look at the code? [16:45] dobey, sure, atm the failing tests is https://jenkins.errormessaging.com/view/Windows/job/ubuntuone-client-windows-test/93/testReport/tests.syncdaemon.test_config/UnicodePathsTestCase/test_get_config_files_path_encoding/ [16:46] dobey, the main issue is that if you don't do the decode it will be using the default platform one which is not utf8 but mbcs on windows [16:46] dobey, the native_path call was removed in rev no 1262.1.1 [16:46] mandel: right, i know where the test is. i'm more interested in which line of code changed [16:46] and why it's breaking that test [16:47] dobey, line 168 in ubuntuone/syncdaemon/config.py use to have: xdg_config_dir = native_path(xdg_config_dir) [16:48] dobey, you removed that line and the decode is not longer used [16:48] gatox: when you got dirspec tests to run on windows...uh, what did you do and how did you do it? [16:48] mandel: looking [16:49] briancurtin, install python-testtools and python-setuptools with easy_install, and then execute the test [16:49] dobey, is not a terrible problem, it was harder to find what changed :) [16:49] mandel, I left you a nice long comment about your daemon-options branch. two quick fixes and some discussion that you may decide to argue should be left to a different branch :) [16:50] dobey, I have a bug number for the issue: bug 1025694 [16:50] Launchpad bug 1025694 in Ubuntu One Client "Config test failing on windows" [Medium,In progress] https://launchpad.net/bugs/1025694 [16:50] mmcc, great, I'll take a look tom in my morning :) [16:50] gatox: after you installed those two things, you ran it from run-tests.bat or something else? [16:50] run-tests.bat [16:51] mmcc, I can fix all those in that branch with no problem, will be ready to a re-review tom :) [16:52] mmcc, better be consistent with the imports, and I have no problem in renaming the method [16:52] mandel: sounds good. I'll be sure to do the re-review tomorrow, since I'm gone for 3 days starting Thursday. [16:53] mmcc, ok, the I'm sure it will be ready :) [16:53] (although if it were an emergency I could look at things from the road over the weekend) [16:53] mandel: i wonder why that test didn't fail on linux [16:55] dobey, it has a skip :) [16:56] :( [16:56] dobey, not big deal, we found it and is a super easy fix [16:57] dobey, do we re-add the decode or do something else? [16:57] mandel: well, i am guessing the test is wrong [16:57] dobey, we should ask nessita AFAIK she wrote it [16:58] mandel: right, but that was before we had to consider python3 for anything, and could do stuff wrong and it would "work" [16:58] dobey, nop, blame just pointed to gatox and alecu [16:59] dobey, is late here, can you take over it? if not, can you write your though in the bug and I'll fix it tom [16:59] mandel: i'll look at it [17:00] dobey, ok, thx! [17:00] dobey, is not a major blocking bug but is a PITA to have jenkins failing due to it [17:02] all, EOD here, see you tom :) [17:03] bye mandel! [17:03] bye mandel [17:03] bye Madkiss [17:03] oh no [17:03] bye mandel [17:03] wtf [17:03] wrong tab-completion [17:03] Madkiss, gatox has tabbing diarrhea :P [17:03] jeje [17:09] porting ubuntuone-client to python3 is going to hurt. === salgado-lunch is now known as salgado [17:13] dobey, a lot [17:13] * mandel is not here.. [17:15] dobey: at least we have a reasonable schedule to spread the pain [17:16] heyyyy there we go. so weird that dirspec tests fail without testtools, but you get no indication that its because of a lack of testtools. ugh [17:16] dobey, alecu: can I pass that list of twisted bits? [17:16] ralsina: +1 [17:16] dobey, alecu: I am not sure I get what we should ask about for qtreactor === yofel_ is now known as yofel [17:17] ralsina: i'm sure there's more, but it's probably fine [17:17] briancurtin: you don't? [17:17] dobey: i already cleared the screen that had that error, but i believe it was an AttributeError that there is nothing called "tests" [17:18] i figured i would've gotten an importError or something more obvious [17:18] ralsina: qt4reactor is required to run the tests. make sure to not confuse it for the qtreactor thing that's in twisted, which is simply a very thin wrapper which requires extra stuff to be installed to use, and which only works with qt3 [17:18] ralsina: I think that we qtreactor would be needed to run the control panel et all tests on ubuntu [17:18] so, I ask that we get a working qt4reactor? [17:18] ralsina: right [17:18] let me do a draft then [17:18] well, we either need a working qt4reactor, or tests not using twisted/qt4reactor [17:19] dobey: is the second option feasible? [17:19] i think so, but i haven't had time to really look into it yet [17:19] ok, then [17:21] things have been a bit overly hectic this weekend, unfortunately [17:21] but we are moving closer to the target at least [17:24] anyway [17:25] hmmm endpoints and protocol is not for the windows IPC? [17:25] https://code.launchpad.net/~dobey/ubuntuone-client/fix-unicode-path/+merge/115398 should fix the test failing in jenkins issue [17:25] alecu, dobey ^ [17:25] ralsina: i don't know about those. but i just realized that you didn't list twisted.names, which we do need [17:26] dobey: adding names [17:29] i think endpoints/protocol are probably required by trial and reactor anyway [17:34] dobey: reactors we need would be SelectReactor, PollReactor, gireactor, and qt4reactor then? [17:35] ralsina: and anything else they depend on, yes. qt4reactor is separate and upstream doesn't really maintain it any more, though [17:36] yes [17:36] the "everything they depend on" is implicit :-) [17:37] dobey, alecu, facundobatista (@canonical this time) sent updated list. If you +1 it I will get back to the contractors [17:39] ralsina: right, but it's good to be explicit, especially in contracts. [17:39] dobey: will add it [17:40] i'm not sure there's a good/easy way to magically print out a dependency report though [17:40] you'd think somoene would have written such a tool for python already [17:40] dobey: there isn't one I know about [17:40] dobey: the curse of dynamic languages in action [17:41] dobey, alecu: could either one of you get me a rough estimate of how amazingly painful it would be to migrate out of qtreactor for tests? [17:41] ralsina: it's so easy to do some things, that nobody wants to solve the hard problems any more, even when they're easier to solve [17:41] just in case they refuse to port it [17:41] ralsina: i think it's something we should do anyway, and we can start doing in parallel even if qt4reactor does get ported [17:44] oh joy [17:44] so i tried to backport python-testtools to lucid; but it requires python-fixtures. so i tried to back port that; but it requires python-testtools… [17:45] dynamic languages are great for stabbing yourself in the face, recursively. [17:46] ralsina: if it helps any, i do have a branch of twisted on my machine right here, that has some of this stuff semi-ported already [17:49] ralsina: for instance, i have "python3 trial --help" working to print out the usage listing, but plug-ins aren't being loaded, so --help-reactors and such don't work (which means it doesn't run tests or anything) [17:50] dobey: there is a cornucopia of branches of twisted that portbits [17:51] dobey: I think yes, we should move away from qtreactor, but I am more concerned about timeframes [17:54] just caught up after being neck deep in py2app for a bit - if we need a dependency report, would the modulefinder stuff in py2app/py2exe be useful? [17:54] right [17:55] ralsina: moving away from qt4reactor sounds hard...we would have to move our sso and u1cp UI tests out of trial too. [17:55] mmcc: yes except that I want a list excluding what we use only on windows nd not on ubuntu [17:56] ralsina: ok, yes, not simple to do automatically [17:56] ralsina: porting qt4reactor to python3 sounds much more easy, as it's only one file. [17:56] alecu: specially if it's mainly for tests [17:57] it should not work any worse [17:57] dobey, alecu: facundo just added a few modules, doublecheck? [17:58] ralsina: qt4reactor depends on some twisted modules, so we may ask for them if they don't commit to porting qt4reactor. [17:58] twisted.internet import posixbase and twisted.python.runtime import platformType, platform [17:59] I'll just ask for qt4reactor and wait for them to refuse [17:59] perfect. [17:59] or not, if we are lucky [18:00] alecu: those modules are required for the gireactor also [18:00] great then. [18:00] hrmm, actuall, i guess platformType and platform from runtime might not be [18:00] but i think other stuff from runtime is [18:14] * gatox hates when something break for a little change and have to start debugging something that was ready....... ¬¬ [18:15] lunchtime, inching closer and closer to working bundle with symlinks to shared code... lots of fiddly bits [18:26] dobey, review done and approved branch because is a no brainer [18:27] mandel: thanks [18:27] dobey, no problem, also double checked that it work in the jenkins instance :) [18:27] mandel: well, when i enabled the test on linux, it failed with the same error as on win :) [18:28] that test should never have been skipped on linux [18:28] dobey, he, I wonder why it was.. [18:28] mandel: well, see the comment in the @skipIfOS line i removed there :) [18:29] dobey, yes, but it did not hurt to run it, right? [18:29] mandel: though i don't think that makes any sense either; and dirspec uses bytes everywhere now (thanks to the py3 port exposing various unicode issues) [18:29] mandel: right, running it wouldn't have added any significant overhead or extra time to the tests run [18:30] dobey, there must be a reason why that code was added, nevertheless when ever we do the py3 move everywhere we are going to have lots of 'stupid' code like that one [18:31] mandel: yeah, i was going to fix it the right way, but then realized that might just break more stuff elsewhere in syncdaemon right now [18:31] so the python2 way will suffice for now [18:31] dobey, probably, it could leak a unicode file inside the state machine and we will have a number of failures sometimes [18:32] if we had only chosen to use unicode from the start.. [18:34] mandel, dobey: consider it as a chance to fix stupid code [18:34] dobey, I hate pylint, skipIfOs is not used, you will need to fix that [18:35] ralsina, he, I'm not such a positive person :P [18:35] mandel: ah [18:36] dobey, happens for not fixing lint on windows.. [18:36] dobey, I should do something about that [18:36] maybe not in this life [18:36] ok, I'm off again, see you all tom [18:37] well, u1-client isn't using pylint [18:37] it's using pyflakes :) [18:37] so it should be usable on windows [18:41] * briancurtin lunch [18:46] I am going to take a long break now. Will be back much later. Mail me for anything! [19:01] alecu, this one is ready for review: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/darwin-tests-refactoring/+merge/113289 [19:03] * briancurtin back [19:12] wow. i didn't realize askubuntu.com was so political [19:22] back from lunch… [19:42] brb, need to run for a bit. === daker_ is now known as daker === technovi- is now known as technoviking === zyga is now known as zyga-afk [20:05] eod for me....... see you tomorrow people! [20:15] need to run to the pharmacy, back shortly [20:32]