[00:42] I thought I could click on 'Private: Some' on a +sharing page to remove access. :-( [00:48] StevenK: You can [00:48] wgrant: Except it doesn't work on qas [00:50] StevenK: Hm, but the FF is enabled... [00:50] Oh [00:50] StevenK: You're trying on launchpad? [00:50] flacoste owns that on qas, rather than ~launchpad [00:50] So you can't edit it [00:50] Ah [00:51] webops: could you please reassign https://launchpad.net/launchpad from ~flacoste to ~launchpad? [00:51] Bah [00:51] https://qastaging.launchpad.net/launchpad [00:51] Hahahaha [00:52] wgrant: "No items matched "~launchpad" [00:52] hloeung: Drop the ~ [00:53] wgrant: done [00:53] Indeed, thanks. [00:53] StevenK: Try again? [00:53] Right, now it has edit icons and such [00:54] Before, the text were links, which gave the impression [01:00] wallyworld: You haz QA [01:01] Not that it matters [01:01] yes, will do it soon [01:54] wallyworld, wgrant: Either of you want to review https://code.launchpad.net/~stevenk/launchpad/auditor-for-packageupload/+merge/116180 ? [02:05] StevenK: ಠ_ಠ ಠ_ಠ [02:06] AuditorClient.recieve is awful [02:06] One doesn't compose query strings using string formatting operations. [02:06] Also, consider using lazr.uri to compose the rest of the URL [02:07] >>> u = lazr.uri.URI(scheme='http', host='foo', port=1234, path='/') [02:07] >>> u.append('log/').replace(query='somequery') [02:07] URI('http://foo:1234/log/?somequery') [02:08] Also, datetime.now() is local time, which is wrong [02:10] wgrant: I didn't know about lazr.uri, but it doesn't seem like it will help much, given the URLs for auditor are simple. [02:10] wgrant: If not string formatting operations, then what? [02:11] >>> urllib.urlencode([('correct=encoding', 'is&good?')]) [02:11] 'correct%3Dencoding=is%26good%3F' [02:16] wgrant: http://pastebin.ubuntu.com/1105753/ [02:17] Improved. [02:17] But still not good? :-P [02:29] wgrant: Diff updated, makes use of urlencode rather than '&'.join() and datetime.utcnow() [02:46] StevenK: Have you discussed all this with lifeless? [02:57] wgrant: He just gave his 2 cents on the MP itself [02:57] So I'll be refactoring after lunch [03:01] wgrant: But thanks for the hints about making use of urlencode. [03:02] StevenK: In general if you're using string formatting to produce a machine-readable string in a format that you didn't design yourself you probably have a terrible bug [03:11] intel should quit the wifi chip business. [03:16] Or perhaps you should switch to Ethernet [03:19] yeah, no. [03:19] I'd rather whinge than fix the problem :) [03:20] Actually, cables around home are problematic when you have a 11month old. [03:20] +2 cats with cable fethishes. [03:20] Haha [03:20] Yes, I can remember having a cat with a cable fetish [03:20] Anyhow, I see my name in backscroll. [03:21] Pretty much every cable that the TV/DVD player/PS2 used had bite marks/exposed wiring on it [03:21] Except for power cables, she never bit those for some reason [03:27] so ... [03:27] whats 'this' under [03:27] 14:29 < StevenK> wgrant: Diff updated, makes use of urlencode rather than '&'.join() and datetime.utcnow() [03:27] 14:46 < wgrant> StevenK: Have you discussed all this with lifeless? [03:38] StevenK: ? [03:50] [12:57] < StevenK> wgrant: He just gave his 2 cents on the MP itself [03:50] [12:57] < StevenK> So I'll be refactoring after lunch [03:50] lifeless: ^ [03:53] wallyworld: What do you feel is the best way to customise vocab content? Sometimes we pass a context into the vocab constructor, but a couple of weeks ago I used a different method (constructing a SimpleVocabulary using a subset of the terms from the original vocab) in BranchEditView.setUpWidgets, since it's more a case of the view knowing which information types to show. [03:54] I'm not sure it's great to push that knowledge down to the vocab itself [03:54] Since InformationTypeVocabulary really shouldn't know about branches or bugs [03:54] But I want others' opinions. [03:54] wgrant: hmmm. the way i've used it based purely on the context [03:54] but i've also seen a SImpleVocab constructed [03:54] wallyworld: The context being the pillar? [03:55] yes [03:55] That works sometimes [03:55] But then you have artifact-specific restrictions [03:55] eg. a branch can't change to Private Security if it's stacked on a Proprietary branch [03:55] A bug can't be Proprietary if it affects 10 projects [03:55] so we need to do the construction at the point where we have the info to make a decision [03:56] so maybe a method on the moel [03:56] which the view can call to get the vocabl to use [03:56] or even a method on the service [03:56] Yeah, that's sort of the design I went for with Branch.information_type [03:56] There's Branch.getAllowedInformationTypes [03:56] yes, that sounds like something reasonable [03:56] And BranchEditView.getInformationTypesToShow reduces that further [03:57] And BranchEditView.setUpWidgets turns getInformationTypesToShow into a vocab [03:57] It seems to work pretty well [03:57] But I need to do something similar for bugs now [03:57] so the view is responsible for presentation logic, the model for model logic etc [03:57] Yep [03:58] wgrant: FTR, I've never liked the pattern of teaching the vocab stuff [03:58] getAllowedInformationTypes is used by transitionToInformationType to verify that the type is legal [03:58] and the model/service apis can also be used to validate for when called over the ws api [03:58] getInformationTypesToShow filters that list down to remove unlikely types from the UI [03:58] I mostly just need to work out how to integrate this with the JS choicesources, but I think it should be easy enough [03:59] for the choicesources, just put stuff in the json cache [03:59] Yeah [03:59] and then js can construct it [03:59] I'm just hoping they don't rely on having a registered vocab [03:59] But I don't think they do [03:59] the choice sources widget? [03:59] no [03:59] Yeah [04:00] you just pass an array of items [04:00] Ah, InformationTypeVocabulary isn't even registered in the first place, excellent. [04:00] wgrant: If you want to rip out the context stuff out of that vocab you would be my hero [04:01] StevenK: Ah. So I didn't see that - see under iwlwifi fail :) [04:02] StevenK: As for the MP, I didn't review it, just glanced at it and saw the client was inlined which seemed strange to me. [04:02] lifeless: Yeah, and I'm refactoring it out again [04:02] Well, half of it out [04:02] Some of it is LP specific [04:03] the config bits? [04:03] they are sure [04:04] lifeless: And object_to_enterpriseid() and object_to_enterpriseid() calls [04:04] Sigh, enterpriseid_to_object() even [04:04] right, thats a layer thing though I suspect ;) [04:06] I guess vocabs really want a filter() method that returns a subset. [06:24] TypeError: must be type, not classobj you make me very sad [06:26] You fail at new-style classes. [06:28] Obviously [06:30] wgrant: I thought it was just __metaclass__ = type and move on [06:30] Yes. [06:31] Hmmm, the egg didn't change. === almaisan-away is now known as al-maisan [08:04] good mornig [09:17] StevenK: morning any reason why your branch has never landed? https://bugs.launchpad.net/launchpad/+bug/790535 [09:17] <_mup_> Bug #790535: Distribution:+ppas timeouts < https://launchpad.net/bugs/790535 > [09:55] ccccccbgjgvchvctjfjjeluutgulchrvkjjhtftctfcc [09:55] ccccccbgjgvcugtgelehbubljkrlledibbfhgrjulcdd [09:55] ccccccbgjgvccbtrielunjgkdgvkhldctjkdvbkbfjhl [09:56] bah, sorry [10:43] czajkowski: Because it's not the right fix. [10:43] rick_h_: I know the feeling [10:44] czajkowski: monday monday [10:44] I think the fix is to delete Distribution:+ppas for being a crime against humanity. [10:45] StevenK: well possibly [10:54] adeuring: morning, did you get a chance to catch up on the branch from thurs/friday? [10:55] rick_h_: ummm. somewhat. [10:55] it's listed as needing qa and deryck rolled it back in 15661 [10:56] I really want to try to get the report a bug link landed, 15657, so wanted to bug you on that to see if we can clear it up to try to get a NDT [10:57] rick_h_: in that case, I'd prefer a rollback. The problem with the buildbot failure: the test call apply_async() -- when celeryd is at least suipposed not to run -- and a subsequent check if there is a message for the task queued fails: No messages at all. [10:58] adeuring: right, the rollback is in the queue from deryck on friday [10:58] i habe no clue how this can happen... [10:58] but is it ok then to just qa yours as qa bad for now? [10:58] and try to get through to the rollback for a NDT? [10:58] rick_h_no, deryck just disabled the test [10:58] ah, doh ok then [10:59] sorry, didn't realize that. === matsubara is now known as matsubara-afk [11:39] rick_h_, adeuring: Bug #1027103 [11:39] <_mup_> Bug #1027103: TestRunMissingJobs.test_run_missing_ready_does_not_return_results disabled due to spurious failure

< https://launchpad.net/bugs/1027103 > [11:39] Please revert ASAP if it needs it [11:39] wgrant: just saw the MP email on that one [11:39] wgrant: so in process === bac changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: - | Firefighting: - | Critical bugs: 4.0*10^2 === benji changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: benji | Firefighting: - | Critical bugs: 4.0*10^2 [12:11] gary_poster: coming [12:39] adeuring: Hm, did the rollback get bounced by PQM? [12:39] wgrant: its running thourgh ec2 right now. [12:39] adeuring: Oh, no point or time for that [12:39] lp-land [12:40] We can't deploy until it's landed, so even if there was a chance of failure we still lose nothing by landing it now. [12:40] ok, i'll try it... [13:01] Morning, all. [13:06] deryck: ello [13:33] adeuring, https://plus.google.com/hangouts/_/ceb51247bd8993e84395ae3e71619d1a725b8063?authuser=0&hl=en === slank` is now known as slank === slank is now known as Guest49605 [13:49] wgrant, hi there. Was there something actually qa-bad about adeuring's branch or are you reverting as a matter of conscious? or to get the deploy going, or something else? [13:50] deryck: Ah, adeuring said here that it should be reverted. [13:50] wgrant, ah, ok. Fair enough. Thanks! [13:52] gary_poster: what make/model headset do you have btw ? [13:52] czajkowski, Sennheiser...um...looking... [13:55] czajkowski, not sure, but Sennheiser PC 151 looks like newer version (mine does not have noise canceling microphone but looks very similar and the price of about $50 USD seems to match my memory) [13:56] gary_poster: cheers [13:56] adding to my wishlist [13:56] :-) cool [13:56] gary_poster: you're very clear on calls [13:57] yay czajkowski :-) [13:57] he also enunciates well which helps no doubt [13:58] heh [13:58] this is rather true, I however speak way too fast and live over a flight path, not a good combination [13:58] it's all the many years of singing training [13:58] Over a flight path? Impressive. [13:58] heh [13:58] * czajkowski peers at wgrant [13:59] wgrant: lots of planes fly over the house reguarly, hows that mr. pedant :) [13:59] lol [13:59] Aw [14:00] And there I was thinking that it was cool that you lived in the stratosphere. [14:01] wgrant: one day we're going to meet and I'm going to be in throwing distance of you! [14:01] he moves quickly [14:01] probably can dodge well [14:01] no actual experience from throwing end though === al-maisan is now known as almaisan-away [14:33] Hi, I'm editing all the launchpad templatefiles to comply with the requirements of canonical I change all icons and the name Launchpad, now am I allowed to have launchpad in the css and new imagefilenames, or do I need to change that as well ? [14:34] en thandige is datk ook ni kan zien of een file edits nodig heeft of ni omda zo goed als elke file i18n:domain="launchpad" bevat [14:34] sorry, wrong channel for that last (dutch) message [14:46] Bert_2, I don't honestly know, but we could find out. I'm sure the intent is to protect branding of the launchpad site. So I don't think anyone will care if this is css class names and such internal to the site. [14:47] mrevell: do yo happen to know re Bert_2 request [14:48] I expect deryck is correct. [14:48] But IANAL. Bert_2 If you email help@launchpad.net we could forward it to our legal team. [14:50] perfect, I'll email to help@launchpad.net then [14:50] thx a lot, let's hope the new logo, icons, and name will be enough, cause manually editing each template file is already taking a lot of time :p [15:00] k, you've got mail ;) === cr3_ is now known as cr3 === cr3 is now known as Guest64961 === matsubara-afk is now known as matsubara [16:18] benji: do you have time to review https://code.launchpad.net/~sinzui/launchpad/adapt-subscription-to-pillar/+merge/116095 [16:19] sinzui: sure, if after lunch is fine [16:19] It is, thank you === Guest64961 is now known as cr3 === cr3 is now known as Guest9828 === salgado is now known as salgado-lunch === Guest9828 is now known as cr3 === cr3 is now known as Guest1039 === deryck is now known as deryck[lunch] [17:51] sinzui: your branch looks good [17:52] thanks benji [17:52] my pleasure === almaisan-away is now known as al-maisan [18:17] benji: couple of reviews your way please. Pre-landing bugfix with JS gardening, no real changes, just cleaning up some LoC to get a credit for the bugfix coming later. [18:17] https://code.launchpad.net/~rharding/launchpad/tab_client/+merge/116329 and https://code.launchpad.net/~rharding/launchpad/garden_client/+merge/116330 [18:17] rick_h_: cool, I'll take a look [18:18] ty much! === Guest1039 is now known as cr3 === cr3 is now known as Guest88086 === salgado-lunch is now known as salgado === deryck[lunch] is now known as deryck === matsubara is now known as matsubara-afk === al-maisan is now known as almaisan-away === bac-lunch is now known as back === back is now known as Guest15663 === bac is now known as Guest27230 === Guest88086 is now known as cr3 === cr3 is now known as Guest21652 [19:43] benji: Thanks for the review :) [19:43] my pleasure [19:44] o/ === bradcrittenden is now known as bac [19:47] o/ lifeless [20:05] deryck: even though I have bugs.dynamic_bug_listings.enabled, I still don't see the sorting losenges and config wheel. Any idea what I need to do? [20:06] abentley, hmmm, weird. thinking.... [20:07] abentley, I wonder if some other flag is conflicting and needs turning off. Something off in production by default but on in dev? [20:07] deryck: err, seeing "ReferenceError: YUI is not defined" [20:07] abentley, ah, js build issue then. [20:11] deryck, rick_h_: Did make clean; make run, still getting ReferenceError: YUI is not defined. [20:12] abentley: not sure. You have build/js/yui? combo load is on by default now so should be looking in there [20:12] abentley, I would think make run should call make jsbuild, but might be worth trying a make clean_js && make jsbuild [20:12] abentley: check the network and see if it has a combo load call and if so what came back from that [20:13] rick_h_: I do have build/js/yui. It has a yui-3.3.0 symlink that is broken. [20:14] abentley: ok, so make clean_buildout and make again [20:14] * rick_h_ dbl checks clean_buildout [20:14] abentley: yea, that should hopefully fix your symlink? Should be linked from the dep cache [20:23] rick_h_: The link is still broken. It points at ../../../../build/js/yui-3.3.0, but that doesn't exist. ../../../../build doesn't exist. [20:24] ../../../../ is the directory containing my launchpad branch. === salgado is now known as salgado-afk [20:25] abentley: so you don't have build in the root LP branch dir? along with bin, lib, etc? [20:25] rick_h_: I do. [20:25] rick_h_: It's looking one parent directory above that. [20:27] rick_h_: My working tree is at ~/launchpad/colo, but it's looking for build in ~/launchpad. [20:27] abentley: looking for what originally creates the build directory itself, sec [20:29] that's buildout that creates the dir and sets up the YUI 3.3 symlink that the combo-rootdir then links to build/js/yui [20:29] abentley: check out the [yui] block in buildout.cfg and see which command isn't working right that causes you to not have the right path [20:29] abentley: you still in dev mode? In production mode it setups up /srv/launchpad.net for the build dir [20:30] rick_h_: still in dev mode AFAIK. [20:31] abentley: yea, so check out the buildout install yui and see if it's erroring on something in your env and if that's correct then combo-rootdir comes in and symlinks to the build dir specified which is just 'build/dir' from the calling point [20:32] rick_h_: I don't really know what to look at. [20:33] abentley: so in the buildout [yui] block should be a series of commands that extract yui from the download-cache and setup the point for the symlink into build/js/yui-3.3.0 [20:35] rick_h_: I have that, and a yui symlink that links to yui-3.3.0. [20:35] ok, and that's an ok symlink? [20:36] rick_h_: Yes. [20:36] abentley: then run ./bin/combo-rootdir build/js and it should get you a good symlink into the build/js/ directory [20:36] rick_h_: The broken symlink is Inside yui-3.3.0, and is named "yui-3.3.0". [20:37] hmmm, wtf [20:37] your buildout.cfg is still pulling download-cache/dist/yui-${:yui_version}.tar.gz right? [20:40] rick_h_: http://pastebin.ubuntu.com/1107124/ [20:45] abentley: ok, I see something strange [20:46] so in build/js/yui-3.3.0 I see all of YUI and a symlink that's ../../../../build/js/yui-3.3.0 i'm not sure where it came from [20:47] rick_h_: So if you see it, it's not what's breaking me. [20:47] right [20:48] rick_h_: In the network view, I see a 404 for https://bugs.launchpad.dev/+combo/?yui/yui/yui-min.js&lp/meta.js&yui/loader/loader-min.js [20:49] do you have the build/js/lp dir? [20:49] rick_h_: yes. [20:50] is the meta.js in there? [20:50] rick_h_: yes. [20:50] if so can you get just https://bugs.launchpad.dev/+combo/?lp/meta.js [20:50] without a 404? [20:50] rick_h_: No. [20:51] ok, so you don't have convoy setup in apache then [20:51] rick_h_: http://pastebin.ubuntu.com/1107142/ [20:52] right, the apache config should be updated to not proxy +combo urls and instead serve via convoy [20:53] abentley: look in configs/development/local-launchpad-apache and diff against your apache config [20:54] rick_h_: I just ran "make install", and that's giving me plausible results. [20:54] rick_h_: Yes, all looks good now. [20:55] abentley: ok awesome === benji changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: - | Firefighting: - | Critical bugs: 4.0*10^2 [21:46] evening [21:47] hello, ive seen launchpadblog entry about career opportunity pointing here so i can see what you guys do, so i've decided to pop in [21:48] hi czajkowski [21:51] Ergo^: hiya, which role? [21:52] czajkowski, http://blog.launchpad.net/were-hiring/were-hiring-software-engineers-to-work-on-cloud-projects-in-canonical [21:52] Ergo^: ah that one. [21:52] Ergo^: well if you have questions many of the team are on here, gary_poster might also be able to help [21:52] or you can apply via the link in the post [21:54] ah, ok, i was thinking i would fit the role well, when do you guys plan to hire someone ? [21:55] my firstborn is supposed to be born this week so im not sure its right time to apply ;-) [21:56] gary_poster, hello gary, what pythonic web frameworks do you guys mostly use? [21:57] Ergo^: soon, he may not be around as it's possibly coming to his EOD [21:58] Ergo^: where are you based? [21:58] czajkowski, Poland, so its midnight for me [21:59] ah most of hte EU folks are well past EOD [21:59] sorry [21:59] czajkowski, no problem [21:59] i might try tommorow [22:00] earlier in the day might be bette [22:00] r [22:00] good night [22:00] night! [22:14] doh, just missed him. I know Ergo^ from the pyramid/pylons irc world