| rye | morning | 07:56 |
|---|---|---|
| JamesTait | Good morning all! :) | 09:01 |
| === zyga is now known as zyga-afk | ||
| alecu | morning, all! | 11:52 |
| === zyga-afk is now known as zyga | ||
| mandel | alecu, morning! | 12:30 |
| mandel | just got be leaving for lunch, alecu want to talk when I'm back about the fsevents ancestors bug? | 12:31 |
| alecu | mandel: sure | 12:31 |
| mandel | alecu, ok, I'll ping you when I'm back :) | 12:31 |
| * mandel lunch | 12:31 | |
| ralsina | morning! | 12:51 |
| dobey | mandel: don't set my update-2-0 branch back to Approved please. it won't land in tarmac. | 13:21 |
| mandel | dobey, ok | 13:34 |
| * mandel back | 13:34 | |
| mandel | dobey, so we should reject it, right? or is it going to be there waiting? | 13:35 |
| mandel | alecu, I'm back, we can talk about the ancestors stuff whenever you have the time | 13:36 |
| dobey | mandel: no, i think i'll have to land it by hand | 13:39 |
| mandel | dobey, oh, ok, if you have to do that, can you also take a look at https://code.launchpad.net/~alecu/ubuntuone-client/timestamp-autofix-1-6/+merge/82754 | 13:40 |
| mandel | dobey, do we have to land that? | 13:41 |
| dobey | we should. i will have to look at the older branches another day though. i need to do stable-4-0 releases today | 13:42 |
| dobey | mandel: you should only worry about branches that have 0 or 1 reviews really. :) | 13:42 |
| mandel | dobey, I know, but I see them and I want to get the things fix, is annoying to see that branch always there | 13:43 |
| mandel | alecu, can I have a review for https://code.launchpad.net/~mandel/ubuntuone-fsevents-daemon/remove-arc-fsevent/+merge/116433 ? | 13:44 |
| mandel | dobey, may I have a review for the following https://code.launchpad.net/~mandel/ubuntuone-fsevents-daemon/long-domain-socket/+merge/116269 | 13:44 |
| alecu | hello back, mandel. | 13:45 |
| alecu | let's mumble! | 13:46 |
| mandel | alecu, ok, launching the thing :) | 13:46 |
| mmcc | good morning everyone | 13:50 |
| mandel | alecu, bug #1012709 | 13:52 |
| ubot5 | Launchpad bug 1012709 in Ubuntu One Client "Add Watches to udf ancestors" [High,In progress] https://launchpad.net/bugs/1012709 | 13:53 |
| mmcc | brb, coffee | 14:04 |
| mandel | ralsina, 1-1? | 14:09 |
| ralsina | mandel: we had one like 3 days ago :-) | 14:09 |
| mandel | ralsina, yes, but since we usually have then on monday.. that is why I asked, we can skip it, only thing diff Iwas going to say is that I'll take a few days off to visit the family in mallorca | 14:10 |
| ralsina | mandel: ack | 14:10 |
| ralsina | mandel: yes, let's skip | 14:10 |
| mandel | ralsina, ok, I'll do the paper work on canonical admin later this night | 14:11 |
| ralsina | mandel: ok | 14:11 |
| mandel | mmcc, the branches regarding the arc have been updated | 14:20 |
| mmcc | ok mandel, I'll take a look today | 14:20 |
| mandel | mmcc, superb, thx! | 14:21 |
| thisfred | me | 15:00 |
| mandel | me | 15:00 |
| ralsina | me | 15:01 |
| briancurtin | me | 15:01 |
| mmcc | me | 15:02 |
| ralsina | alecu? | 15:03 |
| ralsina | dobey? | 15:03 |
| dobey | meh | 15:03 |
| ralsina | ok, alecu is last, go thisfred | 15:04 |
| thisfred | DONE: https://code.launchpad.net/~thisfred/u1db/ergo-sum/+merge/117186 | https://code.launchpad.net/~thisfred/u1db/iterate-over-list-of-dicts/+merge/117120 TODO: wrap up cosas example app | documentation BLOCKED: no NEXT: mandel. | 15:04 |
| mandel | DONE: Update all arc MPs to follow reviews. Refactored communication code so that it can be reused for the jenkins testing daemon. | 15:04 |
| mandel | TODO: Finish the jenkins testing daemon so that we do not need to run tests as root. Canonical admin paper work. | 15:04 |
| mandel | BLOCKED: no | 15:04 |
| mandel | ralsina, please | 15:04 |
| ralsina | no notes yet, sorry | 15:04 |
| ralsina | DONE: chased contractors, catchup, weekly team call | 15:04 |
| ralsina | TODO: start actual work, contractor chasing | 15:04 |
| ralsina | BLOCKED: no | 15:04 |
| ralsina | briancurtin: go | 15:04 |
| briancurtin | DONE: team call, unicode | 15:04 |
| briancurtin | TODO: unicode | 15:04 |
| briancurtin | NEXT: mmcc | 15:04 |
| mmcc | DONE: fixed new reactor import, gave up on test for that | 15:05 |
| mmcc | TODO: darwin cert location, darwin dirspec paths, first-run code | 15:05 |
| mmcc | BLCK: none | 15:05 |
| mmcc | NEXT: dobey | 15:05 |
| dobey | DONE: finish dev-tools refactor, reviews | 15:05 |
| dobey | TODO: releases, fix review issues in refactor branch, reorg to drop ubuntuone-installer for good, SRUs for lucid/natty/oneiric | 15:05 |
| dobey | BLCK: None. | 15:05 |
| dobey | alecu | 15:05 |
| ralsina | Comments? | 15:08 |
| ralsina | since alecu seems to be away | 15:08 |
| alecu | me! | 15:08 |
| alecu | writting notes! | 15:08 |
| ralsina | ok, let's wait | 15:08 |
| * ralsina taps fingers | 15:09 | |
| * ralsina looks at his wrist where a watch could be | 15:09 | |
| * ralsina whistles | 15:09 | |
| alecu | DONE: team meeting, debugging of #1029450, reviews TODO: reviews for mandel, back to py3k | 15:09 |
| ralsina | ok, I'll stop now ;-) | 15:09 |
| alecu | BLOCKED: no. EOM | 15:09 |
| ralsina | EOM it is | 15:09 |
| mmcc | so FYI ralsina, I gave up on that 'fail if we import reactor in the wrong place' test, because it looks (at least in this case) like the code under test is imported before the test module is imported, so it's not clear how to hook it in… | 15:11 |
| ralsina | mmcc: hmmm ok | 15:11 |
| mmcc | er, "not clear how to add a hook to catch the import, since it's already imported. " | 15:11 |
| ralsina | mmcc: I suspect there is no simple way to test that since the tests use a reactor too | 15:11 |
| mandel | ralsina, mmcc , exactly, u1trial does the reactor import so you have a problem there | 15:12 |
| ralsina | So to test this it would have to be a script that does what the windows main does, not a "test" | 15:12 |
| mmcc | ralsina: yes. If the test script didn't use reactor we could just import and check sys.modules. I thought about running a separate process inside the test to just try importing, but it was getting late. I'm happy to revisit that today if you think it'd be worth the time | 15:12 |
| ralsina | mmcc: probably not worth it :-( | 15:13 |
| mmcc | ralsina: no, all it has to do is "import platform", then check sys.modules for reactor | 15:13 |
| ralsina | mmcc: how about a script that does exactly that and running it at the end of run-tests ? | 15:13 |
| mmcc | or, really, import 'platform.everything-but-filesystem_notifications'… | 15:13 |
| mmcc | ralsina: I'm fine with that. I even know where to add it to the makefile | 15:14 |
| ralsina | mmcc: :-) | 15:14 |
| ralsina | mmcc: get dobey's or alecu's opinion for confirmation | 15:14 |
| ralsina | mmcc: but I would really like to have a test for that since we have broken it, like, 4 times already | 15:15 |
| alecu | I really like the idea of a script that tests that the reactor was not imported at module level in any of our code. | 15:15 |
| alecu | mmcc: +1 | 15:15 |
| mmcc | ok to use 'banner' to print the error message for whoever breaks it? | 15:15 |
| alecu | mmcc: then we'd need to include a "banner.exe" in our source tree :) | 15:16 |
| ralsina | mmcc: and use ferret-over-ip to steal their cookies | 15:16 |
| mmcc | alecu: worth it! | 15:16 |
| ralsina | mmcc: you know the problems about finding binaries cross-platform ;-) | 15:16 |
| * mmcc googled "native python banner", found nothing. | 15:17 | |
| mmcc | ok, extra test script coming up | 15:18 |
| ralsina | mmcc: http://www.noah.org/wiki/banner | 15:20 |
| dobey | cowsay | 15:21 |
| mmcc | ralsina: nice! :) | 15:22 |
| dobey | eww | 15:22 |
| dobey | "# This font storage format is not very efficient" | 15:22 |
| dobey | no kidding | 15:22 |
| ralsina | dobey: I am sure it could be worse, but will not be easy to find HOW | 15:22 |
| dobey | also, there's no real need to have such a thing here | 15:23 |
| dobey | also | 15:23 |
| dobey | YAY COPYRIGHT WITH NO LICENSE | 15:23 |
| ralsina | dobey: this conversation is a joke. We are not putting a copy of banner in devtools | 15:24 |
| ralsina | dobey: don't panic! | 15:24 |
| mmcc | dobey: no, no need for a banner. Especially once we get those remote controlled nerf rockets | 15:24 |
| dobey | i'm not | 15:24 |
| mandel | mmcc, can I have a review for : https://code.launchpad.net/~mandel/ubuntuone-client/clean-imports/+merge/116256 | 15:28 |
| mandel | dobey, ralsina, super easy review: https://code.launchpad.net/~mandel/ubuntuone-client/correct-namespace/+merge/116264 do you have time to take a look? | 15:28 |
| ralsina | mandel: sure | 15:28 |
| mandel | ralsina, thx | 15:29 |
| mmcc | mandel: yes | 15:29 |
| mandel | mmcc, thx to you too :) | 15:29 |
| ralsina | mandel: looks good to me, I suspect there is no way to write tests for this :-) | 15:37 |
| dobey | ralsina: required imports are self-testing :) | 15:38 |
| ralsina | dobey: exactly | 15:38 |
| dobey | and i need to get lunch and ship back my doa raid enclosure. :-/ | 15:39 |
| dobey | bbiab | 15:39 |
| mandel | ralsina, install the new version and run the already present tests ? :) | 15:39 |
| ralsina | mandel: ok, +1 ;-) | 15:39 |
| mmcc | mandel: +1 on your clean-imports branch | 16:29 |
| * briancurtin lunch | 16:29 | |
| mandel | mmcc, awesome, thx! | 16:36 |
| mandel | ok, EOD for me | 17:04 |
| mandel | see you all tom! | 17:04 |
| mandel | mmcc, tom we should talk about @property (retain) which allows you use autorelease in the init (I was doing some tests and found a mem leak) | 17:04 |
| mmcc | ok mandel, sounds good. | 17:05 |
| alecu | lunch and bank time for me. | 17:10 |
| briancurtin | before i set https://code.launchpad.net/~brian.curtin/ubuntu-sso-client/py3-unicode-part-2/+merge/116764 to "needs review" does anyone know why it's showing changes from the prerequisite branch inside the diff? i suspect that's going to be a PITA to anyone reviewing. it should only be around a 500 line diff and it depends on a 500 line branch, but they're both shown together | 18:09 |
| briancurtin | (i know i've complained about this before...haven't found any solution) | 18:09 |
| briancurtin | i also suspect that's going to be a PITA to complete the actual merge... | 18:12 |
| ralsina | briancurtin: no idea really, let me check | 18:13 |
| ralsina | briancurtin: it shows as a 500 line branch to me | 18:14 |
| ralsina | briancurtin: 594 lines (+106/-78) 13 files modified to be specific | 18:14 |
| briancurtin | ralsina: the diff i'm seeing on the MP is 1042 | 18:14 |
| ralsina | briancurtin: reload :-) | 18:14 |
| briancurtin | wtfffff | 18:15 |
| ralsina | surprise! It seems lunchpad recalculated at some point | 18:15 |
| dobey | heh | 18:16 |
| briancurtin | i wonder if it did the recalculation when i entered a commit message and description, because it was showing 1042 after opening the page in a fresh browser like 10 minutes ago | 18:16 |
| dobey | briancurtin: did you push a new revision about 15 min ago? | 18:16 |
| briancurtin | dobey: i pushed about 15 minutes ago but there was no changeset to push | 18:17 |
| briancurtin | er, no revision to push | 18:18 |
| dobey | hrmm | 18:18 |
| dobey | ralsina: https://code.launchpad.net/~dobey/dirspec/update-4-0/+merge/117317 easy peasy review | 18:24 |
| ralsina | dobey: looking... | 18:24 |
| ralsina | dobey: +1 because why not | 18:27 |
| dobey | awesome | 18:42 |
| mmcc | test script for reactor imports: https://code.launchpad.net/~mikemc/ubuntuone-client/add-no-reactor-test/+merge/117328 | 19:36 |
| * mmcc lunchtime | 19:39 | |
| === dduffey_afk is now known as dduffey | ||
| mmcc | dobey, can you be a little more specific about which certain things you're referring to in https://code.launchpad.net/~mikemc/ubuntuone-client/add-no-reactor-test/+merge/117328/comments/252306 ? | 21:39 |
| mmcc | I've added the unicode_literals import and fixed the print statement to be a function, and used the new string formatting syntax, but I'm not sure what else you might be referring to | 21:40 |
| briancurtin | mmcc: i don't think you pushed the unicode_literals or print_function changes | 21:43 |
| mmcc | briancurtin: no, not yet. Was just going to discuss first, but I'll go do that. | 21:44 |
| mmcc | done | 21:44 |
| mmcc | ish | 21:45 |
| dobey | mmcc: oh, you can use %-notation for string formatting | 21:48 |
| dobey | mmcc: so primarily the future imports is what i was talking about | 21:48 |
| mmcc | interestingly, python -3 is complaining about that code, giving the DeprecationWarning about CObject, on the line where I call real_import (line 63 of the script). real_import is from earlier: real_import == __import__ | 21:48 |
| dobey | mmcc: have you tried to run it under python3? | 21:49 |
| dobey | the test will obviously fail to import the syncdaemon stuff, but if there's anything wrong with the script itself, it should expose that | 21:50 |
| dobey | because i don't know what the deprecation warning means there :) | 21:50 |
| mmcc | dobey: I did run it under 3, but there's the issue of builtins vs __builtin__, what's the done thing there? should I do an 'try import builtins, except ImportError, import __builtin__? | 21:51 |
| mmcc | in other words, does it need to run in both 2 and 3? | 21:51 |
| dobey | it doesn't need to run in both now | 21:51 |
| dobey | but i think we should stick to at least print_function in new code, and unicode_literals where possible (since unicode is a huge and lumbering pain in python) | 21:52 |
| mmcc | ok, sounds reasonable. so, should I leave in the import of unicode_literals even though I'm not actually using bytes objects anywhere? | 21:58 |
| * mmcc was reading through the PEP again to try to be sure I'm right about that | 21:58 | |
| dobey | i think so | 22:01 |
| dobey | well, i guess it's not about bytes objects | 22:01 |
| dobey | bytes objects are still bytes in 3 | 22:01 |
| dobey | but str is not bytes in 3 | 22:02 |
| mmcc | right, and since I'm using str here, I don't need to write bytes literals. so I don't really need to import unicode_literals, I guess | 22:05 |
| dobey | well, if anyone else ever changes that code and has to do unicode stuff in there for some reason, having unicode_literals will catch problems | 22:07 |
| dobey | and if you aren't doing unicode stuff right now, it doesn't hurt anything | 22:08 |
| mmcc | ok, no prob. also, python3 didn't complain about the CObject deprecation when I ran it just now, after s/__builtin__/builtins | 22:09 |
| mmcc | ah, just saw your re-review. thanks. | 22:10 |
| briancurtin | mmcc: approved | 22:11 |
| briancurtin | and with that, i'm out. later everyone | 22:12 |
| dobey | later all, time to go! | 22:15 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!